Commit Graph

6525 Commits (352acecb402e99ffe6f027648950979fb9592cb5)

Author SHA1 Message Date
Steven Powell 3c125f10e9
Merge pull request #12972 from mpuckett159/bug/fix-docker-env-typo
Fix typo in help text for minikube docker-env command
2021-11-17 13:51:52 -05:00
Steven Powell c432ea13f1 update OldestKubernetesVersion to v1.16.0 2021-11-17 12:52:09 -05:00
Marcus Puckett d831158c0c Fix typo in help text for minikube docker-env
In the help text for the `minikube docker-env` command the suggestions for setting the docker command for Windows (cmd and powershell) don't work as output because if you don't pass the `--shell` flag, it adds a line at the beginning that will cause the cmd example to fail, and doesn't specify that you need to set the flag `--shell powershell` for it to work properly. I've updated the help text to provide a command that will work as expected for both shells.
2021-11-16 22:48:55 -08:00
Sharif Elgamal cf09e50b4e iterate through arguments 2021-11-16 09:24:33 -08:00
Sharif Elgamal 558ece4a8e no need to explicitly translate title, Fmt does it for us 2021-11-15 17:03:09 -08:00
Sharif Elgamal d8ec4704e4 support functions with multiple string args 2021-11-15 16:52:39 -08:00
Sharif Elgamal ea7bc858c7 allow for fmt.Sprintf in Advice text 2021-11-15 16:31:25 -08:00
Medya Ghazizadeh 8bd28a6599
Merge pull request #12933 from klaases/go2
update suggestion messaging for --no-kubernetes
2021-11-12 12:21:14 -08:00
Medya Ghazizadeh 80b4e238cf
Merge pull request #12900 from AkihiroSuda/rootless-crio
Support CRI-O runtime with Rootless Docker driver (`--driver=docker --container-runtime=cri-o`)
2021-11-11 16:05:36 -08:00
klaases 4238bc1319 update message by runtime 2021-11-11 14:49:18 -08:00
Medya Ghazizadeh 75e2466cf9
Merge pull request #12923 from sharifelgamal/sched-ctd
fix scheduled stop test for containerd on docker driver
2021-11-11 12:45:12 -08:00
Sharif Elgamal d226d04eab fix schedule stop test for containerd on docker driver 2021-11-10 09:09:50 -08:00
Steven Powell 413d10192e
Merge pull request #12907 from spowelljr/addFileSharingError
Add error message for file sharing
2021-11-09 15:14:53 -05:00
Steven Powell 414b3ddf78
Merge pull request #12740 from spowelljr/discardUnpackedLayers
containerd preload: discard unpacked layers to reduce size
2021-11-09 14:30:15 -05:00
Steven Powell ab3f316ce6 bump preload version 2021-11-09 13:54:03 -05:00
Steven Powell 5c4e70bb26 add error message for file sharing 2021-11-09 10:58:16 -05:00
Akihiro Suda d7e728487c
Support CRI-O runtime with Rootless Docker driver
Follow-up to PR 12359 (containerd runtime with Rootless Docker driver).

Usage (needs cgroup v2):
```
dockerd-rootless-setuptool.sh install
docker context use rootless
minikube start --driver=docker --container-runtime=cri-o
```

See site/content/en/docs/drivers/includes/docker_usage.inc

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-11-09 16:09:52 +09:00
Steven Powell 69aa495d02 address lint concerns 2021-11-08 09:23:00 -05:00
srikrishnabh93@gmail.com c80793cd5d Merge branch 'master' of https://github.com/kubernetes/minikube into master_srikrishnabh 2021-11-07 00:26:40 +05:30
srikrishnabh93@gmail.com 7dd0eb0c94 fixed review comments 2021-11-07 00:25:33 +05:30
Sharif Elgamal ef9a1a3a4f
Merge pull request #12863 from medyagh/hyperkit_suggestion
update suggestion for disabling internet sharing on hyperkit
2021-11-04 15:14:01 -07:00
Medya Ghazizadeh f8c34933fd
Update pkg/minikube/reason/known_issues.go
Co-authored-by: Sharif Elgamal <selgamal@google.com>
2021-11-04 15:07:40 -07:00
Medya Ghazizadeh bd973bba7c
Update pkg/minikube/reason/known_issues.go
Co-authored-by: Sharif Elgamal <selgamal@google.com>
2021-11-04 15:07:33 -07:00
Medya Ghazizadeh 94c74a2f52
Merge pull request #12848 from medyagh/no_kubernetes
Add --no-kubernetes flag  to start minikube without kubernetes
2021-11-04 14:46:48 -07:00
Medya Gh 8a7f43439a improve wording 2021-11-04 14:45:50 -07:00
Medya Gh 2ec8dc516a update suggestion for disalbing internet sharing on hyperkit 2021-11-04 14:43:43 -07:00
Medya Gh f4055654a1 spell 2021-11-04 12:48:28 -07:00
Medya Gh 75e6ba6637 better translate 2021-11-04 12:35:12 -07:00
Daehyeok Mun a88aec8b46 Support copy file from node to local host or between nodes. 2021-11-03 14:49:32 -07:00
Medya Gh 5bcdba0a09 add more constants 2021-11-03 14:16:04 -07:00
Medya Gh bfdc3cfdea address review comments 2021-11-03 14:13:04 -07:00
James Yin 54be390bba fix: check err before preload 2021-11-03 15:27:15 +08:00
Medya Gh c827bf849f better name 2021-11-02 15:44:30 -07:00
Medya Gh 79f1b8c55c add --no-kubernetes flag to start minikube without kubernetes 2021-11-02 15:41:40 -07:00
Steven Powell 22969595a7 convert containerd config to v2 2021-11-02 15:18:52 -07:00
Sharif Elgamal 3342d3aa34
Merge pull request #12811 from nbusseneau/pr/fix-virtualbox-ip
virtualbox: change default `host-only-cidr`
2021-11-02 13:38:16 -07:00
Steven Powell 2de2ef09a4 discard unpacked layers 2021-11-02 13:36:50 -07:00
Nicolas Busseneau 02a43c52e2
virtualbox: change default `host-only-cidr`
We change the default `--host-only-cidr` to `192.168.59.1/24` in order
to be compatible with the new default host-only networking restrictions
implemented in VirtualBox 6.1.28.

This fixes access denied errors on `minikube start` when using
VirtualBox >= 6.1.28:

```
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
```

More details:

VirtualBox 6.1.28 introduced new restrictions on host-only networking:
https://www.virtualbox.org/wiki/Changelog-6.1#v28

Manual: https://www.virtualbox.org/manual/ch06.html#network_hostonly

> On Linux, Mac OS X and Solaris Oracle VM VirtualBox will only allow IP
> addresses in 192.68.56.0/21 range to be assigned to host-only
> adapters. For IPv6 only link-local addresses are allowed. If other
> ranges are desired, they can be enabled by creating
> /etc/vbox/networks.conf and specifying allowed ranges there. For
> example, to allow 10.0.0.0/8 and 192.168.0.0/16 IPv4 ranges as well as
> 2001::/64 range put the following lines into /etc/vbox/networks.conf:
>
>      * 10.0.0.0/8 192.168.0.0/16
>      * 2001::/64
>
> Lines starting with the hash # are ignored. Next example allows any
> addresses, effectively disabling range control:
>
>      * 0.0.0.0/0 ::/0

These new restrictions manifest in the form of the following issue on
`minikube start` due to the default `--host-only-cidr` used by the
VirtualBox driver being `192.168.99.1/24`:

```console
😄  minikube v1.23.2 on Ubuntu 18.04
  Using the virtualbox driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🔥  Deleting "minikube" in virtualbox ...
🤦  StartHost failed, but will try again: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet0 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp

🔥  Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
😿  Failed to start virtualbox VM. Running "minikube delete" may fix it: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp

  Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯
```

While the above is the primary error, other errors will be reported if
the adapter already exists (this happens when the adapter was created
before updating to VirtualBox 6.1.28, on a version of VirtualBox without
the new restrictions). Some examples:

```
 Exiting due to IF_VBOX_NOT_VISIBLE: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: The host-only adapter we just created is not visible. This is a well known VirtualBox bug. You might want to uninstall it and reinstall at least version 5.0.12 that is is supposed to fix this issue
```

```
  minikube is unable to connect to the VM: dial tcp 192.168.99.112:22: i/o timeout

	This is likely due to one of two reasons:

	- VPN or firewall interference
	- virtualbox network configuration issue

	Suggested workarounds:

	- Disable your local VPN or firewall software
	- Configure your local VPN or firewall to allow access to 192.168.99.112
	- Restart or reinstall virtualbox
	- Use an alternative --vm-driver
	- Use --force to override this connectivity check

  Exiting due to GUEST_PROVISION: Failed to validate network: dial tcp 192.168.99.112:22: i/o timeout
```

When switching to a valid CIDR, `minikube start` works as usual:

```console
😄  minikube v1.23.2 on Ubuntu 18.04
  Using the virtualbox driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.22.2 on Docker 20.10.8 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
```

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
2021-11-02 15:30:46 +01:00
minikube-bot 79766cee83 bump default/newest kubernetes versions 2021-11-01 08:03:05 +00:00
Sharif Elgamal 6bbf98d57f
Merge pull request #12794 from prezha/improve-ingress
support k8s < v1.19 & watch-ingress-without-class
2021-10-28 10:40:09 -07:00
Steven Powell 2aa49b6295
Merge pull request #12806 from minikube-bot/iso-release-v1.24.0
Update ISO to v1.24.0
2021-10-28 09:55:13 -07:00
Sharif Elgamal c5a933fc45
Merge pull request #12801 from minikube-bot/kicbase-release-v0.0.28
Update kicbase to v0.0.28
2021-10-28 09:12:35 -07:00
Predrag Rogic ea3aa4f3a8
support ingress-dns addon, add tests 2021-10-28 04:14:35 +01:00
minikube-bot c3b8912852 Update ISO to v1.24.0 2021-10-27 23:10:38 +00:00
minikube-bot 3bc369459b Update kicbase to v0.0.28 2021-10-27 19:53:03 +00:00
Gio Gutierrez a49cd8a685 feat: Use new bridge interface name on OSX Monterey 2021-10-27 12:23:31 -05:00
Predrag Rogic 76c1e79598
support k8s < v1.19 & watch-ingress-without-class 2021-10-27 15:05:01 +01:00
Sharif Elgamal 418a9a17d2
Merge pull request #12779 from sharifelgamal/gcp-auth-test2
Fix disabling gcp-auth addon and test
2021-10-26 22:37:22 -07:00
Steven Powell 57de50af7b
Merge pull request #12702 from prezha/update-ingress
update ingress controller to v1/1.0.4 and v1beta1/0.49.3
2021-10-26 15:04:44 -07:00
Medya Ghazizadeh 6f72fc9a25
Merge pull request #12578 from AliyunContainerService/aliyun-mirror
Initial support for adding Aliyun mirror for preload images and K8s release binaries
2021-10-26 13:22:30 -07:00
Sharif Elgamal 8cf0a18069 no need to reverse file order for kubectl delete 2021-10-26 11:46:29 -07:00
Sharif Elgamal aaf85032f4 fix unit test part deux 2021-10-26 10:34:46 -07:00
Sharif Elgamal 77da350d83 fix unit test 2021-10-26 09:01:58 -07:00
Sharif Elgamal 1e932bc5bd cleanup and comments 2021-10-25 18:22:49 -07:00
Sharif Elgamal b0598d06e5 ignore-not-found for kubectl delete 2021-10-25 18:07:45 -07:00
Sharif Elgamal bd9da42651 reverse files for kubectl remove on addon disable 2021-10-25 17:31:24 -07:00
Sharif Elgamal bec03819df fix disabling gcp-auth addon 2021-10-25 15:32:13 -07:00
Medya Ghazizadeh 27b0c741cc
Merge pull request #12756 from spowelljr/fixNetworkIndex
fix podman network inspect index check
2021-10-25 14:41:34 -07:00
Medya Ghazizadeh 91c9af304a
Merge pull request #12730 from sharifelgamal/ingress-dns-002
Upgrade minikube-ingress-dns image to 0.0.2
2021-10-25 14:39:37 -07:00
Medya Gh d33b59d8b2 fix len 2021-10-21 14:54:14 -07:00
Medya Gh f80304a022 address review comments 2021-10-21 14:54:14 -07:00
Medya Gh c8cb7a3c2d delete older minikube version preload files on start tup 2021-10-21 14:54:14 -07:00
Steven Powell 016b3ac40a trim space earlier 2021-10-21 13:28:52 -07:00
srikrishnabh93@gmail.com d0928b1913 updated kubeadm-constants image version 2021-10-21 23:01:32 +05:30
srikrishnabh93@gmail.com fce35c9721 Merge branch 'master' of https://github.com/kubernetes/minikube into master_srikrishnabh 2021-10-21 22:56:01 +05:30
Steven Powell fbd4d27582 fix podman network inspect index check 2021-10-21 10:01:10 -07:00
Sharif Elgamal c4b801c8dc
Merge pull request #12735 from zigarn/ingress-driver-none
Remove useless check of baremetal driver for ingress addon
2021-10-20 11:58:07 -07:00
Medya Ghazizadeh b5f8781152
Merge pull request #12717 from afbjorklund/kubeadm-pause
Add kubeadm image versions for kubernetes 1.23
2021-10-19 10:44:31 -07:00
Alexandre Garnier 1c89bd7bf9 Remove useless check of baremetal driver for ingress addon 2021-10-19 17:03:02 +02:00
Sharif Elgamal e41415ce9c Upgrade minikube-ingress-dns image to 0.0.2 2021-10-18 17:18:37 -07:00
Steven Powell d7decc2a8d persist mount settings after stop 2021-10-18 15:40:48 -07:00
srikrishnabh93@gmail.com 2d7e884817 Merge branch 'master' of https://github.com/kubernetes/minikube into master_srikrishnabh 2021-10-18 22:55:57 +05:30
Sharif Elgamal 029a9d1700
Merge pull request #12587 from duttaANI/fixIpCilium
Fix Ipv4 cidr in cilium
2021-10-15 14:06:52 -07:00
Steven Powell 99661e64a3
Merge pull request #12711 from spowelljr/fixMount
Fix mounting on non-default profile
2021-10-15 12:57:24 -07:00
Anders F Björklund 9f16ff632f Add kubeadm image versions for kubernetes 1.23 2021-10-15 21:40:09 +02:00
Steven Powell 2a489bf7e1 fix mounting on non-default profile & make mounting processes cluster independent 2021-10-14 14:44:51 -07:00
Sharif Elgamal c3a9f66a8d
Merge pull request #11590 from dinever/detailed-test-info
Add detailed info generation for integration tests
2021-10-14 11:17:23 -07:00
Predrag Rogic db4937aa8f
update ingress-nginx controller to v1.0.4 2021-10-13 09:02:12 +01:00
Predrag Rogic c680044eae
remove allow-snippet-annotations as per recommendation 2021-10-12 23:24:26 +01:00
Predrag Rogic 29abb74777
update ingress to v1-1.0.3 and v1beta1-0.49.3 2021-10-12 21:21:54 +01:00
Peixuan Ding b43f0bcd39 Add detailed info for integration tests 2021-10-11 01:00:06 -04:00
Anders F Björklund 75804c43ad Match the lower case of the podman error message
Turns out that Docker says "No such network",
but Podman says "no such network". Little nuances.
2021-10-10 12:25:18 +02:00
KallyDev 70022d9b2e
Move from deprecated ioutil to os and io packages 2021-10-08 08:57:19 +08:00
Marc Velasco a48e875ec1 return error if unable to get os.UserHomeDir in ssh-key when resolving absolute path 2021-10-07 11:57:43 -07:00
Marc Velasco 4f5524f039 changes for comments to the PR, use os.UserHomeDir and strings.hasprefix, move package order 2021-10-07 10:40:13 -07:00
Marc Velasco a827379f08 remove comment before absolute path function to fix lint errors 2021-10-07 09:27:25 -07:00
Marc Velasco c27326cab8 fix for #12659, rendor absolute path when tilde starts ssh-key path 2021-10-06 23:14:46 -07:00
Steven Powell c516c43aaf
Merge pull request #12641 from duttaANI/updateHelmTillerImage
Update Helm Tiller image to v2.17.0
2021-10-05 14:39:37 -04:00
Steven Powell 1a4160e60d
Merge pull request #12081 from spowelljr/buildkitSocket
buildkit socket: Add systemd unit
2021-10-01 20:49:41 -04:00
Aniruddha Amit Dutta 33396184bb Update Helm Tiller image to v2.17.0 2021-10-01 13:16:06 +05:30
Aniruddha Amit Dutta d3dad9c7f9 Feat: Add a template for cilium yaml 2021-10-01 10:50:35 +05:30
minikube-bot 39eb5cb53c Updating kicbase image to v0.0.27-1633027942-12081 2021-09-30 19:21:11 +00:00
Steven Powell dafbe6aac3 add created by label for podman 2021-09-29 13:47:59 -07:00
srikrishnabh93@gmail.com 7e7a97e69d updated the test data kubeadm_test.go 2021-09-29 20:51:03 +05:30
srikrishnabh93@gmail.com ab496e6765 Merge branch 'master' of https://github.com/kubernetes/minikube into master_srikrishnabh 2021-09-29 20:28:34 +05:30
Marcus Watkins 6b8aba3c68 Fix invoking kubeadm failing when spaces in PATH 2021-09-28 10:43:13 -06:00
Medya Ghazizadeh 2fd09e11a8
Merge pull request #12149 from afbjorklund/build-cp
Build images on the primary control plane
2021-09-27 19:11:04 -07:00
Medya Ghazizadeh 87dfeb7db5
Merge pull request #12514 from yxxhero/fix_image_none_none
add better error output for minikube image rm
2021-09-27 19:04:14 -07:00
yxxhero 860c66de97 fix typo
Signed-off-by: yxxhero <aiopsclub@163.com>
2021-09-28 07:41:22 +08:00
Aniruddha Amit Dutta cd89ccd30c Fix Ipv4 cidr in cilium 2021-09-27 18:36:13 +05:30
Li Yi f1d56741f8 Fix for boilerplate 2021-09-26 16:19:19 +08:00
Anders F Björklund a9b74bbea2 Allow running podman as experimental driver 2021-09-26 10:16:46 +02:00
Li Yi 9ae94cf8d4 Initial support for adding Aliyun mirror for preload images and Kubernetes binaries
Signed-off-by: Li Yi <denverdino@gmail.com>
2021-09-26 16:04:29 +08:00
Li Yi eb66c6797e Initial support for adding Aliyun mirror for preload images and Kubernetes binaries
Signed-off-by: Li Yi <denverdino@gmail.com>
2021-09-26 15:36:36 +08:00
yxxhero 68b34d41ae add error message out
Signed-off-by: yxxhero <aiopsclub@163.com>
2021-09-25 08:47:47 +08:00
Sharif Elgamal 73d66f0c94
Merge pull request #12534 from sharifelgamal/renew-certs
renew minikube certs if expired
2021-09-24 14:53:22 -07:00
Sharif Elgamal 4307e834df address review comments 2021-09-24 11:47:10 -07:00
Medya Ghazizadeh 8c0e46c784
Merge pull request #12553 from spowelljr/addForceSystemdCrio
Implement --force-systemd into cri-o
2021-09-23 12:15:31 -07:00
Sharif Elgamal 03d9b16c7b write to the correct cell 2021-09-23 09:51:11 -07:00
Steven Powell 205b492a87 implement --force-systemd into cri-o 2021-09-22 15:07:36 -07:00
minikube-bot 2dd9c28d27 Updating ISO to v1.23.1-1632339185-12081 2021-09-22 20:31:56 +00:00
Steven Powell 923928efb7 remove buildkitd start script 2021-09-22 11:31:41 -07:00
Sharif Elgamal 9997caa178 actually print the results 2021-09-22 09:07:00 -07:00
Sharif Elgamal 5038cc0599 fix lint 2021-09-21 17:56:28 -07:00
Sharif Elgamal 92010a5f12 start timing enable ingress for containerd 2021-09-21 17:44:33 -07:00
Sharif Elgamal 2799f24e12 don't skip none driver, fix logging 2021-09-21 17:38:09 -07:00
Sharif Elgamal 1212848649 make cert expiration configurable and add test 2021-09-21 16:17:52 -07:00
Medya Ghazizadeh 6592a43ce2
Merge pull request #12533 from spowelljr/fixDefaultCgroupCrio
change default crio cgroup to systemd
2021-09-21 13:49:12 -07:00
yxxhero 9347def2d0 Modify as suggested
Signed-off-by: yxxhero <aiopsclub@163.com>
2021-09-21 09:48:33 +08:00
Sharif Elgamal e5b8f654fe renew minikube certs if expired 2021-09-20 18:13:24 -07:00
Steven Powell b4cdf84618 change default crio cgroup to systemd 2021-09-20 17:34:49 -07:00
Steven Powell 01314b959b fix template typo 2021-09-20 15:55:40 -07:00
minikube-bot 4a8f4a1e28 bump default/newest kubernetes versions 2021-09-20 08:02:52 +00:00
yxxhero e31738aec4 add better error output for minikube image rm
Signed-off-by: yxxhero <aiopsclub@163.com>
2021-09-19 21:18:30 +08:00
Steven Powell 90b7ebb45f
Merge pull request #12492 from minikube-bot/kicbase-release-v0.0.27
Update kicbase to v0.0.27
2021-09-16 22:44:18 -07:00
Steven Powell 65e7e54788
Merge pull request #12491 from minikube-bot/iso-release-v1.23.1
Update ISO to v1.23.1
2021-09-16 22:44:04 -07:00
Sharif Elgamal a5cdaf53b2 remove debugging 2021-09-16 15:30:59 -07:00
Sharif Elgamal a74d50eade be a little smarter about refreshing secrets 2021-09-16 15:18:52 -07:00
Sharif Elgamal 047f2e553f fix refreshing gcp-auth pull secret 2021-09-16 15:06:31 -07:00
Sharif Elgamal 9c9c1614aa fix sha for metrics-server image in addon config 2021-09-16 13:47:47 -07:00
Sharif Elgamal a86693c96e
Merge pull request #12475 from leifcr/patch-2
Use newer dashboard, to support ingress extensions
2021-09-16 13:31:51 -07:00
minikube-bot 1976e1b296 Update kicbase to v0.0.27 2021-09-16 18:55:00 +00:00
minikube-bot f0636429fb Update ISO to v1.23.1 2021-09-16 18:00:10 +00:00
Sharif Elgamal 40c44fa1ef fix unit tests, change addon yaml, bump preload version 2021-09-16 10:31:43 -07:00
Steven Powell 1936a7b508
Merge pull request #12425 from spowelljr/updateCrio
Update cri-o from v1.20.0 to 1.22.0
2021-09-15 18:21:10 -07:00
Sharif Elgamal 8e61a961e8
Merge pull request #12473 from sharifelgamal/gcp-auth-test
make sure to delete image pull secrets on gcp auth addon disable
2021-09-15 17:12:09 -07:00
Sharif Elgamal 88c62ad469 as usual, skip kube-system for pull secret 2021-09-15 08:59:19 -07:00
Sharif Elgamal 803fc43e26 fix ingress-dns addon and add test 2021-09-14 17:41:26 -07:00
minikube-bot d52130b292 Updating ISO to v1.23.0-1631662909-12425 2021-09-15 00:37:07 +00:00
Leif Ringstad ea81f09058
Use newer dashboard, to support ingress extensions
This should solve #12402 and issues where ingresses will not show properly in the dashboard.
This error shows on kubernetes 1.22
2021-09-14 23:44:35 +02:00
Sharif Elgamal 6acb65ca71 make sure to delete image pull secrets on gcp auth addon disable 2021-09-14 13:12:07 -07:00
minikube-bot 030b3837ab Updating kicbase image to v0.0.26-1631295795-12425 2021-09-14 09:50:53 -07:00
Sharif Elgamal c0534a666c
Merge pull request #12461 from sharifelgamal/gcp-svc-account
Create GCP auth pull secret even if creds JSON is nil
2021-09-14 08:38:53 -07:00
Sharif Elgamal 5672d40eec account for GCE service account for GCP auth 2021-09-13 14:05:30 -07:00
Steven Powell 145f9fc9ab run `go fmt` 2021-09-13 11:58:43 -07:00
Sharif Elgamal f18c312fac
Merge pull request #11785 from brian14708/aliyun-addon
fix images for aliyun registry
2021-09-09 10:31:04 -07:00
minikube-bot 67b82f3fe1 Update kicbase to v0.0.26 2021-09-03 02:18:31 +00:00
minikube-bot 703324b7c7 Updating kicbase image to v0.0.25-1630631232-12398 2021-09-03 01:36:51 +00:00
Steven Powell c1fc138e66
Merge pull request #12395 from spowelljr/updateErrorMessage
Change GitHub issue output to ask user to upload `minikube logs` file
2021-09-02 15:46:56 -07:00
Steven Powell 78febe240d change GitHub issue output to upload `minikube logs` file 2021-09-02 15:09:09 -07:00
minikube-bot 9597ac2f89 Update ISO to v1.23.0 2021-09-02 18:39:41 +00:00
Brian Li 8b8c96bb66 fix minikube images for aliyun registry 2021-09-02 15:04:31 +08:00
Brian Li 71c909a541 fix addon image for aliyun registry 2021-09-02 15:04:31 +08:00
Sharif Elgamal 738eb5177c
Merge pull request #12231 from sharifelgamal/gcp-cs
gcp-auth: improve flow for GCE/Cloud Shell
2021-09-01 13:20:06 -07:00
Sharif Elgamal 60d9d41ba2 omg horrible typo 2021-08-31 15:02:13 -07:00
Medya Ghazizadeh 769ee32872
Merge pull request #12377 from medyagh/helm-fix
fix deprecated image in helm addon
2021-08-31 14:54:39 -07:00
Sharif Elgamal 7317746d57 check for special error everywhere 2021-08-31 12:21:09 -07:00
Medya Ghazizadeh 3469c77ffa
Merge pull request #12351 from raghavendra-talur/rtalur-add-disks-kvm2
Add `--extra-disks` capability to kvm2 driver
2021-08-30 16:50:58 -07:00
Medya Gh 8c096cc3a7 fix depricated image in helm addon 2021-08-30 16:44:13 -07:00
Medya Gh a622f50c5d fix depricated image in helm addon 2021-08-30 16:42:44 -07:00
Akihiro Suda 323225483e
Support Rootless Docker
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/

Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.

Closes issue 10836 ("add support for rootless Docker").

Support for rootless Podman (issue 8719) is not covered in this commit.

---

Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
  instead of `overlayfs` snapshotter

- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
  Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint

- `cmd/minikube/cmd/start_flags.go`: updated to set `KubeletInUserNamespace` feature gate when rootless

- `pkg/drivers/kic/oci`: updated to use port forwarding, because rootless container IPs are not reachable from the host

- `pkg/minikube/cruntime`: updated to generate `/etc/containerd/config.toml` with rootless support.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-08-27 17:21:53 +09:00
Sharif Elgamal 55c40f8220 Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-26 13:32:10 -07:00
srikrishnabh93@gmail.com 6a9d08ecef Merge branch 'master' of https://github.com/kubernetes/minikube into master_srikrishnabh 2021-08-26 20:47:47 +05:30
srikrishnabh93@gmail.com e744f3e3cc fixed kubeadm image version for 22 2021-08-26 19:20:38 +05:30
Medya Ghazizadeh 219580efcc
Merge pull request #12325 from prezha/fix-ingress-v1.22
Bump default Kubernetes version to v1.22.1 and update addons to with new API (ingress, gcpauth, olm and cilium)
2021-08-25 10:48:14 -07:00
Medya Ghazizadeh 527a3d920f
Merge pull request #12265 from prezha/fix-image-save-cmd
fix image save cmd
2021-08-25 10:45:08 -07:00
Sharif Elgamal 2bb50e412f
Merge pull request #12332 from andriyDev/TCSHEnvSupport
Add support for tcsh in docker-env subcommand
2021-08-25 10:09:20 -07:00
Predrag Rogic 1bed76660e
fix lint 2021-08-25 09:41:20 +01:00
Raghavendra Talur dceb676527 Add extra disks capability to kvm2 driver
Having additional disks on the nodes is a requirement for developers
working on the storage components in Kubernetes. This commit adds the
extra-disks feature to the kvm2 driver.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2021-08-25 00:15:02 -04:00
Predrag Rogic aba7d399e8
fix cilium for k8s v1.22+ 2021-08-25 02:11:10 +01:00
Andriy Dzikh 1ba150fd63 Add unit test for tcsh shell. 2021-08-24 11:19:13 -07:00
Predrag Rogic 7466e4a109
fix gcpauth and olm for k8s v1.22+ 2021-08-24 18:40:22 +01:00
Predrag Rogic 9c3c5d1140
prevent 'assignment to entry in nil map' error. 2021-08-24 18:05:56 +01:00
Predrag Rogic abd52901cf
fix ingress for k8s v1.22+ 2021-08-24 18:05:44 +01:00
Predrag Rogic 6efbd1ce13
merge 2021-08-24 04:20:52 +01:00
Sharif Elgamal d6c244e543 bump gcp-auth-webhook to v0.0.7 2021-08-23 18:28:53 -07:00
Sharif Elgamal 42d3f3b92f Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-23 15:40:30 -07:00
Medya Ghazizadeh 7fa5dbdee2
Merge pull request #12331 from afbjorklund/kubeadm-versions
Add kubeadm image versions for kubernetes 1.22
2021-08-23 13:51:08 -07:00
Sharif Elgamal 4bc5cb77d1 Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-cs 2021-08-23 11:11:16 -07:00
Andriy Dzikh fabda37a91 Add support for tcsh in docker-env subcommand. 2021-08-23 10:46:19 -07:00
Anders F Björklund 10dfafeafb Add kubeadm image versions for kubernetes 1.22
Again, the images were wrong in the preload
2021-08-23 18:17:39 +02:00
Anders F Björklund 817f8b4b70 Add also stand-alone image push matching pull
Normally this is done as part of image build
2021-08-22 20:11:19 +02:00
Anders F Björklund 380b846715 Add stand-alone image pull and image tag commands
Needed for testing, but maybe elsewhere as well
2021-08-22 19:52:07 +02:00
Sharif Elgamal 69d5d34eeb
Merge pull request #12089 from zhan9san/feature/ingress-mac
Support Ingress on MacOS, driver docker
2021-08-20 15:16:13 -07:00
Sharif Elgamal b6bbf9fd4b fix lint 2021-08-20 11:21:07 -07:00
Sharif Elgamal f8b9b88425 pause each container separately 2021-08-20 11:03:44 -07:00
Sharif Elgamal ee28862f29 add comments 2021-08-19 16:31:40 -07:00
Sharif Elgamal 5c2f2c888f fix unit tests by comparing JSON structs 2021-08-19 16:13:12 -07:00
Jack Zhang def3f067a8 Support Ingress on MacOS, driver docker 2021-08-17 10:27:21 +08:00
Sharif Elgamal bd9dd612ed Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-16 16:52:41 -07:00
Medya Ghazizadeh 7dc8836303
Merge pull request #12268 from afbjorklund/minikube-2021.02-new
Upgrade Buildroot to 2021.02 LTS with Linux 4.19
2021-08-16 16:47:00 -07:00
Sharif Elgamal f74789656b remove outdated param in tiller test 2021-08-16 16:46:39 -07:00
Medya Ghazizadeh 29117e3c13
Merge pull request #12230 from medyagh/v1beta_depricate
bump calico to v3.20 and move away from v1beta apis
2021-08-16 16:38:16 -07:00
Medya Ghazizadeh e0e890f7ae
update 2021-08-16 16:08:58 -07:00
Medya Ghazizadeh 30d55ca7f2
Update pkg/minikube/reason/known_issues.go
Co-authored-by: Sharif Elgamal <selgamal@google.com>
2021-08-16 16:06:28 -07:00
Medya Gh 0167da6435 add solution message for cgroup related issues on cloud shell-like environments 2021-08-16 15:50:33 -07:00
Predrag Rogic 11d31dda14
early check if image exists at all 2021-08-16 23:12:38 +01:00
Medya Gh b85c4fe0fc common calico func 2021-08-16 14:24:48 -07:00
Anders F Björklund ab61a07f95 Make sure to use sudo for load/save docker images
Add a test for SaveImage, similar to LoadImage
2021-08-16 18:13:32 +02:00
Anders F Björklund 9e588e6ba1 Add stand-alone image pull and image tag commands
Needed for testing, but maybe elsewhere as well
2021-08-15 20:22:24 +02:00
minikube-bot d7484e41ee Updating ISO to v1.22.0-1628974786-12268 2021-08-14 22:13:14 +00:00
Predrag Rogic fa8ee4957e
fix original pr 12162 2021-08-13 23:28:48 +01:00
Anders F Björklund 68197de861
Add command to save images from the cluster
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".

The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-13 23:28:25 +01:00
Anders F Björklund e59c41e6f2
Add method to copy files from the VM as well
Previously you could only Copy(To), not CopyFrom.

Implies that some Assets can be written to instead.
2021-08-13 23:28:24 +01:00
Sharif Elgamal 756aac7c21 only skip the addon on enable 2021-08-13 15:07:25 -07:00
Sharif Elgamal 235d7e8280 Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-13 14:15:31 -07:00
Sharif Elgamal 371becaf73 tMerge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-13 14:08:23 -07:00
Medya Ghazizadeh 0bd906077f
Revert "new `image save` command" 2021-08-13 14:06:42 -07:00
Sharif Elgamal 06ed3378b9 create special error to skip addons without erroring out 2021-08-13 13:42:02 -07:00
Medya Ghazizadeh 559048f83d
Merge pull request #11768 from ilya-zuyev/arm_kvm_driver
KVM2 driver for linux/aarch64
2021-08-13 13:27:59 -07:00
Medya Ghazizadeh d7c3ade64d
Merge pull request #11745 from vishjain/user/vishal/ssh-tunnel/master
Clean up ssh tunnels during exit.
2021-08-13 13:15:47 -07:00
Medya Ghazizadeh 41ba49d597
Merge pull request #12162 from afbjorklund/image-save-cmd
Image save command
2021-08-13 13:02:58 -07:00
Medya Gh 098adff14f fix image name 2021-08-13 12:55:06 -07:00
Medya Ghazizadeh adbeae1763
Merge pull request #12032 from spowelljr/updateBuildkit
Upgrade buildkit from 0.8.2 to 0.9.0
2021-08-13 12:43:49 -07:00
Medya Gh ccf4af0997 change depricated golint to revive and fix lint issues 2021-08-12 18:11:16 -07:00
Medya Ghazizadeh a85e155490
Merge pull request #12252 from medyagh/fix_lint
Fix lint for gocilint 1.41.1
2021-08-12 17:45:20 -07:00
Medya Gh 6aa7abc24a fix lint issues on master 2021-08-12 17:38:24 -07:00
Medya Gh 5206f7fb39 fix lint 2021-08-12 17:11:31 -07:00
Medya Ghazizadeh 79df20bf59
Merge pull request #12228 from andriyDev/PrintProfile
Print profile driver, container runtime, and Kubernetes version on load
2021-08-12 16:42:25 -07:00
Medya Gh 1c76ff5cea lint 2021-08-12 15:29:54 -07:00
Medya Gh 7809b3b2ae update calico to v 3.20 2021-08-12 15:22:32 -07:00
Sharif Elgamal ca04178ced exit prematurely in specific case for gcp-auth 2021-08-12 14:13:51 -07:00
Sharif Elgamal 163a4b2934 fix lint 2021-08-11 11:56:45 -07:00
Sharif Elgamal 1319fe729f fix file existence check 2021-08-11 09:58:03 -07:00
Sharif Elgamal f99b234c7e simplify logic 2021-08-10 15:56:15 -07:00
Sharif Elgamal e150129172 refactor EnableOrDisableAddon to reduce cyclotomic complexity 2021-08-10 15:54:12 -07:00
Sharif Elgamal 19b763fd36 do not start pods if no creds 2021-08-10 15:16:41 -07:00
Andriy Dzikh 61fb4757d0 Add info log message to print driver, container runtime, and Kubernetes version. 2021-08-10 14:54:16 -07:00
Medya Gh 4e32f41c83 move away from v1beta apis 2021-08-10 14:24:43 -07:00
Sharif Elgamal dfef0ad478 read blessed cloud shell config file 2021-08-10 13:46:49 -07:00
Andriy Dzikh d2d0fee726 Use Load function in implementation of LoadProfile function. 2021-08-10 13:24:32 -07:00
minikube-bot d7681967bf Updating ISO to v1.22.0-1628622362-12032 2021-08-10 20:06:04 +00:00
Sharif Elgamal 3acbd2fc90 gcp-auth: improve flow for GCE/Cloud Shell 2021-08-10 12:57:10 -07:00
minikube-bot 6cecbf6fe5 Updating kicbase image to v0.0.25-1628619379-12032 2021-08-10 18:33:49 +00:00
Anders F Björklund e91b037546 Make sure to break loop and not select 2021-08-10 13:16:45 +02:00
Anders F Björklund dbb295d078 Go back to upstream google/go-containerregistry
Do the docker pull (of the manifest and its digest) explicitly,
instead of implicitly in the library. Also, no progress bar.

Pass the digest to the fetch and the tag to the tarball save,
as usual there are _no_ digests used in the tarball files.
2021-08-10 10:43:42 +02:00
Anders F Björklund b75bf27942 Add command to save images from the cluster
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".

The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-10 09:49:23 +02:00
Anders F Björklund a62a02bc9a Add method to copy files from the VM as well
Previously you could only Copy(To), not CopyFrom.

Implies that some Assets can be written to instead.
2021-08-10 09:47:34 +02:00
Steven Powell b1dcba955c ping `releases.json` file if `WantUpdateNotification` is false 2021-08-09 15:45:21 -07:00
Steven Powell de8a1ba40b
Merge pull request #12143 from spowelljr/imageLoadTar
Fix loading an image from tar failing on existing delete
2021-08-09 15:14:58 -07:00
Sharif Elgamal 9995961a77
Merge pull request #12106 from sharifelgamal/more-reg
configure gcp-auth addon pull secret to work with all GCR and AR mirrors
2021-08-09 12:02:31 -07:00
Medya Ghazizadeh dc8dd6f508
Merge pull request #12135 from afbjorklund/containerd-version
Make sure to return valid containerd version
2021-08-09 11:55:32 -07:00
Anders F Björklund 2ab5c86a88 Build images on the primary control plane
Allow selecting another node using --node

Or continue build on all nodes with --all
2021-08-06 19:04:51 +02:00
minikube-bot 3dccb2bea0 Updating ISO to v1.22.0-1628238775-12122 2021-08-06 09:27:20 +00:00
Anders F Björklund c738c78c59 Make sure to pass k8s version for socket path 2021-08-06 10:02:11 +02:00
Anders F Björklund 9957016111 Fix version comparison for pre-release versions 2021-08-06 09:17:57 +02:00
Sharif Elgamal b1ab5a087d
Merge pull request #12124 from sharifelgamal/gcp-cs
gcp-auth: always create the pull secret and don't require --force if …
2021-08-05 17:25:53 -07:00
Steven Powell 6d4eec056b fix loading an image from tar failing on existing delete 2021-08-06 00:24:28 +00:00
Anders F Björklund e6af39a358 Special case for handling deb package versions
So that we still show the patched version, if possible.
But not everything can be represented as semver, like ~.
2021-08-05 23:05:56 +02:00
Anders F Björklund bd00169c07 Make sure to return valid containerd version
For instance ubuntu put their packaging version into it.
Only return the major, minor and patch no in that case.
2021-08-05 22:12:45 +02:00
minikube-bot 16f5466439 Updating ISO to v1.22.0-1628159026-12129 2021-08-05 11:19:56 +00:00
Sharif Elgamal b2bc913596 gcp-auth: always create the pull secret and don't require --force if GOOGLE_APPLICATION_CREDENTIALS env var is set 2021-08-04 16:35:26 -07:00
Anders F Björklund 865e5be0a6 Stop CRIDocker socket before Docker socket
That is, reverse order from when starting up.
2021-08-04 20:10:30 +02:00
Anders F Björklund 51b3f1c82b The socket has a different name than the package
It is cri-docker.sock, even for cri-dockerd deb
2021-08-04 19:58:36 +02:00
Sharif Elgamal c0e8d3e640 Merge branch 'master' of github.com:kubernetes/minikube into more-reg 2021-08-03 13:34:11 -07:00
Sharif Elgamal eff683bfaf
Revert "fix whitespace in test yaml" 2021-08-03 13:21:33 -07:00
Sharif Elgamal 86839e6bc8 Merge branch 'master' of github.com:kubernetes/minikube into more-reg 2021-08-03 13:03:08 -07:00
Sharif Elgamal 35fc753381
Merge pull request #12091 from minikube-bot/auto_bump_k8s_versions
fix whitespace in test yaml
2021-08-03 11:59:10 -07:00
Sharif Elgamal 3d79bba97d configure gcp-auth addon pull secret to work with all GCR and AR mirrors 2021-08-03 11:48:20 -07:00
Anders F Björklund 52dcf3d283 Use the socket systemd unit instead of the service
The socket-activated service for cri-dockerd will start on demand,
similar to how the docker service works (for /var/run/docker.sock)
2021-08-03 13:28:37 +02:00
Anders F Björklund f84ae2aaf7 Use cri-dockerd instead of dockershim where needed
Starting with Kubernetes version 1.23, the CRI socket
for Docker is handled externally instead of internally.
2021-08-03 13:18:52 +02:00
srikrishnabh93@gmail.com ddfcf464dc fixed formatting 2021-08-02 23:02:01 +05:30
minikube-bot ef196a35b8 bump default/newest kubernetes versions 2021-08-02 08:03:07 +00:00
srikrishnabh93@gmail.com 837c73d964 added gofmt for constants_kubeadm_images 2021-08-01 13:42:42 +05:30
srikrishnabh93@gmail.com efbfbc1f21 Merge branch 'master' of https://github.com/kubernetes/minikube into master_srikrishnabh 2021-08-01 13:01:54 +05:30
srikrishnabh93@gmail.com 8f0483461b added makefile target 2021-07-31 23:20:32 +05:30
Steven Powell 88a4add138 auto start buildkit daemon on `image load` for containerd 2021-07-29 16:50:29 -07:00
Medya Ghazizadeh 5da954e278
Merge pull request #11945 from sharifelgamal/gcp-sa
don't try to recreate pull secrets for refreshing gcp-auth
2021-07-28 16:09:45 -07:00
Sharif Elgamal faca0fd9ff
Merge pull request #11483 from BlaineEXE/add-extra-disks-to-hyperkit-vms
Add ability to create extra disks on hyperkit vms
2021-07-28 13:50:13 -07:00
Medya Ghazizadeh 654a1b5b55
Merge pull request #11842 from leoluk/libvirt-permissions-revisited
kvm: only check libvirt membership if we failed to connect to it
2021-07-28 12:27:47 -07:00
Medya Ghazizadeh f20cbf357e
Merge pull request #11968 from kadern0/issue-11729
Added restart command after setting crio options
2021-07-28 12:26:13 -07:00
Medya Ghazizadeh 44feb06fb7
Merge pull request #12066 from andriyDev/fix-download-pb-not-tty
Make download.download not use progress bar if not in tty.
2021-07-28 12:08:41 -07:00
minikube-bot 6aa3c7ff11 Updating ISO to v1.22.0-1627488369-11483 2021-07-28 17:03:32 +00:00
Blaine Gardner 8f05ee00e1
Add ability to create extra disks on hyperkit vms
Add the ability to create and attach extra disks to hyperkit vms.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-07-28 09:57:20 -06:00
Medya Ghazizadeh 2b84cb9a71
Merge pull request #12052 from minikube-bot/auto_bump_k8s_versions
bump default/newest kubernetes versions
2021-07-27 15:00:24 -07:00
Andriy Dzikh a3f7bfc2f8 Make download.download not use progress bar if not in tty. 2021-07-27 14:12:32 -07:00
srikrishnabh93@gmail.com 5f46b98eae initial fix on update kubeadm images automatically 2021-07-27 23:41:17 +05:30
Medya Ghazizadeh 75d0c72a62
Merge pull request #11709 from dinever/out-box
Add method for customized box output
2021-07-26 17:34:28 -07:00
Medya Ghazizadeh 3375c39c76
Merge pull request #11981 from de-sh/vb-warn
Add message to discourage the use of the virtualbox driver
2021-07-26 17:30:38 -07:00
Medya Gh a6bfbd1580 update the warnning 2021-07-26 16:40:43 -07:00
Medya Ghazizadeh c6ff62046c
Merge pull request #11979 from andriyDev/MountPort
Add configurable port for minikube mount
2021-07-26 15:30:45 -07:00
Medya Gh 12a174a7ba update kubeadm yamls 2021-07-26 15:06:45 -07:00
minikube-bot 190226eb07 bump default/newest kubernetes versions 2021-07-26 08:03:10 +00:00
Vishal Jain ecaa3c1f03 Addressed comment about activeConn. 2021-07-25 14:45:41 -07:00
Medya Ghazizadeh 11200f8778
Merge pull request #12035 from sharifelgamal/custom-cert
make sure to sync certs from all documented locations
2021-07-23 14:00:12 -07:00
Sharif Elgamal 6d710b4e59 only use update if the secret already exists 2021-07-23 13:11:07 -07:00
Sharif Elgamal a940203ed4 update instead of delete/create 2021-07-23 12:22:51 -07:00
Sharif Elgamal c8379ea2ec Merge branch 'master' of github.com:kubernetes/minikube into gcp-sa 2021-07-23 09:25:00 -07:00
Sharif Elgamal c744d3b72d don't throw an error if a certs dir doesn't exist 2021-07-22 11:38:27 -07:00
Andriy Dzikh 36cc7e0a70 Have cluster.Mount return an error which is checked in advice.go. 2021-07-22 10:38:57 -07:00
Medya Ghazizadeh db4f0dc414
Merge pull request #11957 from kadern0/issue-11513
Don't set conntrack parameters in kube-proxy
2021-07-21 21:28:16 -07:00
Sharif Elgamal cca438a21a sync from all locations 2021-07-21 18:14:29 -07:00
Steven Powell f78483c83c
Merge pull request #11940 from tejal29/patch-1
Add a suggestion for unhealthy control plane due to control plane not updated.
2021-07-21 21:00:14 +00:00
Steven Powell 92b7ba0c1e
Merge pull request #11420 from ntkme/fully-qualified-image-name
Use fully qualified image name for kicbase image from docker hub
2021-07-21 18:47:42 +00:00
Tejal Desai 064a7eccf9
code review comments. 2021-07-20 09:24:53 -07:00
Devdutt Shenoi 892b314020 Rewrite suggestion and change if statement 2021-07-20 09:06:25 +05:30
Sharif Elgamal 5227520347 Merge branch 'master' of github.com:kubernetes/minikube into gcp-sa 2021-07-19 12:23:15 -07:00
minikube-bot 839b0fbdbc bump default/newest kubernetes versions 2021-07-19 08:02:48 +00:00
Devdutt Shenoi e30f9e2e62 Ensure if alternative vmware is healthy before recommeding 2021-07-17 15:57:59 +05:30
Devdutt Shenoi 86dba80fb3 Ensure available alternatives aren't either discouraged or not installed 2021-07-17 15:43:14 +05:30
Devdutt Shenoi 3fb51c4cfc Ensure message is shown only if alternatives are available 2021-07-17 15:34:59 +05:30
Devdutt Shenoi dfb624117c Improve cyclomatic complexity, move warning into separate function 2021-07-16 18:46:07 +05:30
Devdutt Shenoi b3696ea3b8 Refactor message into a box dialog 2021-07-16 02:13:14 +05:30
Andriy Dzikh 49cd3840d3 Create advice for mount command timing out. 2021-07-14 15:38:04 -07:00
Devdutt Shenoi 0e665930e8 Add message to discourage the use of virtualbox driver 2021-07-14 15:00:22 +05:30
なつき 4040311f1e Use fully qualified image name for docker hub fallback image 2021-07-13 16:09:55 -07:00
Sharif Elgamal 6b6a7c0192
Merge pull request #11956 from minikube-bot/auto_bump_k8s_versions
bump default/newest kubernetes versions
2021-07-13 14:15:29 -07:00
Sharif Elgamal 4dd89f8713 Merge branch 'master' of github.com:kubernetes/minikube into gcp-sa 2021-07-13 13:31:34 -07:00
Sharif Elgamal 4c66799127
Merge pull request #11933 from balasu/addons/portainer
Add addon support for portainer
2021-07-13 10:40:20 -07:00
Sharif Elgamal be6b203bdc
Merge pull request #11948 from aspectcapital/issue11934
Retain full container name when passing --image-repository
2021-07-13 10:07:57 -07:00
Pablo Caderno c211601ec4 Added restart command after setting crio options 2021-07-13 20:38:08 +10:00
Steven Powell 59faff1ff9
Merge pull request #11893 from andriyDev/refactor-preload
Refactor checkRemotePreloadExists to no longer include caching logic
2021-07-12 23:58:00 +00:00
Matt Dainty f452a08f5c
Update tests 2021-07-12 22:39:31 +01:00
balasu 41e4977bcb
Update addons.go 2021-07-12 23:01:05 +05:30
Pablo Caderno 746d5d14b1 Don't set conntrack parameters in kube-proxy 2021-07-12 19:31:07 +10:00
minikube-bot 35253acf40 bump default/newest kubernetes versions 2021-07-12 08:02:55 +00:00
Sharif Elgamal a8d366ffbf don't try to recreate pull secrets for refreshing gcp-auth 2021-07-08 16:15:44 -07:00
Tejal Desai 5db736cea6
Add a suggestion for unhealthy control plane.
Related to  #11417

Add a suggestion for unhealthy control plane
2021-07-08 12:37:01 -07:00
Matt Dainty de19bcb77a
Don't strip off container image prefixes 2021-07-08 18:17:35 +01:00
balasu e833905678 for portainer add-on 2021-07-08 13:22:01 +00:00
Medya Ghazizadeh 81c2bb2796
Merge pull request #11708 from afbjorklund/info-klog
Make sure to log errors from DaemonInfo
2021-07-07 13:29:05 -04:00
Medya Ghazizadeh cabf73ed59
Merge pull request #11800 from mahalrs/simplify-error-codes-11786
Simplify, and remove all un-used minikube error codes
2021-07-06 19:48:12 -04:00
Medya Gh 89c24e5fac fix 2021-07-06 10:52:41 -04:00
Medya Gh 18c841ccff update comment 2021-07-06 10:20:13 -04:00
Medya Gh f5cdc4fec3 update problematic k8s versions 2021-07-06 10:14:17 -04:00
minikube-bot 058d2b4201 bump default/newest kubernetes versions 2021-07-05 08:02:58 +00:00
Steven Powell c29adeaa06
Merge pull request #11864 from minikube-bot/auto_bump_k8s_versions
bump default/newest kubernetes versions
2021-07-02 21:32:45 +00:00
Andriy Dzikh c96c695806 Use http.StatusOK instead of 200. 2021-07-02 13:06:49 -07:00
Andriy Dzikh 6f5e85f6bf Move preload existence caching out of checkRemotePreloadExists. 2021-07-02 13:05:44 -07:00
Medya Ghazizadeh 47f32b9f2f
Merge pull request #11892 from andriyDev/fix-preload-caching
Replace single preload cache with a preload map cache.
2021-07-02 15:07:42 -04:00
Andriy Dzikh 25ba31a2b5 Replace single preload cache with a preload map cache. Also add tests. 2021-07-02 10:37:15 -07:00
Medya Gh 788eb9c5af bump default k8s 2021-07-02 10:38:19 -04:00
minikube-bot 4db717a5eb Update kicbase to v0.0.25 2021-07-01 23:38:36 +00:00
Sharif Elgamal 494a24abcc
Merge pull request #11834 from andriyDev/AutoPause
Add support for other container runtimes for auto-pause
2021-07-01 16:01:27 -07:00
Rajwinder Mahal 6a3781c575
Remove un-used error codes 2021-07-01 14:59:44 -07:00
Rajwinder Mahal 659e8c2785
Replace InternalEnable and InternalDisable with InternalAddonEnable and InternalAddonDisable 2021-07-01 14:52:24 -07:00
Sharif Elgamal 85e27c5820
Merge pull request #11773 from sharmarajdaksh/add-error-code-explanations
Adds explanations for all minikube error codes
2021-07-01 14:33:15 -07:00
minikube-bot 1a5b4ac397 bump default/newest kubernetes versions 2021-07-01 20:49:00 +00:00
minikube-bot 202e2fa36f Updating kicbase image to v0.0.24-1625170572-11834 2021-07-01 20:31:45 +00:00
Andriy Dzikh cec98ef11a Template auto-pause.service to allow injecting the correct container runtime. 2021-07-01 13:12:44 -07:00
Medya Ghazizadeh 05b64d1a74
Merge pull request #11824 from andriyDev/fix-auto-pause
Make kicbase copy auto-pause binary instead of auto-pause folder
2021-07-01 16:10:33 -04:00
Dakshraj Sharma d8adc48463 Adds explanations for minikube error codes 2021-07-01 23:22:23 +05:30
minikube-bot 2bf9076527 Updating kicbase image to v0.0.24-1625086337-11824 2021-06-30 21:07:40 +00:00
Leopold Schabel f0eaa993b9 kvm: only check libvirt membership if we failed to connect to it
Test Plan:

- Ran `go run k8s.io/minikube/cmd/minikube start --driver=kvm2`
  on a machine with polkit-based libvirt permission. This
  previously failed and now works.

- Re-ran the same command after shutting down libvirt.
  This fails with PR_KVM_USER_PERMISSION as expected.
2021-06-30 22:53:43 +02:00
Medya Ghazizadeh b8596f1a13
Merge pull request #11811 from medyagh/go_mod_godame
bump go mod libs manually
2021-06-30 15:50:45 -04:00
Medya Ghazizadeh 646060bc7b
Merge pull request #11815 from ilya-zuyev/ilyaz/fix_contains_no_runlevels_issue
Fix "kubelet Default-Start contains no runlevels" error
2021-06-30 12:55:40 -04:00
Ilya Zuyev 6cb587a873 set `SYSTEMCTL_SKIP_SYSV` for "systemctl disable --now" to suppress attempts to interract with sysv scripts 2021-06-29 14:03:39 -07:00
Medya Gh a714161f31 update go-github to v36 2021-06-29 15:46:23 -04:00
minikube-bot 8e62a7d4a0 Update ISO to v1.22.0-beta.0 2021-06-29 19:32:53 +00:00
Medya Gh 89c7853601 bump go mod libs manually 2021-06-29 15:24:59 -04:00