Commit Graph

1419 Commits (14fcdaa98b04a5439be469f32bc0031b2a6fedd1)

Author SHA1 Message Date
Marcos Diez ba20534107 we don't disable other container engines when vmdriver==none 2019-06-24 09:31:35 -03:00
Thomas Stromberg abff28db7e Universally redirect stdlog messages to glog 2019-06-23 20:58:11 +08:00
Thomas Stromberg d94d94718d Use non-unicode percent signs for proper interpolation 2019-06-23 11:44:03 +08:00
Anders F Björklund f20f223c02 Decrease cyclomatic complexity
Here is the report (from gocyclo), before:

21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
Anders F Björklund c9fabad212 Fix the simple things, gofmt and golint 2019-06-22 16:16:37 +02:00
Sharif Elgamal 247efdea15
Merge pull request #4534 from kubernetes/k8s-1.15.0
Update Kubernetes default version to v1.15.0
2019-06-21 23:27:20 -07:00
Sharif Elgamal 79e00c2e05
%v for errors 2019-06-21 15:40:01 -07:00
Sharif Elgamal 0a23696386
Suppress error message when translation file doesn't exist 2019-06-21 09:57:01 -07:00
Sharif Elgamal 37f09da483
Merge pull request #4464 from sharifelgamal/localization-poc
Add ability to localize all strings output to console
2019-06-20 17:08:28 -07:00
Thomas Strömberg 02b8032b59
Merge pull request #4385 from josedonizetti/refactor-drivers-restart
Refactor: improve readability drivers.Restart
2019-06-21 08:07:35 +08:00
Sharif Elgamal 8f5026db91
small fix 2019-06-20 14:23:53 -07:00
Sharif Elgamal 7a8fb7d489
add more entries to the blacklist and clean up translation files 2019-06-20 13:52:57 -07:00
Sharif Elgamal 3be580c97c add comment for top level command and add chinese transkations 2019-06-20 09:55:29 -07:00
Thomas Stromberg c2569cf0d7 Run goimports 2019-06-20 15:38:30 +08:00
Thomas Stromberg f26f2ad677 Refactor tests to decrease toil when adding new versions 2019-06-20 15:37:20 +08:00
Sharif Elgamal 7fc7b245e1
fix linting errors 2019-06-19 18:21:39 -07:00
Medya Ghazizadeh ead799d7c5
Remove deprecated reporting api 2019-06-19 18:02:23 -07:00
Sharif Elgamal e8329f6380
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc 2019-06-19 17:59:17 -07:00
Sharif Elgamal d1eea5343c
add demo translation file for zh-CN 2019-06-19 17:58:52 -07:00
Sharif Elgamal 062a4539b3
test actually passes now 2019-06-19 17:46:00 -07:00
Sharif Elgamal 97e2cd1153
Simplifying and correcting the extract code. Test passes now. 2019-06-19 17:44:34 -07:00
Thomas Stromberg bb30ee9e9e Update some of the example files (work still required) 2019-06-20 07:58:42 +08:00
Thomas Strömberg a4a796ea5e
Merge pull request #4407 from afbjorklund/rkt.net.d
Stop updating /etc/rkt/net.d config files
2019-06-20 07:43:11 +08:00
Thomas Strömberg 4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag
Add kvm2 --version
2019-06-20 07:41:18 +08:00
Thomas Strömberg b3c7496d52
Merge pull request #4393 from fenglixa/fix-mount-failed
Fix "mount failed: File exists" issue when unmount fails
2019-06-20 07:40:37 +08:00
Thomas Stromberg edee1c7bbd Update Kubernetes default version to v1.15.0 2019-06-20 07:36:07 +08:00
Om Kumar bf50225e02 Register registry-proxy with registry addons 2019-06-19 14:10:29 -07:00
Thomas Strömberg 32ad6e4e98
Merge pull request #4469 from fenglixa/k8s_v1.15.0-beta.1_support
Update for supporting k8s_v1.15.0-beta.1
2019-06-19 15:45:32 +08:00
Sharif Elgamal 8308aa5156
adding test 2019-06-18 11:19:05 -07:00
Sharif Elgamal 8da5f2b4a6
General cleanup for clarity 2019-06-17 13:28:10 -07:00
Sharif Elgamal 6cd86b7ca7
don't make extract an end-user command 2019-06-17 11:43:05 -07:00
Sharif Elgamal b499226597
shorten name of translate function 2019-06-17 10:58:16 -07:00
Medya Gh b332f04ac0 better var name 2019-06-15 23:17:14 -07:00
Medya Gh 4fd29be51c lint and comment 2019-06-15 22:55:57 -07:00
Medya Gh 5176806eb2 set context on profile 2019-06-15 22:18:23 -07:00
Jose Donizetti a2d844ef51 Add kvm network name validation
closes for #3581
2019-06-15 13:56:12 -07:00
Medya Gh 05177194a5 increasing time out for Pod operations 2019-06-14 16:03:23 -07:00
Anders Björklund c25ab2d107 Upgrade CNI config version to 0.3.0
Was using the default version of 0.2.0, didn't load with 0.4.0. closes https://github.com/kubernetes/minikube/issues/4406
2019-06-14 15:55:09 -07:00
Sharif Elgamal 5ef94b4c5e
Adding comments for clarity 2019-06-14 15:02:17 -07:00
Francis 31ab527da5 Improve enable/disable add-on
Closes https://github.com/kubernetes/minikube/issues/4417
2019-06-14 10:47:11 -07:00
Sharif Elgamal dae9425aa0 small changes 2019-06-14 10:17:05 -07:00
Sharif Elgamal 44856928f6
Merge pull request #4474 from medyagh/4418_fixTestVersionUpgrade
adding retriable http get
2019-06-14 10:09:46 -07:00
Medya Gh 657469310c Use retryable http to avoid connection flakes 2019-06-13 22:58:14 -07:00
Medya Ghazizadeh 6ecc1055b3
Automatically add extra options for none driver on ubuntu
Automatically add extra options for none driver on ubuntu
2019-06-13 15:13:55 -07:00
Sharif Elgamal 3ce070c6ec
extract is now a command 2019-06-12 18:11:34 -07:00
Sharif Elgamal aabce5867f
Refactor extract to not use global variables 2019-06-11 13:54:01 -07:00
fenglixa aebcec7bd0 update for support k8s_v1.15.0-beta.1 2019-06-11 21:11:31 +08:00
Sharif Elgamal 0c43731671
Small fixes to make things work 2019-06-10 14:14:38 -07:00
Sharif Elgamal 4630cccca4
linting 2019-06-10 13:11:49 -07:00
Sharif Elgamal f452f0cded
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc 2019-06-10 12:00:39 -07:00
Sharif Elgamal 3447499a33
Robust extraction yaaaaaaaay 2019-06-10 11:45:14 -07:00
Sharif Elgamal 7d89ac131c
Merge pull request #4444 from sharifelgamal/k8s-1.14.3
Upgrade to kubernetes 1.14.3
2019-06-07 12:03:14 -07:00
Sharif Elgamal dfd9b6b83d
Merge pull request #4431 from Pradip-Khakurel/issue-#4161-WantShowDriverDeprecationNotification-setting
fix ShowDriverDeprecationNotification config setting
2019-06-07 11:30:25 -07:00
Sharif Elgamal 7119f57045
Upgrade to kubernetes 1.14.3 2019-06-06 14:12:09 -07:00
Sharif Elgamal 610e4f1159
More extractor work 2019-06-06 14:10:32 -07:00
Anders F Björklund f4aaef7d25 Cache: don't use ssh runner for the none driver 2019-06-06 13:20:43 +02:00
Pradip-Khakurel bb78d3eb31 fix ShowDriverDeprecationNotification config setting 2019-06-05 23:30:13 +02:00
josedonizetti a024c6d22a Add kvm2 --version 2019-06-04 16:45:14 -03:00
Medya Gh 7c8a0e224b fix mistake logic 2019-06-04 09:25:06 -07:00
Medya Gh 79ba9a17a2 typo 2019-06-03 20:32:29 -07:00
Medya Gh 6d57b28fdd changing string driver name to checked type 2019-06-03 20:27:26 -07:00
Anders F Björklund c67ff35579 Stop updating /etc/rkt/net.d config files
We have now removed rkt, should be enough with cni
2019-06-02 20:57:55 +02:00
fenglixa cfaac81707 update cases to ensure make test PASS 2019-06-02 21:11:20 +08:00
fenglixa 12b350b518 fix issue 4239 2019-05-31 10:27:02 +08:00
Sharif Elgamal 483f9fb19e
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc 2019-05-30 15:26:20 -07:00
josedonizetti 0e633533c2 Refactor: improve readability drivers.Restart 2019-05-30 17:24:28 -03:00
Benn Linger 529b5aa389
Fixed addon-manager failing with non-default --apiserver-port 2019-05-30 16:21:44 -04:00
Sharif Elgamal 94e9c002a6
Merge pull request #4381 from josedonizetti/fix-kvm-gpu-log
Fix kvm gpu log
2019-05-30 13:09:37 -07:00
Sharif Elgamal 16af8b403c
Merge pull request #4376 from sharifelgamal/style-enum
Change console style string to enum
2019-05-30 11:06:34 -07:00
josedonizetti 986c61d15e Fix kvm gpu log 2019-05-30 14:56:46 -03:00
Sharif Elgamal 94932dd5e5
Remove unnecessary HasStyle function 2019-05-30 10:53:43 -07:00
Sharif Elgamal f424969553
Initialisms, man. 2019-05-30 10:40:45 -07:00
Sharif Elgamal 984f563e21
remove unnecessary String() implementation 2019-05-30 10:18:40 -07:00
Sharif Elgamal 6d507fbcd1
Fixing variable style 2019-05-29 19:19:33 -07:00
Sharif Elgamal 34ccd2ad41
Change console style string to enum 2019-05-29 18:45:55 -07:00
Sharif Elgamal fbc11c327a
Recursive search for extractor 2019-05-29 14:35:28 -07:00
tstromberg 9c996a7796 Clarify log message 2019-05-29 11:55:20 -07:00
tstromberg 3a63a512db Wait up to 3 minutes for the apiserver to become healthy 2019-05-29 11:54:45 -07:00
Medya Gh 09a1cc5179 fix func name in comment 2019-05-29 11:06:25 -07:00
Thomas Strömberg 56ec0aeb10
Merge pull request #4283 from tstromberg/timesunk
Sync guest system clock if desynchronized from host
2019-05-29 10:34:24 -07:00
Thomas Strömberg db37c03063
Merge pull request #4364 from tstromberg/no-docker-version
docker-env: Remove DOCKER_API_VERSION
2019-05-29 10:27:43 -07:00
Thomas Strömberg c83d5f712d
Merge pull request #2797 from shahiddev/master
Disable hyperv dynamic memory for hyperv driver
2019-05-29 10:27:20 -07:00
Thomas Stromberg 0afdce2d6d Address lint issue 2019-05-28 20:59:53 -07:00
Thomas Stromberg 27dcd40983 Pull logic out to ensureSyncedGuestClock 2019-05-28 20:57:26 -07:00
Thomas Stromberg 035331b96b Add testing 2019-05-28 20:24:01 -07:00
Thomas Stromberg 5dd0890fc7 Set a realistic desync value 2019-05-28 19:12:00 -07:00
Thomas Stromberg 3c39723d41 Merge branch 'master' into timesunk 2019-05-28 19:10:14 -07:00
Thomas Stromberg 2bf84b1593 Make maxClockDesyncSeconds a float for clarity & ease of calling math.Abs 2019-05-28 19:10:09 -07:00
Thomas Stromberg b0d8d7feb3 Refactor for testability 2019-05-28 18:58:56 -07:00
Thomas Stromberg a3f557d870 Remove dangling references to DockerAPIVersion 2019-05-28 17:21:26 -07:00
Thomas Strömberg dbc64c053b
Merge pull request #4355 from josedonizetti/fix-kvm-remove-when-domain-is-not-defined
Fix kvm remove when domain is not defined
2019-05-28 17:07:53 -07:00
Thomas Strömberg dcb10332a0
Merge pull request #4334 from josedonizetti/refactor-kvm-lookup-status-ip
Refactor kvm lookupIPFromStatusFile
2019-05-28 10:26:02 -07:00
josedonizetti c09913070d Fix kvm remove when domain is not defined 2019-05-25 09:23:40 -03:00
Shahid Iqbal 5ed19ee7bd disable hyperv dynamic memory for hyperv driver 2019-05-25 10:17:07 +01:00
Thomas Strömberg 8f9a3f448d
Merge pull request #4344 from josedonizetti/fix-kvm-remove-when-domain-is-not-running
Fix kvm remove when domain is not running
2019-05-24 13:55:04 -07:00
Thomas Strömberg bb56fd2eb7
Merge pull request #4323 from josedonizetti/fix-kvm-ensure-network
kvm2: Add support for --kvm-network to ensureNetwork
2019-05-24 10:47:41 -07:00
josedonizetti 48237d95b8 Clean up kvm Remove code 2019-05-24 14:27:55 -03:00
josedonizetti b65c7403cf Add error warp to destroyRunningDomain 2019-05-24 14:27:55 -03:00
josedonizetti 3124f11e1b Fix kvm remove when domain is not running 2019-05-24 14:27:55 -03:00
josedonizetti 81f0d9ba37 Fix kvm remove warn message 2019-05-24 12:38:00 -03:00
josedonizetti 1852a72caf Refactor kvm lookupIPFromStatusFile 2019-05-23 15:38:02 -03:00
josedonizetti fc2e2e52c5 Skip kvm network deletion if private network doesn't exist 2019-05-23 06:17:12 -03:00
josedonizetti 93329f1619 Remove obsolete comment 2019-05-22 17:25:27 -03:00
josedonizetti e3bf4bd7ec Fix kvm ensureNetwork 2019-05-22 16:19:09 -03:00
Thomas Strömberg 5e4201786f
Merge pull request #4308 from josedonizetti/validate-kvm-network-exist
Validate kvm network exists
2019-05-21 15:08:54 -07:00
Thomas Strömberg 28edca2cfb
Merge pull request #4306 from tstromberg/docker-backwards-compat
Disable SystemVerification preflight on Kubernetes releases <1.13
2019-05-21 15:08:40 -07:00
tstromberg ba28a73495 Improve KVM2_START_NO_IP, add KVM2_QEMU_MONITOR, DRIVER_CRASHED, and DRIVER_EXITED 2019-05-21 15:01:50 -07:00
tstromberg 11cdcef0e1 Add log statement 2019-05-21 13:14:17 -07:00
josedonizetti e9a450df66 Validate kvm network exists 2019-05-21 16:19:15 -03:00
tstromberg 14b4e17cc1 Fix version comparison 2019-05-21 12:01:47 -07:00
tstromberg 04f6cf1230 Improve how we document Port-10250 and Swap 2019-05-21 11:52:45 -07:00
tstromberg 9d2c0b202c Disable SystemVerification preflight on Kubernetes releases <1.13 2019-05-21 11:47:12 -07:00
tstromberg 44c18008b6 Add missing testdata update to v1.14.2 2019-05-20 13:34:06 -07:00
Thomas Strömberg 9d09ff069b
Merge pull request #4229 from medyagh/no_proxy_for_self
Allow minikube to function with misconfigured NO_PROXY value
2019-05-20 11:22:12 -07:00
Thomas Strömberg f74c62a667
Merge pull request #4282 from tstromberg/apiserver-no-oom
Set apiserver oom_adj to -10 to avoid OOMing before other pods
2019-05-20 11:20:56 -07:00
Thomas Strömberg 35dc6a2ff2
Merge pull request #3892 from 11janci/jjanik-expose-pod-cidr
Expose ‘—pod-network-cidr’ argument in minikube
2019-05-20 08:14:03 -07:00
Thomas Strömberg 00832dc182
Merge pull request #4204 from afbjorklund/docker-18.09
Upgrade Docker, from 18.06.3-ce to 18.09.5
2019-05-20 08:12:55 -07:00
Medya Gh b6bf1dff8d Improve test clean up 2019-05-19 14:45:21 -07:00
Sharif Elgamal e174f3bdc6
Add semi-functional extractor 2019-05-17 14:20:25 -07:00
Thomas Strömberg a4895e9024
Merge pull request #4279 from tstromberg/v1.14.2
Upgrade default Kubernetes release to v1.14.2
2019-05-17 13:01:25 -07:00
tstromberg 424be87071 Improve log messages 2019-05-17 11:01:58 -07:00
tstromberg 7c100538e8 Merge remote-tracking branch 'upstream/master' 2019-05-17 10:47:34 -07:00
tstromberg 80c692e88d Add prehistoric system clock synchronization 2019-05-17 10:47:26 -07:00
Thomas Strömberg 93507eb9db
Merge pull request #4281 from tstromberg/console-err-msg
log the intended message when errFile/outFile are unset
2019-05-17 10:09:32 -07:00
Thomas Stromberg d97584ad61 Address merge conflicts 2019-05-17 07:40:10 -07:00
Thomas Stromberg 727be6ec0d Set apiserver oom_adj to -16 to avoid OOMing before other pods 2019-05-17 07:29:32 -07:00
Thomas Stromberg 4a32c053b6 log the intended message when errFile/outFile are unset 2019-05-17 06:17:44 -07:00
Thomas Strömberg af049bd477
Merge pull request #4276 from tstromberg/proxy-restart2
Restart kube-proxy using kubeadm & add bootstrapper.WaitCluster
2019-05-17 06:12:36 -07:00
Thomas Stromberg affd351905 Merge branch 'master' into v1.14.2 2019-05-16 22:20:07 -07:00
Jan Janik 21b9e95647 Whitelist for kubeadm extra args 2019-05-17 17:11:03 +12:00
Jan Janik 6fe47f3677 Expose ‘—pod-network-cidr’ argument in minikube 2019-05-17 16:59:06 +12:00
Medya Gh d4cf3b0f89 Merge remote-tracking branch 'upstream/master' into no_proxy_for_self 2019-05-16 21:57:38 -07:00
Thomas Stromberg f1342b665c Upgrade default Kubernetes release to v1.14.2 2019-05-16 21:44:35 -07:00
Thomas Stromberg 8445f786a2 Clean up new lint issues brought in by the #3464 merge 2019-05-16 19:50:27 -07:00
Thomas Strömberg b65d602b0b
Merge pull request #3464 from ceason/tunnel-dns
WIP: Resolve service FQDNs from host during 'minikube tunnel' (macOS)
2019-05-16 19:12:06 -07:00
Thomas Stromberg 2ea63fb658 Remove deferred log statement 2019-05-16 16:32:46 -07:00
Medya Gh 3ff806a595 Added unittest and rebase 2019-05-16 14:44:01 -07:00
Sharif Elgamal 03ebb0e0f5
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc 2019-05-16 13:50:39 -07:00
Thomas Stromberg 802586f3b9 Use waitForAPIServer, as it gives better signal than asking the apiserver about itself 2019-05-16 13:42:35 -07:00
Thomas Stromberg e535268db5 Use kubeadm to restart kube-proxy rather than rolling our own 2019-05-16 13:28:12 -07:00
Thomas Strömberg 6bc6c3fe87
Merge pull request #4253 from tstromberg/gomods
De-lint everything and replace "go lint" with golangci-lint
2019-05-15 23:15:35 -07:00
Medya Gh f38efb95df Improved Style 2019-05-15 17:33:10 -07:00
Medya Gh a2590ecdb2 Adding more unit test 2019-05-15 17:30:27 -07:00
Maximilian Hess 88a14890a8 Make derivation of Host IP address more generic when using vmware. 2019-05-15 16:59:45 -07:00
Maximilian Hess 53a46251e1 Return host IP when using vmware as vm driver.
Adds the missing case "vmware" to return the host IP.
2019-05-15 16:59:45 -07:00
Kubernetes Prow Robot 867443c1cc
Merge pull request #4255 from ne0h/mount-vmware
Return host IP when using vmware as vm driver.
2019-05-15 15:57:17 -07:00
Medya Gh 08d19bf15a Improve formatting and messages 2019-05-15 15:39:50 -07:00
Medya Gh e878f9badb Merge remote-tracking branch 'upstream/master' into no_proxy_for_self 2019-05-15 14:19:14 -07:00
Thomas Strömberg 2a4270c803
Merge pull request #4257 from tstromberg/solution-msgs
Add more solutions messages
2019-05-15 11:50:51 -07:00
Medya Gh b9149b1eb0 Better name 2019-05-15 11:44:31 -07:00