Commit Graph

1419 Commits (14fcdaa98b04a5439be469f32bc0031b2a6fedd1)

Author SHA1 Message Date
Medya Gh 14fcdaa98b make constant profile funcs more testable 2019-07-19 10:21:47 -07:00
Medya Gh cd80371aad Addded unit test for profile list 2019-07-18 22:13:32 -07:00
Medya Gh b17376cccf Refactor profile, detect invalid profiles 2019-07-18 18:23:26 -07:00
Medya Gh 63a6754f9d Add testdata for profile 2019-07-18 16:17:26 -07:00
Medya Gh 5b22779d99 Add comments 2019-07-18 14:31:11 -07:00
Medya Gh 9efc2f579d Added all profile funcs 2019-07-18 14:29:13 -07:00
Medya Gh 6a08732179 Added profile type 2019-07-18 14:27:35 -07:00
Sharif Elgamal 45974d911d
remove test checking for up to date translation files (#4808) 2019-07-18 13:15:09 -07:00
Sharif Elgamal 93263bc2bc
Templatizing more calls to console 2019-07-17 18:06:06 -07:00
Medya Gh e49d193cd7 Move up nil check the chain 2019-07-17 17:42:20 -07:00
Medya Gh 4fd0f757af Fix OutT 2019-07-17 17:38:25 -07:00
Thomas Stromberg 054fc946f1 Pass most tests 2019-07-17 17:13:12 -07:00
Thomas Stromberg cbd7d702ef Merge remote-tracking branch 'upstream/master' 2019-07-17 16:55:06 -07:00
Thomas Stromberg 3d7c657eaf Templated output migration 2019-07-17 16:54:56 -07:00
Sharif Elgamal b40011b2e3
Add T versions of the console convenience functions (#4796)
* Add T versions of the console convenience functions

* more changes

* Make OutT and ErrT more convenient and add WithCodeT:

* add UsageT

* make extract

* translate messages in displayError
2019-07-17 15:19:49 -07:00
Sharif Elgamal 24ad1d82b9
Add test to make sure translations files are up to date. (#4777)
* Add test to make sure translations files are up to date.

* Fix file path sadness so tests work as expected

* make sure we reset the working dir

* switching from bytes.Compare to cmp.Diff

* add better error message

* extract new localized strings

* fix tests
2019-07-17 13:49:39 -07:00
Medya Ghazizadeh 4178c4486d
Merge pull request #4794 from medyagh/hyperkit_errmap
Add advice if crash on hyperkit not installed
2019-07-17 13:03:27 -07:00
Medya Gh f68764cbc3 Add advice for hyperkit install instead of crash 2019-07-17 12:58:58 -07:00
Thomas Strömberg 3555ae5fb4
Merge branch 'master' into not-an-err 2019-07-17 11:14:32 -07:00
Thomas Strömberg 03fb063281
Merge pull request #4790 from tstromberg/issue-url-chooser
Update github issues URL now that we have issue templates
2019-07-17 11:08:09 -07:00
Anders F Björklund df7922881c Add missing ErrMapFile docs, to make golint happy 2019-07-17 19:40:19 +02:00
Jose Donizetti 6ded92edbe Fix darwin constants 2019-07-17 14:19:40 -03:00
tstromberg 1d3cea757b Update github issues URL to chooser 2019-07-17 09:58:31 -07:00
tstromberg 80fc10167f Merge conflicts 2019-07-17 09:41:53 -07:00
Thomas Strömberg bed7b8eb3e
Merge pull request #4729 from afbjorklund/none-info
Show more relevant information, when using none driver
2019-07-17 09:34:48 -07:00
tstromberg 1dc2afc748 Address more merge conflicts 2019-07-17 09:05:47 -07:00
Thomas Strömberg fe6e2b15e2
Merge pull request #4738 from josedonizetti/move-supported-drivers-per-platform
Move supported drivers per platform
2019-07-17 09:02:37 -07:00
tstromberg d0ae6e9d3b Obsolete driver lint issues 2019-07-16 15:16:51 -07:00
tstromberg 6729f6cfe4 Remove remaining DriverXhyve and DriverKvmOld references 2019-07-16 13:54:24 -07:00
tstromberg 914713f388 Remove deprrecated drivers: kvm-old and xhyve 2019-07-16 13:40:00 -07:00
josedonizetti 2ed16a1198 Move supported drivers per platform 2019-07-16 15:06:55 -03:00
Sharif Elgamal 941c7d5fb2
moving checks to their relevant stops so unit tests work 2019-07-15 13:38:12 -07:00
Sharif Elgamal 77931fb4e2
Merge branch 'master' of github.com:kubernetes/minikube into extract-advice 2019-07-15 13:36:48 -07:00
Sharif Elgamal a7d5309f8e
fix lint 2019-07-15 11:17:08 -07:00
Anders F Björklund 7584d6aa08 Move hostInfo into function, add error checking 2019-07-14 10:19:54 +02:00
Sharif Elgamal 92bb35137b
Make sure err_map.go exists 2019-07-12 15:28:26 -07:00
Thomas Strömberg 76c456b998
Merge pull request #4739 from sharifelgamal/tmo-extract-test
Use tempfile for extract test
2019-07-12 15:14:53 -07:00
Thomas Strömberg b50aa37407
Revert "Refactor status command" 2019-07-12 14:23:38 -07:00
tstromberg 71ab89dfc2 Reduce kubectl restart time from 10 seconds to 600ms 2019-07-12 09:55:15 -07:00
Anders F Björklund 2b986ef638 Fix golint complaint about new OutT/ErrT functions 2019-07-11 22:03:22 +02:00
Sharif Elgamal f16ae95724 check error value 2019-07-11 12:19:41 -07:00
Kubernetes Prow Robot 65c6f9e5a3
Merge pull request #4686 from josedonizetti/refactor-status-cmd
Refactor status command
2019-07-11 11:54:10 -07:00
Sharif Elgamal c8f9562555 Use tempfile for extract test 2019-07-11 11:53:18 -07:00
Thomas Strömberg 82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
Add space after // comments
2019-07-11 11:53:15 -07:00
Thomas Strömberg b0b13e1a7c
Merge pull request #4545 from marcosdiez/dont_disable_container_engines_when_vmdriver_is_none
Don't disable other container engines when --vm_driver=none
2019-07-11 11:17:57 -07:00
Sharif Elgamal 6c2c00b754
fixing lint 2019-07-10 11:44:49 -07:00
Sharif Elgamal ad4d55f0ad
Merge branch 'master' of github.com:kubernetes/minikube into extract-advice 2019-07-10 10:24:36 -07:00
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677)
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
2019-07-10 10:17:28 -07:00
Anders F Björklund fdb4f9b167 Show "localhost" information for none driver 2019-07-10 17:27:55 +02:00
Anders F Björklund 4642b66ebc Don't lie about creating a VM with none driver 2019-07-10 13:47:24 +02:00