Commit Graph

1612 Commits (5cba1d80a05816bfdc4fd5263d66b63e25f2d11c)

Author SHA1 Message Date
jimtng 5cba1d80a0
Tag Input: Prevent user from adding a semantic tag (#2983)
When the tag input is supposed to filter out semantic tags, also prevent user from entering them.
It is up to the caller of tag-input form to determine whether it can accept semantic tags or not,
by specifying it in the `showSemanticTags` property.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2025-01-07 23:28:46 +01:00
jimtng 331ec6b79e
Thing Copy: Fix channel uid of copied Thing (#2984)
Fixes #2977.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2025-01-07 23:22:06 +01:00
Holger Friedrich 438854f482
Fix JavaDoc output directory (#2989)
Regression, fix issue introduced by #2972.
JavaDoc output dir changed from target/site to target/reports.
This will get it back to the known location.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2025-01-07 21:48:58 +01:00
Wouter Born 824bbc4711
Start license headers with `/*` instead of `/**` (#2988)
Prevents JavaDoc tooling issues because these tools check comments
starting with `/**`.

Depends on #2987

Signed-off-by: Wouter Born <github@maindrain.net>
2025-01-07 18:49:02 +01:00
Wouter Born fe0be2e322
Upgrade SAT to 0.17.0 (#2987)
For release notes, see:

https://github.com/openhab/static-code-analysis/releases/tag/0.17.0

Signed-off-by: Wouter Born <github@maindrain.net>
2025-01-07 18:43:11 +01:00
Florian Hotze b69589bdb1
Developer tools: Add WS connection test (#2981)
Depends on https://github.com/openhab/openhab-core/pull/4540.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2025-01-06 20:00:21 +01:00
jimtng 7ac9838c9e
Fix Schedule page shows UTC instead of local timezone (#2969)
Reported in:
https://community.openhab.org/t/shown-time-in-schedule-view-is-wrong/161288
https://community.openhab.org/t/schedule-page-in-mainui-off-by-one-hour-since-4-3/161307

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2025-01-04 21:59:35 +01:00
Florian Hotze 75e866792a
WS client: Remove trailing `=` from base64-encoded access token (#2976)
Follow-up for #2907.

Fixes WS client broken due to `=` being part of the base74-encoded
token, which is no allowed WS subprotocol value.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2025-01-04 18:11:27 +01:00
Florian Hotze 6104cba46d
Add Inbox approve menu to add Thing of binding page (#2973)
Supersedes #2921.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2025-01-04 17:06:42 +01:00
Florian Hotze f1c3896897
Widget expressions: Fix handling of Item name being `undefined` & Align behaviour for @ and @@ shorthands in that case (#2965)
Fixes #2956.
This fix creates the limitation that an Item must not be named
`undefined` - for an Item with this name, state tracking won't work.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2025-01-04 16:13:18 +01:00
Holger Friedrich 4380671878
Upgrade plugins (#2972)
* frontend-maven-plugin to 1.15.1
* sortpom-maven-plugin to 4.0.0 (breaking change)
https://github.com/Ekryd/sortpom?tab=readme-ov-file#news
* license-maven-plugin to 4.6
https://github.com/mathieucarbou/license-maven-plugin/releases
* maven-clean-plugin to 3.4.0
https://github.com/apache/maven-clean-plugin/releases/tag/maven-clean-plugin-3.4.0
* maven-dependency-plugin to 3.8.1
* maven-enforcer-plugin to 3.5.0
https://github.com/apache/maven-enforcer/releases
* maven-install-plugin to 3.1.3
https://github.com/apache/maven-install-plugin/releases
* maven-jar-plugin to 3.4.2
https://github.com/apache/maven-jar-plugin/releases/tag/maven-jar-plugin-3.4.2
* maven-javadoc-plugin to 3.11.2
* maven-release-plugin to 3.1.1
* maven-site-plugin to 3.21.0
* maven-surefire-plugin to 3.5.2
* build-helper-maven-plugin to 3.6.0
https://github.com/mojohaus/build-helper-maven-plugin/releases/tag/3.6.0


leaving out the remaining
```
[INFO]   org.codehaus.mojo:jaxb2-maven-plugin ....................................................... 2.5.0 -> 3.2.0
[INFO]   org.openapitools:openapi-generator-maven-plugin ........................................... 4.3.0 -> 7.10.0
```
for now....

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2025-01-04 14:13:30 +01:00
Florian Hotze 095584a137
Model tabs: Fix left/right margin to small on mobile (#2964)
Signed-off-by: Florian Hotze <dev@florianhotze.com>
2025-01-01 19:25:13 +01:00
Wouter Born 4610a15ad1
Update license headers to 2025 (#2963)
Updates the license headers to 2025.

Signed-off-by: Wouter Born <github@maindrain.net>
2025-01-01 17:09:54 +01:00
Florian Hotze 85616e1fb5
Refactor websocket code to `$oh` namespace & Pass access token through header (#2907)
Depens on https://github.com/openhab/openhab-core/pull/4515.

This refactors the WebSocket connection code from #2884 to the `$oh`
namespace, same as it is for the SSE logic.
It also passes the access token as WebSocket subprotocol so it is sent
with the `Sec-WebSocket-Protocol` header.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-31 17:02:06 +01:00
Florian Hotze f424e2b914
Layout pages: Safe area fixes & related code improvements (#2959)
Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-31 16:52:12 +01:00
Nadahar 0706f3a2b7
Enable additional chart types for `oh-data-series` (#2946)
This enables the use of all imported ECharts in (custom) widgets using `oh-data-series`.
2024-12-31 15:40:32 +01:00
openhab-bot f3a973e4d3
New Crowdin updates (#2955) 2024-12-31 15:39:39 +01:00
jimtng 2028872bfc
Allow item names to start with an underscore (#2958)
Reported in
https://community.openhab.org/t/openhab-4-3-item-name-starting-with-underscore/161244

Regression from #2658

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2024-12-31 15:31:09 +01:00
Florian Hotze 512ecce304
Page: Add ability to edit current tab of tabbed page (#2953)
Closes #2899.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-28 15:54:22 +01:00
Florian Hotze 1f4673f415
Widget mixin: Fix JS error when using both trendline & stylesheet (#2952)
Fixes #1423.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-28 15:40:27 +01:00
Florian Hotze 802d41284a
Thing details: Show error message when modifying disabled Thing (#2951)
Do not fail silently.

Fixes #1590.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-28 15:10:01 +01:00
Florian Hotze ba1772c6c0
Thing details: Fix Z-Wave network map shown if not Z-Wave binding (#2950)
Fixes #2940.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-28 13:38:23 +01:00
Florian Hotze 5d7f35a824
Don't subscribe to Item events to reload model (#2949)
Related to #2584 and
https://github.com/openhab/openhab-core/issues/4466.

This avoids that the global SSE connection is always established, and
therefore reduces problems with the max parallel HTTP connections
limitation. The global SSE connection is now only established if the web
audio sink or the command Item are enabled.

Whilst this change potentially makes the UI not reload the model
automatically on change, practically the now removed mechanism might
haven't been really useful at all because the model is already reloaded
on Main UI start, and if SSE was not connected the moment an Item
changed the mechanism did not trigger.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-28 13:34:02 +01:00
openhab-bot ad971dc8bc
New Crowdin updates (#2916) 2024-12-28 13:21:56 +01:00
Mark Herwege 15463f894f
Sitemap editor: Add drag & drop (#2904)
This PR implements drag and drop in the sitemap tree, to make it easier
to graphically rearange sitemaps.
To achieve this, [Vue.Draggable](https://github.com/SortableJS/Vue.Draggable) (by itself
based on SortableJS) is included.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
2024-12-28 13:20:52 +01:00
stefan-hoehn df02810c3b
Interactive SVG canvas: Add String Type support (#2948)
Adds String type support to the interactive SVG canvas by allowing to
compare a string to a specific value that is perceived as state ON:

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
2024-12-28 11:52:04 +01:00
Florian Hotze bd9c6f0c36
Link add/edit: Fix profile selection (#2941)
Regression from #2690.

Reported here:

https://community.openhab.org/t/enocean-impossible-to-link-a-rockerswitch-channel-with-an-item-in-main-ui-there-is-no-profile-available-for-the-selected-item/160987

When creating a Thing channel link to an item, the profile selection are
disabled. This presents two problems:

- It made linking a trigger channel to an item not possible, because a
profile must be selected, but they're disabled.
- Linking a non-trigger channel to a new item is possible, but selecting
a profile is not possible at link creation. The user has to create the
link without a profile first, then go back to edit the link in order to
assign a profile.

When editing a channel link, profile selection was possible for
unsupported profiles, e.g. when editing a link between a Switch Item and
a Number channel, one could edit the link to use the default or follow
profiles.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-24 09:46:23 +01:00
Florian Hotze 3861fa8f27
Things list: Do not listen to InboxUpdatedEvents (#2942)
Fixes #2395.
Supersedes #2918.

Those do not change the inbox count and hence can be ignored.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-22 17:39:12 +01:00
Mark Herwege 8d8e46ad5b
Import treeview items locally & Clean-up sitemap page components (#2915)
See https://github.com/openhab/openhab-webui/pull/2904#issuecomment-2537081847
and https://github.com/openhab/openhab-webui/pull/2904#issuecomment-2537277268

This moves the import from the treeview items for model and sitemap out
of app.js and removes the sitemap page elements as this was never used.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
2024-12-22 17:20:58 +01:00
dependabot[bot] ba1c988ebf
Bump nanoid from 3.3.7 to 3.3.8 in /bundles/org.openhab.ui/web (#2922)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-22 17:12:17 +01:00
dependabot[bot] b3b32be705
Bump elliptic from 6.5.7 to 6.6.1 in /bundles/org.openhab.ui/web (#2887)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.1.

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-22 17:06:21 +01:00
jimtng 0071de993c
Fix enabled profiles in link editor appear disabled (#2938)
Reported on the community:
https://community.openhab.org/t/enocean-impossible-to-link-a-rockerswitch-channel-with-an-item-in-main-ui-there-is-no-profile-available-for-the-selected-item/160987/40

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2024-12-22 15:48:10 +01:00
Florian Hotze 0ead7b8100
Widget expressions: Fix screen object not properly initialized & updated (#2933)
Fixes #2929.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-22 01:48:33 +01:00
Florian Hotze 56e0ebe23e
`oh-clock-card`: Remove (broken) background property in favour of style config (#2932)
This avoids confusion because `background` is not working anymore.
Use `style: background: ` instead.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-19 15:31:40 +01:00
Florian Hotze a907cc3319
`oh-card`: Fix action & tap-hold action not working (#2931)
Regression from #2781.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-19 15:09:07 +01:00
Florian Hotze 511b9493bb
Fix scripting add-on availability check for old JS Scripting MIME type (#2928)
Regression from #2743.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-17 16:14:23 +01:00
Holger Friedrich 97b37f6cc9
Fix problem matchers (#2926)
Regression, but introduced with #2925

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2024-12-16 08:39:11 +01:00
Holger Friedrich 9cafa80b60
Remove Java 17 build, switch to 21 (#2925)
Related to  openhab/openhab-core#4483

---------

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2024-12-15 23:21:28 +01:00
Florian Hotze 148248900d
CODEOWNERS: Add Blockly maintainers (#2923)
Add @stefan-hoehn as Blockly CODEOWNER so he is automatically requested
for review in his role as Blockly maintainer.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-15 20:39:41 +01:00
Holger Friedrich b54f9d2297
Prepare for OH 5.0.0 (#2924)
* Fix spotless after unleash

Depends on https://github.com/openhab/openhab-core/pull/4496

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2024-12-15 19:41:01 +01:00
openhab-bot f5a4bb3388 [unleash-maven-plugin] Preparation for next development cycle. 2024-12-15 17:12:57 +00:00
Arne Seime 8b8732ceaf
Update CONTRIBUTING with missing npm lint scripts (#2919)
Signed-off-by: Arne Seime <arne.seime@gmail.com>
2024-12-14 09:27:27 +01:00
Yannick Schaus c2ae0ab5d3
Log viewer: only render lines around visible area (#2905)
This should fix the performance problems in the log viewer when the
number of items reaches the max buffer size.

---------

Signed-off-by: Yannick Schaus <github@schaus.net>
2024-12-13 15:17:02 +01:00
Florian Hotze dfd1e453c2
Unit metadata edit: Add missing padding (#2913)
Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-11 17:55:25 +01:00
Florian Hotze b6233259b1
Update unit definitions (#2912)
Refs https://github.com/openhab/openhab-core/pull/4467.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-11 17:47:42 +01:00
Florian Hotze a55edca789
Update openhab-js tern defs (#2911)
This updates the tern defs used for autocompletion to the current
library version included in the add-on (5.8.1).

See https://github.com/openhab/openhab-js/compare/v5.3.1...v5.8.1 for
changes.

Last update was in #2642.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-11 17:09:38 +01:00
Florian Hotze b6118058ce
Fix safe-area issues (#2910)
This fixes safe-area issues all over the UI:

- Issues where the safe area was applied to elements where it should
not, e.g. the settings menus' entries.
- Issues where the safe area was missing, e.g. model cards, which were
hidden under the notch.

Due to webpack's CssMinimizerPlugin minimizing `0px` to `0` when
overriding the Framework7 safe area CSS vars, which then broke the
calculation, a new .css file has been introduced.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-10 20:52:07 +01:00
Florian Hotze 1783d8fe73
Log viewer: Fix styling issues on mobile devices (#2908)
- Fix navbar button color and arrangement on iOS devices.
- Remove tooltip for iPhones as it is hidden behing the notch, which
looks weird.
- Fix safe area issues with log table and badge in landscape on iPhone.
- Clean-up code a bit.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
2024-12-10 14:26:24 +01:00
openhab-bot 8823e0e9c6
New Crowdin updates (#2909) 2024-12-10 00:11:00 +01:00
openhab-bot 7e8f460802
New Crowdin updates (#2906) 2024-12-09 23:25:59 +01:00