OpenHAB
/
openhab-webui
mirror of https://github.com/openhab/openhab-webui.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Tag Input: Prevent user from adding a semantic tag (#2983) 

When the tag input is supposed to filter out semantic tags, also prevent user from entering them.
It is up to the caller of tag-input form to determine whether it can accept semantic tags or not,
by specifying it in the `showSemanticTags` property.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
pull/2982/head
jimtng 2025-01-08 08:28:46 +10:00 committed by GitHub
parent 331ec6b79e
commit 5cba1d80a0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
bundles/org.openhab.ui/web/src/components/tags/tag-input.vue
View File

@ -53,17 +53,24 @@ export default {
if (tag === 'Scene') return true
},
addTag () {
const newTag = this.pendingTag
this.pendingTag = ''
// Block adding of Scene or Script tags in the wrong editor
// Adding them would otherwise lead to a situation where the rule/scene/script is not visible in the UI
if ((!this.inScriptEditor && this.pendingTag === 'Script') ||
(!this.inSceneEditor && this.pendingTag === 'Scene')) {
this.pendingTag = ''
if ((!this.inScriptEditor && newTag === 'Script') ||
(!this.inSceneEditor && newTag === 'Scene')) {
return
}
if (this.pendingTag && this.item.tags.indexOf(this.pendingTag) === -1) {
this.item.tags.push(this.pendingTag)
if (newTag && this.item.tags.indexOf(newTag) === -1) {
if (!this.showSemanticTags && this.isSemanticTag(newTag)) {
this.$f7.dialog.alert(
`The tag '${newTag}' is a semantic tag. A semantic tag cannot be added here.`,
'Cannot add tag'
)
return
}
this.item.tags.push(newTag)
}
this.pendingTag = ''
},
keyPressed (evt) {
this.pendingTag = evt.target.value