Multiple calls to w.WriteHeader were possible if there was an error that
was encountered while encoding the response. To resolve this, we simply
log any error that is encountered instead.
In go1.11, go mod vendor can modify go.sum when go.mod contains replace
directives. This behavior has been fixed in go1.12, so just work around
it for now.
Fixes#2056.
There were two issues.First the `chronograf` subdir was not listed.
Second the tmpl generate dependency was not listed in the tools.go list
of dependencies.
Fixes#2044
* Introduce clockface components for grid layout
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Remove child type enforcement on grid row
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Improve naming of grid column props
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Implement Grid components in view options
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Add default prop to grid column
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Remove concept of grid layout from form elements
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Introduce validated form element
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Optionally render components into a form label
Co-Authored-By: Delmer <ofthedelmer@users.noreply.github.com>
* Make linter happy via massive cleanup
* Update snapshots and fix failing test
* Add optional "required" to form elements
* Clean up grid usage in line graph options
* Update snapshot
Steps taken:
- go test -short ./... repeatedly, and on each checksum failure:
- remove line for that repository from go.sum, and re-run go test
- go mod tidy repeatedly, and on each checksum failure:
- remove line for that repository from go.sum, and re-run go mod tidy
I think this fixes local development, but it is unlikely to succeed on
CI until other images also migrate to go1.11.4. Unfortunately, the
docker image for go1.11.4 has not yet been published.
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Michael Desa <mjdesa@gmail.com>
feat(kv): add kv store interface for services
feat(bolt): add boltdb implementation of kv.Store
spike(platform): add kv backed user service
feat(kv): add static cursor
Note here that this operation cannot be transactionally done. This poses
a bit of issues that will need to be worked out.
fix(bolt): use error explicit error message
squash: play with interface a bit
fix(kv): remove commit and rollback from kv interface
feat(inmem): add inmem kv store
chore: add note for inmem transactions
fix(bolt): remove call to tx in kv store tests
feat(kv): add tests for static cursor
doc(kv): add comments to store and associated interfaces
doc(bolt): add comments to key value store
feat(testing): add kv store tests
test(testing): add conformance test for kv.Store
test(inmem): add kv.Store conformance tests
doc(inmem): add comments to key value store
feat(inmem): remove CreateBucketIfNotExists from Tx interface
feat(bolt): remove CreateBucketIfNotExists from Tx
feat(inmem): remove CreateBucketIfNotExists from Tx
doc(kv): add note to bucket interface about conditions methods can be called
feat(kv): add context methods to kv.Tx
feat(bolt): add context methods to bolt.Tx
feat(inmem): add context methods to inmem.Tx
test(kv): add contract tests for view/update transactions
feat(kv): ensure that static cursor is always valid
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Michael Desa <mjdesa@gmail.com>
fix(kv): remove error from cursor methods
test(kv): remove want errors from cursor test
test(testing): add concurrent update test for kv.Store
feat(kv): make kv user service an example service
fix(testing): add concurrnent update test to the kv.Store contract tests
test(platform): fix example kv service tests
dep(platform): make platform tidy
Michael Desa
Nathaniel Cook
Christopher Henn
kelwang
ABond
Kelvin Wang
AJ Bond
Mark Rushakoff
Alirie Gray
Daniel Campbell
alexpaxton
Jade McGough
Iris Scholten
Palakp41
Christopher M. Wolff