Merge pull request #2058 from influxdata/dataloaders/red-x-for-invalid-plugins-in-sidebar

Display red x in sidebar when plugin config is invalid
pull/10616/head
Alirie Gray 2018-12-19 15:21:05 -08:00 committed by GitHub
commit bb2efcc641
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 2 deletions

View File

@ -34,6 +34,8 @@ const configStateToTabStatus = (cs: ConfigurationState): TabStatus => {
switch (cs) {
case ConfigurationState.Unconfigured:
return TabStatus.Default
case ConfigurationState.InvalidConfiguration:
return TabStatus.Error
case ConfigurationState.Configured:
return TabStatus.Success
}

View File

@ -148,7 +148,7 @@ describe('dataLoader reducer', () => {
},
{
name: TelegrafPluginInputFile.NameEnum.File,
configured: ConfigurationState.Unconfigured,
configured: ConfigurationState.InvalidConfiguration,
active: false,
plugin: {
name: TelegrafPluginInputFile.NameEnum.File,

View File

@ -248,7 +248,10 @@ export default (state = INITIAL_STATE, action: Action): DataLoadersState => {
)
if (!isValidConfig || _.isEmpty(config)) {
return {...tp, configured: ConfigurationState.Unconfigured}
return {
...tp,
configured: ConfigurationState.InvalidConfiguration,
}
} else {
return {...tp, configured: ConfigurationState.Configured}
}

View File

@ -50,6 +50,7 @@ export interface DataLoadersState {
export enum ConfigurationState {
Unconfigured = 'unconfigured',
InvalidConfiguration = 'invalid',
Configured = 'configured',
}