From 9dd5ee0d27abc4ee07b976348f3e01fbfe62ce03 Mon Sep 17 00:00:00 2001 From: Alirie Gray Date: Wed, 19 Dec 2018 14:56:59 -0800 Subject: [PATCH] Display red x in sidebar when plugin config is invalid --- ui/src/onboarding/components/OnboardingSideBar.tsx | 2 ++ ui/src/onboarding/reducers/dataLoaders.test.ts | 2 +- ui/src/onboarding/reducers/dataLoaders.ts | 5 ++++- ui/src/types/v2/dataLoaders.ts | 1 + 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ui/src/onboarding/components/OnboardingSideBar.tsx b/ui/src/onboarding/components/OnboardingSideBar.tsx index fb479b831a..96e95e43c9 100644 --- a/ui/src/onboarding/components/OnboardingSideBar.tsx +++ b/ui/src/onboarding/components/OnboardingSideBar.tsx @@ -34,6 +34,8 @@ const configStateToTabStatus = (cs: ConfigurationState): TabStatus => { switch (cs) { case ConfigurationState.Unconfigured: return TabStatus.Default + case ConfigurationState.InvalidConfiguration: + return TabStatus.Error case ConfigurationState.Configured: return TabStatus.Success } diff --git a/ui/src/onboarding/reducers/dataLoaders.test.ts b/ui/src/onboarding/reducers/dataLoaders.test.ts index 9647cf7288..a32b9a319c 100644 --- a/ui/src/onboarding/reducers/dataLoaders.test.ts +++ b/ui/src/onboarding/reducers/dataLoaders.test.ts @@ -148,7 +148,7 @@ describe('dataLoader reducer', () => { }, { name: TelegrafPluginInputFile.NameEnum.File, - configured: ConfigurationState.Unconfigured, + configured: ConfigurationState.InvalidConfiguration, active: false, plugin: { name: TelegrafPluginInputFile.NameEnum.File, diff --git a/ui/src/onboarding/reducers/dataLoaders.ts b/ui/src/onboarding/reducers/dataLoaders.ts index 3c583b2675..284205e81a 100644 --- a/ui/src/onboarding/reducers/dataLoaders.ts +++ b/ui/src/onboarding/reducers/dataLoaders.ts @@ -248,7 +248,10 @@ export default (state = INITIAL_STATE, action: Action): DataLoadersState => { ) if (!isValidConfig || _.isEmpty(config)) { - return {...tp, configured: ConfigurationState.Unconfigured} + return { + ...tp, + configured: ConfigurationState.InvalidConfiguration, + } } else { return {...tp, configured: ConfigurationState.Configured} } diff --git a/ui/src/types/v2/dataLoaders.ts b/ui/src/types/v2/dataLoaders.ts index 8af1654bb5..9a6941bfae 100644 --- a/ui/src/types/v2/dataLoaders.ts +++ b/ui/src/types/v2/dataLoaders.ts @@ -50,6 +50,7 @@ export interface DataLoadersState { export enum ConfigurationState { Unconfigured = 'unconfigured', + InvalidConfiguration = 'invalid', Configured = 'configured', }