716c469324
feat: Implement all-in-one local persistence testing mode ( #7027 )
...
* feat: Implement all-in-one local persistence testing mode
* fix: Apply suggestions from code review
Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>
---------
Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-21 12:45:25 +00:00
30fea67701
fix: Move variables within format strings. Thanks clippy!
...
Changes made automatically using `cargo clippy --fix`.
2023-02-03 13:06:17 -05:00
fa6b07f3a0
refactor(trogging): remove atty dependency
...
Replace atty with IsTerminal due to:
https://rustsec.org/advisories/RUSTSEC-2021-0145
2023-01-09 16:14:11 +01:00
43687a86d2
fix: Remove lots of needless borrows that Clippy can now identify
...
Except for in generated code that we don't control.
2022-11-09 10:54:18 -05:00
576d629ce4
fix: Remove leading `--` from long option names
2022-09-30 16:59:28 -04:00
3c11d3640f
fix: Update use of clap::StructOpt to clap::Parser
...
StructOpt is now fully part of Clap.
https://docs.rs/clap/latest/clap/_faq/index.html#how-does-clap-compare-to-structopt
2022-09-30 16:59:03 -04:00
e76b93d47b
fix: Remove deprecated takes_value attribute
...
See <https://github.com/clap-rs/clap/issues/2688 >
2022-09-30 16:48:26 -04:00
cd4087e00d
style: add no todo!() or dbg!() lints
...
Some crates had theme, some not - lets be consistent and have the
compiler spot dbg!() and todo!() macro calls - they should never be in
prod code!
2022-09-29 13:10:07 +02:00
832f305b9c
chore: Do not use ANSI colorization if not connected to a tty ( #5674 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-09-20 11:01:58 +00:00
46ab254dfb
fix: Make us log logs from the log crate again ( #5680 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-09-19 23:04:28 +00:00
267a53a9e8
chore: update `tracing-subscriber`, fix trogging, fix CLI test port allocation ( #5581 )
...
* test: use dedicated ports for CLI tests
* chore: update `tracing-subscriber`
* fix: work around tracing-subscriber weirdness
It seems that trogging with tracing-subscriber >= 0.3.14 does not
produce any output at all. I suspect we are hitting
<https://github.com/tokio-rs/tracing/issues/2265 >. Let's change the
construct to not use multiple optional layers but a single dyn-dispatch
layer. Logging shouldn't have such a high throughput that his makes any
difference, esp. because the dyn-dispatch happens AFTER the filter.
2022-09-08 09:37:37 +00:00
b982bdaf2f
fix: Derive Eq when we derive PartialEq and members can derive Eq
...
Allow this in generated code that we don't control, though.
Recommended by clippy now. https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
2022-08-11 15:04:06 -04:00
23c9e38ea7
chore(deps): Bump clap from 3.1.18 to 3.2.1 ( #4848 )
...
* chore(deps): Bump clap from 3.1.18 to 3.2.1
Bumps [clap](https://github.com/clap-rs/clap ) from 3.1.18 to 3.2.1.
- [Release notes](https://github.com/clap-rs/clap/releases )
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/clap-rs/clap/compare/v3.1.18...clap_complete-v3.2.1 )
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* chore: fix clap deprecations
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marco Neumann <marco@crepererum.net>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-06-14 15:42:18 +00:00
78bbe629b2
feat: Add more logging to understand the flaky multi ingester test better ( #4580 )
...
* feat: Increase logging to investigate multi ingester flaky test
* feat: Temporarily disable a test while logging is increased in CI
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-05-12 20:05:05 +00:00
48b15a2661
refactor: enable log / tracing composition
...
Changes the trogging::Builder to return a tracing Layer impl when
build() is called, so that it can be composed together with other Layer
impls rather than forcing complete control of the tracing pipeline.
Callers of the Builder::install_global() (basically everything) are
unaffected by this change.
2022-04-12 13:02:31 +01:00
c399e676ca
chore: upgrade clap to v3
2022-01-17 12:12:46 +01:00
9ceb5800c1
fix: adjust code to `tracing-subscriber` 0.3
2021-10-25 17:01:50 +02:00
3fdc0e9a6a
chore: remove orphaned code from trogging ( #2371 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-08-24 10:12:59 +00:00
710f477e35
refactor: remove opentelemetry from observability_deps ( #2192 ) ( #2336 )
2021-08-18 17:24:05 +00:00
efa776bd03
feat: fix log crate output ( #2325 )
...
* feat: fix log crate output
* chore: fix doc
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-08-17 16:19:22 +00:00
3de6b44e23
build: use new rustdoc lint name ( #2261 )
...
* fix: nocache feature code rot
The MBChunk::snapshot code when using the "nocache" option no longer
compiles - this commit updates it to match the not(nocache) code.
* build: use updated broken_intra_doc_links name
The broken_intra_doc_links lint was renamed
rustdoc::broken_intra_doc_links
https://doc.rust-lang.org/rustdoc/lints.html
2021-08-11 19:48:51 +00:00
82677d9510
feat: add `jaeger` and `otlp` features, default to off ( #2202 )
...
* feat: add jaeger and otlp flags
* chore: add jaeger and otlp features to CI test and deploy image
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-08-06 13:26:59 +00:00
9d15798288
fix: Address or allow Clippy warnings new with Rust 1.54
2021-07-30 09:59:59 -04:00
d35b74c226
fix: Fix doc build warnings ( #1945 )
...
* fix: Fix doc build warnings
* refactor: add deny bare_urls to crates
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-07-13 08:03:42 +00:00
e6d995cbd8
chore: Update to Rust 1.53.0 ( #1922 )
...
* chore: Update to Rust 1.53.0
* fix: Update to latest clippy standards
* fix: bad refactor
* fix: Update escaping
* test: update test output
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-07-07 18:02:03 +00:00
f2c7454274
fix: Use layered tracing
2021-06-28 18:37:12 +02:00
1ff0e8d8d4
fix: Fix trailing newline emission in case of truncated log line
2021-06-28 12:23:53 +02:00
15b709f89c
fix: Increase line buffer to avoid frequent interleaved logs
2021-06-25 17:41:28 +02:00
22aa80969d
test: Ensure disabled logs don't eval args
2021-06-25 10:16:43 +02:00
5175ecbbe1
chore: Add our linting rules to the trogging crate
2021-06-23 17:10:17 +02:00
4adf3b5e52
chore: Split LoggingConfig out of TracingConfig
...
Client CLI utils only need LoggingConfig. Servers need also the TracingConfig
2021-06-16 16:07:57 +02:00
58e1494ca2
chore: Allow custom default log level
...
This PR moves the definition of the `log_filter` default value from the `structopt` annotation
to the `trogging::Builder`. This allows users of `trogging` to define their own default value
for the log level.
2021-06-16 13:30:32 +02:00
760bcde3f0
feat: Factor out tracing/logging CLI options
...
This PR factors out the tracing/logging CLI optinos into the `trogging` utility crate,
so that multiple binaries from the IOx suite (such as conductor) can use the same (and quite complex)
logging/tracing configuration options (flags and env vars).
Closes influxdata/conductor#343
2021-06-16 00:54:11 +02:00
bde35cf5be
chore: Pull tracing+logging setup in its own crate
...
1. so that it can be reused by other binaries (e.g. conductor)
2. so that it's faster to build when working on it.
2021-06-15 14:52:04 +02:00
Andrew Lamb
Carol (Nichols || Goulding)
Dom Dwyer
Andrew Lamb
Marko Mikulicic
Marco Neumann
dependabot[bot]
Carol (Nichols || Goulding)
Raphael Taylor-Davies
Carol (Nichols || Goulding)