style: add no todo!() or dbg!() lints

Some crates had theme, some not - lets be consistent and have the
compiler spot dbg!() and todo!() macro calls - they should never be in
prod code!

arrow_util/src/lib.rs

@@ -1,5 +1,14 @@
 #![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![allow(clippy::clone_on_ref_ptr)]
+#![warn(
+    missing_copy_implementations,
+    missing_debug_implementations,
+    clippy::explicit_iter_loop,
+    clippy::future_not_send,
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
+)]
 
 pub mod bitset;
 pub mod dictionary;

arrow_util/src/string.rs

@@ -175,6 +175,7 @@ impl PackedStringArray<i32> {
     }
 }
 
+#[derive(Debug)]
 pub struct PackedStringIterator<'a, K> {
     array: &'a PackedStringArray<K>,
     index: usize,

arrow_util/src/test_util.rs

@@ -80,7 +80,7 @@ pub fn sort_record_batch(batch: RecordBatch) -> RecordBatch {
         .columns()
         .iter()
         .map(|col| SortColumn {
-            values: col.clone(),
+            values: Arc::clone(col),
             options: Some(SortOptions {
                 descending: false,
                 nulls_first: false,

backoff/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 use observability_deps::tracing::info;
 use rand::prelude::*;

cache_system/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod addressable_heap;

clap_blocks/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 pub mod catalog_dsn;
 pub mod compactor;

client_util/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

compactor/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub(crate) mod cold;

data_types/src/lib.rs

@@ -8,7 +8,9 @@
     missing_docs,
     clippy::explicit_iter_loop,
     clippy::future_not_send,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use influxdb_line_protocol::FieldValue;

dml/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::time::Duration;

executor/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use parking_lot::Mutex;
@@ -621,7 +623,7 @@ mod tests {
     async fn wait_for_tasks(exec: &DedicatedExecutor, num: usize) {
         tokio::time::timeout(Duration::from_secs(1), async {
             loop {
-                if dbg!(exec.tasks()) == num {
+                if exec.tasks() == num {
                     return;
                 }
                 tokio::time::sleep(Duration::from_millis(1)).await;

garbage_collector/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

grpc-binary-logger/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod predicate;

influxdb2_client/src/lib.rs

@@ -7,7 +7,9 @@
     missing_docs,
     clippy::explicit_iter_loop,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 //! # influxdb2_client

influxdb_influxql_parser/src/lib.rs

@@ -9,7 +9,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::common::statement_terminator;

influxdb_iox_client/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

influxdb_line_protocol/src/lib.rs

@@ -13,7 +13,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod builder;

influxdb_storage_client/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

influxdb_tsm/src/lib.rs

@@ -4,7 +4,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod encoders;

influxrpc_parser/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::use_self,
     clippy::clone_on_ref_ptr,
     clippy::str_to_string,
-    clippy::string_to_string
+    clippy::string_to_string,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod predicate;

ingester/src/lib.rs

@@ -7,10 +7,14 @@
     missing_copy_implementations,
     missing_debug_implementations,
     missing_docs,
+    clippy::todo,
+    clippy::dbg_macro,
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub(crate) mod compact;

iox_catalog/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::interface::{

iox_data_generator/src/lib.rs

@@ -24,7 +24,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::{agent::Agent, tag_set::GeneratedTagSets};

iox_query/src/lib.rs

@@ -5,7 +5,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use async_trait::async_trait;

iox_tests/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod util;

iox_time/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use chrono::{DateTime, TimeZone, Timelike, Utc};

ioxd_garbage_collector/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

metric/src/lib.rs

@@ -107,7 +107,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use parking_lot::Mutex;

metric_exporters/src/lib.rs

@@ -3,7 +3,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use metric::{Attributes, MetricKind, Observation};

mutable_batch/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 //! A mutable data structure for a collection of writes.

mutable_batch_lp/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use hashbrown::{hash_map::Entry, HashMap, HashSet};

mutable_batch_pb/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod decode;

packers/src/lib.rs

@@ -4,7 +4,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod packers;

panic_logging/src/lib.rs

@@ -6,7 +6,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::{fmt, panic, sync::Arc};

predicate/src/lib.rs

@@ -5,7 +5,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod delete_expr;

querier/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod cache;

query_functions/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use datafusion::{

read_buffer/src/lib.rs

@@ -3,7 +3,9 @@
     clippy::clone_on_ref_ptr,
     clippy::use_self,
     clippy::str_to_string,
-    clippy::string_to_string
+    clippy::string_to_string,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(dead_code, clippy::too_many_arguments)]
 mod chunk;

router/src/lib.rs

@@ -20,6 +20,7 @@
     missing_docs,
     clippy::todo,
     clippy::dbg_macro,
+    clippy::explicit_iter_loop,
     clippy::clone_on_ref_ptr,
     clippy::future_not_send
 )]

router/src/namespace_cache/sharded_cache.rs

@@ -84,12 +84,12 @@ mod tests {
             .collect::<HashMap<_, _>>();
 
         // The cache should be empty.
-        for (name, _) in names.iter() {
+        for name in names.keys() {
             assert!(cache.get_schema(name).is_none());
         }
 
         // Populate the cache
-        for (name, id) in names.iter() {
+        for (name, id) in &names {
             let schema = schema_with_id(*id as _);
             assert!(cache.put_schema(name.clone(), schema).is_none());
         }

service_grpc_catalog/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use data_types::{PartitionId, TableId};

service_grpc_object_store/src/lib.rs

@@ -9,7 +9,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use futures::{stream::BoxStream, StreamExt};

sqlx-hotswap-pool/src/lib.rs

@@ -10,7 +10,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items, clippy::type_complexity)]
 

test_helpers/src/lib.rs

@@ -4,7 +4,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::{

trace/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::{any::Any, collections::VecDeque};

trace_exporters/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::export::AsyncExporter;

trace_http/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod classify;

tracker/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod async_semaphore;

trogging/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 #[cfg(feature = "clap")]

write_buffer/src/lib.rs

@@ -2,6 +2,8 @@
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,
+    clippy::todo,
+    clippy::dbg_macro,
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,