build: use new rustdoc lint name (#2261)

* fix: nocache feature code rot

The MBChunk::snapshot code when using the "nocache" option no longer
compiles - this commit updates it to match the not(nocache) code.

* build: use updated broken_intra_doc_links name

The broken_intra_doc_links lint was renamed
rustdoc::broken_intra_doc_links

https://doc.rust-lang.org/rustdoc/lints.html

arrow_util/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![allow(clippy::clone_on_ref_ptr)]
 
 pub mod bitset;

data_types/src/lib.rs

@@ -2,7 +2,7 @@
 //! servers including replicated data, rules for how data is split up and
 //! queried, and what gets stored in the write buffer database.
 
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

datafusion_util/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![allow(clippy::clone_on_ref_ptr)]
 
 use std::sync::Arc;

generated_types/src/lib.rs

@@ -1,7 +1,7 @@
 // This crate deliberately does not use the same linting rules as the other
 // crates because of all the generated code it contains that we don't have much
 // control over.
-#![deny(broken_intra_doc_links, rustdoc::bare_urls)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls)]
 
 /// This module imports the generated protobuf code into a Rust module
 /// hierarchy that matches the namespace hierarchy of the protobuf

google_types/src/lib.rs

@@ -1,7 +1,7 @@
 // This crate deliberately does not use the same linting rules as the other
 // crates because of all the generated code it contains that we don't have much
 // control over.
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![allow(
     unused_imports,
     clippy::redundant_static_lifetimes,

grpc-router/src/lib.rs

@@ -166,7 +166,7 @@
 //! # }
 //! ```
 
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

influxdb2_client/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

influxdb_iox_client/src/lib.rs

@@ -1,6 +1,6 @@
 //! An InfluxDB IOx API client.
 #![deny(
-    broken_intra_doc_links,
+    rustdoc::broken_intra_doc_links,
     rustdoc::bare_urls,
     rust_2018_idioms,
     missing_debug_implementations,

influxdb_line_protocol/src/lib.rs

@@ -7,7 +7,7 @@
 //! However, this implementation uses a nom combinator based parser
 //! rather than attempting to port the imperative Go logic.
 
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

influxdb_tsm/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

internal_types/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

lifecycle/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

logfmt/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 
 use observability_deps::{
     tracing::{

mem_qe/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![allow(clippy::type_complexity)]
 pub mod adapter;
 pub mod column;

metrics/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

mutable_buffer/src/chunk.rs

@@ -142,10 +142,7 @@ impl MBChunk {
     /// Returns a queryable snapshot of this chunk
     #[cfg(feature = "nocache")]
     pub fn snapshot(&self) -> Arc<ChunkSnapshot> {
-        Arc::new(ChunkSnapshot::new(
-            self,
-            self.metrics.memory_bytes.clone_empty(),
-        ))
+        Arc::new(ChunkSnapshot::new(self))
     }
 
     /// Return the name of the table in this chunk

mutable_buffer/src/lib.rs

@@ -50,7 +50,7 @@
 //! is done on a per-Chunk basis, so that as soon as the chunk is
 //! closed the corresponding dictionary also becomes immutable
 
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

object_store/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

packers/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

panic_logging/src/lib.rs

@@ -1,7 +1,7 @@
 //! Custom panic hook that sends the panic information to a tracing
 //! span
 
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

parquet_file/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

persistence_windows/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

query/src/lib.rs

@@ -1,5 +1,5 @@
 //! Contains the IOx query engine
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

read_buffer/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(clippy::clone_on_ref_ptr, clippy::use_self)]
 #![allow(dead_code, clippy::too_many_arguments)]
 mod chunk;

server/src/lib.rs

@@ -59,7 +59,7 @@
 //!   └────────────┘  └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─
 //! ```
 
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

src/main.rs

@@ -1,5 +1,5 @@
 //! Entrypoint of InfluxDB IOx binary
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

test_helpers/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

tracker/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_debug_implementations,
     clippy::explicit_iter_loop,

trogging/src/lib.rs

@@ -1,6 +1,6 @@
 //! Log and trace initialization and setup
 
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,

write_buffer/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
+#![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,