3de6b44e23
build: use new rustdoc lint name ( #2261 )
...
* fix: nocache feature code rot
The MBChunk::snapshot code when using the "nocache" option no longer
compiles - this commit updates it to match the not(nocache) code.
* build: use updated broken_intra_doc_links name
The broken_intra_doc_links lint was renamed
rustdoc::broken_intra_doc_links
https://doc.rust-lang.org/rustdoc/lints.html
2021-08-11 19:48:51 +00:00
304901bf40
Merge branch 'main' into er/refactor/logs
2021-08-10 21:31:49 +00:00
8626e9980b
docs: Add/update doccomments in the read_buffer ( #2245 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-08-10 21:26:02 +00:00
5d5ed7d0db
refactor: remove logging
2021-08-10 22:16:01 +01:00
f8870968b9
refactor: reduce logging when creating RUB chunk
2021-08-10 22:11:10 +01:00
126598a2e8
fix(read_buffer): Improve statistics update to handle nulls and prevent `panic`s ( #2246 )
...
* fix(read_buffer): Improve statistics update to handle nulls
* fix: clippy
* refactor: only compile test helpers with cfg(test)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-08-10 16:58:20 +00:00
0297aae17e
Merge branch 'main' into cn/1.54
2021-07-30 17:01:37 +00:00
248ae08343
fix(read_buffer): Avoid panic when creating stats for entirely null columns ( #2159 )
2021-07-30 14:59:18 +00:00
9d15798288
fix: Address or allow Clippy warnings new with Rust 1.54
2021-07-30 09:59:59 -04:00
11b7755325
refactor: Remove first/last write times from RUB chunks
2021-07-28 11:22:22 -04:00
5fb3e00f2a
fix: Properly record total_count and null_count in statistics ( #2103 )
...
* fix: Properly record total_count and null_count in statistics
* fix: fix statistics calculation in mutable_buffer
* refactor: expose null counts in read_buffer
* refactor: expose null_count in parquet_file
* fix: update server crate tests
* fix: update query_tests tests
* docs: tweak comments
* refactor: Use storage_stats rather than adding `null_count`
* refactor: rename test data field for clarity
* fix: fixup merge conflicts
* refactor: rename initial_non_null_count to initial_total_count
* refactor: caculate null_count as row_count - to_add
2021-07-26 18:13:36 +00:00
05782eb980
refactor: Move first/last write times up to read buffer Chunk rather than MetaData
2021-07-22 12:27:46 -04:00
37f24ebfc7
feat: Record first/last write times for creation of read_buffer::Chunk
2021-07-22 11:35:23 -04:00
4e6b79534b
feat: Require passing first/last write times for creation of Table
2021-07-22 11:35:23 -04:00
b7bedeaaf3
feat: Require passing first/last write times for creation of Table MetaData
2021-07-22 11:35:23 -04:00
8d1d877196
feat: Record first/last write times for RUB chunks
2021-07-22 11:35:22 -04:00
16b07e5b31
refactor: Always use Table::with_row_group to ensure Tables are never empty
...
Remove Table::new that created an empty table.
2021-07-22 11:15:18 -04:00
6feea3b2d5
feat: Require at least one RecordBatch to create a read_buffer::Chunk::new
...
In the signature only for the moment.
2021-07-22 11:15:18 -04:00
bbb4462264
refactor: Extract a function for the RecordBatch to RowGroup transformation with logging
...
So that we can call it from RBChunk::new too.
2021-07-22 11:15:18 -04:00
0a724878e6
refactor: Organize uses
2021-07-22 11:15:18 -04:00
4da8a16c18
chore: update to arrow 5.0 and master datafusion ( #2049 )
...
* chore: update to arrow 5.0 and master datafusion
* fix: Update test for change in object size
2021-07-19 12:49:51 +00:00
54ad69ed86
fix: ensure correct table meta size used
2021-07-16 10:48:45 -04:00
f3175ed291
test: use of different size values
2021-07-16 09:47:56 -04:00
abe2fe7262
test: MetaData new with a row group vs default then update_with should have the same size
2021-07-16 09:47:56 -04:00
3fd6430fb6
fix: rename `estimated_bytes` to `memory_bytes` and expose `object_store_bytes` in ChunkSummary and system.chunks ( #2017 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-07-15 16:00:24 +00:00
833debd5b5
Merge branch 'main' into cn/exploration
2021-07-14 17:30:55 +00:00
1d00fa2fd8
refactor: track memory metrics in catalog ( #1995 )
...
* refactor: track memory metrics in catalog
* chore: update comment
2021-07-14 16:23:00 +00:00
8070065e2f
fix: Change RUB chunk table_summaries to table_summary
...
Because chunks now have only one table.
Connects to #1718 , #1613 , #1295
2021-07-14 11:18:02 -04:00
97c727a2c2
fix: update read_buffer tests
2021-07-13 15:44:57 -04:00
2e391deb34
chore: update croaring to 0.5.0
...
Upstreame changelog:
- CRoaring updated to 0.3.1
- `-march=native` is not a default for croaring-sys anymore
- Impl Default for `Bitmap` and `Treemap`
2021-07-13 15:15:41 +02:00
d35b74c226
fix: Fix doc build warnings ( #1945 )
...
* fix: Fix doc build warnings
* refactor: add deny bare_urls to crates
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-07-13 08:03:42 +00:00
f811bf1e5e
refactor: log compaction activity
2021-07-08 12:48:41 +01:00
7602bde850
chore: Update datafusion deps ( #1799 )
...
* chore: Update datafusion deps + rework code
* refactor: remove workaround as it has been contributed upstream
* fix: Update query/src/exec/split.rs
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-07-08 10:58:32 +00:00
e6d995cbd8
chore: Update to Rust 1.53.0 ( #1922 )
...
* chore: Update to Rust 1.53.0
* fix: Update to latest clippy standards
* fix: bad refactor
* fix: Update escaping
* test: update test output
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-07-07 18:02:03 +00:00
2ec9151b32
Merge branch 'main' into er/fix/read_buffer/predicate
2021-07-06 13:35:04 +01:00
b4534883fe
refactor: remove table name from upsert_table ( #1882 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-07-02 15:22:41 +00:00
8fc07cf4f0
fix: correctly evaluate exprs matching disjoint rows
2021-07-01 16:05:09 +01:00
2e430ac7f0
refactor: remove table name from read_filter schema
2021-06-30 09:50:53 +01:00
62f274cc1b
refactor: remove table name from column_values
2021-06-30 09:46:54 +01:00
5737c9d962
refactor: remove table name from column_names
2021-06-30 09:43:41 +01:00
86e2fe4138
refactor: satisfies predicate
2021-06-29 11:58:28 +01:00
ed98812c2a
refactor: logging
2021-06-25 17:37:04 +01:00
84e63bb1b9
feat: temporary log information on record batch data ( #1807 )
...
* feat: temporary log information on record batch data
* chore: add buffer size
2021-06-25 14:46:51 +00:00
7e3df17896
test: update benchmarks
2021-06-21 15:29:23 +01:00
2ff80162d3
refactor: one table per chunk
2021-06-21 15:08:38 +01:00
15416ca223
refactor: enable empty table init
2021-06-21 15:08:38 +01:00
ec43a87909
chore: Update itertools deps ( #1750 )
2021-06-17 17:56:44 +00:00
ff19beb0ad
refactor: export rb chunk as RBChunk
2021-06-11 18:33:10 +01:00
1e7ef193a6
refactor: use field metadata to store influx types ( #1642 )
...
* refactor: use field metadata to store influx types
make SchemaBuilder non-consuming
* chore: remove unused variants
* chore: fix lints
2021-06-07 13:26:39 +00:00
418cc4cf0e
refactor: update read_buffer/src/column/encoding/scalar/transcoders.rs
...
Co-authored-by: Dom <dom@itsallbroken.com>
2021-06-03 14:02:16 +01:00
22c7592e3b
refactor: DRY RLE check
2021-06-03 12:32:40 +01:00
9a45c0d05b
feat: implement float byte trimming for arrow array
2021-06-03 12:32:40 +01:00
5d02a71e6f
feat: implement byte trimming on float slice
2021-06-03 12:32:40 +01:00
32e5f8c715
feat: add float byte trimmer encoding
2021-06-03 12:32:40 +01:00
728476f2e1
refactor: add encoding name to float encodings
2021-06-03 12:32:40 +01:00
fa729fd6b0
refactor: address PR feedback
2021-06-02 11:21:10 +01:00
a5b554d2c3
feat: add RLE support to integer encodings
2021-06-02 10:57:17 +01:00
71598d9b3e
refactor: move rle heuristics to rle module
2021-06-02 10:57:17 +01:00
aca00a505f
refactor: avoid copying encoding name for stats
...
Swaps the encoding name String type for a Cow in the column Statistics,
avoiding having to copy the encoding name where it is a static string
already.
2021-06-01 11:08:07 +01:00
00e735ef0d
chore: remove unused dependencies ( #1583 )
2021-05-29 10:31:57 +00:00
db432de137
feat: add distinct count to StatValues ( #1568 )
2021-05-28 17:41:34 +00:00
e94be15296
refactor: update read_buffer/src/column/encoding/scalar/fixed.rs
2021-05-27 21:18:10 +01:00
26fe4167f7
refactor: erase some types
2021-05-27 14:57:40 +01:00
bba387d6ff
refactor: fix benchmarks
2021-05-27 14:35:34 +01:00
7ab27c4468
refactor: get build
2021-05-27 14:35:34 +01:00
04513e737d
refactor: define encodings wrt to scalar encoding trait
2021-05-27 14:35:34 +01:00
22f8a8a4a1
refactor: define scalar encoding in terms of trait
2021-05-27 14:35:34 +01:00
c84d50447c
feat: define a Transcoder trait
2021-05-27 14:35:34 +01:00
a81ada6140
feat: add transcoder trait
2021-05-27 14:35:34 +01:00
4fcc04e6c9
chore: enable arrow prettyprint feature ( #1566 )
2021-05-27 10:28:14 +00:00
db96286ed7
Merge branch 'main' into er/refactor/scalar_comp
2021-05-24 17:02:14 +00:00
14ba25f86d
chore: Update datafusion and use released version of arrow crates ( #1546 )
...
* chore: Update datafusion and use released version of arrow crate
* fix: Update for change in API
2021-05-24 15:37:22 +00:00
eace6c9201
fix: ensure scalars compare correctly
2021-05-24 16:19:28 +01:00
784ef88fcd
chore: merge main to branch and add more tests that expose a wrong result bug on unsigned int
2021-05-21 12:38:06 -04:00
a65c729b01
fix: support converse binary expressions
2021-05-21 15:41:52 +01:00
d5f02cb6c5
refactor: address PR feedback
2021-05-21 09:40:26 +01:00
d57e3ae73e
refactor: move scalar encodings
2021-05-20 22:58:30 +01:00
0ec2499f60
refactor: teach scalar RLE to return different type
2021-05-20 22:50:44 +01:00
e44a3a87db
feat: fnow predicate is actuallu pushed down to RUB but there are bugs and not working yet
2021-05-20 16:56:15 -04:00
4cb76e367b
refactor: fix change to Chunk API
2021-05-20 11:11:18 +01:00
663a38862d
refactor: address PR feedback
2021-05-20 10:49:49 +01:00
76caef89b1
refactor: apply suggestions from code review
...
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2021-05-20 10:49:49 +01:00
c901fe1023
perf: improve values_as_dictionary with predicates
2021-05-20 10:49:49 +01:00
723ff2553b
feat: teach read_filter to return dictionaries
2021-05-20 10:49:49 +01:00
3de6f3f8bd
feat: teach string encoding to production Dictionary values
2021-05-20 10:49:49 +01:00
634ceb886b
feat: add Dictionary Values type
2021-05-20 10:49:49 +01:00
b7b87c1c96
test: add read_filter benchmark
2021-05-20 10:49:49 +01:00
4e766d7085
refactor: reorganise benchmarks
2021-05-20 10:49:49 +01:00
c8e2c9224e
chore: rename benchmark
2021-05-20 10:49:49 +01:00
37880ee89a
refactor: store chunk IDs only in catalog ( #1521 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-05-20 04:07:14 +00:00
2963d63b5e
feat: implement byte trimming on nullable encodings
2021-05-17 14:32:55 +01:00
6a72274517
feat: extend implementations to more Arrow arrays
2021-05-17 14:32:55 +01:00
2b98bca9ca
test: allow from slice to be testable
2021-05-17 14:32:55 +01:00
b7ea53f5db
refactor: remove unnecessary from imps
2021-05-17 14:32:55 +01:00
07db4932ee
refactor: rename data_types/src/chunk.rs -> data_types/src/chunk_metadata.rs ( #1500 )
2021-05-15 10:18:01 +00:00
f9178dbb5f
feat: push metrics into catalog ( #1488 )
...
* feat: push metrics into catalog
* chore: minor cleanup
* fix: include db labels in chunk metric domains
* chore: fmt
* fix: don't allow dropping moving chunks
* chore: further tweaks
* chore: review feedback
* feat: use new_unregistered() for metric instruments instead of default
* chore: use &[KeyValue] instead of &Vec<KeyValue>
* refactor: make GauageValue non default constructible
2021-05-14 17:37:39 +00:00
db6c7728c7
refactor: use 10% target reduction for RLE
...
Comments say 10% but const was 30% - a 10% computed size reduction
sounds sensible!
2021-05-14 15:08:54 +01:00
874d7a1118
test: run rle_rows test
...
The rle_rows test was missing a #[test] annotation preventing it from
running.
2021-05-14 14:41:17 +01:00
0d21d9e2e0
refactor: implement from_iter, reduce code!
2021-05-14 13:32:02 +01:00
ac4fa1e527
refactor: update read_buffer/src/column/encoding/scalar/rle.rs
...
Co-authored-by: Dom <dom@itsallbroken.com>
Co-authored-by: Marko Mikulicic <mkm@influxdata.com>
2021-05-14 13:24:55 +01:00
1fa08d0de5
test: add test for float encoding rules
2021-05-14 13:24:53 +01:00
1ac949e7ea
feat: implement predicate pushdown on RLE
2021-05-14 13:23:42 +01:00
0cf445991e
refactor: all read buffer tests passing
2021-05-14 13:14:12 +01:00
7525f6e9e3
feat: teach read buffer to create RLE float columns
2021-05-14 13:14:10 +01:00
9a666fac00
feat: implement RLE methods for materialising
2021-05-14 13:05:02 +01:00
c55dce3af5
feat: implement stat methods
2021-05-14 13:05:02 +01:00
958219d63e
feat: skeleton scalar RLE
2021-05-14 13:05:02 +01:00
91fda41f8e
refactor: pdate read_buffer/src/column/boolean.rs
...
Co-authored-by: Marko Mikulicic <mkm@influxdata.com>
2021-05-14 12:11:54 +01:00
d80e71ad86
feat: add new metric to track raw size
2021-05-14 10:34:54 +01:00
51c9c15026
refactor: include raw size in log message
2021-05-14 09:42:24 +01:00
966093deec
feat: expose size_raw via ReadBuffer API
2021-05-14 09:42:24 +01:00
984f505267
feat: implement raw column size on bool columns
2021-05-14 09:42:24 +01:00
1a20f3fb4a
feat: implement raw column size on float columns
2021-05-14 09:42:24 +01:00
301df03e72
feat: implement raw column size on integer columns
2021-05-14 09:42:24 +01:00
850db3f6c2
feat: implement raw size on string columns
2021-05-14 09:42:22 +01:00
1416097a35
Merge branch 'main' into er/feat/read_buffer/num_rle
2021-05-11 23:30:55 +01:00
aa83669740
refactor: move encodings to scalar module
2021-05-11 22:49:20 +01:00
482e4dab86
refactor: shuffle string encodings
2021-05-11 22:47:42 +01:00
f86e0641fd
refactor: clarify benchmark
2021-05-11 22:47:42 +01:00
f5fe270e43
refactor: move benchmark
2021-05-11 22:47:36 +01:00
696e4e0cfd
fix: ensure metrics not overwriting
2021-05-11 20:57:31 +01:00
d1da954fe4
feat: don't store encoded strings twice in RLE dictionaries ( #1469 )
2021-05-11 15:22:25 +00:00
32abe2e777
feat: wire up stats to metrics
2021-05-11 13:38:32 +01:00
c4987028fb
feat: expose all column stats
2021-05-11 13:00:52 +01:00
88ed58aa8a
feat: column statistics for int/float
2021-05-11 13:00:52 +01:00
ef2eda04ef
feat: add string encoder statistics
2021-05-11 13:00:52 +01:00
3622a92c8b
feat: wire in rb column metrics
2021-05-11 13:00:52 +01:00
795f5bfcb7
refactor: make `StatValues::{min,max}` optional + handle NaNs
...
This will allow us to:
- handle all-NULL columns correctly
- be in-line with Parquet (where min/max are optional)
- handle NaNs at least somewhat sane (they do not "poison" stats
anymore)
2021-05-10 17:12:25 +02:00
4a414fc8fb
fix: don't blow up on all null columns
2021-05-07 17:31:18 +01:00
b5ea71f45f
feat: Expose the storage usage for each column in system.chunk_columns ( #1441 )
...
* feat: Expose the storage usage for each column in system.chunk_columns
* fix: fixup logical conflicts
* refactor: move coalsce logic into the read buffer
* fix: Update system_tables to not use coalese
* fix: Improve comments
Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
2021-05-07 12:36:49 +00:00
884baf7329
feat: add column_type and influxdb_column_type, remove row_count from system.columns ( #1415 )
...
* feat: add column_type and influxdb_column_type, remove row_count from system.columns
* fix: update tests
* fix: more test update
* fix: Apply suggestions from code review
Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
* fix: fmt
* fix: copy/paste type conversion to avoid cross dependency between data_types and internal_types
Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
2021-05-06 12:59:30 +00:00
ca1c698fd0
chore: update hashbrown ( #1430 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-05-05 22:32:46 +00:00
411cf134e9
refactor: explode arrow_deps ( #1425 )
...
* refactor: explode arrow_deps
* chore: workaround doctest bug
2021-05-05 16:59:12 +00:00
b4b048127d
refactor: add column count to log line
2021-05-05 11:08:15 +01:00
0788892413
feat: add row_count to system.chunks and Chunk managment API ( #1373 )
...
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-04-29 13:53:25 +00:00
96e1289c94
refactor: log time to create row group
2021-04-28 15:08:19 +00:00
c3b41649ee
refactor: use space saving compression
2021-04-28 15:08:19 +00:00
5e3d43d62f
fix: report row group rows correctly
2021-04-28 15:08:19 +00:00
eddc9319ff
docs: deny broken intradoc links
2021-04-27 13:22:28 +02:00
20117de078
feat: string dictionary encoding ( #1220 ) ( #1262 )
...
* feat: string dictionary encoding (#1220 )
* chore: review comments
* chore: fix lint
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-04-27 09:36:58 +00:00
1826d86938
chore: fix observability dependency key
...
The observability_deps crate name was erroneously wrapped in double
quotes.
2021-04-26 12:22:21 +01:00
faec98eab9
refactor: remove time column from row group
2021-04-26 09:51:06 +00:00
15bde2f8fa
refactor: remove time field from Table meta
2021-04-26 09:51:06 +00:00
1f0e760f2f
refactor: use bool::then
2021-04-22 21:59:41 +00:00
2784f89e6e
refactor: sigh
2021-04-20 17:30:50 +00:00
d55bf73860
refactor: satisfy new clippy lints
2021-04-20 17:30:50 +00:00
0114afcdfa
refactor: quieten logs for new row group
2021-04-19 16:08:49 +00:00
82c1d94ce1
refactor: Use Option.map where possible
2021-04-19 08:48:11 -04:00
83250a93e6
refactor: Use vec macro
2021-04-19 08:48:11 -04:00
c9772db01b
fix: Allow this upper case acronym; it could be confusing otherwise
2021-04-19 08:48:11 -04:00
Dom
kodiakhq[bot]
Andrew Lamb
Edd Robinson
Carol (Nichols || Goulding)
Raphael Taylor-Davies
Andrew Lamb
Marco Neumann
Nga Tran