test: update benchmarks

read_buffer/benches/database.rs

@@ -14,7 +14,7 @@ const ONE_MS: i64 = 1_000_000;
 
 fn table_names(c: &mut Criterion) {
     let rb = generate_row_group(500_000);
-    let mut chunk = RBChunk::new(ChunkMetrics::new_unregistered());
+    let mut chunk = RBChunk::new("table_a", ChunkMetrics::new_unregistered());
     chunk.upsert_table("table_a", rb);
 
     // no predicate - return all the tables

read_buffer/benches/read_filter.rs

@@ -17,7 +17,7 @@ const ONE_MS: i64 = 1_000_000;
 pub fn read_filter(c: &mut Criterion) {
     let mut rng = rand::thread_rng();
 
-    let mut chunk = RBChunk::new(read_buffer::ChunkMetrics::new_unregistered());
+    let mut chunk = RBChunk::new("table", read_buffer::ChunkMetrics::new_unregistered());
     let row_group = generate_row_group(200_000, &mut rng);
     read_buffer::benchmarks::upsert_table_with_row_group(&mut chunk, "table", row_group);
 
@@ -48,9 +48,7 @@ fn read_filter_no_pred_vary_proj(c: &mut Criterion, chunk: &RBChunk) {
             &exp_card,
             |b, _| {
                 b.iter(|| {
-                    let result = chunk
-                        .read_filter("table", Predicate::default(), projection)
-                        .unwrap();
+                    let result = chunk.read_filter("table", Predicate::default(), projection);
                     let rbs = result.collect::<Vec<_>>();
                     assert_eq!(rbs.len(), 1);
                     assert_eq!(rbs[0].num_rows(), 200_000);
@@ -85,9 +83,7 @@ fn read_filter_with_pred_vary_proj(c: &mut Criterion, chunk: &RBChunk) {
             &exp_rows,
             |b, _| {
                 b.iter(|| {
-                    let result = chunk
-                        .read_filter("table", predicate.clone(), Selection::All)
-                        .unwrap();
+                    let result = chunk.read_filter("table", predicate.clone(), Selection::All);
                     let rbs = result.collect::<Vec<_>>();
                     assert_eq!(rbs.len(), 1);
                     assert!(rbs[0].num_rows() > 0); // data randomly generated so row numbers not exact

server/src/db.rs

@@ -553,7 +553,7 @@ impl Db {
             .register_domain_with_labels("read_buffer", db.metric_labels.clone());
 
         let mut rb_chunk = RBChunk::new(
-            table_name,
+            &table_summary.name,
             ReadBufferChunkMetrics::new(
                 &metrics,
                 db.preserved_catalog
@@ -667,6 +667,7 @@ impl Db {
 
             let arrow_schema: ArrowSchemaRef = rb_chunk
                 .read_filter_table_schema(table_name, Selection::All)
+                .expect("read buffer is infallible")
                 .into();
 
             let stream: SendableRecordBatchStream = Box::pin(