Commit Graph

199 Commits (ac8556f35ea26a1cc5c8fa85cf294784b487bbdf)

Author SHA1 Message Date
Dave Long 85aee30af3
Issue #3351089 by Spokje: Fix PHPStan L1 errors "@dataProvider Foo related method not found." 2023-04-11 18:46:51 +01:00
catch bef31d1d77 Issue #3352938 by Spokje, smustgrave: Fix PHPStan L1 errors "Configuration entity must define a `config_export` key." 2023-04-11 15:20:13 +01:00
Lee Rowlands 40b09f3b48
Revert "Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD"
This reverts commit 7ea52649ec.
2023-04-05 08:21:03 +10:00
Lee Rowlands 7ea52649ec
Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD 2023-04-04 14:37:06 +10:00
catch 8c61db1638 Issue #3351073 by Spokje: Fix PHPStan L1 errors "Annotation "@covers::foo" is invalid, "@covers" should be followed by a space and a value." 2023-03-31 11:21:54 +01:00
catch 1f7aa7ac83 Issue #3351218 by Spokje: Fix PHPStan L1 errors "@covers value \Foo\Bar::baz() references an invalid method." 2023-03-30 16:22:57 +01:00
catch 6ca4984f03 Issue #3351079 by Spokje: Fix PHPStan L1 errors "You should use assertFoo() instead of assertSame(foo, $actual)." 2023-03-29 23:50:46 +01:00
catch 336c3ef206 Issue #3351060 by Spokje: Fix PHPStan L1 errors "You should use assertNull() instead of assertSame(null, $actual)." 2023-03-29 23:46:03 +01:00
catch 821cc64ae6 Issue #3351067 by Spokje: Fix PHPStan L1 errors "Class already @covers \Foo\Bar so the method @covers is redundant." 2023-03-29 21:18:34 +01:00
Alex Pott 947fd48d2b
Issue #3326239 by mondrake, Spokje, andypost, longwave, xjm, quietone: Add phpstan/phpstan-phpunit as a dev dependency 2023-03-29 11:45:04 +01:00
catch 0bbf07394d Issue #3245252 by andypost, ranjith_kumar_k_u, Spokje: Fix possibly undefined $finished in _batch_process() 2023-03-28 12:18:57 +01:00
catch 8726c00a0e Revert "Issue #3337513 by mondrake, gidarai, daffie, alexpott, catch: Fix batch process race conditions by making ‘bid (batch id)’ auto-increment"
This reverts commit 779785e220.
2023-03-23 17:24:34 +00:00
catch 779785e220 Issue #3337513 by mondrake, gidarai, daffie, alexpott, catch: Fix batch process race conditions by making ‘bid (batch id)’ auto-increment 2023-03-21 12:29:21 +00:00
Dave Long de09fc95c5
Issue #3322743 by Spokje, mondrake: Fix PHPStan L2 errors "Parameter $foo of method Foo::bar() has invalid type Foo\Baz." and "Method Foo::bar() has invalid return type Foo\Baz. " 2023-03-12 19:15:58 +00:00
catch 60c2916b17 Issue #3335110 by Spokje, mondrake: Fix PHPStan L1 errors "#foo callback class 'Bar\Baz')' at key 'X' does not implement Drupal\Core\Security\TrustedCallbackInterface." 2023-03-10 14:29:37 +00:00
catch f247d598cb Issue #3341098 by quietone: Move non-migrations tests to Statistics 2023-02-25 09:46:08 +00:00
Dave Long cc21877471
Issue #3264167 by Spokje, neclimdul, heykarthikwithu, longwave: Remove use of final Guzzle client class 2023-02-24 09:54:12 +00:00
catch 7cf8cec67d Issue #3341254 by Spokje, longwave: Fix failing "updated deps" test-runs on 10.x.x 2023-02-23 14:58:45 +00:00
Dave Long 1ac46a2af3
Issue #3308920 by jungle, smustgrave, Lendude: Fix test performance of Drupal\Tests\user\FunctionalJavascript\UserPasswordResetTest 2023-02-23 14:11:23 +00:00
catch 1c5789b443 Issue #3336536 by murilohp: Fix PHPStan warning on assertBreadcrumb when passing NULL 2023-02-23 11:11:10 +00:00
Alex Pott f979f42ec0
Issue #3323209 by Spokje, mondrake, smustgrave, alexpott, xjm: Deprecate calling Drupal\block\Plugin\migrate\process\BlockTheme::_construct() with the $migration argument 2023-02-22 21:38:00 +00:00
catch 79cd4d3682 Issue #3336586 by Spokje: Fix failing "updated deps" test-runs by upping mglaman/phpstan-drupal to latest 2023-02-10 16:05:33 +00:00
catch 461eb14b7a Issue #3326378 by Spokje: Fix PHPStan L1 error "Instantiated class Foo\Bar not found." 2023-02-06 12:05:14 +00:00
catch 480569932d Issue #3336527 by murilohp, longwave: Remove unnecessary variables from core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php 2023-02-03 11:40:04 +00:00
Lauri Eskola bfe3f5dc98
Issue #3333569 by alorenc, lauriii, smustgrave, larowlan: Breadcrumb for local tasks of Custom Blocks should contain the name of the custom block not the entity ID 2023-01-25 12:39:26 +02:00
Alex Pott 4936c9bd07
Issue #3260391 by huzooka, arunkumark, Spokje, quietone: BlockedIp::import violates MigrateDestinationInterface::import 2023-01-13 15:39:46 +00:00
Dave Long e1e56ac4a5
Issue #3333065 by Spokje: Update PHPStan to 1.9.9 to fix 10.x "updated deps" Drupal CI runs 2023-01-12 23:17:41 +00:00
xjm 4d9b40b01e
Issue #3244570 by voleger, xjm, alexpott, longwave, andypost: Deprecate drupal_rewrite_settings() 2023-01-07 15:32:44 -06:00
catch c6babbb64e Issue #3324384 by Spokje, joachim, elber, znerol, longwave, mondrake: resolve differing createUser() test methods 2023-01-06 11:14:45 +00:00
Alex Pott dd9b1659db
Issue #3330305 by Spokje, mondrake: Fix failing "updated deps" test-runs by upping mglaman/phpstan-drupal to latest 2023-01-03 11:57:57 +00:00
xjm 53803cfb4c
Issue #3317230 by mondrake, kim.pepper, longwave: Fix test mock related PHPStan 0 issues 2023-01-02 05:07:22 -06:00
Alex Pott 1a63aa6318
Issue #3326371 by Spokje: Fix PHPStan L1 error "Anonymous function has an unused use $foo." 2022-12-30 16:39:39 +00:00
Dave Long 1e659b4a79
Issue #3327018 by Spokje, longwave, xjm: Update PHPStan to 1.9.3 and make daily "updated deps" QA jobs pass 2022-12-20 11:19:33 +00:00
xjm 2a461dcd71
Issue #3325184 by Spokje, andypost, xjm, smustgrave: $this->configFactory is not set properly in the constructor of \Drupal\system\Form\CronForm 2022-12-16 13:21:42 -06:00
Alex Pott e2d4dcfdf2
Issue #3319582 by mondrake, Spokje, longwave, mallezie: Fix calls to methods with too many parameters passed in 2022-11-29 11:38:06 +00:00
Alex Pott d9059c0650
Issue #3323260 by Spokje, longwave: Deprecate node_revision_load() and friends 2022-11-23 21:54:56 +00:00
Dave Long 5c1863a060
Issue #3322961 by mondrake: Fix WebAssert since PHPStan can now check the number of arguments passed to methods 2022-11-22 14:11:50 +00:00
Dave Long c4a3b2558d
Issue #3323036 by mondrake, mallezie: Remove $group parameter from AssertContentTrait methods 2022-11-22 13:48:02 +00:00
catch 8e71d46598 Issue #3320025 by alexpott, longwave: Make PHPStan baseline the same in 10.1.x and 10.0.x 2022-11-09 14:58:26 +00:00
catch 0dc16934ab Issue #3319683 by alexpott, mallezie, mondrake: Fix PHPStan errors from UserCreationTrait and AssertMailTrait 2022-11-09 11:27:52 +00:00
Alex Pott e00c523fb4
Issue #3317651 by mondrake, longwave, alexpott: Fix DataReferenceBase PHPStan L0 issues 2022-11-08 15:57:37 +00:00
Alex Pott 7fa5f0a577
Issue #3190406 by mondrake, mallezie, klausi: Update PHPStan to level 1 2022-11-07 12:38:24 +00:00
Alex Pott d96c99b491
Issue #3317652 by mondrake, longwave: Fix Updater PHPStan L0 issues 2022-11-03 00:23:39 +00:00
catch 08b0f54bf4 Issue #3317658 by pooja saraah, mondrake, ravi.shankar, longwave: Fix HoldTestSubscriber PHPStan L0 issues 2022-11-02 14:54:34 +00:00
Alex Pott e54ef601a4
Issue #3317874 by longwave, mondrake: Update dependencies for Drupal 10.0 2022-11-01 15:42:01 +00:00
catch 23b444af40 Issue #3317223 by mondrake, longwave: Fix RecursiveExtensionFilterIterator PHPStan L0 issues 2022-10-26 08:23:29 +01:00
catch c2a6c76593 Issue #3317243 by mondrake: Fix PluginManagerBase PHPStan-0 issues 2022-10-25 09:04:50 +01:00
catch 4c187847dc Issue #3316950 by mondrake: Fix StreamWrapper\ReadOnlyStream PHPStan-0 issues 2022-10-24 15:57:12 +01:00
catch 43e4c4a853 Issue #3316960 by mondrake: Fix PageRenderTest PHPStan L0 issues 2022-10-24 15:23:17 +01:00
catch 8b08268ead Issue #3316825 by mondrake, Spokje: Fix Kernel/RenderCacheIntegrationTest PHPStan L0 issues 2022-10-21 20:54:32 +01:00
catch 78f3dbf183 Issue #3316815 by mondrake: Fix PHPStan L0 issues for calls to crufty drupalPost* methods 2022-10-21 20:02:22 +01:00
catch 8d8d4e5e7a Issue #3316129 by mondrake: Fix AssertContentTraitTest PHPStan-0 issues 2022-10-21 11:24:10 +01:00
catch c42342d31c Issue #3316198 by mondrake: Fix Database\Schema PHPStan-0 issues 2022-10-21 11:14:18 +01:00
catch 2170e97e6d Issue #3316276 by mondrake: Fix 'undefined variable' PHPStan L0 errors 2022-10-21 07:32:15 +01:00
Alex Pott 830646e662
Issue #3309047 by mondrake: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code 2022-10-19 12:03:31 +01:00
Alex Pott 74b0acbefc
Issue #3259109 by mondrake, longwave, andregp, daffie, mglaman, neclimdul, alexpott: Fix 'Cannot unset offset' PHPStan L0 errors 2022-10-17 11:41:00 +01:00
Alex Pott 5564aee8ce
Issue #3313021 by Spokje: Remove obsolete \Drupal\KernelTests\KernelTestBase::prepareTemplate 2022-10-03 10:05:44 +01:00
catch ffdecfadf6 Issue #3274474 by mondrake, longwave, andypost, Spokje, catch, alexpott: Fix 'Access to an undefined property' PHPStan L0 errors 2022-09-13 12:32:43 +01:00
catch b9d8507cbe Issue #3308427 by mondrake, Spokje: Update PHPStan to 1.8.5 2022-09-08 09:48:29 +01:00
catch cee6b9ca2b Issue #3267515 by Spokje, longwave, quietone, phenaproxima: Remove RDF from core 2022-09-02 07:49:58 +01:00
catch fa636e1819 Issue #3270899 by Spokje, quietone, q0rban, longwave, ravi.shankar, dww, andypost, bbrala, Wim Leers: Remove Color module from core 2022-08-21 10:22:37 +09:00
catch ebe774d4b9 Issue #3293216 by longwave, Spokje, quietone: Rename references to Simpletest in tests 2022-08-15 11:24:13 +09:00
Alex Pott b957382d75
Issue #1014086 by catch, nod_, martin107, quietone, dww, mariacha1, Spokje, yogeshmpawar, pounard, Wim Leers, mfer, mikeytown2, mbutcher, moshe weitzman, Fabianx, borisson_, alexpott, donquixote, sun, andypost, dawehner: Stampedes and cold cache performance issues with css/js aggregation 2022-08-08 10:12:23 +01:00
catch 265b3c94a9 Issue #3299606 by Spokje, andypost, mondrake, longwave: Update mglaman/phpstan-drupal to 1.1.25 to unblock testing on PHP 8.2 2022-07-25 09:49:43 +09:00
Alex Pott f76cebd189
Issue #3295157 by mondrake: Fix 'Access to an undefined property' PHPStan L0 errors - public properties 2022-07-11 12:09:54 +01:00
Alex Pott d440b3c6c1
Issue #3137119 follow-up: User::setExistingPassword() does not return $this for chaining 2022-07-09 15:57:55 +01:00
Alex Pott 433f2ae0fd
Issue #3112290 by Spokje, mondrake, mpdonadio, daffie, andypost, Kristen Pol, quietone, mallezie, alexpott: Replace REQUEST_TIME in procedural code 2022-07-04 15:26:28 +01:00
Alex Pott 5253862d0d
Issue #3264145 by ankithashetty, yogeshmpawar, ravi.shankar, mrinalini9, neclimdul, mondrake, longwave, daffie: Fixing missing use statement in ConfigOverrider test class 2022-06-30 17:57:56 +01:00
catch 4fd25f45bd Issue #3285667 by andregp, ankithashetty, quietone, longwave: Remove duplicate test from source\d7\NodeTest::providerSource 2022-06-30 10:06:34 +01:00
Alex Pott 386d79e2e0
Issue #3283794 by mondrake, longwave: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code 2022-06-14 14:10:16 +01:00
Alex Pott ef36c2ead7
Issue #3265429 by neclimdul, eleonel: Fix array keys in MailManagerTest 2022-06-14 12:02:30 +01:00
Alex Pott 6dd0db56c8
Issue #3281535 by mondrake, daffie: Fix 'Access to an undefined property' PHPStan L0 errors in test code 2022-06-14 11:27:54 +01:00
Alex Pott a83509c72f
Revert "Issue #3282315 by mondrake, mallezie, alexpott: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions"
This reverts commit dea3a7f218.
2022-06-08 17:01:24 +01:00
Alex Pott dea3a7f218
Issue #3282315 by mondrake, mallezie, alexpott: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions 2022-06-08 14:46:35 +01:00
Alex Pott 3ac12da415
Revert "Issue #3282315 by mondrake, mallezie, alexpott: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions"
This reverts commit f50b372e85.
2022-06-07 12:47:43 +01:00
Alex Pott f50b372e85
Issue #3282315 by mondrake, mallezie, alexpott: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions 2022-06-07 12:37:04 +01:00
Alex Pott 617d96e967
Issue #3260007 by mondrake, yogeshmpawar, daffie, andypost: Decouple Connection from the wrapped PDO connection to allow alternative clients 2022-05-23 12:03:58 +01:00
Alex Pott b9421033b6
Issue #3281755 by mondrake: PHPStan baseline broken again in head (hopefully for the last time?) 2022-05-22 07:28:59 +01:00
Alex Pott 10dce7b208
Issue #3112283 by ravi.shankar, mpdonadio, andregp, daffie, jhedstrom, alexpott, andypost, pifagor, vladbo, JeroenT, voleger, cliddell: Replace REQUEST_TIME in non-OO and non-module code 2022-05-16 17:27:01 +01:00
Alex Pott 810334c7a2
Issue #3278916 by mallezie, mondrake: Update phpstan/phpstan to latest version 2022-05-16 09:57:27 +01:00
Alex Pott fdfde8e5d1
Issue #3276839 by Spokje, mondrake: Remove leftover dumpHeaders property 2022-05-15 15:25:35 +01:00
Alex Pott 33de6eef4d
Issue #3279840 by Spokje, mallezie, alexpott: Update mglaman/phpstan-drupal 2022-05-13 13:50:28 +01:00
Alex Pott a2b684aacf
Issue #3278052 by Spokje, mondrake: Fix added core/phpstan-baseline.neon error suppresion for core/modules/dblog/tests/src/Functional/DbLogResourceTest.php 2022-05-12 08:45:12 +01:00
Alex Pott e025b90427
Issue #3278782 by mondrake: PHPStan baseline is out of sync 2022-05-12 08:43:09 +01:00
catch f8411d73c4 Issue #3268078 by Spokje, TR: DBLogResource is no longer being tested 2022-04-29 17:36:37 +01:00
Alex Pott 57a7de3798
Issue #3260928 by mondrake, mallezie, neclimdul, mglaman: Move more PHPStan global ignore patterns to baseline 2022-04-08 12:10:20 +02:00
Alex Pott 0e2ea433bf
Issue #3264120 by Spokje, catch, Taran2L, danflanagan8, xjm, quietone, ckrina: Remove aggregator module and our dependency on Laminas Feed 2022-03-29 14:38:11 +01:00
catch f555c85f30 Issue #3211131 by longwave, neclimdul, mondrake: Call to an undefined static method PHPUnit\Util\ErrorHandler::handleError() in DrupalStandardsListenerTrait 2022-03-07 09:49:42 +00:00
catch 9718e6d120 Issue #3266535 by Spokje: Remove remaining references to the hal module from core/phpstan-baseline.neon 2022-02-25 12:59:42 +00:00
Alex Pott 6eb57f0cd4
Issue #3260710 by mglaman: UpdateUploaderTestBase must be declared abstract 2022-02-24 17:42:57 +00:00
catch 0cec48668c Issue #3263654 by Spokje, bbrala, daffie, Kristen Pol, longwave: Move all HAL tests to the module in preparation of removal in D10 2022-02-20 14:43:28 +00:00
catch 5ac3d364d8 Issue #3264153 by neclimdul: Fix missing sprintf argument in CKEditor5ImageController 2022-02-14 14:29:14 +00:00
catch 30e53dfe11 Issue #3262937 by mallezie, alexpott, catch, mondrake, mglaman: PHPStan fails when @legacy tests call deprecated code 2022-02-11 11:35:30 +00:00
catch 0c65c0592c Issue #3261251 by ravi.shankar, andypost, longwave, daffie: Remove deprecated node module functions 2022-02-09 10:14:02 +00:00
catch 22bfdaa366 Issue #3254726 follow-up by catch: adjust phpstan baseline. 2022-02-08 11:40:50 +00:00
catch 8ec62297ba Issue #3261241 by andypost, longwave: Remove deprecated field module functions 2022-02-08 11:38:31 +00:00
Alex Pott f29ceb64c2
Issue #3259110 by longwave, mglaman: Fix undefined variables where files are included 2022-02-01 12:42:01 +00:00
catch 6be0f7b425 Issue #3176468 by longwave, jungle: Remove support for EasyRDF 0.9 2022-01-24 14:29:25 +00:00
catch fe307a0fee Issue #3178534 by mondrake, klausi, alexpott, longwave, mallezie, Taran2L, mglaman, Spokje, kim.pepper, daffie, andypost, neclimdul, xjm, Gábor Hojtsy, cmlara: Start running PHPStan on Drupal core (level 0) 2022-01-18 10:08:49 +00:00