Issue #3276839 by Spokje, mondrake: Remove leftover dumpHeaders property

merge-requests/1697/head
Alex Pott 2022-05-15 15:25:35 +01:00
parent ba111c104d
commit fdfde8e5d1
No known key found for this signature in database
GPG Key ID: BDA67E7EE836E5CE
17 changed files with 0 additions and 72 deletions

View File

@ -39,11 +39,6 @@ class BigPipeTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
/**
* {@inheritdoc}
*/
protected $dumpHeaders = TRUE;
/**
* {@inheritdoc}
*/

View File

@ -22,11 +22,6 @@ use Drupal\Tests\BrowserTestBase;
*/
class DynamicPageCacheIntegrationTest extends BrowserTestBase {
/**
* {@inheritdoc}
*/
protected $dumpHeaders = TRUE;
/**
* {@inheritdoc}
*/

View File

@ -24,8 +24,6 @@ class ImageFieldDisplayTest extends ImageFieldTestBase {
compareFiles as drupalCompareFiles;
}
protected $dumpHeaders = TRUE;
/**
* Modules to enable.
*

View File

@ -52,8 +52,6 @@ class NodeAccessCacheabilityTest extends NodeTestBase {
* @see node_query_node_access_alter()
*/
public function testNodeAccessCacheabilitySafeguard() {
$this->dumpHeaders = TRUE;
// The node grants cache context should be added automatically.
$this->drupalGet(new Url('node_access_test_auto_bubbling'));
$this->assertCacheContext('user.node_grants:view');

View File

@ -26,11 +26,6 @@ class FrontPageTest extends ViewTestBase {
*/
protected $defaultTheme = 'stark';
/**
* {@inheritdoc}
*/
protected $dumpHeaders = TRUE;
/**
* The entity storage for nodes.
*

View File

@ -23,8 +23,6 @@ class PageCacheTagsIntegrationTest extends BrowserTestBase {
*/
protected $profile = 'standard';
protected $dumpHeaders = TRUE;
/**
* {@inheritdoc}
*/

View File

@ -20,8 +20,6 @@ class PageCacheTest extends BrowserTestBase {
use AssertPageCacheContextsAndTagsTrait;
protected $dumpHeaders = TRUE;
/**
* Modules to enable.
*

View File

@ -26,8 +26,6 @@ class ResponsiveImageFieldDisplayTest extends ImageFieldTestBase {
*/
protected $defaultTheme = 'stark';
protected $dumpHeaders = TRUE;
/**
* Responsive image style entity instance we test with.
*

View File

@ -25,11 +25,6 @@ class SearchPageCacheTagsTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
/**
* {@inheritdoc}
*/
protected $dumpHeaders = TRUE;
/**
* A user with permission to search content.
*

View File

@ -10,13 +10,6 @@ use Drupal\Tests\BrowserTestBase;
*/
abstract class PageCacheTagsTestBase extends BrowserTestBase {
/**
* {@inheritdoc}
*
* Always enable header dumping in page cache tags tests, this aids debugging.
*/
protected $dumpHeaders = TRUE;
/**
* {@inheritdoc}
*/

View File

@ -28,8 +28,6 @@ class SessionExistsCacheContextTest extends BrowserTestBase {
* Tests \Drupal\Core\Cache\Context\SessionExistsCacheContext::getContext().
*/
public function testCacheContext() {
$this->dumpHeaders = TRUE;
// 1. No session (anonymous).
$this->assertSessionCookieOnClient(FALSE);
$this->drupalGet(Url::fromRoute('<front>'));

View File

@ -12,11 +12,6 @@ use Drupal\Tests\BrowserTestBase;
*/
class EarlyRenderingControllerTest extends BrowserTestBase {
/**
* {@inheritdoc}
*/
protected $dumpHeaders = TRUE;
/**
* {@inheritdoc}
*/

View File

@ -24,8 +24,6 @@ class SessionTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
protected $dumpHeaders = TRUE;
/**
* Tests for \Drupal\Core\Session\WriteSafeSessionHandler::setSessionWritable()
* ::isSessionWritable and \Drupal\Core\Session\SessionManager::regenerate().

View File

@ -37,11 +37,6 @@ class UpdateScriptTest extends BrowserTestBase {
*/
protected $defaultTheme = 'stark';
/**
* {@inheritdoc}
*/
protected $dumpHeaders = TRUE;
/**
* The URL to the status report page.
*

View File

@ -31,8 +31,6 @@ class WorkspaceCacheContextTest extends BrowserTestBase {
* Tests the 'workspace' cache context.
*/
public function testWorkspaceCacheContext() {
$this->dumpHeaders = TRUE;
$renderer = \Drupal::service('renderer');
$cache_contexts_manager = \Drupal::service("cache_contexts_manager");

View File

@ -2178,11 +2178,6 @@ parameters:
count: 2
path: modules/node/src/Plugin/views/row/Rss.php
-
message: "#^Access to an undefined property Drupal\\\\Tests\\\\node\\\\Functional\\\\NodeAccessCacheabilityTest\\:\\:\\$dumpHeaders\\.$#"
count: 1
path: modules/node/tests/src/Functional/NodeAccessCacheabilityTest.php
-
message: "#^Access to an undefined property Drupal\\\\Tests\\\\node\\\\Functional\\\\NodeAccessGrantsCacheContextTest\\:\\:\\$noAccessUser2\\.$#"
count: 1
@ -2653,10 +2648,6 @@ parameters:
count: 1
path: modules/system/tests/modules/service_provider_test/src/TestFileUsage.php
-
message: "#^Access to an undefined property Drupal\\\\Tests\\\\system\\\\Functional\\\\Cache\\\\SessionExistsCacheContextTest\\:\\:\\$dumpHeaders\\.$#"
count: 1
path: modules/system/tests/src/Functional/Cache/SessionExistsCacheContextTest.php
-
message: "#^Access to an undefined property Drupal\\\\Tests\\\\system\\\\Functional\\\\Entity\\\\EntityListBuilderTest\\:\\:\\$webUser\\.$#"
@ -3603,10 +3594,6 @@ parameters:
count: 1
path: modules/workspaces/src/WorkspacePublisher.php
-
message: "#^Access to an undefined property Drupal\\\\Tests\\\\workspaces\\\\Functional\\\\WorkspaceCacheContextTest\\:\\:\\$dumpHeaders\\.$#"
count: 1
path: modules/workspaces/tests/src/Functional/WorkspaceCacheContextTest.php
-
message: "#^Access to an undefined property Drupal\\\\Tests\\\\workspaces\\\\Kernel\\\\EntityReferenceSupportedNewEntitiesConstraintValidatorTest\\:\\:\\$entityTypeManager\\.$#"
@ -3623,11 +3610,6 @@ parameters:
count: 5
path: profiles/demo_umami/modules/demo_umami_content/src/InstallHelper.php
-
message: "#^Access to an undefined property Drupal\\\\Tests\\\\standard\\\\Functional\\\\StandardTest\\:\\:\\$dumpHeaders\\.$#"
count: 1
path: profiles/standard/tests/src/Functional/StandardTest.php
-
message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:10\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"
count: 1

View File

@ -170,7 +170,6 @@ class StandardTest extends BrowserTestBase {
// Verify certain routes' responses are cacheable by Dynamic Page Cache, to
// ensure these responses are very fast for authenticated users.
$this->dumpHeaders = TRUE;
$this->drupalLogin($this->adminUser);
$url = Url::fromRoute('contact.site_page');
$this->drupalGet($url);