Commit Graph

199 Commits (ac8556f35ea26a1cc5c8fa85cf294784b487bbdf)

Author SHA1 Message Date
Alex Pott 6eaf9fa3c3
Issue #3391530 by Spokje, alexpott: Fix PHPStan L1 error "Variable $foo in/on something() is never defined." 2023-10-16 16:34:26 +02:00
Dave Long 5e8d5e8a48
Issue #3387988 by quietone, atul4drupal: Fix @return type, simple fixes 2023-10-13 14:42:49 +01:00
Dave Long 5a359db70a
Issue #3383456 by Spokje: Replace call to deprecated method setMethods() of class MockBuilder with onlyMethods() 2023-10-13 13:39:07 +01:00
Dave Long ce2e1aa235
Issue #3392313 by Spokje: Bump phpstan/phpstan to latest to make daily "updated deps" QA run pass again 2023-10-07 15:58:43 +01:00
xjm 063a9f708a
Issue #3387556 by Spokje, smustgrave: Remove redundant if (empty($machine_name_1_value))-statement in MachineNameTest::testMachineName 2023-09-30 13:57:06 -05:00
xjm 7f21a89a98
Issue #3387560 by Spokje, smustgrave: Returntype incorrect for \Drupal\Core\Entity\EntityDeleteMultipleAccessCheck::$tempStore 2023-09-30 13:31:31 -05:00
Lauri Eskola 861aa769fc
Issue #3389668 by catch: Split up ConfigTranslationUiTest 2023-09-29 12:44:48 +03:00
catch c19a53a053 Issue #315302 by mstrelan, tacituseu, PaulMagrath, coltrane, yched, DamienMcKenna, quietone: Node Access Rebuild never finishes (infinite loop) 2023-09-15 08:11:02 +01:00
catch 5aa70a9fc4 Issue #3385095 by Spokje: Replace call to deprecated function GuzzleHttp\default_user_agent() 2023-09-08 11:30:24 +01:00
catch 5404ebfb11 Issue #2791693 by nginex, acbramley, oknate, guaneagler, jan kellermann, jonathan1055, jibran, ankithashetty, dpi, Jelle_S, FeyP, kattekrab, smustgrave, mpdonadio, quietone, AaronMcHale, rkoller, BlackBamboo, simohell, Jody Lynn, shaal, notmike: Remove sample date from date field error message and title attribute 2023-09-04 10:13:48 +01:00
catch cc0c9fdde2 Issue #3383513 by Spokje, smustgrave: Use type-hinting on deprecation warnings for loadRevision() introduced by mglaman/phpstan-drupal:1.2.0 2023-08-29 13:03:05 +01:00
catch 09b54e9786 Issue #3383591 by Spokje: Use type-hinting on deprecation warnings for deleteRevision() introduced by mglaman/phpstan-drupal:1.2.0 2023-08-29 08:51:33 +01:00
catch 12dabf05a0 Issue #3383339 by Spokje: Replace implementing deprecated interface Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface with ValueResolverInterface 2023-08-26 09:21:14 +01:00
catch 97f1d6b0b0 Issue #3383367 by Spokje: Add @group legacy to EditorMediaDialogTest 2023-08-26 09:17:20 +01:00
catch b50ba1f4a9 Issue #3383316 by Spokje: Replace deprecated getComposer() of class Composer\Command\BaseCommand in ComposerScaffoldCommand 2023-08-26 09:14:31 +01:00
catch 70e2c38099 Issue #3383215 by mglaman, Spokje, bbrala: Rearrange interfaces TranslatableRevisionableStorageInterface extends to fix deprecation warnings 2023-08-26 08:40:14 +01:00
catch 27aba04e2c Issue #3327294 by poker10, alexpott: Username enumeration via one time login route when logged in as another user 2023-08-25 16:19:45 +01:00
catch 6a3bddd0be Issue #3383279 by Spokje, bbrala: Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again 2023-08-25 15:59:54 +01:00
Dave Long fc54da11c4
Issue #3372757 by Spokje: Bump phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again 2023-07-23 13:13:26 +01:00
Dave Long 2096ffc653
Revert "Issue #3372757: Bump phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again"
This reverts commit 0a283530d7.
2023-07-23 13:13:20 +01:00
Dave Long 0a283530d7
Issue #3372757: Bump phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again 2023-07-23 13:05:45 +01:00
Lauri Eskola 985b1efaef
Issue #3374878 by Spokje: Fix PHPStan L1 errors "Offset 'foo' on array{} in isset() does not exist." 2023-07-22 11:14:41 +03:00
catch 3d4e3fc793 Issue #3264148 by neclimdul, Wim Leers, xjm: remove inner _add_ajax_listeners_to_plugin_inputs and _add_attachments_to_editor_update_response function definitions 2023-07-19 12:30:32 +01:00
catch d0337fa72b Issue #3374253 by TwoD, smustgrave: The renderer throws away cache metadata from access result if it is not allowed 2023-07-14 23:26:34 +01:00
hooroomoo 9d522de054 Issue #3356894 by hooroomoo, lauriii, srishtiiee, Rajeshreeputra, Utkarsh_33, bnjmnm, narendraR, tim.plunkett, smustgrave, ckrina, yoroy, amateescu, Wim Leers: Make field selection less overwhelming by introducing groups 2023-06-30 19:27:14 +00:00
Dave Long 62d7c46774
Issue #3318888 by mondrake, Spokje, smustgrave, xjm, longwave: Fix migrate destination entity PHPStan L0 issues 2023-06-27 14:48:10 +01:00
Dave Long 67bad1b36c
Issue #3359179 by Spokje: Fix PHPStan L1 errors "@coversDefaultClass defined on class method foo." 2023-06-22 14:13:38 +01:00
Dave Long cc97afe40d
Issue #3359048 by Spokje, smustgrave: Fix PHPStan L1 errors "Cannot unset offset 'foo' on array<int, string>." 2023-06-22 14:11:59 +01:00
Dave Long 95c061fa9c
Issue #3358890 by Spokje, mondrake, smustgrave: Fix PHPStan L1 errors "Class \Foo\Bar not found." 2023-06-22 14:10:02 +01:00
Dave Long 7e4ecad537
Issue #3354063 by Spokje, longwave, mondrake, Gauravvvv, joachim: Fix missing call to parent::setUp() in remaining tests 2023-06-21 22:52:41 +01:00
catch d704aa3827 Issue #3325175 by Spokje, mondrake, andypost, xjm: Deprecate calling \Drupal\menu_link_content\Form\MenuLinkContentForm::_construct() with the $language_manager argument 2023-06-21 15:26:13 +01:00
catch 339643bebb Issue #2551419 by kristiaanvandeneynde, catch, dawehner, Wim Leers, borisson_, bradjones1, tstoeckler, andypost: Abstract RenderCache into a separate service that is capable of cache redirects in a non-render array-specific way 2023-06-07 16:56:20 +01:00
catch 5062db5e65 Issue #3362569 by Spokje: Update mglaman/phpstan-drupal and make daily "updated deps" QA jobs pass 2023-05-25 12:29:42 +01:00
Dave Long eb39373a8a
Issue #3361148 by Spokje: Update mglaman/phpstan-drupal and make daily "updated deps" QA jobs pass 2023-05-22 22:39:56 +01:00
catch 75085fa400 Issue #3337513 by mondrake, gidarai, VladimirAus, daffie, catch, andypost, smustgrave, rkoller, alexpott: Fix batch process race conditions by making ‘bid (batch id)’ auto-increment 2023-05-22 11:58:06 +01:00
catch 4ab1f4b027 Issue #3359065 by Spokje: Fix PHPStan L1 errors "Fix PHPStan L1 errors "Array has 2 duplicate keys with value 'Foo.SOME_KEY'..." 2023-05-11 14:04:15 +01:00
catch 51021373a6 Issue #3359543 by Spokje: Update mglaman/phpstan-drupal and make daily "updated deps" QA jobs pass 2023-05-11 10:23:55 +01:00
catch 19d08d31aa Issue #3351379 by Spokje, mondrake, longwave: Only mock methods defined in interfaces 2023-05-04 13:22:13 +01:00
catch 63e7604841 Issue #3357646 by Spokje: Fix 2 PHPStan L1 errors "Relying on entity queries to check access by default is deprecated..." in the Layout Builder module 2023-05-02 19:28:22 +01:00
catch 9121ea0b49 Issue #3357114 by Spokje: Update mglaman/phpstan-drupal and help make daily "updated deps" QA jobs pass 2023-05-01 12:03:12 +01:00
catch c49ae937ea Issue #3330981 by Spokje, smustgrave, mallezie, catch, xjm: Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated..." 2023-04-28 09:37:27 +01:00
Lee Rowlands 6af88f6d6e
Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, Berdir, alexpott, marcelovani, catch, Lendude, mstrelan, tar_inet, Honza Pobořil, seanB, andrewbelcher, danflanagan8, susgo, sylus, sjpeters79, yogeshmpawar, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD 2023-04-27 07:58:01 +10:00
catch 9a1b764427 Issue #3355137 by Spokje: Update mglaman/phpstan-drupal and make daily "updated deps" QA jobs pass 2023-04-21 11:39:20 +01:00
Lauri Eskola 1996c9d44d
Issue #857312 by bnjmnm, tim.plunkett, yched, swentel, nod_, nick_schuch, smustgrave: Add a "changes not applied until saved" warning when changing widget/formatter settings 2023-04-20 19:10:52 +03:00
Dave Long 99492c0288
Issue #3351095 by Spokje, daffie, longwave, xjm: Fix PHPStan L1 errors "@covers value foo references an invalid class or function." 2023-04-16 22:56:57 +01:00
Dave Long 596b3d38f1
Issue #3351236 by Spokje, mondrake, smustgrave: Fix PHPStan L1 errors "Missing call to parent::setUp()/tearDown() method." 2023-04-16 22:50:09 +01:00
Dave Long 15881f46b9
Issue #3352367 by andypost: Fix Variable $graph might not be defined 2023-04-12 14:19:17 +01:00
Dave Long 60f751eaab
Issue #3352758 by Spokje: Fix PHPStan L1 errors "#foo callback 'bar' at key 'n' is not callable." 2023-04-12 14:16:27 +01:00
Dave Long a701bab559
Issue #3352932 by Spokje: Fix PHPStan L1 error "Class Foo\Bar\Baz referenced with incorrect case: Foo\bar\Baz." 2023-04-12 14:14:41 +01:00
Dave Long e55cf5ca78
Issue #3352944 by Spokje: Fix PHPStan L1 errors "#pre_render/#lazy_builder callback '\Foo\Bar' at key 'n' is not trusted." 2023-04-12 14:11:53 +01:00
Dave Long 85aee30af3
Issue #3351089 by Spokje: Fix PHPStan L1 errors "@dataProvider Foo related method not found." 2023-04-11 18:46:51 +01:00
catch bef31d1d77 Issue #3352938 by Spokje, smustgrave: Fix PHPStan L1 errors "Configuration entity must define a `config_export` key." 2023-04-11 15:20:13 +01:00
Lee Rowlands 40b09f3b48
Revert "Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD"
This reverts commit 7ea52649ec.
2023-04-05 08:21:03 +10:00
Lee Rowlands 7ea52649ec
Issue #3007424 by acbramley, Spokje, mbovan, narendra.rajwar27, AaronBauman, ravi.shankar, aleevas, geek-merlin, jibran, YurkinPark, daffie, larowlan, alexpott, marcelovani, catch, Berdir, Lendude, mstrelan, tar_inet, andrewbelcher, seanB, Honza Pobořil, danflanagan8, susgo, yogeshmpawar, sylus, sjpeters79, raman.b: Multiple usages of FieldPluginBase::getEntity do not check for NULL, leading to WSOD 2023-04-04 14:37:06 +10:00
catch 8c61db1638 Issue #3351073 by Spokje: Fix PHPStan L1 errors "Annotation "@covers::foo" is invalid, "@covers" should be followed by a space and a value." 2023-03-31 11:21:54 +01:00
catch 1f7aa7ac83 Issue #3351218 by Spokje: Fix PHPStan L1 errors "@covers value \Foo\Bar::baz() references an invalid method." 2023-03-30 16:22:57 +01:00
catch 6ca4984f03 Issue #3351079 by Spokje: Fix PHPStan L1 errors "You should use assertFoo() instead of assertSame(foo, $actual)." 2023-03-29 23:50:46 +01:00
catch 336c3ef206 Issue #3351060 by Spokje: Fix PHPStan L1 errors "You should use assertNull() instead of assertSame(null, $actual)." 2023-03-29 23:46:03 +01:00
catch 821cc64ae6 Issue #3351067 by Spokje: Fix PHPStan L1 errors "Class already @covers \Foo\Bar so the method @covers is redundant." 2023-03-29 21:18:34 +01:00
Alex Pott 947fd48d2b
Issue #3326239 by mondrake, Spokje, andypost, longwave, xjm, quietone: Add phpstan/phpstan-phpunit as a dev dependency 2023-03-29 11:45:04 +01:00
catch 0bbf07394d Issue #3245252 by andypost, ranjith_kumar_k_u, Spokje: Fix possibly undefined $finished in _batch_process() 2023-03-28 12:18:57 +01:00
catch 8726c00a0e Revert "Issue #3337513 by mondrake, gidarai, daffie, alexpott, catch: Fix batch process race conditions by making ‘bid (batch id)’ auto-increment"
This reverts commit 779785e220.
2023-03-23 17:24:34 +00:00
catch 779785e220 Issue #3337513 by mondrake, gidarai, daffie, alexpott, catch: Fix batch process race conditions by making ‘bid (batch id)’ auto-increment 2023-03-21 12:29:21 +00:00
Dave Long de09fc95c5
Issue #3322743 by Spokje, mondrake: Fix PHPStan L2 errors "Parameter $foo of method Foo::bar() has invalid type Foo\Baz." and "Method Foo::bar() has invalid return type Foo\Baz. " 2023-03-12 19:15:58 +00:00
catch 60c2916b17 Issue #3335110 by Spokje, mondrake: Fix PHPStan L1 errors "#foo callback class 'Bar\Baz')' at key 'X' does not implement Drupal\Core\Security\TrustedCallbackInterface." 2023-03-10 14:29:37 +00:00
catch f247d598cb Issue #3341098 by quietone: Move non-migrations tests to Statistics 2023-02-25 09:46:08 +00:00
Dave Long cc21877471
Issue #3264167 by Spokje, neclimdul, heykarthikwithu, longwave: Remove use of final Guzzle client class 2023-02-24 09:54:12 +00:00
catch 7cf8cec67d Issue #3341254 by Spokje, longwave: Fix failing "updated deps" test-runs on 10.x.x 2023-02-23 14:58:45 +00:00
Dave Long 1ac46a2af3
Issue #3308920 by jungle, smustgrave, Lendude: Fix test performance of Drupal\Tests\user\FunctionalJavascript\UserPasswordResetTest 2023-02-23 14:11:23 +00:00
catch 1c5789b443 Issue #3336536 by murilohp: Fix PHPStan warning on assertBreadcrumb when passing NULL 2023-02-23 11:11:10 +00:00
Alex Pott f979f42ec0
Issue #3323209 by Spokje, mondrake, smustgrave, alexpott, xjm: Deprecate calling Drupal\block\Plugin\migrate\process\BlockTheme::_construct() with the $migration argument 2023-02-22 21:38:00 +00:00
catch 79cd4d3682 Issue #3336586 by Spokje: Fix failing "updated deps" test-runs by upping mglaman/phpstan-drupal to latest 2023-02-10 16:05:33 +00:00
catch 461eb14b7a Issue #3326378 by Spokje: Fix PHPStan L1 error "Instantiated class Foo\Bar not found." 2023-02-06 12:05:14 +00:00
catch 480569932d Issue #3336527 by murilohp, longwave: Remove unnecessary variables from core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php 2023-02-03 11:40:04 +00:00
Lauri Eskola bfe3f5dc98
Issue #3333569 by alorenc, lauriii, smustgrave, larowlan: Breadcrumb for local tasks of Custom Blocks should contain the name of the custom block not the entity ID 2023-01-25 12:39:26 +02:00
Alex Pott 4936c9bd07
Issue #3260391 by huzooka, arunkumark, Spokje, quietone: BlockedIp::import violates MigrateDestinationInterface::import 2023-01-13 15:39:46 +00:00
Dave Long e1e56ac4a5
Issue #3333065 by Spokje: Update PHPStan to 1.9.9 to fix 10.x "updated deps" Drupal CI runs 2023-01-12 23:17:41 +00:00
xjm 4d9b40b01e
Issue #3244570 by voleger, xjm, alexpott, longwave, andypost: Deprecate drupal_rewrite_settings() 2023-01-07 15:32:44 -06:00
catch c6babbb64e Issue #3324384 by Spokje, joachim, elber, znerol, longwave, mondrake: resolve differing createUser() test methods 2023-01-06 11:14:45 +00:00
Alex Pott dd9b1659db
Issue #3330305 by Spokje, mondrake: Fix failing "updated deps" test-runs by upping mglaman/phpstan-drupal to latest 2023-01-03 11:57:57 +00:00
xjm 53803cfb4c
Issue #3317230 by mondrake, kim.pepper, longwave: Fix test mock related PHPStan 0 issues 2023-01-02 05:07:22 -06:00
Alex Pott 1a63aa6318
Issue #3326371 by Spokje: Fix PHPStan L1 error "Anonymous function has an unused use $foo." 2022-12-30 16:39:39 +00:00
Dave Long 1e659b4a79
Issue #3327018 by Spokje, longwave, xjm: Update PHPStan to 1.9.3 and make daily "updated deps" QA jobs pass 2022-12-20 11:19:33 +00:00
xjm 2a461dcd71
Issue #3325184 by Spokje, andypost, xjm, smustgrave: $this->configFactory is not set properly in the constructor of \Drupal\system\Form\CronForm 2022-12-16 13:21:42 -06:00
Alex Pott e2d4dcfdf2
Issue #3319582 by mondrake, Spokje, longwave, mallezie: Fix calls to methods with too many parameters passed in 2022-11-29 11:38:06 +00:00
Alex Pott d9059c0650
Issue #3323260 by Spokje, longwave: Deprecate node_revision_load() and friends 2022-11-23 21:54:56 +00:00
Dave Long 5c1863a060
Issue #3322961 by mondrake: Fix WebAssert since PHPStan can now check the number of arguments passed to methods 2022-11-22 14:11:50 +00:00
Dave Long c4a3b2558d
Issue #3323036 by mondrake, mallezie: Remove $group parameter from AssertContentTrait methods 2022-11-22 13:48:02 +00:00
catch 8e71d46598 Issue #3320025 by alexpott, longwave: Make PHPStan baseline the same in 10.1.x and 10.0.x 2022-11-09 14:58:26 +00:00
catch 0dc16934ab Issue #3319683 by alexpott, mallezie, mondrake: Fix PHPStan errors from UserCreationTrait and AssertMailTrait 2022-11-09 11:27:52 +00:00
Alex Pott e00c523fb4
Issue #3317651 by mondrake, longwave, alexpott: Fix DataReferenceBase PHPStan L0 issues 2022-11-08 15:57:37 +00:00
Alex Pott 7fa5f0a577
Issue #3190406 by mondrake, mallezie, klausi: Update PHPStan to level 1 2022-11-07 12:38:24 +00:00
Alex Pott d96c99b491
Issue #3317652 by mondrake, longwave: Fix Updater PHPStan L0 issues 2022-11-03 00:23:39 +00:00
catch 08b0f54bf4 Issue #3317658 by pooja saraah, mondrake, ravi.shankar, longwave: Fix HoldTestSubscriber PHPStan L0 issues 2022-11-02 14:54:34 +00:00
Alex Pott e54ef601a4
Issue #3317874 by longwave, mondrake: Update dependencies for Drupal 10.0 2022-11-01 15:42:01 +00:00
catch 23b444af40 Issue #3317223 by mondrake, longwave: Fix RecursiveExtensionFilterIterator PHPStan L0 issues 2022-10-26 08:23:29 +01:00
catch c2a6c76593 Issue #3317243 by mondrake: Fix PluginManagerBase PHPStan-0 issues 2022-10-25 09:04:50 +01:00
catch 4c187847dc Issue #3316950 by mondrake: Fix StreamWrapper\ReadOnlyStream PHPStan-0 issues 2022-10-24 15:57:12 +01:00
catch 43e4c4a853 Issue #3316960 by mondrake: Fix PageRenderTest PHPStan L0 issues 2022-10-24 15:23:17 +01:00
catch 8b08268ead Issue #3316825 by mondrake, Spokje: Fix Kernel/RenderCacheIntegrationTest PHPStan L0 issues 2022-10-21 20:54:32 +01:00