Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3374878 by Spokje: Fix PHPStan L1 errors "Offset 'foo' on array{} in isset() does not exist."

merge-requests/4449/head
Lauri Eskola 2023-07-22 11:14:41 +03:00
parent fb90a180aa
commit 985b1efaef
No known key found for this signature in database
GPG Key ID: 382FC0F5B0DF53F8
3 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/modules/views/tests/src/Kernel/Handler/AreaDisplayLinkTest.php
View File

@ -308,7 +308,9 @@ class AreaDisplayLinkTest extends ViewsKernelTestBase {
protected function assertFormOptions(ViewExecutable $view, string $display_link_id): void {
$form = [];
$form_state = new FormState();
$view->display_handler->getHandler('header', $display_link_id)->buildOptionsForm($form, $form_state);
/** @var \Drupal\views\Plugin\views\area\DisplayLink $display_handler */
$display_handler = $view->display_handler->getHandler('header', $display_link_id);
$display_handler->buildOptionsForm($form, $form_state);
$this->assertTrue(isset($form['display_id']['#options']['page_1']));
$this->assertTrue(isset($form['display_id']['#options']['page_2']));
$this->assertFalse(isset($form['display_id']['#options']['block_1']));

4
core/modules/views/tests/src/Kernel/Handler/AreaEntityTest.php
View File

@ -179,7 +179,9 @@ class AreaEntityTest extends ViewsKernelTestBase {
$form = [];
$form_state = (new FormState())
->set('type', 'header');
$view->display_handler->getHandler('header', 'entity_entity_test')->buildOptionsForm($form, $form_state);
/** @var \Drupal\views\Plugin\views\area\DisplayLink $display_handler */
$display_handler = $view->display_handler->getHandler('header', 'entity_entity_test');
$display_handler->buildOptionsForm($form, $form_state);
$this->assertTrue(isset($form['view_mode']['#options']['test']), 'Ensure that the test view mode is available.');
$this->assertTrue(isset($form['view_mode']['#options']['default']), 'Ensure that the default view mode is available.');
}

10
core/phpstan-baseline.neon
View File

@ -2445,16 +2445,6 @@ parameters:
count: 2
path: modules/views/tests/src/FunctionalJavascript/ClickSortingAJAXTest.php
-
message: "#^Offset 'display_id' on array\\{\\} in isset\\(\\) does not exist\\.$#"
count: 1
path: modules/views/tests/src/Kernel/Handler/AreaDisplayLinkTest.php
-
message: "#^Offset 'view_mode' on array\\{\\} in isset\\(\\) does not exist\\.$#"
count: 1
path: modules/views/tests/src/Kernel/Handler/AreaEntityTest.php
-
message: "#^Call to deprecated constant REQUEST_TIME\\: Deprecated in drupal\\:8\\.3\\.0 and is removed from drupal\\:11\\.0\\.0\\. Use \\\\Drupal\\:\\:time\\(\\)\\-\\>getRequestTime\\(\\); $#"
count: 3