201e1dd356
- Patch #268449 by catch: fixed some tests that failed due to invalid permissions.
2008-06-09 16:33:20 +00:00
5ed9cf76a0
- Patch #253577 by Morbus Iff: allow new comment timestamp to be passed.
2008-06-09 07:07:36 +00:00
dc613626d4
- Patch #266465 by R.Muilwijk: fixed the comment module tests.
2008-06-05 17:57:04 +00:00
3f052180dc
- Patch #66264 by boombatower: comment approval displayed on node view of comment. Comes with tests and everything.
2008-06-03 16:30:20 +00:00
c6c26b5e23
- Patch #247423 by boombatower: code style fixes for the tests.
2008-05-30 07:30:53 +00:00
8cc4aaeeae
- Patch #258171 by Senpai: code cleanup.
2008-05-14 13:12:41 +00:00
11aeff6016
- Patch #145242 by douggreen et al: refactor node_rank to modules can add scoring factors.
2008-05-14 11:10:54 +00:00
2e18cb8924
- Patch #221964 by chx, dopry, webernet, moshe, webchick, justinrandall, flobruit
...
et al. Can you say 'registry'? Drupal now maintains an internal registry of
all functions or classes in the system, allowing it to lazy-load code files as
needed (reducing the amount of code that must be parsed on each request). The
list of included files is cached per menu callback for subsequent loading by
the menu router. This way, a given page request will have all the code it needs
but little else, minimizing time spent parsing unneeded code.
2008-05-06 12:18:54 +00:00
d1bc889242
- Patch #227830 by JohnAlbin: link attributes added to l() incorrectly.
2008-05-02 15:11:05 +00:00
159bb6dd08
- Rollback.
2008-04-25 18:34:05 +00:00
d7f3c18d17
- Patch #250729 by R.Muilwijk: performance improvement.
2008-04-25 17:59:36 +00:00
21576021bf
- Patch #249546 by pwolanin: rip menu access inheritance -- was already committed to D6.
2008-04-23 20:01:56 +00:00
d1779405d2
- Patch #249941 by John Morahan: fixed incorrect parameters of watchdog() calls.
2008-04-23 18:05:58 +00:00
af474609e3
- Added a test framework to Drupal along with a first batch of tests for
...
Drupal core! This is an important milestone for the project so enable
the module and check it out ... :)
Thanks to Rok Žlender, Károly Négyesi, Jimmy Berry, Kevin Bridges, Charlie
Gordon, Douglas Hubler, Miglius Alaburda, Andy Kirkham, Dimitri13, Kieran
Lal, Moshe Weitzman, and the many other people that helped with testing
over the past years and that drove this home.
It all works but it is still rough around the edges (i.e. documentation
is still being written, the coding style is not 100% yet, a number of
tests still fail) but we spent the entire weekend working on it in Paris
and made a ton of progress. The best way to help and to get up to speed,
is to start writing and contributing some tests ... as well as fixing
some of the failures.
For those willing to help with improving the test framework, here are
some next steps and issues to resolve:
- How to best approach unit tests and mock functions?
- How to test drupal_mail() and drupal_http_request()?
- How to improve the admin UI so we have a nice progress bar?
- How best to do code coverage?
- See http://g.d.o/node/10099 for more ...
2008-04-20 18:24:07 +00:00
46546ef478
- Patch #175841 by catch et al: remove comment controls for users. Yowza.
2008-04-16 11:26:29 +00:00
56d2664a90
- Patch #245115 by kkaefer, John Morahan, JohnAlbin et al: after a long discussion we've decided to make the concatenation operator consistent with the other operators.
2008-04-14 17:48:46 +00:00
79b016d915
- Patch #216072 by recidive, David Rothstein, ptalindstrom et al: switched from numeric block IDs to string IDs.
...
The short explanation is that Drupal uses a lot of numeric deltas in the block system; blocks are identified by the 'module' and the 'delta'. In early Drupal, delta was numeric, but somewhere along the line it was changed to be possibly a string. In modern Drupal, block overrides are easily done via block-MODULE-DELTA.tpl.php. The primary motivation to switch to string IDs everywhere is to make these deltas friendlier to themers:
block-user-0.tpl.php --> block-user-navigation.tpl.php
block-user-1.tpl.php --> block-user-login.tpl.php
You get the picture.
2008-04-10 10:28:23 +00:00
23602afbe1
- Patch #195072 by webchick and coltrane: make _comment_load() a public API function by renaming it to comment_load().
2008-04-10 10:13:57 +00:00
91824358be
- Patch #216504 by webchick et al: added missing table alias in comment_render function.
2008-04-10 01:45:38 +00:00
1dfd1717c1
- Patch #240387 by matt2000 et al: move 'content types' to 'site building' per the UMN usability study results.
2008-04-06 18:50:12 +00:00
f5d4287cd5
- Patch #214271 by recidive: improved schema identation.
2008-03-15 12:31:29 +00:00
33853f6d9c
- Patch #228120 by jvandyk: fixed code comment.
2008-03-10 18:25:48 +00:00
6030a5b2e4
- Patch #81931 by keith.smith: improved wording of help text.
2008-02-23 08:02:48 +00:00
657935c263
- Patch #81931 by webchick et al: made the recent comments block configurable. Somme minor changes by me.
2008-02-21 19:38:07 +00:00
584f3e886a
- Patch #30984 by webchick, keith.smith, kkaefer, Crell et al: provide descriptions for permissions on the permission administration page.
2008-02-20 13:46:43 +00:00
b05db1f176
- Patch #221384 by webernet: update core compatibility to Drupal 7.
2008-02-18 19:19:49 +00:00
b8a1eab1fb
- Patch #210131 by dvessel, catch, John, et al: updated jQuery library.
2008-02-06 19:38:28 +00:00
85cae0d01a
#204411 by chx, slightly modified: heal a possible MySQL import error when the anonymous user becomes broken
2008-01-25 16:19:13 +00:00
7f85bc5bc4
#208938 by bjaspan, scor: use schema PI for index updates instead of database dependent code
2008-01-16 21:45:30 +00:00
c5aa55b38e
#204705 by pwolanin: abort user_save on SQL errors, to avoid data corruption
2008-01-10 15:03:53 +00:00
b78a990270
#207569 by ScoutBaker (minor code style): clean up @see usage in phpdoc blocks
2008-01-08 10:35:43 +00:00
7127adabb0
- Patch #205465 by jvandyk: add missing index on comment table.
2008-01-05 22:45:40 +00:00
258b576020
#199809 by theborg: comment templates were not checking status properly (fix notice, allows themes to theme in-preview comments differently)
2008-01-04 19:24:24 +00:00
a555202276
#195161 follow up by keith.smith: fix typo in code comment
2008-01-04 15:11:59 +00:00
9bc7c07cb7
#195161 by mcarbone with some modifications: only show 'login to post comments' if logging in actually lets you post comments
2008-01-04 11:34:19 +00:00
a88c178b91
- Patch #204221 by webernet: code style fixes.
2007-12-28 12:02:52 +00:00
1d4fc1b1af
#202473 by keith.smith: pre-RC1 spell checking on hopefully final text
2007-12-19 21:40:05 +00:00
fcbd175337
#189878 by O Govinda, keith.smith: comment module help updates, removing help on features which are not there, and adding help on Drupal 6's new per content type comment settings
2007-12-19 19:17:20 +00:00
d17b6ad1cf
#199336 by JirkaRybka: remove improper t() use in update code (update goes all in English, but there were some mistakes), and add messages to updates where there was no return value otherwise, so users know what happens in each update
2007-12-19 10:34:51 +00:00
b339b47fc0
- Patch #199510 by Pancho: fixed form API conversions.
2007-12-18 22:16:55 +00:00
c8b1ddf26a
- Patch #164532 by catch, pwolanin, David Strauss, et al.: improve table indicies for common queries.
2007-12-18 12:59:22 +00:00
191beee5fa
#194310 follow up by chx and myself: only load comment module when we can actually do it, and when we need it in comment.install
2007-12-17 16:26:12 +00:00
dfe1225147
#194310 by chx, catch, KarenS: run updates for disabled but previously installed modules, if they are compatible with the current system
2007-12-17 12:23:01 +00:00
b7a2becd15
#197314 by vitezslav.smid (as GHOP 39): improve/add/update phpdoc in aggregator, comment and system modules
2007-12-16 21:01:45 +00:00
b6532a4fdb
#200069 by keith.smith: new standard for 'more information' links in module help texts, as the handbook we referred to before was renamed
2007-12-14 18:08:50 +00:00
c6d841c096
#197297 by DanW (as GHOP 17), and keith.smith: clean up lots of help texts, update to drag and drop functionality, drupal.module removal, etc
2007-12-13 09:34:40 +00:00
5622bce2d5
#198579 by webernet and hswong3i: a huge set of coding style fixes, including:
...
- whitespaces at end of lines
- indentation
- control structure usage
- whitespace in empty lines
- phpdoc comment formatting
2007-12-08 14:06:23 +00:00
d83289f857
#196667 (GHOP 45) by fberci: add '@ingroup themeable' to all themeable functions
2007-12-06 09:58:34 +00:00
259e2f5c7e
#195678 by catch: standardise on Save and Preview button terminology (for comments) and button placement for comments and nodes, so Save is always the leftmost button, and there is no guessing to find it
2007-11-29 11:54:37 +00:00
f77b60f291
#195543 by hass and yhager: CSS inherit was completely misused in RTL CSS files
2007-11-27 12:09:27 +00:00
22a4c039da
Rollback the accidentally committed #194310
2007-11-26 19:55:15 +00:00
e6a88be5d1
#193333 by quicksketch et al: taxonomy drag and drop support
2007-11-26 19:46:52 +00:00
c856eac135
#191104 by keith.smith: (usability) change occurances of node to 'post' and 'content' as appropriate
2007-11-12 19:06:33 +00:00
beb7cfa80e
- Patch #190483 by webernet et al: tiny code cleanup.
2007-11-09 07:46:10 +00:00
678773e364
#189837 by chx: remove temporary table usage from comment_enable(). Now we require MySQL 4.1 and it has constructs which make this unnecessary.
2007-11-07 15:54:49 +00:00
e9f7072edd
#186749 by Rob Loach and myself: (regression) only override comment submitter name with anonymous name, if it was not provided already
2007-11-05 14:25:58 +00:00
d1c46eadeb
#187391 by jrbeeman, catch: redirect user to proper node comment page after submitting a new comment
2007-11-04 16:11:33 +00:00
510bb1a42f
#93425 by bjaspan: remove pre-Drupal 4.6 era destination handling cruft carried over in comment module
2007-11-04 15:15:47 +00:00
91e980a271
#187881 by mooffie: fix misnamed database table names in schema documentation
2007-11-04 14:33:07 +00:00
b99aab8381
- Patch #163499 by Crell et al: split up comment module.
2007-10-31 17:50:47 +00:00
b036bef620
#185867 by hunmonk: (usability) add node title to comment overview page for easier identification
2007-10-25 10:28:05 +00:00
4e187261ab
#177497 by chx and Desbeers: revive Drupal 5's menu_set_location() functionality by introducing menu_set_item() (for consistency in function naming), thus fixing a regression in the current development code. Also fixing some misuse of menu_set_location() by using drupal_set_breadcrumb() instead.
2007-10-25 08:24:43 +00:00
b94f2716cf
#184867 by deekayen, catch and keith.smith: fix some spelling errors in our source code and messages printed
2007-10-21 18:59:02 +00:00
b64adf07c8
#182645 by scor: clean up concatenations to be in line with core coding standards
2007-10-19 10:19:03 +00:00
6417a6ade4
#55277 by catch and JirkaRybka: when flat comment view is used, order comments by cid (ie. original submission order) instead of timestamp (ie. last editing time order) to avoid comments jumping around when being edited
2007-10-16 14:22:00 +00:00
0a61aff251
#183390 by hunmonk: forms should use form_state['redirect'] for redirection, not drupal_goto() - fix this in comment_admin_overview_submit()
2007-10-15 15:57:15 +00:00
b274bf87f3
- Patch #182950 : fieldset massaging for usability.
2007-10-12 14:10:18 +00:00
09e2701892
#181088 by fajerstarter, catch and JirkaRybka: rename 'access control' to 'permissions' for usability reasons
2007-10-12 10:41:48 +00:00
8cf6fefe54
#164983 by multiple contributors: document the core database schemas
2007-10-10 11:39:35 +00:00
1a2bf588e6
#63990 by several people: fix comment submission on nodes where a form is displayed
2007-10-08 14:22:31 +00:00
ca8e9a1e18
- Patch #180432 by hunmonk, sun, et al: make comment settings per node type. This is a new feature that slipped in because it is required for the project module on drupal.org.
2007-10-07 19:25:57 +00:00
39706e3c51
- Patch #150245 by webchick, bjaspan, ralf, Arancaytar et al: move the .schema files into .install files to prevent mistakes.
2007-10-05 14:43:26 +00:00
071d4b010e
#180559 by hunmonk: do not try to display the comment addition form at th end of comments, if we are already on the page, so it is displayed anyway
2007-10-03 17:59:50 +00:00
b03af772d7
#174233 by webernet: fix notices when editing comments and also fix a moderation bug along the way
2007-09-28 17:15:04 +00:00
be091880f4
- Patch #124979 by chx: remove the auto_increment.
2007-09-26 18:31:34 +00:00
cd517f16e9
#177927 by chx: use path=/ in PHP comment settings cookie creation, so cookies set around the site are available in other 'directories'
2007-09-25 14:58:43 +00:00
21ac9f1917
#174708 by multiple contributors: update jQuery to 1.2
2007-09-12 18:29:32 +00:00
ac7637bc9b
#172773 by numerous contributors: Make the actions interface usable by mere mortals (including rename of actions.module to trigger, but keeping the actions themselfs).
...
Complete previous history of actions module:
- #148410 by jvandyk: added rewrite of the actions module!
- #155986 by Uwe: fixed typos.
- #155828 by Eaton, pwolanin and jvandyk: let actions live even if actions.module is not turned on
2007-09-11 14:50:05 +00:00
67e5859a7f
#172376 by ChrisKennedy: fix 8 E_ALL issues in comment module and fix approval queue
2007-09-06 12:21:39 +00:00
ab1715750a
- Patch #172961 by webernet: code style cleanup.
2007-09-05 08:42:02 +00:00
2db2c039fb
- Patch #172950 by webernet: code style fixes.
2007-09-04 21:10:45 +00:00
e310d9e4a4
#6162 by various people: actually point new anchors to the page the first new comment is displayed (in a multipage comment view)
2007-09-02 14:56:18 +00:00
c07305d060
#172149 by dvessel: add semicolons, so the JS aggregator works
2007-09-01 07:08:11 +00:00
00181ecb39
- Removing whitespace.
2007-08-30 19:54:22 +00:00
4e0071fb8a
#111127 rollback by chx, slightly extended: roll back node_load cache, it needs more thought and discussion, so postponed until at least Drupal 7
2007-08-30 15:31:46 +00:00
d8b17c9f19
#156475 by Christoph C. Cemper and greggles: actually call the publish op on hook_comment when a comment is first (automatically) published
2007-08-29 17:01:33 +00:00
5e73b66f3a
- Patch #168028 by dvessler, merlinofchaos, pwolanin et al: both theme functions and templates may need include files. Flush your caches.
2007-08-26 07:46:11 +00:00
801756e7e6
#111127 by chx: cache node_load(), so heavy operations loading data from external sources and only invoked once (note that you should do everything dynamic in the view op, not the load op)
2007-08-25 09:25:49 +00:00
c17499b6fe
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement. (Correct version this time.)
2007-08-12 16:12:00 +00:00
b134b023e1
- Patch #163191 by hswong3i: removed db_num_rows() for compatibility with Oracle and DB2. Also a performance improvement.
2007-08-12 15:55:36 +00:00
a5fcb369fb
- Patch #166205 by hswong3i: improved database compatibility of db_result(). Makes it work with DB2, Oracle, etc.
2007-08-11 14:14:46 +00:00
f23c24c8a3
#164935 by Ralf Stamm: standardize CVS Id tags in files:
...
- always include CVS Id tags in all files
- add a new line after the CVS Id, if more code or phpdoc follows in the same code block
- fix bogus Id tags previously added
2007-08-07 08:39:36 +00:00
d746d35a8f
- Patch #163073 by Robert Douglas: removing dead code.
2007-07-30 21:27:34 +00:00
f180790bb7
#161979 noticed by bboyjay, patch by myself: kill noticedisplayed when no comments were selected for the mass operation
2007-07-25 14:57:58 +00:00
e3fa6893c2
#124485 by Wesley Tanaka: move some remaining node.css comment styles to the actual comment.css
2007-07-24 21:33:53 +00:00
7d0cf742f7
- Patch #160589 by dvessel: tpl-ify the comment module's theme functions.
2007-07-20 08:51:13 +00:00
0ddff5ee26
- Patch #160491 by dvessel: fixed E_NOTICE warnings.
2007-07-20 08:39:00 +00:00
08c059ec77
- Rollback of patch #147947 : lacks proper upgrade path.
2007-07-15 10:09:21 +00:00
a771c6c45a
- Patch #57106 by Steven et al: future timestamps break search indexing.
2007-07-15 10:05:18 +00:00
51b789c0d3
#156778 by asimmonds: revert node and comment deletions to the pre-deletion API state
2007-07-13 20:04:47 +00:00
Dries Buytaert
Gábor Hojtsy