Dries Buytaert
4ff46202cb
- Patch #157773 by pwolanin: remove node/%/% from comment_menu.
2007-07-09 17:05:49 +00:00
Gábor Hojtsy
806d0a3dee
#156910 by asimmonds: fix code indentation problems introduced with new code in this development cycle; only whitespace changes
2007-07-05 08:48:58 +00:00
Gábor Hojtsy
1b503eaac9
#128165 by joshk and webchick: missing db_rewrite_sql() calls in comment queries
2007-07-04 22:24:40 +00:00
Dries Buytaert
ee701b3336
- Patch #155986 by Uwe: fixed typos.
2007-07-02 14:41:37 +00:00
Gábor Hojtsy
3409019929
#146386 by kbahey: refactor 'submitted by user - date' themeing and make it more verbose to translate
2007-07-01 23:15:41 +00:00
Dries Buytaert
e59852d336
- Rollback of patch #147723 : delete API. Talked to Steven and Gabor and we
...
unanimously agreed to rollback the deletion API. We all support the
features this patch added, yet not its actual design and implementation.
After some talk, we decided that it would be better for Drupal -- in the
long term -- not to go with a solution that isn't 100%. We also recognize
that in the short term, this patch would have been useful addition. So
let's figure out how we can implement this properly in D7.
2007-07-01 17:41:16 +00:00
Dries Buytaert
c11cb4ec24
- Patch #120360 by nedjo: enable AJAX by making all behaviours reattachable.
2007-07-01 15:37:10 +00:00
Gábor Hojtsy
9e6ef53c2c
#154064 by pwolanin: get hook_help() up to speed to menu changes, allowing router path based lookups, and also full path argument lookup with a passed argument array
2007-06-30 19:46:58 +00:00
Dries Buytaert
2348e7de6f
- Patch #148410 by jvandyk: added rewrite of the actions module!
...
This is a very important patch, but one that is merely an enabler.
Hopefully we'll see more people submitting "action patches" in the
near future.
Thanks for the hard work and persistence, John. *If* you decide
to update the Drupal Pro Development book to Drupal 6, make sure
to add a chapter on actions. ;)
2007-06-29 18:06:51 +00:00
Steven Wittens
7093495f7c
#154046 : Optimize confirm_form syntax for common usage (and fix some $form_state bugs).
2007-06-24 10:09:53 +00:00
Steven Wittens
028c8e6050
#148678 : Fix notices/warnings on invalid paths like 'node/zzz'. (chx/pwolanin/webernet)
2007-06-24 00:38:40 +00:00
Steven Wittens
38a1300df2
#147723 : Deletion API (by hunmonk). Woop woop.
2007-06-22 05:44:21 +00:00
Dries Buytaert
ae0392b2eb
- Patch #147947 by hswong3i: some files shouldn't defined as text:big for Oracle compatibility.
2007-06-15 07:15:25 +00:00
Dries Buytaert
0d5e968823
- Patch #82526 by Moshe: simplified APIs -- use form_alter now.
2007-06-15 07:10:47 +00:00
Dries Buytaert
42667a6328
- Patch #142829 by webchick and gurpartap singh: pave the path to allow comment-.tpl.php.
2007-06-11 14:56:40 +00:00
Dries Buytaert
29eb5a6284
- Patch #146910 by dww: only allow enabling modules with the same Drupal core compatibility version.
2007-06-08 05:50:58 +00:00
Dries Buytaert
27388f6655
- Patch #149176 by chx, David et al: getting rid of the sequences table, using db_last_insert_id() instead of db_next_id().
2007-06-05 12:13:23 +00:00
Dries Buytaert
2a3744c572
- Patch #149339 by Ted: removed unnecessary heavy query.
2007-06-05 09:22:22 +00:00
Dries Buytaert
e629deb94d
- Patch #146667 by Jeff Eaton: form API fixes.
2007-06-04 15:56:34 +00:00
Dries Buytaert
1fe90cba4f
- Patch #146667 by Eaton: correct builder argument ordering, eliminate redundant arguments
2007-06-04 07:22:23 +00:00
Dries Buytaert
556ef56c52
- Patch #147417 by robertDouglas: only save cookie for anonymous users.
2007-05-29 06:27:37 +00:00
Dries Buytaert
96926ca047
- Patch #146470 by Eaton et al: standardize form API3 hook parameter order.
2007-05-28 06:08:47 +00:00
Gábor Hojtsy
860947d3c8
#145737 by yhager, documentation cleaned up by myself: add support for RTL CSS overrides and default RTL CSS override files for modules
...
Note: properties, which are different in the RTL display are marked with /* LTR */ in default CSS files now,
so maintainers remember that changing them should also have an effect on RTL CSS files.
This should open the way for better RTL (right-to-left written) language (such as Arabic and Hebrew) support.
2007-05-27 17:57:48 +00:00
Dries Buytaert
4a6f5869e5
- Patch #142773 by kbahey: made Drupal work correctly when behind a reverse proxy.
2007-05-25 15:04:42 +00:00
Dries Buytaert
3cafffe63f
- Killer patch #144765 by bjaspan, frando et al: schema API 1 hits core. Oh, behave.
2007-05-25 12:46:46 +00:00
Dries Buytaert
2934a3d9bd
- Patch #144859 by dww: added optional e-mail notifications when user are approved, blocked, or deleted.
2007-05-20 12:34:48 +00:00
Dries Buytaert
b86d106e0e
- Patch #141131 by mfer: fixed UTF-8 problem.
2007-05-20 07:30:03 +00:00
Dries Buytaert
da7f952a45
- Patch #141131 by mfer: remember anonyous comment posters.
2007-05-17 21:05:38 +00:00
Dries Buytaert
d1e28d4273
- Patch #141131 by mfer: remember anonyous comment posters.
2007-05-17 20:57:19 +00:00
Dries Buytaert
ac65ff9074
- Patch #138706 by eaton, chx, webchick, yched et al: form api 3 ... yay. :)
2007-05-14 13:43:38 +00:00
Dries Buytaert
7d4f2836ba
- Patch #128082 by Goba et al: Allow localization of built-in menu items.
2007-04-30 17:03:29 +00:00
Dries Buytaert
29055d34d6
- Patch #137236 by merlinofchaos: provide a way to secure the theme variables system.
2007-04-27 07:42:54 +00:00
Gábor Hojtsy
359ace36e6
#76588 patch by alienbrain: some localization-unfriendly watchdog() calls
2007-04-24 18:23:48 +00:00
Dries Buytaert
e675979091
- Patch #134493 by douggreen: getting the Drupal coding standards right in core. Woot. Woot.
2007-04-13 08:56:59 +00:00
Dries Buytaert
083a6a274d
- Patch #134185 by Ralf Stamm: missing CVS IDs in files.
2007-04-13 07:33:24 +00:00
Dries Buytaert
b9b015ff19
- Patch #130366 by webchick and Steven: make signatures pretty.
2007-04-09 13:41:10 +00:00
Dries Buytaert
5bbbf10ba8
- Patch #130987 by merlinofchaos: added theme registry for easier themability.
2007-04-06 13:27:23 +00:00
Steven Wittens
f3cd2da113
#130991 : Custom menu items, part 1
2007-04-06 04:39:51 +00:00
Steven Wittens
a2baa44499
#130366 : Better styling for signature separator (thanks webchick).
2007-04-01 05:04:20 +00:00
Dries Buytaert
9e94bb6101
- Patch #130366 by webchick and steven: improved signature handling. Step 1 of 2.
2007-03-30 07:45:20 +00:00
Dries Buytaert
630277cc89
- Patch #110888 by Heine: fixed drupal_alter glitch().
2007-03-29 23:19:33 +00:00
Steven Wittens
f7440d4d73
#130971 : Kitchen sink (E_NOTICE compliance / Code style / Bugfix in book toc)
2007-03-27 05:13:55 +00:00
Dries Buytaert
eb6b848de6
- Patch #110888 by Eaton: unify hook _alter()
2007-03-26 00:35:59 +00:00
Dries Buytaert
69eb6a883d
- Patch #123940 by Gman: anchor to comment form is mis-labeled.
2007-03-12 13:08:02 +00:00
Dries Buytaert
273a653f56
- Patch #111830 by pwolanin: comment block sql incompatible with db_rewrite_sql.
2007-03-06 16:15:19 +00:00
Dries Buytaert
1e9c517796
- Patch #124742 by ChrisKennedy: fixed comments in CVS HEAD.
2007-03-06 16:14:04 +00:00
Dries Buytaert
b95f496bbc
- Backporting comment module validation fixes. Already went into DRUPAL-5.
2007-03-01 19:53:04 +00:00
Dries Buytaert
dc5843bd30
- Patch #111347 by Steven: refactor url() and l().
2007-02-15 11:40:19 +00:00
Dries Buytaert
a1e6728a46
- Patch #113603 by chx: first crack at re-implementing tabs.
2007-02-11 09:30:51 +00:00
Dries Buytaert
05a708fb06
- Patch #112715 by chx, webchick, asimmonds, et al: fixing E_ALL notices. Thanks.
2007-01-31 15:49:26 +00:00
Dries Buytaert
03752e35a4
- Patch #34755 by chx et al: faster menu system. HEAD is temporary broken and there is no upgrade path yet.
2007-01-24 14:48:36 +00:00
Dries Buytaert
301d377986
- Patch #107440 by webchick and add1sum: code cleanup.
2007-01-23 19:11:18 +00:00
Dries Buytaert
1ec2b45be7
- Patch #104156 by chromeyellow and Heine: avoid redundant SQL queries.
2007-01-03 11:32:38 +00:00
Dries Buytaert
dbcf525d42
- Patch #106351 by hickory: fixed comment forms.
2007-01-03 11:04:50 +00:00
Neil Drumm
36fce2f001
#18870 by zen. Only allow the new comment anchor to be output forthe first new comment.
2006-12-30 21:20:38 +00:00
Neil Drumm
8b9a3326c3
#60664 by Heine. Only check if new comments are duplicates.
2006-12-25 22:39:08 +00:00
Neil Drumm
f4ed6e1a14
#69111 by robertDouglass. Speed up the new comments block.
2006-12-19 09:02:28 +00:00
Steven Wittens
46392b264c
#92242 : Don't indent when comment view is flat.
2006-12-15 01:33:00 +00:00
Steven Wittens
17b8327efc
#102353 : More efficient query for comment.module fix
2006-12-13 22:44:54 +00:00
Steven Wittens
a043194e3f
#102353 : Fix comment tracking when comment module has been disabled.
2006-12-13 10:24:58 +00:00
Steven Wittens
a10ca909a0
#93897 : Fix comment de-indenting multiple levels at a time.
2006-12-12 09:20:17 +00:00
Steven Wittens
27db2cb8b5
#102606 : More documentation for constants (webchick)
2006-12-12 06:14:21 +00:00
Steven Wittens
fcde99a4dd
#60916 : Fix comment subject being empty when comment only contains HTML tags.
2006-12-12 06:06:41 +00:00
Steven Wittens
59fe44368f
#102783 : link to right permissions section in comment help
2006-12-12 05:39:45 +00:00
Dries Buytaert
711378019d
-Patch
2006-12-11 17:13:45 +00:00
Dries Buytaert
cbb4504574
- Patch #102026 by robert douglas: improved PHPdoc comments.
2006-12-08 16:16:30 +00:00
Dries Buytaert
eade0808a3
- Patch #102151 by robert douglass: removed unneeded 'GROUP BY' clause in thread-building code.
2006-12-08 15:32:10 +00:00
Dries Buytaert
627d426735
- Patch #100836 by webernet: make collapsed comments work again.
2006-12-06 15:44:09 +00:00
Dries Buytaert
00758e24dc
- Patch #92149 by Chris Kennedy: more sentence capitalization.
2006-12-05 17:48:03 +00:00
Dries Buytaert
46a6e08cea
- Patch #51314 by kjartan, eafarris, et al: hide the last comment block if there are no comments.
2006-12-01 16:50:36 +00:00
Neil Drumm
a2dbfc9034
#99579 by Heine. Don't placeholder the number of comments per page.
2006-11-27 02:14:33 +00:00
Neil Drumm
760e495554
#97824 by webchick. Move enclosing elements out of t().
2006-11-26 23:10:29 +00:00
Neil Drumm
8bf48bf999
#99645 by chx. Reshuffle some comments.
2006-11-26 22:35:20 +00:00
Neil Drumm
8b1e5d0505
#97231 by pwolanin. Keep the node type in a property and use it consistently.
2006-11-26 02:43:48 +00:00
Dries Buytaert
827f064deb
- Patch # #98366 by webchick and ac: simplified strings for translators.
2006-11-24 10:18:24 +00:00
Dries Buytaert
d721a4f0d9
- Patch #98365 by webchick and RobRoy: added missing t() functions.
2006-11-24 09:01:57 +00:00
Dries Buytaert
6ae6dc0d85
- Patch #87298 by webchick, neil, dww et al: show version numbers on modules page.
2006-11-21 20:55:36 +00:00
Dries Buytaert
b004f328ee
- Patch #92992 by webchick and neclimdul: clean up documentation that is superseded by the new 'by module' administration dashboard.
2006-11-21 20:14:19 +00:00
Steven Wittens
001d54f663
#84961 : Add 'select all' and range select feature to admin tables.
2006-11-21 08:16:39 +00:00
Neil Drumm
7f25862f95
#93821 by lyricnz. Fix an undefined variable.
2006-11-12 00:11:15 +00:00
Neil Drumm
337c2f9b5d
#92149 by Egon Bianchet. Fix an uncapitalized link.
2006-11-10 08:37:20 +00:00
Dries Buytaert
87f1359158
- Patch #82938 by edkwh and natrak: error in comments admin page after clicking on Update without selecting any comments.
2006-10-24 20:31:25 +00:00
Steven Wittens
36d44fbfb0
#84146 : Use 'Sentence capitalization' for menu items, page titles, form items, etc
2006-10-22 08:28:47 +00:00
Dries Buytaert
8306444494
- Patch #78399 by Eaton and chx: don't allow HTML in the title.
2006-10-18 18:00:40 +00:00
Neil Drumm
ea38bae2a7
#84443 by Shakur. Do not depend on a url argument being defined.
2006-10-17 08:45:51 +00:00
Dries Buytaert
8d74e4c132
- Patch #87995 by merlinofchaos: added missing css.
2006-10-15 19:57:06 +00:00
Dries Buytaert
7cb0c537c1
- Patch #87995 by merlinofchaos: cleaned up CSS and simplified the code.
2006-10-11 13:17:23 +00:00
Dries Buytaert
6e8a0a1602
- Patch #87755 by kjartan: anonymous comments can't save names.
2006-10-09 06:59:01 +00:00
Dries Buytaert
18b297abf8
- Patch #81740 by merlinofchaos, webchick, moshe, neclimdul et al: added package support to the modules page.
2006-10-05 15:47:57 +00:00
Dries Buytaert
cb8201c337
- Patch #83007 by edkwh: fixed multi-comment delete.
2006-09-17 19:09:34 +00:00
Neil Drumm
d48100eb88
#73584 by keve an flk. Properly check if a variable is set.
2006-09-09 00:23:11 +00:00
Dries Buytaert
6f0e54b037
- Patch #82465 by webchick: renamed variables in hooks for consistency.
2006-09-08 16:33:02 +00:00
Neil Drumm
208090eeb0
#82336 by jvandyk. Set the default input format if we don't have one.
2006-09-05 02:36:02 +00:00
Dries Buytaert
49fa25fb76
- Rollback of patch #68418 : clean up node submit hooks. Needs more thinkering.
...
Restores the old node API.
2006-08-31 21:58:36 +00:00
Dries Buytaert
c64db1da29
- Patch #80952 by earl, webchick, neclimdul et al: .info files
2006-08-31 20:22:37 +00:00
Neil Drumm
e051f5bd90
#81481 by erdemkose. Show the comment subject on delete confirmation.
2006-08-31 08:55:45 +00:00
Dries Buytaert
5524604a95
- Patch #68418 by Moshe et al: clean up node submit hooks.
2006-08-29 18:43:26 +00:00
Neil Drumm
bceaf8f0da
#80574 Eaton and chx. Replace $_POST['edit'] with $_POST.
2006-08-29 09:12:03 +00:00
Dries Buytaert
f8534504b3
- Patch #80895 by webchick et al: make it easier to disable form elements.
2006-08-27 12:54:01 +00:00
Dries Buytaert
c4f1e4ba13
- Patch #76444 by chx, moshe, eaton, angie et al: make it possible to control access to form elements.
2006-08-22 11:13:04 +00:00
Dries Buytaert
e14c3aa6c0
- Patch #79498 by Eaton: fixed editing comments and nodes.
2006-08-19 21:40:58 +00:00
Dries Buytaert
7de41539df
- Patch #77919 by chx, eaton, moshe, et al: enable programmaticaly submitted forms via the pull model.
2006-08-18 18:58:47 +00:00
Steven Wittens
81938a3cdc
#76802 : Introduce placeholder magic into t()
...
See: http://drupal.org/node/64279#t-placeholders
2006-08-18 12:17:00 +00:00
Dries Buytaert
ce85b7c7f8
- Patch #74326 by Eaton, Royboy, chx, et al: building $node->body with arrays like FAPI for viewing.
...
Once again, we're paving the path for CCK in core ... :)
2006-08-10 15:42:33 +00:00
Dries Buytaert
d2eb90c45e
- Patch #77896 by killes: don't clear cache inside loop.
2006-08-10 05:47:37 +00:00
Dries Buytaert
729fa6c11b
- Patch #77422 by timcn: corrected various paths in the documentation.
2006-08-07 15:04:16 +00:00
Neil Drumm
129c8eb18c
#62340 by chx, webchick, Jaza, Eaton, mathieu, and myself. Configurable node types.
2006-08-06 23:00:42 +00:00
Neil Drumm
cd430165d7
#73884 by RobRoy, various code cleanup.
2006-08-05 00:26:36 +00:00
Dries Buytaert
b138793b68
- Patch #72079 by Earl et al: give Drupal an overall administration page ... :-)
2006-07-31 11:25:55 +00:00
Neil Drumm
c11c1c2800
#73605 by RobRoy, make hook_link() implementations consistent with documentation.
2006-07-19 07:15:35 +00:00
Neil Drumm
e616f2b580
#73748 by RobRoy, add a themeable wrapper for comments
2006-07-19 06:19:17 +00:00
Steven Wittens
dafb146b27
#74070 : urlencode to drupal_urlencode()
2006-07-18 10:44:45 +00:00
Dries Buytaert
e4e416d1f7
- Patch #73351 by Kris, Goba et al: only display comment link in RSS, if applicable.
2006-07-13 12:29:15 +00:00
Dries Buytaert
58752cfaa2
- Patch #72284 by me:
...
+ reorganized ?q=admin/settings
+ deprecated the _settings hook
2006-07-10 19:27:52 +00:00
Neil Drumm
84bad29516
#72865 by AjK, use more standard is_numeric() instead of ctype_digit().
2006-07-10 18:00:37 +00:00
Neil Drumm
59aa2ae8e8
#71925 by Steven, remove # prefix from link array keys.
2006-07-04 08:59:05 +00:00
Neil Drumm
d048681f03
#63990 by Heine and chx, allow commenting on nodes containing forms
2006-07-02 20:24:17 +00:00
Neil Drumm
2a89ab89f9
#67745 by AjK, handle deleting non-existant comments better.
2006-07-02 02:59:21 +00:00
Neil Drumm
4f078eb274
#51556 by greggles, Fixing an inaccurate comment.
2006-05-20 08:14:09 +00:00
Dries Buytaert
1b291a2917
- Patch #18260 by Ber, m3averck et al: allow overriding of links returned by modules
2006-05-18 14:58:57 +00:00
Neil Drumm
9cff02e91b
#61802 by Zen, Double spaced sentences clean up
2006-05-07 00:08:36 +00:00
Neil Drumm
79598dc723
#61678 by Zen, Comment body validation should rely on fapi
2006-05-04 09:34:56 +00:00
Steven Wittens
546f5930a4
#58953 : Flat collapsed mode and newest first order broken
2006-04-27 22:03:20 +00:00
Dries Buytaert
326f49b646
- Patch #58953 by tenrapid: critical bugfix: Flat Collapsed mode and Newest First order broken.
2006-04-24 18:42:53 +00:00
Gerhard Killesreiter
297ed741f8
#58221 , Turn #after_build into a functions array in order to make validation of date fields possible. Patch by yched, tenrapid
...
Also makes forms API more consistent (see #pre_render)
2006-04-20 07:11:37 +00:00
Dries Buytaert
0484fcd1ed
- Patch #58921 by markus_petrux: critical bug: database error when rendering comments in PostgreSQL.
...
Tested with MySQL only!
2006-04-17 20:45:00 +00:00
Steven Wittens
8b04c7f0db
#51002 : Admins could not see unpublished comments (plus minor usability enhancements for previewing/unpublished)
2006-04-15 04:07:18 +00:00
Gerhard Killesreiter
d6a164c400
#5371 , drupal_get_destination, pager and tablesort array handling, patch by Steven
2006-04-13 08:25:27 +00:00
Gerhard Killesreiter
70aae83c8e
#58166 , fixes for typos, patch by Uwe Herrmann
2006-04-11 11:33:15 +00:00
Steven Wittens
4c3fe45fe9
#56942 : Comment cids should belong to the associated nid
2006-04-04 07:07:45 +00:00
Steven Wittens
57be840338
#57133 : admin/comment needs to remember sort order in page
2006-04-04 01:26:05 +00:00
Steven Wittens
b3cb4f0d9b
#56346 : XHTML validation error due to comment.module links
2006-03-30 17:23:29 +00:00
Gerhard Killesreiter
a76ee6c9ed
#34132 , remove remnants of nodeapi('fields'), patch by myself
2006-03-28 06:12:15 +00:00
Steven Wittens
d6f15f3051
- #55666 : Comment reply form anchor fixes
2006-03-27 08:08:31 +00:00
Gerhard Killesreiter
5885925b0d
#53348 , Handling of deleted/blocked user accounts, patch by jreyero and Zen
2006-03-26 19:31:00 +00:00
Gerhard Killesreiter
0fad496ca0
#55622 , Security threat -- any user can delete comments, patch by robertgarrigos
2006-03-24 11:38:00 +00:00
Gerhard Killesreiter
63b3fea2b3
#54687 , Typo with page redirection upon login, patch by matt westgate
2006-03-20 16:40:06 +00:00
Dries Buytaert
f51bc544f2
- Patch #51142 by markus: hook_comment not called for all update operations.
2006-03-06 20:52:55 +00:00
Dries Buytaert
c54a0f575f
- Patch #51543 by wtanaka: clicking on 'add new comment' takes you to the wrong place.
2006-03-06 18:09:17 +00:00
Dries Buytaert
5de716f100
- Patch #50835 by markus: print message when replying to non-existing comment.
2006-03-04 18:01:54 +00:00
Gerhard Killesreiter
784202418f
#50771 , Wrong user name in admin/comment, patach by Markus Petrux
2006-02-27 14:54:24 +00:00
Dries Buytaert
66576708a0
- Patch #51347 by eafarris: fixed typo: coment -> comment.
2006-02-26 19:52:09 +00:00
Dries Buytaert
3489651659
- Patch #46690 by Zen: 'user comments' -> 'comment settings'.
2006-02-26 19:47:55 +00:00
Dries Buytaert
c94a2dabb0
- Patch #50755 by markus: = -> ==.
2006-02-22 19:02:58 +00:00
Dries Buytaert
cb05945caf
- Patch #47699 by wtanaka: performance improvement.
2006-02-22 10:05:06 +00:00
Dries Buytaert
3603fe1bd8
- Patch #49912 : www.drupal.org -> drupal.org. (Today's critical bugfix #5.)
2006-02-21 18:46:54 +00:00
Dries Buytaert
7489c87476
- Patch #43572 by Tobias: don't accept spaces.
2006-02-14 19:17:00 +00:00
Dries Buytaert
583d5a4ee9
- Patch #48622 by adrian: remove drupal_goto from _submit functions.
2006-02-10 05:25:57 +00:00
Steven Wittens
1819de963f
- #48518 : Editing own comment broken under postgresl
2006-02-09 09:09:03 +00:00
Steven Wittens
c9a19e3084
- #48239 : Comment thread coding inefficient
2006-02-09 08:33:36 +00:00
Dries Buytaert
91e152b8b8
- Patch #47705 by DriesK: comment moderation/approval wasn't working due to a bug with its forms.
2006-02-04 09:54:16 +00:00
Dries Buytaert
baa2ecc81c
- Patch #47045 by Cvbge: fixed problem with deleting comments.
2006-02-01 14:04:50 +00:00
Dries Buytaert
a6dac9d2ab
- Modified patch #46227 by chx: comment token is broken.
2006-01-31 15:26:39 +00:00
Dries Buytaert
20154df528
- Modified patch #45723 by wtanaka: creating a comment, editing a comment, or anything that validates a comment fails on PHP5.
2006-01-26 08:48:57 +00:00
Dries Buytaert
5d43619ca7
- Patch #40752 by moshe/wtanaka: login and regsiter links on each comment don't redirect back to the topic.
2006-01-26 08:27:58 +00:00
Dries Buytaert
b8832d76a0
- Patch #40753 by wtanaka/killes: #comment-form has disappeared from comment.module
2006-01-25 08:54:40 +00:00
Dries Buytaert
b6b98bb60d
- Patch #44101 by Cvbge: deleting a comment creates incorrect entry in node_comment_statistics.
2006-01-22 07:26:33 +00:00
Dries Buytaert
4da1540a9f
- Patch #45380 by Neil: usability improvement: disable anonymous commenting options when anonymous people can't comment.
2006-01-20 09:33:03 +00:00
Dries Buytaert
8c02d4ec93
- Patch #45530 by Morbus: filter_form shouldn't default to #weight 0
...
When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
# Assign a decimal placeholder weight to preserve original array order
if (!isset($form[$key]['#weight'])) {
$form[$key]['#weight'] = $count/1000;
}
The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
Consider the following pseudo example:
$form['game_title'] = array(
'#type' => 'textfield',
...
);
$form['game_description'] = array(
'#type' => 'textarea',
...
);
$form['game_format'] = filter_form(variable_get('game_format', NULL));
return $form;
Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
2006-01-20 09:04:34 +00:00
Dries Buytaert
e84a98a22b
- Patch #45349 by Morbus Iff: input filters aren't sorting correctly infForms API.
2006-01-19 08:54:41 +00:00
Dries Buytaert
47dd0142e6
- Patch #43325 by chx/drumm/merlinofchaos: critical bugfix: made editing comments work.
2006-01-18 15:09:39 +00:00
Dries Buytaert
cb45cf58fb
- Patch #40755 by wtanaka: make the comment block themable.
2006-01-17 18:02:23 +00:00
Dries Buytaert
226a26a556
- Removed reference to comment moderation.
2006-01-10 19:41:15 +00:00
Steven Wittens
49e5e1cd47
- #43097 : restore admin/comment tablesort
2006-01-08 00:29:37 +00:00
Steven Wittens
030fd1798a
- Comment bug: anchor links should be specified using $fragment in url() and drupal_goto().
2006-01-06 01:14:17 +00:00
Dries Buytaert
24899dba42
- Patch #40563 by chx, merlingofchaos, et al: bug fix: fixed the default comment settings on node sumbission forms.
2006-01-05 14:35:55 +00:00
Dries Buytaert
8d7ff5aea2
- Patch #39743 by merlinofchaos: critical bugfix: fixed comment ordering setting.
2006-01-05 10:53:47 +00:00
Dries Buytaert
72ed68d48b
- Patch #42971 by markus_petrux: input format not correctly shown when editing a comment.
2006-01-03 23:04:23 +00:00
Dries Buytaert
ea2d791095
- Patch 41169 by Chris: got rid of expensvie object 2 array casts.
2005-12-31 10:48:56 +00:00
Dries Buytaert
6164074655
- Patch #38999 by saerdna: There's no need that users with the "administer comments" role has to go via admin/comments to delete comments. this patch simply adds the delete link on each comment if you have administer comments role. "access administration pages" not needed; because if they not have it they can still delete from admin/comments.
2005-12-19 10:12:52 +00:00
Dries Buytaert
21a9442bbb
- Patch #41081 by billturner: fixed problem with the comment settings form.
2005-12-15 16:31:01 +00:00
Dries Buytaert
922a46d281
- Patch #34920 by Morbus/webchick/tangent: fixed order of form fields.
2005-12-15 16:24:40 +00:00
Dries Buytaert
5accfa08f5
- Patch #41133 by DriesK: as of PHP 5.1.0, strtotime() returns FALSE on failure instead of -1.
...
Changed code to be compatible with all versions.
2005-12-15 16:02:50 +00:00
Dries Buytaert
764f1177ef
- Patch #40631 by Chris Johnson: is_array() slower than isset() or empty().
2005-12-14 20:10:45 +00:00
Dries Buytaert
3ae534a64e
- Patch #28595 by Cvbge: fixed problems with bulk comment operations.
2005-12-08 09:11:32 +00:00
Dries Buytaert
e019ce5107
- Patch #28595 by Jeremy: added support for bulk operations on comments.
2005-12-07 05:35:02 +00:00
Dries Buytaert
28fdb3975e
- Patch #39778 by chx: obliterate nodeapi op form in favor of the forms API's way of doing things. Tested with help from webchick.
2005-12-05 09:11:33 +00:00
Dries Buytaert
80e02e6e73
- Patch #36434 by assimonds: fixed problem with editing signatures.
2005-12-03 19:39:15 +00:00
Dries Buytaert
26bd449860
- Patch #39576 by chx: rename '_execute' to '_submit' and '#execute' to '#submit'.
2005-12-02 15:21:01 +00:00
Dries Buytaert
8784a7d13a
- Patch #39024 by Zen: comments that should be in the moderation queue get published.
2005-11-27 11:45:03 +00:00
Dries Buytaert
c647b39c2c
- Patch #37798 by Neil: fixed problem with node settings.
2005-11-27 11:11:46 +00:00
Dries Buytaert
247e012c35
- Patch #39013 by drumm: more logical naming of themeable functions
2005-11-27 11:07:02 +00:00
Dries Buytaert
b1b1e2045f
- Patch #37798 by Neil: allow non-workflow form elements on the node type settings page.
2005-11-25 10:11:59 +00:00
Dries Buytaert
bd2d91807e
- Patch #38575 by Neil: fixed infinite loop in comment.module.
2005-11-23 08:23:45 +00:00
Dries Buytaert
62e5c58777
- Patch #38491 by Neil: refactor comment viewing controls to _execute model.
2005-11-22 15:48:46 +00:00
Dries Buytaert
9f8fcab8db
- Patch #35726 by asimmonds: post_process -> build_after
2005-11-22 15:13:15 +00:00
Dries Buytaert
28f973a986
- Patch #35726 by asimmonds/chx: converted the comment module to the forms API's _execute model.
2005-11-21 08:32:31 +00:00
Dries Buytaert
e900d28640
- Patch #34295 by assimonds: added missing defines to comment.module. Improves
...
readability of the code.
2005-11-15 07:29:47 +00:00
Dries Buytaert
d5d0149abe
- Patch #34295 by DrupalJapan and chx:
...
+ Fixed problem with configuration of comment display options.
+ Introduced defines for the various comment settings.
2005-11-13 09:05:38 +00:00
Steven Wittens
21bed11e66
- Add missing url()s around form actions (these would break without clean URLs)
2005-11-13 02:32:18 +00:00
Dries Buytaert
aeed4cd8e4
- Patch #35644 by webchick: forms API simplificiations.
2005-11-12 11:26:16 +00:00
Dries Buytaert
3d13a38502
- Patch #36727 by Goba: fixed incorrect use of drupal_goto().
2005-11-08 20:57:41 +00:00
Dries Buytaert
a8b218827a
- Patch #26139 by webchick / Kieran / documentation team: improved admin help of core modules! /
2005-11-01 10:17:34 +00:00
Steven Wittens
3fad92fc59
- #34645 : Make $links in theme_comment consistent with theme_node (Stefan)
2005-10-20 09:27:36 +00:00
Steven Wittens
e83b00d526
- Typo
2005-10-20 08:56:34 +00:00
Steven Wittens
8164ec2f49
- Code style
2005-10-20 08:53:59 +00:00
Dries Buytaert
75fe6b6c0a
- Patch #33752 by chx, adrian, et al: another batch of form API changes/fixes.
2005-10-11 19:44:35 +00:00
Dries Buytaert
7863be5e82
- Patch #33433 by chx: fixed a number of form API problems.
...
* Default form value
* Leftover debug function in form.inc
* PHP5 issue with comment date (I got this patch from another issue)
* Validation error fix (was calling legacy form validate)
* Lots o' warnings on comment preview
* Filter tips plus argument (gremlins. I swear this was not there.)
* Message to clear what's going on with system settings
* Non-freetagging taxonomies fixed
2005-10-08 12:21:47 +00:00
Dries Buytaert
7e1527ee61
- Patch #29465 : new form API by Adrian et al.
...
TODO:
+ The contact.module was broken; a new patch for contact.module is needed.
+ Documentation is needed.
+ The most important modules need to be updated ASAP.
2005-10-07 06:11:12 +00:00
Dries Buytaert
0200ccf4da
- Patch by chx: fixed validation check.
2005-10-01 08:43:51 +00:00