#195543 by hass and yhager: CSS inherit was completely misused in RTL CSS files

2007-11-27 12:09:27 +00:00 · 2007-11-27 12:09:27 +00:00 · f77b60f291
parent 61f04c91c9
commit f77b60f291
17 changed files with 50 additions and 47 deletions
--- a/modules/color/color-rtl.css
+++ b/modules/color/color-rtl.css
@ -1,13 +1,13 @@
 /* $Id$ */

 #placeholder {
-  right: inherit;
  left: 0;
+  right: auto;
 }

 /* Palette */
 .color-form .form-item {
-  padding-left: inherit;
+  padding-left: 0;
  padding-right: 1em;
 }
 .color-form label {
@ -18,7 +18,7 @@
  float: right;
 }
 .color-form .form-text {
-  margin-right: inherit;
+  margin-right: 0;
  margin-left: 5px;
 }

@ -26,7 +26,7 @@
  float: right;
 }
 #palette .down, #palette .up, #palette .both {
-  background-position: 0 0;
+  background: url(images/hook-rtl.png) no-repeat 0 0;
 }
 #palette .up {
  background-position: 0 -27px;
@ -37,7 +37,6 @@

 #palette .lock {
  float: right;
-  left: inherit;
  right: -10px;
 }
 html.js #preview {
--- a/modules/color/images/hook-rtl.png
+++ b/modules/color/images/hook-rtl.png
--- a/modules/comment/comment-rtl.css
+++ b/modules/comment/comment-rtl.css
@ -1,6 +1,6 @@
 /* $Id$ */

 .indented {
-  margin-left: inherit;
+  margin-left: 0;
  margin-right: 25px;
 }
--- a/modules/dblog/dblog-rtl.css
+++ b/modules/dblog/dblog-rtl.css
@ -2,6 +2,6 @@

 #dblog-filter-form .form-item {
  float: right;
-  padding-right: inherit;
+  padding-right: 0;
  padding-left: .8em;
 }
--- a/modules/forum/forum-rtl.css
+++ b/modules/forum/forum-rtl.css
@ -1,7 +1,7 @@
 /* $Id$ */

 #forum tr td.forum {
-  padding-left: inherit;
+  padding-left: 0.5em;
  padding-right: 25px;
  background-position: 98% 2px;
 }
--- a/modules/help/help-rtl.css
+++ b/modules/help/help-rtl.css
@ -2,10 +2,10 @@

 .help-items {
  float: right;
-  padding-right: inherit;
+  padding-right: 0;
  padding-left: 3%;
 }
 .help-items-last {
-  padding-right: inherit;
+  padding-right: 0;
  padding-left: 0;
 }
--- a/modules/node/node-rtl.css
+++ b/modules/node/node-rtl.css
@ -2,7 +2,7 @@

 #node-admin-buttons {
  float: right;
-  margin-left: inherit;
+  margin-left: 0;
  margin-right: 0.5em;
  clear: left;
 }
--- a/modules/search/search-rtl.css
+++ b/modules/search/search-rtl.css
@ -2,7 +2,7 @@

 .search-advanced .criterion {
  float: right;
-  margin-right: inherit;
+  margin-right: 0;
  margin-left: 2em;
 }
 .search-advanced .action {
--- a/modules/system/admin-rtl.css
+++ b/modules/system/admin-rtl.css
@ -6,9 +6,9 @@ div.admin-panel .body {

 div.admin .expert-link {
  text-align: left;
-  margin-right: inherit;
+  margin-right: 0;
  margin-left: 1em;
-  padding-right: inherit;
+  padding-right: 0;
  padding-left: 4px;
 }

@ -31,7 +31,7 @@ table.screenshot {
  float: right;
 }
 .date-container .custom-container {
-  margin-left: inherit;
+  margin-left: 0;
  margin-right: 15px;
 }

--- a/modules/system/defaults-rtl.css
+++ b/modules/system/defaults-rtl.css
@ -2,6 +2,6 @@

 th {
  text-align: right;
-  padding-right: inherit;
+  padding-right: 0;
  padding-left: 1em;
 }
--- a/modules/system/system-rtl.css
+++ b/modules/system/system-rtl.css
@ -1,8 +1,14 @@
 /* $Id$ */

+thead th {
+  text-align: right; 
+  padding-left: 1em; 
+  padding-right: 0.5em;
+}
+
 .item-list .icon {
  float: left;
-  padding-left: inherit;
+  padding-left: 0;
  padding-right: 0.25em;
  clear: left;
 }
@ -30,13 +36,13 @@ ul.primary {
  padding: 0 1em 0 0;
 }
 ul.primary li a {
-  margin-right: inherit;
+  margin-right: 5px;
  margin-left: 0.5em;
 }
 ul.secondary li {
  display: inline;
  padding: 0 1em;
-  border-right: inherit;
+  border-right: none;
  border-left: 1px solid #ccc;
 }
 html.js input.form-autocomplete {
@ -47,7 +53,7 @@ html.js input.throbbing {
 }

 html.js fieldset.collapsible legend a {
-  padding-left: inherit;
+  padding-left: 0;
  padding-right: 15px;
  background-position: 98% 75%;
 }
@ -58,7 +64,7 @@ html.js fieldset.collapsed legend a {

 div.teaser-button-wrapper {
  float: left;
-  padding-right: inherit;
+  padding-right: 0;
  padding-left: 5%;
 }
 .teaser-checkbox div.form-item {
@ -79,9 +85,9 @@ div.teaser-button-wrapper {
 }
 input.password-field {
  margin-left: 10px;
-  margin-right: inherit;
+  margin-right: 0;
 }
 input.password-confirm {
  margin-left: 10px;
-  margin-right: inherit;
+  margin-right: 0;
 }
--- a/modules/user/user-rtl.css
+++ b/modules/user/user-rtl.css
@ -1,17 +1,17 @@
 /* $Id$ */

 #permissions td.permission {
-  padding-left: inherit;
+  padding-left: 0;
  padding-right: 1.5em;
 }
 #access-rules .access-type, #access-rules .rule-type {
-  margin-right: inherit;
+  margin-right: 0;
  margin-left: 1em;
  float: right;
 }
 #user-admin-buttons {
  float: right;
-  margin-left: inherit;
+  margin-left: 0;
  margin-right: 0.5em;
  clear: left;
 }
--- a/themes/bluemarine/style-rtl.css
+++ b/themes/bluemarine/style-rtl.css
@ -17,7 +17,7 @@ body {
 }
 ul.links li {
  border-right: 1px solid #9cf;
-  border-left: inherit;
+  border-left: none;
 }
 .block, .box {
  padding: 0 1.5em 0 0;
--- a/themes/chameleon/marvin/style-rtl.css
+++ b/themes/chameleon/marvin/style-rtl.css
@ -10,7 +10,7 @@ p {
 }

 ul.links li {
-  border-left: inherit;
+  border-left: none;
  border-right: 1px solid #888;
 }

@ -25,7 +25,7 @@ ul.links li {
  float: left;
 }
 .node .content {
-  padding-left: inherit;
+  padding-left: 0;
  padding-right: 1em;
 }
 .node .links {
--- a/themes/chameleon/style-rtl.css
+++ b/themes/chameleon/style-rtl.css
@ -8,20 +8,20 @@ body {
 * Welcome to design by tables..
 */
 #sidebar-left {
-  border-right: inherit;
+  border-right: none;
  border-left: 1px solid gray;
 }
 #sidebar-right {
-  border-left: inherit;
+  border-left: none;
  border-right: 1px solid gray;
 }

 ul.links li {
-  border-left: inherit;
+  border-left: none;
  border-right: 1px solid #000;
 }
 ul.links li.first {
-  border-left: inherit;
+  border-left: none;
  border-right: none;
 }
 div.links {
--- a/themes/garland/style-rtl.css
+++ b/themes/garland/style-rtl.css
@ -20,7 +20,7 @@ ul.menu, .item-list ul {
 }

 ul.menu ul, .item-list ul ul {
-  margin-left: inherit;
+  margin-left: 0;
  margin-right: 0em;
 }

@ -34,7 +34,7 @@ ul li, ul.menu li, .item-list ul li, li.leaf {
 }

 ol li {
-  margin-left: inherit;
+  margin-left: 0;
  margin-right: 2em;
 }

@ -51,7 +51,7 @@ ul.inline li {
 }

 ol.task-list {
-  margin-left: inherit;
+  margin-left: 0;
  margin-right: 0;
 }

@ -68,7 +68,7 @@ ol.task-list li.done {
 }

 ol.task-list li.active {
-  margin-right: inherit;
+  margin-right: 0;
  margin-left: 1em;
 }

@ -96,10 +96,9 @@ dl dd {
 }

 #wrapper #container #header h1 img {
-  padding-right: inherit;
+  padding-right: 0;
+  padding-left: 20px;
  float: right;
-  padding-right: inherit;
-  padding-left : 20px;
 }

 #sidebar-left .block-region {
@ -118,7 +117,7 @@ dl dd {
 #wrapper #container .breadcrumb {
  position: absolute;
  top: 15px;
-  left: inherit;
+  left: 0;
  right: 35px;
  z-index: 3;
 }
@ -139,7 +138,6 @@ ul.primary-links li {
 * Secondary navigation
 */
 ul.secondary-links {
-  padding: 20px 0 0;
  float: left;
  clear: left;
 }
@ -186,7 +184,7 @@ ul.links li, ul.inline li {
 }

 .picture, .comment .submitted {
-  padding-left: inherit;
+  padding-left: 0;
  float: left;
  clear: left;
  padding-right: 1em;
@ -201,12 +199,12 @@ ul.links li, ul.inline li {
 }

 .indented {
-  margin-left: 0; /* an should be inherit, but force left margin to be 0  */
+  margin-left: 0;
  margin-right: 25px;
 }

 html.js fieldset.collapsible legend a {
-  padding-left: inherit;
+  padding-left: 0;
  padding-right: 2em;
  background: url("images/menu-expanded.gif") no-repeat 100% 50%;
 }
@ -220,7 +218,7 @@ html.js fieldset.collapsed legend a {
 */
 #block-node-0 h2 {
  float: right;
-  padding-right: inherit;
+  padding-right: 0;
  padding-left: 20px;
 }

--- a/themes/garland/style.css
+++ b/themes/garland/style.css
@ -577,7 +577,7 @@ ul.primary-links li a:hover, ul.primary-links li a.active {
 */
 ul.secondary-links {
  margin: 0;
-  padding: 18px 0 0; /* LTR */
+  padding: 18px 0 0;
  float: right; /* LTR */
  clear: right; /* LTR */
  position: relative;