8e28e0a32b
Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326
2020-06-26 14:15:09 +05:30
830ac1cc91
Fixed following SonarQube issues:
...
1. Method/Field names should comply with a naming convention.
2. Conditionals should start on new lines
2020-06-26 13:32:45 +05:30
5206dafb35
Fixed code smells having rule 'Rename class name to match the regular expression'.
2020-06-26 13:23:23 +05:30
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
6a63279396
Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions.
2020-06-26 12:28:36 +05:30
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
db9d684524
Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube.
2020-06-24 16:08:14 +05:30
15c621b1d8
Fixed following SonarQube issues:
...
1) TypeError can be thrown as <variable_name> might be null or undefined here.
2) Unexpected duplicate "white-space".
3) Unexpected missing generic font family.
4) Unexpected shorthand "padding" after "padding-left".
2020-06-24 15:57:01 +05:30
cdf1c7a2a6
Fixed parallel test execution failure by handling slowness when multiple sessions are logged in concurrently.
2020-06-23 18:43:54 +05:30
d265ed9729
Fixed an issue while creating RLS Policy with the name having space. Fixes #5620
2020-06-23 14:28:21 +05:30
c064eb0795
Fix an issue where RLS Policy dialog help is not working.
2020-06-23 14:13:08 +05:30
caebdcfa91
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591
2020-06-22 17:09:10 +05:30
6012f49919
Added policy event 'ALL' in events drop-down list.
2020-06-22 17:09:10 +05:30
34fbe756e8
1) Fixes parallel test execution failures.
...
2) Added capability to pass browser-name via command line for parallel execution.
2020-06-22 13:05:13 +05:30
daad16ea93
Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube.
2020-06-22 12:58:48 +05:30
6620f9263d
Fixed issues reported by SonarQube with tag 'bad-practice'.
2020-06-22 12:18:59 +05:30
9e40995ab0
Update Japanese translation.
2020-06-22 11:58:15 +05:30
ecdd95d15a
Update Italian translation.
2020-06-22 11:55:32 +05:30
d6b22f1f4c
Fixed an issue where the search object is unable to locate inherited tables and constraint filters are not working. Fixes #5492
2020-06-22 11:53:00 +05:30
7ce7808093
Update message catalogs.
2020-06-19 18:01:32 +05:30
bc24e3643f
More code cleanup for SonarQube.
2020-06-18 16:20:34 +01:00
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
905be1d894
Replace if-then-else statement by a single return statement, issue reported by SonarQube.
2020-06-18 15:51:01 +05:30
a278e8b1e6
Fixed the master password issue, introduced in the last commit.
2020-06-18 15:38:38 +05:30
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
df05efd7d9
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation.
2020-06-17 17:15:09 +05:30
7c12ade161
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-17 17:08:23 +05:30
cb268075c2
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468
...
2) Added server group name while selecting servers in schema diff. Fixes #5500
3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584
2020-06-17 16:27:51 +05:30
d43518cb3c
Fixed following issues reported by SonarQube:
...
1) Replace this if-then-else statement by a single return statement. (clumsy)
2) 'switch' statements should have at least 3 'case' clauses. (bad practice)
2020-06-16 15:00:51 +05:30
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
2ae5c0ec4f
Fixed an issue where select all checkbox only selects the first 50 tables. Fixes #4226
2020-06-16 11:05:10 +05:30
697f4aec95
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-16 10:47:40 +05:30
023a1f222f
Remove duplicate properties in CSS and few js standard fixes reported by SonarQube.
2020-06-15 17:15:15 +05:30
a21e6448ce
Fixed RESQL test cases, regression of RLS policy.
2020-06-15 17:10:25 +05:30
eb1b17b636
Fix 'expressions evaluated to true/false always' issue reported by SonarQube.
2020-06-15 16:50:07 +05:30
38cd3327f3
Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592
2020-06-15 16:50:07 +05:30
8ab358ccec
Fix following issues reported by SonarQube:
...
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
2020-06-15 16:50:07 +05:30
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
18277543b6
Added support of Row Security Policies. Fixes #5516
2020-06-15 15:44:59 +05:30
8c20f0c0d2
Some clumsy coding related fixes reported by SonarQube.
2020-06-12 15:24:17 +05:30
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
82c4a4a03e
Improve code coverage and API test cases for Collations. Fixes #5325
2020-06-11 11:12:41 +05:30
21efe6f902
Remove blank line at EOF.
2020-06-10 17:03:08 +01:00
5c60dcd501
Remove blank line at EOF.
2020-06-10 17:02:39 +01:00
85e89c869a
Cleanup some code smells identified by SonarQube.
2020-06-10 16:42:59 +01:00
ac4b5ab7fa
1) Correct the typo 'pythonw.exe' should be 'python.exe' for Windows if 'pythonw.exe' not found.
...
2) Added logging to identify the interpreter command for Windows.
2020-06-09 19:05:20 +05:30
eb971a0320
Update Codemirror version to the latest which allows us to set screen reader labels on Codemirror editor.
...
refs #5197
2020-06-08 12:26:12 +05:30
92d9c41da7
Fixed connection and version number detection issue when the database server is upgraded. Fixes #5507
2020-06-04 18:18:11 +05:30
726ecd79e6
Fixed import statements.
...
refs #3669
2020-06-03 12:49:05 +05:30
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
a1a232a1f1
The 'pwd' module is not available on Windows, so replacing it with the 'getpass' module.
...
refs #5576
2020-06-02 14:09:44 +05:30
c932213abd
Disabled the Stop process button after clicking it and added a message 'Terminating the process...' to notify the user. Fixes #3787
2020-06-02 11:23:52 +05:30
a0c19252df
Improve error messaging if the storage and log directories cannot be created. Fixes #5576
2020-06-02 11:11:53 +05:30
1050c9857a
Fixed an issue when dumping servers from a desktop pgAdmin app by providing an option '--sqlite-path'. Fixes #5521
2020-06-01 11:22:38 +05:30
4632a7faba
Fixed an issue where pgadmin detects the wrong browser version of the Microsoft Edge. Fixes #5465
2020-05-29 13:07:02 +05:30
09b76b306c
Fixed typo in exception keyword. Fixes #5539
2020-05-28 18:11:41 +05:30
e10f1274dc
Ensure that the query tool panel gets closed when clicking on the 'Don't Save' button. Fixes #5416
2020-05-28 16:39:26 +05:30
b1cbcc7ef6
Fixed data truncation issue when updating the data of type character with length. Fixes #5481
2020-05-25 17:05:47 +05:30
22c3a2649b
Update Italian translation.
2020-05-25 11:24:37 +05:30
2bb0b25688
Update Japanese translation.
2020-05-25 11:13:37 +05:30
2aefc6361e
Update Czech translation.
2020-05-25 11:09:52 +05:30
d42b712ee4
Update message catalogs
2020-05-22 19:13:13 +05:30
9b8902dfb8
Fixed the SQL help issue for EDB Postgres Advanced Server. Fixes #4099
2020-05-22 14:11:58 +05:30
d927a517aa
Fixed feature test failures on the selenium grid for concurrent execution.
2020-05-21 19:44:28 +05:30
7b1cac6914
Fixed an issue where clicking on Select All button, not selecting all the options in pgAgent job scheduler. Fixes #5496
2020-05-19 13:54:21 +05:30
d1bdb178e2
Fixed an issue where if LDAP_SEARCH_BASE_DN is not set then, the value for LDAP_BASE_DN will be considered. Fixes #5487
2020-05-18 12:35:34 +05:30
9f445dc052
Improve code coverage and API test cases for Indexes. Fixes #5333
2020-05-18 12:29:33 +05:30
d58c33dec0
Search object UI improvements. Fixes #5493
2020-05-18 11:29:12 +05:30
0f56c25893
Changed the user identity from email to username in the log file.
...
refs #5452
2020-05-18 11:01:20 +05:30
6d6cd19b37
Improve code coverage and API test cases for Triggers and Compound Triggers. Fixes #5335
2020-05-15 12:50:50 +05:30
c0451cd454
Added connected pgAdmin user and connection name in the log file. Fixes #5452
...
Patch By: Nico T
2020-05-13 17:43:21 +05:30
0620fafb6c
Fixed PEP8 issues discovered after pycodestyle gets upgraded.
2020-05-13 17:14:32 +05:30
a9a1a975a6
Added compatibility for Flask-Security-Too version 3.2
2020-05-13 16:02:38 +05:30
dba5761ad0
Fixed an issue where clicking on the cross button of the alert box on the login page is not working. Fixes #4033
2020-05-12 17:22:22 +05:30
46e9924ebb
Fixed Unicode decode error 'utf-8' codec can't decode byte. Fixes #5510
...
It's a regression of commit id: 04d6d4e2ccc129baa698471ce0680ccabe2282be
2020-05-12 17:22:22 +05:30
9d08776824
Ensure that maintenance job should be worked properly for indexes under a materialized view. Fixes #4223 .
2020-05-11 16:47:36 +05:30
073d90c4a6
Fixed internal server error when clicking on Triggers -> 'Enable All' for partitions. Fixes #5052
2020-05-11 15:18:39 +05:30
1294c089a8
Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255
2020-05-11 12:11:31 +05:30
b64896f558
Fixed generated SQL issue for auto vacuum options. Fixes #5398
...
Fixed some more issues:
1) pgAdmin allows only true or false values for autovacuum_enabled,
and there is no way to reset it individually without disabling a custom auto vacuum.
To fix this, the control is changed from the switch to three state buttons.
2) Setting any vacuum options to zero made the option disappear from the SQL.
3) Right-click on a table with vacuum options set and create a new table.
4) The parameters tab will have the options prefilled.
5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.
The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".
2020-05-08 14:30:30 +05:30
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
9338bdcb3a
Fixed an issue where the newly added table is not alphabetically added to the tree. Fixes #5434
...
Fixed an issue when renaming the column not added in the proper order. Fixes #5450
2020-05-08 12:52:03 +05:30
d68e6bd892
Remove Python2 modules.
...
refs #5443
2020-05-08 12:28:21 +05:30
057a2b2312
Improve code coverage and API test cases for the Rules module. Fixes #5334
2020-05-07 16:27:58 +05:30
6ad46e1860
Fixed invalid literal issue when removing the connection limit for the existing role. Fixes #5001
2020-05-07 13:14:45 +05:30
a662d866af
Ensure that 'With OID' option should be disabled while taking backup of database server version 12 and above. Fixes #4840
2020-05-07 11:56:43 +05:30
a0940fd145
Typecast the object to 'text' before using it in length() function, so that correct length function gets called.
2020-05-06 17:34:18 +05:30
f61448eea2
Fixed an issue where the background job creation fails if there is only a version-specific python binary available in PATH. Fixes #5480
2020-05-06 12:38:06 +05:30
943495de31
Fixed list sorting issue in the schema diff tool. Fixes #5440
...
Fixed an issue while comparing the two identical schemas using the schema diff tool. Fixes #5449
2020-05-06 11:25:43 +05:30
370094274c
Fixed post-login redirect location when running in server mode under a non-default root. Fixes #5473
2020-05-04 15:00:45 +01:00
04d6d4e2cc
Remove support for Python 2. Fixes #5443
2020-05-04 14:58:49 +01:00
5fe7813f9f
Fixed an issue where select2 hover is inconsistent for the SSL field in create server dialog. Fixes #5469
2020-05-04 13:19:13 +05:30
d61b8eb1b3
Gracefully informed the user that the database is already connected when they click on 'Connect Database...'. Fixes #3694
2020-05-04 13:08:56 +05:30
0fc2afb829
Add Reverse Engineered and Modified SQL tests for Column and Type.
2020-05-04 12:48:24 +05:30
cc2e3ece7a
Ensure that file browse home button should point to /Users/akshayjoshi rather than /. Fixes #4279
2020-05-04 12:40:19 +05:30
5656f756e6
Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422
2020-05-04 12:23:18 +05:30
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
fe264aafa7
Update Czech translation.
2020-04-28 11:04:43 +05:30
88aebb64f9
Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447
...
It's a regression of #5213
2020-04-28 11:00:23 +05:30
b695329d2d
Fixed API test cases for backup, restore and maintenance.
2020-04-27 21:17:34 +05:30
99d1068f70
Fixed an issue where the search object not able to locate pg_toast_* tables in the pg_toast schema. Fixes #5441
2020-04-27 19:51:56 +05:30
18748846ef
Fixed the regression where initial changes make the Save button enabled when the table dialog is opened. Fixes #4504
2020-04-27 18:48:44 +05:30
b80784f5a1
Fixed an issue where the user should not be able to add columns in the creation order after 50 columns.
...
Regression of the initial patch.
Fixes #5043
2020-04-27 18:01:09 +05:30
76eb3e9b67
Fixed an issue when the user performs refresh on a large size materialized view. Fixes #5213
2020-04-27 17:30:23 +05:30
0f6abcc7fa
Fixed an issue where the user is not able to create a server if login with an LDAP account. Fixes #5439
...
Improved LDAP error messages.
2020-04-27 15:33:19 +05:30
ed106e3577
Update French translation.
2020-04-27 13:52:13 +05:30
3c9aed4d6f
Update Italian translation.
2020-04-27 13:50:31 +05:30
9daa7c7a7c
Added title to the login page. Fixes #5430
2020-04-27 12:38:11 +05:30
ccafde604e
Update message catalogs.
2020-04-24 18:24:00 +05:30
ef58d277ca
Fixed an issue where like options should be disabled if the relation is not selected while creating a table. Fixes #4504
2020-04-24 18:22:11 +05:30
aec64aa582
Fixed following issues for 1257:
...
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".
Fixes #1257
2020-04-24 16:35:59 +05:30
6de1d3f7de
Fixed feature test.
...
Pass the row height to the function instead of making the
decision onthe basis of whether it is a new row or not.
2020-04-24 13:16:18 +05:30
90849fe29b
Fixed mouse click issue where it does not select an object in Browser unless the pointer is over the object. Fixes #4180
2020-04-24 11:32:11 +05:30
17129b259b
Reverting patch for RM #3269 .
...
We observed that sometimes the browser is getting hanged and sometimes
the ViewData grid is getting disappear. We suspect its due to the number
of rows to update on the slick grid after fetching next of rows.
2020-04-24 11:13:13 +05:30
dfb74904ed
Ensure all object types have a System XXX? property. Fixes #1257
2020-04-23 17:31:40 +05:30
2b5c90e379
A warning message will be displayed only when the package header is changed for EPAS packages. Fixes #5410
2020-04-23 17:14:01 +05:30
2e29f3fd6d
Fixed an issue where columns names should be visible in the order of their creation in the browser tree. Fixes #5043
2020-04-23 16:42:42 +05:30
637c80c38b
Recreate the node item in the tree, when 'id' has been changed of the node.
...
Fixes #5053
2020-04-23 11:11:15 +05:30
c76732e3e7
Ensure that default sort order should be using the primary key in View/Edit data. Fixes #5157
2020-04-22 18:47:13 +05:30
b0464500ca
Ensure that the user should not be able to change the authentication source. Fixes #5419
...
Ensure error should be handled properly when LDAP user is created with the same name. Fixes #5420
Fixed an issue where an internal user is not created if the authentication source is set to internal and ldap. Fixes #5432
2020-04-22 18:47:13 +05:30
5e91ed2bb1
Fixed slider jump issue by making an API call to fetch the next batch of rows only after a user stops scrolling down. Fixes #3269
2020-04-22 18:47:13 +05:30
6e5dbf7beb
Added multiple drop/delete functionality for the table constraints. Fixes #3900
2020-04-22 18:47:13 +05:30
553eeb034d
Fixed tooltip crop issue for the large complex query with zoom factor. Fixes #5352
2020-04-22 18:47:13 +05:30
858294f36e
Fixed validation errors in view/materialized view javascript to
...
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.
Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.
Fixes #5053
2020-04-22 17:19:18 +05:30
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
b29bc6868c
Fixed an issue where [null] and [default] values are not get copied. Part of #3947
2020-04-22 12:08:52 +05:30
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
f289dfb762
Fixed following issues for packages:
...
1) Removing the package header removes the body as well.
2) Schema is not visible on the properties dialog.
3) Reverse engineering SQL and Create script not showing schema-qualified packages.
Fixes #5410
2020-04-21 16:49:23 +05:30
8d4f3c07c7
Fixed an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool. Fixes #3269
2020-04-21 13:29:49 +05:30
7e30a99937
Fixed the rightmost and bottom tooltip crop issues in the explain query plan. Fixes #5352
2020-04-21 13:14:26 +05:30
3d516101a4
Fixed an issue wherein grant wizard the last object is not selectable. Fixes #4545
2020-04-21 13:09:15 +05:30
05abb9e430
Ensure that the query tool context menu should work on the collection nodes. Fixes #5415
2020-04-20 18:50:20 +05:30
dc4571a3c8
Fixed search object issue when the object name contains special characters. Fixes #5401
2020-04-20 18:40:40 +05:30
7361470b64
Fixed an issue where the search object module unable to locate the object in the browser tree. Fixes #5396
2020-04-20 18:27:36 +05:30
f282b26883
Fixed an issue when the user creates a temporary table with 'on commit drop as' clause. Fixes #4946
2020-04-20 18:22:34 +05:30
4692b21bcf
Fixed an issue where schema diff marks an identical table as different. Fixes #5350
...
Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315
Ignore the keys from the source and target list and also sort both the lists.
2020-04-20 18:04:16 +05:30
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
8bdfa18efb
Ensure that if the delimiter is set other than comma then download the file as '.txt' file. Fixes #4573
2020-04-17 17:37:02 +05:30
52d031f2d0
Fixed encoding issue while saving data in encoded charset other than 'utf-8'. Fixes #4684
2020-04-17 16:30:22 +05:30
d8ad0b8faf
Fixed validation issue in Synonyms node. Fixes #5409
2020-04-17 14:50:38 +05:30
c6deb9393c
Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410
2020-04-17 13:06:07 +05:30
d35433d0b8
Fixed an issue where the query tool unable to load the file which contains the BOM marker. Fixes #3495
2020-04-17 12:40:09 +05:30
0ce4f49e08
Fixed copy-paste row issues in View/Edit Data. Fixes #3947
...
1) Copy table rows across two or more active query tool sessions.
2) Copied rows can be pasted multiple times without selecting a row in the query tool grid.
3) Adds an empty row at the end in the query tool grid after pasting rows.
2020-04-16 15:25:39 +05:30
dc1e32a632
Fixed internal server error when the database server is logged in with non-super user. Fixes #5400
2020-04-16 15:05:17 +05:30
c0a2f1f24d
Ensure that text larger than underlying field size should not be truncated automatically. Fixes #5210
2020-04-16 14:39:31 +05:30
eec2cfd5dd
Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. Fixes #5375
2020-04-16 13:16:07 +05:30
d6cab7b421
Ensure the DROP statements in reverse engineered SQL are properly quoted for all objects. Fixes #4440
2020-04-16 13:06:50 +05:30
Satish V
Pradip Parkale
Khushboo Vashi
Yogesh Mahajan
Diego Augusto Molina
Aditya Toshniwal
Nikhil Mohite
Akshay Joshi
Murtuza Zabuawala
Identifier Anonymous
Domenico Sgarbossa
Mishika Singh
Dave Page
Nagesh Dhope
Libor M
Yogesh Jain
Ashesh Vashi
Ganesh Jaybhay
Fred Escallier
navnath gadakh
Neel Patel
Amol Vyavahare
Shubham Agarwal