Akshay Joshi
dd6ae193ff
Replace 'fa-clock-o' with 'fa-clock' which is appropriate for font awesome v5
2020-08-21 13:44:29 +05:30
Dave Page
79e6480513
Added SQL Formatter support in Query Tool. Fixes #2042
2020-08-20 13:05:00 +05:30
Akshay Joshi
8f61944386
1) Added special handling for the extension to resolve the dependency.
...
2) Added 'is_sys_obj' to the ignore list of Schema Diff.
3) Font awesome v5 fixes.
2020-08-13 17:48:04 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Aditya Toshniwal
26a758a0d6
Fixed an issue where copying and pasting a cell with multiple line data
...
will result in multiple rows. Fixes #5526
Fixed an old issue where quotes are not escaped when copying the cells.
As per CSV standards, if the string is in double quotes and there are
double quotes inside the string then they should be escaped with extra double-quotes.
2020-08-10 16:53:32 +05:30
Aditya Toshniwal
f715373218
Replace charting library Flotr2 with ChartJS using React. Fixes #3904
2020-07-29 14:49:22 +05:30
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Aditya Toshniwal
9d0f3ce90b
Fixed code smell 'potential hiding of variables declared in an outer scope'.
2020-07-16 19:53:39 +05:30
Satish V
522ddad72b
Fixed code smell 'Variables should not be shadowed'.
2020-07-15 15:03:47 +05:30
Aditya Toshniwal
161c9b0fc7
Fixed code smell 'Variables should not be shadowed'.
...
Fixed all the duplicate CSS blocks issues raised by SonarQube.
2020-07-14 15:45:01 +05:30
Yogesh Mahajan
776bec0d82
Fixed following SoanrQube issues:
...
1) Variables should not be shadowed.
2) Variables and functions should not be redeclared.
2020-07-07 16:25:46 +05:30
Yogesh Mahajan
80ab596992
Fixed the SoanrQube code smell 'Variables should not be shadowed'.
2020-07-03 14:33:30 +05:30
Aditya Toshniwal
341c3aded6
Fixed dark theme-related CSS and modify the color codes. Fixes #5287
...
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
2020-07-03 11:47:40 +05:30
Nikhil Mohite
2ec8051303
Remove the duplicate code for tab indent and add the logic into codemirror.
2020-07-03 10:47:39 +05:30
Yogesh Mahajan
6dd3ca31be
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-07-01 13:43:00 +05:30
Nikhil Mohite
c2e875d54b
Fixed tab indent issue on a selection of lines is deleting the content when 'use spaces == true' in the preferences. Fixes #4235
2020-07-01 13:34:48 +05:30
Satish V
4c05287677
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-06-30 17:26:18 +05:30
Yogesh Mahajan
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Akshay Joshi
15c621b1d8
Fixed following SonarQube issues:
...
1) TypeError can be thrown as <variable_name> might be null or undefined here.
2) Unexpected duplicate "white-space".
3) Unexpected missing generic font family.
4) Unexpected shorthand "padding" after "padding-left".
2020-06-24 15:57:01 +05:30
Aditya Toshniwal
6620f9263d
Fixed issues reported by SonarQube with tag 'bad-practice'.
2020-06-22 12:18:59 +05:30
Akshay Joshi
bc24e3643f
More code cleanup for SonarQube.
2020-06-18 16:20:34 +01:00
Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Aditya Toshniwal
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
Satish V
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
Aditya Toshniwal
eb971a0320
Update Codemirror version to the latest which allows us to set screen reader labels on Codemirror editor.
...
refs #5197
2020-06-08 12:26:12 +05:30
Satish V
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
Satish V
9338bdcb3a
Fixed an issue where the newly added table is not alphabetically added to the tree. Fixes #5434
...
Fixed an issue when renaming the column not added in the proper order. Fixes #5450
2020-05-08 12:52:03 +05:30
Aditya Toshniwal
99d1068f70
Fixed an issue where the search object not able to locate pg_toast_* tables in the pg_toast schema. Fixes #5441
2020-04-27 19:51:56 +05:30
Satish V
2e29f3fd6d
Fixed an issue where columns names should be visible in the order of their creation in the browser tree. Fixes #5043
2020-04-23 16:42:42 +05:30
Neel Patel
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
Pradip Parkale
3d516101a4
Fixed an issue wherein grant wizard the last object is not selectable. Fixes #4545
2020-04-21 13:09:15 +05:30
Libor M
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
Nagesh Dhope
8bdfa18efb
Ensure that if the delimiter is set other than comma then download the file as '.txt' file. Fixes #4573
2020-04-17 17:37:02 +05:30
Nagesh Dhope
0ce4f49e08
Fixed copy-paste row issues in View/Edit Data. Fixes #3947
...
1) Copy table rows across two or more active query tool sessions.
2) Copied rows can be pasted multiple times without selecting a row in the query tool grid.
3) Adds an empty row at the end in the query tool grid after pasting rows.
2020-04-16 15:25:39 +05:30
Murtuza Zabuawala
c41da41efe
Fixed python exception error when user tries to download the CSV and there is a connection issue. Fixes #4858
2020-04-15 16:46:03 +05:30
Khushboo Vashi
ed0a596286
Added alert message to Reset Layout if any of the panels from Query Tool failed to load. Fixes #5366
2020-04-15 16:23:54 +05:30
Pradip Parkale
a05acb4f99
Fixed tab key navigation for some dialogs. Fixes #5371
2020-04-14 13:32:03 +05:30
Aditya Toshniwal
b427a87724
Fixed an issue where changing the values of columns with JSONB or JSON types to NULL. Fixes #4969
2020-04-13 12:34:32 +05:30
Aditya Toshniwal
077589e08b
Fixed an issue where right-clicking a browser object does not apply to the object on which right-click was fired. Fixes #3523
...
Fixes keyboard navigation on the context menu applied to browser tree.
2020-04-10 17:34:57 +05:30
Aditya Toshniwal
014ce31589
Fixed user management related issues:
...
1) Unable to add a user when there are many users. The dialog went blank. Fixed.
2) The error message did not have a close button. Fixed.
3) When clicked on the add button, then the cursor will focus on the email box of
the new row for convenience.
4) When the dialog opens, the cursor will focus on the search text box.
5) By default, the "User" role will be selected when adding a new user.
Also removed an empty option in the roles dropdown.
6) When the search filter is applied and we try to add an already existing user, the
validation is done only on the filtered data and not on all the users' data.
Fixes #5227
2020-04-10 16:49:33 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Pradip Parkale
33deacacee
Ensure that the grant wizard should be closed on pressing the ESC key. Fixes #4206
2020-04-07 13:48:56 +05:30
Aditya Toshniwal
e1f990190e
Added search object functionality. Fixes #2172
2020-04-06 17:33:07 +05:30
Aditya Toshniwal
4f71dae598
Fixed calendar opening issue on the exception tab inside the schedules tab of pgAgent. Fixes #4512
2020-04-06 12:59:22 +05:30
Vishal Sawale
99a72e529b
Fixed some accessibility issues:
...
1) Added missing search filter label in backgrid.
2) broken aria issue for objects menu.
2020-04-03 17:11:46 +05:30
Aditya Toshniwal
824e3866d8
Replace the existing color picker - spectrum-colorpicker with @simonwep/pickr.
...
spectrum-colorpicker has accessibility issues and is not maintained since long
Part of #5197
2020-04-03 17:06:47 +05:30
Vishal Sawale
4036f2a0f2
Fixed accessibility issue for the missing label from the table header.
2020-04-02 12:47:39 +05:30
Murtuza Zabuawala
37f55ccc25
Ensure that switch cell is in sync with switch control for accessibility. Fixes #5314
2020-04-02 12:25:55 +05:30