pgadmin-org
/
pgadmin4
mirror of https://github.com/pgadmin-org/pgadmin4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed following SoanrQube issues: 

1) Variables should not be shadowed.
  2) Variables and functions should not be redeclared.
pull/33/head
Yogesh Mahajan 2020-07-07 16:25:46 +05:30 committed by Akshay Joshi
parent ab2dc60097
commit 776bec0d82
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/pgadmin/static/js/selection/grid_selector.js
View File

@ -42,18 +42,18 @@ define(['jquery',
});
};
var getColumnDefinitions = function (columnDefinitions) {
columnDefinitions = columnSelector.getColumnDefinitions(columnDefinitions);
columnDefinitions = rowSelector.getColumnDefinitions(columnDefinitions);
var getColumnDefinitions = function (columnDefinition) {
columnDefinition = columnSelector.getColumnDefinitions(columnDefinition);
columnDefinition = rowSelector.getColumnDefinitions(columnDefinition);
columnDefinitions[0].selectAllOnClick = true;
columnDefinitions[0].name = '<span data-id="select-all" ' +
columnDefinition[0].selectAllOnClick = true;
columnDefinition[0].name = '<span data-id="select-all" ' +
'title="' + gettext('Select/Deselect All') + '">' +
'<br>' +
columnDefinitions[0].name +
columnDefinition[0].name +
'<img class="select-all-icon" src="' + url_for('static', {'filename': 'img/select-all-icon.png'}) + '"></img>' +
'</span>';
return columnDefinitions;
return columnDefinition;
};
function handleSelectedRangesChanged(grid) {

9
web/pgadmin/static/vendor/backgrid/backgrid.js vendored
View File

@ -312,8 +312,8 @@ _.extend(NumberFormatter.prototype, {
var decimalParts = rawData.split(this.decimalSeparator);
rawData = '';
for (var i = 0; i < decimalParts.length; i++) {
rawData = rawData + decimalParts[i] + '.';
for (var j = 0; j < decimalParts.length; j++) {
rawData = rawData + decimalParts[j] + '.';
}
if (rawData[rawData.length - 1] === '.') {
@ -1474,12 +1474,11 @@ var SelectCellEditor = Backgrid.SelectCellEditor = CellEditor.extend({
var optionValue = null;
var optionText = null;
var optionValue = null;
var optgroupName = null;
var optgroup = null;
for (var i = 0; i < optionValues.length; i++) {
var optionValue = optionValues[i];
optionValue = optionValues[i];
if (_.isArray(optionValue)) {
optionText = optionValue[0];
@ -1637,7 +1636,7 @@ var SelectCell = Backgrid.SelectCell = Cell.extend({
if (_.isArray(optionValue)) {
var optionText = optionValue[0];
var optionValue = optionValue[1];
optionValue = optionValue[1];
if (optionValue == rawDatum) selectedText.push(optionText);
}