Ashesh Vashi
b756407c3c
When running pgAdmin as a WSGI application, we will not be able to find
...
the '__main__' module under 'sys.modules'.
2017-04-03 18:44:53 +05:30
Murtuza Zabuawala
74655e60a0
Replace the '$DIR' only when found in the binary directory string.
2017-04-03 18:32:50 +05:30
Aravindraja Thinakaran
bb0bd8acc5
Properly handle truncated table names (> NAMEDATALEN). Fixes #2277
2017-04-01 02:57:48 -04:00
Harshal Dhumal
9acf340400
Generic function qtLiteral was not adapting values properly when they contain non ascii characters. Fixes #2305
2017-03-31 21:11:25 -04:00
Dave Page
4ba9269a88
Remove debug code.
2017-03-31 20:27:41 -04:00
Akshay Joshi
6a861f7a91
Add the config option ALLOW_SAVE_PASSWORD to allow admins to disable saving of passwords. Fixes #2232
2017-03-31 20:14:37 -04:00
Khushboo Vashi
efb077b7f7
Fix error highlighting in the query tool. Fixes #2291
2017-03-31 20:06:55 -04:00
Murtuza Zabuawala
08ff9d7422
Dialog Help was broken in case where query tool/Debugger opens in new browser tab. Fixes #2310
2017-03-31 16:08:05 +05:30
Maxim Zakharov
8005b05292
Fixes #2304 , #2145 - Resolve the issue for restoring the table from the backup.
...
Earlier - implementation was generating the backup code like as below:
XXX/pg_restore.exe --host "x.x.x.x" --port "xxxx" --username "osboxes" --no-password --dbname "test" --data-only --verbose --table "tt.test2" "XXX-FILE.bak"
It should have been:
XXX/pg_restore.exe --host "x.x.x.x" --port "xxxx" --username "osboxes" --no-password --dbname "test" --data-only --verbose --schema "tt" --table "test2" "XXX-FILE.bak"
2017-03-31 13:16:17 +05:30
Joao Pedro De Almeida Pereira
eb89998dc0
From a visual standpoint, grey highlight makes selection look deselected rather than selected. A brighter color would quickly provide visual feedback on an action.
...
With this patch the color of selected rows look more highlighted.
2017-03-30 22:56:13 -04:00
Sarah McAlear
1d27341e21
Fix translation extraction for new client side translations, and update catalogs.
2017-03-28 15:21:49 -04:00
Khushboo Vashi
8745417926
Fix ascending/descending sort order in backgrid while clicking on the headers. Fixes #2303
2017-03-28 09:19:24 -04:00
Dave Page
7450c2df0d
Revert code cleanup that wasn't 2.6 compatible.
2017-03-27 21:27:17 -04:00
Dave Page
95f43d59b8
Revert "Ensure client-side translations are correctly extracted into the message templates."
...
This reverts commit 82bd97aed0
.
There are still issues extracting with these changes.
2017-03-27 13:53:40 -04:00
Sarah McAlear
82bd97aed0
Ensure client-side translations are correctly extracted into the message templates.
2017-03-27 13:24:47 -04:00
Khushboo Vashi
633d2ad28c
Fix the bin path preferences.
2017-03-27 12:25:59 -04:00
Akshay Joshi
757500c478
Ensure preferences are properly saved the first time they're set.
2017-03-27 12:19:28 -04:00
Dave Page
b2ab35e990
Don't require an auth key for the static help files. It doesn't play nicely with webkit.
2017-03-26 21:52:31 -04:00
Jonas Thelemann
c391696054
Remove some unnecessary line breaks causing problems with translations.
2017-03-26 20:26:58 -04:00
Dave Page
6152d73f13
Fix some code inspection complaints
2017-03-25 22:04:52 -04:00
Dave Page
a6fa35789c
Fix broken markup
2017-03-25 22:04:52 -04:00
Dave Page
4f27afc99b
Ensure the spinner doesn't obscure the version
2017-03-25 22:04:52 -04:00
Akshay Joshi
569ceb3906
Modify the web code to allow the Query Tool and Debugger to be opened in new tabs, per settings in Preferences. Fixes #1344
...
Note that this does *not* enable the runtime to use multiple windows at this stage. It's really only useful in Server mode.
2017-03-24 14:43:56 +00:00
Khushboo Vashi
0eda6033df
Allow users to select UI language at login or from Preferences rather than unpredictable behaviour from browsers. Fixes #2190
2017-03-24 14:20:10 +00:00
Dave Page
6cb9ece6fd
Decode error messages before trying to use them.
2017-03-24 14:11:31 +00:00
Wayne Winch Jr
5f2a15dd6d
Fix deletion of rows where the primary key isn't at ordinal zero. Fixes #2274
2017-03-24 13:32:56 +00:00
Murtuza Zabuawala
d4e88217eb
Added timeout in _wait_timeout function in our psycopg2 module.
...
Fixes debugger module, Added common function to covert 2d array data to dict for BackGrid.
2017-03-24 14:01:59 +05:30
Dave Page
d205550b53
Fix Python 3 compatibility.
2017-03-23 13:43:24 +00:00
Dave Page
8748ee20cb
Client side translation.
2017-03-23 12:35:28 +00:00
Atira Odhner
10920404e1
Re-organised the regression directory now we have multiple test suites: move test_utils.py into python_test_utils/
2017-03-23 11:59:31 +00:00
Atira Odhner
fe9bc379c7
Replace the template selection feature test with one that tests table DDL generation (which also covers template selection).
2017-03-23 11:47:21 +00:00
Atira Odhner
77007996ed
Support generation of DDL for tables in Greenplum DB. Fixes #2261
2017-03-23 11:40:06 +00:00
Atira Odhner
0ba0b25290
Move foreign key templates into a default directory.
2017-03-23 11:13:06 +00:00
Harshal Dhumal
720aefbe6f
Select2Cell: Check if cell is in multiselect mode before setting default selection of multiple values. Fixes #2283
2017-03-23 10:45:42 +00:00
Dave Page
5b12fd6d5f
Client-side translation for the About and Dashboard modules.
2017-03-22 12:57:59 +00:00
Ashesh Vashi
90a369b7de
[Extendible][Dashboard] Allow to create a server clicking the
...
'Add New Server' button on the dashboard, even when the first node is
of not type of 'server-group' in the browser tree.
2017-03-21 22:58:07 +05:30
Harshal Dhumal
2142824448
PRevent an error being displayed if the user views data on a table with no columns. Fixes #2244
2017-03-21 16:40:21 +00:00
Surinder Kumar
aee1492d0d
Correct some EDB Postgres Advanced Server branding.
2017-03-21 10:12:26 +00:00
Ashesh Vashi
4eafdbeff6
Resolved a typo - show a '?' after the 'Show timing' preference.
2017-03-21 11:17:35 +05:30
Ashesh Vashi
72128df75c
[Extendible][Dashboard] Allow to show the dashboard of their choice for
...
the selected node in the browser tree.
2017-03-20 19:17:47 +05:30
Sarah McAlear
c9e04fec8d
Show tooltips for disabled buttons to help user learning. Fixes #2226
2017-03-20 10:33:35 +00:00
Murtuza Zabuawala
145983d544
Add miissing braces to reverse engineered SQL header block for Functions. Fixes #2246
2017-03-17 12:48:58 +00:00
Murtuza Zabuawala
461086c17d
Fix View Data filter options. Fixes #2265
2017-03-17 12:45:59 +00:00
Murtuza Zabuawala
e9702752d9
Fix hadling of DATERANGE[] type. Fixes #2258
2017-03-17 12:40:08 +00:00
Harshal Dhumal
e4134695e5
Fix dropping of databases with Unicode names. Fixes #2243
...
1. Pickup correct encoding in qtLiteral to decode.
2. While releasing database connection only decode database name if it's not unicode.
2017-03-17 10:33:03 +00:00
Dave Page
648c332488
Import from flask_babel instead of the deprecated flask.ext.babel. Fixes #2264
2017-03-17 10:22:41 +00:00
Atira Odhner
4464be6f43
Fix a typo and remove an unnecessary copy of the column properties template.
2017-03-17 10:02:52 +00:00
Dave Page
b2a74ad26d
Fix a bunch of file headers.
2017-03-16 14:27:55 +00:00
Atira Odhner
ae0d8e89eb
Fix the path to JS
2017-03-15 17:12:58 +00:00
Atira Odhner
889050b71d
Fix quotes to ensure we have valid JS.
2017-03-15 17:11:53 +00:00
Atira Odhner
172b41cba8
Refactor clipboard copying into a separate file for use outside the SQL Editor.
2017-03-15 17:11:11 +00:00
Atira Odhner
4445f9dd63
Add a mechanism for centralising JS translations, to avoid having to render many JS files with Jinja.
2017-03-15 17:10:22 +00:00
Murtuza Zabuawala
ff9d6cd3d5
Fix previous partial commit
2017-03-14 09:34:12 +00:00
Murtuza Zabuawala
cc4c557122
Move Bootstrap files into the distribution format.
2017-03-14 09:23:30 +00:00
Dave Page
1c6f30a0ed
Remove \n in translation that was causing a syntax error.
2017-03-13 10:39:36 +00:00
Ashesh Vashi
7767c085c3
Resolved an issue finding the python interpreter on *nix systems, and
...
Windows 2008 R2 (32 bit), while running the pgAdmin 4 as runtime for
the PostgreSQL one click installers.
- Found a typo in runtime code, we were appending the path using ';' on
*nix systems too. We should have used ':', and that did not allow the
os.environ['PATH'] to identify the correct path of the python
interpreter under the 'venv' directory.
- On Windows 2008, it was not honouring the environment variables, set
under the Qt application (e.g. pgAdmin4.exe runtime), in the python
application. (e.g. pgAdmin4.py). We will need to assume that - the
python interpreter resides under the 'venv' directory outside the
'bin' directory.
- Also, on windows 2008, it was setting PYTHONHOME environment variable
to the full path of the pgAdmin4.exe, we need to reset it to 'venv'
directory, if we find the python interpreter under it.
Thanks Murtuza Zabuawala for tips, and help.
2017-03-10 21:19:06 +05:30
Atira Odhner
28deb34283
Remove some dead code.
2017-03-10 10:27:17 +00:00
Begina Felicysym
5e6c29d5db
Update Polish translation
2017-03-10 09:03:18 +00:00
Joao Pedro De Almeida Pereira
d756f2f6c6
Create screenshots when feature tests fail.
2017-03-09 15:34:51 +00:00
Harshal Dhumal
502c827697
Fix numeric control validation in nested schemas. Fixes #2241
2017-03-09 15:23:18 +00:00
Dave Page
670c8a2cc1
Disable HTMLMIN with Python 2.6 as it doesn't work on that older version.
2017-03-09 15:21:52 +00:00
Murtuza Zabuawala
bc63652811
Fix the issue where Import/Export was failing in linux runtime. Fixes #2166
...
Issue:
Changes done by Ashesh in pgAdmin4.py file for setting up PYTHONHOME variable to sys.prefix was applicable only for windows only.
Additionally I have also added exception handling for file provided by user for Backup/Restore/Import/Export.
2017-03-09 09:54:55 +00:00
Murtuza Zabuawala
533833cb02
Cleanup some ugly code formatting.
2017-03-09 09:27:41 +00:00
Dave Page
18d465e7bc
Fix some messages and update the Polish translation from Begina Felicysym
2017-03-09 09:23:19 +00:00
Begina Felicysym
b6fefd89b6
Add a Polish translation
2017-03-08 10:14:18 +00:00
Dave Page
fb44ffffa0
Fix a couple of translation issues, and remove the test French translation files.
2017-03-08 10:13:15 +00:00
Dave Page
1f9fd507b0
Translation updates.
2017-03-07 11:20:20 +00:00
Ashesh Vashi
6cc1fbe739
Import config only when needed, it was causing cyclic dependency when
...
running the regression suite.
2017-03-07 16:07:10 +05:30
Jonas Thelemann
e3e951e86d
Prevent the Slonik logo obscuring the login dialogue on small displays in server mode. Fixes #2230
2017-03-07 10:33:38 +00:00
Jonas Thelemann
c34f5fd2d4
Use "could not" consistently, instead of "couldn't" which was used in some places.
2017-03-07 10:29:54 +00:00
Ashesh Vashi
f2fc1ceba8
Resolved quite a few file-system encoding/decoding related cases.
...
In order to resolve the non-ascii characters in path (in user directory,
storage path, etc) on windows, we have converted the path into the
short-path, so that - we don't need to deal with the encoding issues
(specially with Python 2).
We've resolved majority of the issues with this patch.
We still need couple issues to resolve after this in the same area.
TODO
* Add better support for non-ascii characters in the database name on
windows with Python 3
* Improve the messages created after the background processes by
different modules (such as Backup, Restore, Import/Export, etc.),
which does not show short-paths, and xml representable characters for
non-ascii characters, when found in the database objects, and the file
PATH.
Fixes #2174 , #1797 , #2166 , #1940
Initial patch by: Surinder Kumar
Reviewed by: Murtuza Zabuawala
2017-03-07 15:31:03 +05:30
Dave Page
3317a02120
Fix regression tests with runtime auth. Fixes #2228
2017-03-06 15:24:52 +00:00
Dave Page
6696b3c316
Authenticate the runtime to the server. Fixes #2228
2017-03-06 14:53:49 +00:00
Murtuza Zabuawala
6d6a3753ee
Fix the path to the busy indicator for the treeview which changed when the aciTree module was moved.
2017-03-06 10:36:07 +00:00
Murtuza Zabuawala
da186ea77b
Ensure servers are deleted when their parent group is deleted. Fixes #2212
2017-03-06 10:35:27 +00:00
Murtuza Zabuawala
af499c0c9a
Show the correct indeterminate state when editing new boolean values. Fixes #2218
2017-03-06 10:30:58 +00:00
Neel Patel
278c64c361
Add missing "Run Now" option for pgAdmin jobs. Fixes #1796
2017-03-06 10:24:43 +00:00
Dave Page
d1b95aeb33
Revert "Rename the top level feature tests directory for consistency with other test directories"
...
The exclude command line option relies on the directory name. This needs fixing...
This reverts commit 9288d69b62
.
2017-03-02 11:23:05 +00:00
Dave Page
9288d69b62
Rename the top level feature tests directory for consistency with other test directories
2017-03-02 11:09:08 +00:00
Harshal Dhumal
ffa8d94e76
Better handling the non-ascii characters for different database objects.
...
Using 'psycopg2.extensions.UNICODE' (for Python < 3) in the psycopg2
driver for proper conversation of unicode characters. Also - adjusted
the string typecaster to take care of different character types (char,
character, text, name, character varying, and their array types).
Reviewed by: Dave Page, Murtuza Zabuawala & Akshay Joshi
2017-03-02 15:09:28 +05:30
Atira Odhner
e89c54c15d
Make feature test app teardown more reliable, and tests faster
...
- don't spin up app and chromedriver between each test
- catching signals also tears down the app
- do layout reset between tests, but assume that tests will not leave a modal opened.
Use selenium built-in waiting function and fix flakiness around clicking the alertify OK button
- we think the OK button does not have its event bound when it is created.
If you see more flakiness around clicking the alertify OK button, let us know. The element is clickable but we have to arbitrarily wait for the event to be bound and that timing may vary system to system.
The feature tests are about 7 seconds faster now.
Tira & Joao
2017-03-01 13:20:06 +00:00
Dave Page
59c6be534d
Typo fixes.
2017-03-01 12:49:15 +00:00
Khushboo Vashi
ddb8bad201
Fix Sequence ACL SQL for PG 9.3/9.2.
2017-03-01 12:46:58 +00:00
Murtuza Zabuawala
480e00fddf
Query tool efficiency.Convert the data as a 2D array instead of dict. Fixes #2036
...
Incremental back off when polling. Fixes #2038
Initial Patch By: Dave Page
2017-03-01 16:58:51 +05:30
Atira Odhner
0cd914f3f9
Improve visibility of syntax highlighting colours. Fixes #2215
2017-02-28 15:08:36 +00:00
Murtuza Zabuawala
e2e000a371
Remove a debug message.
2017-02-28 14:44:58 +00:00
Navnath Gadakh
1f935d699e
Testsuite fixes for 9.3 and 9.2 support.
2017-02-28 14:22:10 +00:00
Dave Page
5dc2326e9d
Consistent dialogue configuration
2017-02-27 14:58:22 +00:00
Dave Page
3638d63330
Move pgadmin plugins for codemirror back out of the vendor area.
2017-02-27 13:18:28 +00:00
Dave Page
206b9255c5
Fix CSS path. Fixes #2213
2017-02-27 12:39:13 +00:00
Sarah McAlear
a0a31e55ae
Move 3rd party client code into vendor/ directories for ease of maintenance.
2017-02-24 17:01:21 +00:00
Dave Page
b19081421b
Ensure primary key column names are quoted in View Data mode of the Query Tool. Fixes #2208
2017-02-24 13:58:23 +00:00
Surinder Kumar
40ff651ef3
Fix display of boolean nulls in the query tool. Fixes #2205
2017-02-24 13:47:37 +00:00
Surinder Kumar
88cae263b2
Fix display of long integers and decimals. Fixes #2039 . Fixes #2119 . Fixes #2154
2017-02-24 13:39:40 +00:00
Surinder Kumar
c0f2aab001
Ensure we never sort columns on the treeview. Fixes #2185
2017-02-24 13:02:13 +00:00
Harshal Dhumal
b961b2d929
Fix function arguments when generating create SQL. Fixes #2198
2017-02-24 12:42:25 +00:00
Khushboo Vashi
0ba9b7db43
Add PARALLEL SAFE|UNSAFE|RESTRICTED support. Fixes #2089
2017-02-24 12:21:05 +00:00
Harshal Dhumal
1c09b57a1a
Fix casting issue with dependents queries.
2017-02-24 10:48:46 +00:00
Harshal Dhumal
685b1ea12f
Fix renaming of check constraints when the table name is changed at the same time. Fixes #2201
2017-02-24 10:44:43 +00:00
Harshal Dhumal
5e33fe4e95
Properly handle event trigger functions in different schemas. Fixes #2200
2017-02-24 10:40:11 +00:00
Atira Odhner
fe1aec5de0
Add feature test framework, using selenium and chromedriver for UI testing.
...
Written by both George and Atira at Pivotal.
2017-02-22 12:41:28 +00:00
Murtuza Zabuawala
89137f57b2
Display un-sized varlen column types correctly in the query tool. Fixes #2151
2017-02-21 13:12:50 +00:00
George Gelashvili
03a161cc0a
Don't try to decode connection error strings that are null.
2017-02-16 16:42:19 +00:00
Dave Page
03f292ce51
Tidy up the regression test output a little.
2017-02-16 11:40:54 +00:00
Murtuza Zabuawala
9ad1316990
Various encoding fixes. Fixes #2160
2017-02-16 11:00:40 +00:00
Surinder Kumar
833629d438
Fix exclusion constraint reverse engineered SQL. Fixes #2115
2017-02-16 10:54:21 +00:00
Surinder Kumar
cbaad81f00
Correct node labels in Preferences for EDB functions and procedures. Fixes #2126
2017-02-16 10:47:28 +00:00
Atira Odhner
b6486f3d42
Test suite runner enhancements:
...
To chase down a set of tests that were failing together, we wanted to run
deeper trees of tests. We changed the behavior of the --pkg argument to
runtests.py so it runs tests under a package and its subpackages, instead
of for a single node.
It gave us more flexibility in what tests to run. This also includes the
--exclude option.
To run tests for a single node, ".tests" can be appended to the package path.
Tira & George.
2017-02-15 15:10:31 +00:00
Dave Page
ae10da4371
Another Python 3.x compatibility fix.
2017-02-13 10:27:16 +00:00
Dave Page
14f181d2ba
Fix Python 3 compatibility.
2017-02-13 10:07:38 +00:00
Atira Odhner
1340c1c2ee
Make syntax highlighting more visible by making keywords and numbers bolder.
2017-02-13 10:05:54 +00:00
Atira Odhner
ec9e8b79a3
Basic support for viewing tables in Greenplum. Patch from George & Tira @ Pivotal.
2017-02-13 10:02:20 +00:00
Murtuza Zabuawala
6887920295
Ensure FTS parsers and templates are removed prior to creating them when testing.
2017-02-09 12:05:55 +00:00
Murtuza Zabuawala
c34fdaf37d
Fix the issue with Jinja conditions in Foreign Data Wrappers, Foreign Servers, User Mapping.
...
I also did some re-formatting & re-factoring to code to remove all the duplicate code.
2017-02-09 12:05:09 +00:00
Murtuza Zabuawala
a914ea088c
Python 2.6 compatibility fixes.
2017-02-08 16:28:04 +00:00
Dave Page
2dc0eab057
Update translation files.
2017-02-06 16:25:16 +00:00
Murtuza Zabuawala
ec93077040
Compatibility fixes for newer versions of Jinja2 (e.g. 2.9.5+). Fixes #2156
2017-02-06 12:53:16 +00:00
Murtuza Zabuawala
c96da34c28
Fix handling of "char" columns. Fixes #2152
2017-02-06 10:59:03 +00:00
Murtuza Zabuawala
4d8683e13a
Fix display of graphical query plans for UPDATE/DELETE queries. Fixes #2133
2017-02-06 10:43:31 +00:00
Murtuza Zabuawala
3ea8a7b211
Fix column addition regression test.
2017-02-06 09:46:34 +00:00
Surinder Kumar
4566877188
Handle NULL booleans in the data editor. Fixes #1790
2017-02-05 11:06:48 +01:00
Ashesh Vashi
b7c5039416
Fix process execution. Fixes #1679 . Fixes #2144 .
...
Re-engineer the background process executor, to avoid using sqlite as some builds of
components it relies on do not support working in forked children.
2017-02-04 15:26:57 +01:00
Surinder Kumar
54ba1fbe59
Support setting text fields to empty strings or NULL in the data editor grid. Fixes #1790
2017-02-04 14:10:30 +01:00
Neel Patel
c17e201a92
Handle saved directories that no longer exist gracefully. Fixes #2110
2017-02-03 15:19:21 +01:00
Murtuza Zabuawala
bf8c3c4180
Handle sized time/timestamp columns correctly. Fixes #2076
2017-02-03 14:51:58 +01:00
Khushboo Vashi
f2ac6fc6a7
1) Wrong tablespace displayed in table properties. Fixes #2069
...
2) Message (Connection to the server has been lost.) displayed with Materialized view and view under sql tab. Fixes #2139
2017-02-03 16:13:07 +05:30
Harshal Dhumal
4ef26a528b
Allow direct navigation (i.e. typing of paths) in the file manager. Fixes #1911
2017-02-03 10:51:36 +01:00
Murtuza Zabuawala
687a793383
Fix display of zeros in read-only grid editors. Fixes #2138
2017-02-01 13:48:46 +00:00
Murtuza Zabuawala
2d442da9ff
Properly handle setting comments and other options on databases with allowconn = False. Fixes #2024
2017-02-01 10:23:45 +00:00
George Gelashvili
6d05302ca1
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3.
2017-02-01 09:57:49 +00:00
Murtuza Zabuawala
0da8d1fe4c
Another Python 3 fix.
2017-01-31 12:12:22 +00:00
Murtuza Zabuawala
2e5771e164
Python 3 fix for the template loader test.
2017-01-31 10:02:20 +00:00
Atira Odhner
c6b67fc66a
Bypass recovery checks with older servers. This is required for Greenplum which is based on PG 8.3 at present.
2017-01-30 17:02:55 +00:00
Surinder Kumar
30e546208f
Ensure dialogues cannot be moved under the navbar. Fixes #2047
2017-01-30 14:02:01 +00:00
Murtuza Zabuawala
e8f0cf6d94
Resolve various trigger issues. Fixes #2015
...
- Allow changing of row/statement flag
- When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, Row trigger etc. then new OID is getting generated so we should fetch and return new OID in response rather then old trigger OID.
2017-01-30 13:05:15 +00:00
George Gelashvili
19be3529f8
Create a template loader for SQL templates.
...
This will automatically find the correct version of a template for the server version, and allows us to remove templates that were previously duplicated for different server versions.
Patch by George & Tira at Pivotal. Review by me and Murtuza from EDB.
Discussion: https://www.postgresql.org/message-id/flat/CAHowoHaU9_pkCt%2B1g8dpY3hsXXZmsJZiJH-3-_Hd%2BC1MxiGhtA%40mail.gmail.com#CAHowoHaU9_pkCt+1g8dpY3hsXXZmsJZiJH-3-_Hd+C1MxiGhtA@mail.gmail.com
2017-01-30 11:25:03 +00:00
Surinder Kumar
e01cf748ea
Enable/disable NULLs and ASC/DESC options for index columns and exclusion constraints appropriately. Fixes #2061 . Fixes #1840 .
2017-01-25 13:21:39 +00:00
Murtuza Zabuawala
29a6f2e124
Fix Reset Statistics operation for which the popup messages weren't displaying correctly. Fixes #2091
2017-01-24 10:19:33 +00:00
Dave Page
801c7688a3
A little message cleanup.
2017-01-24 10:18:30 +00:00
Harshal Dhumal
415119d581
Properly remove any event listeners added by subnode control.
2017-01-20 13:24:37 +00:00
Dave Page
ac4178233b
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024"
...
This reverts commit e431eb9d8e
.
2017-01-20 13:21:05 +00:00
Murtuza Zabuawala
6557433061
Fix display of enum GUCs on users/databases etc. Fixes #2067
2017-01-17 10:45:01 +00:00
Murtuza Zabuawala
28621999f2
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065
2017-01-17 10:25:26 +00:00
Murtuza Zabuawala
e431eb9d8e
Handle comments on databases with datallowconn=False correctly. Fixes #2024
2017-01-16 15:42:25 +00:00
Neel Patel
0d4bc0d27d
Store layout changes on each adjustment, rather than on unload which is unreliable. Fixes #1967
...
We also use an async request now, rather than a deprecated sync request.
2017-01-16 15:34:55 +00:00
Khushboo Vashi
024b664c21
Improve the display of role membership on both the properties panel and role dialogue. Fixes #1730
2017-01-16 14:48:25 +00:00
Dave Page
a85861ca57
Remove some comments that don't fit with our normal presentation of generated SQL.
2017-01-16 14:46:44 +00:00
Surinder Kumar
86f6857cb7
Fix sorting of numerics in the statistics grids. Fixes #1938
2017-01-09 15:55:38 +05:30
Murtuza Zabuawala
4c19f93b3b
Use the correct OID for retrieving properties of freshly created exclusion constraints. Fixes #1896
2017-01-09 15:05:22 +05:30
Surinder Kumar
e400693126
Add BigNumberJS library for upcoming large number related fixes.
2017-01-09 09:07:21 +05:30
Surinder Kumar
b14f8239d2
Fix a SQL error when reverse-engineering ROLE SQL on EPAS servers. Fixes #1830
2017-01-09 08:14:34 +05:30
Khushboo Vashi
01b2288d57
Ensure columns with types that are not in pg_catalog are handled properly in the table dialog.
2017-01-09 08:05:51 +05:30
Surinder Kumar
d05534ad6c
Prevent attempts to access what may be an empty list. Fixes #1832
2017-01-09 07:56:02 +05:30
Neel Patel
d87345ef52
Ensure breakpoints are cleared properly when clearing all of them. Fixes #1745
2017-01-08 19:05:13 +05:30
Navnath Gadakh
1325b30e0b
Various improvements to the regression tests, notably avoiding use of signals unavailable on Windows.
2017-01-08 18:48:04 +05:30
Murtuza Zabuawala
bdf9761472
Improve consistency of dialogue controls offered. Fixes #1364
2017-01-08 16:05:34 +05:30
Neel Patel
8d71e888b4
Remember the last used directory in the file manager. Fixes #1910
2017-01-08 15:27:59 +05:30
Dave Page
5d0a0e57e7
Allow selection of message box contents for ease of error message copy/paste.
2017-01-08 15:27:58 +05:30
Neel Patel
2787c5c207
Reset the column list properly if the access method is changed on an index to ensure error handling works correctly. Fixes #2009
2017-01-08 15:27:58 +05:30
Surinder Kumar
6e14bef801
Show icons for unique and exclusion constraints in the dependency/dependents panels. Fixes #2033
2017-01-08 15:27:58 +05:30
Murtuza Zabuawala
879a6bef53
Fix keyboard control of switches in the column grid. Fixes #1394
2017-01-08 15:27:58 +05:30
Neel Patel
a33ee2ae32
Improve detection of the pldbgapi extension and functions before allowing debugging. Fixes #2026
2017-01-08 15:27:58 +05:30
Surinder Kumar
e3c8cb2706
Prevent attempts to create server groups with no name. Fixes #2012
2017-01-08 15:27:58 +05:30
Akshay Joshi
ae809c4506
Properly detect when files have changed in the query tool and set the dirty flag accordingly. Fixes #1807
...
Note that (like pgAdmin 3) we don't make any attempt to detect if all changes have been undone and completely reverted as that could be very expensive with large scripts.
2017-01-08 15:27:58 +05:30
Surinder Kumar
07e1c61eea
Allow setting of effective_io_concurrency on tablespaces in 9.6+. Fixes #2000
2017-01-08 15:27:58 +05:30
Dave Page
a93a99fdc0
Improve query plan tooltip formatting.
2017-01-06 15:38:27 +00:00
Dave Page
1504d05cdd
Format JSON more efficiently. This can significantly reduce response sizes from the server.
2017-01-06 14:09:36 +00:00
Dave Page
fe9bdc62a1
Fix copyright notices.
2017-01-04 13:35:38 +00:00
Dave Page
560395e557
Tidy up file header
2017-01-04 13:34:17 +00:00
Dave Page
f221194bcc
Update copyright notices for 2017.
2017-01-04 13:33:32 +00:00
Dave Page
87d4937726
Minimise memory requirements for rendered cells and rows in SlickGrid. Fixes #2035
...
- The CSS class 'slick-row' has been renamed to 'sr'
- The CSS class 'slick-cell' has been renamed to 'sc'
- The SQL Editor included an unused 'normal_row' class on each row which has been removed as it was unreferenced in the code or CSS.
The intent of these changes is to minimise memory usage by the grid, by saving a few bytes per row/cell.
It's questionable how much difference this actually makes given that SlickGrid updates the document so it
only includes the visible rows on the fly, but every little helps.
2016-12-22 17:43:42 +00:00
Murtuza Zabuawala
43b9e53572
Fix word wrap in note control.
2016-12-21 13:17:11 +00:00
Dave Page
99299f022f
Fix time formatting on dashboards. Fixes #2032
2016-12-21 12:01:43 +00:00
Dave Page
d3862eef3f
Fix some additional table styling inconsistencies.
2016-12-19 14:26:33 +00:00
Dave Page
ef5b8fe603
Clarify the close browser warning.
2016-12-19 12:12:43 +00:00
Khushboo Vashi
5008872203
Ensure the SQL editor has enough space to show block folding arrows in the gutter.
2016-12-19 11:35:27 +00:00
Harshal Dhumal
5adc6b71ca
fix display of double scrollbars on the grant wizard. Fixes #2028
2016-12-19 09:25:14 +00:00
Harshal Dhumal
2994c128f3
Fix inconsistent table styling. Fixes #2027
2016-12-19 09:21:49 +00:00
Murtuza Zabuawala
6fc8f040ff
Allow users to enable wrapping of code in SQL boxes. Fixes#2025
2016-12-16 17:07:41 +00:00
Khushboo Vashi
1d571902da
Fix regression when generating SQL for new databases, caused by an invalid check of datallowconn introduced in the fix for #1801 .
2016-12-16 13:12:12 +00:00
Khushboo Vashi
53ea991907
Properly size the SQL Editor gutter as the width of the line numbers increases. Fixes #1780
2016-12-16 13:04:16 +00:00
Murtuza Zabuawala
1431dfcb01
Show index columns in the correct order in RE-SQL. Fixes #1842
2016-12-16 11:59:37 +00:00
Akshay Joshi
686237413c
Use more sensible column sizes for the data output in the query tool. Fixes #1789
...
Per Akshay:
I have tried to get the width of the content but we are sending complete data as collection to the SlickGrid. We will have to fetch the content of each column and figure out the maximum length for that column by iterating all the rows is too expensive. Apart from that to set the width in 'ch' we will have to do it using css. With current implementation we are setting the column option of the SlickGrid from javascript code.
I have fixed this issue by setting the width of the columns based on data type. I have set the width of boolean column to 60, all the numeric/integer columns to 80 and for all other data types it is 20% of the container width as 33% is too wide.
2016-12-12 10:13:53 +00:00
Khushboo Vashi
53481023fa
Properly sort rows by the pkey when viewing first/last 100. Fixes #2007
2016-12-12 10:06:34 +00:00
Ashesh Vashi
dbff4f7977
Minor Python 3/encoding fix in the file manager.
2016-12-12 09:49:00 +00:00
Dave Page
4a280b2517
Only show the filename in query tool tabs, not the whole path.
2016-12-09 12:42:30 +00:00
Akshay Joshi
b8d03d5dc2
Don't cast data when saving in the edit grid, so errors are seen and data doesn't get silently modified. Fixes #1994
2016-12-09 12:05:46 +00:00
Khushboo Vashi
81841cdb3c
Treat databases with datallowconn=false appropriately. Fixes #1801
2016-12-09 11:59:13 +00:00
Anthony DeBarros
6ff2fe64b8
Fix various mis-spellings of VACUUM. Fixes #2005
2016-12-08 10:35:53 +00:00
Dave Page
eb337cadce
Remove unused rows per page config option.
2016-12-05 13:59:44 +09:00
Akshay Joshi
e160909423
Quote identifiers correctly in auto-complete. Fixes #1992
2016-12-05 13:15:03 +09:00
Surinder Kumar
a64824a851
Fix various encoding issues with multibyte paths and filenames.
...
Fixes #1986 . Fixes #1940 .
2016-12-05 13:10:56 +09:00
Neel Patel
54e6336a58
Deal with Function arguments correctly in the properties dialogue. Fixes #1979
2016-11-25 10:55:10 +00:00
Murtuza Zabuawala
66b9e22d01
Handle the template property on databases appropriately. Fixes #1800
2016-11-25 10:11:40 +00:00
Dave Page
394381bf75
Add search/replace support to the Query Tool, including regexp matching. Fixes #1765
2016-11-24 15:38:39 +00:00
Dave Page
1a18e07329
Allow a placeholder ($DIR) to be used in utility paths to make it easier to use relative paths.
2016-11-23 13:35:27 +00:00
Dave Page
08396ce861
Allow default binary paths to be set in the config for each database driver.
2016-11-23 12:44:13 +00:00
Dave Page
961f946a76
Treat empty text settings as unset, to allow users to clear a string to get the default back.
2016-11-23 12:43:02 +00:00
Dave Page
8ae4a10c64
Apparently Flask-HTMLmin still requires django-htmlmin
2016-11-21 13:37:52 +00:00
Dave Page
020bf1d532
Minify HTML with Flask-HTMLMIN
2016-11-18 16:42:38 +00:00
Murtuza Zabuawala
b7c819e912
Render column headers at the correct width in the query tool under Firefox. Fixes #1680
2016-11-18 14:24:16 +00:00
Khushboo Vashi
54b35c711d
Ensure dialogue panels show their errors themselves, and not in the properties panel. Fixes #1855
2016-11-18 14:05:39 +00:00
Murtuza Zabuawala
6e5126d571
Add newly created triggers to the treeview. Fixes #1747
2016-11-18 13:58:35 +00:00
Murtuza Zabuawala
6e68e7501a
Display messages and notices received in the query tool. Fixes #1953
2016-11-18 13:53:57 +00:00
Khushboo Vashi
6567669798
Ensure the check_option is only set when editing views when appropriate. Fixes #1924
2016-11-18 13:44:43 +00:00
Dave Page
29743ad3c4
Allow selection of process output and commands.
2016-11-18 12:05:19 +00:00
Dave Page
687f1f640f
Prevent users selecting elements of the UI that shouldn't be selectable. Fixes #1976
2016-11-18 10:55:00 +00:00
lambda
e3c8b67767
Add a Chinese (Simplified) translation. Fixes #1963
2016-11-16 09:45:22 +00:00
Khushboo Vashi
48b0a3f2d2
Ensure treeview collection nodes are translated in the UI. Fixes #1962
2016-11-16 09:25:38 +00:00
Daniel Hahler
c0da81e8ec
Fix upgrade check on Python 3. Fixes #1961
2016-11-16 09:13:59 +00:00
Khushboo Vashi
12d75e0a51
Styling improvements for password input fields in backgrid.
2016-11-15 09:55:32 +00:00
Dave Page
7ce04bbaea
Add missing translation tags.
2016-11-15 09:31:39 +00:00
Khushboo Vashi
83a1808bfd
Move some DOM elements out of the global context.
2016-11-14 13:13:58 +00:00
Dave Page
052a9fc840
Add missing strings from the dashboards.
2016-11-14 12:04:28 +00:00
Dave Page
74e5b5a492
Include SQL templates in the translation template.
2016-11-14 11:53:20 +00:00
Murtuza Zabuawala
00d2ab0338
Cast OIDs to oid not int, otherwise we lose half the range which results in objects not being accessible. Fixes #1951
2016-11-11 14:36:41 +00:00
Murtuza Zabuawala
6f30cabdbb
Resolve various debugger quirks. Fixes #1227
...
- Prevent the user from executing multiple options at once, resulting in "Execute cannot be used while an asynchronous query is underway********** Error ****" messages
- Stop polling when debugging is complete.
- Don't show the busy cursory when debugging is complete.
- Display info messages properly, and reset them between executions.
2016-11-11 14:25:11 +00:00
Murtuza Zabuawala
f405cdf383
Ensure trigger function names are schema qualified in trigger RE-SQL. Fixes #1949
2016-11-11 13:46:06 +00:00
Navnath Gadakh
7b574b284d
Fix TypeError.
2016-11-10 12:48:38 +00:00
Murtuza Zabuawala
36c909b1f9
Generate mSQL for new schemas correctly. Fixes #1937
2016-11-09 15:13:17 +00:00
Murtuza Zabuawala
c345adaa52
Properly format arguments passed by triggers to functions. Fixes #1912
2016-11-09 15:00:35 +00:00
Akshay Joshi
7da3ece169
Ensure all changes to rows are stored in the data editor. Fixes #1919
2016-11-07 15:07:43 +00:00
Dave Page
ca333ea6a7
Don't strip \r\n from "Download as CSV" batches of rows, as it leads to malformed data. Fixes #1936
2016-11-07 14:47:50 +00:00
Dave Page
8bb656c002
Translation catalog update.
2016-11-07 12:45:13 +00:00
Dave Page
f736051309
Handle broken config databases much more gracefully. Fixes #1922
2016-11-02 17:00:26 +02:00
Akshay Joshi
c2d9c0bb7c
Improve display of role options. Fixes #1729
2016-11-01 11:44:32 +02:00
Murtuza Zabuawala
a3622a380a
Fix display of exclusion contraint dependencies. Partially fixes #1892 - requires icon display fix.
2016-11-01 11:35:09 +02:00
Murtuza Zabuawala
ca57323ad1
Properly schema qualify domains when reverse engineering SQL. Fixes #1865
2016-10-28 16:45:06 +01:00
Murtuza Zabuawala
67e5dfa5a7
Fix refreshing of Unique constraints. Fixes #1893
2016-10-28 16:40:27 +01:00
Murtuza Zabuawala
8c48be3b0c
Properly quote role names when specifying function ownership. Fixes #1899
2016-10-28 16:18:31 +01:00
Dave Page
c1c2fb9df9
Ensure sequence start value is shown in SQL and properties list. Fixes #1155
2016-10-24 09:27:16 +01:00
Surinder Kumar
19bd021696
Ensure select2 instances have a destroy property before calling destroy.
2016-10-21 16:16:10 +01:00
Harshal Dhumal
2952faab5e
Fix exclusion constraint support on 9.6. Fixes #1875
2016-10-21 16:14:19 +01:00
Surinder Kumar
23a0fc2f22
Fix refreshing of FTS Dictionaries. Fixes #1837
2016-10-21 16:07:45 +01:00
Dave Page
ef0d26c294
Ensure steps and schedules can be created in empty jobs. Fixes #1878
2016-10-21 16:00:23 +01:00
Murtuza Zabuawala
e6d018c44f
Ensure we handle external processes that fail to start. Fixes #1679
2016-10-21 15:35:06 +01:00
Surinder Kumar
8e9108e0f3
Allow package bodies to be dropped. Fixes #1867
2016-10-21 15:24:11 +01:00
Khushboo Vashi
a97d21cc90
Ensure preferences values are stored properly. Fixes #1877
2016-10-21 15:06:45 +01:00
Khushboo Vashi
5a1795e4a0
Fix quoting of objects names for external utilities. Fixes #1603 , fixes #1220 , fixes #1221
2016-10-21 14:57:19 +01:00
Harshal Dhumal
aef508ff91
Properly quote type names in RE-SQL for tables. Fixes #1863
2016-10-21 14:43:57 +01:00
Surinder Kumar
da3a37ab19
Handle non-ascii responses from the server when connecting. Fixes #1822
2016-10-21 14:32:25 +01:00
Surinder Kumar
1e66119ef5
Ensure the File Manager honours the file type while traversing the directories. Fixes #1858
...
When a File Manager is closed by clicking cancel button. Its dom element not destroyed.. So on traversing into directories, when it tries to get currently selected file type, it looks into the dom element but it gets dom of previous dialogs not of currently dialog.
Now whenever an instance of File Manager is closed. its dom elements are also destroyed.
2016-10-21 14:26:12 +01:00
Surinder Kumar
406dab069d
Show security labels in the reverse engineered SQL for domains. Fixes #1574
2016-10-21 12:49:50 +01:00
Surinder Kumar
d806a9ce9e
Fix the file manager when used under Python 3. Fixes #1872
...
Issues fixed:
1) In Python 3, parameter "cmp" is removed from sorted method. So File Manager won't open.
As we are sorting data on JS side using Natural sort, so on server side sorting is not required.
2) Improvement in Exception handling.
2016-10-21 12:43:02 +01:00
Murtuza Zabuawala
d29ccea299
Don't allow setting of security labels on edbspl stored procedures (by correctly checking the node type). Fixes #1576
2016-10-21 12:37:47 +01:00
Navnath Gadakh
1908e86d22
Resolve a PG 9.6 compatibility issue in the regression test for Languages.
2016-10-21 12:24:26 +01:00
Surinder Kumar
48ee8490f0
Add new indexes to the correct parent on the treeview. Fixes #1880
2016-10-21 12:12:37 +01:00
Surinder Kumar
06039320b9
Don't specify ASC/DESC options for index types that don't support them. Fixes #1840
2016-10-21 12:08:41 +01:00
Harshal Dhumal
6874a1a247
Properly generate exclusion constraint SQL. Fixes #1861
2016-10-21 12:04:30 +01:00
Surinder Kumar
9155c2111f
Ensure the grant wizard works with objects with special characters in the name. Fixes #1599
2016-10-21 11:58:46 +01:00