Akshay Joshi
262dcdcf54
Added postion relative to show error message properly.
2021-12-24 17:37:59 +05:30
Akshay Joshi
74be3a9f52
Fixed linter error.
2021-12-24 16:52:32 +05:30
Aditya Toshniwal
5c65766ece
Added a common table MUI style object which can be used on any table.
...
Added a few more styling improvements.
2021-12-24 16:15:38 +05:30
Nikhil Mohite
45179ccb8c
Change logic for grant wizard, wizard component, and updated CSS.
2021-12-22 18:26:21 +05:30
Akshay Joshi
ebee7a5b72
Fixed linter errors.
2021-12-22 14:44:57 +05:30
Akshay Joshi
ae73f13812
Added beforeNext and beforeBack method in Wizard.
2021-12-22 14:25:08 +05:30
Akshay Joshi
02b83146be
1) Added spacing for message and loading spinner.
...
2) Rename the GrantWizard Dialog.
3) Return the activeStep from disableNextStep function.
2021-12-21 18:00:07 +05:30
Akshay Joshi
92a997b16a
Rearrange tools menu on the basis of usability and form groups of similar sub-menus.
2021-12-16 18:29:44 +05:30
Aditya Toshniwal
6875d00e44
Fixed an issue where confirmation pop-up is hidden behind Reassign/Drop Owned Dialog. Fixes #7071
2021-12-14 16:42:06 +05:30
Akshay Joshi
f24348b2b0
Fixed an issue where notifier not working when opening query tool in a new
...
window and then open it in the new tab.
2021-12-08 18:15:13 +05:30
Akshay Joshi
fd53e4f5f9
Replace Alertify alert and confirm with React-based model dialog. Fixes #7053
2021-12-07 18:52:40 +05:30
Aditya Toshniwal
dfdaf7f6d1
Implemented React based modal provider to create models on the fly.
...
Also, use this to replace Alertify alert and confirm dialog.
2021-12-03 12:50:24 +05:30
Ashesh Vashi
36c9eb3dfd
Added support for Two-factor authentication for improving security. Fixes #6543
2021-12-02 16:47:18 +05:30
Ganesh Jaybhay
e30cbe2579
Fixed some accessibility issues:
...
1) Focus is not visible while navigating through top navbar menu items(File, Object, Tools)
2) In preference dialog wherever access key is used for a shortcut declaration, unable to get out of the textbox.
3) Focus is not visible for the links on the dashboard
Fixes #7046
2021-12-02 16:24:55 +05:30
Akshay Joshi
c6424e3897
Replaced alertifyjs notifiers with React-based notistack. Fixes #7004
2021-12-02 16:05:52 +05:30
Nikhil Mohite
61b440261f
Ensure that sort order should be maintained when renaming a server group. Fixes #6955
2021-11-29 12:04:04 +05:30
Nikhil Mohite
3a30f27153
1. Updated notification message for the reset layout.
...
2. Added notification type in alertify which was missing.
refs #6988
2021-11-24 10:58:15 +05:30
Nikhil Mohite
3afeb8ca46
Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984
2021-11-22 11:20:44 +05:30
Nikhil Mohite
cc91e5da94
Fixed an issue where properties of the database should not be visible after removing the database.
...
Fixes #6964
2021-11-18 12:36:39 +05:30
Khushboo Vashi
cc38bc132e
Fixed scroll issue in the browser tree when navigating using the keyboard.
2021-11-15 18:26:16 +05:30
Yogesh Mahajan
e2e5a8208c
1) Fixed an issue where JSON editor preview colours have inappropriate contrast in dark mode. Fixes #6944
...
2) Fixed JSON Editor scrolling issue in code mode. Fixes #6945
2021-11-15 10:58:17 +05:30
Khushboo Vashi
aff84103d9
Fixed an issue where database nodes are not getting loaded behind a reverse
...
proxy with SSL. Fixes #6905
2021-11-10 11:47:40 +05:30
Pradip Parkale
a61a9e5b8f
Fixed an issue where older server group name displayed in the confirmation
...
pop-up when the user removes server group. Fixes #6939
2021-11-10 11:17:51 +05:30
Aditya Toshniwal
1ed4d0f95e
Fixed an issue where textarea should be allowed to resize and have more than 255 chars. Fixes #6976
2021-11-07 10:51:54 +05:30
Akshay Joshi
39992a817d
Added support of Aggregate and Operator node in view-only mode. Fixes #3834
2021-10-29 16:14:33 +05:30
Aditya Toshniwal
a2f5e6ad8f
Fixed an issue where the wrong SQL is generated when deleting and renaming table columns together. Fixes #6935
2021-10-19 17:13:12 +05:30
Khushboo Vashi
9e3165c0ff
1) Ensure that the master password should be prompt when MASTER_PASSWORD_REQUIRED
...
is set to True and AUTHENTICATION_SOURCES is the webserver. Fixes #6928
2) Fixed an issue where the existing server group is disappeared on rename it. Fixes #6930
2021-10-19 11:56:44 +05:30
Khushboo Vashi
a908ef7c61
Fixed browser tree sort order regression issue. Fixes #6912
2021-10-16 12:54:44 +05:30
Aditya Toshniwal
7f3c3fa6f9
Added support to allow tables to be dragged to ERD Tool. Fixes #6241
2021-10-16 12:43:39 +05:30
Nikhil Mohite
476d7c5fc9
Fixed background colour issue in the browser tree. Fixes #6890
2021-10-16 12:40:57 +05:30
Khushboo Vashi
2aac87569b
Fixed an issue where the users are unable to load the databases behind an HTTP reverse proxy. Fixes #6905
2021-10-14 11:35:11 +05:30
Aditya Toshniwal
9ace229152
Fixed an issue where exclusion constraint cannot be created from table dialog
...
if the access method name is changed once. Fixes #6900
2021-10-13 11:35:19 +05:30
Nikhil Mohite
5b9383c880
Fixed an issue where the user is unable to create an index with concurrently keyword. Fixes #6790
2021-10-12 18:19:40 +05:30
Khushboo Vashi
ac6c6fbf97
Fixed an issue where the browser tree doesn't show all contents on changing resolution. Fixes #6881
2021-10-12 15:02:46 +05:30
Khushboo Vashi
ca40add29b
Ensure that columns should be displayed in the order of creation instead of alphabetical order in the browser tree. Fixes #6882
2021-10-12 14:37:06 +05:30
Aditya Toshniwal
a92c1b43a2
1) Added support for advanced table fields like the foreign key, primary key in the ERD tool. Fixes #6081
...
2) Added index creation when generating SQL in the ERD tool. Fixes #6529
2021-10-11 17:42:14 +05:30
Khushboo Vashi
9796f50362
Fixed an issue where the tree is not scrolling to the object selected from the search result. Fixes #6828
2021-10-07 17:23:21 +05:30
Nikhil Mohite
ea706be7fc
Fixed the issue related to the privilege checkbox color in disabled mode.
2021-10-05 14:38:00 +05:30
Aditya Toshniwal
400896c563
1. Operators dropdown disabled. Fixes #6771 .
...
2. Vacuum options value is not considered for M-SQL when creating. Fixes #6781 .
2021-10-05 14:13:15 +05:30
Nikhil Mohite
40b8da8223
Fixed theme related issues after react porting.
2021-10-04 18:00:09 +05:30
Khushboo Vashi
8faec3e0e9
Fixed loading issue of Partitions collection node. Fixes #6844
2021-10-04 16:15:49 +05:30
Aditya Toshniwal
038fd6ce21
Fixed Dark theme UI related issues. Fixes #6846
2021-10-04 12:41:48 +05:30
Khushboo Vashi
44e1a405f0
1) Newly added server/server group is not visible in the tree unless pgAdmin is refreshed. Fixes #6839
...
2) Internal server error displayed if disconnect the server. Fixes #6852
2021-10-03 12:12:02 +05:30
Nikhil Mohite
5f9bb1c160
Correct the implementation of query details should be scrollable as per design.
...
Fixes #3827
2021-10-01 13:01:24 +05:30
Aditya Toshniwal
357a020828
Table node related fixes:
...
1. File select control sets the value for all other to last selected file. Fixes #6814
2. Vacuum parameters-related issues. Fixes #6777
3. Exclusion removes all columns if one row is removed. Fixes #6771
2021-10-01 12:57:04 +05:30
Khushboo Vashi
5e0c113c7b
Properties panel is not updated when any object is added/deleted from the browser tree. Fixes #6833
2021-09-30 18:21:43 +05:30
Nikhil Mohite
1a25fdffbb
Ensure that the 'When' field should be read-only in the properties panel. Fixes #6836
2021-09-30 16:25:27 +05:30
Aditya Toshniwal
381f5edbd5
Few more stability improvements to date time picker.
...
refs #6816
2021-09-30 15:00:32 +05:30
Nikhil Mohite
3da85f415d
Fixed an issue while saving grant wizard data with user-defined functions. Fixes #6826
2021-09-30 10:56:51 +05:30
Akshay Joshi
1b6ab6b3bb
1) Fixed pgAgent related issues. Fixes #6827
...
2) Added helpMessageMode parameter to hide help messages from properties panel.
2021-09-29 19:48:43 +05:30
Khushboo Vashi
aa8854db53
1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817
...
2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821
3) Object gets deselected after editing. Fixes #6824
2021-09-29 17:18:55 +05:30
Aditya Toshniwal
332351efaf
1. Date time control not working on firefox.
...
2. Replace moment with date-fns in date time control as date-fns is more maintained.
Fixes #6816
2021-09-29 13:43:05 +05:30
Rahul Shirsat
77d0409c5b
Fixed an issue where the user was not able to expand the server's on Windows. Fixes #6822
2021-09-29 13:35:54 +05:30
Akshay Joshi
7d07770244
Reverting 'Two-factor authentication' support as it cause OSX and docker build failures.
...
This reverts commit 787a441343
.
2021-09-29 13:24:18 +05:30
Aditya Toshniwal
08706ba6b2
1. Make Unlogged switch in table as read only.
...
2. Fix a console warning when saving node data.
Fixes #6778
2021-09-28 17:48:09 +05:30
Ashesh Vashi
787a441343
Added support for Two-factor authentication for improving security. Fixes #6543
2021-09-28 17:47:00 +05:30
Khushboo Vashi
31c7f3eaba
Fixed an error in browser tree when adding any node.
2021-09-28 15:08:59 +05:30
Aditya Toshniwal
be69470d55
Server and Database node fixes:
...
1. Unable to change shared server switch.
2. DB restriction and schema restriction have an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then an empty value error should not come.
5. Values for parameters should be reset on changing parameters.
6. Added a new key - helpMessageMode which can have a value similar to mode. It will show the help message if the mode is supported.
Fixes #6814
2021-09-28 15:05:32 +05:30
Khushboo Vashi
7b6101bc6d
Fixed 'Save' button issue where dialog is not getting closed.
2021-09-28 15:04:37 +05:30
Aditya Toshniwal
dc8ab7cd2a
1. Switch control and CodeMirror control UI improvements for read-only and disabled states.
...
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
2021-09-28 10:24:25 +05:30
Khushboo Vashi
483e2ca8d0
Port browser tree to React. Fixes #6129
2021-09-27 16:44:26 +05:30
Aditya Toshniwal
0228d16990
Partition related fixes:
...
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.
Fixes #6783
2021-09-24 16:28:55 +05:30
Aditya Toshniwal
d28f8bc7ee
Fixed exclusion constraint issues:
...
1. Incorrect error message.
2. Properties panel Column Section data missing
3. Operator class value is missing
Fixes #6771
2021-09-23 19:28:35 +05:30
Akshay Joshi
8125320093
Fixed linter error.
2021-09-23 17:12:34 +05:30
Akshay Joshi
ecaaa8a1b5
Fixed scrollbar issue and used flex layout in grant wizard.
2021-09-23 16:59:59 +05:30
Akshay Joshi
b9bc628189
1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...'
...
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
2021-09-23 16:17:39 +05:30
Aditya Toshniwal
9179b7464b
Fixed following issues after React Porting:
...
1. Unique constraint should not allow changing values for deferrable, deferred, included columns.
2. Primary keys should not allow changing values for deferrable, deferred, included columns.
3. Foreign keys should not allow changing match type. The referenced table name is empty.
4. Exclude - Column/Expression has incorrect values.
5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited.
Fixes #6777
2021-09-23 14:46:10 +05:30
Nikhil Mohite
15a494c189
Fixed review comments for Grant Wizard.
...
refs #6687
2021-09-23 14:40:38 +05:30
Aditya Toshniwal
78c8fbbe00
Fixed an issue where the Properties panel was not loaded for catalog tables. Fixes #6778
2021-09-23 10:42:50 +05:30
Aditya Toshniwal
a1aa080956
Fixed an issue where unable to change the column properties from edit dialog. Fixes #6766
2021-09-22 18:23:40 +05:30
Aditya Toshniwal
a8c8ea69e3
Foreign Key fixes:
...
1. Auto FK related fixes.
2. Properties tab not showing columns.
3. Toggle button is editable even if set to read-only.
4. Dropdown placeholder should be blank for read-only/disabled.
5. Input control help text color on a dark theme.
Fixes #6770
2021-09-22 18:18:09 +05:30
Aditya Toshniwal
fc86faf51e
Changed the layout for tables from block layout to flex layout to fix the width of the columns as per the dialog size.
2021-09-22 18:11:50 +05:30
Akshay Joshi
71d7b14320
Remove unused files.
2021-09-22 13:12:46 +05:30
Akshay Joshi
6b100b60f8
Remove word break for dialog labels.
2021-09-21 17:15:53 +05:30
Aditya Toshniwal
08009f8edc
1) Make default values column read-only for inherited columns when creating table.
...
2) Default values not populated for inherited columns. The existing issue, API changed.
3) Options are not populated for Name in Column > Variable tab.
4) The empty check error message is changed from Label cannot be empty to Label in Collection cannot be empty for collections.
Fixes #6763
2021-09-21 16:56:29 +05:30
Nikhil Mohite
d27b4831d6
Fixed the issue where password field is showing as plain text.
2021-09-20 13:05:58 +05:30
Rahul Shirsat
55e7e481d4
Fixed an issue where collapse and expand arrows mismatch in case of nested IF. Fixes #6712
2021-09-09 16:04:59 +05:30
Aditya Toshniwal
f874276d0f
Added some missing propTypes.
2021-09-09 15:57:17 +05:30
Akshay Joshi
eeff75ba20
Remove GPDB support completely. Fixes #6692
2021-09-09 13:09:53 +05:30
Aditya Toshniwal
f7b8969c72
Stability and bug fixes for the react schema view framework.
2021-09-09 13:09:53 +05:30
Aditya Toshniwal
af27af8d42
Integer and Numeric inputs fixes.
2021-09-09 13:09:44 +05:30
Aditya Toshniwal
73e1cbc0b9
Change the parse changes logic to get changes at any level of depth.
2021-09-09 13:09:42 +05:30
Aditya Toshniwal
d62fba024b
- Focus on first tab and first element on reset. - Move formErr to state context.
2021-09-09 13:09:42 +05:30
Aditya Toshniwal
ae49b556ce
- Properties tab should refresh if node is updated. - Error should be hierarchical and not just id based.
2021-09-09 13:09:41 +05:30
Aditya Toshniwal
2a76027cce
- Fix codemirror cursor issue. - Fix foreign table jasmine test cases.
2021-09-09 13:09:30 +05:30
Aditya Toshniwal
c02705c53c
- Fix all the jasmine test case failures. - Show default value column in Table->Columns grid. Fixes #4353 .
2021-09-09 13:06:24 +05:30
Aditya Toshniwal
27e446a0b0
Fixed following: - Dropdown selected menu color - CodeMirror render on properties tab - Placeholders on select control - Codemirror borders
2021-09-09 13:06:24 +05:30
Akshay Joshi
4bfffa3806
Port FTS Configurations node to react. Fixes #6638
2021-09-09 13:06:24 +05:30
Aditya Toshniwal
261cec1d20
Port Table, Column, Primary key, Foreign key, Check constraint, Unique constraint, Exclusion constraint.
2021-09-09 13:05:57 +05:30
Rahul Shirsat
725d9b4bbf
Port package and it’s child node to React. Fixes #6675
2021-09-09 13:04:42 +05:30
Akshay Joshi
b7105093e2
1) Port Compound Trigger node to react. Fixes #6674 2) Remove 'inSchema' method and create a generic method 'inCatalog'.
2021-09-09 13:03:54 +05:30
Aditya Toshniwal
9274df0f11
- Fix Jasmine test cases failing in framework. - More stability fixes and enhancements.
2021-09-09 13:03:54 +05:30
Nikhil Mohite
351cb3e6ca
Port Triggers node to react. Fixes #6672
2021-09-09 13:03:54 +05:30
Aditya Toshniwal
bb5e2b98e9
Stability and bug fixes in schemaview react framework.
2021-09-09 13:03:54 +05:30
Akshay Joshi
1b7a77f5cb
Port pgAgent and it's child nodes to react. Fixes #6645
2021-09-09 13:03:54 +05:30
Aditya Toshniwal
1ce6c2aee1
Add the plain string component forgot last time.
2021-09-09 13:03:54 +05:30
Aditya Toshniwal
314fcabbeb
Add plain string control with formatter.
2021-09-09 13:03:54 +05:30
Aditya Toshniwal
0ddd053e88
Framework stability fixes.
2021-09-09 13:03:54 +05:30
Aditya Toshniwal
9bfef1f6e5
- Add feature to allow collection header form using CustomControl. - Framework stability and bug fixes.
2021-09-09 13:03:38 +05:30
Rahul Shirsat
08f2121544
Port Schema & Catalog node to react. Fixes #6655
2021-09-09 13:01:53 +05:30
Pradip Parkale
1f430227aa
Port Subscriptions node to react. Fixes #6634
2021-09-09 13:01:52 +05:30
Akshay Joshi
8dac933a66
Fixed linter error in DateTimePicker control.
2021-09-09 13:01:18 +05:30
Rahul Shirsat
1e07ef13cf
Port Types node to react. Fixes #6602
2021-09-09 13:01:18 +05:30
Akshay Joshi
56ef085412
Added DateTimePicker control in React.
2021-09-09 13:00:36 +05:30
Aditya Toshniwal
bcab0e3754
- Fix jasmine test cases. - Unregister listener when row removed in DataGrid.
2021-09-09 13:00:36 +05:30
Aditya Toshniwal
f6ac0d5877
Handle null in note.
2021-09-09 13:00:33 +05:30
Aditya Toshniwal
1810d810d8
Few more UI changes for Note.
2021-09-09 13:00:33 +05:30
Aditya Toshniwal
82ca5145c2
Add the note control.
2021-09-09 13:00:33 +05:30
Aditya Toshniwal
377fe80046
- Add VaccumSettings schema. - Allow collection to have fixed rows. - Changes in data change comparison and add state utils context. - Fixed jasmine test cases.
2021-09-09 13:00:33 +05:30
Akshay Joshi
eb48765a5a
1) Fixed 'Material-UI: You are providing a disabled `button` child to the Tooltip' 2) Fixed InputToggle value issue. 3) Fixed jasmine test for Language. 4) Remove unused code from the view node.
2021-09-09 13:00:03 +05:30
Aditya Toshniwal
09db3ddd5c
Use isFullTab instead of noLabel for full space code field spec.
2021-09-09 13:00:03 +05:30
Nikhil Mohite
d9cfbf592e
Port View node to react. Fixes #6637
2021-09-09 12:59:26 +05:30
Akshay Joshi
6d18842dd3
Port Domain and Domain Constraints node to react. Fixes #6330
2021-09-09 12:59:26 +05:30
Pradip Parkale
c474ca2c5f
Port Publications node to react. Fixes #6610
2021-09-09 12:55:56 +05:30
Akshay Joshi
be04bea2b6
Port Resource Group node to react. Fixes #6629
2021-09-09 12:55:56 +05:30
Aditya Toshniwal
5db72a6916
- Some UI changes based on review comments. - Fix the numeric type.
2021-09-09 12:55:56 +05:30
Aditya Toshniwal
453f26817a
Check if type is string for nested type changes parsing.
2021-09-09 12:55:55 +05:30
Aditya Toshniwal
51c11a21fa
Fieldset changes should be included. Fix linter errors.
2021-09-09 12:54:25 +05:30
Aditya Toshniwal
cd9e37bac5
Fix typo in fieldsetview also.
2021-09-09 12:54:25 +05:30
Aditya Toshniwal
3d7450b308
- Fix typo modeSupported. - Add support for collection conditional visibility.
2021-09-09 12:54:25 +05:30
Aditya Toshniwal
48176ea986
Add support for nested-fieldset control.
2021-09-09 12:54:25 +05:30
Pradip Parkale
621426ac55
Port Language node to react. Fixes #6581
2021-09-09 12:52:54 +05:30
Aditya Toshniwal
5d8eeba0dd
Fix linter issues in previous commit.
2021-09-09 12:50:32 +05:30
Aditya Toshniwal
a06f78b2d5
- Introduce deps listener context and move the old code. - Add support for deffered deps change - deferredDepChange. - Changes for canEditRow and canDeleteRow. - Select the tab again on visible if it is rendered when hidden. - It is helpful to show the error footer in SQL tab also. - Fix isEmptyString.
2021-09-09 12:50:32 +05:30
Akshay Joshi
5c1ce23780
Port Synonyms node to react. Fixes #6599
2021-09-09 12:50:32 +05:30
Akshay Joshi
4b8e655948
Port Foreign Data Wrapper, Foreign Server and User Mapping nodes to react. Fixes #6583
2021-09-09 12:48:24 +05:30
Aditya Toshniwal
79e1b0c5d8
Added field key - optionsReloadBasis to allow options to be re-loaded. Add formatters to select and input control.
2021-09-09 12:44:37 +05:30
Aditya Toshniwal
de3f3e6e61
Fix jasmine test case failures in SchemaView.
2021-09-09 12:44:37 +05:30
Nikhil Mohite
793dbc6e7f
Port Event Triggers node to react. Fixes #6578
2021-09-09 12:44:37 +05:30
Aditya Toshniwal
bd5536dbf9
Fix linter errors in previous commit.
2021-09-09 12:27:42 +05:30
Aditya Toshniwal
6b9e8c3039
Fixes for expanded table row form control.
2021-09-09 12:27:42 +05:30
Aditya Toshniwal
9d33b03be9
Few more changes to core schema framework required by other nodes.
2021-09-09 12:22:05 +05:30
Akshay Joshi
351928a1e0
Fixed minor issue with merging
2021-09-09 12:20:59 +05:30
Aditya Toshniwal
b20558cb99
Some changes to the core code that will be helpful for other nodes.
2021-09-09 12:20:59 +05:30
Aditya Toshniwal
764677431f
Added React framework for the properties dialog and port Server Group, Server, and Database dialogs.
...
Following changes done for the framework:
- Framework for creating React based dynamic form view out of a pre-defined UI schema. Previously, it was based on Backform/Backbone.
- The new framework and components will use MaterialUI as the base. Previously, Bootstrap/Backform/jQuery components were used.
- The new code uses JSS instead of CSS since material UI and most modern React libraries also use JSS. In the future, this will allow us to change the theme in real-time without refresh.
- 90% code covered by 80-85 new jasmine test cases.
- Server group node UI Schema migration to new, with schema test cases.
- Server node UI Schema migration to new, with schema test cases.
- Database node UI Schema migration to new, with schema test cases.
- Few other UI changes.
Fixes #6130
2021-09-09 12:20:59 +05:30
Nikhil Mohite
22f20a38ec
Fixed an issue where the user can not paste the updated table header in safari 12 and 13 browsers. Fixes #4815
2021-08-30 14:46:42 +05:30
Yogesh Mahajan
51d73b1672
Fixed errors related to HTML tags shown in the error message for JSON editor. Fixes #6668
2021-08-26 14:54:51 +05:30
Yogesh Mahajan
c7fd1ae535
Enables pgAdmin to retrieve user permissions in case of nested roles which helps to terminate the session for AWS RDS. Fixes #6641
2021-08-24 17:01:06 +05:30
Aditya Toshniwal
c64eb3507c
Make code folding case insensitive in the code mirror. Fixes #4264
2021-08-23 16:16:20 +05:30
Yogesh Mahajan
1b33c52eac
Fixed the JSON editor issue of hiding the first record. Fixes #6684
2021-08-20 13:47:31 +05:30
Yogesh Mahajan
dc4f59e664
Handle null values more correctly.
...
refs #5198
2021-08-09 20:11:39 +05:30
Yogesh Mahajan
8e214ca8fb
Added support for formatted JSON viewer/editor when interacting with data in a JSON column. Fixes #5198
2021-08-03 11:36:45 +05:30
Akshay Joshi
508f97b08e
Rename the "Resize by data?" to "Columns sized by" and disabled the 'Maximum column width'
...
button if 'Columns sized by' is set to 'Column data'. Fixes #6622
2021-07-27 15:17:06 +05:30
Akshay Joshi
ef67409d61
Highlighted long running queries on the dashboards. Fixes #1975
2021-07-01 18:10:55 +05:30
Dave Page
d90472014d
Remove leading whitespace and replace it with '[...] ' in the Query Tool data grid so cells don't look empty.
...
Fixes #6427
2021-07-01 09:17:35 +01:00
Akshay Joshi
e68c8305a2
Added option to provide maximum width of the column when 'Resize by data?’ option in the preferences is set to True. Fixes #6559
2021-06-28 11:51:21 +05:30
Pradip Parkale
5581f0909a
Fixed an issue where Debugger and ERD tool panel give a blank white panel, missing from the last patch.
...
refs #6398
2021-06-25 11:38:02 +05:30
Libor M
cc989c5c08
Added missing gettexts and text space improvements.
2021-06-24 11:15:50 +05:30
Nikhil Mohite
2adb29ffc0
Fixed an issue where the New Connection Drop Down has lost default maintenance database, auto-select, and tab-through functionality. Fixes #6505
2021-06-23 12:48:17 +05:30
Nikhil Mohite
a533620684
Fixed an issue where Execute/Refresh button should not be disabled when we run the empty query. Fixes #6489
2021-06-23 11:49:40 +05:30
Akshay Joshi
16d2a3096a
1) Fixed an issue where the binary path is not correctly parsed for version 9.6. Fixes #6534
...
2) Added the default binary path in the container.
3) Fixed the typo in the documentation.
2021-06-15 19:49:46 +05:30
Nikhil Mohite
71526ac79f
Ensure that the calendar control should be disabled in the properties panel for Role. Fixes #6469 .
2021-06-14 16:59:04 +05:30
Akshay Joshi
c86a2b643a
1) Binary path set to the default location in which we install the binaries.
...
2) Validate path not working if there is a space in the binary path.
3) Handle the case when the path contains '$DIR'.
refs #5370
2021-06-10 22:49:05 +05:30
Nikhil Mohite
e1067ffe67
Ensure that the Query Tool connection string should not be changed as per the 'Query Tool tab title'. Fixes #6404
2021-06-07 22:07:51 +05:30
Akshay Joshi
07eb541806
1) Added logic to set the appropriate default binary path if DEFAULT_BINARY_PATH is
...
set in the config and the user not updated the preferences.
2) Remove 'gpdb' from DEFAULT_BINARY_PATH.
3) Fixed API test cases.
refs #5370
2021-06-07 20:36:34 +05:30
Akshay Joshi
4bc4ca1ba9
1) Added browse button to select the binary path in the Preferences. Fixes #1561
...
2) Added support to set the binary path for the different database server versions. Fixes #5370
2021-06-04 17:55:35 +05:30
Rahul Shirsat
658a2de619
Fixed the issue of renaming the database by another user. Fixes #4203
2021-05-31 12:41:09 +05:30
Ashesh Vashi
a487a51135
Fixes SonarQube issues.
2021-05-29 12:55:59 +05:30
huangj.fnst@fujitsu.com
fe6f9aae61
Fix a number of typos.
2021-05-11 11:16:38 +01:00
Akshay Joshi
d80087f6d5
Added support to set auto width of columns by content size in the data output window. Fixes #5954
2021-05-07 17:18:50 +05:30
Pradip Parkale
333a22496c
Fixed an issue where drag and drop object is not correct in codemirror for properties dialog. Fixes #4436
2021-04-29 13:19:36 +05:30
Aditya Toshniwal
2b1910c1c1
Better fix for the black screen issues, reverted the old fix.
...
refs #6334
2021-04-16 18:23:29 +05:30
Yogesh Mahajan
9853d8bfd6
Fixed an issue while selecting the row which was deleted just before the selection operation. Fixes #6306
2021-04-12 11:45:04 +05:30
Rahul Shirsat
49095ccba6
1) Fixed an issue where shortcut keys are not working with manage macro. Fixes #5908
...
2) Fixed an issue where the cursor shifts its focus to the wrong window for all the query tool related model dialogs. Fixes #6161
2021-04-09 12:41:13 +05:30
Yogesh Mahajan
14dcb70b95
Ensure that the user should not be to change the connection when a long query is running. Fixes #6082
2021-04-08 18:09:13 +05:30
Aditya Toshniwal
c88a63edf8
Included JSX files in the linter check.
2021-04-08 17:56:18 +05:30
Pradip Parkale
566f03beca
Ensure that the query tool tab should be closed after server disconnection when auto-commit/auto-rollback is set to false. Fixes #5519
2021-04-01 11:58:59 +05:30
Nikhil Mohite
be31fb08f1
Fix following scroll bar issues:
...
1) Stop overwriting the text in the scroll bar area.
2) Make scroll bars functional.
2021-03-23 19:17:01 +05:30
Akshay Joshi
723d97971d
1) Ensure that SQL formatter should not add extra tabs and format the SQL correctly. Fixes #5869
...
2) Ensure that SQL formatter should not use tab size if 'Use spaces?' set to false. Fixes #6233
2021-03-22 14:47:19 +05:30
Khushboo Vashi
b973d6055d
Ensure that toggle buttons are accessible by most screen readers. Fixes #6317
2021-03-19 11:44:57 +05:30
Nikhil Mohite
9395ce3fda
Fixed an issue where copy/paste rows in view data paste the wrong value for boolean type. Fixes #6312
2021-03-16 11:29:47 +05:30
Nikhil Mohite
8031961205
Fixed alignment issue under preferences for the German language. Fixes #4014
2021-03-12 13:33:04 +05:30
Nikhil Mohite
778e0cd402
Ensure that cell content being autoselected when editing the cell data. Fixes #5810
2021-03-04 13:53:23 +05:30
Akshay Joshi
008bc6da28
Fixed some SonarQube issues.
2021-03-02 14:53:05 +05:30
Nikhil Mohite
cb5d7190c4
Fixed SonarQube issues.
2021-03-01 18:00:06 +05:30
Pradip Parkale
731ba32e81
1) Added SSL support for creating a subscription. Fixes #6201
...
2) Fixed an issue where the user is not able to create the subscription. Fixes #6230
3) Fixed a couple of issues raised during testing of logical replication.
2021-02-19 14:56:45 +05:30
Nikhil Mohite
f65eb546b7
Fixed codemirror black screen issue on OSX.
2021-02-19 11:14:49 +05:30
Pradip Parkale
44cc7a308a
Added publication and subscription support in Schema Diff. Fixes #6153
2021-02-15 16:05:40 +05:30
Aditya Toshniwal
1317e4254b
Updated the JS dependencies to the latest
...
1) Migrate from webpack 4 to webpack 5. This had a lot of breaking changes,
so updated multiple webpack plugins and changed the config accordingly.
2) Replaced iconfont-webpack-plugin with a more maintained webfonts-loader.
3) Replaced deprecated babel-eslint with @babel/eslint-parser.
4) Replaced optimize-css-assets-webpack-plugin with a more maintained css-minimizer-webpack-plugin.
5) Updated all other JS packages and made the required code changes.
Fixes #6207
2021-02-10 12:47:52 +05:30
Nikhil Mohite
85b40ee4f0
Fixed an issue where the user unable to change the background color for a server. Fixes #6178
2021-02-05 14:15:37 +05:30
Nikhil Mohite
02c3863e8c
Fixed an issue where shared server entries not getting deleted from SQLite database if the user gets deleted. Fixes #6143
2021-02-04 11:31:39 +05:30
Pramod Ahire
b948f43dda
Added Quick Search functionality for menu items and help articles. Fixes #6148
2021-02-02 14:47:58 +05:30
Pradip Parkale
bf56a6723b
Added support for Logical Replication. Fixes #5912
2021-02-01 15:12:43 +05:30
Aditya Toshniwal
13db981445
Fixed following issues in ERD:
...
1) After opening an existing project, the first table is already selected but the edit, clone, delete buttons are disabled.
2) ERD project title gets changed when 2 ERD projects are open & anyone of it edited.
3) Closing the ERD tab does not ask for a confirmation pop-up.
4) Shortcut for 'Show more/Fewer details' is missing.
5) Deleting the primary key does not delete associated links.
6) The long table & schema name are getting out of the box.
7) The long table name in the notes pop-up needs re-alignment.
8) The same table name present in ERD/canvas is allowed in Add Table dialogue. Added validation in the dialog.
9) Download image option is added, but it is not perfect yet. Image icons (table, schema, etc.) are not showing up.
10) Rename panel option should be disabled by default. It should be enabled for the tools which implement rename functionality.
11) The Toolbar is not visible in Safari for the ERD tool.
refs #1802
2021-01-25 17:32:56 +05:30
Khushboo Vashi
9bee91b6f6
1) Fixed an issue where the Save button is enabled by default in Macro. Fixes #5905
...
2) Remove extra line after Manage Macros menu while clearing all macros. Fixes #5906
3) Ensure that 'Clear All Rows' should not work if there is no existing macro available and the user does not specify any value. Fixes #5907
4) Fixed an issue where the server is disconnected error message displayed if the user creates Macro with invalid SQL. Fixes #5929
2021-01-20 13:52:00 +05:30
Aditya Toshniwal
0c8226ff39
Added ERD Diagram support with basic table fields, primary key, foreign key, and DDL SQL generation. Fixes #1802
2021-01-16 17:06:50 +05:30
Nikhil Mohite
a2edf317a9
Ensure that the user should be able to specify an older date for the account expiration of the role/user. Fixes #6120
2021-01-15 11:38:08 +05:30
Akshay Joshi
b372f08a59
Update copyright notices for 2021
2021-01-04 15:34:45 +05:30
Aditya Toshniwal
5448de2d3f
Added support for expression in exclusion constraints. Fixes #5571
2020-12-24 12:50:57 +05:30
Nikhil Mohite
c933771016
Fixed accessibility issues in schema diff module. Fixes #6065
2020-12-23 12:57:16 +05:30
Rahul Shirsat
6475a70514
Ensure that the macro query result should be download properly. Fixes #5965
2020-12-14 11:58:53 +05:30
Nikhil Mohite
5370bb4515
Added the appropriate server icon based on the server type in the new connection dialog. Fixes #5983
2020-11-12 17:52:54 +05:30
Rahul Shirsat
183c83f0d2
Fixed an issue where the validation error message is shown twice. Fixes #5736
2020-10-30 14:59:22 +05:30
Nikhil Mohite
6c723a7e43
Fixed an issue where connection to the server is on wait state if a different user is provided. Fixes #5953
2020-10-28 12:32:22 +05:30
Nikhil Mohite
b5f9fffadd
Fixed the following issues:
...
RM-4232:
1. If the user adds a percentage (other than for placeholders) then it is stripped off.
2. Backslash is getting removed in the connection string if we provide the backslash(\) in placeholders or the database name contains it.
3. If the user added only spaces( )in placeholders it is not getting reset to default values.
RM-4230:
1. Rename panel option is not working in the debugger.
2. Added Rename panel for schema diff.
Fixes #4232 #4230
2020-10-27 11:03:00 +05:30
Pradip Parkale
7573fac29f
Ensure that query history should be listed by date/time in descending order. Fixes #5842
2020-10-23 15:06:56 +05:30
Nikhil Mohite
275d13d40f
Following issues have been resolved for the new connection feature:
...
1. Show servers with server groups in the dropdown.
2. Highlighted current selected connection in the new connection dropdown.
3. Notify the user before changing the connection.
refs #3794
2020-10-21 17:14:59 +05:30
Nikhil Mohite
18cad32bd4
Added tab title placeholder for Query Tool, View/Edit Data, and Debugger. Fixes #4232
2020-10-20 15:41:54 +05:30
Nikhil Mohite
2b7e3ce64e
Fixed an issue on a new connection when the server is disconnected and we are trying to connect it using the new connection model.
2020-10-12 17:14:42 +05:30
Khushboo Vashi
49b139bb75
Added escape and unescape for the strings used in query tool and new connection support. Fixes #5899 .
2020-10-12 16:20:33 +05:30
Khushboo Vashi
f4d6290b50
Update the macro help link.
2020-10-09 11:52:46 +05:30
Nikhil Mohite
1c796720be
Fixed the following issues for RM 3794:
...
1. Updated connection success message. (Added database name in the success message.)
2. Resolve issue of the mouse pointer and dropdown will show below the connection string only.
3. Added loader for both new connections and load existing connections.
4. Removed async: false for update connection.
refs #3794
2020-10-08 11:38:05 +05:30
Murtuza Zabuawala
483eeeca39
Added gettext and escape around Macro name and label. Fixes #5894
2020-10-08 11:23:45 +05:30
Nikhil Mohite
be7bb81a19
Allow user to change the database connection from an open query tool tab. Fixes #3794
2020-10-01 13:29:46 +05:30
Khushboo Vashi
4616a74029
Added Macro support. Fixes #1402
2020-09-28 15:26:45 +05:30
Aditya Toshniwal
95a5b1e459
Some more accessibility fixes.
...
refs #5732
2020-09-17 20:16:38 +05:30
Pradip Parkale
8e132eab08
Fixed some accessibility issues. Fixes #5732
2020-09-15 13:03:18 +05:30
Rahul Shirsat
62e6848dc8
1) Added tooltip & keyboard shortcut for the query tool button.
...
2) Fixed TypeError issue.
refs #4059
2020-09-09 19:32:33 +05:30
Aditya Toshniwal
f8f00b4ecf
Fixed an issue in the query tool when columns are having the same name as javascript object internal functions. Fixes #5765 .
2020-09-07 18:10:27 +05:30
Akshay Joshi
ddf5b33219
Added exclamation icon to alertify warning messages.
2020-09-02 17:27:26 +05:30
Neel Patel
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
Akshay Joshi
dd6ae193ff
Replace 'fa-clock-o' with 'fa-clock' which is appropriate for font awesome v5
2020-08-21 13:44:29 +05:30
Dave Page
79e6480513
Added SQL Formatter support in Query Tool. Fixes #2042
2020-08-20 13:05:00 +05:30
Akshay Joshi
8f61944386
1) Added special handling for the extension to resolve the dependency.
...
2) Added 'is_sys_obj' to the ignore list of Schema Diff.
3) Font awesome v5 fixes.
2020-08-13 17:48:04 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Aditya Toshniwal
26a758a0d6
Fixed an issue where copying and pasting a cell with multiple line data
...
will result in multiple rows. Fixes #5526
Fixed an old issue where quotes are not escaped when copying the cells.
As per CSV standards, if the string is in double quotes and there are
double quotes inside the string then they should be escaped with extra double-quotes.
2020-08-10 16:53:32 +05:30
Aditya Toshniwal
f715373218
Replace charting library Flotr2 with ChartJS using React. Fixes #3904
2020-07-29 14:49:22 +05:30
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Aditya Toshniwal
9d0f3ce90b
Fixed code smell 'potential hiding of variables declared in an outer scope'.
2020-07-16 19:53:39 +05:30
Satish V
522ddad72b
Fixed code smell 'Variables should not be shadowed'.
2020-07-15 15:03:47 +05:30
Aditya Toshniwal
161c9b0fc7
Fixed code smell 'Variables should not be shadowed'.
...
Fixed all the duplicate CSS blocks issues raised by SonarQube.
2020-07-14 15:45:01 +05:30
Yogesh Mahajan
776bec0d82
Fixed following SoanrQube issues:
...
1) Variables should not be shadowed.
2) Variables and functions should not be redeclared.
2020-07-07 16:25:46 +05:30
Yogesh Mahajan
80ab596992
Fixed the SoanrQube code smell 'Variables should not be shadowed'.
2020-07-03 14:33:30 +05:30
Aditya Toshniwal
341c3aded6
Fixed dark theme-related CSS and modify the color codes. Fixes #5287
...
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
2020-07-03 11:47:40 +05:30
Nikhil Mohite
2ec8051303
Remove the duplicate code for tab indent and add the logic into codemirror.
2020-07-03 10:47:39 +05:30
Yogesh Mahajan
6dd3ca31be
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-07-01 13:43:00 +05:30
Nikhil Mohite
c2e875d54b
Fixed tab indent issue on a selection of lines is deleting the content when 'use spaces == true' in the preferences. Fixes #4235
2020-07-01 13:34:48 +05:30
Satish V
4c05287677
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-06-30 17:26:18 +05:30
Yogesh Mahajan
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Akshay Joshi
15c621b1d8
Fixed following SonarQube issues:
...
1) TypeError can be thrown as <variable_name> might be null or undefined here.
2) Unexpected duplicate "white-space".
3) Unexpected missing generic font family.
4) Unexpected shorthand "padding" after "padding-left".
2020-06-24 15:57:01 +05:30
Aditya Toshniwal
6620f9263d
Fixed issues reported by SonarQube with tag 'bad-practice'.
2020-06-22 12:18:59 +05:30
Akshay Joshi
bc24e3643f
More code cleanup for SonarQube.
2020-06-18 16:20:34 +01:00
Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Aditya Toshniwal
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
Satish V
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
Aditya Toshniwal
eb971a0320
Update Codemirror version to the latest which allows us to set screen reader labels on Codemirror editor.
...
refs #5197
2020-06-08 12:26:12 +05:30
Satish V
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
Satish V
9338bdcb3a
Fixed an issue where the newly added table is not alphabetically added to the tree. Fixes #5434
...
Fixed an issue when renaming the column not added in the proper order. Fixes #5450
2020-05-08 12:52:03 +05:30
Aditya Toshniwal
99d1068f70
Fixed an issue where the search object not able to locate pg_toast_* tables in the pg_toast schema. Fixes #5441
2020-04-27 19:51:56 +05:30
Satish V
2e29f3fd6d
Fixed an issue where columns names should be visible in the order of their creation in the browser tree. Fixes #5043
2020-04-23 16:42:42 +05:30
Neel Patel
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
Pradip Parkale
3d516101a4
Fixed an issue wherein grant wizard the last object is not selectable. Fixes #4545
2020-04-21 13:09:15 +05:30
Libor M
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
Nagesh Dhope
8bdfa18efb
Ensure that if the delimiter is set other than comma then download the file as '.txt' file. Fixes #4573
2020-04-17 17:37:02 +05:30
Nagesh Dhope
0ce4f49e08
Fixed copy-paste row issues in View/Edit Data. Fixes #3947
...
1) Copy table rows across two or more active query tool sessions.
2) Copied rows can be pasted multiple times without selecting a row in the query tool grid.
3) Adds an empty row at the end in the query tool grid after pasting rows.
2020-04-16 15:25:39 +05:30
Murtuza Zabuawala
c41da41efe
Fixed python exception error when user tries to download the CSV and there is a connection issue. Fixes #4858
2020-04-15 16:46:03 +05:30
Khushboo Vashi
ed0a596286
Added alert message to Reset Layout if any of the panels from Query Tool failed to load. Fixes #5366
2020-04-15 16:23:54 +05:30
Pradip Parkale
a05acb4f99
Fixed tab key navigation for some dialogs. Fixes #5371
2020-04-14 13:32:03 +05:30
Aditya Toshniwal
b427a87724
Fixed an issue where changing the values of columns with JSONB or JSON types to NULL. Fixes #4969
2020-04-13 12:34:32 +05:30
Aditya Toshniwal
077589e08b
Fixed an issue where right-clicking a browser object does not apply to the object on which right-click was fired. Fixes #3523
...
Fixes keyboard navigation on the context menu applied to browser tree.
2020-04-10 17:34:57 +05:30
Aditya Toshniwal
014ce31589
Fixed user management related issues:
...
1) Unable to add a user when there are many users. The dialog went blank. Fixed.
2) The error message did not have a close button. Fixed.
3) When clicked on the add button, then the cursor will focus on the email box of
the new row for convenience.
4) When the dialog opens, the cursor will focus on the search text box.
5) By default, the "User" role will be selected when adding a new user.
Also removed an empty option in the roles dropdown.
6) When the search filter is applied and we try to add an already existing user, the
validation is done only on the filtered data and not on all the users' data.
Fixes #5227
2020-04-10 16:49:33 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Pradip Parkale
33deacacee
Ensure that the grant wizard should be closed on pressing the ESC key. Fixes #4206
2020-04-07 13:48:56 +05:30
Aditya Toshniwal
e1f990190e
Added search object functionality. Fixes #2172
2020-04-06 17:33:07 +05:30
Aditya Toshniwal
4f71dae598
Fixed calendar opening issue on the exception tab inside the schedules tab of pgAgent. Fixes #4512
2020-04-06 12:59:22 +05:30
Vishal Sawale
99a72e529b
Fixed some accessibility issues:
...
1) Added missing search filter label in backgrid.
2) broken aria issue for objects menu.
2020-04-03 17:11:46 +05:30
Aditya Toshniwal
824e3866d8
Replace the existing color picker - spectrum-colorpicker with @simonwep/pickr.
...
spectrum-colorpicker has accessibility issues and is not maintained since long
Part of #5197
2020-04-03 17:06:47 +05:30
Vishal Sawale
4036f2a0f2
Fixed accessibility issue for the missing label from the table header.
2020-04-02 12:47:39 +05:30
Murtuza Zabuawala
37f55ccc25
Ensure that switch cell is in sync with switch control for accessibility. Fixes #5314
2020-04-02 12:25:55 +05:30
Rahul Shirsat
75b6341a84
Ensure that the start and end date should be deleted when clear the selection for pgAgent Job. Fixes #3645
2020-04-01 13:31:36 +05:30
Pradip Parkale
13b65c9a6a
Fixed tab key navigation issue for Grant Wizard. Fixes #5241
...
1) Added entry for .scss to change the shadow of 'ajs-close' button.
2) allow the user to use the keyboard to update the Backgrid cell DateTime picker control.
2020-03-30 17:31:50 +05:30
Ganesh Jaybhay
4c0b229b14
Fixed an issue where focus doesn't go to the immediate next editable cell after pressing the tab key on switch cell.
2020-03-26 10:50:01 +05:30
Libor M
94864104e4
Added and fixed gettext usage for better translation coverage. Fixes #5284
...
1) Fixed usage gettext('') instead of _('') in javascript files.
2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
because "pybabel extract" not support extracting from this syntax.
2020-03-24 11:14:05 +05:30
Pradip Parkale
96361656e4
Fixed some accessibility issues in the dialogs:
...
1) Aria-label additions at few missing places.
2) Label additions with 'sr-only' class where hidden labels required.
3) Converted label to span to solve accessibility error.
Fixes #4608
2020-03-19 16:08:51 +05:30
Ganesh Jaybhay
6586be5158
Fixed some accessibility issues:
...
1) Screen reader to read elements in radio modern control.
2) Aria-label additions at few missing places.
3) Radiocontrol to have different ids for each option.
2020-03-12 11:09:29 +05:30
Pradip Parkale
1bd14895c3
Fix an issue where the user can not change the value of DateTime picker control using keyboard. Fixes #4237 .
2020-03-10 13:21:17 +05:30
Pradip Parkale
82155cd859
Fix an accessibility issue to maximize the panel for all alertify dialog. Fixes #5143
2020-03-06 18:47:22 +05:30
Aditya Toshniwal
4db0a6524d
Fix an issue where debugger not showing all arguments anymore after hitting SQL error while debugging. Fixes #5101
...
Added a "Clear All" button to the argument dialog which will clear all the saved arguments values from SQLite DB.
2020-02-28 15:27:01 +05:30
Pradip Parkale
eaf4781f5f
1) Added accessibility support in AlertifyJS. Fixes #5154
...
2) Fix accessibility issue for the maximize button of the Alertify dialog. Fixes #5143
2020-02-25 18:23:36 +05:30
Aditya Toshniwal
9bad590e9e
Improvements in the UI for both default and dark themes. Fixes #5133
...
Improve the style of the highlighted code after query execution for Dark mode. Fixes #4996 .
Changed background pattern for geometry viewer to use #fff for all themes. Fixes #5077
Changed the color of selected and hovered item for Select2 dropdown, also tweak the appearance of the tags in multi-select boxes. Fixes #4955
Fixed Firefox monospaced issue by updating the font to the latest version. Fixes #5184
2020-02-24 14:11:00 +05:30
Akshay Joshi
29c236c33d
Ensure that AlertifyJS should not be visible as a title for alert dialog. Fixes #5058
2020-02-24 12:33:23 +05:30
Nagesh Dhope
1964e824c8
Initialize the label and control className for select2 which was missing in the last commit.
2020-02-18 10:58:30 +05:30
Nagesh Dhope
3e10e2c978
Added option to override the class name of a label tag for select2 control. Fixes #5185
2020-02-17 11:58:28 +05:30
Pradip Parkale
210bbfdbe1
1) Added labels and titles after parsing and validating all the pgAdmin4 web pages for accessibility. Fixes #4770
...
2) Fixed an issue where Save Password control disappears after clicking on it while creating a server. Fixes #5116
2020-01-31 14:21:35 +05:30
Aditya Toshniwal
0da23b837d
Set input controls as read-only instead of disabled will allow tab navigation in the properties tab and also allow screen readers to read it. Fixes #4993
2020-01-31 12:37:44 +05:30
Murtuza Zabuawala
989aa462f7
Set proper focus on tab navigation for file manager dialog. Fixes #5107 .
...
Initial patch sent by Ganesh Jaybhay
2020-01-31 11:43:30 +05:30
Aditya Toshniwal
75a3e92098
Fixed an issue where logout inactive session did not work when a new tab is opened from the already opened tab.
2020-01-31 11:20:45 +05:30
Nagesh Dhope
f167d77b61
Allow screen-reader to read label & description of non-textable elements. Fixes #4762 .
...
Allow screen-reader to identify the alert errors. Fixes #4763
Added role alertdialog for confirm and alert dialog.
Added role status for all status bars/banners.
Added role alert for error bars.
Added aria-labelledby for charts on each dashboard.
Added tabindex for each chart so that it is navigable using tab key.
2020-01-28 11:32:11 +05:30
Aditya Toshniwal
fde8e4054a
Fixed an issue where Grant wizard unable to handle multiple objects when the query string parameter exceeds its limit. Fixes #4511
2020-01-20 17:53:21 +05:30
Khushboo Vashi
45f2e35a99
Added Schema Diff tool to compare two schemas and generate the difference script.
...
Currently supported objects are Table, View, Materialized View, Function and Procedure.
Backend comparison of two schemas implemented by: Akshay Joshi
Fixes #3452 .
2020-01-10 15:42:09 +05:30
Aditya Toshniwal
d4ee869281
Fixed broken tags and tokenizer options of select2. Regression of #5038
...
With the change of data adapter, we have configured adapters for tags and tokenizers.
We also renamed the method onDemandLoad to showOnScroll to avoid confusion.
2020-01-06 12:47:56 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Aditya Toshniwal
febbd729ec
Ensure that constraints, indexes, rules, triggers, and compound triggers should be created on partitions. Fixes #4842 .
2020-01-01 12:59:48 +05:30
Aditya Toshniwal
737f8375fb
Added support for on-demand loading of items in Select2. Fixes #5038 .
2020-01-01 11:24:16 +05:30
Nagesh Dhope
8c4dff057f
Added aria-label attribute wherever missing for accessibility.
2020-01-01 10:37:17 +05:30
Nagesh Dhope
37f76142fb
1) Added aria-label to buttons used in graphical explain plan.
...
2) Fixed minor issue where we use dialog tab navigator keyboard shortcut only on visible tabs.
3) Fixed an issue where Zoom in, Zoom out, Zoom to original and Download button should not blur the focus after a click on them.
Initial patch sent by Murtuza Zabuawala.
2019-12-31 13:05:46 +05:30
Aditya Toshniwal
f1a18749f6
1) Allow screen-reader to read relationship attributes for tab, tabpanels and tables under it. Similar changes are done for subnode controls.
...
2) Add role="img" for font icons.
Fixes #4764
2019-12-17 13:22:36 +05:30
Ashesh Vashi
1f5ccd1c3b
Fixed any typo - we were using the function
...
'TreeNode.prototype.hasParent(...)' to find the server parent node
instead of 'TreeNode.prototype.anyParen(...)'.
2019-12-14 10:31:33 +05:30
Aditya Toshniwal
6e2cf8ced2
Changed the open query tool and data filter icons. Fixes #4990 .
2019-12-06 19:27:55 +05:30
Akshay Joshi
f7cc79fab1
Fix an issue where the inherited table name with quotes did not escape correctly. Fixes #4985 .
2019-12-03 19:31:32 +05:30
Aditya Toshniwal
0a67b2ecb9
Added aria-label to provide an invisible label where a visible label cannot be used. Fixes #4772 .
2019-12-03 12:47:42 +05:30
Khushboo Vashi
ae2aadeede
Fix an issue where pgAdmin4 unable to retrieve table node if the trigger is already disabled and the user clicks on Enable All. Fixes #4953 .
2019-12-02 15:26:36 +05:30
Khushboo Vashi
cccc6e5676
Added role=status attribute to all the status messages for accessibility. Fixes #4773 .
2019-12-02 14:15:31 +05:30
Aditya Toshniwal
4ed2d74d9c
1) Fix network disconnect issue while establishing the connection via SSH Tunnel and it impossible to expand the Servers node. Fixes #4724 .
...
2) Fix server connection drops out issue in query tool. Fixes #4818
3) Fix VPN network disconnect issue where pgAdmin4 hangs on expanding the Servers node. Fixes #4926 .
4) Ensure that the Servers collection node should expand independently of server connections. Fixes #4933 .
Set the default connection timeout to 10 seconds instead of 0.
2019-11-26 09:04:41 +05:30
Murtuza Zabuawala
6a5d98cf19
Fix accessibility issues:
...
1) Suppress ESC key presses in Alertify dialogues when the come from Select2 controls (It also closes the alertify dialog when user try to close Select2 using ESC key)
2) Do not allow Tabindex focus on Switch control when it is disbaled
3) Tab keyboard shortcut navigation does not work in wcDocker iframe.
Fixes #4935
2019-11-15 11:06:00 +05:30
Aditya Toshniwal
c1c682402a
1) Further styling tweaks for Dark Theme.
...
2) Theme related code changes are removed from config.py and moved to miscellaneous under a new package - "themes".
2019-11-11 18:47:43 +05:30
Aditya Toshniwal
8180403f97
1) Added support for custom theme creation and selection. Fixes #4348 .
...
2) Added Dark(Beta) UI Theme option. Fixes #3741 .
3) Fix an issue where a black arrow-kind image is displaying at the background of browser tree images. Fixes #4171
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown.
It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes.
On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after the bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the SVG files(monochrome) used as icons for buttons to font icons.
This will allow us to change the color of the icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of
theme CSS files as CSS in .css files will not change with the change of SASS variables.
2019-11-07 18:51:03 +05:30
Aditya Toshniwal
f85efb2797
Handle NULL values appropriately when sorting backgrid tables. Fixes #4242
2019-11-01 12:04:40 +00:00
Aditya Toshniwal
4bec7df33b
Suppress Enter key presses in Alertify dialogues when the come from Select2 controls to allow item selection with Enter. Fixes #4610
2019-10-30 10:42:06 +00:00
Aditya Toshniwal
4f9d2de8cd
Ensure Javascript errors during Query Tool execution are reported as such and not as Ajax errors.. Fixes #4564
2019-10-29 15:51:28 +00:00
Aditya Toshniwal
06022dfd7e
Fix an issue in the Query Tool where shortcut keys could be ignored following a query error. Fixes #3915
2019-10-29 11:51:01 +00:00
Aditya Toshniwal
1f6a0a87f6
Ensure all messages are retained in the Query Tool from long running queries. Fixes #4730
2019-10-25 12:38:46 +01:00
Aditya Toshniwal
6d7ff9444a
Don't quote bigints when copying them from the Query Tool results grid. Fixes #4459
2019-10-25 11:53:39 +01:00
Ganesh Jaybhay
5b438e13cc
Fixed potential error in the properties dialog for the Code tab. Fixes #4845 .
2019-10-18 17:38:15 +05:30
Nagesh Dhope
687fe617cc
Fixed an issue where Datetimepicker control opens when clicking on the label.
...
Change the click event to 'click .input-group'.
Fixes #4850
2019-10-18 17:37:57 +05:30
Aditya Toshniwal
f16498a8a7
Optimize Webpack to improve overall performance.
...
Changes include:
1) Remove underscore-string and sprintf-js packages as we were using only %s. Instead, added a function to do the same. Also changed gettext to behave like sprintf directly.
2) backgrid.sizeable.columns was not used anywhere, removed. @babel/polyfill is deprecated, replaced it with core-js.
3) Moved few css to make sure they get minified and bundled.
4) Added Flask-Compress to send static files as compressed gzip. This will reduce network traffic and improve initial load time for pgAdmin.
5) Split few JS files to make code reusable.
6) Lazy load few modules like leaflet, wkx is required only if geometry viewer is opened. snapsvg loaded only when explain plan is executed. This will improve sqleditor initial opening time.
Reviewed By: Khushboo Vashi
Fixes #4701
2019-10-10 12:05:28 +05:30
Ashesh Vashi
6e4923d762
Fixes # 4778 - Implement the query plan analyzer
...
Look 'n' Feel and implementation logic are inspired from
'http://explain.depsez.com '.
It now creates three tabs under the 'Explain' panel when executing a
query using the Explain Analyze/Explain button from the toolbar of the
Query tool.
Graphical
---------
-> Graphical Explain Plan
Analysis
--------
-> Table to show details of the explain plan analyse.
-> Each row represents the statistics per Explain Plan Node
-> It may contains columns like node information, exclusive timing
(time spent for this explain node excluding the child nodes),
inclusive timing, actual rows, plan rows,
rowsx (misestimation between planned vs actual rows), loop.
-> Background color of exclusive, inclusive, rows changes based on
their values.
i.e.
If Percentage of exclusive, and inclusive timings of total query time
is:
> 90 - Red Color
> 50 - Orange (Between Red & Yellow Color)
> 10 - Yellow color
If planner misestimation for the rows is
> 1000 times - Red Color
> 100 times - Orange (Between Red & Yellow Color)
> 10 times - Yellow Color
Also - if actual rows <= planned rows then it shows up arrow, else it
shows down arrow.
Statistics
----------
-> It contains a HTML table for the statistics per Node Type, and
a HTML table for the statistics per table.
Reviewed by: Akshay Joshi
2019-10-08 16:44:24 +05:30
Akshay Joshi
55c6fa0d93
Fix an error where 'false' string is displayed when we add a new parameter in the Parameters tab,
...
also clear the old value when the user changes the parameter name.
Corrected the implementation of BooleanCellFormatter.
Fixes #4753
2019-10-07 16:00:28 +05:30
Khushboo Vashi
56e00d74ad
There is no option to Copy data with headers from Query Tool/View Data.
...
Added drop-down 'Copy with headers' near to the copy button in Query Tool/View Data.
Fixes #3009
2019-09-27 12:14:39 +05:30
Aditya Toshniwal
73dc130908
Fix issue where pgAdmin does not load completely if loaded in an iframe. Fixes #4756
2019-09-23 12:55:02 +05:30
Akshay Joshi
da553eec9b
Ensure port and username should not be mandatory when a service is provided. Fixes #4642
2019-09-13 11:54:16 +05:30
Aditya Toshniwal
1c2ba72f02
Add editor options for plain text mode and to disable block folding to
...
workaround rendering speed issues in CodeMirror with very large scripts.
Fixes #4631 .
Re-arrange editor options in the Preferences dialogue to tidy things up.
2019-09-04 15:46:08 +01:00
Aditya Toshniwal
06ad6b8ba8
1) Ensure Boolean columns should be editable using keyboard keys. Fixes #3778
...
2) Ensure Boolean columns should be editable in View/Edit data and Query Tool. Fixes #4487
2019-08-28 11:09:30 +05:30
Yosry Muhammad
f8f7d5ac6f
Ensure editable and read-only columns in Query Tool should be identified by icons and tooltips in the column header. Fixes #4667
2019-08-26 14:17:40 +05:30
Yosry Muhammad
5887fb3815
Some refactoring of sqleditor.js.
2019-08-23 16:15:43 +01:00
Aditya Toshniwal
234efc3be7
Don't wait for the database connection before rendering the Query Tool UI, for improved UX. Fixes #4453
...
In addition, unescape HTML entities in database names in the Query Tool title bar. Fixes #4584
2019-08-23 12:14:20 +01:00
Yosry Muhammad
687204771c
Add support in query history to show internal queries generated by pgAdmin during save data operations. Fixes #4612
2019-08-16 17:17:12 +05:30
Aditya Toshniwal
6800b1f723
Add an optimisation to the internal code responsible for searching for treeview nodes. Fixes #4570
...
Attached is a tiny but very effective patch to improve the speed of
finding a node using path (used internally).
If you right click or just click on a node, internally the node is
traversed using its path. But currently, it compares with the path of
all the open nodes to find a match.
So if you 1000+ tables and the tables node is open and if you click on
a view, the view path is compared with all the 1000+ tables (and with
any other open nodes above) before arriving to path. You're at bad luck
if you have more open servers above.
Code is changed to check if the path of node to be found starts with the
current node path. If it doesn't match, why bother the children's of
current node.
This change will not show much effect for small data, but it does matter
for large servers.
One more change is to remove unnecessary calls to find node and use the
data available with Main Menu -> Object to enable/disable node context
menu items.
2019-08-06 14:02:57 +01:00
Aditya Toshniwal
b5c8c85c90
Ensure triggers should be updated properly for EPAS server. Fixes #4559
2019-08-05 12:49:33 +05:30
Aditya Toshniwal
99a8b70e00
Fix some errors thrown on the JS console when dragging text in the Query Tool. Fixes #4552
2019-08-02 11:28:57 +01:00
Akshay Joshi
537c27a58e
Use the full tab space for CodeMirror instances on dialogues where appropriate. Fixes #4540
2019-08-02 10:25:21 +01:00
Akshay Joshi
2ef3080d0e
Add support for generated columns in Postgres 12+. Fixes #4334
...
Ensure columns can be created when they are IDENTITY fields with the CYCLE option enabled. Fixes #4496
Ensure purely numeric comments can be saved on new columns. Fixed #4497
2019-07-25 16:38:26 +01:00
Murtuza Zabuawala
108af5c10b
Fix accessibility issue for Datetime cell in backgrid. Fixes #4508
2019-07-25 17:54:24 +05:30
Ganesh Jaybhay
136bb412a1
1) Fix accessibility issue for checkbox in IE11. Fixes #4490
...
2) Fix adjacent switch cell focus issue in backgrid for IE.
2019-07-25 17:23:56 +05:30
Khushboo Vashi
c019778a47
1) Fix an error while retrieving json data from the table. Fixes #4427
...
2) Fix an issue where Explain and Explain Analyze are not working, it's regression of #1760 . Fixes #4484
3) Fix an issue where Filter toolbar button is not working in view/edit data, it's regression of keyboard navigation. Fixes #4485
2019-07-22 18:42:48 +05:30
Yosry Muhammad
710d520631
Add support for editing of resultsets in the Query Tool, if the data can be identified as updatable. Fixes #1760
...
When a query is run in the Query Tool, check if the source of the columns
can be identified as being from a single table, and that we have all
columns that make up the primary key. If so, consider the resultset to
be editable and allow the user to edit data and add/remove rows in the
grid. Changes to data are saved using SAVEPOINTs as part of any
transaction that's in progress, and rolled back if there are integrity
violations, without otherwise affecting the ongoing transaction.
Implemented by Yosry Muhammad as a Google Summer of Code project.
2019-07-17 11:45:20 +01:00
Murtuza Zabuawala
20a5899c7d
Fix some minor UI issues on IE11. Fixes #4462
...
Includes some Jasmine test case fixes from Ganesh.
2019-07-12 10:06:30 +01:00
Ganesh Jaybhay
4cbc1f2f59
Allow keyboard navigation of all controls on subnode grids. Partially fixes #3919
2019-07-11 10:14:01 +01:00
Aditya Toshniwal
0aa18fd466
Ensure drag/drop from the treeview works as expected on Firefox. Fixes #4429
2019-07-04 14:49:09 +01:00
Aditya Toshniwal
0340b8fb28
Add EXPLAIN options for SETTINGS and SUMMARY. Fixes #4335
...
Prevent flickering of large tooltips on the Graphical EXPLAIN canvas. Fixes #4224
EXPLAIN options should be Query Tool instance-specific. Fixes #4395
2019-07-03 13:57:56 +01:00
Aditya Toshniwal
24ec882f45
Properly escape dragged node text. Fixes #4139
2019-06-28 08:17:04 -04:00
Aditya Toshniwal
173b812b93
Allow some objects to be dragged/dropped into the Query Tool to insert their signature into the query text. Fixes #4139
2019-06-27 10:30:05 -04:00
Dave Page
fb4afce629
Fix formatting change which inadvertently broke the feature tests.
2019-06-20 12:43:07 +01:00
Aditya Toshniwal
3b69f92d70
Ensure strings are properly encoded in the Query History. Fixes #4349
2019-06-14 09:17:02 +01:00
Dave Page
2ca11c84e8
Ensure that the Return key can be used to submit the Master Password dialogue. Fixes #4310
...
Ensure that browser auto-fill doesn't cause Help pages to be opened unexpectedly. Fixes #4317
2019-06-10 14:03:56 +01:00
Aditya Toshniwal
f561c0cee6
Fix keyboard navigation in "inner" tabsets such as the Query Tool and Debugger. Fixes #4195
2019-06-10 11:10:49 +01:00
Aditya Toshniwal
d90136d93d
Prevent the geometry viewer grabbing key presses when not in focus under Firefox, IE and Edge. Fixes #4255
2019-06-05 12:00:09 +01:00
Dave Page
2dd075161d
Allow the UI layout to be fully locked or to prevent docking changes. Fixes #2653
2019-05-31 11:51:30 -04:00
Aditya Toshniwal
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
Khushboo Vashi
6f0eafb223
Fixed CSRF security vulnerability issue. per Alvin Lindstam. Fixes #4217
...
Initial patch by: Khushboo Vashi
Modified by: Ashesh Vashi and Murtuza Zabuawala
2019-05-28 10:59:51 +05:30
Murtuza Zabuawala
155768a2d7
Prevent Backgrid Password cells from losing focus if the browser opens an autocomplete list. Fixes #4278
2019-05-20 13:34:47 +01:00
Murtuza Zabuawala
5786c17569
Fix navigation of switch cells in grids. Fixes #4269
2019-05-17 16:27:14 +01:00
Aditya Toshniwal
2cd58efcdd
1) Fixed Tab key navigation for Maintenance dialog. Fixes #4227
...
2) Fix Tab key issue for Toggle switch controls and button on the dialog footer in Safari browser. Fixes #4244
2019-05-15 16:37:06 +05:30
Murtuza Zabuawala
eb189844e7
Fixed console error when subnode control is used in panels. Fixes #4246
2019-05-10 11:24:15 +05:30
Neel Patel
34b59da526
Properly assign dropdownParent in Select2 controls. Fixes #4218
2019-04-30 12:57:17 +01:00
Khushboo Vashi
74af8976c9
Ensure that newly added row in backgrid should be visible.
2019-04-23 17:32:00 +05:30
Khushboo Vashi
0b47d1dbf6
1) Fix an issue where Deleting N number of rows makes first N number of rows disable. Fixes #3605
...
2) Ensure that on clicking Delete button should not delete rows immediately from the database server,
it should be deleted when Save button will be clicked. Fixes #2392
2019-04-18 12:09:35 +05:30
Murtuza Zabuawala
6016a5ee98
Fix an issue where the dropdown becomes misaligned/displaced. Fixes #4138
2019-04-09 12:09:25 +05:30
Murtuza Zabuawala
84ecffa4d9
Added recommended ESLinter checks. Fixes #4142
2019-04-05 13:07:43 +05:30
Dave Page
f706f7ed0c
Relabel the Save button on the datagrid text editor to avoid confusion with the actual Save button that updates the database. Fixes #4131
2019-04-02 17:20:43 +01:00
Khushboo Vashi
5965bc9107
Remove a debug statement.
2019-03-29 14:40:36 +00:00
Khushboo Vashi
97919d091a
Add support for IDENTITY columns. Fixes #4030
2019-03-28 13:13:43 -04:00
Akshay Joshi
5dd1472d6b
1) Fixed issue in Select2 Control, added undefined/null check.
...
2) Fixed the width of the delete cell.
2019-03-20 18:54:49 +05:30
Aditya Toshniwal
a4bc26c810
Fix handling of numeric arrays in View/Edit Data. Fixes #4062
2019-03-19 16:45:00 +00:00
Khushboo Vashi
e4417229aa
Update all Python and JS dependencies. Fixes #4019
2019-03-14 15:11:16 +00:00
Dave Page
ab9a3a57ad
Make the Query Tool history persistent across sessions. Fixes #4017
2019-03-13 13:37:34 +00:00
Aditya Toshniwal
4b895941b3
Remove the large and unnecessary dependency on React and 87 other related libraries. Fixes #4018
2019-03-07 10:51:59 +00:00
Dave Page
d7bf6ec69f
String review and subsequent cleanup
...
Ashesh Vashi
Abhilasha Narendra
Karen Blatchley
Susan Douglas
Dave Page
2019-03-05 14:08:16 +00:00
Khushboo Vashi
98815af8b6
Fix the position of text editor of a cell in Query Tool.
2019-03-04 16:39:30 +05:30
Akshay Joshi
0aeb20ee64
Prevent auto-commit/rollback being changed mid-transaction, and make the Preferences the defaults, not the current values.
2019-03-04 10:44:31 +00:00
Murtuza Zabuawala
36ffdb93e8
Custom-encode forward slashes in URL parameters as Apache HTTPD doesn't allow them in some cases. Fixes #3998
2019-03-01 14:55:25 +00:00
Aditya Toshniwal
e6e7cf0f69
Fix support for bigint's in JSONB data. Fixes #3587
2019-02-27 13:39:47 +00:00
Aditya Toshniwal
9c5b9364b6
Support double-click on Query Tool result grid column resize handles to auto-size to the content. Fixes #4034
2019-02-26 13:44:16 +00:00
Aditya Toshniwal
59446bb4b5
Ensure JSON data isn't modified in-flight by psycopg2 when using View/Edit data. Fixes #3600
2019-02-25 10:34:36 +00:00
Akshay Joshi
a5d39003b6
Handle display of roles with expiration set to infinity correctly. Fixes #3352
2019-02-25 10:24:11 +00:00
Akshay Joshi
38b034ec3c
Add Commit and Rollback buttons to the Query Tool. Fixes #2418
2019-02-22 14:28:05 +00:00
Dave Page
0766b17726
Enable/disable the Download button with the Execute button.
2019-02-22 09:34:48 +00:00
Murtuza Zabuawala
e2482d2294
Set the background colour for backform notes, and add an icon. Fixes #3948
2019-02-18 16:59:39 +00:00
Khushboo Vashi
554455fa75
Fix treeview state saving after reset.
2019-02-18 13:15:22 +00:00
Khushboo Vashi
17694ab467
Automatically expand child nodes as well as the selected node on the treeview if there is only one. Fixes #3559
...
This also ensure the browser state is cleared if the save interval is set to -1.
2019-02-14 09:18:08 +00:00
Akshay Joshi
0aa93ac3ba
Fix alignment of Connection type toggle switch of pgagent. Fixes #3974
2019-02-13 13:03:44 +05:30
Dave Page
1fc66406f5
Don't embed docs and external sites in iframes, to allow the external sites to set X-FRAME-OPTIONS = DENY for security. Fxies #3985
2019-02-12 16:07:38 +00:00
Khushboo Vashi
4a75053514
Clean up the unwanted extended versions of Backform Switch controls.
...
The Bootstrap Switch Control was extended only for alignment in most
places. IIntroduce a configurable option to set the necessary class
on the main div and also remove the extra extended controls.
2019-02-05 16:22:35 +00:00
Aditya Toshniwal
aad7830d37
Dashboard graph optimization. Fixes #3941
2019-02-04 15:39:47 +05:30
Khushboo Vashi
dae8186c2a
Replace Bootstrap switch with Bootstrap4 toggle to improve the performance. Fixes #3051
2019-02-04 11:31:48 +05:30
Ashesh Vashi
0e8f804279
Show the help string separate block in the calendar control to align the
...
input, and calendar button properly in case of help string is present.
2019-01-30 11:42:38 +05:30
Murtuza Zabuawala
2d7eaa63c4
Fix alignment of help messages in properties panels. Fixes #3929
2019-01-24 16:39:55 +00:00
Harshal Dhumal
42c7ae372f
Fixed dialog tab navigation for Backup and Restore dialog. Fixes regression of #3862
2019-01-24 17:15:12 +05:30
Akshay Joshi
f316e0533e
1) Messages tab of query tool should be clear on subsequent execution of table/view using View/Edit Data. Fixes #3608
...
2) Clear drop-down menu should be disabled for View/Edit Data. Fixes #3609
2019-01-23 18:25:33 +05:30
Harshal Dhumal
ea87d6da8f
Fixed keyboard navigation for Select2 and Privilege cell in Backgrid Fixes #3908
2019-01-22 16:35:57 +05:30
Harshal Dhumal
f731ab730b
Fixed keyboard navigation for dialog tabs. Fixes #3862
2019-01-22 16:28:32 +05:30
Ganesh Jaybhay
a0d2c45361
1. Proper alignment of help message with date time control.
...
2. Added help-block class for helpMessageClassName.
2019-01-22 11:22:32 +05:30
Khushboo Vashi
3ffeb4be45
Ensure that database restriction of server dialog should work with special characters. Fixes #3800
2019-01-21 17:24:46 +05:30
Khushboo Vashi
aedb3997b0
Ensure that Backup/Restore button should work on single click. Fixes #3811
2019-01-21 15:27:55 +05:30
Aditya Toshniwal
27cdb835cb
Correct order of Save and Cancel button for json/jsonb editing. Fixes #3891
2019-01-18 18:14:50 +05:30
Aditya Toshniwal
06ae799d02
Handle text wrapping in alertify dialog only when it is required. Regression of #3695
2019-01-18 17:54:49 +05:30
Aditya Toshniwal
48660508ce
Fixed controls alignment responsiveness to docker size change.
2019-01-17 18:20:12 +05:30
Aditya Toshniwal
dec43d98dc
Fixed execution time to show Hours part for long running queries in Query Tool. Fixes #3475
2019-01-16 12:57:52 +05:30
Aditya Toshniwal
7ac4e2a9d9
Fixed following issues:
...
- Process watcher made fixed width with header changes, time details rounded to 2 decimals
- Query history will show "No query history" if no query fired. Query editor default size increased.
- Fixed a bug where New folder create button not working when in List mode and No files/folder present.
- Other minor improvements.
2019-01-16 11:55:08 +05:30
Aditya Toshniwal
f7fa18f827
Ensure the context menu works after a server is renamed. Fixes #3575
2019-01-10 11:52:52 +05:30
Dave Page
598f69b63d
Improve wording.
2019-01-03 15:24:47 +00:00
Aditya Toshniwal
7d765fea04
Further styling fixes.
2019-01-03 14:50:24 +00:00
Murtuza Zabuawala
e23d307c56
Update copyright notices for 2019
2019-01-02 15:54:12 +05:30
Aditya Toshniwal
86ecf9c84e
Fixed following:
...
- Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem.
- Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter
- Alignment fix for controls of Node properties dialogs which includes showing text and label in one line without dialog size change, checkbox alignment, switch control alignment at places and other minor improvements in other dialogs
- Error message design change in dialogs validation
- SQL Editor data grid editor popup design changes which were missed
- Design change for dashboard server activity grid
- Login page language dropdown color fix
- Properties accordion collapse design fix
- Help, Info icon fixed across all dialogs which were not working if clicked exactly on the text
- Added missing icon with buttons at few places
- Shadow behind the dialogs is increased to make it look clearly separated and depth.
- Control Alignment fix in maintenance dialog
- Min height of alertify dialogs set for better UX
- File dialog design fix when no files found
- Grant wizard fixes - Scroll bar visibility on first page, use full space for SQL generated on the last page
- Browser toolbar buttons changed to sync with SQL editor toolbar buttons
- Rounded corners for docker floating dialog (no properties)
- Renaming file in file dialog should show original file name
- SQL data grid text edit popup buttons behaviour was swapped. This is fixed.
- Import/Export dialog changes as per new design.
2019-01-02 15:07:59 +05:30
Ashesh Vashi
5799ac14ba
Improvement in the look and feel of the whole application
...
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
2018-12-21 17:14:55 +05:30
Khushboo Vashi
a000dc6f60
Further improvements to treeview restoration. Fixes #3559
2018-12-21 11:36:11 +00:00
Akshay Joshi
bdf9f3404f
Fix handling of array types as inputs to the debugger. Fixes #3354
2018-11-27 11:18:47 +00:00
Khushboo Vashi
f17979141c
Add support for dropping multiple objects at once from the collection Properties panel. Fixes #1513
2018-10-31 10:30:37 +00:00
Akshay Joshi
3359a0de7a
Allow the selection order to be preserved in the Select2 control to fix column ordering in data Import/Export. Fixes #3029
2018-10-31 10:09:40 +00:00
Aditya Toshniwal
d6c4911135
Fixed calender control issues with Bootstrap 4
2018-10-12 15:02:38 +05:30
Aditya Toshniwal
6991c06937
Additional Bootstrap 4 fixes:
...
- Calendar control
- Query Tool's Sort/Filter drop down
- Backform hidden controls
- Debugger toolbar
2018-10-11 13:23:59 +01:00
Khushboo Vashi
235a75202d
Fixed minor issue in saving tree state logic.
2018-10-11 11:22:24 +05:30
Aditya Toshniwal
0565f8dd78
Update to use Bootstrap 3 instead of Bootstrap 4. Fixes #3562
2018-10-10 12:43:26 +01:00
Khushboo Vashi
528ea88dec
Save the treeview state periodically, and restore it automatically when reconnecting. Fixes #1253
2018-10-08 10:03:19 +01:00
Akshay Joshi
0ec3224212
Fix logic around validation and highlighting of Sort/Filter in the Query Tool. Fixes #3607
2018-09-14 14:18:43 +01:00
Aditya Toshniwal
82c9cca683
Move all CSS into SCSS files for consistency and ease of colour maintenance etc. Fixes #2927
2018-09-04 11:24:51 +01:00
Xuri Gong
89e283fbc2
Add a geometry viewer that can render PostGIS data on a blank canvas or various map sources. Fixes #1407
2018-08-30 13:59:44 +01:00
Aditya Toshniwal
283a69a21a
Fix auto scrolling issue in debugger on step in and step out. Fixes #3554 .
2018-08-29 18:20:45 +05:30
Aditya Toshniwal
25679fd542
Ensure sort/filter dialog should display proper message after losing database connection. Fixes #3561
2018-08-22 16:38:31 +05:30
Aditya Toshniwal
57660d131f
1) Fix sort/filter dialog editing issue. Fixes #3558 .
...
2) Fix sort/filter dialog issue where it incorrectly requires ASC/DESC. Fixes #3325 .
2018-08-21 13:05:40 +05:30
Ashesh Vashi
ffd41009ea
We were refering to the wrong 'name' variable during cleaning up the
...
backform controls.
2018-08-12 15:44:52 +05:30
Akshay Joshi
7117ce6a22
Fix keyboard shortcuts layout in the preferences panel. Fixes #3407
2018-08-07 14:41:50 +01:00
Ashesh Vashi
e2ce73d855
'anyFamilyMember' runs the condition function for all nodes in the
...
hierarchy. No need to run the 'dashboardURL' function in the
'getDashboardURL' function for the current node too.
2018-07-26 21:37:40 +05:30
Ashesh Vashi
e12e00703f
Refactored the dashboard code, which was allowing each node type to
...
define its own dashboardURL.
There was a typo, while calling the dashboard function of a Node type.
2018-07-25 12:28:44 +05:30
Aditya Toshniwal
f7e43d5e50
Realtime preference handling for the Dashboards and Debugger. Fixes #3294
2018-07-24 16:31:44 +01:00
Khushboo Vashi
2d1e835d32
Fix panel errors seen when click on partitions.
2018-07-23 14:33:40 +01:00
Aditya Toshniwal
2b9c0a63fb
Ensure CodeMirror always has a non-zero font size. Fixes #3480
2018-07-10 13:58:44 +01:00
Aditya Toshniwal
3b862bd70b
More jQuery 3 updates.
2018-07-10 10:59:53 +01:00
Aditya Toshniwal
d1784137a5
Ensure text is visible in the SQL Filter dialogue. Fixes #3478
2018-07-09 14:08:41 +01:00
Aditya Toshniwal
41a8333145
Replace deprecated success, error callbacks in $.ajax call with new functions .done and .fail.
2018-07-09 13:54:00 +01:00
Aditya Toshniwal
73530c05aa
Add missing files related to previous commit: Infrastructure and changes to the Query Tool for realtime preference handling. Refs #3294
2018-07-05 11:41:01 +01:00
Aditya Toshniwal
bdb7e3fde2
Infrastructure and changes to the Query Tool for realtime preference handling. Refs #3294
...
Highlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab of the main screen, Query tool, History entries in the query tool, Query tool opened in New Tab/Window
- All the components of SQL editor will refer to single source of preferences which is cached in the Browser object. All other redundant ajax get preference calls are removed.
- SQL editor will not refer template JS variables anymore, once all the references are removed the template variables will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.
2018-07-05 11:38:43 +01:00
Murtuza Zabuawala
d53c47e1cf
Cleanup and fix handling of Query Tool Cancel button status. Fixes #3319
2018-07-02 15:43:36 +01:00
Khushboo Vashi
fb1ef9ac0b
Properly support backups in Directory format. Fixes #3309
2018-06-29 15:14:37 +01:00
Akshay Joshi
b48145f01f
Add an option to auto-complete keywords in upper case. Fixes #2686
2018-06-15 10:18:56 +01:00
Joao De Almeida Pereira
7dd6372eeb
Extract the tests and refactor some of the methods.
...
Extract some of the ACI Tree functionalities, and decouple it from the
main source. Also - create some abstractions from the repeated code
around the enable/disable the schema children object create/edit/delete
functionalities, and also created the dialog wrappers for backup and
restore dialogs.
Reviewed by: Khushboo and Ashesh
Refactored by: Ashesh
2018-06-05 16:42:59 +05:30
Akshay Joshi
38ee39ae7a
Add support for LISTEN/NOTIFY in the query tool. Fixes #3204
2018-05-30 21:58:28 -04:00
Aditya Toshniwal
9f13865777
Update jQuery to 3.3.1. Fixes #3271
...
Patch by Aditya, with test enhancements from Anthony and Joao at Pivotal.
2018-05-25 16:26:37 +01:00
Joao De Almeida Pereira
bc4d16eb83
Initial version of the new tree implementation.
...
This is the first version of our Tree implementation. At this point is a
very simple tree without no abstractions and with code that eventually
is not very performant, but this is only the first iteration and we are
trying to follow the 'Last Responsible Moment Principle' [1].
Implemention details:
- Creation of PGBrowser.treeMenu
- Initial version of the Tree Adaptor 'pgadmin/static/js/tree/tree.js'
- TreeFake test double that can replace the Tree for testing purposes
- Tests, As an interesting asside because Fake’s need to behave like
the real object you will noticed that there are tests for this type
of double and they the same as of the real object.
[1] https://medium.com/@aidanjcasey/guiding-principles-for-an-evolutionary-software-architecture-b6dc2cb24680
Patched by: Victoria && Joao
Reviewed by: Khushboo & Ashesh
2018-05-14 18:00:23 +05:30
Aditya Toshniwal
5b86a67a41
Fixed query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Fixes #3298
2018-05-09 13:05:22 +05:30
Dave Page
8937375885
Standardise the error handling for parsing of JSON response messages from the server. Fixes #3238
2018-05-04 16:56:15 +01:00
Akshay Joshi
b7fb01ab04
Add support for SSH tunneled connections. Fixes #1447
2018-05-04 11:27:27 +01:00
Khushboo Vashi
732d8d903d
F5 key should work to refresh Browser tree. Fixes #3284
...
Refactoring by: Joao Pedro De Almeida Pereira
2018-05-02 11:43:42 +05:30
Ashesh Vashi
b653b742ed
Close button added to the alertify message box, which pops up in case of backend error. Fixes #3290
2018-04-24 18:57:31 +05:30
Murtuza Zabuawala
f5e474e4ec
Ensure the query tool will open properly under MS Edge.
2018-04-10 11:09:59 +01:00
Murtuza Zabuawala
78c3db6fc9
Update filter dialogue Javascript to use ES6.
2018-04-06 10:38:04 +01:00
Murtuza Zabuawala
fa1854bd85
Allow sorting when viewing/editing data. Fixes #1894
2018-04-05 16:25:17 +01:00
Neel Patel
659390493d
Ensure Alertify dialogues are modal to prevent them being closed by mis-click. Fixes #3248
2018-04-05 11:28:18 +01:00
Murtuza Zabuawala
a705fb46a8
Refactor and simplify query tool connection error handling code. Fixes #3235
2018-04-04 11:20:36 +01:00
Khushboo Vashi
7805170783
Add the ability to enable/disable UI animations. Fixes #1978
2018-04-03 14:52:13 +01:00
Joao Pedro De Almeida Pereira
94e1e46201
Show more granular timing info in the query tool history panel. Fixes #3244
2018-04-03 14:11:11 +01:00
Akshay Joshi
637f3b9d1a
Fix a number of broken connection detection scenarios.
2018-03-21 08:38:18 +00:00
Murtuza Zabuawala
34f1ebc88e
Ensure the host parameter is correctly pickup up from the service file. Fixes #3200
2018-03-19 12:38:44 +00:00
Joao Pedro De Almeida Pereira
3c4359270e
Fix trim function which was causing some JS errors during Server Properties validation. Victoria & Joao
2018-03-14 17:58:01 -04:00
Victoria Henry
6b03cb78af
Refactor server dialogue validation for better unit testing.
...
Victoria & Joao @ Pivotal.
2018-03-13 14:47:32 -04:00
Joao Pedro De Almeida Pereira
d1ab47c10c
Disable function statistics on Greenplum. Fixes #3176
2018-03-07 11:52:02 +00:00
Joao Pedro De Almeida Pereira
427314cfdf
Support for external tables in GPDB. Fixes #3168
2018-03-02 16:49:25 +00:00
Murtuza Zabuawala
92a0bb605d
Ensure we can edit grid values in the debugger using keyboard shortcuts. Fixes #3153
2018-03-02 15:05:04 +00:00