2fddf750e6
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971
2017-06-08 12:41:56 +01:00
8d8e7dab3c
Extract row staging into it's own module with tests.
2017-06-07 14:17:10 +01:00
0d05385585
Update the styling to use the set of grays defined in the WIP style guide.
2017-06-07 13:57:49 +01:00
ae80976689
Using the client-side translation using the client-side 'gettext'
...
implementation.
This is the first step towards 'Avoid creating the javascript modules
using Jinja templates'.
2017-06-07 15:53:05 +05:30
d21cbb8b1f
Handle composite primary keys correctly when deleting rows in the Edit Grid. Fixes #2425
2017-06-06 09:58:47 +01:00
456096092d
Avoid re-rendering the edit grid for every row that is pasted.
2017-05-30 16:22:11 +01:00
1f26953504
Cleanup handling of default/null values when data editting. FIxes #2400
2017-05-27 14:51:02 -04:00
8aabee352c
Import the ordereddict module for Python 2.6
2017-05-26 12:34:05 -04:00
dba64e77f1
Order columns in multi-column pkeys correctly. Fixes #2417
2017-05-26 11:04:32 -04:00
1db81da020
Fix JS error when selecting a single grid cell.
2017-05-16 08:44:29 +01:00
d7d4bf475b
Various improvements to the NULL/DEFAULT handling in the data editor. Fixes #2399
2017-05-15 15:04:16 +01:00
0e7efc0cf8
Track disabled rows properly in the edit grid.
2017-05-12 16:42:06 +01:00
dd318e679d
Minor colour tweaks for highlighted rows in the data editor. These are likely to be changed again when we overhaul and standardise the colouring, but at least now they're using colours from the style guide.
2017-05-12 11:29:46 +01:00
4f9628ed43
Improve handling of nulls and default values in the data editor. Fixes #2257
2017-05-12 10:53:57 +01:00
13f4432bbd
Support loading files with Unicode BOMs. Fixes #2369
2017-05-09 12:06:49 +01:00
63d42745ef
Fix various issues in CSV file download feature:
...
1) To handle non-ascii filenames which we set from table name. Fixes #2314
2) To handle non-ascii query data. Fixes #2253
3) To dump JSON type columns properly in csv. Fixes #2360
2017-05-08 13:36:11 +01:00
93df5e3e54
Ensure errors thrown when deleting rows in the query tool in edit mode are shown properly. Fixes #2356
2017-05-02 12:20:30 +01:00
928c0d3de8
startsWith() function of java script is not supported in IE, instead use startsWith() function of underscore string. Fixes #2347
2017-04-25 12:00:15 +05:30
f718e1f49c
Only display the header row in SlickGrid where columns actually exist.
2017-04-24 20:26:59 +01:00
d663d553c5
Allow column or row selection in the query tool. Fixes #2216
2017-04-18 13:28:45 +01:00
c758920890
Properly handle EXPLAIN queries entered directly by the user in the query tool. Fixes #2287
2017-04-06 09:46:42 +01:00
37120bf199
(De)Capitalized strings to fit the common/usual format, corrected spelling, removed unnecessary characters.
2017-04-05 13:50:49 +01:00
efb077b7f7
Fix error highlighting in the query tool. Fixes #2291
2017-03-31 20:06:55 -04:00
eb89998dc0
From a visual standpoint, grey highlight makes selection look deselected rather than selected. A brighter color would quickly provide visual feedback on an action.
...
With this patch the color of selected rows look more highlighted.
2017-03-30 22:56:13 -04:00
569ceb3906
Modify the web code to allow the Query Tool and Debugger to be opened in new tabs, per settings in Preferences. Fixes #1344
...
Note that this does *not* enable the runtime to use multiple windows at this stage. It's really only useful in Server mode.
2017-03-24 14:43:56 +00:00
5f2a15dd6d
Fix deletion of rows where the primary key isn't at ordinal zero. Fixes #2274
2017-03-24 13:32:56 +00:00
2142824448
PRevent an error being displayed if the user views data on a table with no columns. Fixes #2244
2017-03-21 16:40:21 +00:00
4eafdbeff6
Resolved a typo - show a '?' after the 'Show timing' preference.
2017-03-21 11:17:35 +05:30
461086c17d
Fix View Data filter options. Fixes #2265
2017-03-17 12:45:59 +00:00
ae0d8e89eb
Fix the path to JS
2017-03-15 17:12:58 +00:00
889050b71d
Fix quotes to ensure we have valid JS.
2017-03-15 17:11:53 +00:00
172b41cba8
Refactor clipboard copying into a separate file for use outside the SQL Editor.
2017-03-15 17:11:11 +00:00
28deb34283
Remove some dead code.
2017-03-10 10:27:17 +00:00
fb44ffffa0
Fix a couple of translation issues, and remove the test French translation files.
2017-03-08 10:13:15 +00:00
480e00fddf
Query tool efficiency.Convert the data as a 2D array instead of dict. Fixes #2036
...
Incremental back off when polling. Fixes #2038
Initial Patch By: Dave Page
2017-03-01 16:58:51 +05:30
3638d63330
Move pgadmin plugins for codemirror back out of the vendor area.
2017-02-27 13:18:28 +00:00
a0a31e55ae
Move 3rd party client code into vendor/ directories for ease of maintenance.
2017-02-24 17:01:21 +00:00
b19081421b
Ensure primary key column names are quoted in View Data mode of the Query Tool. Fixes #2208
2017-02-24 13:58:23 +00:00
89137f57b2
Display un-sized varlen column types correctly in the query tool. Fixes #2151
2017-02-21 13:12:50 +00:00
a914ea088c
Python 2.6 compatibility fixes.
2017-02-08 16:28:04 +00:00
4566877188
Handle NULL booleans in the data editor. Fixes #1790
2017-02-05 11:06:48 +01:00
54ba1fbe59
Support setting text fields to empty strings or NULL in the data editor grid. Fixes #1790
2017-02-04 14:10:30 +01:00
4ef26a528b
Allow direct navigation (i.e. typing of paths) in the file manager. Fixes #1911
2017-02-03 10:51:36 +01:00
6d05302ca1
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3.
2017-02-01 09:57:49 +00:00
19be3529f8
Create a template loader for SQL templates.
...
This will automatically find the correct version of a template for the server version, and allows us to remove templates that were previously duplicated for different server versions.
Patch by George & Tira at Pivotal. Review by me and Murtuza from EDB.
Discussion: https://www.postgresql.org/message-id/flat/CAHowoHaU9_pkCt%2B1g8dpY3hsXXZmsJZiJH-3-_Hd%2BC1MxiGhtA%40mail.gmail.com#CAHowoHaU9_pkCt+1g8dpY3hsXXZmsJZiJH-3-_Hd+C1MxiGhtA@mail.gmail.com
2017-01-30 11:25:03 +00:00
ae809c4506
Properly detect when files have changed in the query tool and set the dirty flag accordingly. Fixes #1807
...
Note that (like pgAdmin 3) we don't make any attempt to detect if all changes have been undone and completely reverted as that could be very expensive with large scripts.
2017-01-08 15:27:58 +05:30
f221194bcc
Update copyright notices for 2017.
2017-01-04 13:33:32 +00:00
87d4937726
Minimise memory requirements for rendered cells and rows in SlickGrid. Fixes #2035
...
- The CSS class 'slick-row' has been renamed to 'sr'
- The CSS class 'slick-cell' has been renamed to 'sc'
- The SQL Editor included an unused 'normal_row' class on each row which has been removed as it was unreferenced in the code or CSS.
The intent of these changes is to minimise memory usage by the grid, by saving a few bytes per row/cell.
It's questionable how much difference this actually makes given that SlickGrid updates the document so it
only includes the visible rows on the fly, but every little helps.
2016-12-22 17:43:42 +00:00
d3862eef3f
Fix some additional table styling inconsistencies.
2016-12-19 14:26:33 +00:00
5008872203
Ensure the SQL editor has enough space to show block folding arrows in the gutter.
2016-12-19 11:35:27 +00:00
6fc8f040ff
Allow users to enable wrapping of code in SQL boxes. Fixes#2025
2016-12-16 17:07:41 +00:00
53ea991907
Properly size the SQL Editor gutter as the width of the line numbers increases. Fixes #1780
2016-12-16 13:04:16 +00:00
686237413c
Use more sensible column sizes for the data output in the query tool. Fixes #1789
...
Per Akshay:
I have tried to get the width of the content but we are sending complete data as collection to the SlickGrid. We will have to fetch the content of each column and figure out the maximum length for that column by iterating all the rows is too expensive. Apart from that to set the width in 'ch' we will have to do it using css. With current implementation we are setting the column option of the SlickGrid from javascript code.
I have fixed this issue by setting the width of the columns based on data type. I have set the width of boolean column to 60, all the numeric/integer columns to 80 and for all other data types it is 20% of the container width as 33% is too wide.
2016-12-12 10:13:53 +00:00
53481023fa
Properly sort rows by the pkey when viewing first/last 100. Fixes #2007
2016-12-12 10:06:34 +00:00
4a280b2517
Only show the filename in query tool tabs, not the whole path.
2016-12-09 12:42:30 +00:00
b8d03d5dc2
Don't cast data when saving in the edit grid, so errors are seen and data doesn't get silently modified. Fixes #1994
2016-12-09 12:05:46 +00:00
eb337cadce
Remove unused rows per page config option.
2016-12-05 13:59:44 +09:00
a64824a851
Fix various encoding issues with multibyte paths and filenames.
...
Fixes #1986 . Fixes #1940 .
2016-12-05 13:10:56 +09:00
394381bf75
Add search/replace support to the Query Tool, including regexp matching. Fixes #1765
2016-11-24 15:38:39 +00:00
b7c819e912
Render column headers at the correct width in the query tool under Firefox. Fixes #1680
2016-11-18 14:24:16 +00:00
6e68e7501a
Display messages and notices received in the query tool. Fixes #1953
2016-11-18 13:53:57 +00:00
687f1f640f
Prevent users selecting elements of the UI that shouldn't be selectable. Fixes #1976
2016-11-18 10:55:00 +00:00
00d2ab0338
Cast OIDs to oid not int, otherwise we lose half the range which results in objects not being accessible. Fixes #1951
2016-11-11 14:36:41 +00:00
7da3ece169
Ensure all changes to rows are stored in the data editor. Fixes #1919
2016-11-07 15:07:43 +00:00
1e66119ef5
Ensure the File Manager honours the file type while traversing the directories. Fixes #1858
...
When a File Manager is closed by clicking cancel button. Its dom element not destroyed.. So on traversing into directories, when it tries to get currently selected file type, it looks into the dom element but it gets dom of previous dialogs not of currently dialog.
Now whenever an instance of File Manager is closed. its dom elements are also destroyed.
2016-10-21 14:26:12 +01:00
0bf48d06fb
Ensure the view data filter box is usable. Fixes #1733
2016-09-26 10:50:09 +01:00
2d222067b9
Fix layout of the filter box.
2016-09-26 10:48:31 +01:00
7a40171300
Handle nested JSON correctly in SlickGrid. Fixes #1713 . Fixes #1404
2016-09-21 13:43:27 +01:00
28ce31a022
Save error details when executing to CSV, if no data is returned. This ensures the user gets some feedback rather than nothing at all. Fixes #1592
2016-09-20 11:57:51 +01:00
c044af9585
Bulk delete rows in SlickGrid. Fixes #1696
2016-09-16 16:46:58 +01:00
2f32427c59
Fix an issue in the Query Tool which causes it to hang in some installations of Chrome 53.0.2785.116 on Mac.
...
This commit also modifies the Query Tool to load SlickGrid using require.js.
2016-09-16 10:18:49 +01:00
016de5dc88
Fix scrolling in the query tool editor. Fixes #1579
2016-09-15 10:15:00 +01:00
3807ba047b
Don't have the query tool try to load arrow_right_spearmint.png. Fixes #1693
2016-09-14 16:12:49 +01:00
db7b8a8fa5
Don't disable the save button when executing a query in the query tool. Fixes #1695
2016-09-14 11:22:54 +01:00
751327eacc
Ensure View Data on a table with zero columns doesn't throw an error. Fixes #1677
2016-09-14 10:43:08 +01:00
ffc58b74d2
Allow viewing of long data values in the grid. Fixes #1672
2016-09-12 12:39:40 +01:00
982c291a31
Confirm loss of changes with the user before clearing the query or history, or opening a new file in the Query Tool. Fixes #1666
2016-09-08 09:12:48 +01:00
f13de8b86b
Ensure the query tool editor has focus when the tab is selected or when first shown so the user can immediately type/execute. Fixes #1581
2016-09-07 16:20:47 +01:00
8b61aa49d0
Warn the user about unsaved changes to SQL or data before closing the query tool. Fixes #1661
2016-09-05 17:18:43 +01:00
15df12c924
Highlight invalid rows when saving data in the edit grid. Fixes #1637
2016-09-02 16:05:00 +01:00
087332f32e
Fix the boolean editor, and warn the user if there are unsaved changed in the edit grid before refreshing.
2016-09-01 11:50:48 +01:00
8dca4b0e0b
Fixed an syntantical issue, which was not supported by QtWebkit.
...
The issue was regression of the patch for the 'SlickGrid'.
Fixes #1621
2016-08-30 14:43:50 +05:30
c56e4667df
SlickGrid Integration in to query tool. Fixes #1618
2016-08-29 20:17:01 +05:30
d5f6c63ead
More string tweaks.
2016-08-19 11:48:34 +01:00
761b54ce69
Allow the user to configure tabs in the SQL editor. Fixes #1406
2016-08-19 11:40:19 +01:00
d6391c7e9b
Properly display messages from the server in the query tool. Fixes #1523
2016-08-18 17:08:40 +01:00
6d839a2924
Prevent a query being executed whilst one is already in progress. Fixes #1532
2016-08-16 12:10:16 +01:00
035066bd41
Fix query tool button/menu inconsistencies. Fixes #1461
2016-08-09 16:23:24 +01:00
1bcac0b67c
Fix more of the funky keyboard shortcuts.
2016-08-08 15:26:37 +01:00
8e099e29c3
Fix various escaping issues. Fixes #1527
2016-08-05 12:20:00 +01:00
42f8745aba
Fix error running VACUUM FULL FREEZE ANALYZE VERBOSE. Fixes #1519
2016-08-04 12:13:34 +01:00
cb35c46f03
Fix View Data options for tables with columns that need quoting. Fixes #1492
2016-08-04 11:54:36 +01:00
8c433fbfce
Fix display of numerics in the query tool. Fixes #1463
2016-08-04 11:31:24 +01:00
9c4eed70b4
Use the same keyboard shortcuts in the query tool as pgAdmin 3. Refs #1478
...
Per discussion on the mailing list, the shortcuts override the browser defaults (where there are any), but only when the query tool has focus.
2016-08-01 15:10:52 +01:00
f4f8273994
Display basic query info when execution completes in the query tool. Fixes #1507
2016-07-27 11:36:13 +01:00
06e881570a
Fix numerous encoding issues. Fixes #1307 . Fixes #1479
2016-07-26 15:05:14 +01:00
9dd3cf2399
Make Save/Save As menu options work a little more sanely. Fixes #1460
2016-07-25 12:55:06 +01:00
60659975ed
Stop using deprecated imports.
2016-07-22 16:25:23 +01:00
a7d7577c7c
Query tool file handling cleanup. Fixes #1460
...
- Opening a file should set the tab name to the filename
- Editing a file should add a * to the tab name to indicate the file is dirty
- Saving changes to a file should clear the *
- The Save button should have a drop-down menu, with a Save As option.
2016-07-21 13:44:42 +01:00
83a1535f89
Fix saving of query output as CSV data. Fixes #1405
2016-07-18 15:29:09 +01:00
9ba6bafb2b
Using own version of cursor class to allow us to take care of the
...
duplicate name in column description.
2016-07-16 10:42:51 +05:30
d15dfac60f
FIx a hang in the query tool that could occur if a column type couldn't be determined. Fixes #1438
2016-07-15 12:59:01 +01:00
517a797947
Fix query tool display of various types:
...
date
reltime
abstime
time with timezone
time without timezone
2016-07-15 11:59:45 +01:00
1a129cf30e
File management dialogue enhancements:
...
- Double click on file/folder icon or name will navigate to the folder/file.
- Selected file/folder can be renamed by Rename button only. Double click rename is removed.
- Filename text box will not hide on smaller screen. Setting minimum width of File Browser fixed it.
- Path at top will only show directory name, not the file name and it is greyed out
2016-07-15 10:50:25 +01:00
9ad0bd1026
Fix clear query option which was opening a query tool in new window in Mac Runtime
2016-07-13 12:35:22 +01:00
d22ea8bf61
Properly support file downloads in the desktop runtime. Fixes #1405 . Fixes #1342
2016-07-13 12:26:24 +01:00
52d1af63a5
Scroll to the new row when adding one in the query tool. Fixes #1435
2016-07-07 12:35:44 +01:00
6c6660e576
Resolve "Move to last page" warning shown unnecessarily issue. Fixes #1422
2016-07-05 12:20:40 +01:00
1bd27b847b
Grey the SQL panel in edit data mode. Fixes #1423
...
Introduced a new class 'cm_disabled' with css property background-color to '#EEEEE'
Query tool in edit mode, add the class 'cm_disabled' to set background color to dark and set the cursor property to 'nocursor' to disable editor.
Increased the query tool title padding to fix the issue of whitespace below the title.
2016-07-05 12:11:36 +01:00
3ee8861d44
Fix JSON type rendering. Fixes #1404
2016-07-04 10:05:59 +01:00
aa44122a8a
Fix query execution keys in the Mac runtime. Needs more work to sanitize with CodeMirror, but this is a step further. Fixes #1336
2016-06-30 09:56:15 +01:00
0282ef7992
Use a standard colour for error highlighting.
2016-06-29 20:54:08 +01:00
53434030c1
Consistent busy indication. Fixes #1242
2016-06-29 12:16:02 +01:00
1222681888
Revert "Display busy indicators in a much more consistent way. Fixes #1242"
...
This reverts commit 7fbefa507b
2016-06-29 10:32:20 +01:00
7fbefa507b
Display busy indicators in a much more consistent way. Fixes #1242
2016-06-27 17:09:37 +01:00
7d0fe669ca
Code tidy.
2016-06-21 14:21:06 +01:00
3026b470e9
Optimise Python imports.
2016-06-21 14:12:14 +01:00
237f93591f
Keyboard shortcuts in the Query Tool:
...
Execute --> Ctrl + Shift + E
Explain --> Ctrl + Shift + X
Explain analyze --> Ctrl + Shift + A
2016-06-20 13:03:46 +01:00
c04b729c1d
Set the minimum value to 50 and maximum value to 2000 for the items per page in the result grid
2016-06-20 16:23:49 +05:30
05e7ee5a05
Second attempt at fixing the file handling code. Tested on Mac and Windows in both desktop and server modes.
2016-06-17 22:05:49 +01:00
2c62d1a4b7
Revert "Make the file manager work a little more sanely with regard to paths."
...
This breaks things even more on Windows :-(
This reverts commit 35243b9869
2016-06-17 18:19:51 +01:00
35243b9869
Make the file manager work a little more sanely with regard to paths.
2016-06-17 17:12:04 +01:00
359b1d0176
Use a separate class to remove the footer space in the query editor,
...
when no of records in a page is set to 0 (or, less than 0). So that -
we do not loose CSS applied on the children DOM Elements dependent of
the original class.
This was regression of commit-id:
f9393aee44
2016-06-17 15:11:47 +05:30
f9393aee44
Allow a value of 0 rows per page to mean "no paging". Allow rows to be added on any page.
...
Fixes #1356
2016-06-16 09:57:44 +01:00
677008af10
Fix file type detection for Python 2.6. Fixes #1330
...
To find out the type of file selected using FileManager in query tool, we use bitwise OR( | ) on two sets which is not working on python-2.6.9 version.
Now we took list of elements instead of sets to fix the issue.
2016-06-13 16:35:11 +01:00
9e8e3fc787
Fix file selection on Windows. Fixes #1319
...
1) Unable to select sql file through query tool on windows OS. In file_manager.js, we are stripping initial slash '/' from the path obtained, but we should not strip if it is full path like 'c:/path/to/dir/filename.ext'
2) Handle directory path if STORAGE_DIR is None. Proper checks are added.
2016-06-10 17:06:22 +01:00
967159664e
Fixes #1303 Query with Order by clause is not working in Query Tool
2016-06-03 14:40:57 +05:30
1bd37d1f76
Fixes #1275 Issue with Query tool for PPAS - not showing the correct output
2016-06-03 14:34:50 +05:30
278f18bab8
Fixes #1243 - Allow to resize the columns of the result table in the
...
Query editor.
2016-06-02 14:46:58 +05:30
486da5e12c
Fixed issue only coming in the runtime.
...
* Do not need to translate an empty string. (that results into the
translation header inclusion in the javacript module).
* String.prototype.StartsWith is not an well received function, it has
not been available in the QWebkit for linux.
2016-06-02 13:15:26 +05:30
f4938beb3c
Error out - when user tries to load a binary file in the Query Editor.
2016-05-25 17:51:44 +05:30
d4644428e6
Fixes #1217 - Added support for the context menu - 'View Data' for the
...
Materialized View.
2016-05-25 00:02:52 +05:30
0a354055a9
Adding support for autocomplete in the SQL Editor.
...
In Query editor, we can use the autocomplete feature by using keyword
combination - 'Ctrl + Space'.
2016-05-21 16:04:29 +05:30
8312efe927
Fixed issue of getting/setting preferences options for 'Explain'
2016-05-17 14:38:44 +05:30
216b6b16b5
Fixed issue change 'Auto Commit' option from preferences not reflacted properly on UI and also not set the class variable
2016-05-17 12:31:39 +05:30
fcc3d112e2
Integrate the graphical explain module in the Query Editor.
...
Added few TODO list for the graphical explain module by Ashesh.
2016-05-16 01:07:54 +05:30
5ca63fba48
Initial version for generationg the CREATE/SELECT/EXEC scripts for the
...
selected node.
2016-05-16 00:25:34 +05:30
1aeab98a2b
Load, and save the files in the Query Editor.
...
Also, the changes done by Ashesh to resolved few issue with the file
manager in 'Select' mode.
2016-05-14 15:29:08 +05:30
949e536bae
First round of string review and cleanup.
2016-05-06 13:53:48 +01:00
894002b06d
Fixed below review comments for QueryTool
...
- The button bar be moved out into an HTML template
- create.sql should perhaps be renamed to insert.sql
- The "Add Row" button only works if you're on the last page of the resultset.
- Use one wcDocker instead of two
- Added support of code folding
2016-05-06 18:09:04 +05:30
9dd3aeadb5
Do not close the menu, when clicking on the menu with checkbox.
...
Introduced a class 'noclose'. Then - menu-item having this class will
not propograte the events to its parent, hence - it will not be closed.
Some of the CSS applicable only to the immediate buttons only, and not
the grand-children.
2016-04-25 22:06:42 +05:30
a5aa6d159a
Updated the CodeMirror to the latest stable version (5.14.2).
...
It has now the 'sql/x-pgsql' mode, which will make the queries more
familiar, and lot more improved addons.
2016-04-22 15:28:34 +05:30
4d7d3bd5e1
Icon and toolbar cleanup/consistency.
2016-04-15 13:32:17 +01:00
9c65b73f31
Fix "View Filtered Rows" option.
2016-04-15 08:52:27 +01:00
c6acbcb5ad
Query tool/data editor initial version
2016-04-14 15:04:03 +01:00
Surinder Kumar
George Gelashvili
Shruti B Iyer
Ashesh Vashi
Khushboo Vashi
Murtuza Zabuawala
Dave Page
Joao Pedro De Almeida Pereira
Matthew Kleiman
RAJASEKAR G
Jonas Thelemann
Akshay Joshi
Wayne Winch Jr
Harshal Dhumal
Atira Odhner
Sarah McAlear
George Gelashvili
Ashesh Vashi
Neel Patel
Sanket Mehta
Karen Blatchley