Ashesh Vashi
b7c5039416
Fix process execution. Fixes #1679 . Fixes #2144 .
...
Re-engineer the background process executor, to avoid using sqlite as some builds of
components it relies on do not support working in forked children.
2017-02-04 15:26:57 +01:00
Surinder Kumar
54ba1fbe59
Support setting text fields to empty strings or NULL in the data editor grid. Fixes #1790
2017-02-04 14:10:30 +01:00
Neel Patel
c17e201a92
Handle saved directories that no longer exist gracefully. Fixes #2110
2017-02-03 15:19:21 +01:00
Murtuza Zabuawala
bf8c3c4180
Handle sized time/timestamp columns correctly. Fixes #2076
2017-02-03 14:51:58 +01:00
Khushboo Vashi
f2ac6fc6a7
1) Wrong tablespace displayed in table properties. Fixes #2069
...
2) Message (Connection to the server has been lost.) displayed with Materialized view and view under sql tab. Fixes #2139
2017-02-03 16:13:07 +05:30
Harshal Dhumal
4ef26a528b
Allow direct navigation (i.e. typing of paths) in the file manager. Fixes #1911
2017-02-03 10:51:36 +01:00
Murtuza Zabuawala
687a793383
Fix display of zeros in read-only grid editors. Fixes #2138
2017-02-01 13:48:46 +00:00
Murtuza Zabuawala
2d442da9ff
Properly handle setting comments and other options on databases with allowconn = False. Fixes #2024
2017-02-01 10:23:45 +00:00
George Gelashvili
6d05302ca1
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3.
2017-02-01 09:57:49 +00:00
Murtuza Zabuawala
0da8d1fe4c
Another Python 3 fix.
2017-01-31 12:12:22 +00:00
Murtuza Zabuawala
2e5771e164
Python 3 fix for the template loader test.
2017-01-31 10:02:20 +00:00
Atira Odhner
c6b67fc66a
Bypass recovery checks with older servers. This is required for Greenplum which is based on PG 8.3 at present.
2017-01-30 17:02:55 +00:00
Surinder Kumar
30e546208f
Ensure dialogues cannot be moved under the navbar. Fixes #2047
2017-01-30 14:02:01 +00:00
Murtuza Zabuawala
e8f0cf6d94
Resolve various trigger issues. Fixes #2015
...
- Allow changing of row/statement flag
- When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, Row trigger etc. then new OID is getting generated so we should fetch and return new OID in response rather then old trigger OID.
2017-01-30 13:05:15 +00:00
George Gelashvili
19be3529f8
Create a template loader for SQL templates.
...
This will automatically find the correct version of a template for the server version, and allows us to remove templates that were previously duplicated for different server versions.
Patch by George & Tira at Pivotal. Review by me and Murtuza from EDB.
Discussion: https://www.postgresql.org/message-id/flat/CAHowoHaU9_pkCt%2B1g8dpY3hsXXZmsJZiJH-3-_Hd%2BC1MxiGhtA%40mail.gmail.com#CAHowoHaU9_pkCt+1g8dpY3hsXXZmsJZiJH-3-_Hd+C1MxiGhtA@mail.gmail.com
2017-01-30 11:25:03 +00:00
Surinder Kumar
e01cf748ea
Enable/disable NULLs and ASC/DESC options for index columns and exclusion constraints appropriately. Fixes #2061 . Fixes #1840 .
2017-01-25 13:21:39 +00:00
Murtuza Zabuawala
29a6f2e124
Fix Reset Statistics operation for which the popup messages weren't displaying correctly. Fixes #2091
2017-01-24 10:19:33 +00:00
Dave Page
801c7688a3
A little message cleanup.
2017-01-24 10:18:30 +00:00
Harshal Dhumal
415119d581
Properly remove any event listeners added by subnode control.
2017-01-20 13:24:37 +00:00
Dave Page
ac4178233b
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024"
...
This reverts commit e431eb9d8e
.
2017-01-20 13:21:05 +00:00
Murtuza Zabuawala
6557433061
Fix display of enum GUCs on users/databases etc. Fixes #2067
2017-01-17 10:45:01 +00:00
Murtuza Zabuawala
28621999f2
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065
2017-01-17 10:25:26 +00:00
Murtuza Zabuawala
e431eb9d8e
Handle comments on databases with datallowconn=False correctly. Fixes #2024
2017-01-16 15:42:25 +00:00
Neel Patel
0d4bc0d27d
Store layout changes on each adjustment, rather than on unload which is unreliable. Fixes #1967
...
We also use an async request now, rather than a deprecated sync request.
2017-01-16 15:34:55 +00:00
Khushboo Vashi
024b664c21
Improve the display of role membership on both the properties panel and role dialogue. Fixes #1730
2017-01-16 14:48:25 +00:00
Dave Page
a85861ca57
Remove some comments that don't fit with our normal presentation of generated SQL.
2017-01-16 14:46:44 +00:00
Surinder Kumar
86f6857cb7
Fix sorting of numerics in the statistics grids. Fixes #1938
2017-01-09 15:55:38 +05:30
Murtuza Zabuawala
4c19f93b3b
Use the correct OID for retrieving properties of freshly created exclusion constraints. Fixes #1896
2017-01-09 15:05:22 +05:30
Surinder Kumar
e400693126
Add BigNumberJS library for upcoming large number related fixes.
2017-01-09 09:07:21 +05:30
Surinder Kumar
b14f8239d2
Fix a SQL error when reverse-engineering ROLE SQL on EPAS servers. Fixes #1830
2017-01-09 08:14:34 +05:30
Khushboo Vashi
01b2288d57
Ensure columns with types that are not in pg_catalog are handled properly in the table dialog.
2017-01-09 08:05:51 +05:30
Surinder Kumar
d05534ad6c
Prevent attempts to access what may be an empty list. Fixes #1832
2017-01-09 07:56:02 +05:30
Neel Patel
d87345ef52
Ensure breakpoints are cleared properly when clearing all of them. Fixes #1745
2017-01-08 19:05:13 +05:30
Navnath Gadakh
1325b30e0b
Various improvements to the regression tests, notably avoiding use of signals unavailable on Windows.
2017-01-08 18:48:04 +05:30
Murtuza Zabuawala
bdf9761472
Improve consistency of dialogue controls offered. Fixes #1364
2017-01-08 16:05:34 +05:30
Neel Patel
8d71e888b4
Remember the last used directory in the file manager. Fixes #1910
2017-01-08 15:27:59 +05:30
Dave Page
5d0a0e57e7
Allow selection of message box contents for ease of error message copy/paste.
2017-01-08 15:27:58 +05:30
Neel Patel
2787c5c207
Reset the column list properly if the access method is changed on an index to ensure error handling works correctly. Fixes #2009
2017-01-08 15:27:58 +05:30
Surinder Kumar
6e14bef801
Show icons for unique and exclusion constraints in the dependency/dependents panels. Fixes #2033
2017-01-08 15:27:58 +05:30
Murtuza Zabuawala
879a6bef53
Fix keyboard control of switches in the column grid. Fixes #1394
2017-01-08 15:27:58 +05:30
Neel Patel
a33ee2ae32
Improve detection of the pldbgapi extension and functions before allowing debugging. Fixes #2026
2017-01-08 15:27:58 +05:30
Surinder Kumar
e3c8cb2706
Prevent attempts to create server groups with no name. Fixes #2012
2017-01-08 15:27:58 +05:30
Akshay Joshi
ae809c4506
Properly detect when files have changed in the query tool and set the dirty flag accordingly. Fixes #1807
...
Note that (like pgAdmin 3) we don't make any attempt to detect if all changes have been undone and completely reverted as that could be very expensive with large scripts.
2017-01-08 15:27:58 +05:30
Surinder Kumar
07e1c61eea
Allow setting of effective_io_concurrency on tablespaces in 9.6+. Fixes #2000
2017-01-08 15:27:58 +05:30
Dave Page
a93a99fdc0
Improve query plan tooltip formatting.
2017-01-06 15:38:27 +00:00
Dave Page
1504d05cdd
Format JSON more efficiently. This can significantly reduce response sizes from the server.
2017-01-06 14:09:36 +00:00
Dave Page
fe9bdc62a1
Fix copyright notices.
2017-01-04 13:35:38 +00:00
Dave Page
560395e557
Tidy up file header
2017-01-04 13:34:17 +00:00
Dave Page
f221194bcc
Update copyright notices for 2017.
2017-01-04 13:33:32 +00:00
Dave Page
87d4937726
Minimise memory requirements for rendered cells and rows in SlickGrid. Fixes #2035
...
- The CSS class 'slick-row' has been renamed to 'sr'
- The CSS class 'slick-cell' has been renamed to 'sc'
- The SQL Editor included an unused 'normal_row' class on each row which has been removed as it was unreferenced in the code or CSS.
The intent of these changes is to minimise memory usage by the grid, by saving a few bytes per row/cell.
It's questionable how much difference this actually makes given that SlickGrid updates the document so it
only includes the visible rows on the fly, but every little helps.
2016-12-22 17:43:42 +00:00
Murtuza Zabuawala
43b9e53572
Fix word wrap in note control.
2016-12-21 13:17:11 +00:00
Dave Page
99299f022f
Fix time formatting on dashboards. Fixes #2032
2016-12-21 12:01:43 +00:00
Dave Page
d3862eef3f
Fix some additional table styling inconsistencies.
2016-12-19 14:26:33 +00:00
Dave Page
ef5b8fe603
Clarify the close browser warning.
2016-12-19 12:12:43 +00:00
Khushboo Vashi
5008872203
Ensure the SQL editor has enough space to show block folding arrows in the gutter.
2016-12-19 11:35:27 +00:00
Harshal Dhumal
5adc6b71ca
fix display of double scrollbars on the grant wizard. Fixes #2028
2016-12-19 09:25:14 +00:00
Harshal Dhumal
2994c128f3
Fix inconsistent table styling. Fixes #2027
2016-12-19 09:21:49 +00:00
Murtuza Zabuawala
6fc8f040ff
Allow users to enable wrapping of code in SQL boxes. Fixes#2025
2016-12-16 17:07:41 +00:00
Khushboo Vashi
1d571902da
Fix regression when generating SQL for new databases, caused by an invalid check of datallowconn introduced in the fix for #1801 .
2016-12-16 13:12:12 +00:00
Khushboo Vashi
53ea991907
Properly size the SQL Editor gutter as the width of the line numbers increases. Fixes #1780
2016-12-16 13:04:16 +00:00
Murtuza Zabuawala
1431dfcb01
Show index columns in the correct order in RE-SQL. Fixes #1842
2016-12-16 11:59:37 +00:00
Akshay Joshi
686237413c
Use more sensible column sizes for the data output in the query tool. Fixes #1789
...
Per Akshay:
I have tried to get the width of the content but we are sending complete data as collection to the SlickGrid. We will have to fetch the content of each column and figure out the maximum length for that column by iterating all the rows is too expensive. Apart from that to set the width in 'ch' we will have to do it using css. With current implementation we are setting the column option of the SlickGrid from javascript code.
I have fixed this issue by setting the width of the columns based on data type. I have set the width of boolean column to 60, all the numeric/integer columns to 80 and for all other data types it is 20% of the container width as 33% is too wide.
2016-12-12 10:13:53 +00:00
Khushboo Vashi
53481023fa
Properly sort rows by the pkey when viewing first/last 100. Fixes #2007
2016-12-12 10:06:34 +00:00
Ashesh Vashi
dbff4f7977
Minor Python 3/encoding fix in the file manager.
2016-12-12 09:49:00 +00:00
Dave Page
4a280b2517
Only show the filename in query tool tabs, not the whole path.
2016-12-09 12:42:30 +00:00
Akshay Joshi
b8d03d5dc2
Don't cast data when saving in the edit grid, so errors are seen and data doesn't get silently modified. Fixes #1994
2016-12-09 12:05:46 +00:00
Khushboo Vashi
81841cdb3c
Treat databases with datallowconn=false appropriately. Fixes #1801
2016-12-09 11:59:13 +00:00
Anthony DeBarros
6ff2fe64b8
Fix various mis-spellings of VACUUM. Fixes #2005
2016-12-08 10:35:53 +00:00
Dave Page
eb337cadce
Remove unused rows per page config option.
2016-12-05 13:59:44 +09:00
Akshay Joshi
e160909423
Quote identifiers correctly in auto-complete. Fixes #1992
2016-12-05 13:15:03 +09:00
Surinder Kumar
a64824a851
Fix various encoding issues with multibyte paths and filenames.
...
Fixes #1986 . Fixes #1940 .
2016-12-05 13:10:56 +09:00
Neel Patel
54e6336a58
Deal with Function arguments correctly in the properties dialogue. Fixes #1979
2016-11-25 10:55:10 +00:00
Murtuza Zabuawala
66b9e22d01
Handle the template property on databases appropriately. Fixes #1800
2016-11-25 10:11:40 +00:00
Dave Page
394381bf75
Add search/replace support to the Query Tool, including regexp matching. Fixes #1765
2016-11-24 15:38:39 +00:00
Dave Page
1a18e07329
Allow a placeholder ($DIR) to be used in utility paths to make it easier to use relative paths.
2016-11-23 13:35:27 +00:00
Dave Page
08396ce861
Allow default binary paths to be set in the config for each database driver.
2016-11-23 12:44:13 +00:00
Dave Page
961f946a76
Treat empty text settings as unset, to allow users to clear a string to get the default back.
2016-11-23 12:43:02 +00:00
Dave Page
8ae4a10c64
Apparently Flask-HTMLmin still requires django-htmlmin
2016-11-21 13:37:52 +00:00
Dave Page
020bf1d532
Minify HTML with Flask-HTMLMIN
2016-11-18 16:42:38 +00:00
Murtuza Zabuawala
b7c819e912
Render column headers at the correct width in the query tool under Firefox. Fixes #1680
2016-11-18 14:24:16 +00:00
Khushboo Vashi
54b35c711d
Ensure dialogue panels show their errors themselves, and not in the properties panel. Fixes #1855
2016-11-18 14:05:39 +00:00
Murtuza Zabuawala
6e5126d571
Add newly created triggers to the treeview. Fixes #1747
2016-11-18 13:58:35 +00:00
Murtuza Zabuawala
6e68e7501a
Display messages and notices received in the query tool. Fixes #1953
2016-11-18 13:53:57 +00:00
Khushboo Vashi
6567669798
Ensure the check_option is only set when editing views when appropriate. Fixes #1924
2016-11-18 13:44:43 +00:00
Dave Page
29743ad3c4
Allow selection of process output and commands.
2016-11-18 12:05:19 +00:00
Dave Page
687f1f640f
Prevent users selecting elements of the UI that shouldn't be selectable. Fixes #1976
2016-11-18 10:55:00 +00:00
lambda
e3c8b67767
Add a Chinese (Simplified) translation. Fixes #1963
2016-11-16 09:45:22 +00:00
Khushboo Vashi
48b0a3f2d2
Ensure treeview collection nodes are translated in the UI. Fixes #1962
2016-11-16 09:25:38 +00:00
Daniel Hahler
c0da81e8ec
Fix upgrade check on Python 3. Fixes #1961
2016-11-16 09:13:59 +00:00
Khushboo Vashi
12d75e0a51
Styling improvements for password input fields in backgrid.
2016-11-15 09:55:32 +00:00
Dave Page
7ce04bbaea
Add missing translation tags.
2016-11-15 09:31:39 +00:00
Khushboo Vashi
83a1808bfd
Move some DOM elements out of the global context.
2016-11-14 13:13:58 +00:00
Dave Page
052a9fc840
Add missing strings from the dashboards.
2016-11-14 12:04:28 +00:00
Dave Page
74e5b5a492
Include SQL templates in the translation template.
2016-11-14 11:53:20 +00:00
Murtuza Zabuawala
00d2ab0338
Cast OIDs to oid not int, otherwise we lose half the range which results in objects not being accessible. Fixes #1951
2016-11-11 14:36:41 +00:00
Murtuza Zabuawala
6f30cabdbb
Resolve various debugger quirks. Fixes #1227
...
- Prevent the user from executing multiple options at once, resulting in "Execute cannot be used while an asynchronous query is underway********** Error ****" messages
- Stop polling when debugging is complete.
- Don't show the busy cursory when debugging is complete.
- Display info messages properly, and reset them between executions.
2016-11-11 14:25:11 +00:00
Murtuza Zabuawala
f405cdf383
Ensure trigger function names are schema qualified in trigger RE-SQL. Fixes #1949
2016-11-11 13:46:06 +00:00
Navnath Gadakh
7b574b284d
Fix TypeError.
2016-11-10 12:48:38 +00:00
Murtuza Zabuawala
36c909b1f9
Generate mSQL for new schemas correctly. Fixes #1937
2016-11-09 15:13:17 +00:00
Murtuza Zabuawala
c345adaa52
Properly format arguments passed by triggers to functions. Fixes #1912
2016-11-09 15:00:35 +00:00
Akshay Joshi
7da3ece169
Ensure all changes to rows are stored in the data editor. Fixes #1919
2016-11-07 15:07:43 +00:00
Dave Page
ca333ea6a7
Don't strip \r\n from "Download as CSV" batches of rows, as it leads to malformed data. Fixes #1936
2016-11-07 14:47:50 +00:00
Dave Page
8bb656c002
Translation catalog update.
2016-11-07 12:45:13 +00:00
Dave Page
f736051309
Handle broken config databases much more gracefully. Fixes #1922
2016-11-02 17:00:26 +02:00
Akshay Joshi
c2d9c0bb7c
Improve display of role options. Fixes #1729
2016-11-01 11:44:32 +02:00
Murtuza Zabuawala
a3622a380a
Fix display of exclusion contraint dependencies. Partially fixes #1892 - requires icon display fix.
2016-11-01 11:35:09 +02:00
Murtuza Zabuawala
ca57323ad1
Properly schema qualify domains when reverse engineering SQL. Fixes #1865
2016-10-28 16:45:06 +01:00
Murtuza Zabuawala
67e5dfa5a7
Fix refreshing of Unique constraints. Fixes #1893
2016-10-28 16:40:27 +01:00
Murtuza Zabuawala
8c48be3b0c
Properly quote role names when specifying function ownership. Fixes #1899
2016-10-28 16:18:31 +01:00
Dave Page
c1c2fb9df9
Ensure sequence start value is shown in SQL and properties list. Fixes #1155
2016-10-24 09:27:16 +01:00
Surinder Kumar
19bd021696
Ensure select2 instances have a destroy property before calling destroy.
2016-10-21 16:16:10 +01:00
Harshal Dhumal
2952faab5e
Fix exclusion constraint support on 9.6. Fixes #1875
2016-10-21 16:14:19 +01:00
Surinder Kumar
23a0fc2f22
Fix refreshing of FTS Dictionaries. Fixes #1837
2016-10-21 16:07:45 +01:00
Dave Page
ef0d26c294
Ensure steps and schedules can be created in empty jobs. Fixes #1878
2016-10-21 16:00:23 +01:00
Murtuza Zabuawala
e6d018c44f
Ensure we handle external processes that fail to start. Fixes #1679
2016-10-21 15:35:06 +01:00
Surinder Kumar
8e9108e0f3
Allow package bodies to be dropped. Fixes #1867
2016-10-21 15:24:11 +01:00
Khushboo Vashi
a97d21cc90
Ensure preferences values are stored properly. Fixes #1877
2016-10-21 15:06:45 +01:00
Khushboo Vashi
5a1795e4a0
Fix quoting of objects names for external utilities. Fixes #1603 , fixes #1220 , fixes #1221
2016-10-21 14:57:19 +01:00
Harshal Dhumal
aef508ff91
Properly quote type names in RE-SQL for tables. Fixes #1863
2016-10-21 14:43:57 +01:00
Surinder Kumar
da3a37ab19
Handle non-ascii responses from the server when connecting. Fixes #1822
2016-10-21 14:32:25 +01:00
Surinder Kumar
1e66119ef5
Ensure the File Manager honours the file type while traversing the directories. Fixes #1858
...
When a File Manager is closed by clicking cancel button. Its dom element not destroyed.. So on traversing into directories, when it tries to get currently selected file type, it looks into the dom element but it gets dom of previous dialogs not of currently dialog.
Now whenever an instance of File Manager is closed. its dom elements are also destroyed.
2016-10-21 14:26:12 +01:00
Surinder Kumar
406dab069d
Show security labels in the reverse engineered SQL for domains. Fixes #1574
2016-10-21 12:49:50 +01:00
Surinder Kumar
d806a9ce9e
Fix the file manager when used under Python 3. Fixes #1872
...
Issues fixed:
1) In Python 3, parameter "cmp" is removed from sorted method. So File Manager won't open.
As we are sorting data on JS side using Natural sort, so on server side sorting is not required.
2) Improvement in Exception handling.
2016-10-21 12:43:02 +01:00
Murtuza Zabuawala
d29ccea299
Don't allow setting of security labels on edbspl stored procedures (by correctly checking the node type). Fixes #1576
2016-10-21 12:37:47 +01:00
Navnath Gadakh
1908e86d22
Resolve a PG 9.6 compatibility issue in the regression test for Languages.
2016-10-21 12:24:26 +01:00
Surinder Kumar
48ee8490f0
Add new indexes to the correct parent on the treeview. Fixes #1880
2016-10-21 12:12:37 +01:00
Surinder Kumar
06039320b9
Don't specify ASC/DESC options for index types that don't support them. Fixes #1840
2016-10-21 12:08:41 +01:00
Harshal Dhumal
6874a1a247
Properly generate exclusion constraint SQL. Fixes #1861
2016-10-21 12:04:30 +01:00
Surinder Kumar
9155c2111f
Ensure the grant wizard works with objects with special characters in the name. Fixes #1599
2016-10-21 11:58:46 +01:00
Akshay Joshi
76fb831554
Fixed issue where some parameter like 'Volatility, LeakProof , Variables etc..' not visible in SQL definition for functions and trigger functions.
2016-10-20 19:07:51 +05:30
Dan Vianello
6c5d81b6f5
Fixes #1843 Function definition does not match value returned from pg_get_functiondef()
2016-10-20 18:30:43 +05:30
Ashesh Vashi
b17eb15742
Resolved - Integer type of preferences are not updated
...
Reason: IntegerControl assumes the model, passed to it, would always has errorModel variable set properly.
In order to resolve it, now using pgBrowser.DataModel instead of Backbone.Model, which initialize the errorModel by default.
Fixes #1868
2016-10-19 16:18:22 +05:30
Dave Page
bc5cc964a3
Move security keys into the SQLite database, and auto-generate them.
...
This avoids packagers having to deal with the issue, which can be
difficult if they need to cater for both server and desktop modes.
Fixes #1849
2016-10-19 09:22:38 +01:00
Priyanka Shendge
c4f1b8eb11
Add tests for Languages
2016-10-18 14:36:25 +01:00
Dave Page
62a35f24e7
Fix layout of DateTimePicker control help message. Fixes #1864
2016-10-18 12:43:58 +01:00
Murtuza Zabuawala
b9571df4de
Don't append new objects to the wrong parent, if the correct one isn't loaded. Fixes #1838
2016-10-18 12:37:44 +01:00
Navnath Gadakh
e31ba5873b
Add regression tests for resource groups on EPAS.
2016-10-18 12:01:01 +01:00
Dave Page
8d2dff1482
Always create databases from template0 when running regression tests, to ensure consistency and avoid concurrency issues.
2016-10-18 11:57:31 +01:00
Surinder Kumar
df09f02e80
List files/folders alphabetically, and don't excessively truncate their names. Fixes #1792
2016-10-18 11:39:12 +01:00
Surinder Kumar
11e486f96d
Fix unsafe schema lookups for types. Fixes #1728
2016-10-18 11:32:43 +01:00
Dave Page
d0a9b25c57
Cleanup the dashboard tables a little for readability
2016-10-14 17:42:29 -07:00
Dave Page
faf517e12b
Include wait information on the activity tab of the dashboards. Fixes #1859
2016-10-14 17:18:17 -07:00
Surinder Kumar
dd6a69d845
Handle reverse engineering of synonyms with / in the name. Fixes #1622
2016-10-14 16:01:55 -07:00
Akshay Joshi
2d39b5fb41
Identify the collation correctly when reverse engineering table SQL. Fixes #1847
2016-10-14 15:57:55 -07:00
Surinder Kumar
c7520cf86d
Allow refreshing of synonym nodes. Fixes #1845
2016-10-14 15:50:20 -07:00
Surinder Kumar
17bd379cb6
Properly quote names when renaming FTS dictionaries and templates. Fixes #1857
2016-10-14 12:23:10 -07:00
Surinder Kumar
7f507f294e
While clicking on Select2 control, it tries to destroy the control and thus it doesn't get this object sometimes and throws error.
...
It should attempt to destroy the select2 object only if this object is not undefined.
2016-10-14 12:20:29 -07:00
Surinder Kumar
0df968f679
Resolve issue with properties refreshing. Fixes #1728
...
1) If we create/update a node with non-default schema, It should return selected schema id in return response. but default schema id is returned every time due to which it throws error in properties panel.
Fixed in Domains, Collation, Types, Views & Table node.
2) Incorrect parent id of object node is returned from nodes method due to which wrong parent id is passed while updating object and
thus node didn't get refreshed.
Fixed in FTS Configuration, FTS Parser nodes.
2016-10-14 12:19:00 -07:00
Navnath Gadakh
404d4efd2e
Add test cases for tables, types, views and their children.
2016-10-14 11:20:51 -07:00
Priyanka Shendge
22dadacb0f
Add terst cases for packages, and update Synonym cases for recent API changes.
2016-10-14 10:59:36 -07:00
Priyanka Shendge
540c389d92
Add regression tests for Foreignb Tables.
2016-10-13 06:57:16 -07:00
Priyanka Shendge
8b91babdc2
Add regression tests for FTS nodes.
2016-10-13 06:54:23 -07:00
Navnath Gadakh
36c185e9dc
Fix regression test import issue.
2016-10-13 06:49:33 -07:00
Harshal Dhumal
713c692ddd
Fix View privilege management. Fixes #1531
...
1. Fixed update privileges for views and materialized views.
2. Apart from this fixed wrong sql for privilege update.
3. Fixed: Error message was not got cleared even after removing entry with error on privilege tab.
2016-10-10 09:42:22 +01:00
Dave Page
148808a17b
Fix label
2016-10-07 14:15:18 +01:00
Navnath Gadakh
ae612f5403
Major update to the test suite:
...
1. Code changes (due to drop objects functionality).
2. Quoting for database names in drop databases.
3. Code changes for import errors for pickle_path and advanced_config variables.
2016-10-07 13:59:43 +01:00
Dave Page
50658808d9
Ensure variable is defined before use.
2016-10-07 13:59:10 +01:00
Khushboo Vashi
50859f8369
Correctly identify server type upon first connection. Fixes #1785
2016-10-07 12:57:36 +01:00
Neel Patel
4e86345c28
Allow debugging of functions and procedures in packages on EPAS. Fixes #1577
2016-10-07 12:46:34 +01:00
Surinder Kumar
3963272523
Don't show Upload File icon unless it is in capabilities list [Storage Manager]. Fixes #1739
...
Issue:
When clicked on upload icon while saving a file prompt user to leave page. It is because the icon is a button and its type is set to submit which makes it to prompt, instead it should be 'button'
Storage Manager's menu items depends on capabilities list set by the module using it. If capabilities doesn't have 'upload' in it, It won't work. Upload button is bound to click event only when it is in capabilities.
Solution:
As upload button is being added only when it is in capabilities, so upload button html is removed from html file. It will not shown on UI untill it is in capabilities list.
2016-10-07 12:31:38 +01:00
Murtuza Zabuawala
c931d715ac
Fix refresh of Synonyms. Fixes #1611
2016-10-07 12:08:19 +01:00
Dave Page
a0aaa80029
Allow users to choose SELECT permissions for sequences in the Grant Wizard. Fixes #1835
2016-10-06 10:02:21 +01:00
Dave Page
f9320811d7
Allow users to choose SELECT permissions for tables in the Grant Wizard. Fixes #1835
2016-10-06 09:56:44 +01:00
Murtuza Zabuawala
bde3dd845b
Fix SSL setup. Fixes #1817
2016-10-05 13:05:10 +01:00
Susan Douglas
8b2832bbc7
pgAgent docs. Fixes #1824
2016-10-04 14:48:57 +01:00
Ashesh Vashi
e52aeecd20
Fixes# 1808 - Invalid date-time format was used in the Start/End time
...
for Job Schedule.
Thanks Susan for the report.
2016-10-04 10:18:37 +05:30
Dave Page
d4af70aeb9
Label corrections.
2016-10-03 14:20:04 +01:00
Surinder Kumar
e4d870cbe6
Ensure errorModel unset property properly in while adding a new server. Fixes #1786
2016-10-03 13:50:54 +01:00
Dave Page
a91f19a21d
Fix typo. Fixes #1596
2016-09-30 10:36:39 +01:00
Dave Page
49ee8abb72
Fix typo
2016-09-30 09:45:14 +01:00
Dave Page
6790f14c6c
Fix button label and colour
2016-09-26 16:10:00 +01:00
Dave Page
0ba2f46092
Update message catalogs
2016-09-26 15:57:03 +01:00
Ashesh Vashi
09c2d605c9
Prevent bigints getting rounded. Fixes #1547
2016-09-26 15:51:01 +01:00
Surinder Kumar
3b4776ab5f
Improve network/server activity feedback for the user. Fixes #1751
2016-09-26 15:10:38 +01:00
Dave Page
f9dacc5237
Fix label cpaitalisation
2016-09-26 15:04:47 +01:00
Surinder Kumar
0ae719dae0
Do not try to set in_recovery, is_replay_paused properties in the server
...
object, when data is not available.
2016-09-26 19:16:06 +05:30
Navnath Gadakh
a4aae4c245
Update role and tablespace tests to cleanup properly following a failure.
2016-09-26 14:02:59 +01:00
Murtuza Zabuawala
a0a6428e86
Ensure compatibility with newer sqlparse modules. Fixes #1725
2016-09-26 13:49:54 +01:00
Ashesh Vashi
e591c6b5c0
pgAgent misc fixes:
...
1. When an existing schedule updated, or a new schedule is added from a pgAgent job dialog, it was not able to generate the proper update SQL Query.
2. The SubNodeCollectionControl was not removing the grid, when it is being getting removed.
2016-09-26 13:43:13 +01:00
Ashesh Vashi
237bfd4882
pgAgent - add modules for jobs, steps and schedules. Fixes #1341
2016-09-26 12:04:10 +01:00
Dave Page
7f3ca548cd
Fix SQL box sizing.
2016-09-26 11:35:11 +01:00
Ashesh Vashi
912eebb583
Fix view creation. Fixes #1736
2016-09-26 11:00:18 +01:00
Dave Page
f51d8c72ef
Fix validation message
2016-09-26 10:57:16 +01:00
Ashesh Vashi
0bf48d06fb
Ensure the view data filter box is usable. Fixes #1733
2016-09-26 10:50:09 +01:00
Dave Page
2d222067b9
Fix layout of the filter box.
2016-09-26 10:48:31 +01:00
Ashesh Vashi
6999249dcd
Ensure the default schema is set when creating objects. Fixes #1735
2016-09-26 10:15:23 +01:00
Ashesh Vashi
b80cd43ae6
Misc changes
...
- Setting the CodeMirror height when panel is resized, which you had mentioned.
- Added a new CellEditor (DatetimePickerEditor) for datetime picker.
2016-09-26 10:04:49 +01:00
Ashesh Vashi
1c623c56e7
Fixes#1737 - Setting the schedma-id as the pid (parent-id) for the
...
sequences node instead of the server-id.
Due to this - during updating the sequence node, it was not able to find
out the correct parent node, and it was updating the existing node, but
- later it (considering the old node) was removed by the replace logic.
2016-09-24 14:25:16 +05:30
Murtuza Zabuawala
5c855234f8
Ensure we go back to the login page after logging out, when installed at a virtual root. Fixes #1691
2016-09-23 13:10:48 +01:00
Ashesh Vashi
8797b3f3bf
Change rolvaliduntil format to "YYYY-MM-DD HH:mm:ss Z" for consistency with the rest of the app.
2016-09-23 10:10:31 +01:00
Murtuza Zabuawala
f18c455411
Don't offer CREATE Script options on servers or server groups. Fixes #1578
2016-09-23 10:06:50 +01:00
Ashesh Vashi
163ae4d53d
Misc fixes and additions for pgAgent support:
...
- Added DatetimepickerControl, MomentCell (using moment.js)
- Used the 'DatetimepickerControl' in Role (Also - resolved an issue, when unset the datetime for 'Valid Until'.)
- Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent nodes.
- Fixed an issue with SubNodeCollectionControl, which was not starting the modification session of the child model, when created default value for collection is not null/undefined. And, hence - validation on the child model was not working.
- Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was not releasing the CodeMirror properly.
2016-09-22 15:27:59 +01:00
Murtuza Zabuawala
a113b43a1f
Add Packages as a synonym target type. Fixes #1611
2016-09-22 14:56:00 +01:00
Murtuza Zabuawala
f48f806657
Fix stats on PG 9.6. Fixes #1719
2016-09-22 14:17:47 +01:00
Murtuza Zabuawala
9a56fb552c
Ensure the favicon can be found. Fixes #1692
2016-09-22 13:07:07 +01:00
Navnath Gadakh
1cb5a7c7ca
Update regression tests to resolve issues where database/connections were getting mixed up.
2016-09-22 12:58:38 +01:00
Harshal Dhumal
f117685d77
Drop all connections from the connection manager when a server is dropped to avoid issues if sqlite reuses an ID. Fixes #1720
2016-09-22 12:57:52 +01:00
Dave Page
2077bd5fdc
Prevent browsers caching responses. Fixes #1171
2016-09-21 16:18:22 +01:00
Dave Page
7a40171300
Handle nested JSON correctly in SlickGrid. Fixes #1713 . Fixes #1404
2016-09-21 13:43:27 +01:00
Surinder Kumar
28ce31a022
Save error details when executing to CSV, if no data is returned. This ensures the user gets some feedback rather than nothing at all. Fixes #1592
2016-09-20 11:57:51 +01:00
Murtuza Zabuawala
f991354f9a
Handle composite type return values properly in the debugger. Fixes #1662
2016-09-20 11:27:51 +01:00
Surinder Kumar
febb1b80b1
Ensure items are properly added to the treeview when their parent has no pre-existing children. Fixes #1627
2016-09-20 11:18:07 +01:00
Ashesh Vashi
7ab0eb158f
Ensure jQuery is loaded before SlickGrid. Fixes #1712
...
Patch by Ashesh with contributions from Surinder.
2016-09-19 17:08:57 +01:00
Navnath Gadakh
c84fd83595
Enhanced summary output for the test suite.
2016-09-19 16:49:06 +01:00
Murtuza Zabuawala
881d2a60a4
Fix an exception that could occur when the browser pings the server following a restart. Fixes #1707
2016-09-19 15:57:52 +01:00
Murtuza Zabuawala
2440f89a71
Fix an issue where the edit icon vanished and the default tab wasn't shown when advanced-editing a column in the table dialogue. Fixes #1704
2016-09-19 15:37:04 +01:00
Surinder Kumar
cc0cb83277
Resolve a syntax error when updating packages with no body. Fixes #1588
2016-09-19 15:33:19 +01:00
Murtuza Zabuawala
82d63804c1
Resolve a refresh issue when updating packages. Fixes #1625
2016-09-19 09:41:13 +01:00
Murtuza Zabuawala
fc5ce22de9
Allow creation of objects in schemas with special chars in the name. Fixes #1598
...
This was caused through generation of SQL based on HTML-escaped labels, not the raw versions.
2016-09-16 17:02:57 +01:00
Murtuza Zabuawala
c044af9585
Bulk delete rows in SlickGrid. Fixes #1696
2016-09-16 16:46:58 +01:00
Murtuza Zabuawala
c5f04d03c6
Fix an issue where several default privileges cause error on database. Fixes #1670
2016-09-16 16:06:29 +01:00
Surinder Kumar
92bc312d2d
Fix updating of matview definitions. Fixes #1595
2016-09-16 15:41:07 +01:00
Magnus Hagander
ce20dbc25a
Add classid filter to queries on pg_depend. Fixes #1705
...
There are a number of cases where queries in both pgadmin4 and pgadmin3 are done against pg_depend but falis to constrain the query on classid.
In particular, if for example a constraint and a sequence exists with the same oid (which is perfectly valid, as they are in different tables), a column will suddenly refer sequences that are completely incorrect. When we look up sequences, we have to make sure we only match dependencies against pg_class.
2016-09-16 11:24:54 +01:00
Surinder Kumar
165b93a968
Fix a syntax error when creating a trigger function on PPAS 9.5+. Fixes #1600
2016-09-16 11:12:41 +01:00
Surinder Kumar
1ce5b38f4a
Fix an issue when changing the length of a column in the table dialogue. Fixes #1669
2016-09-16 11:09:13 +01:00
Ashesh Vashi
2f32427c59
Fix an issue in the Query Tool which causes it to hang in some installations of Chrome 53.0.2785.116 on Mac.
...
This commit also modifies the Query Tool to load SlickGrid using require.js.
2016-09-16 10:18:49 +01:00
Surinder Kumar
016de5dc88
Fix scrolling in the query tool editor. Fixes #1579
2016-09-15 10:15:00 +01:00
Ashesh Vashi
c48e8d415b
The Switch Dependency Cell, implemented in schema module, has a special
...
case. Its purpose is now to handle certain scinarios specific to table
children modules.
Renamed it to 'TableChildSwitchCell' from 'SwitchDepCell' to avoid any
conflict in future.
2016-09-15 13:36:56 +05:30
Navnath Gadakh
d3d8836f61
Introduce a test config database for the regression tests, and track/remove objects that are created during testing.
2016-09-14 16:26:12 +01:00
Murtuza Zabuawala
3807ba047b
Don't have the query tool try to load arrow_right_spearmint.png. Fixes #1693
2016-09-14 16:12:49 +01:00
Dave Page
fcc81d32cc
Fix condition check for avoiding sorting of columns.
2016-09-14 12:33:54 +01:00
Murtuza Zabuawala
db7b8a8fa5
Don't disable the save button when executing a query in the query tool. Fixes #1695
2016-09-14 11:22:54 +01:00
Surinder Kumar
3035ae13df
Fix CMD+V (Paste) in the Mac runtime. Finally fixes #1478
2016-09-14 11:17:34 +01:00
Murtuza Zabuawala
4ba8f4830b
Don't sort columns (tables, views, matviews, catalogs etc) on the treeview by name, but by ordinal. Fixes #1687
2016-09-14 11:13:50 +01:00
Surinder Kumar
2ee631d6fc
Remove blank lines in the formatting of SELECT scripts for functions. Fixes #1690
2016-09-14 11:08:10 +01:00
Surinder Kumar
f2469d113c
Fix function signature generation for reverse engineered SQL. Fixes #1674
...
1) In SQL pane, the signature in comments had arguments with name and type, Now it will show arguments with type only.
2) There is no indent+newline between arguments (there isn't even a space). - Fixed
3) The default value for the last argument is omitted. - Fixed
Last argument is omitted because the value for the last argument we got from table is empty.
Now we form function signature in the get_definition.sql using 'pg_catalog.pg_get_function_arguments' method.
Above changes will reflect in Functions, Procedures & Trigger function Nodes.
2016-09-14 10:59:11 +01:00
Murtuza Zabuawala
751327eacc
Ensure View Data on a table with zero columns doesn't throw an error. Fixes #1677
2016-09-14 10:43:08 +01:00
Murtuza Zabuawala
046f6dd442
Fix creation of DO INSTEAD rules. Fixes #1681
2016-09-14 10:39:16 +01:00
Murtuza Zabuawala
a67c4fc1dc
Fix a typo in the error handling in the browser that caused some errors to be reported to the console only.
2016-09-14 10:33:41 +01:00
Murtuza Zabuawala
071b609a44
Fix error when refreshing table node. Fixes #1686
2016-09-14 10:30:02 +01:00
Dave Page
d848e9cefe
Use SSL when loading Gravatar icons. Fixes #1694
2016-09-13 13:39:26 +01:00
Surinder Kumar
f2ed6fa4dd
Fix function signature generation. Fixes #1683
2016-09-12 15:20:46 +01:00
Murtuza Zabuawala
ffc58b74d2
Allow viewing of long data values in the grid. Fixes #1672
2016-09-12 12:39:40 +01:00
Surinder Kumar
28b7a033bc
Prevent creation of packages and rules in catalogs. Fixes #1682
2016-09-12 11:37:25 +01:00
Surinder Kumar
7cfcf14312
Move the declaration of a variable into the correct scope.
2016-09-09 14:50:51 +01:00
Murtuza Zabuawala
42e19d2169
Fix error highlighting, broken in d6391c7e9b
. Fixes #1676
2016-09-09 14:45:03 +01:00
Murtuza Zabuawala
982c291a31
Confirm loss of changes with the user before clearing the query or history, or opening a new file in the Query Tool. Fixes #1666
2016-09-08 09:12:48 +01:00
Surinder Kumar
f13de8b86b
Ensure the query tool editor has focus when the tab is selected or when first shown so the user can immediately type/execute. Fixes #1581
2016-09-07 16:20:47 +01:00
Murtuza Zabuawala
35d3c396de
Fix SQL generation for functions that return SETOF ... Fixes #1631
2016-09-07 14:53:22 +01:00
Surinder Kumar
da21cabb1e
Fix typo in connection handler.
2016-09-07 14:01:56 +01:00
Dave Page
bd139bc83e
Improve binary path settings hint.
2016-09-07 09:54:54 +01:00
Ashesh Vashi
2540e9687f
Fixed some of the javascript syntax in menu.js
2016-09-06 23:20:38 +05:30
Ashesh Vashi
aeaa4bcad1
Add an object in an parent properly, which was expanded earlier, and do
...
not have any child withing it.
Fixes #1481 , #1627 .
2016-09-06 23:20:38 +05:30
Murtuza Zabuawala
679ad6fca8
Support range types in the query tool. Fixes #1658
2016-09-06 14:26:43 +01:00
Murtuza Zabuawala
1b75679ec4
Python 2.6 fixes. Fixes #1636 . Fixes #1659
2016-09-06 14:07:30 +01:00
Ashesh Vashi
8ac65070bc
Improve the logic for Bad handling of missing connection database server RM #1387
2016-09-06 15:35:20 +05:30
Murtuza Zabuawala
8b61aa49d0
Warn the user about unsaved changes to SQL or data before closing the query tool. Fixes #1661
2016-09-05 17:18:43 +01:00
Surinder Kumar
3dace5ff22
Fix file navigator to properly show drives in Windows. Fixes #1665
2016-09-05 17:07:07 +01:00
Murtuza Zabuawala
15df12c924
Highlight invalid rows when saving data in the edit grid. Fixes #1637
2016-09-02 16:05:00 +01:00
Murtuza Zabuawala
f3f7413701
Use ISO formatted dates when setting rolvaluntil. Fixes #1153
2016-09-02 15:24:34 +01:00