Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Nikhil Mohite
1122e06f48
Fixed cognitive complexity issues reported by SonarQube.
2020-08-06 12:38:35 +05:30
Nikhil Mohite
6a406f466d
Fixed cognitive complexity issues reported by SonarQube.
2020-08-05 13:00:44 +05:30
Aditya Toshniwal
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
Akshay Joshi
5ce2773658
Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429
2020-08-04 15:48:20 +05:30
Akshay Joshi
87d08de3a0
Corrected the syntax as per jinja standards. refs #5632
2020-08-03 13:08:29 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Satish V
318d712c4f
Improve code coverage and API test cases for Schemas. Fixes #5327
2020-08-03 12:38:38 +05:30
Aditya Toshniwal
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
Akshay Joshi
dd7eb54e90
Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710
2020-07-30 13:57:00 +05:30
Nikhil Mohite
89fa85d650
Fixed cognitive complexity issues reported by SonarQube.
2020-07-29 18:29:04 +05:30
Rahul Shirsat
74fd5dfe96
Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632
2020-07-29 16:22:11 +05:30
Satish V
287a6628ed
Improve code coverage and API test cases for Types. Fixes #5336
2020-07-29 15:41:04 +05:30
Aditya Toshniwal
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
Akshay Joshi
fb0bc65ced
Fixed following SonarQube issues:
...
1) Define a constant instead of duplicating this literal.
2) Reduce cognitive complexity (Patch by Aditya)
2020-07-27 16:31:03 +05:30
Cyril Jouve
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
Akshay Joshi
7a22cff28c
Fixed 'cannot unpack non-iterable Response object' issue.
2020-07-24 14:59:50 +05:30
Satish V
4cf8c2f300
Improve code coverage and API test cases for Foreign Servers and User Mappings. Fixes #5324
2020-07-24 14:14:13 +05:30
Rahul Shirsat
937877e841
Ensure that RLS Policy node should be searchable using search object. Fixes #5646
2020-07-24 13:47:39 +05:30
Yogesh Mahajan
dd27e08a98
Fixed code smell 'Unused local variables should be removed'.
2020-07-24 12:15:29 +05:30
Nikhil Mohite
1fbf298d30
Fixed cognitive complexity issues reported by SonarQube.
2020-07-24 12:03:05 +05:30
Aditya Toshniwal
505a3ac960
1) Fixed cognitive complexity issues reported by SonarQube.
...
2) Fixed code smell 'Add a nested comment explaining why this method is
empty, or complete the implementation'.
2020-07-24 11:46:30 +05:30
Pradip Parkale
28a4359020
Fixed issue where the user was not able to update policy if the policy is created with space. Fixes #5686
2020-07-21 18:14:49 +05:30
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Nikhil Mohite
4e2c4b0498
Fixed cognitive complexity issues reported by SonarQube.
2020-07-17 15:31:04 +05:30
Akshay Joshi
703faf3b15
Fixed following SoanrQube issues
...
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
2) Define a constant instead of duplicating this literal.
Solution:
1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
2) Declare the constant in PGChildNodeView for SQL files.
2020-07-16 19:39:55 +05:30
Akshay Joshi
5d8c79da38
Added docstrings for some newly created functions.
2020-07-15 18:07:54 +05:30
Akshay Joshi
11c4877859
Fixed an issue where difference DDL is showing the wrong SQL when changing the policy owner. Fixes #5647
2020-07-15 14:52:14 +05:30
Rahul Shirsat
d6893f9d8a
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569 .
2020-07-14 19:16:33 +05:30
Akshay Joshi
4f34bc0f0e
Added missing dependencies/dependent and corrected some wrongly identified. Fixes #5666
2020-07-14 18:34:50 +05:30
Satish V
a91e4d8a7f
Improve code coverage and API test cases for Foreign Data Wrapper. Fixes #5323 .
2020-07-14 15:58:22 +05:30
Nikhil Mohite
0013a3b047
Fixed cognitive complexity issues reported by SonarQube.
2020-07-14 15:33:54 +05:30
Akshay Joshi
d3eaac8609
Reverted fix for #5569 due to a couple of issues.
2020-07-11 20:32:57 +05:30
Rahul Shirsat
29175d7ec4
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569
2020-07-11 16:23:31 +05:30
Rahul Shirsat
e8b81db977
Fixed cognitive complexity issues reported by SonarQube.
2020-07-10 11:44:33 +05:30
Nikhil Mohite
7420673a0f
Improve code coverage and API test cases for FTS Configuration, FTS Parser, FTS Dictionaries, and FTS Template. Fixes #5329 .
2020-07-10 11:40:08 +05:30
Nikhil Mohite
e1168f8de0
Fixed code smell to reduce cognitive complexity.
2020-07-09 18:41:13 +05:30
Pradip Parkale
916182f80f
Fixed code smell for variable naming convention.
2020-07-09 18:28:08 +05:30
Pradip Parkale
c58fda0a70
Ensure that create RLS Policy menu should not be visible for catalog objects. Fixes #5633
2020-07-09 18:04:32 +05:30
Akshay Joshi
b4c25bdc0a
Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube.
2020-07-07 19:39:06 +05:30
Pradip Parkale
36a2c073bd
Added support for permissive/restricted policy type while creating RLS Policy. Fixes #5622
2020-07-07 17:55:05 +05:30
Nikhil Mohite
aee6bac5ef
Fixed cognitive complexity code smell reported by SonarQube.
2020-07-07 15:19:47 +05:30
Aditya Toshniwal
45a03dd663
Fixed 'convention' related code smell reported by SonarQube.
2020-07-06 11:48:23 +05:30
Murtuza Zabuawala
cb1cdd1b23
Modified EPAS templates to support schema restriction.
2020-07-03 18:42:17 +05:30
Akshay Joshi
0d92059155
Fixed code smells having rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 18:37:37 +05:30
Yogesh Mahajan
80ab596992
Fixed the SoanrQube code smell 'Variables should not be shadowed'.
2020-07-03 14:33:30 +05:30
Khushboo Vashi
b5f0190799
Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 14:24:54 +05:30
Aditya Toshniwal
341c3aded6
Fixed dark theme-related CSS and modify the color codes. Fixes #5287
...
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
2020-07-03 11:47:40 +05:30
Nikhil Mohite
1ab257d512
Fixed Cognitive Complexity code smell reproted by SonarQube.
2020-07-03 11:15:41 +05:30
Yogesh Mahajan
1802f8a3f8
Ensure that the referenced table should be displayed on foreign key constraints. Fixes #5530
2020-07-02 16:21:56 +05:30
Pradip Parkale
8b10315e2a
Added hints for 'Using' and 'With check' options of RLS Policy node.
2020-07-02 16:21:56 +05:30
Akshay Joshi
0850db2a9b
Fixed database connection issue, regression of SonarQube fixes.
2020-07-01 17:32:22 +05:30
Akshay Joshi
a881e4e3f8
Fix PEP8
2020-07-01 15:33:51 +05:30
Nikhil Mohite
192a446131
Fixed API test cases failing due to updating the server manager instance.
2020-07-01 15:29:59 +05:30
Pradip Parkale
b30c590866
Fixed SonarQube code smell 'Rename function and variable name to match the regular expression'.
2020-07-01 13:50:51 +05:30
Yogesh Mahajan
6dd3ca31be
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-07-01 13:43:00 +05:30
Pradip Parkale
979f806161
1) Added RLS Policy support in Schema Diff. Fixes #5601
...
2) Fixed 'cant execute empty query' issue when remove the value of
'USING' or 'WITH CHECK' option of RLS Policy. Fixes #5631
2020-07-01 12:44:28 +05:30
Ashesh Vashi
21d57b1f10
Do not let browser autocomplete the password field while connecting a
...
database server.
Set the autocomplete attribute of the password field to 'new-password'
to let browser know, we require a new password for the password, and do
not autocomplete it.
2020-07-01 11:26:52 +05:30
Nikhil Mohite
c873218c32
Added support for schema level restriction. Fixes #5583
...
Allow user to edit the connection properties when the database server
is already connected.
2020-06-30 19:15:23 +05:30
Nikhil Mohite
6713bc068b
Fixed SonarQube code smells 'Refactor this function to reduce its Cognitive Complexity'.
2020-06-30 17:06:55 +05:30
Akshay Joshi
46d26cd029
Remove extra brackets from reverse engineering SQL of RLS Policy. Fixes #5621
2020-06-30 16:11:02 +05:30
Zhang Jie
88db5ec4d5
Remove extra brackets from reverse engineering SQL of trigger.
2020-06-30 16:07:55 +05:30
Rahul Shirsat
7add777b21
Add proper indentation to the code while generating functions, procedures, and trigger functions. Fixes #3851
2020-06-29 12:36:28 +05:30
Akshay Joshi
b91f6f0f5c
Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
...
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
2020-06-26 19:24:54 +05:30
Nikhil Mohite
115657a465
Fixed following SonarQube issues:
...
1) Refactor function to reduce its Cognitive Complexity.
2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$.
2020-06-26 15:03:50 +05:30
Satish V
8e28e0a32b
Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326
2020-06-26 14:15:09 +05:30
Khushboo Vashi
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
Yogesh Mahajan
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
Diego Augusto Molina
6a63279396
Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions.
2020-06-26 12:28:36 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Nikhil Mohite
db9d684524
Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube.
2020-06-24 16:08:14 +05:30
Akshay Joshi
d265ed9729
Fixed an issue while creating RLS Policy with the name having space. Fixes #5620
2020-06-23 14:28:21 +05:30
Murtuza Zabuawala
c064eb0795
Fix an issue where RLS Policy dialog help is not working.
2020-06-23 14:13:08 +05:30
Pradip Parkale
6012f49919
Added policy event 'ALL' in events drop-down list.
2020-06-22 17:09:10 +05:30
Satish V
daad16ea93
Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube.
2020-06-22 12:58:48 +05:30
Aditya Toshniwal
6620f9263d
Fixed issues reported by SonarQube with tag 'bad-practice'.
2020-06-22 12:18:59 +05:30
Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Satish V
905be1d894
Replace if-then-else statement by a single return statement, issue reported by SonarQube.
2020-06-18 15:51:01 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Akshay Joshi
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
Aditya Toshniwal
df05efd7d9
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation.
2020-06-17 17:15:09 +05:30
Yogesh Mahajan
7c12ade161
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-17 17:08:23 +05:30
Akshay Joshi
cb268075c2
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468
...
2) Added server group name while selecting servers in schema diff. Fixes #5500
3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584
2020-06-17 16:27:51 +05:30
Satish V
d43518cb3c
Fixed following issues reported by SonarQube:
...
1) Replace this if-then-else statement by a single return statement. (clumsy)
2) 'switch' statements should have at least 3 'case' clauses. (bad practice)
2020-06-16 15:00:51 +05:30
Aditya Toshniwal
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
Yogesh Mahajan
697f4aec95
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-16 10:47:40 +05:30
Akshay Joshi
a21e6448ce
Fixed RESQL test cases, regression of RLS policy.
2020-06-15 17:10:25 +05:30
Satish V
eb1b17b636
Fix 'expressions evaluated to true/false always' issue reported by SonarQube.
2020-06-15 16:50:07 +05:30
Mishika Singh
38cd3327f3
Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592
2020-06-15 16:50:07 +05:30
Khushboo Vashi
8ab358ccec
Fix following issues reported by SonarQube:
...
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
2020-06-15 16:50:07 +05:30
Aditya Toshniwal
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
Pradip Parkale
18277543b6
Added support of Row Security Policies. Fixes #5516
2020-06-15 15:44:59 +05:30
Aditya Toshniwal
8c20f0c0d2
Some clumsy coding related fixes reported by SonarQube.
2020-06-12 15:24:17 +05:30
Satish V
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
Satish V
82c4a4a03e
Improve code coverage and API test cases for Collations. Fixes #5325
2020-06-11 11:12:41 +05:30
Dave Page
5c60dcd501
Remove blank line at EOF.
2020-06-10 17:02:39 +01:00
Dave Page
85e89c869a
Cleanup some code smells identified by SonarQube.
2020-06-10 16:42:59 +01:00
Satish V
726ecd79e6
Fixed import statements.
...
refs #3669
2020-06-03 12:49:05 +05:30
Satish V
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
Akshay Joshi
9b8902dfb8
Fixed the SQL help issue for EDB Postgres Advanced Server. Fixes #4099
2020-05-22 14:11:58 +05:30
Yogesh Jain
7b1cac6914
Fixed an issue where clicking on Select All button, not selecting all the options in pgAgent job scheduler. Fixes #5496
2020-05-19 13:54:21 +05:30
Yogesh Mahajan
9f445dc052
Improve code coverage and API test cases for Indexes. Fixes #5333
2020-05-18 12:29:33 +05:30
Pradip Parkale
6d6cd19b37
Improve code coverage and API test cases for Triggers and Compound Triggers. Fixes #5335
2020-05-15 12:50:50 +05:30
Akshay Joshi
073d90c4a6
Fixed internal server error when clicking on Triggers -> 'Enable All' for partitions. Fixes #5052
2020-05-11 15:18:39 +05:30
Yogesh Mahajan
1294c089a8
Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255
2020-05-11 12:11:31 +05:30
Aditya Toshniwal
b64896f558
Fixed generated SQL issue for auto vacuum options. Fixes #5398
...
Fixed some more issues:
1) pgAdmin allows only true or false values for autovacuum_enabled,
and there is no way to reset it individually without disabling a custom auto vacuum.
To fix this, the control is changed from the switch to three state buttons.
2) Setting any vacuum options to zero made the option disappear from the SQL.
3) Right-click on a table with vacuum options set and create a new table.
4) The parameters tab will have the options prefilled.
5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.
The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".
2020-05-08 14:30:30 +05:30
Ashesh Vashi
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
Pradip Parkale
057a2b2312
Improve code coverage and API test cases for the Rules module. Fixes #5334
2020-05-07 16:27:58 +05:30
Akshay Joshi
6ad46e1860
Fixed invalid literal issue when removing the connection limit for the existing role. Fixes #5001
2020-05-07 13:14:45 +05:30
Akshay Joshi
a0940fd145
Typecast the object to 'text' before using it in length() function, so that correct length function gets called.
2020-05-06 17:34:18 +05:30
Ganesh Jaybhay
5fe7813f9f
Fixed an issue where select2 hover is inconsistent for the SSL field in create server dialog. Fixes #5469
2020-05-04 13:19:13 +05:30
Satish V
d61b8eb1b3
Gracefully informed the user that the database is already connected when they click on 'Connect Database...'. Fixes #3694
2020-05-04 13:08:56 +05:30
Murtuza Zabuawala
0fc2afb829
Add Reverse Engineered and Modified SQL tests for Column and Type.
2020-05-04 12:48:24 +05:30
Khushboo Vashi
5656f756e6
Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422
2020-05-04 12:23:18 +05:30
Akshay Joshi
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
Dave Page
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
Khushboo Vashi
88aebb64f9
Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447
...
It's a regression of #5213
2020-04-28 11:00:23 +05:30
Pradip Parkale
18748846ef
Fixed the regression where initial changes make the Save button enabled when the table dialog is opened. Fixes #4504
2020-04-27 18:48:44 +05:30
Murtuza Zabuawala
76eb3e9b67
Fixed an issue when the user performs refresh on a large size materialized view. Fixes #5213
2020-04-27 17:30:23 +05:30
Pradip Parkale
ef58d277ca
Fixed an issue where like options should be disabled if the relation is not selected while creating a table. Fixes #4504
2020-04-24 18:22:11 +05:30
Aditya Toshniwal
aec64aa582
Fixed following issues for 1257:
...
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".
Fixes #1257
2020-04-24 16:35:59 +05:30
Aditya Toshniwal
dfb74904ed
Ensure all object types have a System XXX? property. Fixes #1257
2020-04-23 17:31:40 +05:30
Akshay Joshi
2b5c90e379
A warning message will be displayed only when the package header is changed for EPAS packages. Fixes #5410
2020-04-23 17:14:01 +05:30
Khushboo Vashi
6e5dbf7beb
Added multiple drop/delete functionality for the table constraints. Fixes #3900
2020-04-22 18:47:13 +05:30
Ashesh Vashi
858294f36e
Fixed validation errors in view/materialized view javascript to
...
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.
Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.
Fixes #5053
2020-04-22 17:19:18 +05:30
Akshay Joshi
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
Neel Patel
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
Akshay Joshi
f289dfb762
Fixed following issues for packages:
...
1) Removing the package header removes the body as well.
2) Schema is not visible on the properties dialog.
3) Reverse engineering SQL and Create script not showing schema-qualified packages.
Fixes #5410
2020-04-21 16:49:23 +05:30
Akshay Joshi
4692b21bcf
Fixed an issue where schema diff marks an identical table as different. Fixes #5350
...
Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315
Ignore the keys from the source and target list and also sort both the lists.
2020-04-20 18:04:16 +05:30
Libor M
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
Akshay Joshi
d8ad0b8faf
Fixed validation issue in Synonyms node. Fixes #5409
2020-04-17 14:50:38 +05:30
Akshay Joshi
c6deb9393c
Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410
2020-04-17 13:06:07 +05:30
Aditya Toshniwal
dc1e32a632
Fixed internal server error when the database server is logged in with non-super user. Fixes #5400
2020-04-16 15:05:17 +05:30
Murtuza Zabuawala
eec2cfd5dd
Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. Fixes #5375
2020-04-16 13:16:07 +05:30
Shubham Agarwal
d6cab7b421
Ensure the DROP statements in reverse engineered SQL are properly quoted for all objects. Fixes #4440
2020-04-16 13:06:50 +05:30
Libor M
8254e9f030
Some minor gettext and format fixes.
2020-04-16 12:55:19 +05:30
Ganesh Jaybhay
7493649893
Added schema-qualified dictionary names in FTS configuration to avoid confusion of duplicate names. Fixes #4709
2020-04-16 12:47:00 +05:30
Khushboo Vashi
738c421edf
Ensure that Constraint Trigger, Deferrable, Deferred option should be disabled when the user selects EDB-SPL function for the trigger. Fixes #4957
2020-04-16 12:38:20 +05:30
Aditya Toshniwal
31a929388b
Make changes to use gettext() function correctly.
2020-04-15 16:23:17 +05:30
Aditya Toshniwal
0424f7d962
Fixed following issues for Procedures:
...
1) Change comments on the procedure with arguments as a procedure can be overloaded.
Note that on EPAS servers, procedure overloading works only for v11+.
2) The save button of a procedure dialog is enabled without any change.
3) Fixed formatting of the reverse-engineered SQL.
4) On EPAS servers, the parameters set were not displayed in the SQL generated.
They are visible only if set to edbsql.
5) Changing the volatility option of any existing procedure was not working.
6) Changing the parallel option (EPAS v9.6+) was not working.
7) Added RE-SQL test cases for procedures.
Fixes #4620 , Fixes #4873
2020-04-15 13:54:17 +05:30
Shubham Agarwal
8654d6cf43
Fixed an issue where the mode is not shown in the properties dialog of functions/procedures if all the arguments are IN arguments. Fixes #5387
2020-04-15 12:33:54 +05:30
Ashesh Vashi
3a4641889c
Using 'is_valid_ipaddress' utility function everywhere
2020-04-14 18:51:48 +05:30
Ashesh Vashi
6c5883bce0
We don't need to pass gettext for inline CSS transforation
2020-04-14 18:43:04 +05:30
Ashesh Vashi
d226ffbd1f
[Foreign Key] Removed 1 unexpected arguments; 'get_node_list' expects
...
5 positional arguments.
Also,
- Using 'gettext' instead of '_'.
- Using constant string for 'foreign_key not found' error message.
2020-04-14 18:40:15 +05:30
Ganesh Jaybhay
12530cd973
Ensure index dropdown should have existing indexes while creating unique constraints. Fixes #5007
2020-04-14 14:02:33 +05:30
Khushboo Vashi
a0fcb38e68
Fixed syntax error while refreshing the existing synonyms. Fixes #5383
2020-04-14 13:43:56 +05:30
Pradip Parkale
a05acb4f99
Fixed tab key navigation for some dialogs. Fixes #5371
2020-04-14 13:32:03 +05:30
Shubham Agarwal
41521a9b98
Ensure all object names in the title line of the reverse-engineered SQL are not quoted. Fixes #4445
2020-04-14 13:02:58 +05:30
Akshay Joshi
781b766ac4
Fixed an issue where difference SQL is not seen in the schema diff tool for Types. Fixes #5302
2020-04-13 20:24:12 +05:30
Akshay Joshi
df11f28593
Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. Fixes #5362
2020-04-13 18:06:20 +05:30
Khushboo Vashi
030741bba5
Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053
2020-04-13 16:00:01 +05:30
Murtuza Zabuawala
4de6b93ba8
Ensure that the password prompt should not be visible if the database server is in trust authentication mode. Fixes #2813
2020-04-10 17:03:04 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Khushboo Vashi
e238ecf182
Ensure that OID should be shown in properties for Synonyms. Fixes #5270
2020-04-10 13:19:52 +05:30
Akshay Joshi
31f255b541
Added support of Foreign Tables to the Schema Diff. Fixes #5263
2020-04-09 21:03:28 +05:30
Akshay Joshi
fecf3915c5
Fixed API/RESQL test cases for View/MView failed due to #5053 commit.
2020-04-09 21:03:28 +05:30
Ashesh Vashi
8a550b569f
Fixed expected output status code, as 410 should be the status code
...
for the object (CAST) not exists in the database server.
2020-04-08 16:51:53 +05:30
Ashesh Vashi
1a34f61b24
Moved the ip-address check functionality to a separate file to improve
...
the maintainability of the code.
2020-04-08 16:50:14 +05:30
Ashesh Vashi
775e61c248
Fixed pep8 issue
2020-04-08 14:34:34 +05:30
Ashesh Vashi
d9f6baac72
Various misc fixes:
...
- Using the 'gettext' as oppose to '_', which is not defined
- Define missing variables
- Fixed escape character in string with double quote
- Removed some dead code in a test case
- Removed unnecessary self assignment
Includes some fixes for Accessibility improvements
- Use semantic markup to mark emphasized or special text
- Added hidden legend in <fieldset> for better screen reader support
2020-04-08 14:14:25 +05:30
Ashesh Vashi
8fe687eb55
[Rules] Removing unnecessary 'if' condition
2020-04-08 13:14:14 +05:30
Ashesh Vashi
6c693d158e
[Exclusion Constraint] Fixed an typo - it should have been assignment
2020-04-08 13:05:28 +05:30
Ashesh Vashi
6b3e1f1e65
[TABLES] Do not assign the paramter values, use separate variable for new value
2020-04-08 13:04:24 +05:30
Ashesh Vashi
8fe344c268
[EDB Package Functions] [Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:02:37 +05:30
Ashesh Vashi
c7afa30d0c
[Packages] Fixed a typo
2020-04-08 13:00:49 +05:30
Ashesh Vashi
14f21921bb
[Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:00:01 +05:30
Ashesh Vashi
29ae6dfbf6
[FTS Configuration] Fixed an typo - it should have been assignment
2020-04-08 12:56:51 +05:30
Ashesh Vashi
a6c03a6b75
[Domain] Existing expression will expression will always result into false
2020-04-08 12:54:37 +05:30
Ashesh Vashi
068b812245
[COLLATIONS] Do not assign the paramter values, use separate variable for new value
2020-04-08 12:53:48 +05:30
Ashesh Vashi
a84a62def8
Using the 'gettext' as oppose to '_', which is not defined in these
...
files.
2020-04-08 12:34:57 +05:30
Ashesh Vashi
7f0847b95d
Using the 'gettext' as oppose to '_', which is not defined in the file
2020-04-08 12:29:11 +05:30
Ashesh Vashi
073e310a5a
[Accessibility] Use semantic markup to mark emphasized or special text.
...
Reference: https://www.w3.org/TR/WCAG20-TECHS/H49.html
2020-04-08 12:27:18 +05:30
Khushboo Vashi
f4607885e1
Fixed an issue where changing the columns in the existing view throws an error. Fixes #5053
...
PostgreSQL doesn't allow to change the view columns. So the view should be dropped first
and then recreate it and also the user will get a warning first.
2020-04-08 11:29:03 +05:30
Aditya Toshniwal
e1f990190e
Added search object functionality. Fixes #2172
2020-04-06 17:33:07 +05:30
Pradip Parkale
8ceeb39268
Fixed tab key navigation issue for parameters in table dialog. Fixes #5275
2020-04-06 13:13:21 +05:30
Akshay Joshi
99e4c3350f
Fixed RESQL test cases for Packages.
2020-04-03 19:15:40 +05:30
Akshay Joshi
ce89ae3c1d
Added support of Packages, Sequences and Synonyms to the Schema Diff. Fixes #5264
2020-04-03 16:52:45 +05:30
Aditya Toshniwal
358c5d0a0f
Added support for parameter toast_tuple_target and parallel_workers of the table. Fixes #5181
...
Fixed an issue where the autovacuum_enabled parameter is added automatically in the RE-SQL
when the table has been created using the WITH clause. Fixes #5180
2020-04-01 18:19:55 +05:30
Aditya Toshniwal
88a1e03314
Fixed generated SQL when any token in FTS Configuration or any option in FTS Dictionary is changed. Fixes #5268
2020-04-01 15:03:30 +05:30
Akshay Joshi
86e4a88201
Added 'oid-2' to the ignore list of schema diff for all supported nodes. Fixes #5297
2020-03-27 15:27:48 +05:30
Akshay Joshi
c002881f66
Added conkey and indkey to the ignore list for schema diff.
2020-03-27 14:41:18 +05:30
Akshay Joshi
94a76cc9e0
Added support of Domain, Domain Constraints and Types to the Schema Diff. Fixes #5262
2020-03-26 14:30:09 +05:30
Libor M
94864104e4
Added and fixed gettext usage for better translation coverage. Fixes #5284
...
1) Fixed usage gettext('') instead of _('') in javascript files.
2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
because "pybabel extract" not support extracting from this syntax.
2020-03-24 11:14:05 +05:30
Akshay Joshi
98492e7718
Modified RESQL test cases for Foreign Tables to fix the build failures.
2020-03-22 16:26:23 +05:30
Murtuza Zabuawala
a7ba446703
Fixed Unicode character issue causing error on Python2 environment. Fixes #5279
2020-03-20 15:17:45 +05:30
Pradip Parkale
96361656e4
Fixed some accessibility issues in the dialogs:
...
1) Aria-label additions at few missing places.
2) Label additions with 'sr-only' class where hidden labels required.
3) Converted label to span to solve accessibility error.
Fixes #4608
2020-03-19 16:08:51 +05:30
Akshay Joshi
4fe69e825e
Added support of Collation, FTS Configuration, FTS Dictionary, FTS Parser, and FTS Template to the Schema Diff. Fixes #5261
2020-03-19 13:54:25 +05:30
Akshay Joshi
44c0d76541
Improve logic to get the DDL statements as a part of the comparison. Fixes #5221
...
Fixed 23 issues related to schema diff.
2020-03-15 14:52:19 +05:30
Aditya Toshniwal
fd07e0c868
Fix syntax error when changing the event type for the existing rule. It is a regression of #5115 .
...
Fixes #5215
2020-02-24 18:11:31 +05:30
Aditya Toshniwal
9bad590e9e
Improvements in the UI for both default and dark themes. Fixes #5133
...
Improve the style of the highlighted code after query execution for Dark mode. Fixes #4996 .
Changed background pattern for geometry viewer to use #fff for all themes. Fixes #5077
Changed the color of selected and hovered item for Select2 dropdown, also tweak the appearance of the tags in multi-select boxes. Fixes #4955
Fixed Firefox monospaced issue by updating the font to the latest version. Fixes #5184
2020-02-24 14:11:00 +05:30
Aditya Toshniwal
a44f17a2fc
Fix an issue where command and statements were parsed incorrectly for Rules. Fixes #5115
...
Fixed issue where removing command or statements altogether was not generating modified SQL.
2020-02-24 12:11:19 +05:30
Aditya Toshniwal
915b09255c
Added Python 3.8 support. Fixes #5179
...
1) Upgraded passlib==1.7.1 to passlib==1.7.2
2) Replace unmaintained Flask-Security with maintained Flask-Security-Too package, which is also compatible with python 3.8
3) Other compatibility code changes.
2020-02-18 12:10:38 +05:30
Pradip Parkale
e9f16a29cf
Improve code coverage and API test cases for the Event Trigger module. Fixes #5088
2020-02-14 11:19:34 +05:30
Akshay Joshi
641701ca16
Added missing imports and remove unused imports from schema diff.
2020-02-03 15:30:57 +05:30
Khushboo Vashi
3b1c8abd2f
Fixed following issue of schema diff tool:
...
1. Comparison result of 2 exact identical Trigger Functions is different
2. EPAS 12: Table comparison with the compound trigger shown as different, but all SQL panels are blank
3. Compound trigger properties panel is not opening
4. The DDL difference of the table containing the foreign key is not accurate
5. The DDL difference of the view which refers the table from schema is not accurate
6. DDL comparison fails if we have procedure with plpgsql in source and edbsql in target
2020-01-31 21:28:08 +05:30
Pradip Parkale
210bbfdbe1
1) Added labels and titles after parsing and validating all the pgAdmin4 web pages for accessibility. Fixes #4770
...
2) Fixed an issue where Save Password control disappears after clicking on it while creating a server. Fixes #5116
2020-01-31 14:21:35 +05:30
Aditya Toshniwal
0da23b837d
Set input controls as read-only instead of disabled will allow tab navigation in the properties tab and also allow screen readers to read it. Fixes #4993
2020-01-31 12:37:44 +05:30
Akshay Joshi
02f9de5bdb
Improve wordings.
2020-01-28 18:36:42 +05:30
Khushboo Vashi
c418a9c9ca
Fixed following schema diff issues:
...
1) Version mismatch should be displayed if you select EPAS 11 as the source and EPAS 12 as the target.
2) We should handle schema diff if the user stops the server after compare.
3) The data type is not visible for column headers in the query tool/view data.
4) Difference SQL is shown, though source & target SQL are same.
5) Error is shown when the 'target only' table is selected & clicked on Generate Script.
6) Difference SQL generated on deleting primary constraints from source throwing error on running from query tool.
7) Copy button for Difference SQL does not work.
8) Incorrect SQL is generated when check constraint from the source table is dropped.
9) Difference SQL is NOT shown when 'Unique Constraint' is dropped from the source table.
10) In case of difference, no message displayed related to copied successfully or not.
11) create or replace trigger should be on the next line.
12) Comparison Result of exactly identical tables having foreign key constraints is shown as different.
13) The wrong SQL displayed in the difference tab for view and materialized view for the select statements.
14) Wrong SQL displayed for the procedure in the difference section.
15) If the user already opens the compare section of Schema diff tool and Disconnects the server then '<' not supported between instances of 'NoneType' and 'int' message displayed.
16) When 'check constraint' is added on the source table which has already unique constraint & identical target table is created, all SQL panels remain empty.
17) Difference SQL is NOT shown when after adding 'Foreign Key' constraint to existing source table.
18) Incorrect SQL is generated when the existing index on the source table is modified.
19) Wrong SQL displayed for function in difference section.
20) Additional space is added before & after in difference SQL generated on the addition of an index to the source table.
21) Difference SQL is NOT shown when tables have different permission/grants.
22) Incorrect SQL is shown when the source had inherited table & target has a normal table.
23) Exactly identical child(inherited) tables show difference SQL.
24) Comparison is NOT working when the custom vacuum is enabled & one of the parameter modified & again custom vacuum is disabled.
2020-01-28 14:53:17 +05:30
Nagesh Dhope
f167d77b61
Allow screen-reader to read label & description of non-textable elements. Fixes #4762 .
...
Allow screen-reader to identify the alert errors. Fixes #4763
Added role alertdialog for confirm and alert dialog.
Added role status for all status bars/banners.
Added role alert for error bars.
Added aria-labelledby for charts on each dashboard.
Added tabindex for each chart so that it is navigable using tab key.
2020-01-28 11:32:11 +05:30
Akshay Joshi
6594481992
1) Disable Fill Factor and Has OIDs control for the partitioned table.
...
2) Added reloptions for the partitions and partitioned table.
2020-01-24 16:13:30 +05:30
Akshay Joshi
4faf14b45f
Default tablespace should not be visible for the multi-level partitioned table on PG 12
2020-01-24 11:36:00 +05:30
Akshay Joshi
198063f046
Added support for a multi-level partitioned table. Fixes #2554 .
2020-01-23 18:49:15 +05:30
Akshay Joshi
b4b54d6b94
Fixed API test cases for missing language pack and jasmin test case.
2020-01-20 16:14:12 +05:30
Pradip Parkale
30b4b5b349
Improve code coverage and API test cases for the LANGUAGE module. Fixes #5050 .
2020-01-20 13:16:59 +05:30
Akshay Joshi
430e9ae994
Updated the incorrect icon used for the cast node on refresh. Fixes #5065 .
2020-01-17 12:10:26 +05:30
Akshay Joshi
af56b92af4
Fix an issue where refreshing a package results in the change in the object completely. Fixes #5066 .
2020-01-17 12:01:37 +05:30
Yogesh Mahajan
4ab3bbeb82
Improve code coverage and API test cases for the CAST module. Fixes #5049 .
2020-01-16 14:34:51 +05:30
Khushboo Vashi
45f2e35a99
Added Schema Diff tool to compare two schemas and generate the difference script.
...
Currently supported objects are Table, View, Materialized View, Function and Procedure.
Backend comparison of two schemas implemented by: Akshay Joshi
Fixes #3452 .
2020-01-10 15:42:09 +05:30
Akshay Joshi
be4b8284c5
Fix an issue where select, insert and update scripts on tables throwing an error. Fixes #5074 .
2020-01-09 18:23:23 +05:30
Akshay Joshi
76d04205ef
Fix an issue where the table is not created with autovacuum_enabled and toast.autovacuum_enabled for PG/EPAS 12. Fixes #5068 .
2020-01-07 17:55:12 +05:30
Akshay Joshi
4080511d9d
Fixed linter error.
2020-01-06 18:10:40 +05:30
Akshay Joshi
82c2d50885
Ensure that the user should be able to select/modify tablespace for the partitioned table on v12 and above. Fixes #4950 .
2020-01-06 17:45:25 +05:30
Akshay Joshi
2979424db5
Added support to view multilevel partitioned tables. Fixes #4633 .
2020-01-06 14:53:47 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Aditya Toshniwal
febbd729ec
Ensure that constraints, indexes, rules, triggers, and compound triggers should be created on partitions. Fixes #4842 .
2020-01-01 12:59:48 +05:30
Aditya Toshniwal
cc5c3776ca
Refactored SQL of Functions and Procedures. Fixes #5024 .
2019-12-31 12:55:18 +05:30
Akshay Joshi
ea3eabc3c7
1) Refactored SQL of Table's and it's child nodes. Fixes #4988 .
...
2) Ensure that the error message should not be displayed if Tablespace is not selected while creating the index. Fixes #5008 .
3) Fix an issue where operator, access method and operator class is not visible for exclusion constraints. Fixes #5009 .
2019-12-20 18:10:50 +05:30
Khushboo Vashi
f495af7a76
Refactored SQL of Views and Materialized Views. Fixes #5023 .
2019-12-20 17:14:15 +05:30
Akshay Joshi
4b9bfb2e4a
Optimized edit types and properties SQL for table/columns. It is part of #4988 .
2019-12-20 11:46:10 +05:30
Aditya Toshniwal
a6841bb1e1
Fixed couple of typos for edit types which results in showing proper edit types instead of all data types.
2019-12-18 13:35:58 +05:30
Aditya Toshniwal
f1a18749f6
1) Allow screen-reader to read relationship attributes for tab, tabpanels and tables under it. Similar changes are done for subnode controls.
...
2) Add role="img" for font icons.
Fixes #4764
2019-12-17 13:22:36 +05:30
Aditya Toshniwal
ded71be73f
Improved performance while fetching edit types for each column.
...
Edit types query is executed for every column when open properties dialog of the table.
Change the logic to fetch the edit types for all the distinct column types used in the table at once.
2019-12-16 18:26:22 +05:30
Karan Takalkar
53f418b9a2
Added more information to the 'Database connected/disconnected' message. Fixes #4943 .
2019-12-12 11:12:18 +05:30
Aditya Toshniwal
11bf5fc679
Fix an issue where clicking on an empty textbox like fill factor or comments, considers it as change and enabled the save button. Fixes #4506 .
2019-12-11 14:35:14 +05:30
Akshay Joshi
f15db03ec3
Added statistics and storage information in reverse engineering SQL of table/column. Fixes #4982 .
2019-12-09 15:01:04 +05:30
Akshay Joshi
1a9d365c42
Fix reverse engineering SQL issue where when clause is not visible for PG/EPAS 12. Fixes #4976 .
2019-12-06 19:01:55 +05:30
Akshay Joshi
f8e1973bc2
Fix reverse engineering SQL issue for partitions when specifying digits as comments. Fixes #4893 .
2019-12-05 12:55:52 +05:30
Akshay Joshi
6c7fe644e5
Fix reverse engineering SQL issue for triggers when passed a single argument to trigger function. Fixes #4958 .
2019-12-05 11:45:47 +05:30
Akshay Joshi
9110703aaa
Fix 'Could not find the object on the server.' error while refreshing the check constraint. Fixes #4966 .
2019-12-03 14:18:45 +05:30
Aditya Toshniwal
0a67b2ecb9
Added aria-label to provide an invisible label where a visible label cannot be used. Fixes #4772 .
2019-12-03 12:47:42 +05:30
Khushboo Vashi
d476343b99
Enhance the logic to change the label from 'Delete/Drop' to 'Remove' for the server and server group node. Fixes #4923
2019-12-03 11:52:02 +05:30
Akshay Joshi
d95e8db4ee
Fix an issue of retrieving properties for Compound Triggers. It's a regression of #4006 . Fixes #4952 .
2019-12-02 15:01:54 +05:30
Rahul Shirsat
d98e86d3df
Warn the user on changing the definition of Materialized View about the loss of data and its dependent objects. Fixes #4396
2019-12-02 11:25:51 +05:30
Akshay Joshi
4fa1bdba5a
1) Refactored code of columns node. Fixes #4938 .
...
2) Fix an issue where length and precision are not removed from table/column dialog. Fixes #4964 .
3) Fix an issue where the Interval data type is not displayed in the properties dialog of table/column. Fixes #4965 .
4) Fix an issue where the wrong type is displayed when changing the datatype from timestamp with time zone to timestamp without time zone. Fixes #4761 .
5) Change the label from 'Length and Precision' to 'Length/Precision and Scale' for columns.
6) The maximum length for datatype like interval, timestamp with time zone, time with time zone, etc.. is 6. Set the max length to 6 instead of 10.
2019-11-28 18:48:53 +05:30
Aditya Toshniwal
4ed2d74d9c
1) Fix network disconnect issue while establishing the connection via SSH Tunnel and it impossible to expand the Servers node. Fixes #4724 .
...
2) Fix server connection drops out issue in query tool. Fixes #4818
3) Fix VPN network disconnect issue where pgAdmin4 hangs on expanding the Servers node. Fixes #4926 .
4) Ensure that the Servers collection node should expand independently of server connections. Fixes #4933 .
Set the default connection timeout to 10 seconds instead of 0.
2019-11-26 09:04:41 +05:30
Rahul Shirsat
1a39dedc62
Add Reverse Engineered and Modified SQL tests for Materialized Views. Fixes #4696 .
2019-11-25 11:11:09 +05:30
Akshay Joshi
de878b3198
Refactored code of table and it's child nodes.
...
1) Remove duplicate logic.
2) Child node specific logic should be inside the child node and table node gets the required information from the respective child node.
Note:- Refactoring of columns node still in progress.
Fixes #4807
2019-11-15 14:45:55 +05:30
Akshay Joshi
7282e15ee2
Fixed API and RESQL test cases for Compound Trigger after the recent changes in EPAS 12.
...
EPAS 12 Changes:
Fix server crash when the compound trigger has both row and statement-level triggers having
WHEN clause containing NEW/OLD vars.
2019-11-11 17:22:50 +05:30
Aditya Toshniwal
8180403f97
1) Added support for custom theme creation and selection. Fixes #4348 .
...
2) Added Dark(Beta) UI Theme option. Fixes #3741 .
3) Fix an issue where a black arrow-kind image is displaying at the background of browser tree images. Fixes #4171
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown.
It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes.
On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after the bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the SVG files(monochrome) used as icons for buttons to font icons.
This will allow us to change the color of the icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of
theme CSS files as CSS in .css files will not change with the change of SASS variables.
2019-11-07 18:51:03 +05:30
Aditya Toshniwal
080ccdda5b
Remove arbitrary (and incorrect) requirement that composite types must have at least two members. Fixes #4451
2019-11-01 15:21:59 +00:00
Aditya Toshniwal
f8e0b54836
Ensure comments are shown in reverse engineered SQL for table partitions. Fixes #4191
2019-11-01 11:58:38 +00:00
Aditya Toshniwal
131a944e24
Support Enable Always and Enable Replica on triggers. Fixes #4006
2019-11-01 11:49:17 +00:00
Aditya Toshniwal
4125360dfb
Ensure the correct "running at" agent is shown when a pgAgent job is executing. Fixes #3913
2019-10-25 11:39:40 +01:00
Aditya Toshniwal
02642628b0
Added encrypted password in reverse engineered SQL for roles. Fixes #1974 .
2019-10-23 13:16:36 +05:30
Akshay Joshi
2790689d26
1) Fix issue where validate switch for the foreign key is enabled from table dialog even if the key is validated.
...
2) Fix issue where validate the foreign key from the table dialog, rename the foreign key constraint to none.
2019-10-14 18:19:32 +05:30
Akshay Joshi
c3e11bd390
Fix issue where VALID foreign keys show as NOT VALID in the SQL tab for tables.
...
Corrected the condition for valid foreign key.
Fixes #4791
2019-10-10 18:55:13 +05:30
Aditya Toshniwal
f16498a8a7
Optimize Webpack to improve overall performance.
...
Changes include:
1) Remove underscore-string and sprintf-js packages as we were using only %s. Instead, added a function to do the same. Also changed gettext to behave like sprintf directly.
2) backgrid.sizeable.columns was not used anywhere, removed. @babel/polyfill is deprecated, replaced it with core-js.
3) Moved few css to make sure they get minified and bundled.
4) Added Flask-Compress to send static files as compressed gzip. This will reduce network traffic and improve initial load time for pgAdmin.
5) Split few JS files to make code reusable.
6) Lazy load few modules like leaflet, wkx is required only if geometry viewer is opened. snapsvg loaded only when explain plan is executed. This will improve sqleditor initial opening time.
Reviewed By: Khushboo Vashi
Fixes #4701
2019-10-10 12:05:28 +05:30
Akshay Joshi
55c6fa0d93
Fix an error where 'false' string is displayed when we add a new parameter in the Parameters tab,
...
also clear the old value when the user changes the parameter name.
Corrected the implementation of BooleanCellFormatter.
Fixes #4753
2019-10-07 16:00:28 +05:30
Akshay Joshi
7489c372e5
The search path should not be quoted while setting as a parameter, if it is
...
quoted then that string considers to be a single schema.
Quoting not added for the 'search_path' parameter.
Fixes #4760 , #4780
2019-10-07 12:28:00 +05:30
Akshay Joshi
bf2c001c87
Export job fails when deselecting all the columns.
...
Select2 parameter 'first_empty' should be set to false for the controls of type array.
If it is true then on deselecting/clearing all the values, an empty entry is still there.
Fixes #4751
2019-10-04 13:00:39 +05:30
Akshay Joshi
c54017eac5
Add Reverse Engineered and Modified SQL tests for Synonyms. Fixes #4472
2019-09-24 18:33:07 +05:30
Akshay Joshi
faa6236580
Add Reverse Engineered and Modified SQL tests for Unique Constraints. Fixes #4628
2019-09-20 12:12:01 +05:30
Akshay Joshi
426d9d5872
Fix SQL issue of length and precision when changing the data type of Column. Fixes #4698
2019-09-16 18:57:57 +05:30
Khushboo Vashi
aa668856f7
1) Add Reverse Engineered and Modified SQL tests for Primary Keys. Fixes #4624 .
...
2) Ensure Primary Key should be created with Index. Fixes #4742 .
2019-09-16 12:05:29 +05:30
Murtuza Zabuawala
d923dcf98b
Added MSQL test cases for Roles.
2019-09-16 11:41:48 +05:30
Akshay Joshi
f5a6df4ddb
Fix issue where EXEC script doesn't write the complete script for Procedures. Fixes #4727
2019-09-13 16:58:25 +05:30
Akshay Joshi
da553eec9b
Ensure port and username should not be mandatory when a service is provided. Fixes #4642
2019-09-13 11:54:16 +05:30
Akshay Joshi
7944e75695
Ensure sequence with negative value should be created. Fixes #4726
2019-09-12 14:18:30 +05:30
Akshay Joshi
6a931588aa
1) Add Reverse Engineered and Modified SQL tests for Foreign Keys. Fixes #4616
...
2) Fix issue where Validated switch option is inverted for the Foreign Key. Fixes #4412
2019-09-11 15:59:13 +05:30
Nagesh Dhope
db06dd0275
Add msql tests for FTS Dictionaries
2019-09-06 16:00:33 +01:00
Nagesh Dhope
9f26e7ed20
Added MSQL test cases for Extension.
2019-09-06 16:28:41 +05:30
Akshay Joshi
8e4e8b3e5a
1) Add Reverse Engineered and Modified SQL tests for Indexes. Fixes #4621
...
2) Fix modified SQL for Index when reset the value of Fill factor and Clustered?. Fixes #4702
3) Fix reversed engineered SQL for btree Index when provided sort order and NULLs. Fixes #4703
2019-09-06 14:10:46 +05:30
Akshay Joshi
9eff2e9926
Modified RE-SQL/MSQL test cases of foreign tables for EPAS 9.4 and 9.5
2019-09-05 12:01:03 +05:30
Akshay Joshi
5e54f20578
Add Reverse Engineered and Modified SQL tests for Foreign Tables. Fixes #4618 .
2019-09-04 18:33:07 +05:30
Ganesh Jaybhay
85baa22ca1
Added Modified SQL test cases for FTS Configurations.
2019-09-03 17:42:44 +05:30
navnath gadakh
4690700a24
Added Modified SQL test cases for Packages.
2019-09-03 17:33:57 +05:30
Akshay Joshi
4745ad56e9
1) Add Reverse Engineered and Modified SQL tests for Foreign Servers. Fixes #4617
...
2) Add Reverse Engineered and Modified SQL tests for User Mappings. Fixes #4627
2019-09-03 16:27:41 +05:30
Shubham Agarwal
a0f6e5272a
Add MSQL test cases for FTS Parser.
2019-09-03 10:28:11 +05:30
Murtuza Zabuawala
eeeb350ed2
Add Modified SQL tests for Resource Group. Fixes #4690
2019-09-03 10:18:09 +05:30
Akshay Joshi
5ff3f40116
Add Reverse Engineered and Modified SQL tests for FTS Templates. Fixes #4619
2019-09-02 15:24:41 +05:30
Akshay Joshi
662266a367
Added MSQL test cases for Cast and Language.
2019-09-02 14:11:59 +05:30
Neel Patel
0ca65d7cfe
Added MSQL test cases for Domain.
2019-09-02 11:52:19 +05:30
Akshay Joshi
e0c53e7d1d
Add Reverse Engineered SQL tests for Schemas. Fixes #4575
2019-08-29 18:32:08 +05:30
Aditya Toshniwal
d6da1cf25c
Added MSQL test cases for Sequences and cover missing ACL RE-SQL test cases.
2019-08-29 14:15:34 +05:30
Usman Muzaffar
ac298b03c0
1) Add Reverse Engineered SQL tests for Views. Fixes #4576
...
2) Ensure View should be created with special characters. Fixes #4486
2019-08-28 12:48:59 +05:30
Akshay Joshi
28b741a13a
Fixed timezone issue in RE-SQL test cases for Roles.
2019-08-27 19:54:30 +05:30
Murtuza Zabuawala
1ddc9cc889
Modified RE-SQL test to cover Password, Account Expire, Connection Limit and Variables for Roles.
2019-08-26 18:25:48 +05:30
Aditya Toshniwal
53ab4d7e8d
Fix an error that could be seen when click on any system column of a table. Fixes #4577
2019-08-26 14:36:07 +05:30
Akshay Joshi
232fe286ee
Fix SQL tab issue for Views. It's a regression of compound triggers. Fixes #4650
2019-08-23 10:22:20 +05:30
Neel Patel
dc64ce331a
Fix length and precision enable/disable issue when changing the data type for Domain node. Fixes #4644 .
2019-08-21 16:27:23 +05:30
Akshay Joshi
094e5577e8
Add Reverse Engineered SQL tests for Rules. Fixes #4600
2019-08-21 16:06:05 +05:30
Akshay Joshi
41e2a674e3
Fix Truncate option deselect issue for compound triggers. Fixes #4643
2019-08-20 17:09:26 +05:30
Akshay Joshi
f3e4721a90
Added missing file for function selectivity feature. Fixes #4333
2019-08-20 10:02:43 +05:30
Akshay Joshi
0d6f07a035
1) Ensure compound triggers should be displayed under Views. Fixes #4638 .
...
2) Ensure Truncate option should be available for Compound Triggers. Fixes #4641 .
2019-08-20 09:39:31 +05:30
Akshay Joshi
24f9f65b1b
Ensure compound triggers for event should be updated properly. Fixes #4635
2019-08-17 15:58:50 +05:30
Murtuza Zabuawala
3f541200d9
Add Reverse Engineered SQL tests for Columns. Fixes #4546
2019-08-16 17:36:13 +05:30
Akshay Joshi
4403f326e9
Fix PEP8 issue
2019-08-12 14:41:22 +05:30
Akshay Joshi
35bbee3023
Fix generation of reverse engineered SQL for Rules. Fixes #4586
2019-08-12 14:27:02 +05:30
Aditya Toshniwal
1281f5cd6c
Fix console error when changing kind(SQL/BATCH) for pgAgent job step. Fixes #4582
2019-08-08 18:43:38 +05:30
Akshay Joshi
350ffcce7c
1) Add support of Compound Triggers for EPAS 12+. Fixes #4144 .
...
2) Ensure enable trigger menu should be visible when trigger is disabled. Fixes #4578 .
2019-08-08 16:59:11 +05:30
Dave Page
8331f62e1c
Fix PEP-8 issue.
2019-08-08 10:09:28 +01:00
Khushboo Vashi
c29275011a
Ensure the comment on a Primary Key constraint can be edited under the Table node. Fixes #4581
2019-08-08 09:52:10 +01:00
Akshay Joshi
7f53e13aa7
Fix generation of reverse engineered SQL for partition table, partitions were shown as a child of indexes. Fixes #4414
2019-08-07 17:49:13 +05:30
Dave Page
3a5464b278
Display the row count in the popup message when counting table rows, not just in the properties list. Fixes #4574
2019-08-07 11:17:57 +01:00
Aditya Toshniwal
4067d65a30
Improve test messages
2019-08-07 10:17:34 +01:00
Aditya Toshniwal
9cdb3b40ab
Add Reverse Engineered SQL tests for Trigger Functions. Fixes #4554
...
Fix the reverse engineered SQL for trigger functions with the WINDOW option selected. Fixes #4565
2019-08-06 14:26:11 +01:00
Khushboo Vashi
f8afe2ef94
Add Reverse Engineered SQL tests for Exclusion Constraint. Fixes #4555
2019-08-05 16:25:55 +05:30
Akshay Joshi
537c27a58e
Use the full tab space for CodeMirror instances on dialogues where appropriate. Fixes #4540
2019-08-02 10:25:21 +01:00
Akshay Joshi
1ff007d1cb
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around.
2019-08-01 11:39:49 +05:30
Akshay Joshi
2ef3080d0e
Add support for generated columns in Postgres 12+. Fixes #4334
...
Ensure columns can be created when they are IDENTITY fields with the CYCLE option enabled. Fixes #4496
Ensure purely numeric comments can be saved on new columns. Fixed #4497
2019-07-25 16:38:26 +01:00
Daniel Gustafsson
5b322d94e8
Fix generation of reverse engineered SQL for tables with Greenplum 5.x. Fixes #4179
2019-07-25 16:16:44 +01:00
Khushboo Vashi
adb5cd34bf
Add support for planner support functions in PostgreSQL 12+ functions. Fixes #4333
2019-07-25 16:09:37 +01:00
Nagesh Dhope
1813eca1ca
Add support for pre-condition SQL in RE-SQL testsuite,
...
and use it to ensure that the right extensions are installed for the
extension tests.
2019-07-22 09:44:17 +01:00
Khushboo Vashi
8168f623c4
Add Reverse Engineered SQL tests for Constraints. Fixes #4475
2019-07-17 13:25:08 +01:00
Akshay Joshi
ab87035658
pgAgent fixes:
...
"malformed array literal error when updating pgagent job". Fixes #4428
"Error when updating connection string in pgagent Jobs.". Fixes #4448
When user create a schedule using Create->Schedule dialog browser tree is not showing newly created node.
Properties tab showing same properties for all the created schedule.
Added validation in "pga_jobstep.js", throws error on browser when we modify step from the pgagent dialog and select the same node.
2019-07-15 15:54:57 +01:00
Aditya Toshniwal
d3ef1137d9
Add Reverse Engineered SQL tests for Sequences. Fixes #4469
2019-07-15 14:56:22 +01:00
Aditya Toshniwal
0b82a4ad92
Fix sequence reverse engineered SQL generation with quoted names on PG/EPAS 10+. Fixes #4470
2019-07-15 14:55:07 +01:00
Murtuza Zabuawala
f4453e33cc
Stabilise ordering of ACLs in Type RE-SQL tests to prevent random failures.
2019-07-15 14:48:22 +01:00
Shubham Agarwal
809e0682bd
Add Reverse Engineered SQL tests for FTS Parsers. Fixes #4471
2019-07-15 12:02:44 +01:00
Murtuza Zabuawala
1831c9e70a
Use ROLE consistently when generating RE-SQL for roles, not USER. Fixes #4446
2019-07-15 11:31:27 +01:00
Murtuza Zabuawala
1dcf46cc5f
Add Reverse Engineered SQL tests for Types. Fixes #4468
2019-07-15 10:25:04 +01:00
Neel Patel
88ab6db976
Add Reverse Engineered SQL tests for Domains. Fixes #4463
2019-07-12 14:39:49 +01:00
Khushboo Vashi
79e6f4c008
Add Reverse Engineered SQL tests for Collations. Fixes #4464
...
This also adds the ability to test the msql output in ALTER steps.
2019-07-12 14:37:00 +01:00
Navnath Gadakh
ce8a2bb266
Fix re-sql tests for packages on EPAS 9.4-9.6.
2019-07-12 11:32:29 +01:00
Akshay Joshi
29fd83dc6c
Fix dropping of pgAgent schedules through the Job properties. Fixes #3996
2019-07-12 10:37:41 +01:00
Akshay Joshi
ed01274f7b
Fix an error that could be seen when editing column privileges. Fixes #4389
2019-07-12 10:16:18 +01:00
Nagesh Dhope
379b92729a
Add Reverse Engineered SQL tests for FTS Dictionaries. Fixes #4460
2019-07-11 14:00:11 +01:00
Navnath Gadakh
28585110dd
Add Reverse Engineered SQL tests for Packages. Fixes #4456
2019-07-11 09:23:13 +01:00
Akshay Joshi
cdf655f7db
Add Reverse Engineered SQL tests for Languages. Fixes #4452
2019-07-11 09:20:01 +01:00
Nagesh Dhope
e6c067025c
Fixed resql test cases for Extensions specific to database servers.
2019-07-11 13:16:00 +05:30
Akshay Joshi
6c7e95a463
Added re_sql test cases for privileges in Foreign Data Wrappers
2019-07-10 17:57:11 +05:30
Ganesh Jaybhay
f7d6966d60
Add Reverse Engineered SQL tests for FTS Configurations. Fixes #4454
2019-07-09 17:02:55 +01:00
Nagesh Dhope
84b712a008
Add RE-SQL tests for Extensions. Fixes #4453
2019-07-09 13:23:26 +01:00
Akshay Joshi
f085460453
Remove some files which was committed by mistake.
2019-07-09 16:47:23 +05:30
Akshay Joshi
1a9d8f01aa
1) Ensure re_sql tests should not abort at the first failure, it should run all the test cases.
...
2) Added place holder for owner, so we won't need to create separate pg/ppas folder just because of change in the owner name.
2019-07-09 15:37:53 +05:30
Akshay Joshi
a17687e27c
Fix reverse engineered sql for Foreign Data Wrapper created on EPAS server in redwood mode. Fixes #4450
2019-07-09 12:21:13 +05:30
Dave Page
863f62f4d8
Use special characters in names for RE-SQL tests to exercise quoting.
2019-07-08 11:03:30 +01:00
Khushboo Vashi
7c38c1cb38
Fix small issue which is required to support the custom schema in re_sql test cases.
2019-07-08 12:33:31 +05:30
Akshay Joshi
11a3aa56be
Use different folders for pg vs. ppas RE-SQL tests. Fall back to the tests folder without a subdirectory if neither exist.
2019-07-05 14:40:51 +01:00
Aditya Toshniwal
ba32c98241
Add Reverse Engineered SQL tests for FDWs. Fixes #4441
2019-07-05 11:24:54 +01:00
Akshay Joshi
776884860e
Ensure parameter values are quoted when needed when editing roles. Fixes #4393
2019-07-04 15:00:29 +01:00
Akshay Joshi
bf1f9a4b07
Fix table icon issue when updating any existing field. Fixes #4437
2019-07-04 17:34:47 +05:30
Murtuza Zabuawala
588e3814d1
Add RE-SQL tests for Roles and Resource Groups. Fixes #4415
2019-07-03 14:38:29 +01:00
Dave Page
644624eabe
PEP-8 fixes.
2019-06-20 14:30:31 +01:00
Khushboo Vashi
c07e52b9de
Ensure that both columns and partitions can be edited at the same time in the table dialog. Fixes #4380
2019-06-20 13:37:36 +01:00
Dave Page
81752bb998
Remove additional "SETOF" included when generating CREATE scripts for trigger functions. Fixes #4362
2019-06-20 13:18:30 +01:00
Akshay Joshi
9e65c971a3
Add a framework for testing reversed engineered SQL and CRUD API endpoints. Fixes #4202
2019-06-18 14:28:25 +01:00
Aditya Toshniwal
402dfd07db
Change icons for table inheritance (icons by Chethana Kumar) Fixes #3174
...
Along with this, I have also fixed few other issues/icons found on the way:
1) Dependencies tab for inherited tables/foreign keys shows partial text (Fixes ##3994).
2) Dependencies tab for child partition table shows parent partition table as Function.
3) Dependencies tab for triggers shows trigger functions as plain functions.
4) Dependents tab for partitioned table shows the child partition tables as normal table instead for partitioned tables.
2019-06-17 10:36:30 +01:00
Akshay Joshi
04328b76ba
Fix syntax error for Default value of column. It is a regression of #4253
2019-06-13 18:04:43 +05:30
Akshay Joshi
d774a0ff67
Fix issue where property dialog of column should open properly for EPAS v12. Fixes #4343
2019-06-11 17:48:01 +05:30
Dave Page
6d52f2b911
Initial support for PostgreSQL 12. Fixes #4283 . Fixes #4288 . Fixes #4290 .
2019-06-10 14:24:45 +01:00
Aditya Toshniwal
7ff85903e4
Fix issue where reverse engineered SQL was failing for foreign tables, if it had = in the options. Fixes #4171
2019-06-10 12:15:12 +05:30
Aditya Toshniwal
8b9c50ee5c
Fix issue where new column should be created with Default value. Fixes #4235
2019-06-10 11:53:16 +05:30
Aditya Toshniwal
a588c2994d
1) Fix issue where SSH tunnel connection using password is failing, it's regression of Master Password. Fixes #4320
...
2) Fix some more issues related to SSH Tunnel(By: Akshay Joshi)
2019-06-05 12:07:24 +05:30
Akshay Joshi
6a7339bbe4
Fix syntax error while opening properties tab of functions and procedures inside packages.
2019-06-01 14:02:33 +05:30
Akshay Joshi
26c7d76d4f
Fix the issue of accessing the SQL for Views and Materialized Views. Regression of pluralisation of folder names. Fixes #4308
2019-05-31 11:02:37 +05:30
Aditya Toshniwal
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
Akshay Joshi
90a45557b9
1. Fix syntax error when adding more than one column to the existing table. Fixes #4162
...
2. Fix syntax error when creating a table with a serial column. Fixes #4284
2019-05-27 13:09:11 +05:30
Sander Eikelenboom
ab5f35da8d
Fixed error on displaying table properties of a table partitioned by list having a default partition. Fixes #4262
2019-05-15 18:36:16 +05:30
Akshay Joshi
b7121bb2d2
1) Make folder name pluralise inside 'templates' folder and fix naming inconsistency.
...
2) Remove unwanted functions "module_js()" from the code.
3) Change naming convention for 'Roles' module.
2019-05-15 15:11:54 +05:30
Dave Page
4b421550d3
Stop using application/x-javascript as a mime type and use the RFC-compliant application/javascript instead. Fixes #4261
2019-05-15 09:44:57 +01:00
Dave Page
e53c2b1a5d
Ensure the treeview shows all sequences except those used to implement IDENTITY columns (which can be edited as part of the column). Show all if Show System Objects is enabled. Fixes #4154
2019-04-26 12:36:56 +01:00
Akshay Joshi
9b5a6e2bb7
Prevent duplicate columns being included in reverse engineered SQL for tables. Fixes #4163
2019-04-24 11:35:20 +01:00
Khushboo Vashi
ecded18333
Fix an issue where 'GRANT UPDATE' sql should be displayed for default sequence privileges. Fixes #4087
2019-04-22 12:24:47 +05:30
Khushboo Vashi
5452bff49e
Fixed 'Increment value cannot be empty' error for existing tables. Fixes #4160
2019-04-22 12:04:49 +05:30
Aditya Toshniwal
d96f453e7f
Fixed 'Location cannot be empty' error when open Tablespace properties. Fixes #4134
2019-04-18 12:31:35 +05:30
Aditya Toshniwal
024cfd2fab
1) Ensure that JSON strings as comments should be added properly for all the objects. Fixes #3582
...
2) Fixed alignment issue of columns in definition section of Index node. Fixes #4121
2019-04-12 15:07:07 +05:30
Khushboo Vashi
a9d964b5ca
1) Added support for Default Partition. Fixes #3938
...
2) Ensure that record should be add/edited for root partition table with primary keys. Fixes #4104
2019-04-11 13:25:24 +05:30
Akshay Joshi
9c3925e448
Ensure that parameters of procedures for EPAS server 10 and below should be set/reset properly. Fixes #4161
2019-04-10 13:22:52 +05:30
Murtuza Zabuawala
84ecffa4d9
Added recommended ESLinter checks. Fixes #4142
2019-04-05 13:07:43 +05:30
Dave Page
614c66940a
Add missing files.
2019-04-01 11:04:44 +01:00
Akshay Joshi
d286bada5c
Fix custom autovacuum configuration for Materialized Views. Fixes #4110
2019-04-01 09:47:17 +01:00
Akshay Joshi
61ff588c09
Fixed issue while fetching the view id for view/materialized view. Added schema name in where clause.
2019-03-30 13:20:31 +05:30
Aditya Toshniwal
55c6f5205d
Add some SQL updates to handle inherited column markers/comments that were missed in the previous commit.
2019-03-29 14:44:21 +00:00
Dave Page
4d45a3cb24
PEP-8 fixes.
2019-03-28 14:20:52 -04:00
Khushboo Vashi
97919d091a
Add support for IDENTITY columns. Fixes #4030
2019-03-28 13:13:43 -04:00
Aditya Toshniwal
8aaacdf96e
Include inherited column comments and defaults in reverse engineered table SQL. Fixes #2627
...
Include comment SQL for inherited columns in reverse engineered table SQL. Fixes #4037
Include inherited columns in SELECT scripts. Fixes #4058
2019-03-28 08:36:41 -04:00
Akshay Joshi
9c2ea3ca11
1) Ensure View/Materialized View node should be visible after updating any property. Fixes #4109
...
2) Updated the icon for Materialized View.
2019-03-26 14:12:47 +05:30
Akshay Joshi
a0010aac31
1) Ensure that sequence should be created with Privileges.
...
2) Updated the validation for blank values in Definition tab.
2019-03-25 14:29:43 +05:30
Akshay Joshi
212ca01506
Ensure sequences can be created with increment, start, minimum and maximum options set. Fixes #4100
2019-03-22 15:54:34 +00:00
Dave Page
ce073a2856
Fix SQL help for EPAS 10+, and refactor the URL generation code into a testable function. Fixes #4099
2019-03-22 14:09:24 +00:00
Akshay Joshi
48c5c39c5d
Ensure that parser should be set in FTS Configuration.
2019-03-20 20:21:58 +05:30
Akshay Joshi
5dd1472d6b
1) Fixed issue in Select2 Control, added undefined/null check.
...
2) Fixed the width of the delete cell.
2019-03-20 18:54:49 +05:30
Dave Page
906a4a845e
Update pycodestyle to 2.5.0. Allow newer versions so we can catch issues early.
2019-03-20 13:01:32 +00:00
Dave Page
7a271a34c6
Make the WHEN field a CodeMirror control on the Event Trigger dialogue. Fixes #4050
2019-03-15 10:35:47 +00:00
Dave Page
2e3475e06a
Fix the RE-SQL syntax for roles with a VALID UNTIL clause. Fixes #4081
2019-03-15 10:03:11 +00:00
Dave Page
69ec460b60
Fix naming inconsistency for the column and FTS parser modules. Fixes #1269
2019-03-14 16:52:42 +00:00
Khushboo Vashi
e4417229aa
Update all Python and JS dependencies. Fixes #4019
2019-03-14 15:11:16 +00:00
Dave Page
a9dad423f6
Fix the online help button on the resource group dialogue. Fixes #4052
2019-03-13 16:21:10 +00:00
Dave Page
cdc9ed678f
Enable the online help button on the index dialogue. Fixes #4053
2019-03-13 16:18:51 +00:00
Dave Page
ab9a3a57ad
Make the Query Tool history persistent across sessions. Fixes #4017
2019-03-13 13:37:34 +00:00
Khushboo Vashi
eb1db50f85
Avoid 'bogus varno' message from Postgres when viewing the SQL for a table with triggers. Fixes #3995
2019-03-12 10:13:31 +00:00
Dave Page
d7bf6ec69f
String review and subsequent cleanup
...
Ashesh Vashi
Abhilasha Narendra
Karen Blatchley
Susan Douglas
Dave Page
2019-03-05 14:08:16 +00:00
Dave Page
e5598038fa
Ensure size stats are prettified on the statistics tab when the UI language != English. Fixes #3096
2019-02-20 16:39:38 +00:00
Akshay Joshi
0aa93ac3ba
Fix alignment of Connection type toggle switch of pgagent. Fixes #3974
2019-02-13 13:03:44 +05:30
Dave Page
1fc66406f5
Don't embed docs and external sites in iframes, to allow the external sites to set X-FRAME-OPTIONS = DENY for security. Fxies #3985
2019-02-12 16:07:38 +00:00
Akshay Joshi
8f4d1f14f2
1) Fix alignment of import/export toggle switch. Fixes #3963
...
2) Remove unnecessary options for toggle switch which are already the default options.
2019-02-06 16:49:36 +05:30
Khushboo Vashi
4a75053514
Clean up the unwanted extended versions of Backform Switch controls.
...
The Bootstrap Switch Control was extended only for alignment in most
places. IIntroduce a configurable option to set the necessary class
on the main div and also remove the extra extended controls.
2019-02-05 16:22:35 +00:00
Aditya Toshniwal
d2ee5c4e82
1) Fixed jasmine test cases.
...
2) Bootstarp4 toggle size should be mini for triggers
2019-02-04 17:43:19 +05:30
Khushboo Vashi
dae8186c2a
Replace Bootstrap switch with Bootstrap4 toggle to improve the performance. Fixes #3051
2019-02-04 11:31:48 +05:30
Akshay Joshi
2afa3d8267
Remove icon for 'Refresh View' context menu of Materialized View and Added label for Definition control for consistency.
2019-01-31 13:20:44 +05:30
Khushboo Vashi
3b35aaa1d7
Fixed unable to drop multiple Rules and Foreign Tables from properties tab. Fixes #3899
2019-01-31 13:03:37 +05:30
Akshay Joshi
0bb4f005e5
Correct schema should be displayed in Materialized View dialog. Fixes #3916
2019-01-31 11:29:18 +05:30
Khushboo Vashi
406ada10f5
Fixed EXEC script for procedures. Fixes #3850
2019-01-23 14:44:24 +05:30
Akshay Joshi
11ab1918ea
Fixed domain sql regression test for EPAS
2019-01-22 18:22:16 +05:30
Khushboo Vashi
c6bae69b6f
Proper SQL should be generated when create domain of type interval with precision. Fixes #3853
2019-01-22 17:53:36 +05:30
Harshal Dhumal
ea87d6da8f
Fixed keyboard navigation for Select2 and Privilege cell in Backgrid Fixes #3908
2019-01-22 16:35:57 +05:30
Akshay Joshi
c7cbe0ff4a
Data should be updated properly for FTS Configurations, FTS Dictionaries, FTS Parsers and FTS Templates. Fixes #3897
2019-01-21 14:36:39 +05:30
Akshay Joshi
69f6895224
Proper SQL should be generated when create function with return type as custom type argument. Fixes #3774
2019-01-18 15:11:35 +05:30
Aditya Toshniwal
f779378e8a
Add right border on selected tree item.
2019-01-17 13:27:07 +05:30
Akshay Joshi
c1aba3e055
1) Proper SQL should be generated when creating/changing column with custom type argument. Fixes #3838
...
2) Proper SQL should be generated when create procedure with custom type arguments. Fixes #3846
2019-01-17 13:13:15 +05:30
Aditya Toshniwal
6bbcaf6b27
Fixed SQL for when clause while creating Trigger. Fixes #3837
2019-01-16 14:46:34 +05:30
Aditya Toshniwal
d7b0508305
Fixed SQL for foreign table options. Fixes #3453
2019-01-16 12:34:16 +05:30
Aditya Toshniwal
7ac4e2a9d9
Fixed following issues:
...
- Process watcher made fixed width with header changes, time details rounded to 2 decimals
- Query history will show "No query history" if no query fired. Query editor default size increased.
- Fixed a bug where New folder create button not working when in List mode and No files/folder present.
- Other minor improvements.
2019-01-16 11:55:08 +05:30
Akshay Joshi
252e05ef29
Fix SQL generated for tables with inherited columns. Fixes #3505
2019-01-11 21:50:02 +05:30
Akshay Joshi
01b87d4834
Don't show system catalogs in the schemas property list unless show system objects is enabled. Fixes #3842
2019-01-10 11:41:09 +05:30
Akshay Joshi
4e27bf989f
Display event trigger functions correctly on EPAS. Fixes #3549
2019-01-04 13:06:45 +00:00
Murtuza Zabuawala
e23d307c56
Update copyright notices for 2019
2019-01-02 15:54:12 +05:30
Aditya Toshniwal
86ecf9c84e
Fixed following:
...
- Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem.
- Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter
- Alignment fix for controls of Node properties dialogs which includes showing text and label in one line without dialog size change, checkbox alignment, switch control alignment at places and other minor improvements in other dialogs
- Error message design change in dialogs validation
- SQL Editor data grid editor popup design changes which were missed
- Design change for dashboard server activity grid
- Login page language dropdown color fix
- Properties accordion collapse design fix
- Help, Info icon fixed across all dialogs which were not working if clicked exactly on the text
- Added missing icon with buttons at few places
- Shadow behind the dialogs is increased to make it look clearly separated and depth.
- Control Alignment fix in maintenance dialog
- Min height of alertify dialogs set for better UX
- File dialog design fix when no files found
- Grant wizard fixes - Scroll bar visibility on first page, use full space for SQL generated on the last page
- Browser toolbar buttons changed to sync with SQL editor toolbar buttons
- Rounded corners for docker floating dialog (no properties)
- Renaming file in file dialog should show original file name
- SQL data grid text edit popup buttons behaviour was swapped. This is fixed.
- Import/Export dialog changes as per new design.
2019-01-02 15:07:59 +05:30
Ashesh Vashi
5799ac14ba
Improvement in the look and feel of the whole application
...
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
2018-12-21 17:14:55 +05:30
Aditya Toshniwal
ffae65bdbe
Ensure table definitions include WHERE clauses on EXCLUDE constraints. Fixes #3726
2018-12-20 10:19:54 +00:00
Akshay Joshi
7515e08578
Fix an issue when user define Cast from smallint->text is created. Fixes #3753
2018-12-19 18:02:04 +05:30
Akshay Joshi
c973c3387e
Include the WHERE clause on EXCLUDE constraints in RE-SQL. Fixes #3726
2018-12-18 13:37:04 +00:00
Khushboo Vashi
dfbb2212c0
Prevent attempts to bulk-drop schema objects. Fixes #3797
2018-12-13 11:03:30 +00:00
Akshay Joshi
3cfc3366d7
Fixed the height and width of the Table dialog.
2018-11-21 18:41:03 +05:30
Akshay Joshi
8b5abdfa8f
Fix changes to the NOT NULL and default value options in the Table Dialogue. Fixes #3742
2018-11-20 16:29:20 +00:00
Akshay Joshi
9b0889842d
Fix dropping of multiple functions/procedures at once. Fixes #3746
2018-11-14 08:40:21 -05:00
Dave Page
628f0d254e
Fix resource group multi-drop test.
2018-11-01 08:54:33 +00:00
Dave Page
7dde5d52d0
Fix regression test.
2018-10-31 12:18:13 +00:00
Khushboo Vashi
e59eaedfd0
Fix buildfarm failures.
2018-10-31 11:35:13 +00:00
Khushboo Vashi
f17979141c
Add support for dropping multiple objects at once from the collection Properties panel. Fixes #1513
2018-10-31 10:30:37 +00:00
Akshay Joshi
696fbfb8b9
Fix CREATE Script functionality for EDB-Wrapped functions. Fixes #3676
2018-10-29 11:54:11 +00:00
Akshay Joshi
50738db2b8
Fix syntax error when creating new pgAgent schedules with a start
...
date/time and exception. Fixes #3638
- Fixed syntax error.
- Update/Delete exceptions are not working, SQL is wrong.
- Wrong exception time is shown, it should shown in UTC as datatype of
the column is timestamp with out timezone.
- Added test cases for Schedule and Steps of pgAgent Job.
2018-10-17 12:28:31 +01:00
Aditya Toshniwal
d6c4911135
Fixed calender control issues with Bootstrap 4
2018-10-12 15:02:38 +05:30
Aditya Toshniwal
0565f8dd78
Update to use Bootstrap 3 instead of Bootstrap 4. Fixes #3562
2018-10-10 12:43:26 +01:00
Khushboo Vashi
528ea88dec
Save the treeview state periodically, and restore it automatically when reconnecting. Fixes #1253
2018-10-08 10:03:19 +01:00
Akshay Joshi
6c2c18106f
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around.
2018-09-24 14:11:23 -04:00
Aditya Toshniwal
38ddea038a
Fix support for the CLOB datatype in EPAS. Fixes #3596
2018-09-13 13:45:06 +01:00
Aditya Toshniwal
82c9cca683
Move all CSS into SCSS files for consistency and ease of colour maintenance etc. Fixes #2927
2018-09-04 11:24:51 +01:00
Akshay Joshi
dd3c7c94e6
Ensure external table node should be visible only for GPDB. Fixes #3548
2018-08-27 19:11:25 +05:30
Joao De Almeida Pereira
46d4bf027d
Ensure sql for Role should be visible in SQL panel for GPDB. Fixes #3578
2018-08-17 14:50:16 +05:30
Akshay Joshi
c8c5f83dfe
Add support to save and clear SSH Tunnel password. Fixes #3511
2018-08-06 15:56:46 +05:30
Akshay Joshi
a17aa212f0
COST statement should not be automatically duplicated after creating trigger function. Fixes #3526
2018-08-06 11:54:25 +05:30
Akshay Joshi
e9e8b0b433
1. Change the string from 'Reset server password" to "Clear Saved Password" and move this sub menu from File to Object menu.
...
2. Move the "Change Password..." menu from 'File' to 'Object' menu.
RM #3074
2018-08-03 16:41:01 +05:30
Khushboo Vashi
0cb25bde63
Add support for primary key, foreign key, unique key, indexes and triggers on partitioned tables for PG/EPAS 11. Fixes #3412
2018-07-27 17:31:21 +05:30
Akshay Joshi
0138dee989
Add support for reset saved password. Fixes #3074
2018-07-27 14:36:42 +05:30
Akshay Joshi
213cb440d0
Add support for SCRAM password changes (requires psycopg2 >= 2.8). Fixes #2214
2018-07-23 15:03:44 +01:00
Khushboo Vashi
2d1e835d32
Fix panel errors seen when click on partitions.
2018-07-23 14:33:40 +01:00
Aditya Toshniwal
c353135a3a
Add support for INCLUDE columns on indexes and index constraints with PG 11+. Fixes #3462
2018-07-19 13:13:37 +01:00
Akshay Joshi
ce768c7f8a
Support SSH tunneling with keys that don't have a passphrase. Fixes #3468
2018-07-18 14:15:05 +01:00
Khushboo Vashi
8869fd6eb3
Fix a number of debugger execution issues. Fixes #3191
...
1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT.
2. Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument and function with void return type
3. The Reverse engineering SQL is not correct for Packages' functions/procedures
4. In case of INOUT argument, debugger asks for mendatory input which should not.
5. Re-executing a procedure whilst direct debugging doesn't work.
2018-07-17 12:51:24 +01:00
Akshay Joshi
39b41d7b24
Various procedure/function related fixes for EPAS/PG 11. Fixes #3446
...
- Fix the RM #3446 "plpgsql keyword should displayed in SQL pane for EPAS-11".
- Procedures for EPAS 11 always created as 'edbspl', even though language is sql or plpgsql.
- Not able to create Function/Procedure/Trigger function if the language is "C" for all supported database server.
- Function creation for EPAS 9.6 and above when set "Window?" flag to "Yes".
- Disable Volatility, Strict, Parallel, Estimated cost and Leak prof while creating procedures in EPAS 11 when language is not 'edbspl'.
- Rename "default" folder to "11_plus" inside "pg" directory for procedures, as procedures are supported from PG11 onwards.
- Creating/Deleting parameter in Procedure for PG 11.
- Drop procedures with arguments for PG/EPAS 11.
pg_proc table has added default value 'v' for Volatility, 100 for Cost and 'u' for Parallel for any language. All the three are not supported for Procedures in PG/EPAS 11 (excluding 'edbspl' language for EPAS). Fixed the issue where it is visible in properties panel if we create procedure using language 'plpgsql' or 'sql'.
2018-07-17 12:43:46 +01:00
Aditya Toshniwal
41a8333145
Replace deprecated success, error callbacks in $.ajax call with new functions .done and .fail.
2018-07-09 13:54:00 +01:00
Akshay Joshi
57c054fb0e
Fix various Drop menu options that were broken during the treeview refactoring.
...
Fixes #3442 . Fixes #3443 . Fixes #3444
2018-06-25 15:52:12 +01:00
Akshay Joshi
4a71c6d7af
Various EPAS/PG11 function & procedure fixes. Fixes #3421 . Fixes #3422
2018-06-25 14:58:02 +01:00
Akshay Joshi
560e5f225a
Allow dropping of Procedures in PG 11. Fixes #3423
2018-06-21 16:36:10 -04:00
Akshay Joshi
480fe6b9fc
Fixed issue of detection of EPAS server 11 and above. Version string is changed in EPAS 11
2018-06-21 18:30:37 +05:30
Joao Pedro De Almeida Pereira
155f82676d
Fix the RE-SQL generation for GreenPlum external tables. Fixes #3431
2018-06-19 20:01:45 -04:00