Nikhil Mohite
b764046587
Fixed an issue where privileges were revoked using SQL query on objects like tables that do not correctly show in SQL tab. Fixes #4567
2021-08-27 12:54:14 +05:30
Aditya Toshniwal
d38f520805
Added support for the truncate table with restart identity. Fixes #2538
2021-08-27 12:41:29 +05:30
Nikhil Mohite
b30a42ab9e
Ensure that deleting a database should not automatically connect to the next database. Fixes #6685
2021-08-25 17:01:48 +05:30
Aditya Toshniwal
c543930ac4
Fixed RESQL test cases.
2021-08-25 16:56:12 +05:30
Aditya Toshniwal
e39838455e
Ensure that trigger function SQL should have 'create or replace function' instead of 'create function' only. Fixes #5849
2021-08-24 18:23:32 +05:30
Akshay Joshi
7798584e1c
Fixed an issue where columns with sequences get altered unnecessarily with a schema diff tool. Fixes #6564
2021-08-18 19:33:01 +05:30
Pradip Parkale
7483ddf2b2
Added support to copy SQL from main window to query tool. Fixes #4904
2021-08-09 14:29:31 +05:30
Khushboo Vashi
78b041465e
Fixed an issue where even if the user is locked, he can reset the password and can login into pgAdmin. Fixes #6664
2021-08-09 14:24:26 +05:30
Aditya Toshniwal
9d985d3d8f
Fixed potential bug in the table node.
2021-07-30 13:28:07 +05:30
Rahul Shirsat
2dd88e5a4e
Ensure that all the required options should be loaded when the Range data type
...
is selected while creating a custom data type.
Fixes #6643
2021-07-29 10:43:27 +05:30
Aditya Toshniwal
2452d90300
Fixed incorrect tablespace options in the drop-down for move objects dialog. Fixes #6586
2021-07-27 17:28:38 +05:30
Akshay Joshi
3f67f512ec
Fixed incorrect binary path issue when the user deletes the binary path from the preferences. Fixes #6619
2021-07-26 11:49:48 +05:30
zhangjie2@fujitsu.com
3a3eea0320
Correct the string for shared server test case.
2021-07-23 12:44:16 +05:30
Rahul Shirsat
6cc3423cbe
Fixed session expiration API test case.
2021-07-20 16:29:03 +05:30
Nikhil Mohite
5768ade198
Added exception handling for SQLAlchemy function to check the table exists or not.
2021-07-19 14:01:45 +05:30
Rahul Shirsat
b0727cc532
Fixed CSRF errors for stale sessions by increasing the session expiration time for desktop mode. Fixes #6369
2021-07-15 17:49:42 +05:30
Khushboo Vashi
e981868246
Fixed an issue where the user unable to add server in Kerberos Authentication Mode with Master Password. Fixes #6595
2021-07-09 21:47:34 +05:30
Khushboo Vashi
36086722b3
RESQL testcase fixes for Triggers.
2021-07-07 17:56:30 +05:30
Rahul Shirsat
8edd5946e5
1) Modified some labels and controls.
...
2) Fixed issue where the same user is showing in SQL query.
3) Added SQL tab in the dialog.
refs #3893
2021-07-07 10:44:02 +05:30
Identifier Anonymous
39a845ad31
Remove extra brackets in CREATE script and DDL comparison for trigger node.
2021-07-06 19:07:35 +05:30
Khushboo Vashi
48ca83f31d
Added support for OAuth 2 authentication. Fixes #5940
...
Initial patch sent by: Florian Sabonchi
2021-07-06 13:22:58 +05:30
Rahul Shirsat
5fe52b9cfe
Added support for Reassign/Drop Owned for login roles. Fixes #3893
2021-06-28 18:55:52 +05:30
Pradip Parkale
e095d382b3
Fixed an issue where incorrect column name listed in the properties of Index. Fixes #6557
2021-06-27 19:00:16 +05:30
Pradip Parkale
5581f0909a
Fixed an issue where Debugger and ERD tool panel give a blank white panel, missing from the last patch.
...
refs #6398
2021-06-25 11:38:02 +05:30
Ashesh Vashi
cfb68d73a0
Fixed server mode api test case failure.
2021-06-24 19:41:58 +05:30
Ashesh Vashi
9574f43f87
Refactor the registry class logic and remove duplicate code for the same functionality.
2021-06-24 11:30:11 +05:30
Libor M
cc989c5c08
Added missing gettexts and text space improvements.
2021-06-24 11:15:50 +05:30
Nikhil Mohite
e2302a6c9b
Ensure that setting 'Open in new browser tab' should be visible, it should not be based on the value of 'ENABLE_PSQL'. Fixes #6541
2021-06-23 11:59:56 +05:30
Dave Page
4e067835c3
Revert "Fixed API test cases for PG/EPAS 9.6" per Khushboo.
...
This reverts commit 37278f2cd3
.
2021-06-17 13:27:33 +01:00
Khushboo Vashi
37278f2cd3
Fixed API test cases for PG/EPAS 9.6
2021-06-17 16:22:53 +05:30
Nikhil Mohite
2549688bdf
1) Disable the PSQL feature entirely in server mode by default.
...
2) Remove the code that attempts to filter out commands.
refs #2341
2021-06-14 20:53:11 +05:30
Nikhil Mohite
09693d14d1
Added check if the Windows version is not supporting the ConPty or WinPty disable the PSQL for that version.
...
refs #2341
2021-06-14 11:47:40 +05:30
Akshay Joshi
0dbfbd8dfc
1) Fixed Selenoid test cases.
...
2) Fixed RESQL test case failing on Jenkins.
2021-06-11 15:34:12 +05:30
Aditya Toshniwal
6e42d9113b
Fixed user password-related issues.
...
refs #6225
2021-06-10 22:56:38 +05:30
Khushboo Vashi
460fb7ec29
Fixed an issue where pgAdmin does not open after password reset in server mode. Fixes #6513
2021-06-10 22:55:31 +05:30
Akshay Joshi
c86a2b643a
1) Binary path set to the default location in which we install the binaries.
...
2) Validate path not working if there is a space in the binary path.
3) Handle the case when the path contains '$DIR'.
refs #5370
2021-06-10 22:49:05 +05:30
Yogesh Mahajan
b2042f48cd
Added RESQL/MSQL test cases for Table and its child nodes. Fixes #4622
2021-06-09 18:16:50 +05:30
Nikhil Mohite
7c88ee7cff
Added a mechanism to detect a corrupt/broken config database file. Fixes #6460
2021-06-08 19:41:47 +05:30
Nikhil Mohite
93ddc4a5ba
Ensure that the user should be able to add members in Login/Role group while creating it. Fixes #6466
2021-06-08 19:33:03 +05:30
Nikhil Mohite
9f12747d9b
Added PSQL tool support for the Windows platform.
...
Fixed following issues:
1. If the database name contains escape characters then PSQL unable to connect.
2. If the user terminates the connection by typing the 'exit' command, PSQL
will show the connection termination msg.
Fixes #2341
2021-06-08 14:58:43 +05:30
Akshay Joshi
5a086a9173
Fixed API test cases failed due to wrong handling of default binary path.
2021-06-08 13:24:17 +05:30
Nikhil Mohite
e1067ffe67
Ensure that the Query Tool connection string should not be changed as per the 'Query Tool tab title'. Fixes #6404
2021-06-07 22:07:51 +05:30
Nikhil Mohite
5b12483416
Fixed an issue where the Foreground Color property of server dialog does not work. Fixes #6482
2021-06-07 21:09:04 +05:30
Akshay Joshi
07eb541806
1) Added logic to set the appropriate default binary path if DEFAULT_BINARY_PATH is
...
set in the config and the user not updated the preferences.
2) Remove 'gpdb' from DEFAULT_BINARY_PATH.
3) Fixed API test cases.
refs #5370
2021-06-07 20:36:34 +05:30
Aditya Toshniwal
065a3aa2f5
Updated Flask-Security-Too to the latest v4. Fixes #6225
2021-06-06 13:58:06 +05:30
Akshay Joshi
4bc4ca1ba9
1) Added browse button to select the binary path in the Preferences. Fixes #1561
...
2) Added support to set the binary path for the different database server versions. Fixes #5370
2021-06-04 17:55:35 +05:30
Nikhil Mohite
e0eac875b6
Disable the PSQL tool for Windows, the 'fcntl' module is not working on Windows.
2021-06-01 20:04:43 +05:30
Rahul Shirsat
9ac08c263b
Fixed duplicate SQL issue for tables with more than one partition. Fixes #6478
2021-05-31 12:46:07 +05:30
Rahul Shirsat
658a2de619
Fixed the issue of renaming the database by another user. Fixes #4203
2021-05-31 12:41:09 +05:30
Ashesh Vashi
a487a51135
Fixes SonarQube issues.
2021-05-29 12:55:59 +05:30
Nikhil Mohite
3ddf941cd7
Added support to launch PSQL for the connected database server. Fixes #2341
2021-05-25 20:12:57 +05:30
Rahul Shirsat
37dece2cd8
Added window maximize/restore functionality for properties dialog. Fixes #4064
2021-05-24 22:08:23 +05:30
Pradip Parkale
4676d7ef02
Fixed an issue where the Help message not displaying correctly on Login/Group role. Fixes #6414
2021-05-17 13:08:38 +05:30
Aditya Toshniwal
b7c0914f33
Fixed 'No password supplied' error occurring on auto-detected servers.
2021-05-14 15:14:18 +05:30
Khushboo Vashi
7275ce906e
1) Fixed an issue where the user is not warned if Kerberos ticket expiration
...
is less than 30 min while initiating a global backup. Fixes #6444
2) Ensure that proper identification should be there when the server is
connected using Kerberos or without Kerberos. Fixes #6445
2021-05-14 12:33:01 +05:30
Pradip Parkale
0bb40de1c4
Ensure that the user should not be able to add duplicate panels. Fixes #6399
2021-05-12 15:19:41 +05:30
Akshay Joshi
4842d589a6
Added missing validation for data type. Fixes #6407
2021-05-11 18:21:53 +05:30
huangj.fnst@fujitsu.com
fe6f9aae61
Fix a number of typos.
2021-05-11 11:16:38 +01:00
Yogesh Mahajan
b0df4d3604
Added support for the creation of Nested Table and Varying Array Type for Advanced Server. Fixes #6407
2021-05-07 12:39:54 +05:30
Murtuza Zabuawala
4c55044440
Remove duplicate code and avoid DOM search operation.
...
refs #6355
2021-05-06 10:53:32 +05:30
Akshay Joshi
b13627398b
Fixed API test cases
2021-05-05 13:12:20 +05:30
Khushboo Vashi
b30ec71098
Ensure that while connecting to the server using SSPI login, it should not prompt for the password. Fixes #5776
2021-05-05 11:40:48 +05:30
Akshay Joshi
7e79814cb0
Added 'IF NOT EXISTS' clause while creating tables and partition tables which is convenient while using the ERD tool. Fixes #6397
2021-05-04 15:59:34 +05:30
Khushboo Vashi
72f3730c34
Added support to connect PostgreSQL servers via Kerberos authentication. Fixes #6158
2021-05-03 16:10:45 +05:30
Akshay Joshi
aa9a4c30d3
Fixed an issue where duplicate columns are visible in the browser tree, which is owned by two sequences. Fixes #6413
2021-05-03 14:53:21 +05:30
Akshay Joshi
e718be72e3
Added comment column in the properties panel for View and Materialized View collection node. Fixes #6416
2021-04-28 18:44:28 +05:30
Pradip Parkale
9dd1bae3c7
Ensure that pgAdmin should not allow opening external files that are dragged into it. Fixes #6355
2021-04-28 11:59:45 +05:30
Pradip Parkale
7bab200e4d
Added more checks so that it will pick the correct shared server.
...
refs #6385
2021-04-27 11:58:47 +05:30
Rahul Shirsat
f5ef022ef5
Fixed an issue where indexes showing TABLESPACE pg_default for partition SQL, which should not be shown.
...
refs #6329
2021-04-27 11:54:56 +05:30
Akshay Joshi
7d6f077cf8
Fixed an issue where schema diff does not create DROP DEFAULT statement for columns. Fixes #6377
2021-04-26 16:41:20 +05:30
Rahul Shirsat
b853bda2a2
Fixed an issue where the wrong SQL is showing for the child partition tables. Fixes #6329
2021-04-26 14:32:34 +05:30
Pradip Parkale
abdd3190fe
Fixed some SonarQube issues.
2021-04-22 17:40:41 +05:30
Pradip Parkale
8ae8fea6d2
Ensure that Backup and Restore should work on shared servers as some cases were failing due to initial changes.
...
Fixes #6385
2021-04-22 17:29:04 +05:30
Yogesh Mahajan
dc65cbb08c
Fixed an issue where foreign data wrapper properties are not visible if the host option contains two host addresses. Fixes #6379
2021-04-19 11:08:21 +05:30
Aditya Toshniwal
2b1910c1c1
Better fix for the black screen issues, reverted the old fix.
...
refs #6334
2021-04-16 18:23:29 +05:30
Akshay Joshi
b4d44541bb
Fixed SQL panel black screen issue when detaching it in runtime. Fixes #6334
2021-04-15 16:40:35 +05:30
Pradip Parkale
cb7bcaf939
Ensure that Backup and Restore should work on shared servers. Fixes #6385
2021-04-14 12:11:55 +05:30
Rahul Shirsat
f07463024c
Fixed flickering issue of the input box on check constraints. Fixes #6107
2021-04-12 12:34:36 +05:30
Pradip Parkale
0ed47fcd2b
Fixed an issue where the Save button is enabled by default when open the table's properties dialog on PG 9.5. Fixes #6367
2021-04-12 11:36:16 +05:30
Pradip Parkale
ffdd58ffb4
Fixed some SonarQube issues.
2021-04-08 12:27:03 +05:30
Akshay Joshi
7f59463e3b
Corrected the syntax for 'CREATE TRIGGER', use 'EXECUTE FUNCTION' instead of 'EXECUTE PROCEDURE' from v11 onwards. Fixes #6220
2021-04-07 12:01:37 +05:30
Rahul Shirsat
585ba81492
Fixed sizing issue of help dialog for Query Tool and ERD Tool when open in the new browser tab. Fixes #6333
2021-04-06 15:26:25 +05:30
Akshay Joshi
c84df9cc0f
Ensure that while comparing domains check function dependencies should be considered in schema diff. Fixes #6327
2021-04-01 16:31:12 +05:30
Pradip Parkale
566f03beca
Ensure that the query tool tab should be closed after server disconnection when auto-commit/auto-rollback is set to false. Fixes #5519
2021-04-01 11:58:59 +05:30
Akshay Joshi
07f2df7e66
Fixed cannot unpack non-iterable response object error when selecting any partition. Fixes #6344
2021-03-31 12:08:01 +05:30
Rahul Shirsat
f0c86741a4
Improve code coverage and API test cases for Server module. Fixes #5319
2021-03-30 11:12:33 +05:30
Akshay Joshi
a29890368c
Fixed an issue where the procedure creation is failed when providing the Volatility option. Fixes #6293
2021-03-30 10:58:32 +05:30
Akshay Joshi
2872b5c5d3
1) Ensure that the zoom level should be set for the newly opened window.
...
2) Ensure that if the zoom level is changed on the main window then it should
be applicable for all the opened windows.
refs #6271
2021-03-22 17:50:26 +05:30
Nikhil Mohite
15b8d4711e
Hide the checkbox on the role property tab for 'Members of' and 'Members'.
...
refs #5404
2021-03-19 15:48:05 +05:30
Pradip Parkale
24dc7f4a91
Fixed some issues reported by SonarQube.
2021-03-19 11:56:12 +05:30
Rahul Shirsat
f5cc1d1c7e
Fixed cognitive complexity reported by SonarQube.
2021-03-19 11:51:45 +05:30
Akshay Joshi
4bb71c56ad
Fixed an issue where the top menu disappears when entering into the full screen for minimum screen resolution. Fixes #6322
2021-03-17 18:47:25 +05:30
Pradip Parkale
ff06a18155
1) Fixed an issue where the incorrect values visible in the dependents tab for publication. Fixes #6307
...
2) Ensure that the primary key should be visible properly in the table dialog. Fixes #6316
2021-03-16 11:43:27 +05:30
Akshay Joshi
49a59f8929
Added zoom scaling options with keyboard shortcuts in runtime. Fixes #6271
2021-03-15 14:26:11 +05:30
Nikhil Mohite
7bad4ca535
Show the login roles that are members of a group role be shown when examining a group role. Fixes #5404
2021-03-12 13:11:09 +05:30
Rahul Shirsat
9d8360641f
Use schema qualification while accessing the catalog objects.
...
refs #3976
2021-03-12 11:17:25 +05:30
Pradip Parkale
d6ee715d83
Ensure that autovacuum and analyze scale factors should be editable with more than two decimals. Fixes #4784
2021-03-09 18:48:32 +05:30
Akshay Joshi
351d86e149
Fixed string index out of range error where the dependent tab is in focus and selecting any publication or table. Fixes #6292
2021-03-09 18:43:04 +05:30
Akshay Joshi
0f62fecca2
Fixed an issue where the dependent tab throwing an error when selecting any login/group role. Fixes #6294
2021-03-09 14:32:16 +05:30
Rahul Shirsat
a2be30d257
Use schema qualification while accessing the catalog objects. Fixes #3976
2021-03-09 13:18:45 +05:30
Nikhil Mohite
d70dea5072
Ensure that the template database should be visible while creating the database. Fixes #6286
2021-03-04 17:48:52 +05:30
Akshay Joshi
8c7417b735
Fixed regressions from the last commit.
2021-03-03 11:46:47 +05:30
Akshay Joshi
008bc6da28
Fixed some SonarQube issues.
2021-03-02 14:53:05 +05:30
Huangj
9225493a93
Fixed an issue where schema diff showing wrong SQL when comparing triggers with different when clause. Fixes #6281 .
2021-03-01 13:20:43 +05:30
Pradip Parkale
4267207c7f
1) Fixed an issue where the user is unable to create a subscription if the host/IP address for connection is 127.0.0.1. Fixes #6253
...
2) Ensure that proper error message should be shown on the properties and statistics tab in case of insufficient privileges for a subscription. Fixes #6259
3) Fixed an issue where the 'Create Slot' option is disabled in case of the same IP/host provided but the port is different. Fixes #6260
2021-03-01 12:08:33 +05:30
Rahul Shirsat
5a5a9314f3
Fixed an issue where the Save button is enabled for functions/procedures by default when open the properties dialog. Fixes #5073
2021-02-26 13:15:29 +05:30
Nikhil Mohite
4fc36a9053
Fixed an issue where the properties tab for collection nodes is unresponsive after switching the tabs. Fixes #4959
2021-02-26 12:50:30 +05:30
Pradip Parkale
291e645d77
1) Updated documentation for SSL support in Subscription dialog.
...
2) Fixed API test cases.
refs #6201
2021-02-22 11:02:16 +05:30
Pradip Parkale
731ba32e81
1) Added SSL support for creating a subscription. Fixes #6201
...
2) Fixed an issue where the user is not able to create the subscription. Fixes #6230
3) Fixed a couple of issues raised during testing of logical replication.
2021-02-19 14:56:45 +05:30
Pradip Parkale
e5a91d30bf
Fixed API test cases.
2021-02-15 18:29:49 +05:30
Akshay Joshi
3fc0cc3e92
Fixed SonarQube issues
2021-02-15 17:31:20 +05:30
Pradip Parkale
44cc7a308a
Added publication and subscription support in Schema Diff. Fixes #6153
2021-02-15 16:05:40 +05:30
Rahul Shirsat
2036e9d9a8
Fixed an issue where the user is unable to update column-level privileges from the security tab. Fixes #6117
2021-02-10 17:56:26 +05:30
Aditya Toshniwal
1317e4254b
Updated the JS dependencies to the latest
...
1) Migrate from webpack 4 to webpack 5. This had a lot of breaking changes,
so updated multiple webpack plugins and changed the config accordingly.
2) Replaced iconfont-webpack-plugin with a more maintained webfonts-loader.
3) Replaced deprecated babel-eslint with @babel/eslint-parser.
4) Replaced optimize-css-assets-webpack-plugin with a more maintained css-minimizer-webpack-plugin.
5) Updated all other JS packages and made the required code changes.
Fixes #6207
2021-02-10 12:47:52 +05:30
Aditya Toshniwal
617440e1db
Ensure that ajax request for Dashboard, Statistics, Dependencies, and Dependents
...
should not be raised until the panel will be in focus.
refs #5091
2021-02-09 15:31:26 +05:30
Nikhil Mohite
02c3863e8c
Fixed an issue where shared server entries not getting deleted from SQLite database if the user gets deleted. Fixes #6143
2021-02-04 11:31:39 +05:30
Aditya Toshniwal
73b6b95fbc
Make Statistics, Dependencies, Dependants tabs closable and the user can add them back using the 'Add panel' option. Fixes #5091
2021-02-03 12:46:32 +05:30
Pramod Ahire
9e90350e44
Fixed jasmine test cases and added some missing messages for disabled menus.
2021-02-03 12:15:37 +05:30
Akshay Joshi
eca8e706dd
Fixed SearchObjectsApiSearch test cases failed for EPAS 9.5 and 9.6
2021-02-02 19:47:06 +05:30
Pramod Ahire
b948f43dda
Added Quick Search functionality for menu items and help articles. Fixes #6148
2021-02-02 14:47:58 +05:30
Khushboo Vashi
f7214b7cfe
Fixed dependency tab loading issue when database name having special characters.
...
refs #6087
2021-02-02 11:49:51 +05:30
Pradip Parkale
bf56a6723b
Added support for Logical Replication. Fixes #5912
2021-02-01 15:12:43 +05:30
Akshay Joshi
179bac3fd0
Fixed API test cases failed due to SonarQube fixes.
2021-01-31 18:19:14 +05:30
Dave Page
08df09af96
Limit the upgrade check to run once per day. Fixes #6187
2021-01-29 16:01:35 +00:00
Dave Page
3c1dc18656
Fix typo
2021-01-29 15:40:23 +00:00
Dave Page
12276b6033
Fix typo
2021-01-29 15:34:51 +00:00
Akshay Joshi
102ffd141c
Implemented runtime using NWjs to open pgAdmin4 in a standalone window
...
instead of the system tray and web browser. Used NWjs to get rid of QT
and C++. Fixes #5967
Use cheroot as the default production server for pgAdmin4. Fixes #5017
2021-01-29 13:38:27 +05:30
Aditya Toshniwal
a0271c7656
Fixed an issue while downloading ERD images in Safari and Firefox. Fixes #6177
2021-01-29 12:19:24 +05:30
Akshay Joshi
358af42c50
Fixed an issue where the dependencies tab showing multiple owners for the objects having shared dependencies. Fixes #6087
2021-01-29 12:10:21 +05:30
Rahul Shirsat
ab642344d4
Ensure that username should be visible in the 'Connect to Server' popup when service and user name both specified. Fixes #5871
2021-01-29 11:32:27 +05:30
Rahul Shirsat
e230787f21
Fixed SonarQube issues.
2021-01-29 11:06:59 +05:30
Aditya Toshniwal
13db981445
Fixed following issues in ERD:
...
1) After opening an existing project, the first table is already selected but the edit, clone, delete buttons are disabled.
2) ERD project title gets changed when 2 ERD projects are open & anyone of it edited.
3) Closing the ERD tab does not ask for a confirmation pop-up.
4) Shortcut for 'Show more/Fewer details' is missing.
5) Deleting the primary key does not delete associated links.
6) The long table & schema name are getting out of the box.
7) The long table name in the notes pop-up needs re-alignment.
8) The same table name present in ERD/canvas is allowed in Add Table dialogue. Added validation in the dialog.
9) Download image option is added, but it is not perfect yet. Image icons (table, schema, etc.) are not showing up.
10) Rename panel option should be disabled by default. It should be enabled for the tools which implement rename functionality.
11) The Toolbar is not visible in Safari for the ERD tool.
refs #1802
2021-01-25 17:32:56 +05:30
Akshay Joshi
3e09f1bf40
Ensure that the current value of the sequence should be ignored while comparing using schema diff. Fixes #6144
2021-01-21 14:18:06 +05:30
Dave Page
91ca746c27
Fix menu text (the Query tool option doesn't open a dialogue, so should not have ...).
2021-01-20 15:52:34 +00:00
Dave Page
a2f626046a
Fix labels.
2021-01-20 15:47:41 +00:00
Akshay Joshi
9fa29457a4
Update copyright notice for ERD and Kerberos files.
2021-01-19 16:22:53 +05:30
Nikhil Mohite
da9f9017a9
Fixed cognitive complexity reported by SonarQube.
2021-01-19 13:34:14 +05:30
Nikhil Mohite
94d2ad9584
Fixed API test cases for Kerberose.
2021-01-19 13:28:55 +05:30
Khushboo Vashi
c0ef0a893d
1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457
...
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
2021-01-18 16:32:10 +05:30
Nikhil Mohite
d4a3e4d92c
Fixed issues reported by SonarQube.
2021-01-18 13:02:19 +05:30
Aditya Toshniwal
0c8226ff39
Added ERD Diagram support with basic table fields, primary key, foreign key, and DDL SQL generation. Fixes #1802
2021-01-16 17:06:50 +05:30
Nikhil Mohite
a2edf317a9
Ensure that the user should be able to specify an older date for the account expiration of the role/user. Fixes #6120
2021-01-15 11:38:08 +05:30
Akshay Joshi
f86f58dc56
Revert "Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120"
...
This reverts commit 9a47e574e3
.
2021-01-14 14:47:52 +05:30
Akshay Joshi
f0debdd513
Revert "1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457"
...
This reverts commit 6ead597b43
.
2021-01-14 14:46:59 +05:30
Khushboo Vashi
6ead597b43
1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457
...
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
2021-01-14 13:46:48 +05:30
Nikhil Mohite
9a47e574e3
Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120
2021-01-14 12:09:03 +05:30
Rahul Shirsat
d55555c544
Fixed an issue where sequences are not created. Fixes #6128
...
refs #6084
2021-01-11 17:29:08 +05:30
Nikhil Mohite
f8497d4e7a
Fixed an issue where the database list in the new connection window is not visible. Fixes #6121
2021-01-11 13:03:15 +05:30
Akshay Joshi
b372f08a59
Update copyright notices for 2021
2021-01-04 15:34:45 +05:30
Aditya Toshniwal
5198a881b7
Added 'Count Rows' option to the partition sub tables. Fixes #5282
2021-01-04 15:25:05 +05:30
Aditya Toshniwal
233736897d
Added 'CREATE TABLE' SQL missed in the last patch for #5571
...
refs #5571
2021-01-04 15:06:28 +05:30
Nikhil Mohite
cd5243ac6d
Fixed RESQL test cases for schema
2020-12-31 13:54:19 +05:30
Yogesh Mahajan
d1f5511566
Improve code coverage and API test cases for pgAgent. Fixes #5338
2020-12-31 13:52:14 +05:30
Nikhil Mohite
26bbc0e877
Fixed RESQL test cases for Column.
2020-12-30 12:25:07 +05:30
Aditya Toshniwal
f9087475d4
Fixed RESQL test cases for exclusion constraints.
...
refs #5571
2020-12-24 14:03:07 +05:30
Nikhil Mohite
dbb4a46d46
Fixed accessibility issues in various dialogs. Fixes #6077
2020-12-24 13:26:25 +05:30
Rahul Shirsat
4c9853f10d
Fixed an issue where pressing the back button will show another instance of the main page inside of the Query Tool tab. Fixes #4892
2020-12-24 13:13:57 +05:30
Aditya Toshniwal
5448de2d3f
Added support for expression in exclusion constraints. Fixes #5571
2020-12-24 12:50:57 +05:30
Nikhil Mohite
a92595012f
Fixed extra parentheses issue around joins for Views. Fixes #6061
2020-12-23 13:02:16 +05:30
Rahul Shirsat
3def9792be
Added appropriate help message and a placeholder for letting users know about the account password expiry for Login/Group Role. Fixes #5973
2020-12-17 12:02:32 +05:30
Rahul Shirsat
cb0a914099
Ensure that the 'template1' database should not be visible after pg_upgrade. Fixes #5875
2020-12-16 11:37:19 +05:30
Akshay Joshi
21333490ef
1. Added check to skip debugger test case if the plugin is not installed.
...
2. Added code to delete the existing "pldbgapi" extension and create a new extension.
3. Updated a few test cases that are falling on specific servers.
4. Fixed test cases for pgAgent.
Fixed by: Nikhil & Yogesh
2020-12-16 11:25:16 +05:30
Nikhil Mohite
794bd50ed1
Improve code coverage and API test cases for Debugger. Fixes #5343
2020-12-03 10:31:24 +05:30
Yogesh Mahajan
26b3bc3f74
Fixed an issue where an illegal argument is showing for trigger SQL when a trigger is created for View. Fixes #6003
2020-12-02 10:55:23 +05:30
Akshay Joshi
64e6570f00
Fixed an issue where schema diff doesn't show the result of compare if source schema has tables with RLS. Fixes #5998
2020-12-01 13:46:19 +05:30
Yogesh Mahajan
783b7516a7
Fixed false error is shown while adding a new foreign key from the table dialog when a foreign key already exists with Auto FK Index set to true. Fixes #5886
2020-12-01 11:35:01 +05:30
Yogesh Mahajan
b54cf2edca
Improve code coverage and API test cases for Foreign Tables. Fixes #5328
2020-11-26 11:52:06 +05:30
Yogesh Mahajan
ce14696165
Improve code coverage and API test cases for Views and Materialized Views. Fixes #5337
2020-11-20 10:04:30 +05:30
Rahul Shirsat
be386e77f2
1) Fixed an issue where the process watcher dialog throws an error for
...
the database server which is already removed. Fixes #5985
2) Fixed cognitive complexity reported by SonarQube.
2020-11-12 17:47:21 +05:30
Nikhil Mohite
a026f339c3
Fixed cognitive complexity reported by SonarQube.
2020-11-12 17:20:58 +05:30
Nikhil Mohite
2793747d3c
1) Added support for dynamic tab size. Fixes #4231
...
2) Fixed an issue where a long file name is not visible on the process watcher dialog. Fixes #5950
2020-11-04 17:45:28 +05:30
Pradip Parkale
25fcdab9db
Fixed an issue where a mismatch in the value of 'Estimated row' for functions. Fixes #5914
2020-10-30 15:09:40 +05:30
Rahul Shirsat
183c83f0d2
Fixed an issue where the validation error message is shown twice. Fixes #5736
2020-10-30 14:59:22 +05:30
Akshay Joshi
b76bb58378
Added support to compare schemas and databases in schema diff. Fixes #5891
2020-10-27 16:36:10 +05:30
Libor M
7648bd9646
Added missing gettext.
2020-10-27 10:51:35 +05:30
Nikhil Mohite
c86a3d64fc
Added support to rename query tool and debugger tabs. Fixes #4230
...
Fixed an issue where non-closeable tabs are getting closed. Fixes #5923
2020-10-23 17:16:31 +05:30
Nikhil Mohite
275d13d40f
Following issues have been resolved for the new connection feature:
...
1. Show servers with server groups in the dropdown.
2. Highlighted current selected connection in the new connection dropdown.
3. Notify the user before changing the connection.
refs #3794
2020-10-21 17:14:59 +05:30
Ganesh Jaybhay
08c4deba5a
Added following security enhancements:
...
1) Added ALLOWED_HOSTS list to limit the host address.
2) Added CSP and HSTS security header.
3) Hide the webserver/ development framework version.
Fixes #5919
2020-10-20 17:14:45 +05:30
Pradip Parkale
3413a42af4
Ensure that some fields should be disabled for the trigger in edit mode. Fixes #4639
...
Fixed illegal argument issue in the trigger for EPAS servers. Fixes #5799
2020-10-20 16:18:34 +05:30
Pradip Parkale
7b9504bdfb
Fixed an issue where the suffix for Toast table size is not visible in the Statistics tab. Fixes #5895
2020-10-20 15:57:32 +05:30
Pradip Parkale
1bb510cdd4
Fixed following issues in the function module:
...
1) The volatility option is not reflecting. It stays volatile always when creating the function.
2) Set "Returns as set" to true and enter estimated rows like 12. Now set returns as set to false and save.
It gives ERROR: ROWS is not applicable when the function does not return a set.
Need to clear estimated rows when returns as set is false.
3) If estimated rows are added and support function is selected then SQL looks ugly.
Fixes #5843
2020-10-12 14:01:04 +05:30
Akshay Joshi
556278dbc5
Added support to view trigger function under the respective trigger node. Fixes #2519
2020-10-12 13:49:54 +05:30
Akshay Joshi
f27527a614
Fixed API test cases failed for PG 9.5 due to change in the order of ACL.
2020-10-07 08:41:21 +05:30
Pradip Parkale
82e912ffad
Fixed 'can't execute an empty query' message if the user change the option of Auto FK Index. Fixes #5835
2020-10-06 17:20:43 +05:30
Akshay Joshi
6c4049f29a
Added RESQL/MSQL test cases for Functions. Fixes #5395
...
Initial patch sent by Nikhil Mohite.
2020-10-06 17:13:41 +05:30
Akshay Joshi
9466278be2
Fixed invalid literal issue when fetching dependencies for Materialized View. Fixed #5882
2020-10-05 17:53:47 +05:30
Pradip Parkale
e4029cca04
Ensure that the user should be able to change the start value of the existing sequence. Fixes #5855
2020-10-05 16:38:16 +05:30
Akshay Joshi
542be2b2d4
Fixed issues where the 'pg_pltemplate' system catalog is removed from PG 13 and it gives error while creating the language.
2020-10-05 14:35:48 +05:30
Pradip Parkale
9a77d4dc1a
Allow users to modify the option settings of the procedure.
...
refs #5843
2020-10-05 09:02:27 +05:30
Nikhil Mohite
be7bb81a19
Allow user to change the database connection from an open query tool tab. Fixes #3794
2020-10-01 13:29:46 +05:30
Pradip Parkale
656e239e55
Fixed API test cases introduce in the commit for #5867 .
...
refs #5867
2020-10-01 13:29:46 +05:30
Pradip Parkale
b097cec45e
Fixed an issue where some properties are not being updated correctly for the shared server. Fixes #5867
2020-09-30 12:29:59 +05:30
Akshay Joshi
1c70a43b91
Fixed code smells 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-09-29 15:08:14 +05:30
Aditya Toshniwal
3e7cdcdf90
Ensure that 'ctrl + a' shortcut does not move the cursor in SQL editor. Fixes #5131
2020-09-29 10:56:57 +05:30
Akshay Joshi
952197f130
Added support to ignore the owner while comparing objects in the Schema Diff tool. Fixes #5200 .
2020-09-28 15:22:46 +05:30
Akshay Joshi
68588fbb44
Fixed an issue where schema diff is showing identical table as different due to default vacuum settings. Fixes #5826
2020-09-24 13:24:25 +05:30
Pradip Parkale
c1d04747a1
Ensure that the 'Remove Server' option should be visible in the context menu. Fixes #5861
2020-09-24 10:58:30 +05:30
Pradip Parkale
f8611416ec
Added the 'PARALLEL UNSAFE' option to the missing SQL files.
...
refs #5843
2020-09-24 10:47:42 +05:30
Pradip Parkale
2e55b1f660
Fixed an issue where the 'PARALLEL UNSAFE' option is missing from reverse engineering SQL of function/procedure node. Fixes #5843 .
2020-09-23 13:21:50 +05:30
Nikhil Mohite
43d97b0e6f
Improve code coverage and API test cases for Functions. Fixes #5330
2020-09-22 14:43:46 +05:30
Pradip Parkale
458036ad6b
Fixed an issue where the server is not able to connect using the service. Fixes #5841
2020-09-22 13:14:40 +05:30
Ganesh Jaybhay
b0475566ca
Fixed reverse engineering SQL where parenthesis is not properly arranged for View/MView definition. Fixes #5830
2020-09-21 11:05:56 +05:30
Akshay Joshi
3489f94ca7
Ensure that multiple extensions can be dropped from the properties tab. Fixes #5839 .
2020-09-21 10:09:41 +05:30
Aditya Toshniwal
553be14000
Fixed an issue where a column is renamed and then removed, then the drop SQL query takes the wrong column name. Fixes #5807 .
2020-09-21 09:40:45 +05:30
Aditya Toshniwal
a25e808e06
Remove maximum length on the password field in the server dialog. Fixes #5802
2020-09-17 20:21:00 +05:30
Aditya Toshniwal
95a5b1e459
Some more accessibility fixes.
...
refs #5732
2020-09-17 20:16:38 +05:30
Akshay Joshi
55b5080c77
Fixed and improve API test cases for the schema diff tool. Fixes #5417
2020-09-17 20:10:01 +05:30
Pradip Parkale
593d86d3f2
Ensure that the 'Remove Server Group' option is available in the context menu. Fixes #5834
2020-09-15 13:19:00 +05:30
Akshay Joshi
324e3e74be
Fixed an issue where custom sequences are not visible when show system objects are set to false. Fixes #5833
2020-09-15 12:58:43 +05:30
Akshay Joshi
5eb1c57320
1) Correct the reverse engineering SQL of the collation node for database server version < 10.
...
2) Added 'rngcollation' and 'attnum' in the ignore list of Types node and fixed an issue occurs due to SonarQube fix.
2020-09-14 16:12:20 +05:30
Akshay Joshi
a7d40e238e
Ensure that the 'CREATE SCHEMA' statement should be present in the generated script if the schema is not present in the target database. Fixes #5816
2020-09-11 19:06:56 +05:30
Akshay Joshi
1bd0a0edf5
Remove illegal argument from trigger function in trigger DDL statement. Fixes #5779
2020-09-10 17:27:01 +05:30
Akshay Joshi
1bc1ef7f17
Fixed an issue where vacuum options not consider in Schema Diff. It's a regression.
2020-09-09 15:34:50 +05:30
Akshay Joshi
ffb829e80c
Fixed an issue while refreshing Resource Group. Fixes #5820
2020-09-09 14:34:14 +05:30
Pradip Parkale
98e86a8160
Fixed an issue where the server icon getting change to the shared server icon in desktop mode.
...
refs #4979
2020-09-08 10:09:16 +05:30
Pradip Parkale
9e5487d5ad
Fixed SQL for Row Level Security which is incorrectly generated. Fixes #5764
2020-09-07 18:40:49 +05:30
Pradip Parkale
4da4a05611
Fixed code smell 'Remove duplicates string literals'.
2020-09-07 17:56:02 +05:30
Akshay Joshi
eaa90ee8eb
Fixed primary key/unique constraint icon issue.
2020-09-03 18:53:40 +05:30
Khushboo Vashi
31bbdd6a12
Fixed code smell 'String literals should not be duplicated'.
2020-09-03 18:35:58 +05:30
Akshay Joshi
a67f6e4f9c
Fixed API test cases failed due to commit for #4979 .
2020-09-03 14:20:45 +05:30
Pradip Parkale
b562ab7681
Added shared server support for admin users. Fixes #4979
2020-09-03 12:59:28 +05:30
Yogesh Mahajan
3e35dc95e5
Improve code coverage and API test cases for Tables. Fixes #5774 .
2020-09-03 12:35:56 +05:30
Aditya Toshniwal
8f3bdf1cf3
Fixed cognitive complexity issues reported by SonarQube.
2020-09-02 14:39:54 +05:30
Ganesh Jaybhay
fd0ed81f7f
Fixed accessibility issues for main panels.
2020-09-01 12:58:23 +05:30
Cyril Jouve
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
Aditya Toshniwal
11d5613866
Fixed RESQL test cases for Roles module.
2020-08-28 18:22:25 +05:30
Yogesh Mahajan
3984544bdb
Fixed code smell 'String literals should not be duplicated'.
2020-08-28 18:17:27 +05:30
Yogesh Mahajan
e226b2fa75
Adjusted the height of jobstep code block to use maximum space. Fixes #5426 .
2020-08-28 14:00:49 +05:30
Aditya Toshniwal
28b637c99c
Fixed RE-SQL test cases failed due to the previous commit.
...
Introduces a new key - replace_regex_pattern to synchronize the
expected SQL with the backend SQL based on the regex string
2020-08-27 19:08:00 +05:30
Aditya Toshniwal
53a5410337
Fixed cognitive complexity issues and added some more RESQL test cases for roles module.
2020-08-27 13:09:22 +05:30
Yogesh Mahajan
f3bde7b5f1
Ensure that schema names starting with 'pg' should be visible in browser tree when standard_conforming_strings is set to off. Fixes #4216
2020-08-26 18:16:16 +05:30
Yogesh Mahajan
8fcf527632
Improve code coverage and API test cases for Columns and Constraints (Index, Foreign Key, Check, Exclusion). Fixes #5332
2020-08-26 12:35:22 +05:30
Dave Page
4eb17afe4e
Warn the user when connecting to a server that is older than pgAdmin supports. Fixes #5772
2020-08-25 17:18:43 +01:00
Nikhil Mohite
d2577e32e6
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 18:13:01 +05:30
Akshay Joshi
e2ac6187dc
Fixed Jenkins build failure due to API test case failed.
2020-08-25 14:14:48 +05:30
Akshay Joshi
df9aaf19c2
Fixed string indices must be integers issue for PostgreSQL < 9.3. Fixes #5766
2020-08-25 13:38:24 +05:30
Aditya Toshniwal
275c671576
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:39:14 +05:30
Pradip Parkale
86bbc3a9e8
Ensure that the user should be able to drop the database even if it is connected. Fixes #5722
2020-08-25 12:37:50 +05:30
Nikhil Mohite
b3d49c61a5
Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748
2020-08-25 12:31:58 +05:30
Pradip Parkale
7f947f146c
Fixed cognitive complexity issues reported by SonarQube.
2020-08-25 12:28:55 +05:30
Akshay Joshi
52d0241a17
Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. Fixes #5754
2020-08-24 12:11:09 +05:30
Neel Patel
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
Nikhil Mohite
19491d79a5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-21 13:52:05 +05:30
Akshay Joshi
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
Rahul Shirsat
7f3e8596e3
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 18:34:49 +05:30
Akshay Joshi
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
Khushboo Vashi
cc5a7ea334
Fixed code smell 'String literals should not be duplicated'.
...
Create a constant.py file which contains the common Constants.
2020-08-19 14:16:02 +05:30
Nikhil Mohite
4b56962c1b
Fixed cognitive complexity issues reported by SonarQube.
2020-08-19 13:41:53 +05:30
Akshay Joshi
8f61944386
1) Added special handling for the extension to resolve the dependency.
...
2) Added 'is_sys_obj' to the ignore list of Schema Diff.
3) Font awesome v5 fixes.
2020-08-13 17:48:04 +05:30
Akshay Joshi
63df19ee1c
Fixed following schema diff issues:
...
1) Avoid template databases from the Database drop-down list.
2) Exclude system schemas while comparing two databases.
3) Escape group name for XSS.
2020-08-13 14:12:37 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Cyril Jouve
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
Aditya Toshniwal
7dd313f5fc
Fixed an issue where debugger doesn't work if the search path is set other than 'public'. Fixes #4123
2020-08-12 14:24:40 +05:30
Aditya Toshniwal
8129df42da
Fixed cognitive complexity issues reported by SonarQube.
2020-08-11 15:13:35 +05:30
Akshay Joshi
082b968bbc
Fixed following schema diff issues:
...
1) Wrong SQL generated for the columns having different data type.
2) Added 'castfunc' in the ignore list.
2020-08-11 14:42:32 +05:30
Rahul Shirsat
2907a79dd7
Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791
2020-08-11 11:30:47 +05:30
Akshay Joshi
46af290b85
Fixed API test cases for packages.
2020-08-10 18:13:00 +05:30
Nikhil Mohite
9d006d0ec5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-10 16:30:07 +05:30
Cyril Jouve
7a0bfecfc5
Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses.
2020-08-10 15:57:25 +05:30
Rahul Shirsat
604937cf66
Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664
2020-08-10 15:27:57 +05:30
Akshay Joshi
4f74609ecf
Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126
2020-08-10 15:13:34 +05:30
Yogesh Mahajan
3672013ddc
Fixed an issue where the error message does not have a close button on utility dialogs. Fixes #5670
2020-08-07 17:17:51 +05:30
Nikhil Mohite
9ad7476a34
Corrected DROP SQL syntax for catalog. Fixes #5713
2020-08-07 16:58:38 +05:30
Akshay Joshi
518b13c779
Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689
2020-08-07 16:30:03 +05:30
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Nikhil Mohite
1122e06f48
Fixed cognitive complexity issues reported by SonarQube.
2020-08-06 12:38:35 +05:30
Nikhil Mohite
6a406f466d
Fixed cognitive complexity issues reported by SonarQube.
2020-08-05 13:00:44 +05:30
Aditya Toshniwal
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
Akshay Joshi
5ce2773658
Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429
2020-08-04 15:48:20 +05:30
Akshay Joshi
87d08de3a0
Corrected the syntax as per jinja standards. refs #5632
2020-08-03 13:08:29 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Satish V
318d712c4f
Improve code coverage and API test cases for Schemas. Fixes #5327
2020-08-03 12:38:38 +05:30
Aditya Toshniwal
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
Akshay Joshi
dd7eb54e90
Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710
2020-07-30 13:57:00 +05:30
Nikhil Mohite
89fa85d650
Fixed cognitive complexity issues reported by SonarQube.
2020-07-29 18:29:04 +05:30
Rahul Shirsat
74fd5dfe96
Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632
2020-07-29 16:22:11 +05:30
Satish V
287a6628ed
Improve code coverage and API test cases for Types. Fixes #5336
2020-07-29 15:41:04 +05:30
Aditya Toshniwal
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
Akshay Joshi
ed0dc62b69
Fixed incorrect import statement for urlopen.
...
refs #5700
2020-07-27 17:33:44 +05:30
Akshay Joshi
fb0bc65ced
Fixed following SonarQube issues:
...
1) Define a constant instead of duplicating this literal.
2) Reduce cognitive complexity (Patch by Aditya)
2020-07-27 16:31:03 +05:30
Cyril Jouve
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
Akshay Joshi
7a22cff28c
Fixed 'cannot unpack non-iterable Response object' issue.
2020-07-24 14:59:50 +05:30
Satish V
4cf8c2f300
Improve code coverage and API test cases for Foreign Servers and User Mappings. Fixes #5324
2020-07-24 14:14:13 +05:30
Rahul Shirsat
937877e841
Ensure that RLS Policy node should be searchable using search object. Fixes #5646
2020-07-24 13:47:39 +05:30
Yogesh Mahajan
dd27e08a98
Fixed code smell 'Unused local variables should be removed'.
2020-07-24 12:15:29 +05:30
Nikhil Mohite
1fbf298d30
Fixed cognitive complexity issues reported by SonarQube.
2020-07-24 12:03:05 +05:30
Aditya Toshniwal
505a3ac960
1) Fixed cognitive complexity issues reported by SonarQube.
...
2) Fixed code smell 'Add a nested comment explaining why this method is
empty, or complete the implementation'.
2020-07-24 11:46:30 +05:30
Pradip Parkale
28a4359020
Fixed issue where the user was not able to update policy if the policy is created with space. Fixes #5686
2020-07-21 18:14:49 +05:30
Akshay Joshi
f177d54f21
Fixed AttributeError while creating the server group. Fixes #5688
2020-07-21 18:02:51 +05:30
Khushboo Vashi
645517d22d
Added support for LDAP anonymous binding. Fixes #5650
2020-07-20 15:30:06 +05:30
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Nikhil Mohite
4e2c4b0498
Fixed cognitive complexity issues reported by SonarQube.
2020-07-17 15:31:04 +05:30
Satish V
64cdd509b0
Fixed save button enable issue when focusing in and out of numeric input field. Fixes #5137
2020-07-17 15:31:04 +05:30
Akshay Joshi
703faf3b15
Fixed following SoanrQube issues
...
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
2) Define a constant instead of duplicating this literal.
Solution:
1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
2) Declare the constant in PGChildNodeView for SQL files.
2020-07-16 19:39:55 +05:30
Akshay Joshi
5d8c79da38
Added docstrings for some newly created functions.
2020-07-15 18:07:54 +05:30
Akshay Joshi
11c4877859
Fixed an issue where difference DDL is showing the wrong SQL when changing the policy owner. Fixes #5647
2020-07-15 14:52:14 +05:30
Rahul Shirsat
d6893f9d8a
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569 .
2020-07-14 19:16:33 +05:30
Akshay Joshi
4f34bc0f0e
Added missing dependencies/dependent and corrected some wrongly identified. Fixes #5666
2020-07-14 18:34:50 +05:30
Satish V
a91e4d8a7f
Improve code coverage and API test cases for Foreign Data Wrapper. Fixes #5323 .
2020-07-14 15:58:22 +05:30
Aditya Toshniwal
161c9b0fc7
Fixed code smell 'Variables should not be shadowed'.
...
Fixed all the duplicate CSS blocks issues raised by SonarQube.
2020-07-14 15:45:01 +05:30
Nikhil Mohite
0013a3b047
Fixed cognitive complexity issues reported by SonarQube.
2020-07-14 15:33:54 +05:30
Akshay Joshi
d3eaac8609
Reverted fix for #5569 due to a couple of issues.
2020-07-11 20:32:57 +05:30
Rahul Shirsat
29175d7ec4
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569
2020-07-11 16:23:31 +05:30
Rahul Shirsat
e8b81db977
Fixed cognitive complexity issues reported by SonarQube.
2020-07-10 11:44:33 +05:30
Nikhil Mohite
7420673a0f
Improve code coverage and API test cases for FTS Configuration, FTS Parser, FTS Dictionaries, and FTS Template. Fixes #5329 .
2020-07-10 11:40:08 +05:30
Nikhil Mohite
e1168f8de0
Fixed code smell to reduce cognitive complexity.
2020-07-09 18:41:13 +05:30
Pradip Parkale
916182f80f
Fixed code smell for variable naming convention.
2020-07-09 18:28:08 +05:30
Murtuza Zabuawala
2db9242f5c
Fixed accessibility issue where few dialogs are not rendering properly
...
when we zoomed in browser window 200% and screen resolution is low.
Fixes #5662
2020-07-09 18:18:37 +05:30
Pradip Parkale
c58fda0a70
Ensure that create RLS Policy menu should not be visible for catalog objects. Fixes #5633
2020-07-09 18:04:32 +05:30
Akshay Joshi
b4c25bdc0a
Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube.
2020-07-07 19:39:06 +05:30
Pradip Parkale
36a2c073bd
Added support for permissive/restricted policy type while creating RLS Policy. Fixes #5622
2020-07-07 17:55:05 +05:30
Nikhil Mohite
aee6bac5ef
Fixed cognitive complexity code smell reported by SonarQube.
2020-07-07 15:19:47 +05:30
Khushboo Vashi
58b4c45d0c
Added support for LDAP authentication with different DN by setting the dedicated user for the LDAP connection. Fixes #5484
2020-07-06 19:35:55 +05:30
Aditya Toshniwal
45a03dd663
Fixed 'convention' related code smell reported by SonarQube.
2020-07-06 11:48:23 +05:30
Murtuza Zabuawala
cb1cdd1b23
Modified EPAS templates to support schema restriction.
2020-07-03 18:42:17 +05:30
Akshay Joshi
0d92059155
Fixed code smells having rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 18:37:37 +05:30
Yogesh Mahajan
80ab596992
Fixed the SoanrQube code smell 'Variables should not be shadowed'.
2020-07-03 14:33:30 +05:30
Khushboo Vashi
b5f0190799
Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'.
2020-07-03 14:24:54 +05:30
Aditya Toshniwal
341c3aded6
Fixed dark theme-related CSS and modify the color codes. Fixes #5287
...
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
2020-07-03 11:47:40 +05:30
Aditya Toshniwal
dd4dc19add
Fixed issue where dialog sizes snapping to the default widths.
2020-07-03 11:26:06 +05:30
Nikhil Mohite
1ab257d512
Fixed Cognitive Complexity code smell reproted by SonarQube.
2020-07-03 11:15:41 +05:30
Aditya Toshniwal
ced296939f
Fixed an issue where the user is able to edit properties when some of the collection nodes are selected. Fixes #5629
2020-07-02 16:21:56 +05:30
Yogesh Mahajan
1802f8a3f8
Ensure that the referenced table should be displayed on foreign key constraints. Fixes #5530
2020-07-02 16:21:56 +05:30
Pradip Parkale
8b10315e2a
Added hints for 'Using' and 'With check' options of RLS Policy node.
2020-07-02 16:21:56 +05:30
Akshay Joshi
0850db2a9b
Fixed database connection issue, regression of SonarQube fixes.
2020-07-01 17:32:22 +05:30
Akshay Joshi
a881e4e3f8
Fix PEP8
2020-07-01 15:33:51 +05:30
Nikhil Mohite
192a446131
Fixed API test cases failing due to updating the server manager instance.
2020-07-01 15:29:59 +05:30
Pradip Parkale
b30c590866
Fixed SonarQube code smell 'Rename function and variable name to match the regular expression'.
2020-07-01 13:50:51 +05:30
Yogesh Mahajan
6dd3ca31be
Fixed SonarQube code smell 'Variables should not be shadowed'.
2020-07-01 13:43:00 +05:30
Pradip Parkale
979f806161
1) Added RLS Policy support in Schema Diff. Fixes #5601
...
2) Fixed 'cant execute empty query' issue when remove the value of
'USING' or 'WITH CHECK' option of RLS Policy. Fixes #5631
2020-07-01 12:44:28 +05:30
Ashesh Vashi
3102a8d24b
Fix the dialog size when zoom level is changed of the browser.
...
The screen.width & screen.height does not reflect the values of the
height and width respectively when zoom level is changed for the
browser. It is better to review the calculated height and width based
on the window.innerHeight and window.innerWidth and re-evaluate them.
2020-07-01 11:49:43 +05:30
Ashesh Vashi
21d57b1f10
Do not let browser autocomplete the password field while connecting a
...
database server.
Set the autocomplete attribute of the password field to 'new-password'
to let browser know, we require a new password for the password, and do
not autocomplete it.
2020-07-01 11:26:52 +05:30
Nikhil Mohite
c873218c32
Added support for schema level restriction. Fixes #5583
...
Allow user to edit the connection properties when the database server
is already connected.
2020-06-30 19:15:23 +05:30
Nikhil Mohite
6713bc068b
Fixed SonarQube code smells 'Refactor this function to reduce its Cognitive Complexity'.
2020-06-30 17:06:55 +05:30
Akshay Joshi
46d26cd029
Remove extra brackets from reverse engineering SQL of RLS Policy. Fixes #5621
2020-06-30 16:11:02 +05:30
Zhang Jie
88db5ec4d5
Remove extra brackets from reverse engineering SQL of trigger.
2020-06-30 16:07:55 +05:30
Rahul Shirsat
7add777b21
Add proper indentation to the code while generating functions, procedures, and trigger functions. Fixes #3851
2020-06-29 12:36:28 +05:30
Akshay Joshi
b91f6f0f5c
Fixed an issue where the semicolon is misplaced in RLS Policy SQL.
...
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
2020-06-26 19:24:54 +05:30
Nikhil Mohite
115657a465
Fixed following SonarQube issues:
...
1) Refactor function to reduce its Cognitive Complexity.
2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$.
2020-06-26 15:03:50 +05:30
Satish V
8e28e0a32b
Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326
2020-06-26 14:15:09 +05:30
Khushboo Vashi
c7a16a4bd5
Fixed code smells having rule 'Nested blocks of code should not be left empty'.
2020-06-26 13:18:27 +05:30
Yogesh Mahajan
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
Diego Augusto Molina
6a63279396
Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions.
2020-06-26 12:28:36 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce
Fixed issue related to extra semicolons and function naming convention reported by SonarQube.
2020-06-24 16:16:12 +05:30
Nikhil Mohite
db9d684524
Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube.
2020-06-24 16:08:14 +05:30
Akshay Joshi
d265ed9729
Fixed an issue while creating RLS Policy with the name having space. Fixes #5620
2020-06-23 14:28:21 +05:30
Murtuza Zabuawala
c064eb0795
Fix an issue where RLS Policy dialog help is not working.
2020-06-23 14:13:08 +05:30
Pradip Parkale
6012f49919
Added policy event 'ALL' in events drop-down list.
2020-06-22 17:09:10 +05:30
Satish V
daad16ea93
Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube.
2020-06-22 12:58:48 +05:30
Aditya Toshniwal
6620f9263d
Fixed issues reported by SonarQube with tag 'bad-practice'.
2020-06-22 12:18:59 +05:30
Yogesh Mahajan
6d3f13076f
Fixed 'Comma operator should not be used' issue reported by SonarQube.
2020-06-18 16:17:55 +05:30
Satish V
905be1d894
Replace if-then-else statement by a single return statement, issue reported by SonarQube.
2020-06-18 15:51:01 +05:30
Aditya Toshniwal
a278e8b1e6
Fixed the master password issue, introduced in the last commit.
2020-06-18 15:38:38 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Akshay Joshi
5ed1e1e5b6
Fixed some sonarqube issues.
2020-06-17 19:30:56 +05:30
Aditya Toshniwal
df05efd7d9
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation.
2020-06-17 17:15:09 +05:30
Yogesh Mahajan
7c12ade161
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-17 17:08:23 +05:30
Akshay Joshi
cb268075c2
1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468
...
2) Added server group name while selecting servers in schema diff. Fixes #5500
3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584
2020-06-17 16:27:51 +05:30
Satish V
d43518cb3c
Fixed following issues reported by SonarQube:
...
1) Replace this if-then-else statement by a single return statement. (clumsy)
2) 'switch' statements should have at least 3 'case' clauses. (bad practice)
2020-06-16 15:00:51 +05:30
Aditya Toshniwal
3e00fe2b0f
Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube
2020-06-16 11:14:57 +05:30
Yogesh Mahajan
2ae5c0ec4f
Fixed an issue where select all checkbox only selects the first 50 tables. Fixes #4226
2020-06-16 11:05:10 +05:30
Yogesh Mahajan
697f4aec95
Fixed issue related to shadowing variables reported by SonarQube.
2020-06-16 10:47:40 +05:30
Akshay Joshi
a21e6448ce
Fixed RESQL test cases, regression of RLS policy.
2020-06-15 17:10:25 +05:30
Satish V
eb1b17b636
Fix 'expressions evaluated to true/false always' issue reported by SonarQube.
2020-06-15 16:50:07 +05:30
Mishika Singh
38cd3327f3
Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592
2020-06-15 16:50:07 +05:30
Khushboo Vashi
8ab358ccec
Fix following issues reported by SonarQube:
...
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
2020-06-15 16:50:07 +05:30
Aditya Toshniwal
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
Pradip Parkale
18277543b6
Added support of Row Security Policies. Fixes #5516
2020-06-15 15:44:59 +05:30
Aditya Toshniwal
8c20f0c0d2
Some clumsy coding related fixes reported by SonarQube.
2020-06-12 15:24:17 +05:30
Satish V
ee1ea47e88
Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube.
2020-06-12 15:15:07 +05:30
Satish V
82c4a4a03e
Improve code coverage and API test cases for Collations. Fixes #5325
2020-06-11 11:12:41 +05:30
Dave Page
21efe6f902
Remove blank line at EOF.
2020-06-10 17:03:08 +01:00
Dave Page
5c60dcd501
Remove blank line at EOF.
2020-06-10 17:02:39 +01:00
Dave Page
85e89c869a
Cleanup some code smells identified by SonarQube.
2020-06-10 16:42:59 +01:00
Aditya Toshniwal
eb971a0320
Update Codemirror version to the latest which allows us to set screen reader labels on Codemirror editor.
...
refs #5197
2020-06-08 12:26:12 +05:30
Satish V
726ecd79e6
Fixed import statements.
...
refs #3669
2020-06-03 12:49:05 +05:30
Satish V
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
Yogesh Mahajan
4632a7faba
Fixed an issue where pgadmin detects the wrong browser version of the Microsoft Edge. Fixes #5465
2020-05-29 13:07:02 +05:30
Akshay Joshi
9b8902dfb8
Fixed the SQL help issue for EDB Postgres Advanced Server. Fixes #4099
2020-05-22 14:11:58 +05:30
Yogesh Jain
7b1cac6914
Fixed an issue where clicking on Select All button, not selecting all the options in pgAgent job scheduler. Fixes #5496
2020-05-19 13:54:21 +05:30
Yogesh Mahajan
9f445dc052
Improve code coverage and API test cases for Indexes. Fixes #5333
2020-05-18 12:29:33 +05:30
Pradip Parkale
6d6cd19b37
Improve code coverage and API test cases for Triggers and Compound Triggers. Fixes #5335
2020-05-15 12:50:50 +05:30
Khushboo Vashi
a9a1a975a6
Added compatibility for Flask-Security-Too version 3.2
2020-05-13 16:02:38 +05:30
Akshay Joshi
073d90c4a6
Fixed internal server error when clicking on Triggers -> 'Enable All' for partitions. Fixes #5052
2020-05-11 15:18:39 +05:30
Yogesh Mahajan
1294c089a8
Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255
2020-05-11 12:11:31 +05:30
Aditya Toshniwal
b64896f558
Fixed generated SQL issue for auto vacuum options. Fixes #5398
...
Fixed some more issues:
1) pgAdmin allows only true or false values for autovacuum_enabled,
and there is no way to reset it individually without disabling a custom auto vacuum.
To fix this, the control is changed from the switch to three state buttons.
2) Setting any vacuum options to zero made the option disappear from the SQL.
3) Right-click on a table with vacuum options set and create a new table.
4) The parameters tab will have the options prefilled.
5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.
The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".
2020-05-08 14:30:30 +05:30
Ashesh Vashi
e73e2d2502
Fixed the errors, and warnings reported by pylama.
...
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
2020-05-08 14:13:38 +05:30
Satish V
9338bdcb3a
Fixed an issue where the newly added table is not alphabetically added to the tree. Fixes #5434
...
Fixed an issue when renaming the column not added in the proper order. Fixes #5450
2020-05-08 12:52:03 +05:30
Pradip Parkale
057a2b2312
Improve code coverage and API test cases for the Rules module. Fixes #5334
2020-05-07 16:27:58 +05:30
Akshay Joshi
6ad46e1860
Fixed invalid literal issue when removing the connection limit for the existing role. Fixes #5001
2020-05-07 13:14:45 +05:30
Akshay Joshi
a0940fd145
Typecast the object to 'text' before using it in length() function, so that correct length function gets called.
2020-05-06 17:34:18 +05:30
Ganesh Jaybhay
5fe7813f9f
Fixed an issue where select2 hover is inconsistent for the SSL field in create server dialog. Fixes #5469
2020-05-04 13:19:13 +05:30
Satish V
d61b8eb1b3
Gracefully informed the user that the database is already connected when they click on 'Connect Database...'. Fixes #3694
2020-05-04 13:08:56 +05:30
Murtuza Zabuawala
0fc2afb829
Add Reverse Engineered and Modified SQL tests for Column and Type.
2020-05-04 12:48:24 +05:30
Khushboo Vashi
5656f756e6
Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422
2020-05-04 12:23:18 +05:30
Akshay Joshi
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
Dave Page
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
Khushboo Vashi
88aebb64f9
Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447
...
It's a regression of #5213
2020-04-28 11:00:23 +05:30
Pradip Parkale
18748846ef
Fixed the regression where initial changes make the Save button enabled when the table dialog is opened. Fixes #4504
2020-04-27 18:48:44 +05:30
Satish V
b80784f5a1
Fixed an issue where the user should not be able to add columns in the creation order after 50 columns.
...
Regression of the initial patch.
Fixes #5043
2020-04-27 18:01:09 +05:30
Murtuza Zabuawala
76eb3e9b67
Fixed an issue when the user performs refresh on a large size materialized view. Fixes #5213
2020-04-27 17:30:23 +05:30
Pradip Parkale
ef58d277ca
Fixed an issue where like options should be disabled if the relation is not selected while creating a table. Fixes #4504
2020-04-24 18:22:11 +05:30
Aditya Toshniwal
aec64aa582
Fixed following issues for 1257:
...
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".
Fixes #1257
2020-04-24 16:35:59 +05:30
Aditya Toshniwal
90849fe29b
Fixed mouse click issue where it does not select an object in Browser unless the pointer is over the object. Fixes #4180
2020-04-24 11:32:11 +05:30
Aditya Toshniwal
dfb74904ed
Ensure all object types have a System XXX? property. Fixes #1257
2020-04-23 17:31:40 +05:30
Akshay Joshi
2b5c90e379
A warning message will be displayed only when the package header is changed for EPAS packages. Fixes #5410
2020-04-23 17:14:01 +05:30
Satish V
2e29f3fd6d
Fixed an issue where columns names should be visible in the order of their creation in the browser tree. Fixes #5043
2020-04-23 16:42:42 +05:30
Ashesh Vashi
637c80c38b
Recreate the node item in the tree, when 'id' has been changed of the node.
...
Fixes #5053
2020-04-23 11:11:15 +05:30
Khushboo Vashi
6e5dbf7beb
Added multiple drop/delete functionality for the table constraints. Fixes #3900
2020-04-22 18:47:13 +05:30
Ashesh Vashi
858294f36e
Fixed validation errors in view/materialized view javascript to
...
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.
Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.
Fixes #5053
2020-04-22 17:19:18 +05:30
Akshay Joshi
4c616f32eb
1) Fixed feature test and API test cases.
...
2) Added logic to exclude RESQL test cases.
2020-04-22 13:57:32 +05:30
Neel Patel
07f72252d7
Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636
...
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
2020-04-21 17:00:21 +05:30
Akshay Joshi
f289dfb762
Fixed following issues for packages:
...
1) Removing the package header removes the body as well.
2) Schema is not visible on the properties dialog.
3) Reverse engineering SQL and Create script not showing schema-qualified packages.
Fixes #5410
2020-04-21 16:49:23 +05:30
Aditya Toshniwal
05abb9e430
Ensure that the query tool context menu should work on the collection nodes. Fixes #5415
2020-04-20 18:50:20 +05:30
Akshay Joshi
4692b21bcf
Fixed an issue where schema diff marks an identical table as different. Fixes #5350
...
Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315
Ignore the keys from the source and target list and also sort both the lists.
2020-04-20 18:04:16 +05:30
Libor M
36a3d4e53b
Some more gettext() usage fixes:
...
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts
2020-04-20 11:19:09 +05:30
Akshay Joshi
d8ad0b8faf
Fixed validation issue in Synonyms node. Fixes #5409
2020-04-17 14:50:38 +05:30
Akshay Joshi
c6deb9393c
Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410
2020-04-17 13:06:07 +05:30
Aditya Toshniwal
dc1e32a632
Fixed internal server error when the database server is logged in with non-super user. Fixes #5400
2020-04-16 15:05:17 +05:30
Murtuza Zabuawala
eec2cfd5dd
Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. Fixes #5375
2020-04-16 13:16:07 +05:30
Shubham Agarwal
d6cab7b421
Ensure the DROP statements in reverse engineered SQL are properly quoted for all objects. Fixes #4440
2020-04-16 13:06:50 +05:30
Libor M
8254e9f030
Some minor gettext and format fixes.
2020-04-16 12:55:19 +05:30
Ganesh Jaybhay
7493649893
Added schema-qualified dictionary names in FTS configuration to avoid confusion of duplicate names. Fixes #4709
2020-04-16 12:47:00 +05:30
Khushboo Vashi
738c421edf
Ensure that Constraint Trigger, Deferrable, Deferred option should be disabled when the user selects EDB-SPL function for the trigger. Fixes #4957
2020-04-16 12:38:20 +05:30
Aditya Toshniwal
31a929388b
Make changes to use gettext() function correctly.
2020-04-15 16:23:17 +05:30
Aditya Toshniwal
0424f7d962
Fixed following issues for Procedures:
...
1) Change comments on the procedure with arguments as a procedure can be overloaded.
Note that on EPAS servers, procedure overloading works only for v11+.
2) The save button of a procedure dialog is enabled without any change.
3) Fixed formatting of the reverse-engineered SQL.
4) On EPAS servers, the parameters set were not displayed in the SQL generated.
They are visible only if set to edbsql.
5) Changing the volatility option of any existing procedure was not working.
6) Changing the parallel option (EPAS v9.6+) was not working.
7) Added RE-SQL test cases for procedures.
Fixes #4620 , Fixes #4873
2020-04-15 13:54:17 +05:30
Shubham Agarwal
8654d6cf43
Fixed an issue where the mode is not shown in the properties dialog of functions/procedures if all the arguments are IN arguments. Fixes #5387
2020-04-15 12:33:54 +05:30
Dave Page
74b3495542
Warn the user if an unsupported, deprecated or unknown browser is detected. Fixes #5399
2020-04-14 21:15:02 +05:30
Ashesh Vashi
3a4641889c
Using 'is_valid_ipaddress' utility function everywhere
2020-04-14 18:51:48 +05:30
Ashesh Vashi
6c5883bce0
We don't need to pass gettext for inline CSS transforation
2020-04-14 18:43:04 +05:30
Ashesh Vashi
d226ffbd1f
[Foreign Key] Removed 1 unexpected arguments; 'get_node_list' expects
...
5 positional arguments.
Also,
- Using 'gettext' instead of '_'.
- Using constant string for 'foreign_key not found' error message.
2020-04-14 18:40:15 +05:30
Ganesh Jaybhay
12530cd973
Ensure index dropdown should have existing indexes while creating unique constraints. Fixes #5007
2020-04-14 14:02:33 +05:30
Khushboo Vashi
a0fcb38e68
Fixed syntax error while refreshing the existing synonyms. Fixes #5383
2020-04-14 13:43:56 +05:30
Pradip Parkale
a05acb4f99
Fixed tab key navigation for some dialogs. Fixes #5371
2020-04-14 13:32:03 +05:30
Shubham Agarwal
41521a9b98
Ensure all object names in the title line of the reverse-engineered SQL are not quoted. Fixes #4445
2020-04-14 13:02:58 +05:30
Akshay Joshi
781b766ac4
Fixed an issue where difference SQL is not seen in the schema diff tool for Types. Fixes #5302
2020-04-13 20:24:12 +05:30
Akshay Joshi
df11f28593
Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. Fixes #5362
2020-04-13 18:06:20 +05:30
Khushboo Vashi
030741bba5
Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053
2020-04-13 16:00:01 +05:30
Murtuza Zabuawala
4de6b93ba8
Ensure that the password prompt should not be visible if the database server is in trust authentication mode. Fixes #2813
2020-04-10 17:03:04 +05:30
Nagesh Dhope
d9574f3caa
Fixes following OSX native keyboard shortcuts in Query Tool:
...
1) option+arrow (L/R) should skip by "word"
2) option+arrow (up/down) should go up/down one line
3) shift+option+arrow (L/R) should select/highlight by "word"
2020-04-10 15:21:56 +05:30
Libor M
6a9af07f7a
Fixed gettext usage:
...
- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in the dialog.
- improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
- added gettext for text translations.
2020-04-10 14:52:41 +05:30
Khushboo Vashi
e238ecf182
Ensure that OID should be shown in properties for Synonyms. Fixes #5270
2020-04-10 13:19:52 +05:30
Akshay Joshi
31f255b541
Added support of Foreign Tables to the Schema Diff. Fixes #5263
2020-04-09 21:03:28 +05:30
Akshay Joshi
fecf3915c5
Fixed API/RESQL test cases for View/MView failed due to #5053 commit.
2020-04-09 21:03:28 +05:30
Ashesh Vashi
8a550b569f
Fixed expected output status code, as 410 should be the status code
...
for the object (CAST) not exists in the database server.
2020-04-08 16:51:53 +05:30
Ashesh Vashi
1a34f61b24
Moved the ip-address check functionality to a separate file to improve
...
the maintainability of the code.
2020-04-08 16:50:14 +05:30
Ashesh Vashi
775e61c248
Fixed pep8 issue
2020-04-08 14:34:34 +05:30
Ashesh Vashi
d9f6baac72
Various misc fixes:
...
- Using the 'gettext' as oppose to '_', which is not defined
- Define missing variables
- Fixed escape character in string with double quote
- Removed some dead code in a test case
- Removed unnecessary self assignment
Includes some fixes for Accessibility improvements
- Use semantic markup to mark emphasized or special text
- Added hidden legend in <fieldset> for better screen reader support
2020-04-08 14:14:25 +05:30
Ashesh Vashi
8fe687eb55
[Rules] Removing unnecessary 'if' condition
2020-04-08 13:14:14 +05:30
Ashesh Vashi
6c693d158e
[Exclusion Constraint] Fixed an typo - it should have been assignment
2020-04-08 13:05:28 +05:30
Ashesh Vashi
6b3e1f1e65
[TABLES] Do not assign the paramter values, use separate variable for new value
2020-04-08 13:04:24 +05:30
Ashesh Vashi
8fe344c268
[EDB Package Functions] [Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:02:37 +05:30
Ashesh Vashi
c7afa30d0c
[Packages] Fixed a typo
2020-04-08 13:00:49 +05:30
Ashesh Vashi
14f21921bb
[Functions] Fixed typos:
...
- 'gettext' should be used as '_' is not defined
- Identical expressions should not be used on both sides of a binary operator.
2020-04-08 13:00:01 +05:30
Ashesh Vashi
29ae6dfbf6
[FTS Configuration] Fixed an typo - it should have been assignment
2020-04-08 12:56:51 +05:30
Ashesh Vashi
a6c03a6b75
[Domain] Existing expression will expression will always result into false
2020-04-08 12:54:37 +05:30
Ashesh Vashi
068b812245
[COLLATIONS] Do not assign the paramter values, use separate variable for new value
2020-04-08 12:53:48 +05:30
Ashesh Vashi
a84a62def8
Using the 'gettext' as oppose to '_', which is not defined in these
...
files.
2020-04-08 12:34:57 +05:30
Ashesh Vashi
7f0847b95d
Using the 'gettext' as oppose to '_', which is not defined in the file
2020-04-08 12:29:11 +05:30
Ashesh Vashi
073e310a5a
[Accessibility] Use semantic markup to mark emphasized or special text.
...
Reference: https://www.w3.org/TR/WCAG20-TECHS/H49.html
2020-04-08 12:27:18 +05:30
Khushboo Vashi
f4607885e1
Fixed an issue where changing the columns in the existing view throws an error. Fixes #5053
...
PostgreSQL doesn't allow to change the view columns. So the view should be dropped first
and then recreate it and also the user will get a warning first.
2020-04-08 11:29:03 +05:30
Pradip Parkale
33deacacee
Ensure that the grant wizard should be closed on pressing the ESC key. Fixes #4206
2020-04-07 13:48:56 +05:30
Aditya Toshniwal
e1f990190e
Added search object functionality. Fixes #2172
2020-04-06 17:33:07 +05:30
Khushboo Vashi
f77aa3284f
Added LDAP authentication support. Fixes #2186
2020-04-06 15:57:05 +05:30
Pradip Parkale
8ceeb39268
Fixed tab key navigation issue for parameters in table dialog. Fixes #5275
2020-04-06 13:13:21 +05:30
Akshay Joshi
99e4c3350f
Fixed RESQL test cases for Packages.
2020-04-03 19:15:40 +05:30
Vishal Sawale
99a72e529b
Fixed some accessibility issues:
...
1) Added missing search filter label in backgrid.
2) broken aria issue for objects menu.
2020-04-03 17:11:46 +05:30
Akshay Joshi
ce89ae3c1d
Added support of Packages, Sequences and Synonyms to the Schema Diff. Fixes #5264
2020-04-03 16:52:45 +05:30
Aditya Toshniwal
358c5d0a0f
Added support for parameter toast_tuple_target and parallel_workers of the table. Fixes #5181
...
Fixed an issue where the autovacuum_enabled parameter is added automatically in the RE-SQL
when the table has been created using the WITH clause. Fixes #5180
2020-04-01 18:19:55 +05:30
Aditya Toshniwal
88a1e03314
Fixed generated SQL when any token in FTS Configuration or any option in FTS Dictionary is changed. Fixes #5268
2020-04-01 15:03:30 +05:30
Pradip Parkale
13b65c9a6a
Fixed tab key navigation issue for Grant Wizard. Fixes #5241
...
1) Added entry for .scss to change the shadow of 'ajs-close' button.
2) allow the user to use the keyboard to update the Backgrid cell DateTime picker control.
2020-03-30 17:31:50 +05:30
Akshay Joshi
86e4a88201
Added 'oid-2' to the ignore list of schema diff for all supported nodes. Fixes #5297
2020-03-27 15:27:48 +05:30
Akshay Joshi
c002881f66
Added conkey and indkey to the ignore list for schema diff.
2020-03-27 14:41:18 +05:30
Akshay Joshi
94a76cc9e0
Added support of Domain, Domain Constraints and Types to the Schema Diff. Fixes #5262
2020-03-26 14:30:09 +05:30
Libor M
94864104e4
Added and fixed gettext usage for better translation coverage. Fixes #5284
...
1) Fixed usage gettext('') instead of _('') in javascript files.
2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
because "pybabel extract" not support extracting from this syntax.
2020-03-24 11:14:05 +05:30
Akshay Joshi
98492e7718
Modified RESQL test cases for Foreign Tables to fix the build failures.
2020-03-22 16:26:23 +05:30
Murtuza Zabuawala
a7ba446703
Fixed Unicode character issue causing error on Python2 environment. Fixes #5279
2020-03-20 15:17:45 +05:30
Pradip Parkale
96361656e4
Fixed some accessibility issues in the dialogs:
...
1) Aria-label additions at few missing places.
2) Label additions with 'sr-only' class where hidden labels required.
3) Converted label to span to solve accessibility error.
Fixes #4608
2020-03-19 16:08:51 +05:30
Akshay Joshi
4fe69e825e
Added support of Collation, FTS Configuration, FTS Dictionary, FTS Parser, and FTS Template to the Schema Diff. Fixes #5261
2020-03-19 13:54:25 +05:30
Akshay Joshi
44c0d76541
Improve logic to get the DDL statements as a part of the comparison. Fixes #5221
...
Fixed 23 issues related to schema diff.
2020-03-15 14:52:19 +05:30
Aditya Toshniwal
fd07e0c868
Fix syntax error when changing the event type for the existing rule. It is a regression of #5115 .
...
Fixes #5215
2020-02-24 18:11:31 +05:30
Aditya Toshniwal
9bad590e9e
Improvements in the UI for both default and dark themes. Fixes #5133
...
Improve the style of the highlighted code after query execution for Dark mode. Fixes #4996 .
Changed background pattern for geometry viewer to use #fff for all themes. Fixes #5077
Changed the color of selected and hovered item for Select2 dropdown, also tweak the appearance of the tags in multi-select boxes. Fixes #4955
Fixed Firefox monospaced issue by updating the font to the latest version. Fixes #5184
2020-02-24 14:11:00 +05:30
Aditya Toshniwal
a44f17a2fc
Fix an issue where command and statements were parsed incorrectly for Rules. Fixes #5115
...
Fixed issue where removing command or statements altogether was not generating modified SQL.
2020-02-24 12:11:19 +05:30
Aditya Toshniwal
915b09255c
Added Python 3.8 support. Fixes #5179
...
1) Upgraded passlib==1.7.1 to passlib==1.7.2
2) Replace unmaintained Flask-Security with maintained Flask-Security-Too package, which is also compatible with python 3.8
3) Other compatibility code changes.
2020-02-18 12:10:38 +05:30
Pradip Parkale
e9f16a29cf
Improve code coverage and API test cases for the Event Trigger module. Fixes #5088
2020-02-14 11:19:34 +05:30
Nagesh Dhope
b6173c9d7b
Added tab navigation on close buttons for all the panels and create/properties dialog.
...
Added tab navigation for scroll left and scroll right buttons on the main window.
Fixes #4601
2020-02-04 11:30:33 +05:30
Akshay Joshi
641701ca16
Added missing imports and remove unused imports from schema diff.
2020-02-03 15:30:57 +05:30
Khushboo Vashi
3b1c8abd2f
Fixed following issue of schema diff tool:
...
1. Comparison result of 2 exact identical Trigger Functions is different
2. EPAS 12: Table comparison with the compound trigger shown as different, but all SQL panels are blank
3. Compound trigger properties panel is not opening
4. The DDL difference of the table containing the foreign key is not accurate
5. The DDL difference of the view which refers the table from schema is not accurate
6. DDL comparison fails if we have procedure with plpgsql in source and edbsql in target
2020-01-31 21:28:08 +05:30
Pradip Parkale
210bbfdbe1
1) Added labels and titles after parsing and validating all the pgAdmin4 web pages for accessibility. Fixes #4770
...
2) Fixed an issue where Save Password control disappears after clicking on it while creating a server. Fixes #5116
2020-01-31 14:21:35 +05:30
Aditya Toshniwal
0da23b837d
Set input controls as read-only instead of disabled will allow tab navigation in the properties tab and also allow screen readers to read it. Fixes #4993
2020-01-31 12:37:44 +05:30
Akshay Joshi
02f9de5bdb
Improve wordings.
2020-01-28 18:36:42 +05:30
Khushboo Vashi
c418a9c9ca
Fixed following schema diff issues:
...
1) Version mismatch should be displayed if you select EPAS 11 as the source and EPAS 12 as the target.
2) We should handle schema diff if the user stops the server after compare.
3) The data type is not visible for column headers in the query tool/view data.
4) Difference SQL is shown, though source & target SQL are same.
5) Error is shown when the 'target only' table is selected & clicked on Generate Script.
6) Difference SQL generated on deleting primary constraints from source throwing error on running from query tool.
7) Copy button for Difference SQL does not work.
8) Incorrect SQL is generated when check constraint from the source table is dropped.
9) Difference SQL is NOT shown when 'Unique Constraint' is dropped from the source table.
10) In case of difference, no message displayed related to copied successfully or not.
11) create or replace trigger should be on the next line.
12) Comparison Result of exactly identical tables having foreign key constraints is shown as different.
13) The wrong SQL displayed in the difference tab for view and materialized view for the select statements.
14) Wrong SQL displayed for the procedure in the difference section.
15) If the user already opens the compare section of Schema diff tool and Disconnects the server then '<' not supported between instances of 'NoneType' and 'int' message displayed.
16) When 'check constraint' is added on the source table which has already unique constraint & identical target table is created, all SQL panels remain empty.
17) Difference SQL is NOT shown when after adding 'Foreign Key' constraint to existing source table.
18) Incorrect SQL is generated when the existing index on the source table is modified.
19) Wrong SQL displayed for function in difference section.
20) Additional space is added before & after in difference SQL generated on the addition of an index to the source table.
21) Difference SQL is NOT shown when tables have different permission/grants.
22) Incorrect SQL is shown when the source had inherited table & target has a normal table.
23) Exactly identical child(inherited) tables show difference SQL.
24) Comparison is NOT working when the custom vacuum is enabled & one of the parameter modified & again custom vacuum is disabled.
2020-01-28 14:53:17 +05:30
Nagesh Dhope
f167d77b61
Allow screen-reader to read label & description of non-textable elements. Fixes #4762 .
...
Allow screen-reader to identify the alert errors. Fixes #4763
Added role alertdialog for confirm and alert dialog.
Added role status for all status bars/banners.
Added role alert for error bars.
Added aria-labelledby for charts on each dashboard.
Added tabindex for each chart so that it is navigable using tab key.
2020-01-28 11:32:11 +05:30
Akshay Joshi
6594481992
1) Disable Fill Factor and Has OIDs control for the partitioned table.
...
2) Added reloptions for the partitions and partitioned table.
2020-01-24 16:13:30 +05:30
Akshay Joshi
4faf14b45f
Default tablespace should not be visible for the multi-level partitioned table on PG 12
2020-01-24 11:36:00 +05:30
Akshay Joshi
198063f046
Added support for a multi-level partitioned table. Fixes #2554 .
2020-01-23 18:49:15 +05:30
Aditya Toshniwal
fde8e4054a
Fixed an issue where Grant wizard unable to handle multiple objects when the query string parameter exceeds its limit. Fixes #4511
2020-01-20 17:53:21 +05:30
Akshay Joshi
b4b54d6b94
Fixed API test cases for missing language pack and jasmin test case.
2020-01-20 16:14:12 +05:30
Pradip Parkale
30b4b5b349
Improve code coverage and API test cases for the LANGUAGE module. Fixes #5050 .
2020-01-20 13:16:59 +05:30
Akshay Joshi
430e9ae994
Updated the incorrect icon used for the cast node on refresh. Fixes #5065 .
2020-01-17 12:10:26 +05:30
Akshay Joshi
af56b92af4
Fix an issue where refreshing a package results in the change in the object completely. Fixes #5066 .
2020-01-17 12:01:37 +05:30
Yogesh Mahajan
4ab3bbeb82
Improve code coverage and API test cases for the CAST module. Fixes #5049 .
2020-01-16 14:34:51 +05:30
Aditya Toshniwal
8c3bba65e5
Logout the pgAdmin session when no user activity of mouse move, click or keypress. Fixes #5000 .
...
Introduced two config params:
1. USER_INACTIVITY_TIMEOUT - Interval in seconds for the timeout. Default is 0-Zero which means disabled.
2. OVERRIDE_USER_INACTIVITY_TIMEOUT - If set to true, tools like query tool or debugger will override USER_INACTIVITY_TIMEOUT
and will not allow the application to timeout if a query is running for a long time.
2020-01-15 18:07:46 +05:30
Khushboo Vashi
45f2e35a99
Added Schema Diff tool to compare two schemas and generate the difference script.
...
Currently supported objects are Table, View, Materialized View, Function and Procedure.
Backend comparison of two schemas implemented by: Akshay Joshi
Fixes #3452 .
2020-01-10 15:42:09 +05:30
Akshay Joshi
be4b8284c5
Fix an issue where select, insert and update scripts on tables throwing an error. Fixes #5074 .
2020-01-09 18:23:23 +05:30
Akshay Joshi
76d04205ef
Fix an issue where the table is not created with autovacuum_enabled and toast.autovacuum_enabled for PG/EPAS 12. Fixes #5068 .
2020-01-07 17:55:12 +05:30
Akshay Joshi
4080511d9d
Fixed linter error.
2020-01-06 18:10:40 +05:30
Akshay Joshi
82c2d50885
Ensure that the user should be able to select/modify tablespace for the partitioned table on v12 and above. Fixes #4950 .
2020-01-06 17:45:25 +05:30
Akshay Joshi
2979424db5
Added support to view multilevel partitioned tables. Fixes #4633 .
2020-01-06 14:53:47 +05:30
Aditya Toshniwal
d4ee869281
Fixed broken tags and tokenizer options of select2. Regression of #5038
...
With the change of data adapter, we have configured adapters for tags and tokenizers.
We also renamed the method onDemandLoad to showOnScroll to avoid confusion.
2020-01-06 12:47:56 +05:30
Dave Page
01c7636c75
Update copyright notices for 2020.
2020-01-02 14:43:50 +00:00
Aditya Toshniwal
febbd729ec
Ensure that constraints, indexes, rules, triggers, and compound triggers should be created on partitions. Fixes #4842 .
2020-01-01 12:59:48 +05:30
Aditya Toshniwal
737f8375fb
Added support for on-demand loading of items in Select2. Fixes #5038 .
2020-01-01 11:24:16 +05:30
Nagesh Dhope
8c4dff057f
Added aria-label attribute wherever missing for accessibility.
2020-01-01 10:37:17 +05:30
Aditya Toshniwal
cc5c3776ca
Refactored SQL of Functions and Procedures. Fixes #5024 .
2019-12-31 12:55:18 +05:30
Akshay Joshi
ea3eabc3c7
1) Refactored SQL of Table's and it's child nodes. Fixes #4988 .
...
2) Ensure that the error message should not be displayed if Tablespace is not selected while creating the index. Fixes #5008 .
3) Fix an issue where operator, access method and operator class is not visible for exclusion constraints. Fixes #5009 .
2019-12-20 18:10:50 +05:30
Khushboo Vashi
f495af7a76
Refactored SQL of Views and Materialized Views. Fixes #5023 .
2019-12-20 17:14:15 +05:30
Akshay Joshi
4b9bfb2e4a
Optimized edit types and properties SQL for table/columns. It is part of #4988 .
2019-12-20 11:46:10 +05:30
Aditya Toshniwal
a6841bb1e1
Fixed couple of typos for edit types which results in showing proper edit types instead of all data types.
2019-12-18 13:35:58 +05:30
Aditya Toshniwal
f1a18749f6
1) Allow screen-reader to read relationship attributes for tab, tabpanels and tables under it. Similar changes are done for subnode controls.
...
2) Add role="img" for font icons.
Fixes #4764
2019-12-17 13:22:36 +05:30
Aditya Toshniwal
ded71be73f
Improved performance while fetching edit types for each column.
...
Edit types query is executed for every column when open properties dialog of the table.
Change the logic to fetch the edit types for all the distinct column types used in the table at once.
2019-12-16 18:26:22 +05:30
Karan Takalkar
53f418b9a2
Added more information to the 'Database connected/disconnected' message. Fixes #4943 .
2019-12-12 11:12:18 +05:30
Aditya Toshniwal
11bf5fc679
Fix an issue where clicking on an empty textbox like fill factor or comments, considers it as change and enabled the save button. Fixes #4506 .
2019-12-11 14:35:14 +05:30
Akshay Joshi
f15db03ec3
Added statistics and storage information in reverse engineering SQL of table/column. Fixes #4982 .
2019-12-09 15:01:04 +05:30
Aditya Toshniwal
6e2cf8ced2
Changed the open query tool and data filter icons. Fixes #4990 .
2019-12-06 19:27:55 +05:30
Akshay Joshi
1a9d365c42
Fix reverse engineering SQL issue where when clause is not visible for PG/EPAS 12. Fixes #4976 .
2019-12-06 19:01:55 +05:30
Aditya Toshniwal
75ac259632
Fix issue where the user can not switch the UI language. It's a regression of #4348 . Fixes #4975
2019-12-05 14:34:44 +05:30
Akshay Joshi
f8e1973bc2
Fix reverse engineering SQL issue for partitions when specifying digits as comments. Fixes #4893 .
2019-12-05 12:55:52 +05:30
Akshay Joshi
6c7fe644e5
Fix reverse engineering SQL issue for triggers when passed a single argument to trigger function. Fixes #4958 .
2019-12-05 11:45:47 +05:30
Akshay Joshi
9110703aaa
Fix 'Could not find the object on the server.' error while refreshing the check constraint. Fixes #4966 .
2019-12-03 14:18:45 +05:30
Aditya Toshniwal
0a67b2ecb9
Added aria-label to provide an invisible label where a visible label cannot be used. Fixes #4772 .
2019-12-03 12:47:42 +05:30
Khushboo Vashi
d476343b99
Enhance the logic to change the label from 'Delete/Drop' to 'Remove' for the server and server group node. Fixes #4923
2019-12-03 11:52:02 +05:30
Akshay Joshi
d95e8db4ee
Fix an issue of retrieving properties for Compound Triggers. It's a regression of #4006 . Fixes #4952 .
2019-12-02 15:01:54 +05:30
Khushboo Vashi
cccc6e5676
Added role=status attribute to all the status messages for accessibility. Fixes #4773 .
2019-12-02 14:15:31 +05:30
Rahul Shirsat
d98e86d3df
Warn the user on changing the definition of Materialized View about the loss of data and its dependent objects. Fixes #4396
2019-12-02 11:25:51 +05:30
Fahar Abbas
623ff4f91f
Allow drag and drop functionality for all the nodes under the database node, excluding collection nodes. Fixes #4435
2019-12-02 09:35:20 +05:30
Akshay Joshi
4fa1bdba5a
1) Refactored code of columns node. Fixes #4938 .
...
2) Fix an issue where length and precision are not removed from table/column dialog. Fixes #4964 .
3) Fix an issue where the Interval data type is not displayed in the properties dialog of table/column. Fixes #4965 .
4) Fix an issue where the wrong type is displayed when changing the datatype from timestamp with time zone to timestamp without time zone. Fixes #4761 .
5) Change the label from 'Length and Precision' to 'Length/Precision and Scale' for columns.
6) The maximum length for datatype like interval, timestamp with time zone, time with time zone, etc.. is 6. Set the max length to 6 instead of 10.
2019-11-28 18:48:53 +05:30
Aditya Toshniwal
4ed2d74d9c
1) Fix network disconnect issue while establishing the connection via SSH Tunnel and it impossible to expand the Servers node. Fixes #4724 .
...
2) Fix server connection drops out issue in query tool. Fixes #4818
3) Fix VPN network disconnect issue where pgAdmin4 hangs on expanding the Servers node. Fixes #4926 .
4) Ensure that the Servers collection node should expand independently of server connections. Fixes #4933 .
Set the default connection timeout to 10 seconds instead of 0.
2019-11-26 09:04:41 +05:30
Rahul Shirsat
1a39dedc62
Add Reverse Engineered and Modified SQL tests for Materialized Views. Fixes #4696 .
2019-11-25 11:11:09 +05:30
Akshay Joshi
de878b3198
Refactored code of table and it's child nodes.
...
1) Remove duplicate logic.
2) Child node specific logic should be inside the child node and table node gets the required information from the respective child node.
Note:- Refactoring of columns node still in progress.
Fixes #4807
2019-11-15 14:45:55 +05:30
Aditya Toshniwal
3ff4dfd02d
Fix issue where the Reset button does not get enabled till all the mandatory fields are provided in the dialog. Fixes #3538
2019-11-15 11:51:06 +05:30
Nagesh Dhope
397a1b9616
Fix main window tab navigation accessibility issue:
...
1) Dashboard -> Server Activity grid: terminate the session, cancel active button not navigable using tab key.
2) SQL -> If the focus inside code mirror control tab navigation not working.
Fixes #4930
2019-11-15 11:31:19 +05:30
Murtuza Zabuawala
6a5d98cf19
Fix accessibility issues:
...
1) Suppress ESC key presses in Alertify dialogues when the come from Select2 controls (It also closes the alertify dialog when user try to close Select2 using ESC key)
2) Do not allow Tabindex focus on Switch control when it is disbaled
3) Tab keyboard shortcut navigation does not work in wcDocker iframe.
Fixes #4935
2019-11-15 11:06:00 +05:30
Akshay Joshi
7282e15ee2
Fixed API and RESQL test cases for Compound Trigger after the recent changes in EPAS 12.
...
EPAS 12 Changes:
Fix server crash when the compound trigger has both row and statement-level triggers having
WHEN clause containing NEW/OLD vars.
2019-11-11 17:22:50 +05:30
Murtuza Zabuawala
022cf3d93c
Fixed an issue where keyboard shortcut for context menu is not working when using Firefox on CentOS7. Fixes #4906
2019-11-08 18:41:57 +05:30
Aditya Toshniwal
8180403f97
1) Added support for custom theme creation and selection. Fixes #4348 .
...
2) Added Dark(Beta) UI Theme option. Fixes #3741 .
3) Fix an issue where a black arrow-kind image is displaying at the background of browser tree images. Fixes #4171
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown.
It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes.
On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after the bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the SVG files(monochrome) used as icons for buttons to font icons.
This will allow us to change the color of the icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of
theme CSS files as CSS in .css files will not change with the change of SASS variables.
2019-11-07 18:51:03 +05:30
Rahul Shirsat
62d55cabd9
1) Fixed issue where Drop and Disconnect connection menu points are too close to each other. Fixes #3279
...
2) Rename the context menu from 'Drop Server' to 'Remove Server'. Fixes #3859
2019-11-07 13:11:24 +05:30
Ganesh Jaybhay
69fba93152
Fixed potential issue in reset function for nested objects.
...
Reset function clears the model instead of storing previous values.
Fixes #4895
2019-11-05 14:47:07 +05:30
Aditya Toshniwal
570ee58f53
Add an option to request confirmation before cancelling/resetting changes on a Properties dialog. Fixes #4351
2019-11-05 14:28:03 +05:30
Aditya Toshniwal
e10b58e4ca
Ensure create new object dialog should be opened when alt+shift+n key is pressed on the collection node. Fixes #3130
2019-11-05 11:20:03 +05:30
Aditya Toshniwal
080ccdda5b
Remove arbitrary (and incorrect) requirement that composite types must have at least two members. Fixes #4451
2019-11-01 15:21:59 +00:00
Aditya Toshniwal
f8e0b54836
Ensure comments are shown in reverse engineered SQL for table partitions. Fixes #4191
2019-11-01 11:58:38 +00:00
Aditya Toshniwal
131a944e24
Support Enable Always and Enable Replica on triggers. Fixes #4006
2019-11-01 11:49:17 +00:00
Aditya Toshniwal
fbc3e2d0e7
Don't warn the user before saving changes.
2019-10-30 10:13:29 +00:00
Aditya Toshniwal
c25034a86d
Add an option to request confirmation before cancelling changes on a Properties dialog. Fixes #4315
2019-10-29 14:31:43 +00:00
Dave Page
7408b8c8d9
PEP-8 fix.
2019-10-29 12:18:49 +00:00
Richard Yen
30e9673375
Give appropriate error messages when the user tries to use an blank master password. Fixes #4341
2019-10-25 13:55:07 +01:00
Aditya Toshniwal
4125360dfb
Ensure the correct "running at" agent is shown when a pgAgent job is executing. Fixes #3913
2019-10-25 11:39:40 +01:00
Aditya Toshniwal
02642628b0
Added encrypted password in reverse engineered SQL for roles. Fixes #1974 .
2019-10-23 13:16:36 +05:30
Akshay Joshi
2790689d26
1) Fix issue where validate switch for the foreign key is enabled from table dialog even if the key is validated.
...
2) Fix issue where validate the foreign key from the table dialog, rename the foreign key constraint to none.
2019-10-14 18:19:32 +05:30
Akshay Joshi
c3e11bd390
Fix issue where VALID foreign keys show as NOT VALID in the SQL tab for tables.
...
Corrected the condition for valid foreign key.
Fixes #4791
2019-10-10 18:55:13 +05:30
Aditya Toshniwal
f16498a8a7
Optimize Webpack to improve overall performance.
...
Changes include:
1) Remove underscore-string and sprintf-js packages as we were using only %s. Instead, added a function to do the same. Also changed gettext to behave like sprintf directly.
2) backgrid.sizeable.columns was not used anywhere, removed. @babel/polyfill is deprecated, replaced it with core-js.
3) Moved few css to make sure they get minified and bundled.
4) Added Flask-Compress to send static files as compressed gzip. This will reduce network traffic and improve initial load time for pgAdmin.
5) Split few JS files to make code reusable.
6) Lazy load few modules like leaflet, wkx is required only if geometry viewer is opened. snapsvg loaded only when explain plan is executed. This will improve sqleditor initial opening time.
Reviewed By: Khushboo Vashi
Fixes #4701
2019-10-10 12:05:28 +05:30
Akshay Joshi
55c6fa0d93
Fix an error where 'false' string is displayed when we add a new parameter in the Parameters tab,
...
also clear the old value when the user changes the parameter name.
Corrected the implementation of BooleanCellFormatter.
Fixes #4753
2019-10-07 16:00:28 +05:30
Akshay Joshi
7489c372e5
The search path should not be quoted while setting as a parameter, if it is
...
quoted then that string considers to be a single schema.
Quoting not added for the 'search_path' parameter.
Fixes #4760 , #4780
2019-10-07 12:28:00 +05:30
Akshay Joshi
bf2c001c87
Export job fails when deselecting all the columns.
...
Select2 parameter 'first_empty' should be set to false for the controls of type array.
If it is true then on deselecting/clearing all the values, an empty entry is still there.
Fixes #4751
2019-10-04 13:00:39 +05:30
Akshay Joshi
c54017eac5
Add Reverse Engineered and Modified SQL tests for Synonyms. Fixes #4472
2019-09-24 18:33:07 +05:30
Aditya Toshniwal
73dc130908
Fix issue where pgAdmin does not load completely if loaded in an iframe. Fixes #4756
2019-09-23 12:55:02 +05:30
Akshay Joshi
faa6236580
Add Reverse Engineered and Modified SQL tests for Unique Constraints. Fixes #4628
2019-09-20 12:12:01 +05:30
Akshay Joshi
426d9d5872
Fix SQL issue of length and precision when changing the data type of Column. Fixes #4698
2019-09-16 18:57:57 +05:30
Khushboo Vashi
aa668856f7
1) Add Reverse Engineered and Modified SQL tests for Primary Keys. Fixes #4624 .
...
2) Ensure Primary Key should be created with Index. Fixes #4742 .
2019-09-16 12:05:29 +05:30
Murtuza Zabuawala
d923dcf98b
Added MSQL test cases for Roles.
2019-09-16 11:41:48 +05:30
Akshay Joshi
f5a6df4ddb
Fix issue where EXEC script doesn't write the complete script for Procedures. Fixes #4727
2019-09-13 16:58:25 +05:30
Akshay Joshi
da553eec9b
Ensure port and username should not be mandatory when a service is provided. Fixes #4642
2019-09-13 11:54:16 +05:30
Akshay Joshi
7944e75695
Ensure sequence with negative value should be created. Fixes #4726
2019-09-12 14:18:30 +05:30
Akshay Joshi
6a931588aa
1) Add Reverse Engineered and Modified SQL tests for Foreign Keys. Fixes #4616
...
2) Fix issue where Validated switch option is inverted for the Foreign Key. Fixes #4412
2019-09-11 15:59:13 +05:30
Nagesh Dhope
db06dd0275
Add msql tests for FTS Dictionaries
2019-09-06 16:00:33 +01:00
Nagesh Dhope
9f26e7ed20
Added MSQL test cases for Extension.
2019-09-06 16:28:41 +05:30
Akshay Joshi
8e4e8b3e5a
1) Add Reverse Engineered and Modified SQL tests for Indexes. Fixes #4621
...
2) Fix modified SQL for Index when reset the value of Fill factor and Clustered?. Fixes #4702
3) Fix reversed engineered SQL for btree Index when provided sort order and NULLs. Fixes #4703
2019-09-06 14:10:46 +05:30
Akshay Joshi
9eff2e9926
Modified RE-SQL/MSQL test cases of foreign tables for EPAS 9.4 and 9.5
2019-09-05 12:01:03 +05:30
Akshay Joshi
5e54f20578
Add Reverse Engineered and Modified SQL tests for Foreign Tables. Fixes #4618 .
2019-09-04 18:33:07 +05:30
Ganesh Jaybhay
85baa22ca1
Added Modified SQL test cases for FTS Configurations.
2019-09-03 17:42:44 +05:30
navnath gadakh
4690700a24
Added Modified SQL test cases for Packages.
2019-09-03 17:33:57 +05:30
Akshay Joshi
4745ad56e9
1) Add Reverse Engineered and Modified SQL tests for Foreign Servers. Fixes #4617
...
2) Add Reverse Engineered and Modified SQL tests for User Mappings. Fixes #4627
2019-09-03 16:27:41 +05:30
Shubham Agarwal
a0f6e5272a
Add MSQL test cases for FTS Parser.
2019-09-03 10:28:11 +05:30
Murtuza Zabuawala
eeeb350ed2
Add Modified SQL tests for Resource Group. Fixes #4690
2019-09-03 10:18:09 +05:30
Akshay Joshi
5ff3f40116
Add Reverse Engineered and Modified SQL tests for FTS Templates. Fixes #4619
2019-09-02 15:24:41 +05:30
Akshay Joshi
662266a367
Added MSQL test cases for Cast and Language.
2019-09-02 14:11:59 +05:30
Neel Patel
0ca65d7cfe
Added MSQL test cases for Domain.
2019-09-02 11:52:19 +05:30
Akshay Joshi
e0c53e7d1d
Add Reverse Engineered SQL tests for Schemas. Fixes #4575
2019-08-29 18:32:08 +05:30
Aditya Toshniwal
d6da1cf25c
Added MSQL test cases for Sequences and cover missing ACL RE-SQL test cases.
2019-08-29 14:15:34 +05:30
Usman Muzaffar
ac298b03c0
1) Add Reverse Engineered SQL tests for Views. Fixes #4576
...
2) Ensure View should be created with special characters. Fixes #4486
2019-08-28 12:48:59 +05:30
Akshay Joshi
28b741a13a
Fixed timezone issue in RE-SQL test cases for Roles.
2019-08-27 19:54:30 +05:30
Murtuza Zabuawala
1ddc9cc889
Modified RE-SQL test to cover Password, Account Expire, Connection Limit and Variables for Roles.
2019-08-26 18:25:48 +05:30
Aditya Toshniwal
53ab4d7e8d
Fix an error that could be seen when click on any system column of a table. Fixes #4577
2019-08-26 14:36:07 +05:30
Aditya Toshniwal
234efc3be7
Don't wait for the database connection before rendering the Query Tool UI, for improved UX. Fixes #4453
...
In addition, unescape HTML entities in database names in the Query Tool title bar. Fixes #4584
2019-08-23 12:14:20 +01:00
Akshay Joshi
232fe286ee
Fix SQL tab issue for Views. It's a regression of compound triggers. Fixes #4650
2019-08-23 10:22:20 +05:30
Neel Patel
dc64ce331a
Fix length and precision enable/disable issue when changing the data type for Domain node. Fixes #4644 .
2019-08-21 16:27:23 +05:30
Akshay Joshi
094e5577e8
Add Reverse Engineered SQL tests for Rules. Fixes #4600
2019-08-21 16:06:05 +05:30
Akshay Joshi
41e2a674e3
Fix Truncate option deselect issue for compound triggers. Fixes #4643
2019-08-20 17:09:26 +05:30
Akshay Joshi
f3e4721a90
Added missing file for function selectivity feature. Fixes #4333
2019-08-20 10:02:43 +05:30
Akshay Joshi
0d6f07a035
1) Ensure compound triggers should be displayed under Views. Fixes #4638 .
...
2) Ensure Truncate option should be available for Compound Triggers. Fixes #4641 .
2019-08-20 09:39:31 +05:30
Akshay Joshi
24f9f65b1b
Ensure compound triggers for event should be updated properly. Fixes #4635
2019-08-17 15:58:50 +05:30
Murtuza Zabuawala
3f541200d9
Add Reverse Engineered SQL tests for Columns. Fixes #4546
2019-08-16 17:36:13 +05:30
Akshay Joshi
4403f326e9
Fix PEP8 issue
2019-08-12 14:41:22 +05:30
Akshay Joshi
35bbee3023
Fix generation of reverse engineered SQL for Rules. Fixes #4586
2019-08-12 14:27:02 +05:30
Aditya Toshniwal
1281f5cd6c
Fix console error when changing kind(SQL/BATCH) for pgAgent job step. Fixes #4582
2019-08-08 18:43:38 +05:30
Akshay Joshi
350ffcce7c
1) Add support of Compound Triggers for EPAS 12+. Fixes #4144 .
...
2) Ensure enable trigger menu should be visible when trigger is disabled. Fixes #4578 .
2019-08-08 16:59:11 +05:30
Dave Page
8331f62e1c
Fix PEP-8 issue.
2019-08-08 10:09:28 +01:00
Khushboo Vashi
c29275011a
Ensure the comment on a Primary Key constraint can be edited under the Table node. Fixes #4581
2019-08-08 09:52:10 +01:00
Akshay Joshi
7f53e13aa7
Fix generation of reverse engineered SQL for partition table, partitions were shown as a child of indexes. Fixes #4414
2019-08-07 17:49:13 +05:30
Dave Page
3a5464b278
Display the row count in the popup message when counting table rows, not just in the properties list. Fixes #4574
2019-08-07 11:17:57 +01:00
Aditya Toshniwal
4067d65a30
Improve test messages
2019-08-07 10:17:34 +01:00
Aditya Toshniwal
9cdb3b40ab
Add Reverse Engineered SQL tests for Trigger Functions. Fixes #4554
...
Fix the reverse engineered SQL for trigger functions with the WINDOW option selected. Fixes #4565
2019-08-06 14:26:11 +01:00
Aditya Toshniwal
6800b1f723
Add an optimisation to the internal code responsible for searching for treeview nodes. Fixes #4570
...
Attached is a tiny but very effective patch to improve the speed of
finding a node using path (used internally).
If you right click or just click on a node, internally the node is
traversed using its path. But currently, it compares with the path of
all the open nodes to find a match.
So if you 1000+ tables and the tables node is open and if you click on
a view, the view path is compared with all the 1000+ tables (and with
any other open nodes above) before arriving to path. You're at bad luck
if you have more open servers above.
Code is changed to check if the path of node to be found starts with the
current node path. If it doesn't match, why bother the children's of
current node.
This change will not show much effect for small data, but it does matter
for large servers.
One more change is to remove unnecessary calls to find node and use the
data available with Main Menu -> Object to enable/disable node context
menu items.
2019-08-06 14:02:57 +01:00
Khushboo Vashi
f8afe2ef94
Add Reverse Engineered SQL tests for Exclusion Constraint. Fixes #4555
2019-08-05 16:25:55 +05:30
Akshay Joshi
537c27a58e
Use the full tab space for CodeMirror instances on dialogues where appropriate. Fixes #4540
2019-08-02 10:25:21 +01:00
Akshay Joshi
1ff007d1cb
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around.
2019-08-01 11:39:49 +05:30
Akshay Joshi
2ef3080d0e
Add support for generated columns in Postgres 12+. Fixes #4334
...
Ensure columns can be created when they are IDENTITY fields with the CYCLE option enabled. Fixes #4496
Ensure purely numeric comments can be saved on new columns. Fixed #4497
2019-07-25 16:38:26 +01:00
Daniel Gustafsson
5b322d94e8
Fix generation of reverse engineered SQL for tables with Greenplum 5.x. Fixes #4179
2019-07-25 16:16:44 +01:00
Khushboo Vashi
adb5cd34bf
Add support for planner support functions in PostgreSQL 12+ functions. Fixes #4333
2019-07-25 16:09:37 +01:00
Nagesh Dhope
1813eca1ca
Add support for pre-condition SQL in RE-SQL testsuite,
...
and use it to ensure that the right extensions are installed for the
extension tests.
2019-07-22 09:44:17 +01:00
Khushboo Vashi
8168f623c4
Add Reverse Engineered SQL tests for Constraints. Fixes #4475
2019-07-17 13:25:08 +01:00
Akshay Joshi
ab87035658
pgAgent fixes:
...
"malformed array literal error when updating pgagent job". Fixes #4428
"Error when updating connection string in pgagent Jobs.". Fixes #4448
When user create a schedule using Create->Schedule dialog browser tree is not showing newly created node.
Properties tab showing same properties for all the created schedule.
Added validation in "pga_jobstep.js", throws error on browser when we modify step from the pgagent dialog and select the same node.
2019-07-15 15:54:57 +01:00
Aditya Toshniwal
d3ef1137d9
Add Reverse Engineered SQL tests for Sequences. Fixes #4469
2019-07-15 14:56:22 +01:00
Aditya Toshniwal
0b82a4ad92
Fix sequence reverse engineered SQL generation with quoted names on PG/EPAS 10+. Fixes #4470
2019-07-15 14:55:07 +01:00
Murtuza Zabuawala
f4453e33cc
Stabilise ordering of ACLs in Type RE-SQL tests to prevent random failures.
2019-07-15 14:48:22 +01:00
Shubham Agarwal
809e0682bd
Add Reverse Engineered SQL tests for FTS Parsers. Fixes #4471
2019-07-15 12:02:44 +01:00
Murtuza Zabuawala
1831c9e70a
Use ROLE consistently when generating RE-SQL for roles, not USER. Fixes #4446
2019-07-15 11:31:27 +01:00
Murtuza Zabuawala
1dcf46cc5f
Add Reverse Engineered SQL tests for Types. Fixes #4468
2019-07-15 10:25:04 +01:00
Neel Patel
88ab6db976
Add Reverse Engineered SQL tests for Domains. Fixes #4463
2019-07-12 14:39:49 +01:00
Khushboo Vashi
79e6f4c008
Add Reverse Engineered SQL tests for Collations. Fixes #4464
...
This also adds the ability to test the msql output in ALTER steps.
2019-07-12 14:37:00 +01:00
Navnath Gadakh
ce8a2bb266
Fix re-sql tests for packages on EPAS 9.4-9.6.
2019-07-12 11:32:29 +01:00
Akshay Joshi
29fd83dc6c
Fix dropping of pgAgent schedules through the Job properties. Fixes #3996
2019-07-12 10:37:41 +01:00
Akshay Joshi
ed01274f7b
Fix an error that could be seen when editing column privileges. Fixes #4389
2019-07-12 10:16:18 +01:00
Nagesh Dhope
379b92729a
Add Reverse Engineered SQL tests for FTS Dictionaries. Fixes #4460
2019-07-11 14:00:11 +01:00
Ganesh Jaybhay
4cbc1f2f59
Allow keyboard navigation of all controls on subnode grids. Partially fixes #3919
2019-07-11 10:14:01 +01:00
Navnath Gadakh
28585110dd
Add Reverse Engineered SQL tests for Packages. Fixes #4456
2019-07-11 09:23:13 +01:00
Akshay Joshi
cdf655f7db
Add Reverse Engineered SQL tests for Languages. Fixes #4452
2019-07-11 09:20:01 +01:00
Nagesh Dhope
e6c067025c
Fixed resql test cases for Extensions specific to database servers.
2019-07-11 13:16:00 +05:30
Akshay Joshi
6c7e95a463
Added re_sql test cases for privileges in Foreign Data Wrappers
2019-07-10 17:57:11 +05:30
Ganesh Jaybhay
f7d6966d60
Add Reverse Engineered SQL tests for FTS Configurations. Fixes #4454
2019-07-09 17:02:55 +01:00
Nagesh Dhope
84b712a008
Add RE-SQL tests for Extensions. Fixes #4453
2019-07-09 13:23:26 +01:00
Akshay Joshi
f085460453
Remove some files which was committed by mistake.
2019-07-09 16:47:23 +05:30
Akshay Joshi
1a9d8f01aa
1) Ensure re_sql tests should not abort at the first failure, it should run all the test cases.
...
2) Added place holder for owner, so we won't need to create separate pg/ppas folder just because of change in the owner name.
2019-07-09 15:37:53 +05:30
Akshay Joshi
a17687e27c
Fix reverse engineered sql for Foreign Data Wrapper created on EPAS server in redwood mode. Fixes #4450
2019-07-09 12:21:13 +05:30
Dave Page
863f62f4d8
Use special characters in names for RE-SQL tests to exercise quoting.
2019-07-08 11:03:30 +01:00
Khushboo Vashi
7c38c1cb38
Fix small issue which is required to support the custom schema in re_sql test cases.
2019-07-08 12:33:31 +05:30
Akshay Joshi
11a3aa56be
Use different folders for pg vs. ppas RE-SQL tests. Fall back to the tests folder without a subdirectory if neither exist.
2019-07-05 14:40:51 +01:00
Aditya Toshniwal
ba32c98241
Add Reverse Engineered SQL tests for FDWs. Fixes #4441
2019-07-05 11:24:54 +01:00
Akshay Joshi
776884860e
Ensure parameter values are quoted when needed when editing roles. Fixes #4393
2019-07-04 15:00:29 +01:00
Akshay Joshi
bf1f9a4b07
Fix table icon issue when updating any existing field. Fixes #4437
2019-07-04 17:34:47 +05:30
Murtuza Zabuawala
588e3814d1
Add RE-SQL tests for Roles and Resource Groups. Fixes #4415
2019-07-03 14:38:29 +01:00
Dave Page
64d31b9d3f
Fix a quoting issue that caused a blank UI to be displayed when running in French. Fixes #4407
2019-06-28 08:54:58 -04:00
Aditya Toshniwal
173b812b93
Allow some objects to be dragged/dropped into the Query Tool to insert their signature into the query text. Fixes #4139
2019-06-27 10:30:05 -04:00
Aditya Toshniwal
ebb5e3fe65
Ensure Python escaping matched JS escaping and fix a minor XSS issue in the Query Tool that required superuser access to trigger. Fixes #4378
2019-06-21 09:53:57 +01:00
Dave Page
644624eabe
PEP-8 fixes.
2019-06-20 14:30:31 +01:00
Khushboo Vashi
c07e52b9de
Ensure that both columns and partitions can be edited at the same time in the table dialog. Fixes #4380
2019-06-20 13:37:36 +01:00
Dave Page
81752bb998
Remove additional "SETOF" included when generating CREATE scripts for trigger functions. Fixes #4362
2019-06-20 13:18:30 +01:00
Akshay Joshi
9e65c971a3
Add a framework for testing reversed engineered SQL and CRUD API endpoints. Fixes #4202
2019-06-18 14:28:25 +01:00
Dave Page
71919a4ce9
Prevent the "Please login to access this page" message displaying multiple times. Fixes #4306
2019-06-17 14:12:36 +01:00
Aditya Toshniwal
402dfd07db
Change icons for table inheritance (icons by Chethana Kumar) Fixes #3174
...
Along with this, I have also fixed few other issues/icons found on the way:
1) Dependencies tab for inherited tables/foreign keys shows partial text (Fixes ##3994).
2) Dependencies tab for child partition table shows parent partition table as Function.
3) Dependencies tab for triggers shows trigger functions as plain functions.
4) Dependents tab for partitioned table shows the child partition tables as normal table instead for partitioned tables.
2019-06-17 10:36:30 +01:00
Akshay Joshi
04328b76ba
Fix syntax error for Default value of column. It is a regression of #4253
2019-06-13 18:04:43 +05:30
Akshay Joshi
d774a0ff67
Fix issue where property dialog of column should open properly for EPAS v12. Fixes #4343
2019-06-11 17:48:01 +05:30
Dave Page
6d52f2b911
Initial support for PostgreSQL 12. Fixes #4283 . Fixes #4288 . Fixes #4290 .
2019-06-10 14:24:45 +01:00
Dave Page
2ca11c84e8
Ensure that the Return key can be used to submit the Master Password dialogue. Fixes #4310
...
Ensure that browser auto-fill doesn't cause Help pages to be opened unexpectedly. Fixes #4317
2019-06-10 14:03:56 +01:00
Aditya Toshniwal
7ff85903e4
Fix issue where reverse engineered SQL was failing for foreign tables, if it had = in the options. Fixes #4171
2019-06-10 12:15:12 +05:30
Aditya Toshniwal
8b9c50ee5c
Fix issue where new column should be created with Default value. Fixes #4235
2019-06-10 11:53:16 +05:30
Aditya Toshniwal
a588c2994d
1) Fix issue where SSH tunnel connection using password is failing, it's regression of Master Password. Fixes #4320
...
2) Fix some more issues related to SSH Tunnel(By: Akshay Joshi)
2019-06-05 12:07:24 +05:30
Akshay Joshi
6a7339bbe4
Fix syntax error while opening properties tab of functions and procedures inside packages.
2019-06-01 14:02:33 +05:30
Dave Page
41a20e0252
Fix PEP-8 issue.
2019-05-31 12:12:04 -04:00
Dave Page
2dd075161d
Allow the UI layout to be fully locked or to prevent docking changes. Fixes #2653
2019-05-31 11:51:30 -04:00
Akshay Joshi
26c7d76d4f
Fix the issue of accessing the SQL for Views and Materialized Views. Regression of pluralisation of folder names. Fixes #4308
2019-05-31 11:02:37 +05:30
Aditya Toshniwal
dd187b9122
Prevent Alertify from inadvertently opening help pages.
2019-05-29 13:46:39 -04:00
Aditya Toshniwal
15252b0a26
Added Help button on all master password dialogs.
2019-05-29 13:07:50 +05:30
Aditya Toshniwal
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
Khushboo Vashi
6f0eafb223
Fixed CSRF security vulnerability issue. per Alvin Lindstam. Fixes #4217
...
Initial patch by: Khushboo Vashi
Modified by: Ashesh Vashi and Murtuza Zabuawala
2019-05-28 10:59:51 +05:30
Akshay Joshi
90a45557b9
1. Fix syntax error when adding more than one column to the existing table. Fixes #4162
...
2. Fix syntax error when creating a table with a serial column. Fixes #4284
2019-05-27 13:09:11 +05:30
Aditya Toshniwal
361f7077fd
Update the UI logo. Artwork by Chethana Kumar. Fixes #4208
2019-05-23 16:39:10 +01:00
Sander Eikelenboom
ab5f35da8d
Fixed error on displaying table properties of a table partitioned by list having a default partition. Fixes #4262
2019-05-15 18:36:16 +05:30
Aditya Toshniwal
db4bb22cc6
Ensure that element should get highlighted when they get focus on using Tab key. Fixes #4245
2019-05-15 17:42:07 +05:30
Aditya Toshniwal
2cd58efcdd
1) Fixed Tab key navigation for Maintenance dialog. Fixes #4227
...
2) Fix Tab key issue for Toggle switch controls and button on the dialog footer in Safari browser. Fixes #4244
2019-05-15 16:37:06 +05:30
Aditya Toshniwal
ed8d1cde00
Fix accessibility issue for menu navigation. Fixes #4194
2019-05-15 15:38:33 +05:30
Akshay Joshi
b7121bb2d2
1) Make folder name pluralise inside 'templates' folder and fix naming inconsistency.
...
2) Remove unwanted functions "module_js()" from the code.
3) Change naming convention for 'Roles' module.
2019-05-15 15:11:54 +05:30
Dave Page
4b421550d3
Stop using application/x-javascript as a mime type and use the RFC-compliant application/javascript instead. Fixes #4261
2019-05-15 09:44:57 +01:00
Dave Page
e53c2b1a5d
Ensure the treeview shows all sequences except those used to implement IDENTITY columns (which can be edited as part of the column). Show all if Show System Objects is enabled. Fixes #4154
2019-04-26 12:36:56 +01:00
Akshay Joshi
9b5a6e2bb7
Prevent duplicate columns being included in reverse engineered SQL for tables. Fixes #4163
2019-04-24 11:35:20 +01:00
Khushboo Vashi
74af8976c9
Ensure that newly added row in backgrid should be visible.
2019-04-23 17:32:00 +05:30
Khushboo Vashi
ecded18333
Fix an issue where 'GRANT UPDATE' sql should be displayed for default sequence privileges. Fixes #4087
2019-04-22 12:24:47 +05:30
Khushboo Vashi
5452bff49e
Fixed 'Increment value cannot be empty' error for existing tables. Fixes #4160
2019-04-22 12:04:49 +05:30
Aditya Toshniwal
05ae330030
Improvement for 'beforeunload' event, bind the event only from where it is required.
2019-04-22 11:30:33 +05:30
Aditya Toshniwal
49b318c39e
Ensure that confirmation dialog should be popped up before reload of query tool or debugger
...
if it is opened in a new browser tab. Fixes #4101
2019-04-18 15:39:36 +05:30
Aditya Toshniwal
d96f453e7f
Fixed 'Location cannot be empty' error when open Tablespace properties. Fixes #4134
2019-04-18 12:31:35 +05:30
Aditya Toshniwal
024cfd2fab
1) Ensure that JSON strings as comments should be added properly for all the objects. Fixes #3582
...
2) Fixed alignment issue of columns in definition section of Index node. Fixes #4121
2019-04-12 15:07:07 +05:30
Khushboo Vashi
a9d964b5ca
1) Added support for Default Partition. Fixes #3938
...
2) Ensure that record should be add/edited for root partition table with primary keys. Fixes #4104
2019-04-11 13:25:24 +05:30
Akshay Joshi
9c3925e448
Ensure that parameters of procedures for EPAS server 10 and below should be set/reset properly. Fixes #4161
2019-04-10 13:22:52 +05:30
Murtuza Zabuawala
84ecffa4d9
Added recommended ESLinter checks. Fixes #4142
2019-04-05 13:07:43 +05:30
Dave Page
614c66940a
Add missing files.
2019-04-01 11:04:44 +01:00
Akshay Joshi
d286bada5c
Fix custom autovacuum configuration for Materialized Views. Fixes #4110
2019-04-01 09:47:17 +01:00
Akshay Joshi
61ff588c09
Fixed issue while fetching the view id for view/materialized view. Added schema name in where clause.
2019-03-30 13:20:31 +05:30
Aditya Toshniwal
55c6f5205d
Add some SQL updates to handle inherited column markers/comments that were missed in the previous commit.
2019-03-29 14:44:21 +00:00
Dave Page
4d45a3cb24
PEP-8 fixes.
2019-03-28 14:20:52 -04:00
Khushboo Vashi
97919d091a
Add support for IDENTITY columns. Fixes #4030
2019-03-28 13:13:43 -04:00
Aditya Toshniwal
8aaacdf96e
Include inherited column comments and defaults in reverse engineered table SQL. Fixes #2627
...
Include comment SQL for inherited columns in reverse engineered table SQL. Fixes #4037
Include inherited columns in SELECT scripts. Fixes #4058
2019-03-28 08:36:41 -04:00
Aditya Toshniwal
6fb35f2649
Overhaul the layout saving code so it includes the Query Tool and Debugger, and stores the layout when change events are detected rather than (unreliably) on exit. Fixes #4084
2019-03-26 11:08:45 -04:00
Akshay Joshi
9c2ea3ca11
1) Ensure View/Materialized View node should be visible after updating any property. Fixes #4109
...
2) Updated the icon for Materialized View.
2019-03-26 14:12:47 +05:30
Akshay Joshi
a0010aac31
1) Ensure that sequence should be created with Privileges.
...
2) Updated the validation for blank values in Definition tab.
2019-03-25 14:29:43 +05:30
Akshay Joshi
212ca01506
Ensure sequences can be created with increment, start, minimum and maximum options set. Fixes #4100
2019-03-22 15:54:34 +00:00
Dave Page
ce073a2856
Fix SQL help for EPAS 10+, and refactor the URL generation code into a testable function. Fixes #4099
2019-03-22 14:09:24 +00:00
Usman Muzaffar
be26fc540c
Many fixes to the stability of the feature tests, including:
...
tree toggle issue
Query tool inteliSence issue eg. when there is only one option and drop down is not shown
Backup and restore windows locator changes
Fixes required due to resolving rm # 4041
Dependent tab not showing data sometime, so refreshed the page and handled it
Due to change of logic for auto commit, did the required changes
Due to fix of RM 4062, did the required workaround which broke the test case.
2019-03-21 12:04:37 +00:00
Akshay Joshi
48c5c39c5d
Ensure that parser should be set in FTS Configuration.
2019-03-20 20:21:58 +05:30
Akshay Joshi
5dd1472d6b
1) Fixed issue in Select2 Control, added undefined/null check.
...
2) Fixed the width of the delete cell.
2019-03-20 18:54:49 +05:30
Dave Page
906a4a845e
Update pycodestyle to 2.5.0. Allow newer versions so we can catch issues early.
2019-03-20 13:01:32 +00:00
Dave Page
7a271a34c6
Make the WHEN field a CodeMirror control on the Event Trigger dialogue. Fixes #4050
2019-03-15 10:35:47 +00:00
Dave Page
2e3475e06a
Fix the RE-SQL syntax for roles with a VALID UNTIL clause. Fixes #4081
2019-03-15 10:03:11 +00:00
Dave Page
69ec460b60
Fix naming inconsistency for the column and FTS parser modules. Fixes #1269
2019-03-14 16:52:42 +00:00
Khushboo Vashi
e4417229aa
Update all Python and JS dependencies. Fixes #4019
2019-03-14 15:11:16 +00:00
Dave Page
a9dad423f6
Fix the online help button on the resource group dialogue. Fixes #4052
2019-03-13 16:21:10 +00:00
Dave Page
cdc9ed678f
Enable the online help button on the index dialogue. Fixes #4053
2019-03-13 16:18:51 +00:00
Dave Page
ab9a3a57ad
Make the Query Tool history persistent across sessions. Fixes #4017
2019-03-13 13:37:34 +00:00
Khushboo Vashi
eb1db50f85
Avoid 'bogus varno' message from Postgres when viewing the SQL for a table with triggers. Fixes #3995
2019-03-12 10:13:31 +00:00
Dave Page
d7bf6ec69f
String review and subsequent cleanup
...
Ashesh Vashi
Abhilasha Narendra
Karen Blatchley
Susan Douglas
Dave Page
2019-03-05 14:08:16 +00:00
Khushboo Vashi
6b3a628e7a
Fix double scrollbar on the query tool results grid.
2019-02-27 10:59:58 +00:00
Dave Page
e5598038fa
Ensure size stats are prettified on the statistics tab when the UI language != English. Fixes #3096
2019-02-20 16:39:38 +00:00
Khushboo Vashi
622b67684d
Optimise display of Dependencies and Dependents, and use on-demand loading of rows in batches of 100. Fixes #3959
2019-02-14 11:15:01 +00:00
Khushboo Vashi
17694ab467
Automatically expand child nodes as well as the selected node on the treeview if there is only one. Fixes #3559
...
This also ensure the browser state is cleared if the save interval is set to -1.
2019-02-14 09:18:08 +00:00
Akshay Joshi
1f43b05c2a
Fix alignment of checkbox to drop multiple schedules of pgAgent job. Fixes #3946
2019-02-13 14:55:52 +05:30
Akshay Joshi
10ee75bb1f
Fix alignment of Close and Maximize button of Grant Wizard. Fixes #3906
2019-02-13 13:13:07 +05:30
Akshay Joshi
0aa93ac3ba
Fix alignment of Connection type toggle switch of pgagent. Fixes #3974
2019-02-13 13:03:44 +05:30
Dave Page
1fc66406f5
Don't embed docs and external sites in iframes, to allow the external sites to set X-FRAME-OPTIONS = DENY for security. Fxies #3985
2019-02-12 16:07:38 +00:00
Akshay Joshi
8f4d1f14f2
1) Fix alignment of import/export toggle switch. Fixes #3963
...
2) Remove unnecessary options for toggle switch which are already the default options.
2019-02-06 16:49:36 +05:30
Khushboo Vashi
4a75053514
Clean up the unwanted extended versions of Backform Switch controls.
...
The Bootstrap Switch Control was extended only for alignment in most
places. IIntroduce a configurable option to set the necessary class
on the main div and also remove the extra extended controls.
2019-02-05 16:22:35 +00:00
Aditya Toshniwal
d2ee5c4e82
1) Fixed jasmine test cases.
...
2) Bootstarp4 toggle size should be mini for triggers
2019-02-04 17:43:19 +05:30
Khushboo Vashi
dae8186c2a
Replace Bootstrap switch with Bootstrap4 toggle to improve the performance. Fixes #3051
2019-02-04 11:31:48 +05:30
Ashesh Vashi
38feacd04d
Remove hacky way to open/close the dropdown submenu
2019-01-31 17:49:41 +05:30
Khushboo Vashi
6244463ac1
Fixed Statistics panel hang issue for 1000+ tables. Fixes #3664
2019-01-31 14:47:29 +05:30
Akshay Joshi
2afa3d8267
Remove icon for 'Refresh View' context menu of Materialized View and Added label for Definition control for consistency.
2019-01-31 13:20:44 +05:30
Khushboo Vashi
3b35aaa1d7
Fixed unable to drop multiple Rules and Foreign Tables from properties tab. Fixes #3899
2019-01-31 13:03:37 +05:30
Akshay Joshi
0bb4f005e5
Correct schema should be displayed in Materialized View dialog. Fixes #3916
2019-01-31 11:29:18 +05:30
Murtuza Zabuawala
d9fc9fdc4d
Ensure object names in external process dialogues are properly escaped. Fixes #3872
2019-01-24 16:34:18 +00:00
Khushboo Vashi
406ada10f5
Fixed EXEC script for procedures. Fixes #3850
2019-01-23 14:44:24 +05:30
Aditya Toshniwal
fcfe0929d3
Ensure that browser should warn before close or refresh. Fixes #3849
2019-01-23 11:57:36 +05:30
Akshay Joshi
11ab1918ea
Fixed domain sql regression test for EPAS
2019-01-22 18:22:16 +05:30
Khushboo Vashi
c6bae69b6f
Proper SQL should be generated when create domain of type interval with precision. Fixes #3853
2019-01-22 17:53:36 +05:30
Harshal Dhumal
ea87d6da8f
Fixed keyboard navigation for Select2 and Privilege cell in Backgrid Fixes #3908
2019-01-22 16:35:57 +05:30
Harshal Dhumal
f731ab730b
Fixed keyboard navigation for dialog tabs. Fixes #3862
2019-01-22 16:28:32 +05:30
Akshay Joshi
c7cbe0ff4a
Data should be updated properly for FTS Configurations, FTS Dictionaries, FTS Parsers and FTS Templates. Fixes #3897
2019-01-21 14:36:39 +05:30
Akshay Joshi
69f6895224
Proper SQL should be generated when create function with return type as custom type argument. Fixes #3774
2019-01-18 15:11:35 +05:30
Aditya Toshniwal
48660508ce
Fixed controls alignment responsiveness to docker size change.
2019-01-17 18:20:12 +05:30
Aditya Toshniwal
f779378e8a
Add right border on selected tree item.
2019-01-17 13:27:07 +05:30
Akshay Joshi
c1aba3e055
1) Proper SQL should be generated when creating/changing column with custom type argument. Fixes #3838
...
2) Proper SQL should be generated when create procedure with custom type arguments. Fixes #3846
2019-01-17 13:13:15 +05:30
Aditya Toshniwal
6bbcaf6b27
Fixed SQL for when clause while creating Trigger. Fixes #3837
2019-01-16 14:46:34 +05:30
Aditya Toshniwal
d7b0508305
Fixed SQL for foreign table options. Fixes #3453
2019-01-16 12:34:16 +05:30
Aditya Toshniwal
7ac4e2a9d9
Fixed following issues:
...
- Process watcher made fixed width with header changes, time details rounded to 2 decimals
- Query history will show "No query history" if no query fired. Query editor default size increased.
- Fixed a bug where New folder create button not working when in List mode and No files/folder present.
- Other minor improvements.
2019-01-16 11:55:08 +05:30
Aditya Toshniwal
2a359d9d77
Proper error should be thrown when server group is created with existing name. Fixes #3693
2019-01-15 18:38:01 +05:30
Ashesh Vashi
1f082a0488
Fixed a typo in the wizard.js, which was not allowing to show the
...
maximize button in the Grant Wizard.
Also - change the CSS to set the top to '0' of the ajs-content (alertify
content container) for the frameless dialogs.
2019-01-15 12:59:13 +05:30
Akshay Joshi
252e05ef29
Fix SQL generated for tables with inherited columns. Fixes #3505
2019-01-11 21:50:02 +05:30
Akshay Joshi
01b87d4834
Don't show system catalogs in the schemas property list unless show system objects is enabled. Fixes #3842
2019-01-10 11:41:09 +05:30
Akshay Joshi
4e27bf989f
Display event trigger functions correctly on EPAS. Fixes #3549
2019-01-04 13:06:45 +00:00
Aditya Toshniwal
7d765fea04
Further styling fixes.
2019-01-03 14:50:24 +00:00
Dave Page
d7da8be486
Make the upgrade check key configurable.
2019-01-02 12:56:39 +00:00
Murtuza Zabuawala
e23d307c56
Update copyright notices for 2019
2019-01-02 15:54:12 +05:30
Aditya Toshniwal
86ecf9c84e
Fixed following:
...
- Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem.
- Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter
- Alignment fix for controls of Node properties dialogs which includes showing text and label in one line without dialog size change, checkbox alignment, switch control alignment at places and other minor improvements in other dialogs
- Error message design change in dialogs validation
- SQL Editor data grid editor popup design changes which were missed
- Design change for dashboard server activity grid
- Login page language dropdown color fix
- Properties accordion collapse design fix
- Help, Info icon fixed across all dialogs which were not working if clicked exactly on the text
- Added missing icon with buttons at few places
- Shadow behind the dialogs is increased to make it look clearly separated and depth.
- Control Alignment fix in maintenance dialog
- Min height of alertify dialogs set for better UX
- File dialog design fix when no files found
- Grant wizard fixes - Scroll bar visibility on first page, use full space for SQL generated on the last page
- Browser toolbar buttons changed to sync with SQL editor toolbar buttons
- Rounded corners for docker floating dialog (no properties)
- Renaming file in file dialog should show original file name
- SQL data grid text edit popup buttons behaviour was swapped. This is fixed.
- Import/Export dialog changes as per new design.
2019-01-02 15:07:59 +05:30
Ashesh Vashi
1b9c841c15
pgBrowser tree does not need to save tree state, when 'browser' module
...
is initialized from the tools like query editor, debugger, etc.
Refs #3559
2019-01-02 10:48:13 +05:30
Ashesh Vashi
5799ac14ba
Improvement in the look and feel of the whole application
...
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
2018-12-21 17:14:55 +05:30
Aditya Toshniwal
ffae65bdbe
Ensure table definitions include WHERE clauses on EXCLUDE constraints. Fixes #3726
2018-12-20 10:19:54 +00:00
Akshay Joshi
7515e08578
Fix an issue when user define Cast from smallint->text is created. Fixes #3753
2018-12-19 18:02:04 +05:30
Akshay Joshi
c973c3387e
Include the WHERE clause on EXCLUDE constraints in RE-SQL. Fixes #3726
2018-12-18 13:37:04 +00:00
Khushboo Vashi
72ba5bdaee
Fix drop/drop cascade regression. Fixes #3823
2018-12-18 09:45:06 +00:00
Khushboo Vashi
dfbb2212c0
Prevent attempts to bulk-drop schema objects. Fixes #3797
2018-12-13 11:03:30 +00:00
Dave Page
d68eede3e6
Allow query plans to be downloaded as SVG files. Fixes #3589
2018-12-13 10:49:56 +00:00
Murtuza Zabuawala
04735e631e
Minor bootstrap 4 fixes:
...
- Removed 'collapse in' css from wizard as we have 'collapse show' in Bootstrap-4
- Fixed 'Select/Unselect All' button layout for Select2 control used in pgAgent.
2018-12-13 10:28:58 +00:00
Akshay Joshi
431516ad61
Ensure the browser toolbar buttons work in languages other than English. Fixes #3798
2018-12-06 09:25:15 +00:00
Aditya Toshniwal
851c0cfff3
Ensure browser toolbar buttons are always shown.
2018-12-03 10:09:36 +00:00
Murtuza Zabuawala
c79ac2f8d2
Fix some minor CSS issues.
2018-11-27 10:57:30 +00:00
Akshay Joshi
3cfc3366d7
Fixed the height and width of the Table dialog.
2018-11-21 18:41:03 +05:30
Akshay Joshi
8b5abdfa8f
Fix changes to the NOT NULL and default value options in the Table Dialogue. Fixes #3742
2018-11-20 16:29:20 +00:00
Akshay Joshi
9b0889842d
Fix dropping of multiple functions/procedures at once. Fixes #3746
2018-11-14 08:40:21 -05:00
Dave Page
628f0d254e
Fix resource group multi-drop test.
2018-11-01 08:54:33 +00:00
Dave Page
7dde5d52d0
Fix regression test.
2018-10-31 12:18:13 +00:00
Khushboo Vashi
e59eaedfd0
Fix buildfarm failures.
2018-10-31 11:35:13 +00:00
Khushboo Vashi
f17979141c
Add support for dropping multiple objects at once from the collection Properties panel. Fixes #1513
2018-10-31 10:30:37 +00:00
Akshay Joshi
696fbfb8b9
Fix CREATE Script functionality for EDB-Wrapped functions. Fixes #3676
2018-10-29 11:54:11 +00:00
Usman Muzaffar
9ae49cbf31
Test case fixes for server mode.
2018-10-18 09:39:09 +01:00
Akshay Joshi
50738db2b8
Fix syntax error when creating new pgAgent schedules with a start
...
date/time and exception. Fixes #3638
- Fixed syntax error.
- Update/Delete exceptions are not working, SQL is wrong.
- Wrong exception time is shown, it should shown in UTC as datatype of
the column is timestamp with out timezone.
- Added test cases for Schedule and Steps of pgAgent Job.
2018-10-17 12:28:31 +01:00
Aditya Toshniwal
d6c4911135
Fixed calender control issues with Bootstrap 4
2018-10-12 15:02:38 +05:30
Aditya Toshniwal
6991c06937
Additional Bootstrap 4 fixes:
...
- Calendar control
- Query Tool's Sort/Filter drop down
- Backform hidden controls
- Debugger toolbar
2018-10-11 13:23:59 +01:00
Aditya Toshniwal
0565f8dd78
Update to use Bootstrap 3 instead of Bootstrap 4. Fixes #3562
2018-10-10 12:43:26 +01:00
Murtuza Zabuawala
c66840bc8e
Fix some styling regressed in #2927 .
2018-10-09 11:22:54 +01:00
Khushboo Vashi
528ea88dec
Save the treeview state periodically, and restore it automatically when reconnecting. Fixes #1253
2018-10-08 10:03:19 +01:00
Akshay Joshi
6c2c18106f
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around.
2018-09-24 14:11:23 -04:00
Aditya Toshniwal
38ddea038a
Fix support for the CLOB datatype in EPAS. Fixes #3596
2018-09-13 13:45:06 +01:00
Akshay Joshi
d6c64e8f11
Fixed issue where wrong menu id passed when click on 'View Data' tool button
2018-09-12 11:00:58 +05:30
Akshay Joshi
9c5e42c7a6
Used SCSS variables instead of hardcoded value for color and moved code from CSS to SCSS file.
2018-09-11 11:18:37 +05:30
Akshay Joshi
532cbe216a
Add shortcuts for View Data and the Query tool to the Browser header bar. Fixes #3564
2018-09-10 15:16:13 +01:00
Aditya Toshniwal
a74b9c96c1
Add optional data point markers and mouse-over tooltips to display values on graphs. Fixes #3514
...
Ensure queries are no longer executed when dashboards are closed. Fixes #3576
2018-09-05 17:25:11 +01:00
Dave Page
6e54a13ba2
Update test cases to match style changes
2018-09-04 12:04:57 +01:00
Aditya Toshniwal
82c9cca683
Move all CSS into SCSS files for consistency and ease of colour maintenance etc. Fixes #2927
2018-09-04 11:24:51 +01:00
Akshay Joshi
dd3c7c94e6
Ensure external table node should be visible only for GPDB. Fixes #3548
2018-08-27 19:11:25 +05:30
Murtuza Zabuawala
0f17b4f738
Ensure 'select all' and 'unselect all' working properly for pgAgent schedule. Fixes #3313 .
2018-08-22 15:13:40 +05:30
Joao De Almeida Pereira
46d4bf027d
Ensure sql for Role should be visible in SQL panel for GPDB. Fixes #3578
2018-08-17 14:50:16 +05:30
Ashesh Vashi
0a8d7a37b9
Changed the icon, label, inode, etc. propely while refreshing the
...
browser tree item.
Refs #3461
2018-08-14 10:18:03 +05:30
Akshay Joshi
008359ad3a
Ensure that refreshing a node also updates the Property list. Fixes #3461
2018-08-13 13:47:07 +01:00
Akshay Joshi
c8c5f83dfe
Add support to save and clear SSH Tunnel password. Fixes #3511
2018-08-06 15:56:46 +05:30
Aditya Toshniwal
cb8a288f85
Added version number for URL's to ensure that files are only cached on a per-version basis. Fixes #2136 .
2018-08-06 15:21:10 +05:30
Akshay Joshi
a17aa212f0
COST statement should not be automatically duplicated after creating trigger function. Fixes #3526
2018-08-06 11:54:25 +05:30
Akshay Joshi
e9e8b0b433
1. Change the string from 'Reset server password" to "Clear Saved Password" and move this sub menu from File to Object menu.
...
2. Move the "Change Password..." menu from 'File' to 'Object' menu.
RM #3074
2018-08-03 16:41:01 +05:30
Khushboo Vashi
0cb25bde63
Add support for primary key, foreign key, unique key, indexes and triggers on partitioned tables for PG/EPAS 11. Fixes #3412
2018-07-27 17:31:21 +05:30
Akshay Joshi
0138dee989
Add support for reset saved password. Fixes #3074
2018-07-27 14:36:42 +05:30
Aditya Toshniwal
f7e43d5e50
Realtime preference handling for the Dashboards and Debugger. Fixes #3294
2018-07-24 16:31:44 +01:00
Dave Page
d7eb41fff4
Include a cacert file when needed for the upgrade check. Fixes #3185
2018-07-23 16:15:58 +01:00
Akshay Joshi
213cb440d0
Add support for SCRAM password changes (requires psycopg2 >= 2.8). Fixes #2214
2018-07-23 15:03:44 +01:00
Khushboo Vashi
2d1e835d32
Fix panel errors seen when click on partitions.
2018-07-23 14:33:40 +01:00
Aditya Toshniwal
c353135a3a
Add support for INCLUDE columns on indexes and index constraints with PG 11+. Fixes #3462
2018-07-19 13:13:37 +01:00
Akshay Joshi
ce768c7f8a
Support SSH tunneling with keys that don't have a passphrase. Fixes #3468
2018-07-18 14:15:05 +01:00
Khushboo Vashi
8869fd6eb3
Fix a number of debugger execution issues. Fixes #3191
...
1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT.
2. Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument and function with void return type
3. The Reverse engineering SQL is not correct for Packages' functions/procedures
4. In case of INOUT argument, debugger asks for mendatory input which should not.
5. Re-executing a procedure whilst direct debugging doesn't work.
2018-07-17 12:51:24 +01:00
Akshay Joshi
39b41d7b24
Various procedure/function related fixes for EPAS/PG 11. Fixes #3446
...
- Fix the RM #3446 "plpgsql keyword should displayed in SQL pane for EPAS-11".
- Procedures for EPAS 11 always created as 'edbspl', even though language is sql or plpgsql.
- Not able to create Function/Procedure/Trigger function if the language is "C" for all supported database server.
- Function creation for EPAS 9.6 and above when set "Window?" flag to "Yes".
- Disable Volatility, Strict, Parallel, Estimated cost and Leak prof while creating procedures in EPAS 11 when language is not 'edbspl'.
- Rename "default" folder to "11_plus" inside "pg" directory for procedures, as procedures are supported from PG11 onwards.
- Creating/Deleting parameter in Procedure for PG 11.
- Drop procedures with arguments for PG/EPAS 11.
pg_proc table has added default value 'v' for Volatility, 100 for Cost and 'u' for Parallel for any language. All the three are not supported for Procedures in PG/EPAS 11 (excluding 'edbspl' language for EPAS). Fixed the issue where it is visible in properties panel if we create procedure using language 'plpgsql' or 'sql'.
2018-07-17 12:43:46 +01:00
Aditya Toshniwal
2b9c0a63fb
Ensure CodeMirror always has a non-zero font size. Fixes #3480
2018-07-10 13:58:44 +01:00
Aditya Toshniwal
3b862bd70b
More jQuery 3 updates.
2018-07-10 10:59:53 +01:00
Aditya Toshniwal
41a8333145
Replace deprecated success, error callbacks in $.ajax call with new functions .done and .fail.
2018-07-09 13:54:00 +01:00
Aditya Toshniwal
73530c05aa
Add missing files related to previous commit: Infrastructure and changes to the Query Tool for realtime preference handling. Refs #3294
2018-07-05 11:41:01 +01:00
Aditya Toshniwal
bdb7e3fde2
Infrastructure and changes to the Query Tool for realtime preference handling. Refs #3294
...
Highlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab of the main screen, Query tool, History entries in the query tool, Query tool opened in New Tab/Window
- All the components of SQL editor will refer to single source of preferences which is cached in the Browser object. All other redundant ajax get preference calls are removed.
- SQL editor will not refer template JS variables anymore, once all the references are removed the template variables will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.
2018-07-05 11:38:43 +01:00
Aditya Toshniwal
82d77c4608
Don't create a session when the /misc/ping test endpoint is called. Fixes #3371
2018-07-05 11:12:03 +01:00
Akshay Joshi
57c054fb0e
Fix various Drop menu options that were broken during the treeview refactoring.
...
Fixes #3442 . Fixes #3443 . Fixes #3444
2018-06-25 15:52:12 +01:00
Akshay Joshi
4a71c6d7af
Various EPAS/PG11 function & procedure fixes. Fixes #3421 . Fixes #3422
2018-06-25 14:58:02 +01:00
Akshay Joshi
560e5f225a
Allow dropping of Procedures in PG 11. Fixes #3423
2018-06-21 16:36:10 -04:00
Akshay Joshi
480fe6b9fc
Fixed issue of detection of EPAS server 11 and above. Version string is changed in EPAS 11
2018-06-21 18:30:37 +05:30
Joao Pedro De Almeida Pereira
155f82676d
Fix the RE-SQL generation for GreenPlum external tables. Fixes #3431
2018-06-19 20:01:45 -04:00
Akshay Joshi
7a06acb678
Allow the connection timeout to be configured on a per-server basis. Fixes #3388
2018-06-19 19:58:46 -04:00
Dave Page
9821e28da5
Fix file permissions per Devrim
2018-06-19 16:09:49 -04:00
Dave Page
717637c5b9
Fix indent.
2018-06-18 13:47:39 -04:00
Akshay Joshi
a45c33cf76
Ensure that template0 and template1 are available as tempates when creating databasesa. Fixes #3361
...
[regardless of the Show System Objects? option]
2018-06-18 13:41:14 -04:00
Ashesh Vashi
f2cef38364
Flask 1.0.2 does not allow a dot (.) in the view_func name, which we use
...
during generting the routes for the node.
References:
2f57a0b917
https://github.com/pallets/flask/issues/2790
Fixes #3360
Reported by: Marcelo Mendes
Investigated by: Khushboo Vashi
2018-06-18 09:58:16 +05:30
Akshay Joshi
766b389001
Include the schema name on RE-SQL for packages. Fixes #3356
2018-06-15 10:40:14 +01:00
Akshay Joshi
df7b4d55c6
Remove an extra space in Procedure templates.
2018-06-15 09:16:00 +01:00
Dave Page
087db8a75e
Fix stored procedure test cases so they don't fail on EPAS 9.4
2018-06-13 17:01:19 +01:00
Khushboo Vashi
d1ecba56b8
Function and procedure support for PG11. Fixes #3362
2018-06-13 15:03:17 +01:00
Joao De Almeida Pereira
e5048b4d0b
Disable ACLs for the database objects for the Greenplum due to
...
performance issue.
Reviewed By: Ashesh
Fixes #3415
2018-06-12 10:07:23 +05:30
Victoria Henry
226c872a84
Avoid an exception on GreenPlum when retrieving RE-SQL on a table. Fixes #3409
2018-06-11 16:56:39 +01:00
Joao De Almeida Pereira
7dd6372eeb
Extract the tests and refactor some of the methods.
...
Extract some of the ACI Tree functionalities, and decouple it from the
main source. Also - create some abstractions from the repeated code
around the enable/disable the schema children object create/edit/delete
functionalities, and also created the dialog wrappers for backup and
restore dialogs.
Reviewed by: Khushboo and Ashesh
Refactored by: Ashesh
2018-06-05 16:42:59 +05:30
Murtuza Zabuawala
f877de6a1f
Fix an issue where a change to any field in server dialog causes the 'tunnel_identity_file' model value to get included unnecessarily in the update request. Fixes #3389
2018-05-31 10:10:43 -04:00
Akshay Joshi
08990cb1de
Handle errors properly if they occur when renaming a database. Fixes #3353
2018-05-28 17:35:33 -04:00
Aditya Toshniwal
9f13865777
Update jQuery to 3.3.1. Fixes #3271
...
Patch by Aditya, with test enhancements from Anthony and Joao at Pivotal.
2018-05-25 16:26:37 +01:00
Aditya Toshniwal
a4ed9d6976
Allow connections to servers with port numbers < 1024 which may be seen in container environments. Fixes #3307
2018-05-18 11:12:38 +01:00
Akshay Joshi
719938a14c
Fixed issue where 'Identity file' control of SSH Tunnel tab is enabled when database is connected and 'Use SSH tunneling' flag is set to No.
2018-05-17 17:18:00 +05:30
Anthony Emengo
ab27b9d118
Fix template handling in tests for Windows.
2018-05-14 15:47:38 +01:00
Joao De Almeida Pereira
bc4d16eb83
Initial version of the new tree implementation.
...
This is the first version of our Tree implementation. At this point is a
very simple tree without no abstractions and with code that eventually
is not very performant, but this is only the first iteration and we are
trying to follow the 'Last Responsible Moment Principle' [1].
Implemention details:
- Creation of PGBrowser.treeMenu
- Initial version of the Tree Adaptor 'pgadmin/static/js/tree/tree.js'
- TreeFake test double that can replace the Tree for testing purposes
- Tests, As an interesting asside because Fake’s need to behave like
the real object you will noticed that there are tests for this type
of double and they the same as of the real object.
[1] https://medium.com/@aidanjcasey/guiding-principles-for-an-evolutionary-software-architecture-b6dc2cb24680
Patched by: Victoria && Joao
Reviewed by: Khushboo & Ashesh
2018-05-14 18:00:23 +05:30
Dave Page
8937375885
Standardise the error handling for parsing of JSON response messages from the server. Fixes #3238
2018-05-04 16:56:15 +01:00
Akshay Joshi
b7fb01ab04
Add support for SSH tunneled connections. Fixes #1447
2018-05-04 11:27:27 +01:00
Khushboo Vashi
732d8d903d
F5 key should work to refresh Browser tree. Fixes #3284
...
Refactoring by: Joao Pedro De Almeida Pereira
2018-05-02 11:43:42 +05:30