Commit Graph

522 Commits (master)

Author SHA1 Message Date
Aditya Toshniwal 17acce3e7b Continue fixing multiple UI issues found when testing wcDocker changes. #6479 2023-11-01 20:52:38 +05:30
Aditya Toshniwal b11b2a2f50 Continue fixing multiple UI and SonarQube issues found when testing wcDocker changes. #6479 2023-10-27 15:51:45 +05:30
Aditya Toshniwal 862f101772
Significant changes to use ReactJS extensively.
1. Replace the current layout library wcDocker with ReactJS based rc-dock. #6479
2. Have close buttons on individual panel tabs instead of common. #2821
3. Changes in the context menu on panel tabs - Add close, close all and close others menu items. #5394
4. Allow closing all the tabs, including SQL and Properties. #4733
5. Changes in docking behaviour of different tabs based on user requests and remove lock layout menu.
6. Fix an issue where the scroll position of panels was not remembered on Firefox. #2986
7. Reset layout now will not require page refresh and is done spontaneously.
8. Use the zustand store for storing preferences instead of plain JS objects. This will help reflecting preferences immediately.
9. The above fix incorrect format (no indent) of SQL stored functions/procedures. #6720
10. New version check is moved to an async request now instead of app start to improve startup performance.
11. Remove jQuery and Bootstrap completely.
12. Replace jasmine and karma test runner with jest. Migrate all the JS test cases to jest. This will save time in writing and debugging JS tests.
13. Other important code improvements and cleanup.
2023-10-23 17:43:17 +05:30
Akshay Joshi 557f33c4f9
Added support to drop databases using the 'WITH (FORCE)' option. #6367 2023-06-19 15:04:40 +05:30
Akshay Joshi 251bf05692 Fixed the following SonarQube code smells:
1) Do not use Array index in keys.
2) Unnecessary escape character.
3) Rename this local variable to match the regular expression ^[_a-z][a-z0-9_]*$
4) Remove the unused local variable.
2023-06-12 18:44:31 +05:30
Aditya Toshniwal dc8832192d When opening pgAdmin the layout should be auto reset if it is corrupted. Reset layout menu should work if layout is corrupted while using pgAdmin. #6266 2023-05-26 18:30:28 +05:30
Aditya Toshniwal 1e7517dc98
Show object breadcrumbs path along with its comment on object hover. #2078 2023-04-26 11:18:16 +05:30
Nikhil Mohite 625508e32a
Fixed an issue with the properties tab not getting updated if the user updates the selected node. #6158 2023-04-24 14:54:52 +05:30
Aditya Toshniwal 6710969143
Rename 'Edit Object..' context menu back to 'Properties...'. #4734 2023-04-03 13:10:24 +05:30
Aditya Toshniwal 5330121b36
On pressing Ctrl+C on a tree object, copy the fully qualified name to clipboard. #5854 2023-03-29 21:45:09 +05:30
Aditya Toshniwal 9924fae378
Nomenclature changes:
1. Rename "Properties..." context menu option of object to "Edit Object...".
2. Rename "Browser" tree to "Object Explorer". #4734
2023-03-28 22:20:14 +05:30
Aditya Toshniwal 1d01b5a8a2
Add a note on top of keyboard shortcuts preferences to show the Accesskey of the browser. #5022 2023-03-24 15:44:43 +05:30
Aditya Toshniwal 64ddfc0eb7
Fix an issue where server foreground/background color was not getting applied after jQuery changes. #5701 2023-03-21 17:39:37 +05:30
Aditya Toshniwal f72f4aa359
Dashboard graph Y-axis width should increase with label. #5929 2023-03-14 11:04:08 +05:30
Aditya Toshniwal ec32099d2f
Show appropriate error message when master password is not set instead of 'Crypt key missing'. #5735 2023-03-13 11:51:35 +05:30
Anil Sahoo 5abb748c3e
Display the 'No menu available for this object' message if the selected tree node does not have any options. #5775 2023-03-02 11:02:15 +05:30
Aditya Toshniwal 9abbd30790
Fix an issue where sequence owner is remove on sequence edit. #5810 2023-02-22 14:06:44 +05:30
Aditya Toshniwal 713ddb5f62
Remove usage of jQuery in pgAdmin.
Remove usage of Bootstrap in React components. #5701
2023-02-10 10:28:39 +05:30
Akshay Joshi 6833fdd731 Ensure that keyboard hotkey to open query tool and search object should work properly. #5763 2023-02-06 15:58:33 +05:30
Aditya Toshniwal 4a3bcfa202
Use uplot for Dashboard graphs to reduce CPU usage. #5794 2023-02-06 15:55:02 +05:30
Akshay Joshi ca43f938bd 1. Ensure that the system columns should not visible in the import/export data. #5733
2. Fixed console error while attaching the partition. #5748
2023-02-02 18:14:38 +05:30
Nikhil Mohite b02f81505b
Ensure nested menu items are shown in quick search result. #5796 2023-01-31 13:04:49 +05:30
Khushboo Vashi 7a18ceab64
Fixed the server heartbeat logging issue when server is removed. #5567 2023-01-30 15:39:34 +05:30
Khushboo Vashi 6ae91592d1
Fix orphan database connections resulting in an inability to connect to databases. #5567 2023-01-19 15:57:02 +05:30
Nikhil Mohite a48828e7a3
Improve performance by removing signal-based zoom-in, zoom-out, etc functionality from the runtime environment. #5723 2023-01-17 17:18:35 +05:30
Aditya Toshniwal 1c705cf9be
Fix issues related to menu rewrite. #5615 2023-01-09 18:41:23 +05:30
Nikhil Mohite 0a7d9a69f7
Ensure the correct child node is selected on the expansion of the collection node. 2023-01-05 17:30:30 +05:30
Nikhil Mohite 9c61670c9f
Ensure the query tool opens successfully on renaming any tree node from the database selected for the query tool connection #5542, #5559 2023-01-04 12:20:54 +05:30
Pravesh Sharma 33aea87dea
Incorporated review comments. #5647 2023-01-02 13:30:49 +05:30
Akshay Joshi 98184e5835 Update copyright notices for 2023 2023-01-02 11:53:55 +05:30
Pravesh Sharma 67bc0c23ef
Fixed an issue where row count notification was disappearing automatically. #5647 2023-01-02 10:54:24 +05:30
Aditya Toshniwal 5c34c10d4e
- Move pgadmin4-treeview to pgAdmin main repo.
- Use react based context menu for browser tree. #5615.
- Fix feature tests failure.
2023-01-02 10:51:13 +05:30
Aditya Toshniwal ff9daec5ec
Rewrite pgAdmin main menu bar to use React. #5615 2022-12-22 14:25:18 +05:30
Nikhil Mohite 1d4e7e2642
Fixed an issue updating the schema node de-select the node in the tree if only one schema is present in the collection node. #5542 2022-12-19 10:50:12 +05:30
Pravesh Sharma cc9d519fac
Incorporate review comments. 2022-12-14 15:53:19 +05:30
Pravesh Sharma 3f0eee4c39
Fixed an issue where properties tab was refreshing on tab change even if the selected node is same. #5536 2022-12-14 12:48:24 +05:30
Nikhil Mohite 4c64124588
Fixed an issue enable/disable tools menus is not working in native menus. #5503 2022-12-12 11:12:47 +05:30
Nikhil Mohite c752183199
Fixed issues in native menus. #5503
1. Lock layout selection from native menus not reflecting in preferences dialogue.
2. Sort sub menus with labels and priority in the toolbar and context menus
2022-12-09 14:08:35 +05:30
Nikhil Mohite adfef8e2bb
Fixed blank screen issue while opening online help in new window. #5503 2022-12-09 11:50:53 +05:30
Nikhil Mohite b172cd6a16
Resolved native menu issues. #5503 2022-12-07 18:47:38 +05:30
Nikhil Mohite 2480d08e0f
Added native menu support in desktop mode. #5503 2022-12-06 18:16:36 +05:30
Pravesh Sharma a824d9dd59
Improved error message to make it easier for users to understand. #5539 2022-11-29 18:15:46 +05:30
Aditya Toshniwal 8d74de09cc
Remove all traces of Backbone, Underscore. #5493 2022-11-21 10:54:15 +05:30
Nikhil Mohite 1904a64e42
Fixed XSS vulnerability issues. #5277 2022-10-13 10:59:05 +05:30
Nikhil Mohite 9002961e5d
Fixed console warning shown while updating database node from browser tree. #5332 2022-10-06 16:15:38 +05:30
Nikhil Mohite bb78d91d1b
Ensure that scroll bar on browser tree should be visible on windows resize #5402 2022-10-06 15:58:05 +05:30
Pravesh Sharma 94ca48674a
made tooltip consistent across the application (#5351)
Ensure that the tooltips are consistent throughout the entire application. #5293
2022-09-23 11:11:02 +05:30
Aditya Toshniwal 93f5fbc797 Fixed SonarQube issues. 2022-09-12 11:28:00 +05:30
Khushboo Vashi ca8b5c68fd Remove Backgrid and Backform. Fixes #6134 2022-09-10 14:22:49 +05:30
Pravesh Sharma 43022b7aa2 Fixed 'ternary operators should not be nested' code smell. 2022-09-10 14:00:22 +05:30
Yogesh Mahajan cbf5886430 Fixed the following code smells:
1. Use concise character class syntax
2. Add a "break" statement or remove this "else" clause.
3. Replace this generic exception class with a more specific one.
4. Use a regular expression literal instead of the 'RegExp' constructor.
5. Use the opposite operator ("not in") instead.
2022-09-10 13:48:14 +05:30
Akshay Joshi 3b95a416ca Fixed 'Remove the unnecessary boolean literals' code smell. 2022-09-09 15:23:18 +05:30
Akshay Joshi ec47a2aa66 Added a fix to the context menu and panel issue introduced by the SonarQube fixes. 2022-09-09 11:42:32 +05:30
Akshay Joshi b73aa6d000 Fixed 'Remove the unnecessary boolean literals' code smell 2022-09-08 20:28:43 +05:30
Akshay Joshi b8f63adf41 Fixes following code smell reported by SonarQube:
1) Replace this if-then-else flow by a single return statement
 2) Remove the unnecessary boolean literals.
2022-09-08 19:56:02 +05:30
Akshay Joshi 7086719640 Fixed SonarQube issues. 2022-09-08 18:08:58 +05:30
Akshay Joshi 18b77f15dd Remove Alertify from pgAdmin completely. Fixes #7619 2022-09-08 15:16:48 +05:30
Nikhil Mohite e1942d8c9e 1) Port schema diff to React. Fixes #6133
2) Remove SlickGrid.
2022-09-07 19:20:03 +05:30
Yogesh Mahajan ad59380676 Fixed an issue with the non-visibility of columns added prior to import/export data. Fixes #7649 2022-09-07 17:40:52 +05:30
Akshay Joshi e58b9c767b Port search object dialog to React. Fixes #7622 2022-08-30 17:08:12 +05:30
Yogesh Mahajan 71a4b20d90 Fixed some SonarQube issues. 2022-08-30 14:21:33 +05:30
Aditya Toshniwal c2b23465cc 1) Added support to show all background processes in separate panel. Fixes #3709
2) Port process watcher to React. Fixes #7404
2022-08-11 10:49:45 +05:30
Aditya Toshniwal 8b7ce2c276 Port change user password and 2FA dialog to React. Fixes #7568 2022-08-10 18:02:54 +05:30
Nikhil Mohite 9c418188ee Fixed SonarQube issues. 2022-08-10 15:05:20 +05:30
Yogesh Mahajan fa6b77b42c Port Role Reassign dialog to React. Fixes #7344 2022-08-05 16:04:15 +05:30
Akshay Joshi 53887c32bf Port change ownership dialog to React. Fixes #7590 2022-08-05 14:11:17 +05:30
Akshay Joshi 81b0d1138b Remove Alertify dialog from Grant Wizard, Import/Export Servers and Cloud. 2022-07-28 10:14:04 +05:30
Aditya Toshniwal 4808df5e95 1) Port the file/storage manager to React. Fixes #7313
2) Allow users to delete files/folders from the storage manager. Fixes #4607
3) Allow users to search within the file/storage manager. Fixes #7389
4) Fixed an issue where new folders cannot be created in the save dialog. Fixes #7524
2022-07-19 15:27:47 +05:30
Yogesh Mahajan 8f2bda2309 1) Preserve the settings set by the user in the import/export data dialog. Fixes #7428
2) Fixed the JSON editor issue of hiding the first record. Fixes #7520
2022-07-18 10:54:03 +05:30
Akshay Joshi 02b0f35442 1) Port change password dialog to React. Fixes #7341
2) Port named restore point dialog to React. Fixes #7546
2022-07-11 13:39:09 +05:30
Nikhil Mohite 64e6700228 Changed the default position of the dialog. 2022-07-05 18:46:49 +05:30
Aditya Toshniwal 239e3bb6f1 Some more theme related fixes. 2022-07-04 14:26:33 +05:30
Nikhil Mohite b283c0ba18 Port Master Password dialog to React. Fixes #7342 2022-07-04 12:16:23 +05:30
Pradip Parkale e59471d87d Ensure that dashboard graph API is not called after the panel has been closed. Fixes #7518 2022-07-04 12:03:18 +05:30
Aditya Toshniwal 86b30b3c83 Theme component usage has been fixed, a component should never be wrapped in multiple Theme components. 2022-06-30 15:18:20 +05:30
Nikhil Mohite d90b2621da Fixed an issue where passwords entered in the 'Connect To Server' dialog were truncated. Fixes #7440 2022-06-22 17:35:22 +05:30
Akshay Joshi 93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Pradip Parkale 628e609e6a 1) Added the option 'Show template databases?' to display template databases regardless of the setting of 'Show system objects?'.
2) Ensure that the user should be able to create a template database using create dialog instead of updating it later.

Fixes #7351
2022-06-13 14:50:17 +05:30
Aditya Toshniwal 5e0dfff42a Ensure that the editor position should not get changed once it is opened. Fixes #7393 2022-05-18 13:52:09 +05:30
Akshay Joshi 53bd2c2dc6 Ensure that when the user presses the Enter key on the connect to server dialog, it should work. 2022-05-18 12:08:37 +05:30
Akshay Joshi 44f9ba4a57 Port connect server password dialog to React. Fixes #7337 2022-05-16 16:21:14 +05:30
Akshay Joshi 6e2ee9a21f Port data filter dialog to React. Fixes #7340 2022-04-28 12:04:56 +05:30
Pradip Parkale ab8e9a8ea5 Fixed an issue while creating a new database throwing an error that failed to retrieve data. Fixes #7322 2022-04-22 15:42:04 +05:30
Aditya Toshniwal 9c30d983bd Fixed following issues for query tool after react porting:
1) Add New Server Connection > Server options keep loading(For empty Server group).
 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
 3) Check sign beside options in Execute Option/Copy Header is little bit big
 4) In explain > Analysis tab does not show ROWS column
 5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
 6) Update new query tool connection tool tip. Fixes #7289
 7) Explain-Analyze > Loops column is empty.
 8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
 9) Explain-Analyze with all option checked > background colors are missing for timing.
 10) Explain-Analyze > Additional bullet is added before Hash Cond.
 11) Browser Tree > Filtered rows icon is not working.
 12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
 13) Disable execute options in View/Edit data.
 14) The Boolean column always shows null.
 15) In Query history Remove & Remove all buttons are stuck to each other.
 16) On Remove all, the right panel is empty.
 17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
 18) In query history - Select queries are suffixed by ’Save Data’ icon
 19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
 20) Clicking arrows after opening dropdown options, does not collapse dropdown.

refs #6131
2022-04-18 12:50:51 +05:30
Akshay Joshi 86a3696ab4 Remove aciTree and its references. 2022-04-13 17:35:01 +05:30
Aditya Toshniwal b5b9ee46a1 1) Port query tool to React. Fixes #6131
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
2022-04-07 17:36:56 +05:30
Pradip Parkale 8f8adcf71b 1 Fixed the issue where db connection was getting disconnected for dashboard, if network is slow.
2 Fixed publication collection node properties issue which was missed during react node porting.
3 Removed unwanted variable from theme style sheet.
2022-04-05 13:40:22 +05:30
Pradip Parkale b397ba7787 Fixed issues related to porting of properties collection and dashboard.
refs #7132
2022-04-04 17:42:42 +05:30
Akshay Joshi 38278c179e Ensure that the master password dialog is popped up if the crypt key is missing. Fixes #6960 2022-04-04 17:00:18 +05:30
Pradip Parkale cb052f1988 1) Port Properties panel for collection node, Dashboard, and SQL panel in React. Fixes #7132
2) Added transaction start time to Server activity sessions view. Fixes #7215
2022-03-30 12:06:59 +05:30
Khushboo Vashi e61a1045f5 Added capability to deploy PostgreSQL servers on Amazon RDS. Fixes #7177 2022-02-14 12:13:48 +05:30
Aditya Toshniwal bc4e8a3c82 Implemented utilities in React to make porting easier for pgAdmin tools. 2022-02-11 10:36:24 +05:30
Akshay Joshi aa5b1d50b9 Fixed issues introduce by SonarQube fixes. 2022-02-01 14:11:18 +05:30
Nikhil Mohite 37d82d457c Fixed an issue where the F2 Function key removes browser panel contents. Fixes #7126 2022-01-28 10:55:23 +05:30
Akshay Joshi 0ce3434631 Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube. 2022-01-25 20:10:31 +05:30
Pradip Parkale 094129e2be Port Dependent, dependencies, statistics panel to React. Fixes #7016 2022-01-24 14:13:02 +05:30
Akshay Joshi 343c3ee49c Fixed following code smells reported by SonarQube:
1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.
2022-01-21 18:54:23 +05:30
Akshay Joshi 1013d7ccdd Fixed code smell reported by SonarQube. 2022-01-20 16:58:21 +05:30
Akshay Joshi dabe64a8df Fixed enable/disable menu issue introduced by SonarQube fix. 2022-01-19 12:16:57 +05:30
Akshay Joshi 6adc1bfd42 Fixed context menu issue. 2022-01-18 18:43:34 +05:30