Resolved native menu issues. #5503

runtime/src/js/pgadmin.js

@@ -426,10 +426,10 @@ function addCommonMenus(pgBrowser, menu) {
 }
 
 function getSubMenu(pgBrowser, menuItem) {
-  var submenu = new gui.Menu();
+  let submenu = new gui.Menu();
   if (menuItem.menu_items) {
     menuItem.menu_items.forEach((item) => {
-      let menuType = typeof item.checked == 'boolean' ? 'checkbox' : item.type || 'normal';
+      let menuType = typeof item.checked == 'boolean' ? 'checkbox' : item.type;
       submenu.append(new gui.MenuItem({
         label: item.label,
         enabled: !item.is_disabled,

web/pgadmin/browser/static/js/browser.js

@@ -478,8 +478,8 @@ define('pgadmin.browser', [
       let {name: browser} = getBrowser();
       if(browser == 'Nwjs') {
         pgBrowser.MainMenus.forEach((menu) => {
-          menu.menuItems.forEach((item) => {
-            item.setDisabled(item.disabled(d, item));
+          menu.menuItems.forEach((_item) => {
+            _item.setDisabled(_item.disabled(d, item));
           });
         });
       }else {

web/pgadmin/browser/static/js/main_menu.js

@@ -28,22 +28,22 @@ export default function createMainMenus() {
     // Don't add menuItems for Object menu as it's menuItems get changed on tree selection.
     if(_menu.name !== 'object') {
       menuObj.addMenuItems(Object.values(pgAdmin.Browser.menus[_menu.name]));
-      let priority = null;
       menuObj.menuItems.forEach((menuItem, index)=> {
-        if(index == 0) {
-          priority = menuItem.priority;
+        menuItem?.menu_items?.forEach((item, indx)=> {
+          item.below && menuItem?.menu_items.splice(indx+1, 0, getSeparator());
+        });
+        if(menuItem.below) {
+          menuObj.addMenuItem(getSeparator(), index+1);
         }
-
-        if(priority !== menuItem.priority) {
-          let separateMenuItem = new MenuItem({type: 'separator'});
-          menuObj.addMenuItem(separateMenuItem, index);
-        }
-
       });
     }
   });
 }
 
+function getSeparator() {
+  return new MenuItem({type: 'separator'});
+}
+
 export function refreshMainMenuItems(menu, menuItems) {
   if(browser == 'Nwjs') {
     menu.setMenuItems(menuItems);

web/pgadmin/browser/static/js/quick_search/menuitems_help.js

@@ -55,7 +55,7 @@ export function menuSearch(param, props) {
 
   // Starting Point
   let {name: browser} = getBrowser();
-  const mainMenus = browser == 'Nwjs' ?pgAdmin.Browser.MainMenus : MainMenus;
+  const mainMenus = browser == 'Nwjs' ? pgAdmin.Browser.MainMenus : MainMenus;
   if(browser == 'Nwjs') {
     mainMenus.forEach((menu) => {
       let subMenus = menu.menuItems;

web/pgadmin/help/__init__.py

@@ -26,7 +26,7 @@ class HelpModule(PgAdminModule):
             MenuItem(name='mnu_quick_search_help',
                      label=gettext('Quick Search'),
                      priority=99,
-                     target='pgadmin_help',
+                     target='pgadmin_quick_search_help',
                      icon='fa fa-question',
                      url='#'),
             MenuItem(name='mnu_online_help',

web/pgadmin/settings/__init__.py

@@ -37,7 +37,6 @@ class SettingsModule(PgAdminModule):
                     priority=998,
                     module="pgAdmin.Settings",
                     callback='show',
-                    icon='fa fa-retweet',
                     label=gettext('Reset Layout')
                 )
             ]

web/pgadmin/static/scss/_pgadmin.style.scss

@@ -151,7 +151,8 @@
 }
 
 .pg-docker-native {
-  top: 0px !important
+  top: 0px !important;
+  border-top: 1px solid $border-color;
 }
 
 .pg-panel-content {