pgadmin-org
/
pgadmin4
mirror of https://github.com/pgadmin-org/pgadmin4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed windows signature issue by passing SignTool using /S arg ISCC.exe instead of specifying the path in installer.iss

dependabot/npm_and_yarn/runtime/eslint-9.31.0
Aditya Toshniwal 2025-07-14 15:12:29 +05:30
parent b31c8f78c5
commit 65a35ab23d
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Make.bat
View File

@ -356,7 +356,7 @@ REM Main build sequence Ends
DEL /s "%WD%\pkg\win32\installer.iss.in_stage*" > nul
ECHO Creating windows installer using INNO tool...
CALL "%PGADMIN_INNOTOOL_DIR%\ISCC.exe" "%WD%\pkg\win32\installer.iss" || EXIT /B 1
CALL "%PGADMIN_INNOTOOL_DIR%\ISCC.exe" "%WD%\pkg\win32\installer.iss" "/SpgAdminSigntool=%PGADMIN_SIGNTOOL_DIR%\signtool.exe sign /fd certHash /tr http://timestamp.digicert.com /td SHA256 $f" || EXIT /B 1
ECHO Renaming installer...
MOVE "%WD%\pkg\win32\Output\pgadmin4-setup.exe" "%DISTROOT%\%INSTALLERNAME%" > nul || EXIT /B 1

4
pkg/win32/installer.iss.in
View File

@ -39,10 +39,6 @@ MinVersion={#MinimumWindowsVer}
SignTool=pgAdminSigntool
SignedUninstaller=yes
[SignTool]
Name: "pgAdminSigntool"; \
Command: "{#GetEnv('PGADMIN_SIGNTOOL_DIR')}\signtool.exe sign /fd certHash /tr http://timestamp.digicert.com /td SHA256 $f"
[Languages]
Name: "english"; MessagesFile: "compiler:Default.isl"