From 65a35ab23db21ea2d446e29093fc821aad81e30c Mon Sep 17 00:00:00 2001
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Mon, 14 Jul 2025 15:12:29 +0530
Subject: [PATCH] Fixed windows signature issue by passing SignTool using /S
 arg ISCC.exe instead of specifying the path in installer.iss

---
 Make.bat                   | 2 +-
 pkg/win32/installer.iss.in | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/Make.bat b/Make.bat
index dd7bab89e..733b5017e 100644
--- a/Make.bat
+++ b/Make.bat
@@ -356,7 +356,7 @@ REM Main build sequence Ends
     DEL /s "%WD%\pkg\win32\installer.iss.in_stage*" > nul
 
     ECHO Creating windows installer using INNO tool...
-    CALL "%PGADMIN_INNOTOOL_DIR%\ISCC.exe" "%WD%\pkg\win32\installer.iss" || EXIT /B 1
+    CALL "%PGADMIN_INNOTOOL_DIR%\ISCC.exe" "%WD%\pkg\win32\installer.iss" "/SpgAdminSigntool=%PGADMIN_SIGNTOOL_DIR%\signtool.exe sign /fd certHash /tr http://timestamp.digicert.com /td SHA256 $f" || EXIT /B 1
 
     ECHO Renaming installer...
     MOVE "%WD%\pkg\win32\Output\pgadmin4-setup.exe" "%DISTROOT%\%INSTALLERNAME%" > nul || EXIT /B 1
diff --git a/pkg/win32/installer.iss.in b/pkg/win32/installer.iss.in
index 02c5bba5e..3238276cf 100644
--- a/pkg/win32/installer.iss.in
+++ b/pkg/win32/installer.iss.in
@@ -39,10 +39,6 @@ MinVersion={#MinimumWindowsVer}
 SignTool=pgAdminSigntool
 SignedUninstaller=yes
 
-[SignTool]
-Name: "pgAdminSigntool"; \
-    Command: "{#GetEnv('PGADMIN_SIGNTOOL_DIR')}\signtool.exe sign /fd certHash /tr http://timestamp.digicert.com /td SHA256 $f"
-
 [Languages]
 Name: "english"; MessagesFile: "compiler:Default.isl"