SimFG
e18d5aceb6
enhance: add config to control whether to init public role permissions ( #33165 )
...
issue: #33164
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-05-21 22:39:46 +08:00
wei liu
04f355a802
enhance: Enable alter database props in rootcoord ( #32458 )
...
issue: #30040
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-04-25 10:53:25 +08:00
SimFG
c012e6786f
feat: support rate limiter based on db and partition levels ( #31070 )
...
issue: https://github.com/milvus-io/milvus/issues/30577
co-author: @jaime0815
---------
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-04-12 16:01:19 +08:00
SimFG
789e014c74
enhance: add the db id for the describe collection response ( #32114 )
...
/kind improvement
issue: #32110
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-10 21:23:20 +08:00
congqixia
25a1c9ecf0
fix: Make coordinator `Register` not blocked on ProcessActiveStandby ( #32069 )
...
See also #32066
This PR make coordinator register successful and let
`ProcessActiveStandBy` run async. And roles may receive stop signal and
notify servers.
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-10 18:49:18 +08:00
jaime
bd853be8c7
enhance: Add db label for some usual metrics ( #30956 )
...
issue: #31782
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-04-02 14:27:13 +08:00
wei liu
9111ecab82
enhance: Rootcoord's stop may block in quota_center's stop ( #31447 )
...
this PR fixed that rootcoord's stop may block in quota_center' stop
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-04-01 21:09:18 +08:00
yihao.dai
0fe5e90e8b
enhance: Remove import v1 ( #31403 )
...
Remove all code and logic related to import v1.
issue: https://github.com/milvus-io/milvus/issues/28521
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-03-22 15:29:09 +08:00
Bingyi Sun
992cb6a532
enhace: optimize alter collection log print ( #31275 )
...
issue: https://github.com/milvus-io/milvus/issues/31142
Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-03-18 15:19:06 +08:00
jaime
db79be3ae0
fix: ctx cancel should be the last step while stopping server ( #31220 )
...
issue: #31219
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-03-15 10:33:05 +08:00
chyezh
6a9418d200
fix: lost dbname when only passing collection id to describeCollection ( #31167 )
...
issue: #30931
Signed-off-by: chyezh <chyezh@outlook.com>
2024-03-11 17:19:02 +08:00
chyezh
0c7474d7e8
enhance: add graceful stop timeout to avoid node stop hang under extreme cases ( #30317 )
...
1. add coordinator graceful stop timeout to 5s
2. change the order of datacoord component while stop
3. change querynode grace stop timeout to 900s, and we should
potentially change this to 600s when graceful stop is smooth
issue: #30310
also see pr: #30306
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-02-29 17:01:50 +08:00
zhenshan.cao
bb93b22c84
fix: should return collectionName in response of ListAliases ( #30532 )
...
issue : https://github.com/milvus-io/milvus/issues/30369
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-02-12 08:30:55 +08:00
wayblink
1df3f90696
feat: Implement DescribeAlias and ListAliases interfaces ( #29641 )
...
#22882
/kind feature
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-01-11 19:12:51 +08:00
smellthemoon
1c1f2a1371
enhance:change some logs ( #29579 )
...
related #29588
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-01-05 16:12:48 +08:00
SimFG
dd9c61831d
enhance: Support to get the param value in the runtime ( #29297 )
...
/kind improvement
issue: #29299
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-22 18:36:44 +08:00
wei liu
e41fd6fbde
enhance: Move proxy client manager to util package ( #28955 )
...
issue: #28898
This PR move the `ProxyClientManager` to util package, in case of
reusing it's implementation in querycoord
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-20 19:22:42 +08:00
PowderLi
bcd6865b29
enhance: add 3 builtin roles ( #28961 )
...
issue: #28960 [milvus-proto
#212 ](https://github.com/milvus-io/milvus-proto/issues/212 )
add new configuration: builtinRoles
user can define roles in config file: `milvus.yaml`
there is an example:
1. db_ro, only have read privileges, include load
2. db_rw, read and write privileges, include create/drop/rename
collection
3. db_admin, not only read and write privileges, but also user
administration
Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-18 14:28:41 +08:00
yah01
b8674811cf
fix: data race in ProxyClientManager ( #29206 )
...
this PR changed the ProxyClientManager to thread-safe
fix #29205
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-14 18:22:39 +08:00
SimFG
5a7fb97e07
fix: missing the grant info when using the SelectGrant api with the default db ( #29173 )
...
issue: #29172
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-14 16:20:43 +08:00
wayblink
994b239161
fix: fix datarace in root_coord proxy_client_manager ( #28796 )
...
bug: #28797
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-12 10:18:39 +08:00
wei liu
6718986a5b
enhance: Remove too frequency read ddl log from rootcoord ( #28891 )
...
This PR removed too frequency log for such
`DescribeCollection/ShowPartition` operation from root coord
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-04 09:42:33 +08:00
congqixia
881a166b5a
fix: data race on rootcoord.proxyClientManager.proxyClient ( #28787 )
...
Fix #28786
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-28 15:52:26 +08:00
jaime
b1e0a27f31
enhance: Add logs for each step during service initialization ( #28624 )
...
/kind improvement
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-11-27 16:30:26 +08:00
smellthemoon
79c0edb1d8
enhance:Remove msgbase unnecessary assignments ( #28511 )
...
remove some unnecessary assignments, for the reason that
commonpbutil.NewMsgBase has default value.
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-24 15:02:39 +08:00
wayblink
53646032d0
fix: rootcoord_collection_num metric is twice the real value ( #28666 )
...
#28665
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-23 20:42:23 +08:00
congqixia
a2fe9dad49
enhance: Make etcd kv request timeout configurable ( #28661 )
...
See also #28660
This pr add request timeout config item for etcd kv request timeout
Sync the default timeout value to same value for etcdKV & tikv config
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-23 19:34:23 +08:00
smellthemoon
73f2bab454
enhance:add some log when create client and get component states ( #28160 )
...
/kind improvement
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-22 09:12:22 +08:00
Filip Haltmayer
6b1a106a31
Moving etcd client into session ( #27069 )
...
Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
2023-10-27 07:36:12 +08:00
SimFG
9b0ecbdca7
Support to replicate the mq message ( #27240 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-10-20 14:26:09 +08:00
wayblink
e3f2122618
Expose metrics of stanby coordinators ( #27698 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-10-16 15:04:09 +08:00
jaime
ec1fe3549e
Add a stop hook to clean session ( #27564 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-10-16 10:24:10 +08:00
yah01
15746b5b5f
Refine KV errors ( #27588 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-10-13 17:15:34 +08:00
yah01
be980fbc38
Refine state check ( #27541 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-10-11 21:01:35 +08:00
yah01
63ac43a3b8
Refine errors for import ( #27379 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-30 10:31:28 +08:00
yah01
6539a5ae2c
Refine DataCoord status ( #27262 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-26 17:15:27 +08:00
wayblink
7dd0be1b2c
Enable bulkinsert binlog data with partitionkey ( #27241 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-09-26 10:25:25 +08:00
jaime
7f7c71ea7d
Decoupling client and server API in types interface ( #27186 )
...
Co-authored-by:: aoiasd <zhicheng.yue@zilliz.com>
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-09-26 09:57:25 +08:00
SimFG
26f06dd732
Format the code ( #27275 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-21 09:45:27 +08:00
SimFG
0901b76732
Avoid the panic when the status of rpc response is nil ( #26910 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-07 19:23:15 +08:00
yiwangdr
337edc321b
tikv integration ( #26246 )
...
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-09-07 07:25:14 +08:00
SimFG
28681276e2
Improve the retry of the rpc client ( #26795 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-06 17:43:14 +08:00
yah01
3349db4aa7
Refine errors to remove changes breaking design ( #26521 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-04 09:57:09 +08:00
jaime
c603f1c244
Remove mysql metastore ( #26633 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-08-29 14:36:26 +08:00
yah01
4a181c1635
Fix panic while stopping the cluster ( #26580 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-23 19:08:23 +08:00
SimFG
d13ca54414
Change the default gracefulStopTimeout and only warn when fail to refresh policy cache ( #26450 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-08-22 09:04:21 +08:00
yihao.dai
63b86b32a6
Add server id validation interceptor ( #26395 )
...
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-08-17 20:20:20 +08:00
groot
279a060e75
Not allow to set partition name for collection with partition key ( #26129 )
...
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-08-10 18:55:21 +08:00
SimFG
4e1b65d38f
Refine the rbac cache update process ( #26150 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-08-07 11:59:07 +08:00
SimFG
d2649b63db
Delete the user-role mapping info when deleting the user ( #25988 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-08-04 18:37:08 +08:00
XuanYang-cn
1fff8d2c66
Fix restore redrop enormous dup collections ( #26029 )
...
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-08-03 10:37:06 +08:00
Enwei Jiao
66fdc71479
Refactor logs in DataCoord & DataNode ( #25574 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-07-14 15:56:31 +08:00
groot
96c987ed62
Bulkinsert supports partition keys ( #25284 )
...
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-07-11 15:18:28 +08:00
xige-16
33c2012675
Add more metrics ( #25081 )
...
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-06-26 17:52:44 +08:00
jaime
18df2ba6fd
[Cherry-Pick] Support Database ( #24769 )
...
Support Database(#23742 )
Fix db nonexists error for FlushAll (#24222 )
Fix check collection limits fails (#24235 )
backward compatibility with empty DB name (#24317 )
Fix GetFlushAllState with DB (#24347 )
Remove db from global meta cache after drop database (#24474 )
Fix db name is empty for describe collection response (#24603 )
Add RBAC for Database API (#24653 )
Fix miss load the same name collection during recover stage (#24941 )
RBAC supports Database validation (#23609 )
Fix to list grant with db return empty (#23922 )
Optimize PrivilegeAll permission check (#23972 )
Add the default db value for the rbac request (#24307 )
Signed-off-by: jaime <yun.zhang@zilliz.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: longjiquan <jiquan.long@zilliz.com>
2023-06-25 17:20:43 +08:00
wei liu
0d51f55c48
enable config each collection has different rate limit ( #24139 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-06-21 15:02:42 +08:00
congqixia
41af0a98fa
Use go-api/v2 for milvus-proto ( #24770 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-09 01:28:37 +08:00
xige-16
732fe54775
Support partition Key ( #24047 )
...
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-06-06 10:24:34 +08:00
cai.zhang
008285f849
Support dynamic schema for create collection ( #24176 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-05-18 09:33:24 +08:00
SimFG
ef82e0f1a4
Fix the error when a role removes an already deleted user ( #24049 ) ( #24109 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-05-16 10:15:22 +08:00
yihao.dai
f1cc31ceee
Fix creating partition is not atomic ( #23823 )
...
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-08 10:18:39 +08:00
Jiquan Long
c955c26656
Optimize log when rootcoord goroutine quit ( #23698 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-04-29 16:06:42 +08:00
Jiquan Long
adfa415b74
Optimize log trace ( #23431 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-04-17 11:00:30 +08:00
cai.zhang
43a9e175a3
Exit component process when session key is deleted ( #21658 ) ( #22164 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-04-12 20:12:28 +08:00
jaime
c9d0c157ec
Move some modules from internal to public package ( #22572 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-04-06 19:14:32 +08:00
yah01
fa2c1c1f40
Fix RootCoord double updates TSO ( #22715 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-03-13 18:01:53 +08:00
yah01
e1cb307690
Refine RootCoord services error handle ( #22689 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-03-13 14:29:53 +08:00
yah01
be33911205
Refine RBAC init error handle ( #22537 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-03-13 10:59:53 +08:00
wayblink
28390dfe09
Add bulkinsert integration test ( #22621 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-03-10 11:03:52 +08:00
Enwei Jiao
697dedac7e
Use cockroachdb/errors to replace other error pkg ( #22390 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-02-26 11:31:49 +08:00
zhenshan.cao
e768437681
Correct usage of Timer and Ticker ( #22228 )
...
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2023-02-23 18:59:45 +08:00
cai.zhang
66b3566ac1
Update component state to healthy after start ( #22118 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-02-10 17:40:32 +08:00
yah01
b1f31da77a
Fix activate standby server ignores all errors ( #22073 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-02-09 15:24:31 +08:00
Xiaofan
f1daef22a1
Fix failed bulkload segment marked as sealed ( #21799 )
...
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2023-01-31 12:41:53 +08:00
cai.zhang
bcae97b125
Register after start to prevent there are tow coordinator at the same time ( #21641 ) ( #21707 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-01-30 11:11:50 +08:00
jaime
1dcd9eeb79
Support rename collection ( #21693 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-01-19 14:13:43 +08:00
groot
0af53d1e2e
Fix bulkinsert report bug ( #21778 )
...
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-01-18 10:33:43 +08:00
Enwei Jiao
90d9e165d4
Fix some configs not shown ( #21653 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-01-13 15:31:41 +08:00
wayblink
6a722396bd
Integration test framework ( #21283 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-01-12 19:49:40 +08:00
SimFG
b307ee8c07
Make the rbac error message clearer ( #21645 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-01-12 13:55:42 +08:00
Ten Thousand Leaves
23ceb9c638
Remove index checking phase for bulk insert ( #21578 )
...
/kind improvement
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2023-01-09 21:15:38 +08:00
cai.zhang
e5f408dceb
Merge IndexCoord and DataCoord ( #21267 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-01-04 19:37:36 +08:00
yah01
7b39873ae0
limit the frequency of GetMetrics() log ( #21514 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-01-04 17:39:35 +08:00
Jiquan Long
ff2a68e65a
Fix collection not exist when tried to do recovery ( #21471 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-01-04 16:37:35 +08:00
Ten Thousand Leaves
30b86275ac
Make BulkInsert free DataNode workload when import segments are flushed ( #21253 )
...
/kind improvement
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-12-28 11:11:30 +08:00
wayblink
28b44b781f
Update healthz to support standby state and fix rootcoord active-standby ( #21078 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2022-12-27 12:47:34 +08:00
aoiasd
de0ab9e2cf
Refactor showConfigurations to allow return global config rather than only return config of this component ( #21063 )
...
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2022-12-09 14:31:21 +08:00
Enwei Jiao
89b810a4db
Refactor all params into ParamItem ( #20987 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-12-07 18:01:19 +08:00
Jiquan Long
5a6a92d603
Refine log level ( #20896 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-11-30 14:11:15 +08:00
SimFG
c6fc1511aa
Update the error message for the rabc method ( #20740 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-11-29 20:05:14 +08:00
Enwei Jiao
c05b9ad539
Add event dispatcher for config ( #20393 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-11-17 18:59:09 +08:00
smellthemoon
7325b3e1c3
Substitute traceid for msgid in rpc ( #20450 )
...
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2022-11-14 15:29:06 +08:00
Xiaofan
af66a0b621
Fix Time Tick session2ChanTs map use the same nodeID ( #20537 )
...
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-11-14 14:41:11 +08:00
Jiquan Long
cc9dc0f0fa
Fix log of RootCoord ( #20412 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-11-09 15:07:03 +08:00
Enwei Jiao
7e56e7a976
Fix datarace at Setlogger ( #20376 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-11-08 14:33:03 +08:00
groot
b847c425e1
Fix listImportTasks bug ( #20301 )
...
Signed-off-by: yhmo <yihua.mo@zilliz.com>
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2022-11-07 17:11:02 +08:00
Enwei Jiao
956c5e1b9d
Make Params singleton ( #20088 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-11-04 14:25:38 +08:00
Jiquan Long
89541a6f68
Revert parallel ddl ( #20118 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-10-28 13:25:34 +08:00
groot
bee66631e3
Refine bulkload ( #19671 )
...
Signed-off-by: yhmo <yihua.mo@zilliz.com>
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2022-10-27 16:21:34 +08:00
Jiquan Long
7a13b1c329
Fix panic when stop rootcoord ( #20019 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-10-25 09:51:30 +08:00