Commit Graph

18485 Commits (d9a9eefa49b9972e7c704506900b14523b678528)

Author SHA1 Message Date
zhuwenxing d9a9eefa49
test: add bulk insert benchmark for different file size (#29329)
add bulk insert benchmark for different file size

pr: https://github.com/milvus-io/milvus/pull/29320

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-20 14:38:40 +08:00
Jiquan Long 8ef0c571b3
enhance: make consistency level used in delete configurable (#29280) (#29284)
pr: #29280 
issue: #29279

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-20 14:14:34 +08:00
cai.zhang 3182b9df5b
fix: [Pick]Set the default index name to the name of the existing index (#29281)
issue: #29269 
master pr: #29275

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-20 14:10:40 +08:00
nico f1ed04bee7
enhance: update pymilvus version and test case (#29294)
pr: #29267

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-12-20 09:26:49 +08:00
yah01 cd9e3c4837
fix: creating growing segments may introduce many threads (#29314)
many growing segments may be created in a short time and there is no
restriction to the process, the CGO call will leave many threads

related: https://github.com/milvus-io/milvus/issues/29282
pr: #29306

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-19 18:02:40 +08:00
aoiasd af54ce9e20
fix: [Cherry-pick] msgstream memory leak caused by config event don't deregister (#29268)
pr: https://github.com/milvus-io/milvus/pull/29266
relate: https://github.com/milvus-io/milvus/issues/28620

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-19 12:34:39 +08:00
wei liu 2d33c7fe41
enhance: Add config for querycoord auto balance channel (#29231) (#29262)
issue: #23726
pr: #29231
This PR add control config to querycoord's background auto balance
channel operation

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-18 14:32:41 +08:00
PowderLi 9af24da65a
fix: rootCoord decide the builtin role cannot be deleted (#29248)
issue: #29243

only rootCoord read the configuration item `builtinRoles`, so proxy
never know whether the role to be deleted is builtin.

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-18 14:22:42 +08:00
zhuwenxing 08877e56f7
test: fix gen array field (#29247)
fix gen array field

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-18 11:30:46 +08:00
PowderLi 4ab02da3ac
enhance: RESTFUL search api support range search (#29097)
issue: #29004
master pr: #29055

add a new parameter: `params`, which is a map[string]float64;
but now only 2 valid item: radius + range_filter;

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-17 23:14:45 +08:00
congqixia 9a80dc666b
fix: flushTs is never reset in channelMeta (#29244)
See also #29156
FlushTs need to to be reset to MaxUint64 after channel checkpoint is
after this timestamp. Otherwise, the segment will be shattered and flush
queue will be filled with tasks

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-16 14:00:38 +08:00
congqixia 49c9dc4923
fix: [cherry-pick] balance_unstable_view unit test (#29127) (#29249)
Cherry-pick from master
pr: #29127
fix: #29126
Allow unstable output channel balance plan

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-16 00:16:39 +08:00
congqixia 4e8409e7dc
enhance: [cherry-pick] ignore proto generated files (#29250)
Cherry-pick from master
pr: #28537
ignore proto generated files
issue: #28566

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: sunby <sunbingyi1992@gmail.com>
2023-12-15 22:46:39 +08:00
XuanYang-cn 7facaa0c40
fix: [Cherry-pick] fix unstable ConsistencyHashPolicy ut (#28375) (#29235)
Fixes: #28372, #29234
pr: #28375

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-15 18:34:38 +08:00
Cai Yudong 0a2c38d942
enhance: Remove omp from segcore (#29236)
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
2023-12-15 16:12:38 +08:00
XuanYang-cn 7b0599765f
fix: [cherry-pick]Skip updating checkpoint after dropcollection (#29221)
pr: #29220

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-15 16:04:45 +08:00
wei liu 97d71c2580
enhance: Skip balance segment when channel need be balanced (#29116) (#29232)
issue: #28622
pr: #29216
After we support balance segment with growing segment count #28623, if
we balance segment and channel at same time, some segments need to be
rebalanced after balance channel finish.

This PR skip balance segment when channel need be balanced.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-15 15:58:37 +08:00
congqixia ea688846d8
enhance: [cherry-pick] make `conc.Pool` resizable (#29225)
See also #29223
cherry pick part of master commit
pr: #29224
Make `conc.Pool` resizable by adding Resize method for it.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-15 15:28:38 +08:00
cai.zhang 966487962a
enhance: [Pick] Set default index name as field name (#29219)
master pr: #29218

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-15 12:02:37 +08:00
wei liu e8a480c28d
enhance: Enable balance channel in querycoord (#28469) (#29209)
issue: #23726
pr: #28469

1. enable auto balance channel between nodes in querycoord
2. make `genSegmentPlan` reuse the `AssignSegment` logic
3. make `genChannelPlan` reuse the `AssignChannel` logic

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-15 11:52:38 +08:00
congqixia d8d699401b
enhance: [cherry-pick] Add http method to control datacoord garbage collection (#29212)
Cherry-pick from master
pr: #29052
See also #29051

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi.Xia <congqi.xia@zilliz.com>
2023-12-15 02:16:38 +08:00
zhuwenxing 368a0cd55d
test: add more request type checker for test (#29211)
add more request type checker for test
pr: https://github.com/milvus-io/milvus/pull/29210

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-14 19:38:45 +08:00
zhuwenxing 6bf32d2f2b
test:add array data type and parquet file type for bulk insert case (#28990)
pr: https://github.com/milvus-io/milvus/pull/29030

add array data type and parquet file type for bulk insert test case

---------

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-14 19:36:39 +08:00
congqixia 7d2fa93ee8
enhance: [cherry-pick] remove reset seed for every shuffle (#29196)
Cherry-pick from master
pr: #29195
See also #29113
rand.Seed is deprecated and cost noticable CPU time during heavy payload

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 17:38:37 +08:00
yah01 5a8ddde92a
fix: load gets stuck probably (#29191) (#29192)
we found the load got stuck probably, and reviewed the logs.

the target observer seems not working, the reason is the taskDispatcher
removes the task in a goroutine, and modifies the task status after
committing the task into the goroutine pool, but this may happen after
the task removed, which leads to the task will never be removed

related #29086
pr: #29191

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-14 16:56:38 +08:00
wei liu 7ef49adbd2
enhance: Use mockery to replace manual mock code (#29074) (#29182)
issue: #29043
pr: #29074
This PR remove mannul mock code for proxy and data coord

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-14 16:44:43 +08:00
SimFG 32eb6380a5
fix: [2.3] missing the grant info when using the SelectGrant api with the default db (#29174)
issue: https://github.com/milvus-io/milvus/issues/29172
pr: #29173

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-14 16:20:43 +08:00
wei liu 9092b1ae8a
feat: enable balance based on growing segment row count (#28623) (#29184)
issue: #28622 
pr: #28623
query node with delegator will has more rows than other query node due
to delgator loads all growing rows.
This PR enable the balance segment which based on the num of growing
rows in leader view.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-14 15:26:37 +08:00
congqixia efef573c67
enhance: [cherry-pick] Add a config item for partition name as regexp feature (#29154) (#29183)
Cherry pick from master
pr: #29154 
See also #29177
Add a config item for partition name as regexp feature and disable it by
default

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 14:46:37 +08:00
wayblink 7946c2a8dc
fix: [cherry-pick] bulkinsert binlog didn't consider ts order when processing delta data (#29176)
issue: #29162
pr: #29163

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-14 14:38:38 +08:00
congqixia a108bf7bc1
enhance: improve datanode channel checkpoint source log (#29180)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 14:34:38 +08:00
XuanYang-cn d3cb489154
enhance: Change channel to Interface (#27839) (#29161)
This PR changes `*channel` into RWChannel interface

See also: #25309
pr: #27839

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-14 11:50:36 +08:00
SimFG c2ce7bce1a
fix: [2.3] the unstable unit test TestReplicateManager (#29147)
/kind improvement
pr: #28718

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-13 10:46:44 +08:00
congqixia 78865c02e1
enhance: [cherry-pick] Use zap.Stringer for large log field (#29143) (#29153)
Cherry pick from master
pr: #29143
See also #29113
Using zap.Stringer log field will evaluate log field value only when log
level meets the configuration, which could save some CPU time in search
route

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-13 09:48:38 +08:00
yah01 76757e53c4
enhance: Add more logs for target updating (#29090) (#29141)
This pull request enhances the logging functionality in the code related
to target updating. It adds more logs about the condition satisfying
when updating the target. The logs provide additional information about
the collection ID, replica number, channel readiness, segment readiness,
and leader view readiness. These logs will help in troubleshooting and
monitoring the target updating process.

pr: #29090

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-12 22:28:38 +08:00
Jiquan Long 00e6160848
fix: autoindex panic with flat index type (#29071) (#29072)
issue: https://github.com/milvus-io/milvus/issues/29048
pr: https://github.com/milvus-io/milvus/pull/29071

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-12 22:08:45 +08:00
wei liu 286dce0d3a
enhance: Add config for auto upgrade segment index (#29112) (#29133)
pr: #29112
This PR add config for auto upgrade segment index to index engine's
version.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-12 17:26:38 +08:00
Enwei Jiao 1e2a0dd127
enhance: Support otlp with insecure (#29131)
pr: https://github.com/milvus-io/milvus/pull/29115

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-12-12 16:44:37 +08:00
Jiquan Long c77fe38c39
fix: txn control not applied to snapshot.Remove (#29124) (#29137)
issue: #29123
pr: #29124 

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-12 16:37:44 +08:00
PowderLi 04d351e4bb
fix: wait server to listen the http port (#29076)
issue: #29068
master pr: #29075

wait server to listen the http port
then check whether various urls can be accessed normally

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-12 16:24:37 +08:00
yah01 4334e4e7ad
enhance: remove merger for load segments (#29062) (#29064)
remove merger as now QueryNode could load segments concurrently
fix https://github.com/milvus-io/milvus/issues/29063
pr: #29062

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-12 16:22:50 +08:00
cai.zhang bd46dc2d1b
enhance: [Pick]Support implicit type conversion for parquet (#29119)
issue: https://github.com/milvus-io/milvus/issues/29019
master pr: #29046

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-12 16:14:43 +08:00
wayblink af6714ef59
fix: [cherry-pick] fix rootcoord_collection_num metric is twice the real value (#29105)
pr: #28666

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-12 14:06:43 +08:00
wayblink e49860cb80
feat: Introduce channelCheckpointUpdater to reduce goroutine in ttNode (#29107)
pr: #28570

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-12 13:48:42 +08:00
PowderLi 92db41518d
enhance: upgrade proto to use partition related privileges (#29100)
issue: [milvus-proto
#212](https://github.com/milvus-io/milvus-proto/issues/212)
master pr: #28961

milvus can't use partition related privileges until upgrade
milvus-proto, even if them were added to milvus-proto

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-12 13:22:38 +08:00
nico 30ec598a08
test: modify cases for the update of IVF_FLAT (#29069)
pr: #27179

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-12-12 11:48:36 +08:00
congqixia d36bf21f28
enhance: [cherry-pick] Avoid initializing casbin enforcer for each request (#29118)
Cherry-pick from master
pr: #29117 
See also #29113

This patch:
- Replace plain Enforcer with `casbin.SyncedEnforcer`
- Add implementation of persist.Adapter with `MetaCacheCasbinAdapter`
- Invoke enforcer.LoadPolicy when policy updated

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-12 10:36:43 +08:00
congqixia 0b532b42ea
enhance: [cherry-pick] Add client connect wrapper to keep connection alive (#29061)
Cherry-pick from master
pr: #29058
See also #29057
Add wrapper to maintain client&connection
When reset operation is needed, close method shall wait until all
on-going request return

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-08 21:12:35 +08:00
edward.zeng 273be6c77a
fix: Fix etcd healthcheck command (#28357)
Fix etcd health check command.
/kind improvement
pr: #27980 
/cc @yanliang567

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2023-12-08 17:57:23 +08:00
shaoyue ac0f000c29
enhance: Add proxy.ginLogSkipPaths (#29008)
pr: #28945

/cc @czs007

Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2023-12-08 17:55:30 +08:00