Commit Graph

414 Commits (d299fa502e53a97e005c6f6bdcbf26bde16afe80)

Author SHA1 Message Date
congqixia 394c898b4c
Discard SyncDistribution set action from legacy querycoord (#27027)
Since Milvus in lower version (< 2.3.0), there is no load info in set action
which may corrupt data integrity and cause panicking

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-13 09:35:18 +08:00
yah01 00c65fa0d7
Refine QueryNode errors (#27013)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-12 16:07:18 +08:00
aoiasd e107d0794c
support complex delete expression (#25752)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-09-12 10:19:17 +08:00
congqixia ac45af585b
Make segment loaded successful put in manager even ctx done (#26992)
Leave segment loaded in manager even wait other segment failed
See also #26908
Fix error case in distributed scenario

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-11 21:33:18 +08:00
congqixia 2a5d574a0d
Fix querynodev2 concurrent load logic (#26959)
Fix logic error from #26926
function `waitSegmentLoadDone` shall return error when context is done

Make delegator control concurrency for each same segment
Related to #26908

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-10 07:41:18 +08:00
congqixia c6116d1819
Remove segment to LocalSegment type assertion (#26931)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-09 10:35:16 +08:00
congqixia c8f9f22c4a
Fix segment loader return false success (#26926)
`waitSegmentLoadDone` did not check waitCh result is success or failure
after load return without error, delegator will assume all segments are loaded

This PR changes waitCh to loadResult with `sync.Cond` with `atomic.Int32` to represent status

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-08 16:41:16 +08:00
Xu Tong 9166011c4a
Add float16 vector (#25852)
Signed-off-by: Writer-X <1256866856@qq.com>
2023-09-08 10:03:16 +08:00
XuanYang-cn 7f1ae35e72
Add timeout in dispatcher, AsConsumer and Seek (#26686)
See also: #25309

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-09-08 09:51:17 +08:00
congqixia af5c01082b
Refine delegator lifetime control (#26881)
- Add SafeChan interface in lifetime package
- Embed SafeChan into  interface
- Replace private lifetime struct in delegator package with
- Refine delegator on-going task lifetime control and wait all accepted task done
- Fix potential goroutine leakage from  if delegator closed concurrently

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-07 10:11:15 +08:00
SimFG 28681276e2
Improve the retry of the rpc client (#26795)
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-06 17:43:14 +08:00
MrPresent-Han 528948559f
fix false load failure for long unserviable period(#26813) (#26818)
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-09-06 12:57:15 +08:00
Enwei Jiao fb0705df1b
Decouple basetable and componentparam (#26725)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-09-05 10:31:48 +08:00
congqixia 4b58c71908
Add ctx parameter for organizeTask and GetWorker method (#26835)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-05 10:05:48 +08:00
congqixia 1a8cf5c415
Organize all mockery generation commands in Makefile (#26826)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-04 21:19:48 +08:00
yah01 3349db4aa7
Refine errors to remove changes breaking design (#26521)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-04 09:57:09 +08:00
congqixia e8f1b1736e
Remove log.Error(err.error())-style log (#26783)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-01 13:09:01 +08:00
XuanYang-cn ef75784715
Fix LoadSegmentLatency metric p99 (#26761)
See also: #26743

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-09-01 11:07:07 +08:00
MrPresent-Han 8330c18dc9
add log for loading segment(#26564) (#26640)
/kind improvement

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-08-31 12:03:00 +08:00
Gao 7e36f819b4
Make autoindex config clean (#26732)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-08-31 10:25:01 +08:00
yah01 bfcc691129
Fix segment leaked if task canceled (#26685)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-30 14:17:03 +08:00
congqixia 95dcf7fa06
Fix memory leak when Put duplicated segments (#26693)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-30 11:37:00 +08:00
congqixia 89fc9aad82
Improve sync target version logic (#26630)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-29 23:12:27 +08:00
congqixia 1cf6e00fa6
Improve segment manager interface (#26637)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-29 15:46:27 +08:00
wei liu 7af0f7d90c
avoid concurrent sub/unsub on same channel (#26454)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-08-23 10:10:22 +08:00
Xiaofan 7b3a1dc93f
Fix load index panic (#26457)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2023-08-21 09:56:20 +08:00
wei liu 3b11ad2695
fix dead lock in concurrent search/release segment (#26435)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-08-18 15:28:18 +08:00
cqy123456 fd37860e57
init knowhere build/search thread pool; (#26449)
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2023-08-18 14:00:19 +08:00
yihao.dai 63b86b32a6
Add server id validation interceptor (#26395)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-08-17 20:20:20 +08:00
congqixia 123ad921e0
Fix querynodev2 search/query segments return unexpected grpc err (#26341)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-17 18:24:18 +08:00
Xiaofan ba806429fa
Remove frequent log on search growing segment (#26315)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2023-08-17 15:44:53 +08:00
congqixia 855a04539a
Set delegator lastUpdateTs to startTs (#26416)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-17 12:24:18 +08:00
yah01 5dae6a654a
Protect segment from being released while query/search (#26322)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-16 18:38:17 +08:00
yah01 3d8871b30e
Fix data race while updating segment version (#26387)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-16 16:30:18 +08:00
MrPresent-Han d30a920226
add log trace for segcore(#26277) (#26339)
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-08-16 11:41:33 +08:00
wei liu 23baecd70f
set sealed segment to unreadable before sync target version (#26338)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-08-15 17:27:35 +08:00
congqixia ec65a4e048
Use float64 for resource estimation log (#26335)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-15 14:25:33 +08:00
Enwei Jiao 7d61355ab0
Refactor log for Query (#26310)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-08-14 18:57:32 +08:00
yah01 a173486d2e
Fix calculation of memory usage prediction for mmap mode (#26264)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-12 17:19:31 +08:00
Gao 9ca8f28005
Fix missing totalChannelNum bug (#26295)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-08-11 18:35:29 +08:00
yah01 48422dd4c5
Fix spawn too many threads (#26293)
- Low the thread pool cap
- Limit CGO calls concurrency

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-11 18:29:29 +08:00
Gao b6fcbb0998
Support ScaNN index (#26099)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-08-11 14:21:29 +08:00
wei liu b47a72bfcf
fix set dirty segment distribution to leader view (#26180)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-08-11 11:21:32 +08:00
xige-16 1971d98897
Add disk metric info (#25675)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-08-11 10:35:42 +08:00
Enwei Jiao ca1349708b
Remove time travel ralted testcase (#26119)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-08-10 18:53:17 +08:00
xige-16 1055c90456
Add default retrieve limit (#24782)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-08-10 14:11:15 +08:00
yah01 300fef446b
Enable mmap for vector index (#25877)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-10 13:59:15 +08:00
yah01 889424b3f9
Fix load index with empty file list (#26236)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-09 18:39:16 +08:00
congqixia eea9197306
Perform alter distribution under mutex protection (#26229)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-09 13:05:15 +08:00
wei liu f33a89387f
enable config shard level cost metrics whether contains worker's cost (#26132)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-08-09 11:37:15 +08:00
yah01 99c633954a
Downgrade the log level in search path (#26188)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-08 18:35:14 +08:00
Bingyi Sun 54c0e64059
Fix search on empty segments set bug (#26136)
Signed-off-by: sunby <sunbingyi1992@gmail.com>
2023-08-08 11:17:08 +08:00
MrPresent-Han 68ecf49ed5
fix lost parameter for threadCoefficient(#25781) (#26109)
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-08-03 12:05:06 +08:00
yah01 d9074bcb06
Remove unused code (#26100)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-08-03 09:45:05 +08:00
MrPresent-Han 5634ba777d
add new threadpool with various priority to avoid deadlock(#25781) (#26028)
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-08-03 09:31:07 +08:00
smellthemoon 3fc18c53a3
Fix wrong log (#26022)
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-08-02 11:01:07 +08:00
yah01 9c55a7f422
Add worker num as one of load resource (#26045)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-08-01 21:47:06 +08:00
Jiquan Long 5c1f79dc54
Push down the limit operator to segcore (#25959)
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-08-01 20:29:05 +08:00
aoiasd 7fec0d61cc
Refine test chunkmanager of querynode v2 (#25888)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-08-01 10:33:04 +08:00
congqixia 8b5e276361
Use different cgo pool for SQ and other operations (#26021)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-01 09:19:05 +08:00
yah01 39b00b97a6
Add more logs for committed resources (#26026)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-31 19:27:03 +08:00
yah01 8245e078c0
Add max segment size log (#26015)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-31 14:37:04 +08:00
zhagnlu 833674c1cb
add glog configurable function and redirect aws log to segcore log (#25664)
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-07-27 19:49:02 +08:00
congqixia 5fbe6e99fd
Remove debug log from segment loader (#25937)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-26 18:51:01 +08:00
wei liu 302897f866
refine look aside balance logic (#25837)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-25 18:51:01 +08:00
yah01 3735a097e6
Refine the memeory usage prediction (#25889)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-25 17:41:01 +08:00
congqixia 0bc03ede0d
Add eventlog pkg and support grpc streaming event observation (#25812)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-25 17:23:01 +08:00
wei liu a132122370
fix time unit in insert/delete cost metrics value (#25893)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-25 15:07:01 +08:00
aoiasd b533c68632
Forbid update checkpoint without msgID (#25694)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-07-25 10:43:04 +08:00
wei liu 0e26486abc
fix segment num in log (#25876)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-25 09:13:00 +08:00
yah01 168f346620
Remove deprecated interface (#25864)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-07-24 17:47:00 +08:00
wei liu fc19b85a40
fix count(*)retrieve redundant growing segment (#25825)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-24 14:09:00 +08:00
wei liu 32827f538a
add metrics for delegator insert/delete cost (#25733)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-21 15:30:59 +08:00
yah01 361db51337
Create dir if mmap enabled for validating path (#25750)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-19 18:48:58 +08:00
Cai Yudong 9a4761dcc7
Remove binary metrics TANIMOTO/SUPERSTRUCTURE/SUBSTRUCTURE (#25708)
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
2023-07-19 16:16:58 +08:00
yah01 079cd9dc70
Add caller skip to improve the log for segcore error (#25710)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-18 19:54:57 +08:00
congqixia cc71e065e3
Support load index after segment loaded (#25567)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-18 10:51:19 +08:00
congqixia c490b30db7
Fix segment loader skip wait if all segments are loading (#25643)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-17 19:51:18 +08:00
MrPresent-Han 49655d2f13
fix panic due to lack of indexInfo on querynode(#25362) (#25613)
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-07-17 19:23:19 +08:00
yah01 948d1f1f4a
Handle errors by merr for QueryCoord (#24926)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-17 14:59:34 +08:00
Zhihong Yu a7023ab3cc
Narrow the scope of deleteMut lock in loadStreamDelete (#25436)
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
2023-07-17 09:30:34 +08:00
wei liu b62c82af22
fix set target version in loading sealed segment (#25603)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-14 20:00:31 +08:00
congqixia f2b14b43de
Add log field for local worker call (#25594)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-14 17:34:31 +08:00
congqixia a7e6f08183
Fix DeleteCollection not protected (#25599)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-14 17:04:31 +08:00
Enwei Jiao 66fdc71479
Refactor logs in DataCoord & DataNode (#25574)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-07-14 15:56:31 +08:00
yah01 d216f9abda
Clear collection meta after all channels/segments released (#25486)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-14 10:28:30 +08:00
yiwangdr b9189b9f41
Organize mocks from types.go (#25466)
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-07-14 10:12:31 +08:00
wei liu b72809db15
fix release sealed segment on unwatch channel (#25555)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-13 14:30:29 +08:00
yah01 205a7c430a
Fix QueryNode panic while inserting to released segment (#25495)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-12 19:48:29 +08:00
SimFG f9e2d00f91
Prevent `exclusive consumer` exception in pulsar (#25376)
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-07-12 17:26:30 +08:00
yihao.dai 4c93495587
Add segment size metric in querynode (#25406)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-07-12 14:26:28 +08:00
congqixia bcd3abf644
Separate segments/shards reduce latency metrics (#25475)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-11 18:18:28 +08:00
congqixia 5aec6036dc
Add index info in GetDataDistribution response (#25444)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-11 11:22:29 +08:00
cai.zhang 81278f4aea
Fix bug of missing JSON type when sorting retrieve results (#25412) (#25455)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-07-10 20:02:28 +08:00
congqixia 9e3a591bda
Fix segment released early in case of balancing (#25453)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-10 18:58:28 +08:00
wei liu cc730c1ee5
fix consume growing from dml after release (#25421)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-10 17:36:28 +08:00
wei liu d4704ab9b6
fix set shard unservicable when sync target version (#25418)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-07 19:32:25 +08:00
wei liu a47fc28023
fix querynode panic in get distribution (#25405)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-07 18:26:25 +08:00
congqixia f07c934558
Fix querynodev2 grace stop condition reversed (#25409)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-07 17:28:25 +08:00
wei liu b7740835fe
fix metric label for sq count metrics (#25399)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-07 14:06:25 +08:00
chyezh dc1cb54404
[Fixup] unexpected read_task_ready_len metric (#25349)
Signed-off-by: chyezh <ye.zhen@zilliz.com>
2023-07-06 20:02:29 +08:00
wei liu d5ec7dda80
fix metric label in search/query count (#25377)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-06 17:48:26 +08:00
congqixia 3f9384b515
Fix exclude segment info dml position for flushed segments (#25200)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-06 17:30:26 +08:00
yah01 3d2283415f
Fix delegator leaked (#25347)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-06 14:18:26 +08:00
yah01 dd5f896dc8
Load batch by batch (#25212)
This will significantly reduce the memory usage while loading
- 1x memory usage and MBs overhead for buffer (memory mode)
- only MBs overhead for buffer (mmap mode)

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-06 13:58:27 +08:00
yah01 4c0e36d28c
Stop blocking until all channels & segments released (#25328)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-06 10:04:25 +08:00
wei liu c84496a1ba
fix sq count metrics (#25287)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-07-06 08:46:26 +08:00
congqixia efdd71c640
Make cgo pool size larger than worker pool size (#25318)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-07-05 16:56:26 +08:00
Enwei Jiao 816158e4af
Remove outdated searchplan (#25282)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-07-04 18:30:25 +08:00
Gao 4a87b9f60a
Fix queryHook ut data race (#25306)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-07-04 15:34:25 +08:00
yihao.dai c56a26a556
Add SetMetricType and set metric only for shard leader (#25285)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-07-04 10:20:25 +08:00
chyezh d7d61f529c
[Feature|Pick] enable scheduler policy and add user-task-polling policy (#24839)
Signed-off-by: chyezh <ye.zhen@zilliz.com>
2023-07-03 18:24:25 +08:00
Gao de6e4817a2
Support dynamic tuning config (#25152)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-07-03 15:18:24 +08:00
yah01 7b5013664d
Support graceful stop (#25226)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-06-30 17:28:23 +08:00
yah01 f7ecbff986
Make merged task channel buffered (#25242)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-06-30 14:58:22 +08:00
Gao 8750be1e97
Set receive searchRequest log to debug level (#25223)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-06-29 14:04:22 +08:00
congqixia 1357ef7043
Merge get worker process for same nodeID (#25185)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-28 18:34:24 +08:00
Jiquan Long 8d193a3e56
Skip unnecessary reduce phase during search (#25166)
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-06-27 19:22:45 +08:00
wei liu 9b91519c88
fix search cost metrics on replica selection (#25059)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-06-27 19:02:44 +08:00
congqixia b3362c297a
Make snapshot.expired atomic (#25177)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-27 18:12:45 +08:00
yihao.dai 29b9b26de8
Improve get vector error msg (#24838)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-06-27 16:34:45 +08:00
wei liu 68ae199a9f
load segment with target version, avoid read redundant segment (#24929)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-06-27 11:48:45 +08:00
xige-16 33c2012675
Add more metrics (#25081)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-06-26 17:52:44 +08:00
jaime 18df2ba6fd
[Cherry-Pick] Support Database (#24769)
Support Database(#23742)
Fix db nonexists error for FlushAll (#24222)
Fix check collection limits fails (#24235)
backward compatibility with empty DB name (#24317)
Fix GetFlushAllState with DB (#24347)
Remove db from global meta cache after drop database (#24474)
Fix db name is empty for describe collection response (#24603)
Add RBAC for Database API (#24653)
Fix miss load the same name collection during recover stage (#24941)

RBAC supports Database validation (#23609)
Fix to list grant with db return empty (#23922)
Optimize PrivilegeAll permission check (#23972)
Add the default db value for the rbac request (#24307)

Signed-off-by: jaime <yun.zhang@zilliz.com>
Co-authored-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: longjiquan <jiquan.long@zilliz.com>
2023-06-25 17:20:43 +08:00
xige-16 04082b3de2
Migrate the ability to upload and download binlog to cpp (#22984)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-06-25 14:38:44 +08:00
congqixia a3630e17a0
Refine grpc Status handling: retry legacy only for Unimplemented (#25041)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-25 10:30:43 +08:00
congqixia d51e1379fe
Move loadDelta operation after needTransfer check (#24922)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-19 17:14:41 +08:00
wei liu 46f7d903a3
enable look aside balancer on replica selection (#24791)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-06-16 18:38:39 +08:00
yah01 a413842e38
Fix deleted data is still visible (#24849)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-06-16 17:16:41 +08:00
yihao.dai c7dc1c067a
Assign metric type in load segment request (#24917)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-06-16 16:50:41 +08:00
yah01 9250423288
Fix QueryNode metrics (#24916)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-06-16 16:02:39 +08:00
wei liu 75adf1df98
fix group nq metrics (#24918)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-06-15 19:50:39 +08:00
wei liu e40d95e093
add search/query request cost metrics on qn (#24413)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-06-15 14:24:38 +08:00
yihao.dai e7125672d4
Check metric type at watchChannelTask (#24860)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-06-13 22:08:38 +08:00
Gao 1f8af0596e
Fix autoindex filter bug (#24775)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-06-09 18:18:36 +08:00
yihao.dai e81eb56b92
Add metric of waiting for tSafe latency (#24765)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-06-09 11:26:35 +08:00
congqixia 41af0a98fa
Use go-api/v2 for milvus-proto (#24770)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-09 01:28:37 +08:00
aoiasd 44e5daae3a
Fix querynode read quota (#24412)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-06-08 17:24:36 +08:00
congqixia 54306a10b3
Fix confusing log while plugin is not enabled (#24741)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-08 15:40:35 +08:00
yiwangdr 37c02c9927
clean up meta interface (#24729)
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-06-08 14:18:35 +08:00
Enwei Jiao d3af451d92
Upgrade golangci-lint (#24707)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-06-07 19:34:36 +08:00
yihao.dai 711bbd6373
Check metric type before search (#24652)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-06-07 15:58:36 +08:00
yihao.dai 5f7099a9bd
Fix search failed due to metric type mismatch (#24691)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-06-06 21:40:35 +08:00
Gao ea62922829
Disable search params rewrite while searching with filter (#24625)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-06-06 14:28:35 +08:00
yah01 fb66924c90
Set metric type while init the collection (#24665)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-06-06 13:24:36 +08:00
yihao.dai b0ce4cff83
Assign metric type in search request when user has not explicitly assigned (#24591)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-06-01 18:10:32 +08:00
congqixia 31880ab427
Use conc.PoolOption instead of ants.Option (#24585)
- Add conc.PoolOption to setup conc.Pool
- Change panic default behavior
- Make future has error when job panicks

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-01 15:52:31 +08:00
yah01 1c64d0618c
Revert "Consume threads of the number of nq (#24410)" (#24554)
This reverts commit 71a7fef5c5.

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-05-31 16:41:33 +08:00
congqixia 48dff300db
Fix Get segment returns ambiguous result (#24505)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-30 12:25:28 +08:00
aoiasd c84bdcea49
merge stats log when segment flushing or compacting (#23570)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-05-29 10:21:28 +08:00
yah01 71a7fef5c5
Consume threads of the number of nq (#24410)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-05-26 17:33:27 +08:00
xige-16 fe18109aab
Clean tmp disk data when start milvus (#24404)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-05-26 15:07:26 +08:00
yihao.dai 5f84923bfa
Fix search/query unloaded data (#24368)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-26 15:01:26 +08:00
congqixia 165734de4e
Add unit test for invoking method after segment released (#24414)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-26 10:03:27 +08:00
yihao.dai 014387fd94
Forbid to get quantized vector from ChunkManager (#24334)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-24 23:03:27 +08:00
Bingyi Sun 0c8045d66c
Fix crash caused by segment function concurrency (#24351)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
2023-05-24 19:23:27 +08:00
yihao.dai e49df11942
Fix QueryNode is not able to recovery (#24335)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-24 14:29:29 +08:00
yah01 abd250da09
Fix QueryNode is not able to recovery (#24300)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-05-23 17:17:26 +08:00
wei liu ce03248b1a
simplify logic circle in search (#24110)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-05-23 16:01:26 +08:00
yihao.dai 45aa9779e0
Retrieve segments concurrently (#24245)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-19 18:19:24 +08:00
yihao.dai 1a3dca9b5e
Fix dynamic partitions loading (#24112)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-18 09:17:23 +08:00
MrPresent-Han b74770b636
support try-best query reducer methods(#24075) (#24103)
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-05-17 16:23:23 +08:00
yihao.dai 7384d83d2c
Support rate limit based on growing segments size (#24121)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-17 09:57:22 +08:00
congqixia 73a181d226
Fix get vector it timeout and improve some string const usage (#24141)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-16 17:41:22 +08:00
yah01 3ea4a39078
Fix insert node doesn't handle JSON data while merging (#24126)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-05-16 16:09:23 +08:00
congqixia a960cc2a1b
Fix data race in pipeline/manager (#24127)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-16 15:17:23 +08:00
congqixia df7848cf79
Fix querynode consume ts lag metrics (#24119)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-16 09:59:26 +08:00
congqixia eb27a8a8c0
Fix integration test not wait for index built (#24037)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-12 09:51:25 +08:00
yah01 400364483d
Improve predict the resource usage (#23968)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-05-11 15:33:24 +08:00
smellthemoon 146050db82
Fix some wrong ut (#23990)
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-05-10 09:31:19 +08:00
yihao.dai 7e0d1492c7
Load delete from channel checkpoint (#23961)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-09 19:10:41 +08:00
yihao.dai 426ed30d2d
Log optimized search params (#23930)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-09 10:12:42 +08:00
yihao.dai f0eb5e8563
Fix partition released but can be searched (#23872)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-06 17:42:39 +08:00
congqixia 884f7904a1
Re-calculate segment entry num when binlog field is zero (#23883)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-06 14:24:39 +08:00
yihao.dai 02734d9eb0
Fix ignoring error when loading segment (#23830)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-04 15:10:39 +08:00
yihao.dai 4b26c0afb3
Add collection in querynode when sync new partitions (#23825)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-05-01 16:36:38 +08:00
Gao e467e0d451
Seperate reading build and load params for diskann (#23758)
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-04-27 20:30:35 +08:00
yah01 eab94489ba
Refine the merge algorithm (#23767)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-27 18:26:35 +08:00
smellthemoon f0ababb420
Use merr in querynodev2 (#23652)
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-04-26 17:06:34 +08:00
foxspy 6f4ed517de
add growing segment index (#23615)
Signed-off-by: xianliang <xianliang.li@zilliz.com>
2023-04-26 10:14:41 +08:00
yah01 f8ff97fe29
Fix travel timestamp set unique leads to disable task merge (#23605)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-25 19:04:34 +08:00
yihao.dai 092d743917
Add support for getting vectors by ids (#23450)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-04-23 09:00:32 +08:00
yah01 546080dcdd
Support to retrieve json (#23563)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-21 11:46:32 +08:00
yah01 71364056f9
Fix QueryNode may report succeeded to unsubscribe channel early (#23580)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-20 19:30:33 +08:00
LeoReeYang a2ab94ec3d
remove unused code. (#23572)
Signed-off-by: LeoReeYang <LeoReeYang@outlook.com>
2023-04-20 17:56:32 +08:00
Enwei Jiao 967a97b9bd
Support json & array types (#23408)
Signed-off-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
2023-04-20 11:32:31 +08:00
congqixia 4fe363c4b2
Add KNN cgo pool (#23526)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-19 23:56:31 +08:00
yah01 c7c89511b6
Fix data race of timerecord (#23524)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-19 14:18:30 +08:00
congqixia eb690ef033
Fix querynodev2 stop logic (#23487)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-18 17:56:30 +08:00
wei liu 3ad9ff7a9a
fix release segment failed (#23462)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-04-17 18:46:30 +08:00
cqy123456 7ff6a3a246
Set query node thread pool size in milvus.yaml (#23286)
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2023-04-17 10:44:29 +08:00
yah01 7c4cafc83c
Fix task merge doesn't work (#23405)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-14 18:18:29 +08:00
congqixia a9a5f76f74
Fix AddDistribution unit test (#23418)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-13 20:46:29 +08:00
yah01 dc0eb433ae
Add IoPoolSize config (#23360)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-13 14:50:28 +08:00
cai.zhang 43a9e175a3
Exit component process when session key is deleted (#21658) (#22164)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-04-12 20:12:28 +08:00
congqixia 6cd73d4e2a
Wait safe signal before release growing (#23358)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-11 17:56:31 +08:00
Jiquan Long ad7f3d4c3e
Support Count(*) on querynodev2 (#23321)
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-04-11 15:40:31 +08:00
congqixia 0527d2706c
Fix offline set always nil (#23340)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-11 14:42:30 +08:00
MrPresent-Han ba02e70301
fix bug when syncing distribution without schema and remove unused logic(#23085) (#23216)
Signed-off-by: MrPresent-Han <jamesharden11122@gmail.com>
2023-04-07 19:32:29 +08:00
jaime c9d0c157ec
Move some modules from internal to public package (#22572)
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-04-06 19:14:32 +08:00
congqixia 8db24e0a83
Support queryHook in querynodev2 (#23140)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-06 14:32:29 +08:00
congqixia 424570b2b8
Remove annoy related unit tests (#23229)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-05 08:14:28 +08:00
congqixia 3af3fe52d8
Remove partition target check in querynodev2 (#23188)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-04 13:36:32 +08:00
congqixia 42168f67fc
Add OWNERS file for qnv2 (#23196)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-03 16:22:24 +08:00
congqixia e3e3ac1525
Use peek segment info in querynodev2 (#23183)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-04-03 16:10:24 +08:00
yah01 2a760c108c
Add metrics for QueryNodeV2 (#23163)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-03 15:24:24 +08:00
yihao.dai b6f69fe7f2
Check if loaded before delegator search/query (#23162)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-04-03 14:26:23 +08:00
yihao.dai 9cecdc4f4e
Fix querynode panic (#23181)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-04-03 14:18:24 +08:00
smellthemoon 22aeb72eba
Fix LoadSegment req don't fill in collection id (#23136)
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-03-31 11:28:23 +08:00
Enwei Jiao 50dab2d394
Add tracing for retrieve (#23033)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-03-29 18:10:02 +08:00
aoiasd 970dcb3161
Fix panic because timestamp was nil (#23096)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-03-29 17:20:04 +08:00
wei liu e2096965c7
fix leader view (#23038)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-03-29 14:06:02 +08:00
yah01 826c1fb850
Support mmap on QueryNodeV2 (#23073)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-03-28 21:30:05 +08:00
yah01 081572d31c
Refactor QueryNode (#21625)
Signed-off-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: aoiasd <zhicheng.yue@zilliz.com>
2023-03-27 00:42:00 +08:00