milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make snapshot.expired atomic (#25177) 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/25147/head
congqixia 2023-06-27 18:12:45 +08:00 committed by GitHub
parent b7ecb7f56b
commit b3362c297a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/querynodev2/delegator/snapshot.go
View File

@ -54,7 +54,7 @@ type snapshot struct {
inUse atomic.Int64
// expired flag
expired bool
expired atomic.Bool
}
// NewSnapshot returns a prepared snapshot with channel initialized.
@ -71,7 +71,7 @@ func NewSnapshot(sealed []SnapshotItem, growing []SegmentEntry, last *snapshot,
// Expire sets expired flag to true.
func (s *snapshot) Expire(cleanup snapshotCleanup) {
s.expired = true
s.expired.Store(true)
s.checkCleared(cleanup)
}
@ -118,7 +118,7 @@ func (s *snapshot) Done(cleanup snapshotCleanup) {
// checkCleared performs safety check for snapshot closing the cleared signal.
func (s *snapshot) checkCleared(cleanup snapshotCleanup) {
if s.expired && s.inUse.Load() == 0 {
if s.expired.Load() && s.inUse.Load() == 0 {
s.once.Do(func() {
// first snapshot
if s.last == nil {