Commit Graph

5158 Commits (bb6cd4b4848b09f6f2f9706147e43abf9ceaa968)

Author SHA1 Message Date
zhenshan.cao eae0747f14
Fix bug: data race caused by read and write Params.DataNodeCfg.NodeID (#16478)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-04-13 20:09:34 +08:00
Ji Bin a5ac637ba5
Adaptation windows for Knowhere 1.1.3 (#16444)
fixes #16443

Signed-off-by: Ji Bin <matrixji@live.com>
2022-04-13 14:39:34 +08:00
godchen 4781db8a2a
Add datanode import (#16414)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2022-04-12 22:19:34 +08:00
zwd1208 a2011c1f25
Add env variable for metrics port (#16465)
Signed-off-by: Weida Zhu <weida.zhu@zilliz.com>
2022-04-12 20:11:34 +08:00
jaime ed3c29eae7
Support Kafka (#16149)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-04-12 19:47:33 +08:00
Ten Thousand Leaves 442c73a544
Support passing channel names to DataNode (#16424)
/kind feature

issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-04-12 13:25:34 +08:00
Cai Yudong 70bd6b6e6d
Remove dependency on knowhere::scalar (#16458)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-04-12 09:49:33 +08:00
codeman 4e12271d79
Support login with username and password (#15656) (#16341)
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
2022-04-11 19:49:34 +08:00
congqixia 994bb829d3
Use fmt.Errorf instead of string concat in schema.go (#16404)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-11 09:47:37 +08:00
Cai Yudong fa697d0d48
[skip e2e] Remove useless OpenMP settings in CMakeLists.txt (#16441)
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2022-04-09 14:15:32 +08:00
Cai Yudong 71cd7ba67a
Add configuration common.indexSliceSize (#16438)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-04-08 20:29:33 +08:00
xige-16 27b4cbc098
Cherry pick remove translateHits commit to mater (#16436)
Signed-off-by: xige-16 <xi.ge@zilliz.com>

Co-authored-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-08 20:27:31 +08:00
Cai Yudong a37479d728
Upgrade to knowhere-v1.1.2 to support all index types for mac (#16416)
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2022-04-08 15:29:31 +08:00
Cai Yudong b09e56ff81
Remove unused directory (#16419)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-04-08 00:55:31 +08:00
godchen bb7a0766fe
Add dependency factory (#16204)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2022-04-07 22:05:32 +08:00
Ten Thousand Leaves 768bd4035f
Drop log level in delete node showDelBuf as they confuse our users. (#16410)
issue: 16349

/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-04-07 17:59:31 +08:00
Cai Yudong 6c4d497d73
Fix mac build error (#16415)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-04-07 17:29:31 +08:00
XuanYang-cn 909dd73741
Avoid using specific port in ut (#16398)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-04-06 20:13:32 +08:00
congqixia 4cb7c28bfa
Fix ReplicaInfo package name (#16400)
Fix #16399
PR 16373 breaks the build after ReplicaInfo moved from querypb to milvuspb
Also fix  problem in Makefile
Limit action/setup-go version to ~1.17.1(>=1.17.1 <1.18.0)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-06 19:47:31 +08:00
congqixia 18d76261a0
Add ShardNodeDetector implementation (#16373)
Use etcd as a ShardNodeDetector
Unit tests is based on embedded etcd

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-06 15:43:31 +08:00
Ten Thousand Leaves 1e6f6bd072
Implement set segment state call from RootCoord to DataCoord. (#16374)
/kind feature

issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-04-06 15:33:32 +08:00
XuanYang-cn 78200009a3
Impl GetReplicas in Proxy (#16390)
See also: #16298

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-04-06 14:57:31 +08:00
bigsheeper 2b27fa4609
Print numTimestamps instead of Timestamps (#16369)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-06 14:47:31 +08:00
cai.zhang 4267dc2efc
Handle error and oragnize log (#16367)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-04-06 14:33:30 +08:00
bigsheeper 7161a7760c
Fix segIDAssigner spelling mistake (#16370)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-06 14:11:31 +08:00
bigsheeper 4f4a417c8f
Unify in log print (#16368)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-06 14:09:35 +08:00
cai.zhang e73139deeb
Compressed IndexNode log (#16365)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-04-06 11:33:31 +08:00
cai.zhang 04076393c5
Fix log error (#16363)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-04-06 10:13:32 +08:00
cai.zhang f9c6b3980f
Compressed log (#16354)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-04-06 10:11:36 +08:00
Cai Yudong 543ec4a209
Rename log to milvus_log (#16383)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-04-05 22:55:30 +08:00
Cai Yudong 7323180861
Move bench to directory unittest (#16386)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-04-05 12:43:30 +08:00
Cai Yudong 0c53f06a33
Fix build error on mac (#16380)
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2022-04-04 21:09:32 +08:00
Letian Jiang 09b90fd8bf
Fix QueryCollection retrieve unit test (#16376)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-04 21:07:30 +08:00
Ten Thousand Leaves 2bd0a9526a
Implement task expiring logic and make all deadlines configurable. (#16355)
/kind feature

issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-04-03 11:37:29 +08:00
groot be8d9a8b6b
Support import numpy file (#16348)
Signed-off-by: groot <yihua.mo@zilliz.com>
2022-04-03 11:27:29 +08:00
xige-16 99984b88e1
Support delete varChar value (#16229)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-04-02 17:43:29 +08:00
congqixia aa1c26de77
Add ShardCluster implementation (#16360)
ShardCluster maintains shard replica meta information
It watches node & segment change events
Provides shard replica search/query services

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-02 17:35:29 +08:00
Letian Jiang 028c5cb882
Modify grpc interface for replica Search/Query in QueryNode (#16326)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-02 14:15:31 +08:00
Xiaofan 7f7379d55f
Fix DML channel AsProducer after Close (#16352)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-04-02 13:09:29 +08:00
XuanYang-cn 5494f3c318
Remove offLineNodes from watch states check (#16347)
This PR also
- adds more information in log
- makes Session able to logged by zap.Any/zap.String

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-04-01 22:33:29 +08:00
congqixia 6111dcde52
Fix ticker leakage in datanode flowgraph (#16346)
Using  in case ticker need to be closed may cause leakage
Use time.NewTicker with deferred Stop instead

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-01 19:35:29 +08:00
XuanYang-cn e9090a62ab
Rearrange search/queryTask for readability (#16325)
`searchTask` has 683 lines of code, `queryTask` has 485 lines of code.
`task.go` contains 4k+ codes including `searchTask` and `queryTask`.

It was so much pain navigating codes of searchTask and queryTask though task.go,
task.go and task_test.go are literaly unreadable.

This PR moves
1. 650+ lines of code of `searchTask` from `task.go` to `task_search.go`.
2. 1.4k+ lines of test code of `searchTask` from `task_test.go` to
   `task_search_test.go`.
3. 450+ lines of code of `queryTask` from `task.go` to `task_query.go`.
4. 200+ lines of test code of `queryTask from `task_test.go to
   `task_query_test.go`.

This PR also rearrange methods positions of `searchTask` and
`queryTask`:
-  Putting the most important methods `PreExecute`, `Execute`, and
   `PosExecute` at the beginning of the file.
-  Moves interface methods `ID`, `SetID`, `Type`, `BeginTs`, etc.
   that nobody cares about to the bottom of the file.

See also: #16298

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-04-01 18:59:29 +08:00
congqixia 7a44fff8cd
Use fmt.Errorf instead of string concat in tsafe_replica (#16344)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-01 18:37:28 +08:00
yah01 c005f07ccc
Modify proto to add GetReplicas() interface (#16328)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-04-01 16:15:29 +08:00
Jiquan Long fd589baca7
Integrates marisa trie index (#16192)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-04-01 15:31:29 +08:00
Letian Jiang cb65860e22
Add implementation for QueryShardService (#16317)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-01 14:19:29 +08:00
Ten Thousand Leaves 45be3deb3f
Implement RC, DC, DN calling path for import. (#16321)
/kind feature

issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-04-01 11:33:28 +08:00
congqixia 376a7f6567
Fix Datacoord unsubAttempt using pchannel (#16337)
Fix the channel name used when Datacoord unsub for DataNode
This channel shall always be pChannel instead of vChannel

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-01 11:25:28 +08:00
groot bd241cd28b
Add performance test case for import (#16296)
Signed-off-by: groot <yihua.mo@zilliz.com>
2022-04-01 10:07:28 +08:00
zhenshan.cao b03da87df5
Accelerate query speed in sealed segment (#16287)
Fix delete duplicate key

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-03-31 17:33:28 +08:00
XuanYang-cn 58addbf9f4
Add GetShardLeaders rpc in querycoord proto (#16299)
See also: #16298

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-03-31 16:39:29 +08:00
congqixia f529f8c1fc
Use fmt.Errorf instead of str concat in func.go (#16315)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-31 15:03:28 +08:00
Letian Jiang ad9a2217ae
Add interface for QueryShardService and QueryShard (#16309)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-03-31 14:05:28 +08:00
Ten Thousand Leaves 0d54697d42
Implement ReportImport related logic. (#16312)
/kind feature

issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-03-31 13:51:28 +08:00
Bingyi Sun baa745b83e
Improve log (#16307)
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2022-03-31 11:33:28 +08:00
Bingyi Sun 40fab91448
improve log (#16236)
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2022-03-30 23:05:28 +08:00
XuanYang-cn a0bb758be5
Refine log in proxy searchTask (#16263)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-03-30 22:09:28 +08:00
congqixia 899638810a
Add error log when tsafe register watcher more than once (#16294)
Add some test case to cover the error case
Add log in error branch

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-30 22:07:28 +08:00
Jiquan Long ba37531456
Add support for loading multiple indexes (#16138)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-30 21:11:28 +08:00
yah01 0f53989f17
Modify proto to support replicas (#16289)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-03-30 17:57:28 +08:00
Cai Yudong 5a9e1af3bb
Update create plan CGO interface (#16271)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-30 17:13:27 +08:00
groot ffa06c77b6
Import util functions (#16237)
Signed-off-by: groot <yihua.mo@zilliz.com>
2022-03-30 16:25:30 +08:00
Xiaofan 801eeffbcc
Replace cgo parquet reader to go parquet reader (#16199)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-03-30 15:21:28 +08:00
congqixia 18a3e9f265
Add grpc interface for replica Search/Query in QueryNode (#16197)
Resolves #16195
Add Search and Query grpc interface in query proto and types/types.go

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-30 12:03:27 +08:00
Xiaofan b6b3c9863c
Fix incompatibility of stats log (#16277)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-03-30 10:15:28 +08:00
Cai Yudong 0baa8c60a5
Fix MinGW build error (#16267)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-30 00:15:27 +08:00
Jiquan Long cd0f3cbcd3
Refine log (#16269)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-29 22:43:28 +08:00
cai.zhang e2e345079f
Add indexMeta version for IndexCoord log (#16266)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-03-29 21:03:27 +08:00
jaime d5d6e115bd
Refine delete segment data log (#16241)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-03-29 18:41:27 +08:00
Jiquan Long 3219b4e392
Skip dimension check for scalar index (#16257)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-29 15:35:27 +08:00
Cai Yudong 1160693e4c
Fix centos build error (#16251)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-29 15:13:30 +08:00
aakejiang de70dfe0c3
refine log (#16256)
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
2022-03-29 15:05:27 +08:00
congqixia 91d5436807
Improve log level and param function in QueryCollection (#16254)
Use debug level for all debug information
Use specific parameter function for appliable ones

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-29 12:31:27 +08:00
zhenshan.cao 11cea5aad0
Refine proxy log (#16246)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-03-29 02:29:27 +08:00
Cai Yudong 2ac53c89e9
Revert #16242 (#16247)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-29 00:53:27 +08:00
XuanYang-cn 23b3a9ed8a
Log state in datanode handleWatchInfo (#16231)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-03-29 00:15:28 +08:00
Cai Yudong 9a6b2b8806
Fix centos build error (#16242)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-28 23:23:27 +08:00
bigsheeper 9d673006e0
Improve primary keys print (#16232)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-03-28 23:15:27 +08:00
xige-16 d2424fc50a
Print msgID instead of loadInfo when load segment (#16238)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-03-28 23:13:27 +08:00
congqixia 2c03287e79
Improve log level in proxy QueryTask (#16234)
Use warn instead of debug in error case

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-28 23:11:26 +08:00
XuanYang-cn a77dd1034c
Adopt the extended state in DataCoord (#16200)
ChannelWatchInfo with ToWatch, ToRelease will trigger a timer.
ChannelManager now reacts to different ChannelWatch states.

- WatchSuccess > log this info

- WatchFailure/WatchTimeout > ToRelease

- ReleaseSuccess > Delete, reassign if not from DropCollection

- ReleaseFailure/ReleaseTimeout > Cleanup subscription and Delete,
  reassgin if not from DropCollection.

Some Notes:
1. Reassignment will add this channel to buffer if there's only one node.

See also: #15846

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-03-28 22:33:27 +08:00
Jiquan Long 973ea406ca
Improve log of show collections (#16233)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-28 21:47:27 +08:00
cai.zhang c8688a6275
Organize log for GetIndexFilePaths (#16230)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-03-28 21:27:27 +08:00
Ji Bin 4f08f6d8c6
Workaround for knowhere under windows (#16214)
issue #16205

Signed-off-by: Ji Bin <matrixji@live.com>
2022-03-28 17:41:27 +08:00
yah01 178eb8cce1
Modify proto to support replicas (#16218)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-03-28 16:43:27 +08:00
Ten Thousand Leaves 40c703dacd
Support check index state in root coord, for bulk load feature. (#16198)
issue: #15604

/kind feature

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-03-28 16:41:28 +08:00
Bingyi Sun e0ffe54547
Add interface to get replications by collection ID (#16213)
issue: #16158
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2022-03-28 14:35:27 +08:00
Cai Yudong 3e3756d3dc
Upgrade to knowhere v1.1.1 to support Mac M1 build (#16210)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-28 14:33:26 +08:00
godchen 478f6ca11e
Add cache for vector chunk (#15912)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2022-03-26 22:05:26 +08:00
xige-16 205c92e54b
Support insert string data (#15993)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-03-25 14:27:25 +08:00
yah01 227889b0d0
Add replica interfaces for Meta and Cluster (#16190)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-03-25 14:03:25 +08:00
Cai Yudong f4ebd3a9ce
Upgrade to knowhere v1.1.0 (#16186)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-25 13:49:25 +08:00
XuanYang-cn a00968fdfe
Fix unregister in datacoord cluster (#16182)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-03-25 12:09:25 +08:00
yah01 0d16ecf0dd
Add protobuf messages to support multi memory replica (#16153)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-03-25 11:13:25 +08:00
Ten Thousand Leaves a23ca745bb
Add Etcd support for Import Tasks. (#16164)
issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-03-25 11:03:25 +08:00
bigsheeper 2fcf7b9760
Fix GetMemoryCount, get min as total memory (#15931)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-03-24 20:41:25 +08:00
yah01 9deb245d77
Fix data race in unittest (#16165)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-03-24 20:19:25 +08:00
bigsheeper 7fee4743f5
Improve log print in OOM error info (#16170)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-03-24 20:17:25 +08:00
Jiquan Long 48706f416f
Migrate scalar index from knowhere (#16174)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-24 14:57:26 +08:00
congqixia 661469445c
Copy index file content to c memory (#16162)
Might be the root cause of #15896
The index content bytes were passed via unsafe.Pointer,
which shall be copy to cpp managed memory inmediately

This solution might cause a lot of memory consumption.
Maybe we need to store the index bytes in cpp memory in the first place.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-24 14:55:25 +08:00