milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use fmt.Errorf instead of string concat in tsafe_replica (#16344) 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/16346/head
congqixia 2022-04-01 18:37:28 +08:00 committed by GitHub
parent c005f07ccc
commit 7a44fff8cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/querynode/tsafe_replica.go
View File

@ -17,7 +17,7 @@
package querynode
import (
"errors"
"fmt"
"sync"
"go.uber.org/zap"
@ -59,7 +59,7 @@ func (t *tSafeReplica) setTSafe(vChannel Channel, timestamp Timestamp) error {
defer t.mu.Unlock()
ts, err := t.getTSafePrivate(vChannel)
if err != nil {
return errors.New("set tSafe failed, err = " + err.Error())
return fmt.Errorf("set tSafe failed, err = %w", err)
}
ts.set(timestamp)
return nil
@ -67,9 +67,7 @@ func (t *tSafeReplica) setTSafe(vChannel Channel, timestamp Timestamp) error {
func (t *tSafeReplica) getTSafePrivate(vChannel Channel) (*tSafe, error) {
if _, ok := t.tSafes[vChannel]; !ok {
err := errors.New("cannot found tSafer, vChannel = " + vChannel)
//log.Warn(err.Error())
return nil, err
return nil, fmt.Errorf("cannot found tSafer, vChannel = %s", vChannel)
}
return t.tSafes[vChannel], nil
}
@ -80,11 +78,11 @@ func (t *tSafeReplica) addTSafe(vChannel Channel) {
if _, ok := t.tSafes[vChannel]; !ok {
t.tSafes[vChannel] = newTSafe(vChannel)
log.Debug("add tSafe done",
zap.Any("channel", vChannel),
zap.String("channel", vChannel),
)
} else {
log.Debug("tSafe has been existed",
zap.Any("channel", vChannel),
zap.String("channel", vChannel),
)
}
}
@ -94,7 +92,7 @@ func (t *tSafeReplica) removeTSafe(vChannel Channel) {
defer t.mu.Unlock()
log.Debug("remove tSafe replica",
zap.Any("vChannel", vChannel),
zap.String("vChannel", vChannel),
)
delete(t.tSafes, vChannel)
}