Commit Graph

18428 Commits (b639fd66b4a71093c0b2f9a8abec7352ab5e6acc)

Author SHA1 Message Date
aoiasd b639fd66b4
fix: [Cherry-pick] accesslog can not print search expression (#28931)
relate: https://github.com/milvus-io/milvus/issues/28893
pr: https://github.com/milvus-io/milvus/pull/28899

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-08 02:00:36 +08:00
MrPresent-Han 5f4ac437b2
enhance: [Cherry-pick] Moving etcd client into session (#27069) (#28996)
relate: #26694
pr: https://github.com/milvus-io/milvus/pull/27069

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Co-authored-by: Filip Haltmayer <81822489+filip-halt@users.noreply.github.com>
2023-12-07 16:22:34 +08:00
aoiasd 8502037cff
fix: [Cherry-pick] sync action load segment with lack collection index info list (#28956)
relate: https://github.com/milvus-io/milvus/issues/28779
https://github.com/milvus-io/milvus/issues/28637
pr: https://github.com/milvus-io/milvus/pull/28788

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-07 14:14:42 +08:00
liliu-z f6700551be
enhance: Bump Knowhere's version to 2.2.3 (#29035)
Knowhere's new bug fix version:
https://github.com/zilliztech/knowhere/releases/tag/v2.2.3

related issues: #28821 #28810 #27552 #27516 #28603 #21483

Signed-off-by: Li Liu <li.liu@zilliz.com>
2023-12-07 14:08:33 +08:00
SimFG de28b73fe0
enhance: [2.3] Use a non-blocking method to trigger compaction when saveBinlogPath is executed (#28977)
/kind improvement
issue: #28924
pr: #28941

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-07 13:14:34 +08:00
aoiasd cb7b1d1d51
enhance: [Cherry-pick] pack proxy connection code and support accesslog print SDK_Version (#28844)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/pull/28835

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-07 12:06:34 +08:00
cqy123456 8fd38c8eea
enhance:[cherry-pick] Use binlog index for better search performance (#29012)
this pr is cherry-pick from master:
pr: https://github.com/milvus-io/milvus/pull/28528
pr: https://github.com/milvus-io/milvus/pull/27673
related issue:
issue: https://github.com/milvus-io/milvus/issues/27678

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2023-12-07 09:52:34 +08:00
PowderLi cdd1305f26
enhance: find collection schema from cache (#28916)
issue: #28781 #28329
master pr: #28782

1. There is no need to call `DescribeCollection`, if the collection's
schema is found in the globalMetaCache
2. did `GetProperties` to check the access to Azure Blob Service

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-06 22:44:33 +08:00
congqixia 2e82d65124
fix: [cherry-pick] Align minio object storage ut to new minio server behavior (#29015)
cherry-pick from master
pr: #29014
See also #29013

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-06 15:42:43 +08:00
yihao.dai 51614073ec
enhance: Update pymilvus (#28922) (#28991)
issue: https://github.com/milvus-io/milvus/issues/17614

pr: https://github.com/milvus-io/milvus/pull/28922

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-06 11:56:34 +08:00
zhenshan.cao cb19e590fb
fix: clean snapshots meta (#28502) (#28999)
issue: https://github.com/milvus-io/milvus/issues/28496 /kind bug
pr: #28502 
The input parameters collection.partitions and collection.Field are both
nil, so these two metas have not been cleared.

Signed-off-by: xige-16 <xi.ge@zilliz.com>
Co-authored-by: xige-16 <xi.ge@zilliz.com>
2023-12-06 09:51:01 +08:00
yihao.dai 3d7bcb5e36
enhance: Remove partition load infos with prefix (#28969) (#28973)
Removing partition load infos with prefix instead of removing them one
by one. This enhance can save transactions.

issue: https://github.com/milvus-io/milvus/issues/28343

pr: https://github.com/milvus-io/milvus/pull/28969

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-05 19:54:33 +08:00
groot 1f8c1afe8a
fix: Change ranges of HNSW parameters according to Knowhere (#28877)
fix: https://github.com/milvus-io/milvus/issues/28860
pr: https://github.com/milvus-io/milvus/pull/28875

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-12-05 16:20:42 +08:00
sre-ci-robot 0f0a529299
[automated] Update Builder image changes (#28975)
Update Builder image changes
See changes:
43ec2c2bd7
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-12-05 14:42:33 +08:00
sammy.huang 13d42ec33e
enhance: [skip e2e] upgrade minio version (#28906)
fix: https://github.com/milvus-io/milvus/issues/28880
pr: [#28971](https://github.com/milvus-io/milvus/pull/28971)

Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2023-12-05 14:18:33 +08:00
wei liu 251b55844e
enhance: Remove too frequency read ddl log from rootcoord (#28891) (#28932)
pr: #28891
This PR removed too frequency log for such
`DescribeCollection/ShowPartition` operation from root coord

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-05 14:10:32 +08:00
PowderLi 43ec2c2bd7
enhance: [CHERRY-PICK] use already installed vcpkg (#28915)
issue: #28683 master pr: #28505
issue: #28686 master pr: #28703

1. update the base image: milvusdb/milvus-env (#28505) to avoid
downloading installation packages in CI workload install vcpkg and
install some packages in advance
2. use the latest image
2. update azure-identity-cpp from beta to release

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-05 11:12:32 +08:00
yah01 1ab538be43
enhance: enable assert method to format arguments (#28812) (#28907)
for now the assert method in segcore could accept a string information,
too many codes don't print the value they assert.

make it happy
related #28811
pr: #28812

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-05 10:22:32 +08:00
congqixia 2873be9264
fix: [2.3] Reject compaction task with growing segments (#28927)
See also #28924
The compaction task generated before datanode finish SaveBinlogPath grpc
call contains segments which are still in Growing state DataNode shall
verify each non-levelzero segments before submit compaction task to
executor

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-04 19:14:33 +08:00
congqixia 3a33afd1fb
enhance: [cherry-pick] Change const magic number in querycoord to param (#28819) (#28947)
Cherry-pick from master
pr: #28819 
See also #28817

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-04 19:06:40 +08:00
wei liu c650240f31
enhance: Change some frequency log to rated level (#28897) (#28934)
pr: #28897
This pr change some frequency log's level to rated.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-04 18:52:32 +08:00
congqixia ed550ebb7c
enhance: [cherry-pick] Resolve libunwind requirement conflict using 1.7.2 (#28935)
Cherry-pick from master
pr: #28929
Try to resolve libunwind dependency requirement conflict between glog &
folly

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-04 14:06:40 +08:00
nico 609800a5b7
test: modify test cases for error msg update(2.3) (#28849)
pr: #28846
issue: #23075

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-12-04 11:20:47 +08:00
congqixia f4468dfd15
fix: [cherry-pick] Check whether compaction plan exist before update(#28826) (#28892)
pr: #28826 
Fix #28825

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-04 10:02:33 +08:00
wei liu d2c171354f
fix: Balance channel may cause channel not availble error (#28829) (#28902)
pr: #28829
issue: #28831
release old delegator before new delegator update it's distribution may
cause `channel not available` error
This PR will block release old delgator before new delegator finish
`syncDistribution`

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-04 09:40:32 +08:00
jaime 275e3ea456
fix: Fix missing target db name for RenameCollection (#28911)
issue: #28908
pr: #28909

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-12-03 08:28:31 +08:00
PowderLi 96c8e8d587
fix: azure ListObjects (#27931) (#28894)
issue: #27932
master pr: #27931

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-01 18:34:31 +08:00
yihao.dai c936cc8a95
fix: Fix get binary vector from chunk cache (#28866) (#28884)
The way of getting binary vector size is wrong. This PR will fix it.

issue: https://github.com/milvus-io/milvus/issues/28865

pr: https://github.com/milvus-io/milvus/pull/28866

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-01 17:50:32 +08:00
aoiasd 9bf33eb576
fix: [Cherry-Pick] accesslog method status not return failed when error in response (#28827)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/pull/28824

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-01 15:30:38 +08:00
Gao b6cb9e90d2
fix: [2.3] update folly to resolve simd issue (#28879)
related issue: https://github.com/milvus-io/milvus/issues/27552 , after
this, milvus could run successfully on sse4.2 only machine
pr: #28878

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-12-01 13:52:32 +08:00
congqixia 63e1ac0846
fix: [cherry-pick] schema->size() check logic with system field (#28802) (#28841)
Cherry pick from master
pr: #28802

Now segcore load system field info as well, the growing segment
assertion shall not pass with "+ 2" value
This will cause all growing segments load failure
Fix #28801
Related to #28478
See also #28524

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-01 13:28:30 +08:00
yah01 ce8219f1a3
fix: bypass growing index if no index meta (#28791) (#28859)
we shouldn't panic if no index meta, just skip building it
fix #28022
pr: #28791

---------

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-11-30 21:10:32 +08:00
aoiasd 880189e598
enhance: Delete by complex expression use partitionKey optimization (#27952) (#28128)
relate: https://github.com/milvus-io/milvus/issues/27948
pr: https://github.com/milvus-io/milvus/pull/27952

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-30 17:56:31 +08:00
yihao.dai d0a56ecca5
fix: Fix minio latency monitoring for get operation (#28510) (#28643)
see also: https://github.com/milvus-io/milvus/issues/28509

pr: https://github.com/milvus-io/milvus/pull/28510

Currently Minio latency monitoring for get operation only collects the
duration of getting object (which just returns an io.Reader and does not
really read from minio), this pr will correct this behavior.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-30 10:44:28 +08:00
cai.zhang 00461145b3
enhance: [Pick]Support importing data with parquet file (#28820)
issue: https://github.com/milvus-io/milvus/issues/28272
master pr: #28608 

Numpy does not support array type import.
Array type data is imported through parquet.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-29 22:16:29 +08:00
cai.zhang 2062e5b368
enhance: [Pick]Update arrow version to v12 (#28425) (#28828)
master pr: #28425 
issue: https://github.com/milvus-io/milvus/issues/28423

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-29 20:04:28 +08:00
congqixia e3653af9c9
fix: data race on rootcoord.proxyClientManager.proxyClient (#28787) (#28798)
Cherry-pick from master
pr: #28787
Fix #28786

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-29 18:00:27 +08:00
yihao.dai a78ea4fea0
fix: Check ErrSegmentNotFound in delete node (#28371) (#28638)
We have been check ErrSegmentNotFound in insert_buffer_node in datanode,
we should also check it in delete_node.

issue: https://github.com/milvus-io/milvus/issues/27145

pr: https://github.com/milvus-io/milvus/pull/28371

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-29 17:50:27 +08:00
nico a3aceb97a4
test: update test cases and pymilvus version (#28746)
pr: #28706

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-11-29 10:28:29 +08:00
congqixia 0688ec4d83
enhance: [cherry-pick] Add channel checkpoint ts lag metric (#28767) (#28776)
Cherry-pick from master
pr: #28767
See also #28765

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-28 19:28:28 +08:00
Gao ccca932cc6
fix: [2.3] correct autoindex segment num (#28429)
issue: #28386 
pr: #28387

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-11-28 19:24:26 +08:00
cai.zhang fda452ea4d
enhance: [Pick] Revert import support csv format (#28766)
issue: #28778 
master pr: #28760

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-28 18:26:28 +08:00
aoiasd cbb05a2d52
fix: [Cherry-pick] log can not reduce level (#28770)
relate: https://github.com/milvus-io/milvus/issues/28749
pr: https://github.com/milvus-io/milvus/pull/28750

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-28 16:26:33 +08:00
aoiasd 224f2755c5
enhance: [Cherry-pick]Refine accesslog to support format by yaml and support more metric (#28740)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/issues/28086

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-28 15:34:28 +08:00
yah01 8ea1ef03ad
enhance: store system fields in segcore (#28524) (#28727)
we need the system fields info for some usacase
fix: #28523

pr: #28524

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-28 15:32:31 +08:00
groot ecfa0a9b10
test: Unskip a bulkinsert test case (#28780)
Unskip a bulkinsert test case which is skipped by #28209

pr: https://github.com/milvus-io/milvus/pull/28679

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-11-28 13:00:27 +08:00
groot d20328bc05
test: Avoid unstable case of bulkinsert (#28757)
test: There are too many test cases for bulkinsert+partition_key. Each
case creates 10 bulkinsert tasks to import a file with 100~200 rows. The
default num_partitions is 64 for partition_key. So, each task will
generate 64 tiny segments. There are 10 cases, each case 10 tasks, each
task 64 tiny segment, totally there are 6400 tiny segments generated.
And all these segment row count is less than 1024, no need to build
index, and take part in compaction. There will be lots of compaction
tasks generated. It costs too much time to process these compaction
tasks. Eventually, some cases are timeout after waiting 5 minutes for
their segments to be ready and cases fail.

Specifying the num_partitions to a small value can avoid this problem.

pr: https://github.com/milvus-io/milvus/pull/28679

```
[2023-11-21T03:41:16.187Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[int_scalar-True-True] PASSED [ 54%]
[2023-11-21T03:41:42.796Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[int_scalar-False-True] PASSED [ 57%]
[2023-11-21T03:42:04.694Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[string_scalar-True-True] PASSED [ 60%]
[2023-11-21T03:42:31.205Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[string_scalar-False-True] PASSED [ 63%]
[2023-11-21T03:43:38.876Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_multi_numpy_files[10-150-13-True] XPASS [ 66%]
[2023-11-21T03:49:00.357Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_multi_numpy_files[10-150-13-False] XFAIL [ 69%]
[2023-11-21T03:53:51.811Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[int_scalar-True] FAILED [ 72%]
[2023-11-21T03:58:58.283Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[int_scalar-False] FAILED [ 75%]
[2023-11-21T04:02:04.696Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[string_scalar-True] PASSED [ 78%]
[2023-11-21T04:02:26.608Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[string_scalar-False] PASSED [ 81%]
```

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-11-28 10:34:31 +08:00
Enwei Jiao 7afd7553ed
feat: trigger compaction to handle index version (#28442) (#28754)
issue: https://github.com/milvus-io/milvus/issues/28441
pr: https://github.com/milvus-io/milvus/pull/28442

---------

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-11-28 10:24:26 +08:00
wayblink 1ed92da414
enhance:[cherry-pick] Merge flowgraph goroutines into 1 (#28728)
see also: #28654 #28233

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-27 21:04:27 +08:00
congqixia 5a962a631a
fix: [cherry-pick] Change schema to atomic.Pointer to avoid data race (#28739) (#28759)
Cherry-pick from master
pr: #28739
See also #28738

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-27 19:50:27 +08:00