Commit Graph

18556 Commits (b580aef4dc0bb01b0c41fb11042ea3bca93603ec)

Author SHA1 Message Date
sammy.huang b580aef4dc
enhance: [skip e2e]We aim to cancel the previously initiated job exclusively during PR (#29859)
PR: https://github.com/milvus-io/milvus/pull/29797
 
enhance: We aim to cancel the previously initiated job or workflow
exclusively during the Pull Request (PR) stage

Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2024-01-11 10:00:51 +08:00
XuanYang-cn 1128b1dd67
fix: [cherry-pick]Save lite WatchInfo into etcd in DataNode (#29751)
See also: #29689
pr: #29687

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-01-10 20:48:50 +08:00
zhenshan.cao 9d2847ef2b
enhance: update milvus-proto to support rbac for alias (#29798)
issue: https://github.com/milvus-io/milvus/issues/29781
issue: https://github.com/milvus-io/milvus-proto/issues/237
Update the protocol to support the RBAC functionality for aliases

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-10 10:12:50 +08:00
congqixia 6c9a5e347e
fix: [cherry-pick] Assertion all async invocations in test case (#29737) (#29782)
Cherry-pick from master
pr: #29737
Resolves: #29736

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-09 17:48:49 +08:00
yah01 38c61594c0
enhance: use GPU pool for gpu tasks (#29678) (#29706)
- this much improve the performance for GPU index
- this also reduce 1x copy while parsing index meta
pr: #29678

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-09 14:04:48 +08:00
zhenshan.cao 8c2ca3fb79
feat: Authorize users to query grant info of their roles (#29747) (#29762)
Once a role is granted to a user, the user should automatically possess
the privilege information associated with that role.

issue: #29710
pr: #29747

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-01-08 18:06:49 +08:00
congqixia 0c83440f99
enhance: [Cherry-pick] cache collection schema attributes to reduce proxy cpu (#29668) (#29692)
Cherry-pick from master
pr: #29668

See also #29113

The collection schema is crucial when performing search/query but some
of the information is calculated for every request.

This PR change schema field of cached collection info into a utility
`schemaInfo` type to store some stable result, say pk field,
partitionKeyEnabled, etc. And provided field name to id map for
search/query services.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-07 22:36:48 +08:00
Jiquan Long 03a375ac82
enhance: [skip-e2e] auto cancel stale workflows (#29145) (#29193)
/kind improvement
pr: #29145

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-01-07 20:06:51 +08:00
PowderLi 9e7974a2c6
fix:[CHERRY_PICK] link with install path's libblob-chunk-manager (#29731)
issue: #29494
pr: #29496


1. link with install path's libblob-chunk-manager
2. performance of `ShouldBindWith` is better than `ShouldBindBodyWith`
3. the middleware shouldn't read the unrefreshed parameter repeatly
4. diff from old restful, named HandlersV1

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-07 19:52:49 +08:00
yah01 58410d8b62
enhance: skip loading duplicated index (#29715) (#29716)
this protect the loading index from failure, and speed up the loading
progress
pr: #29715

Signed-off-by: yah01 <yang.cen@zilliz.com>
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2024-01-07 17:00:48 +08:00
wei liu 4088b00602
enhance: Rewrite gen segment plan based on assign segment (#29574) (#29684)
issue: #29582
pr: #29574
This PR rewrite gen segment plan logic based on assign segment in
`score_based_balancer`

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-01-06 09:58:49 +08:00
PowderLi cb355cacce
enhance: get a blob to check object storage config (#29705)
issue: #29672
master pr: #29703

the storage account need privileges of actions
`Microsoft.Storage/storageAccounts/blobServices/containers/blobs/*` at
least

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-05 18:02:47 +08:00
smellthemoon fcd23e2ec2
enhance:Add upsert vector metrics(#29226) (#29674)
pr: https://github.com/milvus-io/milvus/pull/29226

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-01-05 15:44:47 +08:00
congqixia fc65f01ddd
enhance: [Cherry-pick] Cache segment row num, size, and insert count to reduce CGO calls (#28007) (#29679)
Cherry pick from master
pr: #28007
See also #29650

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Co-authored-by: yah01 <yah2er0ne@outlook.com>
2024-01-04 23:04:47 +08:00
cai.zhang 2d64cd780c
enhance: Read azure file without ReadAll (#29604)
issue: #29292 
master pr: #29602

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-01-04 20:52:48 +08:00
yah01 3c3fc160e9
fix: make the entity num metric accurate (#29643) (#29644)
fix https://github.com/milvus-io/milvus/issues/29642
pr: #29643

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-04 19:26:47 +08:00
congqixia cf228c2f1c
fix: Print number of pks instead of delete pk val (#29653)
See also #29445

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-04 10:02:46 +08:00
zhuwenxing 6bf46c6fac
test: update bulk insert bench test (#29535)
update bulk insert bench test
cherry-pick from master
pr: https://github.com/milvus-io/milvus/pull/29534

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-01-03 19:16:55 +08:00
nico b07dbea7fb
enhance: update pymilvus version (#29600)
Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-01-03 15:30:48 +08:00
SimFG a2365e4b2a
enhance: [2.3] Add concurrency for datacoord segment GC (#29557)
issue: #29553
pr: https://github.com/milvus-io/milvus/pull/29561
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-01-03 13:16:57 +08:00
foxspy 66c84655d8
fix: [Cherry-pick] throw exception when upload file failed for DiskIndex (#29628)
Cherry pick from master
pr: #29627 
related to: #29417

Signed-off-by: xianliang <xianliang.li@zilliz.com>
2024-01-03 11:10:47 +08:00
MrPresent-Han 757834602a
enhance: add param for bloomfilter(#29388) (#29614)
related: https://github.com/milvus-io/milvus/issues/29388
pr: https://github.com/milvus-io/milvus/pull/29490

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-01-02 18:58:47 +08:00
Jiquan Long 7a373bec46
enhance: print total memory when milvus starts (#29351) (#29352)
issue: #29349 
pr: #29351

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-31 17:42:47 +08:00
cai.zhang 0902e5aada
enhance: [Pick]Support azurite docker for develope env (#29140)
master pr: #29021

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-31 17:18:37 +08:00
sammy.huang ac1b1b01d1
enhance: [skip e2e][automated] Bump milvus version to v2.3.4 (#29605)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2023-12-30 07:38:45 +08:00
congqixia 7a192da870
enhance: Bump version 2.3.4 & milvus-proto (#29598)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-29 18:32:45 +08:00
cai.zhang ba1d0556ba
fix: Import data from parquet file in streaming way (#29528)
issue:  #29292 
master pr: #29514

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-29 11:56:45 +08:00
congqixia 5ec79ab6f6
fix: [Cherry-pick] Add atomic method to get collection target (#29580)
Cherry pick from master
pr: #29577
Related to #29575

Add `getCollectionTarget` method which is atomic when scope is
`CurrentTargetFirst` or `NextTargetFirst`
Also return error when executor finds no channel in target manager

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-29 10:30:46 +08:00
congqixia 67313ccc86
fix: [cherry-pick] exclude insertData before growing checkpoint (#29559)
Cherry-pick from master
pr: #29558
See also: #29556
Refine exclude segment function signature
Add exclude growing before checkpoint logic

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 18:18:54 +08:00
wei liu a13fc4d346
enhance: Remove useless log in collection observer (#29555)
pr: #29554
This PR removed useless log in collection observer

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-28 17:14:45 +08:00
wei liu 07ef52e845
fix: Choose wrong shard leader during balance channel(#29525) (#29532)
issue: #29523
pr: #29525

readable shard leader should still be the old one during channel
balance, if the new shard leader is not ready.
This PR fixed that query coord choose wrong shard leader during balance
channel

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-28 15:22:51 +08:00
congqixia 687eb3955e
enhance: [Cherry-pick] Refine C.NewSegment response and handle exception (#28952) (#29550)
Cherry-pick from master
pr: #28952
See also #28795

Orignal `C.NewSegment` may panic if some condition is not met, this pr
changes response struct to `CNewSegmentResult`, which contains
`C.CStatus` and may return catched exception

---------

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 14:48:47 +08:00
congqixia 852547b1c5
fix: [cherry-pick] compose exclude info from flushed segment id (#29549)
Cherry-pick from master
pr: #29548
See also #29526

Previous PR removed flushed segment info from request, which causes
pipeline failing to exclude flushed segment info

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 14:02:54 +08:00
congqixia dd52a674aa
enhance: [cherry-pick] add ctx for HandleCStatus and callers (#29517) (#29546)
Cherry-pick from master
pr: #29517 
See also #29516

Make `HandleCStatus` print trace id for better logging

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-28 10:20:47 +08:00
congqixia eb11b1a56e
enhance: [Cherry-pick] remove flushed segmentInfo in WatchChannelRequest (#29527)
Cherry-pick from master
pr: #29526
`WatchDmChannel` only need growing segment info, this PR removes fetch
segmentInfos when fill watch dml channel request.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-27 23:46:46 +08:00
yah01 4c0ca83928
enhance: speed up loading with many deletions (#29455) (#29520)
the executor always fetches the latest segment info, so we could consume
from the latest checkpoint, which could save much time while deleted
many entities

pr: #29455

Signed-off-by: yah01 <yang.cen@zilliz.com>
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-27 23:24:46 +08:00
MrPresent-Han 151a5c3ca8
fix: iterator lose data for duplicted result(#29406) (#29446)
related: #29406
pr: #29451

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-27 23:22:46 +08:00
congqixia fc5dd524c5
enhance: [Cherry-pick] add log when release segment created for load failure (#29464) (#29500)
Cherry-pick from master
pr: #29464 
Add log for releasing segment created during load process when load
error happens

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-27 20:00:48 +08:00
yah01 e422a62a80
enhance: improve the handling for segcore error (#29471) (#29521)
- fix lost exception details in segcore
- improve the logs of handling errors from segcore

pr: #29471

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-27 19:06:46 +08:00
wei liu ad37b98cda
enhance: Rewrite gen stopping segment plan based on assign segment (29473) (#29480)
pr: #29473

`AssignSegment` method defines how to assign segment to nodes, but
score_based_balance implement another assign logic in
`genStoppingSegmentPlan`
This PR rewrite gen stopping segment plan based on assign segment.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 15:50:47 +08:00
wei liu d0bcbf3953
fix: Upgrade from 2.2 should update CollectionLoadInfo (#29443) (#29479)
pr: #29443
milvus branch 2.3 add `loadType` in CollectionLoadInfo, so for
collection meta upgrade from 2.2, we should add `loadType` to
CollectionLoadInfo. This PR update CollectionLoadInfo with `loadType`
when meet a old version CollectionLoadInfo

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 15:48:58 +08:00
Jiquan Long 82fb37e332
fix: panic in concurrent insert/query scenario (#29408) (#29488)
issue: https://github.com/milvus-io/milvus/issues/29405
pr: #29408 

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-27 15:08:45 +08:00
congqixia 5ba0f476d5
fix: [2.3]parse logID from logPath if copyDeltalog find logID not provided (#29276)
Cherry-pick from master
pr: #29273
See also: #29272

This PR add `getDeltaLogID` to safely return logID when Binlog struct
has zero value logID. It parses logID from logPath if the format is
valid. Otherwise, this function shall return error.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-27 14:42:46 +08:00
wei liu 26b1853c54
fix: Auto balance param can't be updated by dynamic(#29501) (#29502)
pr: #29501
This PR fixed that auto balance param can't be updated by dynamic

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 14:30:53 +08:00
aoiasd 1311911a26
enhance: [Cherry-Pick] make sure stream closed (#29457)
relate: https://github.com/milvus-io/milvus/issues/28367
pr: https://github.com/milvus-io/milvus/pull/29456

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-27 10:02:46 +08:00
yah01 51cab791cf
fix: missing to support compact for Array type (#29505) (#29504)
the array type can't be compacted, the system could continue with the
inserted segments, but these segments can be never compacted

fix #29503
pr: #29505

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-27 08:15:51 +08:00
aoiasd f5bba79963
enhance: [Cherry-Pick] add default local path for access log (#29461)
relate: https://github.com/milvus-io/milvus/issues/29459
pr: https://github.com/milvus-io/milvus/pull/29460

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 17:52:47 +08:00
aoiasd 6eeb4b7f9a
enhance: [Cherry-Pick] Refine delete by expression for forbid proxy dml task scheduler hang (#29359)
relate: https://github.com/milvus-io/milvus/issues/29146
pr: https://github.com/milvus-io/milvus/pull/29340

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 17:50:48 +08:00
congqixia 14d8b1fe85
fix: [Cherry-pick] Add scope limit for querynode DeleteRequest (#29476)
Cherry-pick from master
pr: #29474 
See also #27515

When Delegator processes delete data, it forwards delete data with only
segment id specified. When two segments has same segment id but one is
growing and the other is sealed, the delete will be applied to both
segments which causes delete data out of order when concurrent load
segment occurs.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-26 16:40:50 +08:00
MrPresent-Han 95d1056e32
refine the range of chunk size config value(#29388) (#29472)
related: #https://github.com/milvus-io/milvus/issues/29388
pr: https://github.com/milvus-io/milvus/pull/29389

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-26 14:34:46 +08:00