Commit Graph

21583 Commits (6816ee4cf5f4e5c652f2346829cf9f9f2a1c6134)

Author SHA1 Message Date
cai.zhang 6816ee4cf5
fix: [2.5] Record a map to avoid repeatedly traversing the CompactionFrom (#38926)
issue: #38811 

master pr: #38925

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2025-01-15 10:31:00 +08:00
yihao.dai 2e4a1052aa
enhance: [2.5] Reduce mutex contention in datacoord meta (#38904)
1. Using secondary index to avoid retrieving all segments at
GetSegmentsChanPart.
2. Perform batch SetAllocations to reduce the number of times the meta
lock is acquired.

issue: https://github.com/milvus-io/milvus/issues/37630

pr: https://github.com/milvus-io/milvus/pull/38219

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-01-15 00:55:00 +08:00
cai.zhang 4270174899
fix: [2.5] Add scalar index engine version for compatibility (#39236)
issue: #39203 

master pr: #39204

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2025-01-14 21:01:01 +08:00
yihao.dai b91c0a8079
enhance: [2.5] Optimize GetLocalDiskSize and segment loader mutex (#38907)
1. Make the segment loader lock protect only the resource.
2. Optimize GetDiskUsage to avoid excessive overhead.

issue: https://github.com/milvus-io/milvus/issues/37630

pr: https://github.com/milvus-io/milvus/pull/38599

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-01-14 20:43:06 +08:00
wei liu 51994158d9
fix: channel unbalance during stopping balance progress (#38971) (#39200)
issue: #38970
pr: #38971
cause the stopping balance channel still use the row_count_based policy,
which may causes channel unbalance in multi-collection case.

This PR impl a score based stopping balance channel policy.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-14 18:25:00 +08:00
wei liu 4fd56e4773
fix: Prevent leader checker from generating excessive duplicate leader tasks (#39000) (#39160)
issue: #39001
pr: #39000
Background:
Segment Load Version: Each segment load request assigns a timestamp as
its version. When multiple copies of a segment are loaded on different
QueryNodes, the leader checker uses this version to identify the latest
copy and updates the routing table in the leader view to point to it.
Delegator Router Version: When a delegator builds a route to a QueryNode
that has loaded a segment, it also records the segment's version.

Router Table Update Logic: If the leader checker detects that the
version of a segment in the routing table does not match the version in
the worker, it updates the routing table to point to the QueryNode with
the latest version. Additionally, it updates the segment's load version
in the QueryNode during this process.

Issue:
When a channel is undergoing load balancing, the leader checker may sync
the routing table to a new delegator. This sync operation modifies the
segment's load version, which invalidates the routing in the old
delegator. Subsequently, the leader checker updates the routing table in
the old delegator, breaking the routing in the new delegator. This cycle
continues, causing repeated updates and inconsistencies.

Fix:
This PR introduces two changes to address the issue:
1. Use NodeID to verify whether the delegator's routing table needs an
update, avoiding unnecessary modifications.
2. Ensure compatibility by using the latest segment's load version as
the version recorded in the routing table.

These changes resolve the cyclic updates and prevent the leader checker
from generating excessive duplicate tasks, ensuring routing stability
across delegators during load balancing.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-14 18:11:06 +08:00
congqixia b4ddf746c1
enhance: [2.5][bitset] extend op_find() to be able to search both 0 and 1 (#39237)
Cherry-pick from master
pr: #39176 #39229
issue: #39124

`bitset::find_first()` and `bitset::find_next()` now accept one more
parameter, which allows to search for `0` bit instead of `1` bit

---------

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: Alexander Guzhva <alexanderguzhva@gmail.com>
2025-01-14 17:59:00 +08:00
aoiasd e6ac2fe063
enhance: [Cherry-pick] report auth log to hook when grpc authenticate failed (#39192)
relate: https://github.com/milvus-io/milvus/pull/38943

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2025-01-14 17:47:04 +08:00
sthuang 4a47f760b3
fix: [2.5] rbac custom group privilege level check (#39164) (#39224)
cherry-pick from master: https://github.com/milvus-io/milvus/pull/39164
related: https://github.com/milvus-io/milvus/issues/39086

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-01-14 16:50:59 +08:00
zhenshan.cao 99a8274326
enhance: Add primary field name in SearchResult and QueryResults (#39222)
pr: https://github.com/milvus-io/milvus/pull/39220
issue: https://github.com/milvus-io/milvus/issues/39219

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2025-01-14 16:10:58 +08:00
Zhen Ye 54036bcafd
enhance: add broadcast operation for msgstream (#39119)
issue: #38399
pr: #39040

- make broadcast service available for msgstream by reusing the
architecture streaming service

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-14 15:11:00 +08:00
SimFG 7c8db6f61f
fix: [2.5] use the object heap to keep the min ddl ts order (#39195)
- issue: #39002
- pr: #39118

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-14 14:23:05 +08:00
smellthemoon 9a63383878
fix:[2.5] fail to get empty index num rows(#39155) (#39210)
pr: #39155
issue: #39125

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2025-01-14 13:24:59 +08:00
Zhen Ye adfc3f945e
enhance: record memory size (uncompressed) item for index (#38844)
issue: #38715 
pr: #38770

- Current milvus use a serialized index size(compressed) for estimate
resource for loading.
- Add a new field MemSize (before compressing) for index to estimate
resource.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-14 10:33:06 +08:00
foxspy 5b113064fe
enhance: update knowhere version (#39218)
/kind branch-feature
release-note :
https://github.com/zilliztech/knowhere/releases/tag/v2.5.2

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2025-01-14 10:21:06 +08:00
SimFG 68734fe4f7
enhance: [2.5] extract the task step execution process (#39196)
- issue: #38322
- pr: #38323

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-13 21:58:58 +08:00
yihao.dai 8fadcde403
fix: [2.5] Fix incorrect memory estimation for small segments (#38909)
Skip estimation index memory logic for segments without index file.

issue: https://github.com/milvus-io/milvus/issues/37630

pr: https://github.com/milvus-io/milvus/pull/38813

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-01-13 21:49:12 +08:00
sre-ci-robot a1b8bc7706
[automated] Bump milvus version to v2.5.3 (#39214)
Bump milvus version to v2.5.3
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-01-13 18:37:03 +08:00
congqixia ac730be5aa
enhance: Bump milvus & proto version to v2.5.3 (#39198)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-13 12:56:57 +08:00
sthuang 3059fae40d
fix: [2.5] fix restore rbac empty meta crash (#39143)
cp from master: https://github.com/milvus-io/milvus/pull/39141
related: https://github.com/milvus-io/milvus/issues/38985

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-01-13 12:04:58 +08:00
Zhen Ye 0aa592b081
fix: data race when accessing field_ when retrieving (#39152)
issue: #39148
pr: #39151

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-13 11:23:04 +08:00
tinswzy 39fa00fc1a
enhance: add intent ctx to rootcoord init (#38948)
issue: #38439 
cherry pick "enhance: add intent ctx to rootcoord init"

Signed-off-by: tinswzy <zhenyuan.wei@zilliz.com>
2025-01-11 23:54:57 +08:00
zhuwenxing 95df38e24f
test: add text match negative test case (#38982)
pr: https://github.com/milvus-io/milvus/pull/38981

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2025-01-11 14:21:03 +08:00
jaime b0afe32c98
fix: unstable ut in leader_vew_manager.go file (#39162)
issue: #38672
pr: #39161

Signed-off-by: jaime <yun.zhang@zilliz.com>
2025-01-10 19:54:57 +08:00
Buqian Zheng a43720f779
fix: [2.5] fix chunk cache madvise when sparse raw data is mmaped (#39146)
instead of marking as not supported,
ChunkedSparseFloatColumn::DataByteSize can simply use the impl of super
class.
pr: https://github.com/milvus-io/milvus/pull/39145
issue: #39158

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2025-01-10 16:24:58 +08:00
congqixia 6b127d4f5f
fix: [2.5] Return io error other than `NotExist` refreshing config (#38924) (#39072)
Cherry pick from master
pr: #38924
Related to #38923

This PR:

- Check whether `os.Stat` config file error is io.ErrNotExist
- Panic when get config return error during Milvus initialization

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-10 14:09:04 +08:00
XuanYang-cn afef5fed60
fix: Clustering compaction ignoring deltalogs (#39133)
See also: #39131
pr: #39132

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2025-01-10 14:07:05 +08:00
Zhen Ye 95809ca767
enhance: make new go package to manage proto (#39128)
issue: #39095
pr: #39114

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-10 10:53:01 +08:00
jaime 0693634f62
enhance: add db name in replica description (#38673)
issue: #36621
pr: #38672

Signed-off-by: jaime <yun.zhang@zilliz.com>
2025-01-09 19:43:04 +08:00
Spade A f70262c980
fix: build text index when loading field data (#39070) (#39113)
fix: https://github.com/milvus-io/milvus/issues/39053 may fix
https://github.com/milvus-io/milvus/issues/38644 which could be caused
by https://github.com/milvus-io/milvus/issues/39053

---------

Signed-off-by: SpadeA-Tang <tangchenjie1210@gmail.com>
2025-01-09 19:30:58 +08:00
smellthemoon f896b0e3e8
fix: Bulk insert failed when the nullable/default_value field is not exist(#39063) (#39111)
pr: #39063 
issue: #39036

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2025-01-09 19:27:04 +08:00
ThreadDao c2532def02
test: update cases for search params support and groupby issue fix (#38876)
pr: #38852
- update cases for WithSearchParam
- remove skip for groupby search issue
- update output query dynamic case for server changes

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
2025-01-09 19:12:56 +08:00
Bingyi Sun dad0d3b6e4
fix: Fix in filter search result is empty if pk type is varchar (#39108)
Cherry pick from master
pr: #39016
https://github.com/milvus-io/milvus/issues/39107

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2025-01-09 17:04:56 +08:00
Zhen Ye f2e581e2d7
enhance: add broadcast for streaming service (#39047)
issue: #38399
pr: #39020

- Add new rpc for transfer broadcast to streaming coord
- Add broadcast service at streaming coord to make broadcast message
sent automicly

also cherry pick the pr #38400

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-09 16:46:56 +08:00
wei liu 8a9b811781
enhance: Add resource group api on Restful (#38885) (#39092)
issue: #38739
pr: #38885
enable to manage resource group by Restful
- CreateResourceGroup
- DescribeResourceGroup
- UpdateResourceGroup
- ListResourceGroup
- DropResourceGroup
- TransferReplica

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-09 16:00:56 +08:00
SimFG ff3a128446
enhance: [2.5] update the expr static web page (#39091)
issue: #39083
pr: #39082
/kind improvement
Three new functions of the static web page:
1. The input box can be expanded and scrolled if it exceeds the maximum
size
2. Input history
3. It will simply check whether the quotation marks and brackets appear
in pairs

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-09 10:03:01 +08:00
wei liu 35cef0567c
enhance: Add log for case which target not update as expected (#38944) (#39046)
pr: #38944

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-08 19:32:57 +08:00
zhagnlu aecf04e369
fix: fix query incorrect in case of concurrent delete (#38991) (#39054)
pr: #38991

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2025-01-08 17:48:56 +08:00
yanliang567 76c66f07be
test: [cp2.5]Add search with hints for different expressions (#39062)
issue: https://github.com/milvus-io/milvus/issues/38877
pr: #39048

---------

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2025-01-08 16:24:57 +08:00
Gao b2b7cca910
fix: [2.5] set iterative filter hint to false when no expr specified (#39034)
issue: https://github.com/milvus-io/milvus/issues/39013
pr: #39033

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2025-01-08 12:58:56 +08:00
congqixia 4b62dfd11f
enhance: [2.5] Use mvcc timestamp as guarantee ts if set (#38980) (#39019)
Cherry pick from master
pr: #38980
When MvccTimestamp is set, it could be used as guarantee timestamp
directly instead of new ts allocated by scheduler reducing the waiting
time when delegator has tsafe lag

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-07 19:18:57 +08:00
Zhen Ye 6f1febe881
enhance: move streaming coord from datacoord to rootcoord (#39009)
issue: #38399
pr: #39007

We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier
implementation.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-07 17:56:56 +08:00
congqixia 0b62c1e692
enhance: [2.5] Optimize retrieve performance utilizing bitset SIMD methods (#39041)
Cherry pick from master
pr: #39004 #39037
Related to #39003

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-07 17:45:03 +08:00
XuanYang-cn b457c2f415
enhance: [2.5]Add missing delete metrics (#38634) (#38747)
Add 2 counter metrics:
- Total delete entries from deltalog:
milvus_datanode_compaction_delete_count
- Total missing deletes: milvus_datanode_compaction_missing_delete_count

See also: #34665
pr: #38634

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2025-01-07 11:20:56 +08:00
cai.zhang e6dd3e5a57
fix: [2.5]Remove valid expressions from invalid expressions (#38999)
issue: #39014 

master pr: #38957 
master pr: #39012

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2025-01-06 18:02:55 +08:00
yanliang567 aceb028e3a
test: [cp2.5]Refactor pymilvus client v2 testbase and add a test for search hint (#39006)
issue: https://github.com/milvus-io/milvus/issues/38877

    refactor pymilvus client v2 testcasebase
    add a test for search hint
    update pymilvus to 2.6

pr: #38939

---------

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2025-01-06 17:02:55 +08:00
cai.zhang b9da6a58e2
enhance: [2.5]Return collection not loaded rather than not found on querynode (#38593) (#38918)
issue: #38586

master pr: #38593

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2025-01-05 18:55:00 +08:00
nico 498b984607
enhance: delete one pod pipeline in nightly and open mmap in standalone(2.5) (#38888)
pr: #38887

Signed-off-by: nico <cheng.yuan@zilliz.com>
2025-01-03 16:38:55 +08:00
congqixia 6433f76c61
enhance: [2.5] Bump golang/x/net to v0.33 fixing security alarm (#38850) (#38932)
Cherry-pick from master
pr: #38850
Related to https://github.com/milvus-io/milvus/security/dependabot/106

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-03 14:50:54 +08:00
zhikunyao 055cbe1ac9
enhance: update opensource etcd version (#38969)
Signed-off-by: Zhikun Yao <zhikun.yao@zilliz.com>
2025-01-03 11:58:53 +08:00