357fe814ce
fix: Remove unnecessary deleteSession operation ( #31647 )
...
See also #31628
The `Revoke` operation shall delete all keys related to the lease
attaching to. This `deleteSession` operation may also remove the session
key in next epoch by mistake and cause chaos session status
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-03-29 13:57:11 +08:00
32cff25f97
enhance: decrease coordinator init time ( #29822 )
...
This PR mainly improve two items:
1. Target observer should refresh loading status during init time. An
uninitialized loading status blocks search/query. Currently, the target
observer refreshes every 10 seconds, i.e. we'd need to wait for 10s for
no reason. That's also the reason why we constantly see false log
"collection unloaded" upon mixcoord restarts.
2. Delete session when service is stopped. So that the new service
doesn't need to wait for the previous session to expire (~10s).
Item 1 is the major improvement of this PR, which should speed up init
time by 10s.
Item 2 is not a big concern in most cases as coordinators usually shut
down after stop(). In those cases, coordinator restart triggers serverID
change which further triggers an existing logic that deletes expired
session. This PR only fixes rare cases where serverID doesn't change.
integration test:
`go test -tags dynamic -v -coverprofile=profile.out -covermode=atomic
tests/integration/coordrecovery/coord_recovery_test.go -timeout=20m`
Performance after the change:
Average init time of coordinators: 10s
Hardware: M2 Pro
Test setup: 1000 collections with 1000 rows (dim=128) per collection.
issue: #29409
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2024-02-05 14:00:12 +08:00
6b1a106a31
Moving etcd client into session ( #27069 )
...
Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
2023-10-27 07:36:12 +08:00
9b0ecbdca7
Support to replicate the mq message ( #27240 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-10-20 14:26:09 +08:00
ac2d1bb5c2
Support receive signals from parent process ( #27756 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-10-18 20:20:11 +08:00
2f201c25e2
Remove deprecated io/ioutil usage ( #27747 )
...
`io/ioutil` package is deprecated, use `io`,`os` package replacement
also added golangci-lint rule to block future reference
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: guoguangwu <guoguangwu@magic-shield.com>
2023-10-17 20:32:09 +08:00
ec1fe3549e
Add a stop hook to clean session ( #27564 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-10-16 10:24:10 +08:00
0f14d18201
Optimize the codec code of session ( #27360 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-10-01 10:33:30 +08:00
c9653b1683
Add some log and improve TestSessionProcessActiveStandBy test case ( #27403 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-28 09:35:27 +08:00
9433a24f5d
fix component not exit when liveness check failed ( #27236 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-09-22 19:13:25 +08:00
26f06dd732
Format the code ( #27275 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-21 09:45:27 +08:00
16b35e07b3
Fix `TestSessionSuite/TestKeepAliveRetryActiveCancel` unit test logic ( #27231 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-20 18:59:23 +08:00
adfb5298c6
Refine `TestSessionProcessActiveStandBy` unit test logic ( #26980 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-11 18:13:17 +08:00
0e2085b77f
fix dc standby to active ( #26810 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-09-06 10:41:49 +08:00
fb0705df1b
Decouple basetable and componentparam ( #26725 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-09-05 10:31:48 +08:00
145387fdcb
Bump proto go-api to v2.3.0 ( #26561 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-23 20:18:23 +08:00
2b367b6bb0
Fix sessionutil Liveness check blcok in watch forever ( #26248 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-10 14:07:16 +08:00
7dfc8fbf0a
Fix data race on keepAliveCancel ( #26087 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-08-02 18:55:07 +08:00
587237a3c9
Fix dead loop in session ( #25451 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-07-13 18:02:29 +08:00
cd29b863d0
Fix data race in session ( #25354 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-07-06 14:52:25 +08:00
ebd0279d3f
Check error by Error() and NoError() for better report message ( #24736 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-06-08 15:36:36 +08:00
d0c2fa5d19
Fix retryKeepAlive assertion panic ( #24667 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-07 10:08:36 +08:00
5fb5b072ae
Retry keepalive when keepalive channel close ( #24581 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-06-01 16:14:35 +08:00
74bba2320a
Fix session stop/goingStop stuck after connection lost ( #24131 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-05-16 14:51:22 +08:00
43a9e175a3
Exit component process when session key is deleted ( #21658 ) ( #22164 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-04-12 20:12:28 +08:00
c9d0c157ec
Move some modules from internal to public package ( #22572 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-04-06 19:14:32 +08:00
7da870f512
Remove useCustomConfig and simpilify the session type ( #23166 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-04-03 20:10:24 +08:00
697dedac7e
Use cockroachdb/errors to replace other error pkg ( #22390 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-02-26 11:31:49 +08:00
e768437681
Correct usage of Timer and Ticker ( #22228 )
...
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2023-02-23 18:59:45 +08:00
b1f31da77a
Fix activate standby server ignores all errors ( #22073 )
...
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-02-09 15:24:31 +08:00
6a722396bd
Integration test framework ( #21283 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-01-12 19:49:40 +08:00
264f08953d
Refactor Rocksmq's config ( #21304 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-12-26 19:11:30 +08:00
f8cff79804
Support the graceful stop for the query node ( #20851 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-12-06 22:59:19 +08:00
19524a5344
Fix nodeID mismatch at standalone mode ( #20648 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-11-17 17:15:08 +08:00
956c5e1b9d
Make Params singleton ( #20088 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-11-04 14:25:38 +08:00
4cc57adc5d
Initiatively release session in etcd when service close ( #19825 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2022-10-18 19:13:26 +08:00
b0a12116c8
Fix meta migration tool ( #19814 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-10-17 15:07:25 +08:00
a8a074162f
Add meta migration tool ( #19709 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-10-12 11:37:23 +08:00
54e2c079c4
MEP-30:Support basic coordinators active-standby mechanism #16901 ( #19166 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2022-09-29 18:35:02 +08:00
d5bb377bc7
Add semver in session ( #18768 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-08-23 17:14:52 +08:00
6e7831470c
Revert settings of Pulsar address and refine config code ( #18494 )
...
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-08-02 21:26:33 +08:00
af994b5e1c
Fix etcd watch error ( #17364 )
...
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-06-06 16:26:06 +08:00
5494f3c318
Remove offLineNodes from watch states check ( #16347 )
...
This PR also
- adds more information in log
- makes Session able to logged by zap.Any/zap.String
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-04-01 22:33:29 +08:00
c7f55c2e34
Make SessionWatch keep watch even no Rewatch func when find ErrCompacted ( #15497 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-02-15 15:07:48 +08:00
69087ff8dd
Support embedded etcd ( #14333 )
...
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-12-29 14:35:21 +08:00
9f23fc7f2a
Register the service when the component state is healthy ( #13248 )
...
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2021-12-15 11:47:10 +08:00
405b3cd932
Use the same lint rules with golint in revive ( #13324 )
...
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-14 15:31:07 +08:00
de454956fe
Refactor session WatchSessions to allow rewatch when Rev Compacted ( #12880 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-08 10:11:04 +08:00
ee0f753f7a
Fix datarace between GetComponentStates and Register ( #11935 )
...
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-19 13:57:12 +08:00
5edbb82610
Add session revoke ( #11908 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-16 22:31:14 +08:00
congqixia
yiwangdr
Filip Haltmayer
SimFG
jaime
Jiquan Long
wei liu
Enwei Jiao
wayblink
yah01
cai.zhang
zhenshan.cao
Xiaofan
XuanYang-cn
Xiangyu Wang