Commit Graph

19037 Commits (20c9cfc5871a90829df6c80ff0eeb70c3f77c04e)

Author SHA1 Message Date
sre-ci-robot 20c9cfc587
[automated] Update Knowhere Commit (#30487)
Update Knowhere Commit
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-02-04 01:23:04 +08:00
yihao.dai 7ce876a072
fix: Decoupling importing segment from flush process (#30402)
This pr decoups importing segment from flush process by:
1. Exclude the importing segment from the flush policy, this approch
avoids notifying the datanode to flush the importing segment, which may
not exist.
2. When RootCoord call Flush, DataCoord directly set the importing
segment state to `Flushed`.

issue: https://github.com/milvus-io/milvus/issues/30359

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-02-03 13:01:12 +08:00
cai.zhang 36d3fd41e1
fix: Only use bound indexnodes in bound mode (#30461)
issue: #30463

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-02-03 11:01:47 +08:00
pingliu 5cdf0f2490
doc: fix standalone stop cannot start issue (#30481)
Signed-off-by: ping.liu <ping.liu@zilliz.com>
2024-02-02 21:05:05 +08:00
congqixia 1ab851d73f
enhance: Remove useless frequent log in Mintimestamp (#30471)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-02-02 20:39:05 +08:00
sre-ci-robot c7cf7c8cb5 Update all contributors
Signed-off-by: sre-ci-robot <sre-ci-robot@zilliz.com>
2024-02-02 12:00:50 +00:00
pingliu e4a033858e
doc: Add Milvus standalone all in one script (#30459)
Signed-off-by: ping.liu <ping.liu@zilliz.com>
2024-02-02 18:05:04 +08:00
xige-16 05ebe7b6ae
fix: fix hybrid search panic when has multi shard (#30464)
/kind bug
issue:#30457
Signed-off-by: xige-16 <xi.ge@zilliz.com>

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2024-02-02 17:25:12 +08:00
SimFG 02de84239d
fix: add more requests to the database interceptor (#30452)
issue: #30368

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-02-02 16:49:06 +08:00
xige-16 0a78b38bb8
fix: fix requery without partitionIDs in hybrid search (#30444)
issue: #30412 
Signed-off-by: xige-16 <xi.ge@zilliz.com>

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2024-02-02 16:47:13 +08:00
Bingyi Sun dcdf85977c
enhance: [skip e2e] add alter collection task ut (#30447)
Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-02-02 15:25:04 +08:00
nico 3b586709d1
enhance: add milvus client rbac test cases (#30456)
link: #30221

Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-02-02 15:09:04 +08:00
xige-16 6d7061824b
enhance: Opt maxVectorFieldNum param check (#30440)
Signed-off-by: xige-16 <xi.ge@zilliz.com>

---------

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2024-02-02 14:51:05 +08:00
yah01 ec688f5bf6
fix: failed to download OpenDAL (#30380)
OpenDAL's url has been changed
fix #30379

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-02-02 14:35:04 +08:00
Buqian Zheng 1632668b64
enhance: update milvus-proto dep to add sparse vector related protos (#30400)
issue: https://github.com/milvus-io/milvus/issues/29419

this PR solely adds proto definition. sparse float vector support will
be in subsequent PRs.

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-02-02 12:41:04 +08:00
XuanYang-cn d744962aa1
fix: Correct Size calculation of DeleteData (#30397)
This PR would correct the actual deltalog size

See also: #30191

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-02-02 10:47:04 +08:00
congqixia 1c1dd48b71
fix: Deprecated shard leader cache while deprecating collection (#30446)
Resolves: #30445

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-02-02 09:11:05 +08:00
XuanYang-cn e0ed5647b3
fix: Limit L0 Compaction segment size and count (#30374)
See also: #30191

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-02-01 20:39:03 +08:00
Bingyi Sun adaf270697
enhance: roll back apimachinery to v0.28.6 (#30398)
apimachinery use go 1.21 in v0.29.0
reference issue: golang/go#62409

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-02-01 20:31:03 +08:00
smellthemoon 6bc10f9fdd
enhance: support varchar autoid when bulkinsert (#30377)
support varchar autoid when bulkinsert

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-02-01 19:45:09 +08:00
Bingyi Sun e22e8b30d4
enhance: check load state before altering collection (#30399)
/kind improvement

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-02-01 18:03:04 +08:00
xige-16 060c8603a3
fix: Support mvcc with hybrid serach (#30114)
issue: https://github.com/milvus-io/milvus/issues/29656
/kind bug

Signed-off-by: xige-16 <xi.ge@zilliz.com>

---------

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2024-02-01 16:03:03 +08:00
sammy.huang 32914a3ddf
enhance: [skip e2e]cleanup unnecessary part in the github action (#30425)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2024-02-01 14:39:04 +08:00
XuanYang-cn fb5e09d94d
fix: call injectDone after compaction failed (#30277)
syncMgr.Block() will lock the segment when executing compaction.

Previous implementation was unable to Unblock thoese segments when
compaction failed. If next compaction of the same segments arrives,
it'll stuck forever and block all later compation tasks.

This PR makes sure compaction executor would Unblock these segments
after a failure compaction.

Apart form that, this PR also refines some logs and clean some codes of
compaction, compactor:

1. Log segment count instead of segmentIDs to avoid logging too many
segments
2. Flush RPC returns L1 segments only, skip L0 and L2
3. CompactionType is checked in `Compaction`, no need to check again
inside compactor
4. Use ligter method to replace `getSegmentMeta`
5. Log information for L0 compaction when encounters an error

See also: #30213

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-02-01 14:25:04 +08:00
Jiquan Long e549148a19
enhance: full-support for wildcard pattern matching (#30288)
issue: #29988 
This pr adds full-support for wildcard pattern matching from end to end.
Before this pr, the users can only use prefix match in their expression,
for example, "like 'prefix%'". With this pr, more flexible syntax can be
combined.

To do so, this pr makes these changes:
- 1. support regex query both on index and raw data;
- 2. translate the pattern matching to regex query, so that it can be
handled by the regex query logic;
- 3. loose the limit of the expression parsing, which allows general
pattern matching syntax;

With the support of regex query in segcore backend, we can also add
mysql-like `REGEXP` syntax later easily.

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-02-01 12:37:04 +08:00
sammy.huang 46d9ac5931
enhance: move the option of network mode into builder.sh file (#30419)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2024-02-01 11:49:03 +08:00
XuanYang-cn e0f371c99b
fix: [skip e2e]use unique topic name for test pulsarCtl (#30364)
See also: #30363

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-02-01 11:05:04 +08:00
congqixia be8831b311
enhance: Reduce get segments scan during l0 compaction (#30408)
See also #27606

Previously l0 linear compaction will scan all target segment id from
metacache for each line of delta entry, which is not needed since
compaction target segments shall be all immutable.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-02-01 10:59:03 +08:00
sammy.huang 265453f400
enhance: [skip e2e]revert back to original way to archive, upload and download (#30248)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2024-02-01 10:15:04 +08:00
zhuwenxing b02b525196
test: refine debug log and error handle (#30406)
refine debug log and error handle

---------

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-02-01 09:59:05 +08:00
congqixia e677af19b0
enhance: Add PrimaryKeys interface to reduce memory usage (#30405)
See also #30404

`PrimaryKey` is used to hold pk values for both int64 & varchar data
type. Since it is an interface it may occupies more memory than pure
slices when holding a group of pks.

This PR add `PrimaryKeys` interface when some other module need to hold
lots of PrimaryKeys.
By using this interface, it could reduce the memory of pk slice to half
when using Int64 Pk data type and reduce interface cost for each row of
varchar as well.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-02-01 09:57:11 +08:00
yihao.dai c5918290e6
feat: Add import executor and manager for datanode (#29438)
This PR introduces novel importv2 roles for datanode:
1. Executor: To execute tasks, a import task will be divided into the
following steps: read data -> hash data -> sync data;
2. Manager: To manage all the tasks;

issue: https://github.com/milvus-io/milvus/issues/28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-01-31 20:45:04 +08:00
congqixia fc0d007bd1
enhance: Add `MemoryHighSyncPolicy` back to write buffer manager (#29997)
See also #27675

This PR adds back MemoryHighSyncPolicy implementation. Also change
MinSegmentSize & CheckInterval to configurable param item.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-31 19:03:04 +08:00
congqixia b5e078c4d3
enhance: Remove current stats after RollStats action (#30391)
See also #27675

BloomFilterSet.current shall be reset after RollStats, otherwise it will
keep tracking whole segment data causing the false positive ratio larger
than expected.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-31 18:55:04 +08:00
PowderLi 5cf9bb236e
enhance: restful support import jobs (#30343)
issue: #28521 #29732

include
1. list collection's import jobs
2. create a new import job
3. get the progress of an import job

fix:
1. mix the order of dbName & collectionName #29728
2. trace log keep the same as v1
3. support traceID
4. azure precheck, blob name cannot end with / #29703

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-01-31 17:57:04 +08:00
yah01 2f778d9649
fix: proxy may never setup if the port binded (#30035)
the proxy miss-returned nil while failed to listen the port, then the
server continues to run but we can't connect to service
resolve #30034

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2024-01-31 17:37:04 +08:00
yanliang567 54150253e7
enhance: Add more tests for groupby (#30346)
Related issue: #30033
skip the tests before bug fixes

---------

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2024-01-31 17:23:03 +08:00
yah01 878c4c9463
enhance: limit the max pool size to 16 (#30371)
according to our benchmark, concurrency level 16 is enough to fully
utilize the object storage network bandwidth

Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-31 14:13:06 +08:00
zhuwenxing e6daff49a6
test: fix query result verification (#30351)
fix query result verification:
changed the query expression and adopted a more lenient validation
method to address the issue of not being able to guarantee the retrieval
of specific IDs due to frequent deletion operation

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-01-31 14:11:04 +08:00
sammy.huang fb9d64ab1e
enhance: hotfix container network (#30389)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2024-01-31 10:23:05 +08:00
sammy.huang fda6f8d04e
enhance: hotfix docker-compose.yml (#30378)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2024-01-30 19:23:04 +08:00
chyezh 6d63fb5d3f
fix: panic with datanode negetive wait group counter (#30135)
issue: #29170

Signed-off-by: chyezh <chyezh@outlook.com>
2024-01-30 18:15:04 +08:00
cai.zhang 47af347d0e
enhance: Limit index pool size of standalone server (#30170)
issue: #29926

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-01-30 16:47:03 +08:00
cai.zhang f619d792c0
enhance: Break down the granularity of collection info cache expired (#29977)
issue: #29772 

1. `DropPartition` only invalidates the cache related to the partition.
2. `CreateAlias` does not invalidate the cache.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-01-30 16:45:02 +08:00
nico 168260cba3
test: update test cases about rbac (#29088)
issue: #29087
RBAC cases fail a lot.
1. some cases are out of date, for example, the default value of db_name
has changed from "default" to "" in some apis
2. add time sleep after the action of grant or revoke, for it costs time
to take effect

Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-01-30 11:33:02 +08:00
congqixia 7c086a4608
enhance: Set delete scope for LoadSegment streaming data (#30245)
See also #29474

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-30 11:13:02 +08:00
congqixia 0c7a96b48d
enhance: Make compaction log has traceID (#30338)
See also #30167

After support open telemetry tracing, we want to have traceID as well,
this PR adds util functions to set traceID with span & propagate traceID
between different context.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-30 10:09:03 +08:00
congqixia 743bdf1434
enhance: Make l0 compactor download files in parallel (#30309)
See also #27606

`MultiRead` actually download file in sequence, which may lead to large
time consumption during l0 compaction download phase.

This PR make l0 compactor download deltalogs in parallel utilizing conc
package & io pool.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-30 10:07:09 +08:00
cqy123456 74cfba0249
enhance:limit binlog index rows num (#30173)
issue: https://github.com/milvus-io/milvus/issues/27678
also relate issue: https://github.com/milvus-io/milvus/issues/30065

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-01-29 19:49:02 +08:00
zhuwenxing f92edc6cc5
test: Update requirements and pytest configuration (#30336)
Update requirements and pytest configuration

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-01-29 18:59:02 +08:00