Commit Graph

8555 Commits (backup/2.4_20240430)

Author SHA1 Message Date
SimFG 868723340c
enhance: [2.4] the list collection and database api (#32602)
issue: https://github.com/milvus-io/milvus/issues/32550
pr: #32576
/kind improvement

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-29 14:21:26 +08:00
SimFG 5da6db9252
enhance: [2.4] add the skip auto id and partition key check config (#32597)
/kind improvement
issue: https://github.com/milvus-io/milvus/issues/32591
pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-29 10:19:31 +08:00
Gao 05c14d4c21
enhance: update knowhere version (#32559)
master pr: https://github.com/milvus-io/milvus/pull/32468

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-04-28 19:31:25 +08:00
yihao.dai 51e08556a9
fix: Correct the negative queryable num entities metric (#32361) (#32581)
issue: https://github.com/milvus-io/milvus/issues/32281

pr: https://github.com/milvus-io/milvus/pull/32361

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-04-28 15:13:26 +08:00
yihao.dai 6178355e2f
fix: Remove watching config event in rate limiter (#32313) (#32314)
Remove watching config event in rate limiter to prevent object leaks.
Instead, reset limiter rates periodically.

issue: https://github.com/milvus-io/milvus/issues/32312

pr: https://github.com/milvus-io/milvus/pull/32313

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-04-28 11:35:28 +08:00
congqixia 193f88bec3
enhance: [2.4] Make applyDelete work in paralell in segment level (#32291) (#32604)
Cherry-pick from master
pr: #32291
`applyDelete` used to be serial for delete entries on each segments.
This PR make it work in parallel with errgroup to improve performance

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-26 18:09:27 +08:00
SimFG 4f465343d3
enhance: [2.4] update the go-api version for the list api (#32606)
issue: https://github.com/milvus-io/milvus/issues/32550
pr: #32605
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-26 17:49:33 +08:00
XuanYang-cn cd830f8cbc
fix: [cp]Zero flushReq metric for all sealed segs (#32531)
See also: #32399
pr: #32404

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-04-26 15:17:28 +08:00
zhagnlu 8e7c9ee00e
fix: correct AssignSegmentID return and add retry for loadCollectionF… (#32349)
pr: #32335

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-04-25 14:31:25 +08:00
congqixia e1b4ef7451
enhance: [2.4] Make LeaderView Manager filter use map index (#32505) (#32528)
Cherry-pick from master
pr: #32505
See also #32165

Change `LeaderViewFilter` to interface to provided map key to avoid
iterating all key-values in LeaderViewManager

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-24 18:01:25 +08:00
congqixia 1aba9eb616
fix: [2.4] Remove metrics after flowgraph closed (#32515) (#32539)
Cherry-pick from master
pr: #32515
See also #32403

`fg_buffer_size` was decreased after metrics removed in flowgraph
ddnode, which make metrics value negative.

This PR move remove metrics logic into `dataSyncService.Close`

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-24 14:21:24 +08:00
PowderLi 7cace01d22
fix: [restful v2] parameters of create collection (#32486)
issue: #31176
master pr: #32485

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-04-24 09:43:28 +08:00
congqixia 71c30c9144
enhance: [2.4] Make querycoordv2 collection observer task driven (#32441) (#32493)
Cherry-pick from master
pr: #32441
See also #32440

- Add loadTask in collection observer
- For load collection/partitions, load task shall timeout as a whole
- Change related constructor to load jobs

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-23 20:09:23 +08:00
zhagnlu 969e9cc63e
fix: add bitset sve support macro protect (#32464)
pr: #32463

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-04-22 12:29:24 +08:00
congqixia 8b0d445aac
enhance: [2.4] Manual release pool after save targets (#32358) (#32457)
Cherry-pick from master
pr: #32358 
See also #31632

Release conc.Pool after usage to clean worker and stop background purge
and ticktock.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-22 10:11:22 +08:00
yiwangdr 87719caab4
enhance: [2.4]speed up minor functions calls in datacoord (#32477)
Related to https://github.com/milvus-io/milvus/issues/32165

Duplicate of #32389 but for 2.4 branch.

Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2024-04-20 11:45:21 +08:00
PowderLi 21474c1ab0
fix: [restful]use default search parameter `nq: 0` (#32356)
issue: #32225
master pr: #32355

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq #31978

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-04-18 14:35:19 +08:00
congqixia 8f7ac8f7b8
enhance: [2.4] Use map instead of slice to maintain channel info (#32273) (#32316)
Cherry-pick from master
pr: #32273
See also #32165

`ChannelManager.Match` is a frequent operation for datacoord. When the
collection number is large, iteration over all channels will cost lots
of CPU time and time consuming.

This PR change the data structure storing datanode-channel info to map
avoiding this iteration when checking channel existence.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-17 19:07:20 +08:00
zhagnlu cee6071300
fix: remove sve flags (#32275)
pr: #32270

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-04-16 20:27:32 +08:00
Jiquan Long 0e5118b1ba
fix: remove useless log of quota center (#32307) (#32310)
/kind improvement
pr: #32307

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-04-16 18:39:19 +08:00
SimFG 52cc1ed9d8
enhance: [2.4] make the auth error message more suitable (#32298)
issue: #32252
pr: #32253
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-16 17:13:19 +08:00
SimFG d565d64941
enhance: [2.4] make datanode exit and case `TestProxy` faster (#32293)
/kind improvement
issue: #32219
pr: #32218

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-16 16:37:20 +08:00
yiwangdr 018a784989
enhance: speed up GetByCollection/AndNode (2.4 patch) (#32234)
Related to https://github.com/milvus-io/milvus/issues/32165

Avoid iterating through all replicas/collections if possible. Iteration
is expensive when there are large number of replicas/collections.

Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2024-04-15 19:53:21 +08:00
congqixia 9e3099e20e
enhance: [2.4] Maintain collection-patitions mapping in qc meta (#32227) (#32249)
Cherry-pick from master
pr: #32227
Related to #32165

Add collection to partitionIDs mapping to avoid interation on all
partitions loaded when trying to get all partitions with collection id

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-15 18:15:19 +08:00
wei liu 2726d639f9
fix: fix collectionInfo leak in datacoord (#32243)
issue: #32029
pr: #32175 

lack of logic to clean collection info in datacoord's meta, This PR
clean collection info after drop channel, to avoid collection info leak
in datacoord

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-04-15 17:21:19 +08:00
Gao 0df0972eb4
enhance: support disable search optimization (#32142)
pr: https://github.com/milvus-io/milvus/pull/32141

---------

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-04-15 17:17:20 +08:00
XuanYang-cn 0a3a483d02
enhance: [cherry-pick]Use channel manager interface in server_test (… (#32211)
…#31621)

Tidy the following test codes

    - Remove channel in newTestServer
    - Remove newTestServerWithMeta
    - Remove newTestServer2
    - Remove testDataCoordBase
    - Use the same func for handleTTmsg and handleRPCTTmsg

See also: #31620
pr: #31621

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-04-15 11:57:20 +08:00
wei liu e50599ba10
fix: Skip to load l0 segment on old version query node (#32131)
issue: #32107
pr: #32124

during rolling upgrade progress, skip to load l0 segment on old version
query node

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-04-15 11:23:23 +08:00
yihao.dai b68af208bc
fix: Use pk from binlog during import (#32118) (#32194)
During binlog import, even if the primary key's autoID is set to true,
the primary key from the binlog should be used instead of being
reassigned.

issue: https://github.com/milvus-io/milvus/discussions/31943,
https://github.com/milvus-io/milvus/issues/28521

pr: https://github.com/milvus-io/milvus/pull/32118

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-04-15 10:31:19 +08:00
Chun Han 5f7edc7304
fix: lack good results for insufficient ef(#29883) (#32151)
related: #29883
pr: https://github.com/milvus-io/milvus/pull/32080
see also: #29883

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-04-13 22:13:23 +08:00
yihao.dai 9cb640fe78
fix: Fix import hanging and improve logging output (#32166) (#32167)
Fix import hanging when the previous import task failed, and improve
parquet import logging outout.

issue: https://github.com/milvus-io/milvus/issues/31834

pr: https://github.com/milvus-io/milvus/pull/32166

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-04-13 22:03:23 +08:00
PowderLi 3946368e82
fix: restful v2 (#32160)
issue: #31176
master pr: #32144

cannot get dbName correctly while describe alias
https://github.com/milvus-io/milvus/issues/31978
return a valid json string even if the user doesn't have the whole
privileges to describe collection
https://github.com/milvus-io/milvus/issues/31635
rename IndexParam.IndexConfig to IndexParam.Params
FieldSchema.ElementTypeParams, IndexParam.Params can not only accept
string

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-04-13 21:55:29 +08:00
Jiquan Long 3a1e0c3b18
fix: put inverted index into local storage (#32209) (#32210)
issue: https://github.com/milvus-io/milvus/issues/32154
pr: #32209

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-04-13 21:53:18 +08:00
congqixia e00772a098
fix: [2.4] Wait StandBy server ready for testcase (#32216) (#32230)
Cherry-pick from master
pr: #32216
See also #32069

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-13 12:03:23 +08:00
Cai Yudong 9613d368c9
fix: fix estimate float16 field data size wrong (#32196)
issue: #32192 
pr: #32193

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2024-04-12 16:29:26 +08:00
congqixia e18ddfc06d
enhance: [Cherry-pick] Make write buffer memory check do until safe (#32172) (#32201)
Cherry-pick from master
pr: #32172
See also #27675 #26177

Make memory check evict memory buffer until memory water level is safe.
Also make `EvictBuffer` wait until sync task done.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-12 16:03:20 +08:00
zhenshan.cao cbac23a8ff
fix: failed to raise metric_type not match error (#32203)
issue:https://github.com/milvus-io/milvus/issues/32176
pr:https://github.com/milvus-io/milvus/pull/32202

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-04-12 15:57:19 +08:00
wei liu e495073e4b
fix: Use correct ts to avoid exclude segment list leak (#32191)
issue: #31990
pr: #31991

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-04-12 15:11:19 +08:00
congqixia 5457829660
fix: [Cherry-pick] Make `ResourceGroup.nodes` concurrent safe (#32159) (#32200)
Cherry-pick from master
pr: #32159
See also #32158

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-12 15:05:20 +08:00
zhenshan.cao 6d7c6db49c
fix: fix incomplete hybrid search result when nq > 1 (#32178)
pr: https://github.com/milvus-io/milvus/pull/32177
issue: https://github.com/milvus-io/milvus/issues/25639

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-04-12 10:31:19 +08:00
Alexander Guzhva a72a9cd9cb
fix: [2.4] [Cherry-pick] dynamically resolve whether SVE is available for bitset (#32139)
Issue: https://github.com/milvus-io/milvus/issues/32129
pr: #32137 
This PR adds a dynamic SVE detection for ARM CPU families for the bitset
code.
Also, allows the code to be compiled if the compiler does not support
NEON (arm-v7).

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
2024-04-12 10:01:20 +08:00
jaime 5b45debb28
enhance: refine sync memory watermark configuration (#32138)
pr: #32140

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-04-11 20:07:24 +08:00
congqixia 7f683000e9
fix: [2.4] Make coordinator `Register` not blocked on ProcessActiveStandby(#32069) (#32132)
Cherry-pick from master
pr: #32069
See also #32066

This PR make coordinator register successful and let
`ProcessActiveStandBy` run async. And roles may receive stop signal and
notify servers.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-04-11 17:31:19 +08:00
zhenshan.cao 329e73b58b
fix: partitionIDs should be union of partitionIDs of each subquery (#32147)
issue: https://github.com/milvus-io/milvus/issues/25639

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-04-11 15:41:19 +08:00
yihao.dai 246ef454dc
enhance: Add binlog import intergration test (#32112) (#32146)
issue: https://github.com/milvus-io/milvus/issues/28521

pr: https://github.com/milvus-io/milvus/pull/32112

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-04-11 15:17:20 +08:00
yihao.dai d11309b37f
enhance: Support $meta key for json import (#32013) (#32121)
During JSON import:
1. Allow the specification of the $meta key
2. Prohibit duplicated keys within the $meta field, for instance,
`{"id": 1, "vector": [], "x": 6, "$meta": {"x": 8}}`

issue: https://github.com/milvus-io/milvus/issues/31835

pr: https://github.com/milvus-io/milvus/pull/32013

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-04-11 15:15:28 +08:00
SimFG 4ea2a98fa3
enhance: [2.4] support to invalid the database meta cache (#32092)
issue: #32077
pr: #32078
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-11 15:01:20 +08:00
Xiaofan ada0e8c931
fix: reduce didn't handle offset without limit and reduceStopForBest … (#32088)
fix https://github.com/milvus-io/milvus/issues/32059
pr: https://github.com/milvus-io/milvus/pull/32089

this pr fix two issues:

offset is not handled correctly without specify a limit
reduceStopForBest doesn't guarantee to return limit result even if there
are more result when there is small segment

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2024-04-10 21:21:07 -07:00
SimFG 35f39593aa
enhance: [2.4] add the db id for the describe collection response (#32123)
/kind improvement
issue: #32110
pr: #32114

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-11 10:25:19 +08:00
wei liu 94e35793c6
enhance: Refactor leader view manager interface (#31133) (#32127)
issue: #31091
pr: #31133
This PR add GetByFilter interface in leader view manager, instead of all
kind of get func

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-04-11 10:01:23 +08:00