milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix golint error of PopTask in queryCoord (#10232) 

Signed-off-by: xige-16 <xi.ge@zilliz.com>
pull/10250/head
xige-16 2021-10-20 11:12:35 +08:00 committed by GitHub
parent cd6a4a6704
commit c298a14e08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/querycoord/task_scheduler.go
View File

@ -96,7 +96,7 @@ func (queue *TaskQueue) addTaskToFront(t task) {
}
// PopTask pops a trigger task from task list
func (queue *TaskQueue) PopTask() task {
func (queue *TaskQueue) popTask() task {
queue.Lock()
defer queue.Unlock()
@ -599,7 +599,7 @@ func (scheduler *TaskScheduler) scheduleLoop() {
scheduler.stopActivateTaskLoopChan <- 1
return
case <-scheduler.triggerTaskQueue.Chan():
triggerTask = scheduler.triggerTaskQueue.PopTask()
triggerTask = scheduler.triggerTaskQueue.popTask()
log.Debug("scheduleLoop: pop a triggerTask from triggerTaskQueue", zap.Int64("triggerTaskID", triggerTask.getTaskID()))
alreadyNotify := true
if triggerTask.getState() == taskUndo || triggerTask.getState() == taskDoing {

2
internal/querycoord/task_scheduler_test.go
View File

@ -412,7 +412,7 @@ func TestReloadTaskFromKV(t *testing.T) {
taskScheduler.reloadFromKV()
task := taskScheduler.triggerTaskQueue.PopTask()
task := taskScheduler.triggerTaskQueue.popTask()
assert.Equal(t, taskDone, task.getState())
assert.Equal(t, 1, len(task.getChildTask()))
}