From c298a14e083eff2458f29036b39c7719279cc55f Mon Sep 17 00:00:00 2001 From: xige-16 Date: Wed, 20 Oct 2021 11:12:35 +0800 Subject: [PATCH] Fix golint error of PopTask in queryCoord (#10232) Signed-off-by: xige-16 --- internal/querycoord/task_scheduler.go | 4 ++-- internal/querycoord/task_scheduler_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/querycoord/task_scheduler.go b/internal/querycoord/task_scheduler.go index 516ef93144..2a56244969 100644 --- a/internal/querycoord/task_scheduler.go +++ b/internal/querycoord/task_scheduler.go @@ -96,7 +96,7 @@ func (queue *TaskQueue) addTaskToFront(t task) { } // PopTask pops a trigger task from task list -func (queue *TaskQueue) PopTask() task { +func (queue *TaskQueue) popTask() task { queue.Lock() defer queue.Unlock() @@ -599,7 +599,7 @@ func (scheduler *TaskScheduler) scheduleLoop() { scheduler.stopActivateTaskLoopChan <- 1 return case <-scheduler.triggerTaskQueue.Chan(): - triggerTask = scheduler.triggerTaskQueue.PopTask() + triggerTask = scheduler.triggerTaskQueue.popTask() log.Debug("scheduleLoop: pop a triggerTask from triggerTaskQueue", zap.Int64("triggerTaskID", triggerTask.getTaskID())) alreadyNotify := true if triggerTask.getState() == taskUndo || triggerTask.getState() == taskDoing { diff --git a/internal/querycoord/task_scheduler_test.go b/internal/querycoord/task_scheduler_test.go index 51ca575661..9fea3435dd 100644 --- a/internal/querycoord/task_scheduler_test.go +++ b/internal/querycoord/task_scheduler_test.go @@ -412,7 +412,7 @@ func TestReloadTaskFromKV(t *testing.T) { taskScheduler.reloadFromKV() - task := taskScheduler.triggerTaskQueue.PopTask() + task := taskScheduler.triggerTaskQueue.popTask() assert.Equal(t, taskDone, task.getState()) assert.Equal(t, 1, len(task.getChildTask())) }