milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skip e2e] Add note for design doc (#13589) 

Signed-off-by: yhmo <yihua.mo@zilliz.com>
pull/13601/head
groot 2021-12-17 14:37:30 +08:00 committed by GitHub
parent cc04834b81
commit 9d65ba3393
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
docs/design_docs/drop_collection_release_resources_en.md
View File

@ -26,23 +26,23 @@ DataNode ignites Flush&Drop
**Plan 1: Picked** **Plan 1: Picked**
Add a `dropped` flag in `SaveBinlogPathRequest` proto Add a `dropped` flag in `SaveBinlogPathRequest` proto.
DataNode DataNode
- Flush all segments in this vChannel, When Flush&Drop, set the `dropped` flag true. - Flush all segments in this vChannel, When Flush&Drop, set the `dropped` flag true.
- If fails, retry at most 10 times and restart - If fails, retry at most 10 times and restart.
DataCoord DataCoord
- DataCoord marks segmentInfo as `dropped`, doesn't remove segmentInfos from etcd - DataCoord marks segmentInfo as `dropped`, doesn't remove segmentInfos from etcd.
- When recovery, check if the segments in the vchannel are all dropped - When recovery, check if the segments in the vchannel are all dropped.
- if not, recover before the drop - if not, recover before the drop.
- if so, no need to recover the vchannel - if so, no need to recover the vchannel.
Pros: Pros:
1. The easiest approach in both DataNode and DataCoord 1. The easiest approach in both DataNode and DataCoord.
2. DN can reuse the current flush manager procedure 2. DN can reuse the current flush manager procedure.
Cons: Cons:
1. The No. rpc call is equal to the No. segments in a collection, expensive 1. The No. rpc call is equal to the No. segments in a collection, expensive.
--- ---