From 9d65ba3393a682f9baf87526dde20676cd9f5fb0 Mon Sep 17 00:00:00 2001 From: groot Date: Fri, 17 Dec 2021 14:37:30 +0800 Subject: [PATCH] [skip e2e] Add note for design doc (#13589) Signed-off-by: yhmo --- .../drop_collection_release_resources_en.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/design_docs/drop_collection_release_resources_en.md b/docs/design_docs/drop_collection_release_resources_en.md index 671479b981..ac328798bb 100644 --- a/docs/design_docs/drop_collection_release_resources_en.md +++ b/docs/design_docs/drop_collection_release_resources_en.md @@ -26,23 +26,23 @@ DataNode ignites Flush&Drop **Plan 1: Picked** -Add a `dropped` flag in `SaveBinlogPathRequest` proto +Add a `dropped` flag in `SaveBinlogPathRequest` proto. DataNode - Flush all segments in this vChannel, When Flush&Drop, set the `dropped` flag true. - - If fails, retry at most 10 times and restart + - If fails, retry at most 10 times and restart. DataCoord -- DataCoord marks segmentInfo as `dropped`, doesn't remove segmentInfos from etcd -- When recovery, check if the segments in the vchannel are all dropped - - if not, recover before the drop - - if so, no need to recover the vchannel +- DataCoord marks segmentInfo as `dropped`, doesn't remove segmentInfos from etcd. +- When recovery, check if the segments in the vchannel are all dropped. + - if not, recover before the drop. + - if so, no need to recover the vchannel. Pros: - 1. The easiest approach in both DataNode and DataCoord - 2. DN can reuse the current flush manager procedure + 1. The easiest approach in both DataNode and DataCoord. + 2. DN can reuse the current flush manager procedure. Cons: - 1. The No. rpc call is equal to the No. segments in a collection, expensive + 1. The No. rpc call is equal to the No. segments in a collection, expensive. ---