kubernetes
/
website
mirror of https://github.com/kubernetes/website.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
website/content/en/docs/contribute/advanced.md

9.3 KiB
Raw Blame History

title slug content_template weight
Advanced contributing advanced templates/concept 30

{{% capture overview %}}

This page assumes that you've read and mastered the Start contributing and Intermediate contributing topics and are ready to learn about more ways to contribute. You need to use the Git command line client and other tools for some of these tasks.

{{% /capture %}}

{{% capture body %}}

Be the PR Wrangler for a week

SIG Docs approvers take regular turns as the PR wrangler for the repository and are added to the PR Wrangler rotation scheduler for weekly rotations.

The PR wrangler’s duties include:

  • Review open pull requests daily for quality and adherence to the style guide.
    • Review the smallest PRs (size/XS) first, then iterate towards the largest (size/XXL).
    • Review as many PRs as you can.
  • Ensure that the CLA is signed by each contributor.
    • Help new contributors sign the CLA.
    • Use this script to automatically remind contributors that haven’t signed the CLA to sign the CLA.
    • Close any PR where the CLA hasn’t been signed for two weeks. PR authors can reopen the PR after signing the CLA, so this is a low-risk way to make sure nothing gets merged without a signed CLA.
  • Provide feedback on proposed changes and help facilitate technical reviews from members of other SIGs.
    • Provide inline suggestions on the PR for the proposed content changes.
    • If you need to verify content, comment on the PR and request more details.
    • Assign relevant sig/ label(s).
    • If needed, assign reviewers from the reviewers: block in the file's front matter.
    • Assign Docs Review and Tech Review labels to indicate the PR's review status.
    • AssignNeeds Doc Review or Needs Tech Review for PRs that haven't yet been reviewed.
    • Assign Doc Review: Open Issues or Tech Review: Open Issues for PRs that have been reviewed and require further input or action before merging.
    • Assign /lgtm and /approve labels to PRs that can be merged.
  • Merge PRs when they are ready, or close PRs that shouldn’t be accepted.
  • Triage and tag incoming issues daily. See Intermediate contributing for guidelines on how SIG Docs uses metadata.

Helpful GitHub queries for wranglers

The following queries are helpful when wrangling. After working through these three queries, the remaining list of PRs to be reviewed is usually small. These queries specifically exclude localization PRs, and only include the master branch (except for the last one).

  • No CLA, not eligible to merge: Remind the contributor to sign the CLA. If they have already been reminded by both the bot and a human, close the PR and remind them that they can open it after signing the CLA. Do not review PRs whose authors have not signed the CLA!
  • Needs LGTM: If it needs technical review, loop in one of the reviewers suggested by the bot. If it needs docs review or copy-editing, either suggest changes or add a copyedit commit to the PR to move it along.
  • Has LGTM, needs docs approval: Determine whether any additional changes or updates need to be made for the PR to be merged. If you think the PR is ready to be merged, comment /approve.
  • Not against master: If it's against a dev- branch, it's for an upcoming release. Make sure the release meister knows about it by adding a comment with /assign @<meister's_github-username>. If it's against an old branch, help the PR author figure out whether it's targeted against the best branch.

Propose improvements

SIG Docs members can propose improvements.

After you've been contributing to the Kubernetes documentation for a while, you may have ideas for improvement to the style guide, the toolchain used to build the documentation, the website style, the processes for reviewing and merging pull requests, or other aspects of the documentation. For maximum transparency, these types of proposals need to be discussed in a SIG Docs meeting or on the kubernetes-sig-docs mailing list. In addition, it can really help to have some context about the way things currently work and why past decisions have been made before proposing sweeping changes. The quickest way to get answers to questions about how the documentation currently works is to ask in the #sig-docs Slack channel on kubernetes.slack.com

After the discussion has taken place and the SIG is in agreement about the desired outcome, you can work on the proposed changes in the way that is the most appropriate. For instance, an update to the style guide or the website's functionality might involve opening a pull request, while a change related to documentation testing might involve working with sig-testing.

Coordinate docs for a Kubernetes release

SIG Docs approvers can coordinate docs for a Kubernetes release.

Each Kubernetes release is coordinated by a team of people participating in the sig-release Special Interest Group (SIG). Others on the release team for a given release include an overall release lead, as well as representatives from sig-pm, sig-testing, and others. To find out more about Kubernetes release processes, refer to https://github.com/kubernetes/sig-release.

The SIG Docs representative for a given release coordinates the following tasks:

  • Monitor the feature-tracking spreadsheet for new or changed features with an impact on documentation. If documentation for a given feature won't be ready for the release, the feature may not be allowed to go into the release.
  • Attend sig-release meetings regularly and give updates on the status of the docs for the release.
  • Review and copyedit feature documentation drafted by the SIG responsible for implementing the feature.
  • Merge release-related pull requests and maintain the Git feature branch for the release.
  • Mentor other SIG Docs contributors who want to learn how to do this role in the future. This is known as "shadowing".
  • Publish the documentation changes related to the release when the release artifacts are published.

Coordinating a release is typically a 3-4 month commitment, and the duty is rotated among SIG Docs approvers.

Serve as a New Contributor Ambassador

SIG Docs approvers can serve as New Contributor Ambassadors.

New Contributor Ambassadors work together to welcome new contributors to SIG-Docs, suggest PRs to new contributors, and mentor new contributors through their first few PR submissions.

Responsibilities for New Contributor Ambassadors include:

  • Being available on the Kubernetes #sig-docs channel to answer questions from new contributors.
  • Working with PR wranglers to identify good first issues for new contributors.
  • Mentoring new contributors through their first few PRs to the docs repo.
  • Helping new contributors create the more complex PRs they need to become Kubernetes members.
  • Sponsoring contributors on their path to becoming Kubernetes members.

Current New Contributor Ambassadors are announced at each SIG-Docs meeting, and in the Kubernetes #sig-docs channel.

Sponsor a new contributor

SIG Docs reviewers can sponsor new contributors.

After a new contributor has successfully submitted 5 substantive pull requests to one or more Kubernetes repositories, they are eligible to apply for membership in the Kubernetes organization. The contributor's membership needs to be backed by two sponsors who are already reviewers.

New docs contributors can request sponsors by asking in the #sig-docs channel on the Kubernetes Slack instance or on the SIG Docs mailing list. If you feel confident about the applicant's work, you volunteer to sponsor them. When they submit their membership application, reply to the application with a "+1" and include details about why you think the applicant is a good fit for membership in the Kubernetes organization.

{{% /capture %}}